Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
It'd be great if you can wait a bit on landing this.
LLVMGetGlobalPassRegistry is called by some projects such as
- https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/compilation/aot_llvm.c#L1514
- https://github.com/numba/llvmlite/blob/main/ffi/initfini.cpp#L15
and we want to determine whether simply commenting out the functions locally can work.
@MaskRay Sure, I'm also waiting on https://github.com/rust-lang/rust/pull/108599 to land first.
Just to put it out there, an alternative to this patch is to retain all these functions and just make them no-ops. Maybe that's the better option in terms of reducing C API breakage?
Thank you! Also, we managed to integrate D144970 but it may be useful to wait for the change to stabilize...
Just to put it out there, an alternative to this patch is to retain all these functions and just make them no-ops. Maybe that's the better option in terms of reducing C API breakage?
Sounds good!
IMO it's better to delete API surfaces (not deleting one off functions since that does cause unnecessary churn, but e.g. everything that revolves around LLVMPassRegistryRef) that don't do anything, else it can be confusing for people to figure out how to use the C API when a good portion of them are no-ops
but yeah short term delaying this patch is fine
Just wanted to check back here whether we're ready to land this patch now or should wait longer?
I think we should be ok to go forward with this. can you put in the description that users can just delete calls to these functions