This is an archive of the discontinued LLVM Phabricator instance.

[2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

Authored by eopXD on Jan 12 2023, 12:51 AM.



The original naming is inaccurate. An RVV intrinsic always comes with
a corresponding policy behavior. When the policy is unspecified for an
intrinsic, its policy behavior should be it's default assumption.

This is the 2nd commit of a patch-set that aims to change the default policy
for RVV intrinsics from TAMU to TAMA.

Please refer to the cover letter in the 1st commit (D141573) for an

Diff Detail

Event Timeline

eopXD created this revision.Jan 12 2023, 12:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2023, 12:51 AM
eopXD requested review of this revision.Jan 12 2023, 12:51 AM
eopXD updated this revision to Diff 488579.Jan 12 2023, 3:13 AM

Bump CI

eopXD updated this revision to Diff 488823.Jan 12 2023, 5:50 PM

Bump CI

eopXD updated this revision to Diff 489286.Jan 14 2023, 10:56 AM

Rebase to latest main.

eopXD retitled this revision from [WIP][2/N][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed to [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed.Jan 15 2023, 7:22 AM
eopXD edited the summary of this revision. (Show Details)
kito-cheng accepted this revision.Jan 16 2023, 10:51 PM

LGTM, this made the code more expressive.

This revision is now accepted and ready to land.Jan 16 2023, 10:51 PM
craig.topper added inline comments.Jan 17 2023, 4:17 PM

Maybe this should default to true, and the constructor that wants false should set it to false? Then you can use = default for the default constructor.


This can be folded into the previous if using &&.

For the record here, IsUnspecified will be removed in D142016, so the un-addressed comment will be resolved by then.

This revision was landed with ongoing or failed builds.Jan 24 2023, 12:05 AM
This revision was automatically updated to reflect the committed changes.