This is an archive of the discontinued LLVM Phabricator instance.

[CMake][LoongArch] Add LoongArch to LLVM_ALL_TARGETS so it is built by default

Authored by SixWeining on Jan 7 2023, 1:35 AM.



This follows the RFC.

Follow-on commits will add appropriate release notes changes etc.

Submit this now and in a minimal form so there is reasonable time before
16.0.0 is branched to resolve any issues arising from e.g. the backend
being exposed on different compiler/sanitizer setups.

The current builder for LoongArch is on the staging area.

Diff Detail

Event Timeline

SixWeining created this revision.Jan 7 2023, 1:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2023, 1:35 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
SixWeining requested review of this revision.Jan 7 2023, 1:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2023, 1:35 AM
rengolin added a subscriber: tstellar.

Thank you for your continued contributions, @SixWeining!

Adding some key people and other target owners, including non-default ones. :)

As discussed in the RFC, the LoongArch target has completed the requirements from the policy.

The only minor issues raised were:

  • We're at the release branch time, so not sure we want this before branch (and risk bug-fixes in dot releases), or after the branch (and wait another 6 months for the target to be "live").
  • The buildbot is only 10 days green (during holidays), while the policy states 3 months.

The target has been stable and is working on the test-suite and a large body of upstream projects for a while, so the probability of serious bugs is minimal. And if there is a bug, it will be only on their target, not the rest of LLVM.

The delay in setting up a buildbot was due to the holiday period and the time it takes to approve and start a builder in Buildbot.

So, I'm happy with whatever the consensus is, but I personally feel they're ready for prime time.

Since this is a big decision, please wait for a number of people to approve. Coordinate with @tstellar about the release branch.

I'll let other people "approve" this, as I've been too involved in the process and don't want to bias the review.


Generally speaking ping is supposed to be once a week. But I ping now in order to have more time to resolve potential compiling or testing issues when the backend was exposed to other bots.

Please take a look. Thanks.

jyknight accepted this revision.Jan 9 2023, 3:18 PM

Hearning no objections, I'll approve this.

This revision is now accepted and ready to land.Jan 9 2023, 3:18 PM
arsenm accepted this revision.Jan 9 2023, 3:19 PM
myhsu accepted this revision.Jan 9 2023, 3:20 PM


MaskRay accepted this revision.Jan 9 2023, 3:57 PM

No objection.

As the community guy who has helped the port a little (by writing some of the codegen myself, porting LLD, putting all of these into distro-building practice and helping troubleshooting things in general), I can confirm the port indeed works on most open-source projects I've checked. Even Linux is close to being buildable. I also experimented with Gentoo stage-building with a recent LLVM snapshot (with my D138135 applied), and bootstrapping is almost done with all problems so far unrelated to the target code.

All in all I'm quite impressed by, and very much grateful to the LoongArch team, and I'll be ready to help should any issue pop up. Thanks very much for all the hard work.

(I'm not approving this though, because I'm also deeply involved in the target's development, despite me not being employed by Loongson nor affiliated in any other way.)

Thanks everyone, this looks like a good state and consensus. @SixWeining please check with @tstellar directly before merging, to make sure you get the right time for the release.

echristo accepted this revision.Jan 10 2023, 10:51 AM

SGTM and congratulations.

tstellar accepted this revision.Jan 10 2023, 3:22 PM


Thanks to all you guys to make things happen!

Expensive check fail I will fix it as soon as possilbe or revert this change.