Page MenuHomePhabricator

myhsu (Min-Yih Hsu)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2017, 5:24 AM (188 w, 2 d)

Recent Activity

Tue, Apr 6

myhsu added a comment to D98537: [M68k] Implement AsmParser.

I agree about the tests. I think the existing tests should be converted to Motorola syntax too (as that seems to be the canonical format), however, I'd argue that we should do those after the assembler & disassembler have landed (in my opinion, fleshing out that functionality is more pressing as it helps us write better tests more easily).

Tue, Apr 6, 10:03 AM · Restricted Project

Mon, Apr 5

myhsu added a comment to D98537: [M68k] Implement AsmParser.

Thanks for this amazing efforts :-) I only have minor formatting comments inlined in the code.
I do have a more high-level question: It seems that you only support Motorola syntax right now, is that true? I'm totally fine if you don't add the MIT syntax in this patch, just want to make sure.
Now a bigger issue is the testing: Presumably we should rewrite all of our existing tests under test/CodeGen/M68k/Encoding into assembly and put it under test/MC/M68k. I believe this can give us a better testing coverage on all of our MC components including AsmParser.
On one hand I don't want to put those migrating changes into this patch because it will easily bloat the size. Not to mention those tests contains binary encoding tests, so if we need migrate both kinds of tests at once. On the other hand, I still need to make sure this patch reaches certain test coverage. Fortunately, the test you provided seemed to cover cases in each instruction classes. Can you add a comment in that test file to note our tests migration plan?

Mon, Apr 5, 2:28 PM · Restricted Project
myhsu committed rG62a94b725cd2: [M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro (authored by glaubitz).
[M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro
Mon, Apr 5, 9:25 AM
myhsu closed D99869: [M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro.
Mon, Apr 5, 9:25 AM · Restricted Project

Sun, Apr 4

myhsu accepted D99869: [M68k] Mark public functions with the LLVM_EXTERNAL_VISIBILITY macro.

LGTM. Thanks
I don't think we need a second LGTM since this is a minor change

Sun, Apr 4, 11:06 PM · Restricted Project
myhsu accepted D98519: [M68k] Add support for Motorola literal syntax to AsmParser.
Sun, Apr 4, 11:00 PM · Restricted Project

Thu, Mar 18

myhsu accepted D98536: [M68k] Convert register Aliases to AltNames.

LGTM

Thu, Mar 18, 8:59 PM · Restricted Project
myhsu accepted D98534: [M68k] Introduce DReg bead.

LGTM

Thu, Mar 18, 8:59 PM · Restricted Project
myhsu added a comment to D98819: [M68k] Replace unknown operand with explicit type.

LGTM after the inlined comment is addressed.

Thu, Mar 18, 8:57 PM · Restricted Project

Wed, Mar 17

myhsu added inline comments to D98534: [M68k] Introduce DReg bead.
Wed, Mar 17, 2:18 PM · Restricted Project
myhsu committed rGeb6b455ba169: [M68k] Forward declare getMCInstrBeads in one place (authored by ricky26).
[M68k] Forward declare getMCInstrBeads in one place
Wed, Mar 17, 1:32 PM
myhsu committed rG2416f2436334: [M68k] Use fixed asm string for MxPseudo instructions (authored by ricky26).
[M68k] Use fixed asm string for MxPseudo instructions
Wed, Mar 17, 1:32 PM
myhsu closed D98533: [M68k] Forward declare getMCInstrBeads in one place.
Wed, Mar 17, 1:32 PM · Restricted Project
myhsu closed D98532: [M68k] Use fixed asm string for MxPseudo instructions.
Wed, Mar 17, 1:32 PM · Restricted Project
myhsu accepted D98532: [M68k] Use fixed asm string for MxPseudo instructions.

LGTM

Wed, Mar 17, 1:27 PM · Restricted Project
myhsu added a comment to D98532: [M68k] Use fixed asm string for MxPseudo instructions.

@myhsu Would we be better off adding non-empty asm strings to all uses?

Do you mean setting non-empty asm string by default on MxInst? I feel like the non-empty string requirement imposed by parser table can help us catch mistakes if we forget to set assembly string for an instruction (in the future), so I'm incline not to do that

I meant just stop MxPseudo taking a default string so all instances include a useful asm comment string.

Wed, Mar 17, 12:00 PM · Restricted Project
myhsu added a comment to D98534: [M68k] Introduce DReg bead.

It acts like a default when decoding (in one of the later patches). The DA bead is still needed since it's used for instructions where it can be either an address or data register.

As it stands, I could rename it but it might be a bit misleading. (Existing cases which don't need a specific register kind would all use AReg.)

Ahh I see

Alternatively, perhaps I could add AReg and enforce that DReg/AReg cannot be combined with DA and keep Reg separate, solely for use with DA. I didn't think of that at the time.

Let's keep your current plan (i.e. only add DReg) for now. Since if Reg and DA are really needed I don't see a good reason to add another AReg if that doesn't really make implementing MCCodeEmitter or AsmParser easier.

Wed, Mar 17, 11:32 AM · Restricted Project
myhsu added a comment to D98536: [M68k] Convert register Aliases to AltNames.

Are you trying to distinguish the sub-register use cases from alternative naming (e.g. a5 & bp)?

Kind of. I was running into a number of cases where I had to handle A7/SP separately (for example). I was worried this was eventually going to lead to significant code duplication and/or errors. AltNames seemed to make the most sense. SP/etc are really only used to make assembly more readable. (For that reason, I actually made SP the default rendering of A7.)

Wed, Mar 17, 11:22 AM · Restricted Project
myhsu accepted D98533: [M68k] Forward declare getMCInstrBeads in one place.

LGTM
BTW, @ricky26 I think you can consider applying for commit access. We don't have a concrete numbers on how many patches you should have before asking for that access, but since you already have some patches accepted and you're working on AsmParser and Disassembler which have non-trivial amount of work, I think that can be a good justification :-)
Please consult this page for how to obtain the access: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access (Yes, we're still using the old-school way on applying this). Optionally you can CC me when you send the email to Chris.

Wed, Mar 17, 10:57 AM · Restricted Project

Tue, Mar 16

myhsu committed rG8ef111222a3d: [M68k] Add more specific operand classes (authored by ricky26).
[M68k] Add more specific operand classes
Tue, Mar 16, 1:39 PM
myhsu committed rG340d558c7789: [M68k] Fixed incorrect `extract-section` command substitution (authored by myhsu).
[M68k] Fixed incorrect `extract-section` command substitution
Tue, Mar 16, 1:39 PM
myhsu closed D98535: [M68k] Add more specific operand classes.
Tue, Mar 16, 1:39 PM · Restricted Project
myhsu closed D98661: [M68k] Fixed incorrect `extract-section` command substitution.
Tue, Mar 16, 1:39 PM · Restricted Project

Mon, Mar 15

myhsu added inline comments to D98536: [M68k] Convert register Aliases to AltNames.
Mon, Mar 15, 3:35 PM · Restricted Project
myhsu added a comment to D98536: [M68k] Convert register Aliases to AltNames.

Are you trying to distinguish the sub-register use cases from alternative naming (e.g. a5 & bp)?

Mon, Mar 15, 3:32 PM · Restricted Project
myhsu added a comment to D98534: [M68k] Introduce DReg bead.

Does the remaining Reg (beads) always mean address register? If that's the case, can we just rename it into AReg?

Mon, Mar 15, 3:08 PM · Restricted Project
myhsu added inline comments to D98533: [M68k] Forward declare getMCInstrBeads in one place.
Mon, Mar 15, 2:53 PM · Restricted Project
myhsu added a comment to D98532: [M68k] Use fixed asm string for MxPseudo instructions.

@myhsu Would we be better off adding non-empty asm strings to all uses?

Mon, Mar 15, 2:47 PM · Restricted Project
myhsu accepted D98535: [M68k] Add more specific operand classes.

LGTM!

Mon, Mar 15, 2:36 PM · Restricted Project
myhsu requested review of D98661: [M68k] Fixed incorrect `extract-section` command substitution.
Mon, Mar 15, 2:00 PM · Restricted Project

Sun, Mar 14

myhsu committed rG9f015757de7c: [M68k] Make M68k TargetMachine use getter function (authored by ricky26).
[M68k] Make M68k TargetMachine use getter function
Sun, Mar 14, 11:54 AM
myhsu committed rG84094fb4fd0b: [M68k] Tidy up some bit shifting during code emission (authored by ricky26).
[M68k] Tidy up some bit shifting during code emission
Sun, Mar 14, 11:54 AM
myhsu closed D98527: [M68k] Tidy up some bit shifting during code emission.
Sun, Mar 14, 11:54 AM · Restricted Project
myhsu closed D98517: [M68k] Make M68k TargetMachine use getter function.
Sun, Mar 14, 11:54 AM · Restricted Project
myhsu accepted D98517: [M68k] Make M68k TargetMachine use getter function.

LGTM, thanks

Sun, Mar 14, 11:40 AM · Restricted Project
myhsu committed rG6475ddb1d898: [M68k] Fix extract-section.py under Python 3 (authored by ricky26).
[M68k] Fix extract-section.py under Python 3
Sun, Mar 14, 11:39 AM
myhsu closed D98428: [M68k] Fix extract-section.py under Python 3.
Sun, Mar 14, 11:39 AM · Restricted Project

Mar 11 2021

myhsu added a comment to D98428: [M68k] Fix extract-section.py under Python 3.

If you don't have commit access I can commit on your behave

Mar 11 2021, 9:33 AM · Restricted Project
myhsu accepted D98428: [M68k] Fix extract-section.py under Python 3.

yes you're right about this, thanks :-)
LGTM

Mar 11 2021, 9:21 AM · Restricted Project

Mar 9 2021

myhsu committed rZORGadad9548325b: [M68k] Add new worker debian-akiko-m68k for Linux 32-bit M68k (authored by myhsu).
[M68k] Add new worker debian-akiko-m68k for Linux 32-bit M68k
Mar 9 2021, 11:15 AM
myhsu closed D91031: Add new worker debian-akiko-m68k for Linux 32-bit M68k.
Mar 9 2021, 11:15 AM

Mar 8 2021

myhsu committed rG5509748f2ce5: [cfe][driver][M68k](8/8) Clang driver support (authored by myhsu).
[cfe][driver][M68k](8/8) Clang driver support
Mar 8 2021, 12:34 PM
myhsu committed rG5eb7a5814a5c: [cfe][M68k](7/8) Clang basic support (authored by myhsu).
[cfe][M68k](7/8) Clang basic support
Mar 8 2021, 12:34 PM
myhsu committed rGc23a780c306c: [M68k][test](6/8) Add all of the tests (authored by myhsu).
[M68k][test](6/8) Add all of the tests
Mar 8 2021, 12:34 PM
myhsu committed rG5ac19e0acf86: [M68k](5/8) Target-specific lowering (authored by myhsu).
[M68k](5/8) Target-specific lowering
Mar 8 2021, 12:34 PM
myhsu committed rG8dddc15297f1: [M68k](4/8) MC layer and object file support (authored by myhsu).
[M68k](4/8) MC layer and object file support
Mar 8 2021, 12:34 PM
myhsu closed D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Mar 8 2021, 12:34 PM · Restricted Project
myhsu committed rGbec7b166923b: [M68k](3/8) Skeleton and target description files (authored by myhsu).
[M68k](3/8) Skeleton and target description files
Mar 8 2021, 12:34 PM
myhsu closed D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.
Mar 8 2021, 12:34 PM · Restricted Project
myhsu closed D88392: [M68k] (Patch 6/8) IR Tests.
Mar 8 2021, 12:34 PM · Restricted Project
myhsu committed rG503343191e12: [M68k][TableGen](1/8) TableGen related changes (authored by myhsu).
[M68k][TableGen](1/8) TableGen related changes
Mar 8 2021, 12:34 PM
myhsu committed rG6dcc325ce045: [M68k][MIR](2/8) Changes in the target-independent MIR part (authored by myhsu).
[M68k][MIR](2/8) Changes in the target-independent MIR part
Mar 8 2021, 12:34 PM
myhsu closed D88391: [M68k] (Patch 5/8) Target lowering.
Mar 8 2021, 12:34 PM · Restricted Project
myhsu closed D88390: [M68k] (Patch 4/8) MC layer and object file support.
Mar 8 2021, 12:34 PM · Restricted Project
myhsu committed rGa3fee3993a09: [M68k][CODE_OWNERS](0/8) Add code owner for the M68k target (authored by myhsu).
[M68k][CODE_OWNERS](0/8) Add code owner for the M68k target
Mar 8 2021, 12:34 PM
myhsu closed D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.
Mar 8 2021, 12:34 PM · Restricted Project
myhsu closed D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part.
Mar 8 2021, 12:33 PM · Restricted Project
myhsu closed D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.
Mar 8 2021, 12:33 PM · Restricted Project
myhsu closed D95315: [CODE_OWNERS][M68k] (Patch 0/8) Add code owner for the M68k target.
Mar 8 2021, 12:33 PM · Restricted Project

Mar 7 2021

myhsu added a comment to D88391: [M68k] (Patch 5/8) Target lowering.

Woohoo, finally \o/. Min: Time to push, I guess :D :D :D.

Mar 7 2021, 4:41 PM · Restricted Project
myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.

[NFC] Fix formatting

Mar 7 2021, 10:48 AM · Restricted Project
myhsu updated the diff for D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.

[NFC] Fix formatting

Mar 7 2021, 10:47 AM · Restricted Project

Mar 4 2021

myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.

[NFC] Fix formatting

Mar 4 2021, 10:00 PM · Restricted Project
myhsu updated the diff for D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.

[NFC] Fix formatting and indents

Mar 4 2021, 9:59 PM · Restricted Project

Mar 2 2021

myhsu added inline comments to D88392: [M68k] (Patch 6/8) IR Tests.
Mar 2 2021, 4:18 PM · Restricted Project
myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.

[NFC] Remove all comments generated by update_llc_test_checks.py in MIR files

Mar 2 2021, 4:17 PM · Restricted Project

Feb 28 2021

myhsu added inline comments to D88392: [M68k] (Patch 6/8) IR Tests.
Feb 28 2021, 10:31 PM · Restricted Project
myhsu updated the diff for D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.

[NFC] Update FileCheck prefix

Feb 28 2021, 10:27 PM · Restricted Project
myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.

[NFC] Addressed feedbacks

Feb 28 2021, 10:26 PM · Restricted Project
myhsu added inline comments to D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.
Feb 28 2021, 10:23 PM · Restricted Project
myhsu updated the diff for D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.
  • [NFC] Addressed feedbacks
Feb 28 2021, 10:23 PM · Restricted Project

Feb 25 2021

myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.

[NFC] Combine README of test/CodeGen/M68k with the one in test/CodeGen/M68k/Encoding

Feb 25 2021, 3:50 PM · Restricted Project
myhsu added inline comments to D88392: [M68k] (Patch 6/8) IR Tests.
Feb 25 2021, 3:45 PM · Restricted Project
myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.
  • Addressed feedbacks
Feb 25 2021, 3:45 PM · Restricted Project
myhsu added inline comments to D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
Feb 25 2021, 2:22 PM · Restricted Project
myhsu updated the diff for D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k.
  • Addressed feedbacks
Feb 25 2021, 2:21 PM · Restricted Project
myhsu added inline comments to D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.
Feb 25 2021, 2:21 PM · Restricted Project
myhsu updated the diff for D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.
  • [NFC] Addressed feedbacks
Feb 25 2021, 2:20 PM · Restricted Project
myhsu added inline comments to D88390: [M68k] (Patch 4/8) MC layer and object file support.
Feb 25 2021, 2:20 PM · Restricted Project
myhsu updated the diff for D88390: [M68k] (Patch 4/8) MC layer and object file support.
  • Addressed feedbacks
Feb 25 2021, 2:19 PM · Restricted Project
myhsu added inline comments to D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.
Feb 25 2021, 2:18 PM · Restricted Project
myhsu updated the diff for D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.
  • Addressed feedbacks
Feb 25 2021, 2:18 PM · Restricted Project
myhsu updated the diff for D88386: [MIR][M68K] (Patch 2/8): Changes on Target-independent MIR part.
  • [NFC] Addressed feedbacks
Feb 25 2021, 2:16 PM · Restricted Project
myhsu updated the diff for D88385: [TableGen][M68K] (Patch 1/8) Utilities for complex instruction addressing modes: CodeBeads and logical operand helper functions.
  • Addressed feedbacks
Feb 25 2021, 2:15 PM · Restricted Project

Feb 17 2021

myhsu added inline comments to D88392: [M68k] (Patch 6/8) IR Tests.
Feb 17 2021, 11:58 PM · Restricted Project

Feb 14 2021

myhsu added a comment to D88392: [M68k] (Patch 6/8) IR Tests.

As I've said before, please use update_llc_test_checks.py. Manually-maintained CHECK lines are a complete pain when making tree-wide changes.

Feb 14 2021, 10:58 PM · Restricted Project
myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.
  • Use update_llc_test_checks.py to manage all the assembly tests
Feb 14 2021, 10:56 PM · Restricted Project
myhsu added inline comments to D88391: [M68k] (Patch 5/8) Target lowering.
Feb 14 2021, 10:49 PM · Restricted Project
myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.
  • Addressed feedbacks
Feb 14 2021, 10:48 PM · Restricted Project
myhsu updated the diff for D88390: [M68k] (Patch 4/8) MC layer and object file support.
  • [NFC] Addressed some of the feedbacks
Feb 14 2021, 10:47 PM · Restricted Project
myhsu updated the diff for D88389: [M68k] (Patch 3/8) Basic infrastructures and target description files.
  • [NFC] Addressed feedbacks
Feb 14 2021, 10:46 PM · Restricted Project

Feb 12 2021

myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.
  • [NFC] Remove reset of the x00 prefixes
Feb 12 2021, 12:26 PM · Restricted Project
myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.
  • [NFC] Rename CHECK prefixes
    • Replace any standalone x00 prefix with normal CHECK
    • Capitalize custom prefix
Feb 12 2021, 12:18 PM · Restricted Project
myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.
  • [NFC] Addressed most of the feedbacks
Feb 12 2021, 12:16 PM · Restricted Project

Feb 3 2021

myhsu added inline comments to D88391: [M68k] (Patch 5/8) Target lowering.
Feb 3 2021, 9:11 PM · Restricted Project
myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.
  • Addressed feedbacks
Feb 3 2021, 9:11 PM · Restricted Project

Feb 1 2021

myhsu updated the diff for D88392: [M68k] (Patch 6/8) IR Tests.
  • Reflecting changes from D88391 on optimizing multiplications
Feb 1 2021, 10:54 PM · Restricted Project
myhsu updated the diff for D88391: [M68k] (Patch 5/8) Target lowering.
  • Addressed feedbacks
    • Use TargetLowering callback to optimize multiplications instead of doing manually
Feb 1 2021, 10:52 PM · Restricted Project
myhsu added inline comments to D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.
Feb 1 2021, 2:31 PM · Restricted Project
myhsu updated the diff for D88393: [cfe][M68k] (Patch 7/8) Basic Clang support.
  • Addressed feedback
    • Remove redundant target macro definitions
Feb 1 2021, 2:31 PM · Restricted Project