- User Since
- Sep 1 2017, 5:24 AM (135 w, 3 d)
Dec 21 2019
Dec 20 2019
ORC, specifically ORCv2. I did see deregistration called in LegacyRTDyldObjectLinkingLayer, but well, it’s legacy v1. I didn’t see any deregistration in v2.
Looking at the code again, if you're using ORC this should be handled automatically. If you're using MCJIT it is (unfortunately) contract that you're responsible for calling this yourself. It would be safe to add this call to SectionMemoryManager as redundant calls (from existing clients) are no-ops, but it introduces a hazard: Anyone who brings up a JIT successfully with SectionMemoryManager is suddenly going to discover that their code fails when they try to use a custom memory manager.
Dec 18 2019
Oct 19 2019
That would be great. Thank you very much
Oct 16 2019
Ping on this review.
Also, the compiler for the Pony Programming Language bumped into the same bug. Since MemCpyOpt will run by default in O3, it would be a little bit hard for a downstream user to avoid this bug without changing the LLVM source tree.
Aug 21 2019
Aug 11 2019
Aug 10 2019
Jul 31 2019
Jul 4 2019
Is there any plan on supporting GraphTraits in this patch? I understand that sometimes it probably will be more suitable for derived class of DirectedGraph to implement GraphTraits. But I see no problem on providing a basic implementation of GraphTraits for DirectedGraph here.
Jun 17 2019
Thanks for the review. I don't have commit permission, can you help me to commit?
Oct 5 2017
Remove 'FindPhiPredForUsedInBlock' function
Rebase to master
Oct 4 2017
Oct 3 2017
Oct 2 2017
Fix things mentioned in the inline comments
Sep 22 2017
Temporarily revert to version before applying clang-format
Sep 21 2017
Sep 18 2017
It turn out that the DomTree updating issue has actually been fixed in D32308
The unittest also pass after I applying that change
Sorry I didn't work incrementally on master branch at first place