Page MenuHomePhabricator

myhsu (Min-Yih Hsu)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 1 2017, 5:24 AM (135 w, 3 d)

Recent Activity

Dec 21 2019

myhsu closed D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

Actually, are you seeing this bug on ORC? Or just on MCJIT?

ORC, specifically ORCv2.

Oh -- That's an ORCv2 bug. I have fixed that in 9f4f237e29e7. Would you be able to apply that patch to your branch and see if it fixes your issue?

Dec 21 2019, 12:24 AM · Restricted Project

Dec 20 2019

myhsu added a comment to D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

Actually, are you seeing this bug on ORC? Or just on MCJIT?

ORC, specifically ORCv2. I did see deregistration called in LegacyRTDyldObjectLinkingLayer, but well, it’s legacy v1. I didn’t see any deregistration in v2.

Looking at the code again, if you're using ORC this should be handled automatically. If you're using MCJIT it is (unfortunately) contract that you're responsible for calling this yourself. It would be safe to add this call to SectionMemoryManager as redundant calls (from existing clients) are no-ops, but it introduces a hazard: Anyone who brings up a JIT successfully with SectionMemoryManager is suddenly going to discover that their code fails when they try to use a custom memory manager.

Dec 20 2019, 7:30 PM · Restricted Project
myhsu added a comment to D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

@myhsu Now that you have three accepted commits to LLVM, you can ask for commit access! Follow these instructions

Dec 20 2019, 5:01 PM · Restricted Project
myhsu added a comment to D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.

Hi myhsu -- This looks good to me. Do you have commit access? If so please feel free to commit. If not just let me know and I will commit on your behalf.

Dec 20 2019, 3:46 AM · Restricted Project

Dec 18 2019

myhsu created D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.
Dec 18 2019, 5:59 PM · Restricted Project
myhsu updated the summary of D71683: [ORC][EH] Deregister EH frames in MemoryManager dtor.
Dec 18 2019, 5:59 PM · Restricted Project

Oct 19 2019

myhsu added a comment to D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values.

@myhsu do you need me to land this for you? I presume you don't yet have commit privileges.

That would be great. Thank you very much

Oct 19 2019, 1:50 PM · Restricted Project

Oct 16 2019

myhsu updated the summary of D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values.
Oct 16 2019, 9:41 AM · Restricted Project
myhsu added a comment to D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values.

Ping on this review.
Also, the compiler for the Pony Programming Language bumped into the same bug. Since MemCpyOpt will run by default in O3, it would be a little bit hard for a downstream user to avoid this bug without changing the LLVM source tree.

Oct 16 2019, 9:41 AM · Restricted Project

Aug 21 2019

myhsu added reviewers for D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values: dneilson, t.p.northover, lattner.
Aug 21 2019, 7:27 PM · Restricted Project

Aug 11 2019

myhsu updated the summary of D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values.
Aug 11 2019, 7:08 AM · Restricted Project
myhsu updated the summary of D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values.
Aug 11 2019, 7:07 AM · Restricted Project

Aug 10 2019

myhsu created D66060: [MemCpyOpt] Fixing Incorrect Code Motion while Handling Aggregate Type Values.
Aug 10 2019, 9:42 PM · Restricted Project

Jul 31 2019

myhsu added inline comments to D65350: [DDG] Data Dependence Graph Basics.
Jul 31 2019, 8:50 AM · Restricted Project

Jul 4 2019

myhsu added a comment to D64088: [DDG] DirectedGraph as a base class for various dependence graphs such as DDG and PDG..

Is there any plan on supporting GraphTraits in this patch? I understand that sometimes it probably will be more suitable for derived class of DirectedGraph to implement GraphTraits. But I see no problem on providing a basic implementation of GraphTraits for DirectedGraph here.

Jul 4 2019, 7:26 AM · Restricted Project

Jun 17 2019

myhsu added a comment to D63449: [GN] Generation failure caused by trailing space in file name.

Thanks for the review. I don't have commit permission, can you help me to commit?

Jun 17 2019, 10:10 PM · Restricted Project
myhsu created D63449: [GN] Generation failure caused by trailing space in file name.
Jun 17 2019, 11:05 AM · Restricted Project

Oct 5 2017

myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

Remove 'FindPhiPredForUsedInBlock' function

Oct 5 2017, 6:16 PM
myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

Rebase to master

Oct 5 2017, 8:28 AM
myhsu added a comment to D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

@chandlerc @kuhar
I'm not pretty familiar the procedure yet, could someone help me commit the patch or merge it?
Thanks

If you have commit access, you can go ahead and submit the patch. Otherwise, I can submit it for you.
Please take a look here: Obtaining Commit Access.

Oct 5 2017, 7:58 AM
myhsu added a comment to D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

@chandlerc @kuhar
I'm not pretty familiar the procedure yet, could someone help me commit the patch or merge it?
Thanks

Oct 5 2017, 5:22 AM

Oct 4 2017

myhsu added a comment to D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

Other than the two minor nits, the patch looks good to me.

Oct 4 2017, 5:16 AM
myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

Fix comment

Oct 4 2017, 5:14 AM

Oct 3 2017

myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

@kuhar
Fix typos

Oct 3 2017, 2:13 PM

Oct 2 2017

myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

Fix typo

Oct 2 2017, 10:34 AM
myhsu added inline comments to D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.
Oct 2 2017, 10:29 AM
myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

@kuhar
Fix things mentioned in the inline comments

Oct 2 2017, 10:25 AM

Sep 22 2017

myhsu updated the summary of D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.
Sep 22 2017, 5:23 AM
myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

@chandlerc
Temporarily revert to version before applying clang-format

Sep 22 2017, 5:20 AM

Sep 21 2017

myhsu added a comment to D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

@kuhar @dberlin
Could you help reviewing my update?
Thanks : )

Sep 21 2017, 12:48 PM

Sep 18 2017

myhsu added a comment to D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.

It turn out that the DomTree updating issue has actually been fixed in D32308
The unittest also pass after I applying that change
Sorry I didn't work incrementally on master branch at first place

Sep 18 2017, 7:51 AM
myhsu updated the diff for D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.
Sep 18 2017, 7:46 AM

Sep 15 2017

myhsu created D37902: [CodeExtractor] Fix multiple bugs under certain shape of extracted region.
Sep 15 2017, 7:06 AM