- User Since
- Jul 8 2012, 1:04 PM (393 w, 1 d)
Nov 7 2019
Oct 30 2019
In general LGTM. But will you please correct the test names, so I can commit on your behalf?
@joanlluch Yes, having the version with amount does make sense as target may know how to efficiently lower some of the shifts with crazy tricks. And in the view of this patch it's easier to preserve the sequences rather than match and undo later. I guess for MSP430 we'd need to allow 9 as possible "special" shift value, as select is lowered to 3 instructions (test + branch + mov of some kind) and removing branch overall has some additional value like allowing more code folding / reducing register pressure.
Oct 24 2019
Oct 22 2019
Oct 19 2019
Oct 16 2019
If they are not necessary, then it would make sense to undo them. At least partially.
@joanlluch There are two things here. We understand that there might be some out-of-tree targets that would benefit from changes in the mainline. However, it is still important to add tests that utilize mainline targets as this ensures that the proposed changes won't e.g. break during some refactoring, etc. So, using MSP430 (probably the smallest) / AVR is perfectly fine for tests, etc.!
The MSP430 changes / overall direction looks extremely useful to me. We just need to ensure everything is done properly. This is exactly what @spatel proposed.
Sep 25 2019
Aug 31 2019
Aug 13 2019
Jul 8 2019
Jun 24 2019
The changes are pretty straightforward :)
May 31 2019
Note that on AArch64, there is no equivalent to x86's use of "al" for varargs calls.
Correct. Everywhere else we're using the same ABI regardless of this flag.
May 30 2019
@efriedma The LangRef states that "This attributes disables implicit floating-point instructions". I believe that the definition of "implicit" is very vague here. And clang cmdline documentation does not explain "-mno-implicit-float" at all. What you'd suggest? :)
May 29 2019
Apr 11 2019
How many such switches are seen in e.g. LLVM test suite? Could you please share the size reduction statistics?
Apr 8 2019
Mar 30 2019
Well, what's the overall motivation of all these changes? There are no multiple threads, etc. on msp430. I believe instead of lowering to libcalls we could simply "drop" atomic.
Mar 18 2019
Feb 26 2019
@wuzish Do you really wanted on comment on commit that is more than 10 years old? Have you looked over the current ToT?
Feb 17 2019
Feb 16 2019
Feb 13 2019
Feb 12 2019
Feb 5 2019
Paul, sorry, I completely missed this review request for some reason... Please rebase and commit, thanks!
Feb 2 2019
Jan 27 2019
Jan 25 2019
Please make sure the test passes.
The patch was reverted – the test requires fully configured msp430 configuration and therefore was breaking the bots.
Patch fails to apply. Please rebase.
This breaks CodeGen/MSP430/mult-alt-generic-msp430.ll :)
Jan 17 2019
Jan 16 2019
Jan 15 2019
Committed as r351233, thanks!