Page MenuHomePhabricator

asl (Anton Korobeynikov)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2012, 1:04 PM (432 w, 1 d)
Roles
Administrator

Recent Activity

Fri, Oct 9

asl added a comment to D89142: llvmbuildectomy.

Can we fold all these LLVMBuild.cmake files into the corresponding cmakelists.txt?

Fri, Oct 9, 10:00 AM · Restricted Project

Aug 9 2020

asl added inline comments to D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.
Aug 9 2020, 12:52 PM · Restricted Project

Aug 7 2020

asl requested changes to D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.

Will you please switch to iterators here?

Aug 7 2020, 2:52 AM · Restricted Project

Jul 8 2020

asl accepted D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.

LGTM, thanks!

Jul 8 2020, 2:25 PM · Restricted Project
asl added inline comments to D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.
Jul 8 2020, 5:26 AM · Restricted Project

Jun 30 2020

asl committed rG19e75717eff2: [MSP430] Declare comparison LibCalls as returning i16 instead of i32 (authored by atrosinenko).
[MSP430] Declare comparison LibCalls as returning i16 instead of i32
Jun 30 2020, 1:35 AM
asl committed rG0ee439b705e8: [builtins] Change si_int to int in some helper declarations (authored by atrosinenko).
[builtins] Change si_int to int in some helper declarations
Jun 30 2020, 1:35 AM
asl closed D81285: [builtins] Change si_int to int in some helper declarations.
Jun 30 2020, 1:35 AM · Restricted Project
asl closed D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.
Jun 30 2020, 1:35 AM · Restricted Project

Jun 26 2020

asl committed rGcb56fa2196c5: [MSP430] Update register names (authored by atrosinenko).
[MSP430] Update register names
Jun 26 2020, 5:58 AM
asl committed rGa4e8f7fe3f38: [builtins] Improve compatibility with 16 bit targets (authored by atrosinenko).
[builtins] Improve compatibility with 16 bit targets
Jun 26 2020, 5:58 AM
asl closed D82184: [MSP430] Update register names.
Jun 26 2020, 5:58 AM · Restricted Project, Restricted Project
asl closed D81408: [builtins] Improve compatibility with 16 bit targets.
Jun 26 2020, 5:57 AM · Restricted Project
asl accepted D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.
Jun 26 2020, 5:56 AM · Restricted Project
asl added inline comments to D82557: [MSP430][NFC] Remove redundant condition.
Jun 26 2020, 5:26 AM · Restricted Project

Jun 25 2020

asl committed rGa931ec7ca0ee: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list (authored by atrosinenko).
[builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list
Jun 25 2020, 1:06 PM
asl closed D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.
Jun 25 2020, 1:05 PM · Restricted Project
asl requested changes to D82557: [MSP430][NFC] Remove redundant condition.
Jun 25 2020, 1:05 PM · Restricted Project

Jun 22 2020

asl committed rG16cc759ebd56: Attempt to unbreak the test introduced in 359fae6eb094 on Windows (authored by asl).
Attempt to unbreak the test introduced in 359fae6eb094 on Windows
Jun 22 2020, 4:49 AM
asl committed rG6cb80fbe4052: Revert "[MSP430] Update register names" (authored by asl).
Revert "[MSP430] Update register names"
Jun 22 2020, 3:44 AM
asl added a reverting change for rG8f6620f66303: [MSP430] Update register names: rG6cb80fbe4052: Revert "[MSP430] Update register names".
Jun 22 2020, 3:44 AM
asl committed rG8f6620f66303: [MSP430] Update register names (authored by atrosinenko).
[MSP430] Update register names
Jun 22 2020, 3:44 AM
asl closed D82184: [MSP430] Update register names.
Jun 22 2020, 3:43 AM · Restricted Project, Restricted Project
asl committed rGa5bd75aab861: [MSP430] Enable some basic support for debug information (authored by atrosinenko).
[MSP430] Enable some basic support for debug information
Jun 22 2020, 3:43 AM
asl committed rG359fae6eb094: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data (authored by atrosinenko).
[DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data
Jun 22 2020, 3:43 AM
asl closed D81488: [MSP430] Enable some basic support for debug information.
Jun 22 2020, 3:43 AM · Restricted Project
asl closed D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data.
Jun 22 2020, 3:43 AM · Restricted Project
asl accepted D81488: [MSP430] Enable some basic support for debug information.

LGTM, thanks!

Jun 22 2020, 3:43 AM · Restricted Project
asl accepted D82184: [MSP430] Update register names.

Looks good to me! FP was an old register name from mspgcc time. MSP430 EABI does not use frame pointer at all (seems to be a bug in the ABI, as I do not understand how we could support VLAs or alloca's in this case).

Jun 22 2020, 3:10 AM · Restricted Project, Restricted Project

Jun 18 2020

asl added inline comments to D81515: [llvm] Release-mode ML InlineAdvisor.
Jun 18 2020, 4:52 AM · Restricted Project

Jun 17 2020

asl added inline comments to D81515: [llvm] Release-mode ML InlineAdvisor.
Jun 17 2020, 2:34 PM · Restricted Project
asl added inline comments to D77752: [llvm] Machine Learned policy for inlining -Oz.
Jun 17 2020, 4:16 AM · Restricted Project

Feb 27 2020

asl committed rG7b08aa9549e0: Test commit: update my email (authored by asl).
Test commit: update my email
Feb 27 2020, 4:02 AM

Nov 7 2019

asl accepted D69975: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (3) (baseline tests).
Nov 7 2019, 11:25 PM · Restricted Project

Oct 30 2019

asl accepted D69609: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (Baseline).

In general LGTM. But will you please correct the test names, so I can commit on your behalf?

Oct 30 2019, 11:22 AM · Restricted Project
asl added a comment to D69120: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (2/2).

@joanlluch Yes, having the version with amount does make sense as target may know how to efficiently lower some of the shifts with crazy tricks. And in the view of this patch it's easier to preserve the sequences rather than match and undo later. I guess for MSP430 we'd need to allow 9 as possible "special" shift value, as select is lowered to 3 instructions (test + branch + mov of some kind) and removing branch overall has some additional value like allowing more code folding / reducing register pressure.

Oct 30 2019, 11:21 AM · Restricted Project

Oct 24 2019

asl added inline comments to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
Oct 24 2019, 10:00 AM · Restricted Project
asl added inline comments to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
Oct 24 2019, 8:48 AM · Restricted Project

Oct 22 2019

asl added inline comments to D69103: Backend for NEC SX-Aurora.
Oct 22 2019, 5:31 PM · Restricted Project, Restricted Project

Oct 19 2019

asl added a comment to D69116: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (1/2).

LGTM, thanks!

Oct 19 2019, 10:06 AM · Restricted Project

Oct 16 2019

asl added a comment to D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine.

If they are not necessary, then it would make sense to undo them. At least partially.

Oct 16 2019, 3:10 AM · Restricted Project
asl added a comment to D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine.

@joanlluch There are two things here. We understand that there might be some out-of-tree targets that would benefit from changes in the mainline. However, it is still important to add tests that utilize mainline targets as this ensures that the proposed changes won't e.g. break during some refactoring, etc. So, using MSP430 (probably the smallest) / AVR is perfectly fine for tests, etc.!

Oct 16 2019, 2:32 AM · Restricted Project
asl added a comment to D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine.

The MSP430 changes / overall direction looks extremely useful to me. We just need to ensure everything is done properly. This is exactly what @spatel proposed.

Oct 16 2019, 1:33 AM · Restricted Project

Sep 25 2019

asl accepted D67313: [MSP430] Allow msp430_intrcc functions to not have interrupt attribute..

LGTM, thanks!

Sep 25 2019, 8:34 AM · Restricted Project

Aug 31 2019

asl committed rL370567: Add username.
Add username
Aug 31 2019, 2:06 AM

Aug 13 2019

asl removed 1 auditor(s) for rG3a6bdf8f82c8: Remove EnhancedBugReport and RangedBugReport - pull all the extra functionality…: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG685fbda217ee: [GlobalISel] Make LegalizerInfo accessible in LegalizerHelper: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG202d660af100: Fix -Wdocumentation typo. NFCI.: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rGb9bd6ebe1dca: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting…: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed a project from rL368639: Removed builders: llvm-clang-lld-x86_64-debian-fast, ubuntu-gcc7.1-werror.: debug-info.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG2c69b1377cb6: Merging r368581: --------------------------------------------------------------…: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG97e6d088e946: Merging r368517, r368518, r368519, and r368554:: lisa6jones6.
Aug 13 2019, 2:16 PM

Jul 8 2019

asl committed rL365389: JetBrains actually signed the agreement.
JetBrains actually signed the agreement
Jul 8 2019, 2:18 PM

Jun 24 2019

asl accepted D23664: [AAP] (1) Add AAP target triple.

The changes are pretty straightforward :)

Jun 24 2019, 5:51 AM

May 31 2019

asl added a comment to D62639: Fix ABI breakage with noimplicitfloat and varargs functions.

Note that on AArch64, there is no equivalent to x86's use of "al" for varargs calls.

Correct. Everywhere else we're using the same ABI regardless of this flag.

May 31 2019, 6:24 PM · Restricted Project

May 30 2019

asl updated the summary of D62639: Fix ABI breakage with noimplicitfloat and varargs functions.
May 30 2019, 9:31 PM · Restricted Project
asl added a comment to D62639: Fix ABI breakage with noimplicitfloat and varargs functions.

@efriedma The LangRef states that "This attributes disables implicit floating-point instructions". I believe that the definition of "implicit" is very vague here. And clang cmdline documentation does not explain "-mno-implicit-float" at all. What you'd suggest? :)

May 30 2019, 9:31 PM · Restricted Project
asl resigned from D62571: Implement codegen for MSVC unions with reference members.
May 30 2019, 12:34 PM · Restricted Project

May 29 2019

asl created D62639: Fix ABI breakage with noimplicitfloat and varargs functions.
May 29 2019, 7:01 PM · Restricted Project

Apr 11 2019

asl added a comment to D60584: Conversion of a switch table to a bitmap is not profitable for -Os and -Oz compilation.

How many such switches are seen in e.g. LLVM test suite? Could you please share the size reduction statistics?

Apr 11 2019, 3:26 PM

Apr 8 2019

asl committed rL357888: Remove the project.
Remove the project
Apr 8 2019, 1:03 AM

Mar 30 2019

asl added a comment to D60033: [MSP430] Expand Atomic nodes.

Well, what's the overall motivation of all these changes? There are no multiple threads, etc. on msp430. I believe instead of lowering to libcalls we could simply "drop" atomic.

Mar 30 2019, 12:48 PM · Restricted Project

Mar 18 2019

asl edited reviewers for D59460: [MSP430] Use generic operand printer for modifiers, added: mskvortsov; removed: nlewycky.
Mar 18 2019, 5:57 AM · Restricted Project

Feb 26 2019

asl added a comment to rG66b91e66ecc3: Implement necessary bits for flt_rounds gcc builtin. Codegen bits and llvm-gcc….

@wuzish Do you really wanted on comment on commit that is more than 10 years old? Have you looked over the current ToT?

Feb 26 2019, 2:15 AM

Feb 17 2019

asl committed rL354230: Clarify keynote authors.
Clarify keynote authors
Feb 17 2019, 10:46 AM

Feb 16 2019

asl updated subscribers of D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Feb 16 2019, 10:36 AM · Restricted Project
asl updated subscribers of rGf6e77311502c: Fix some tests I broke in r354190.
Feb 16 2019, 10:36 AM
asl updated subscribers of D57938: [WebAssembly] Update MC for bulk memory.
Feb 16 2019, 10:35 AM · Restricted Project
asl updated subscribers of D58319: [WebAssembly] Remove getBottom function from CFGStackify (NFC).
Feb 16 2019, 10:35 AM · Restricted Project
asl updated subscribers of rGeac7c3ffaf5d: [Sema] Diagnose floating point conversions based on target semantics.
Feb 16 2019, 10:35 AM
asl removed 1 auditor(s) for rG358f99c7fe27: [clang-tidy] Delete obsolete objc-property-declaration options ✂️: ham999221.
Feb 16 2019, 10:34 AM

Feb 13 2019

asl committed rL353930: Fix authors in outline as well.
Fix authors in outline as well
Feb 13 2019, 1:35 AM
asl committed rL353929: Add more authors.
Add more authors
Feb 13 2019, 1:34 AM

Feb 12 2019

asl committed rGa39eb26bd3f1: Disable PIC/PIE for MSP430 target (authored by asl).
Disable PIC/PIE for MSP430 target
Feb 12 2019, 12:46 PM
asl committed rC353877: Disable PIC/PIE for MSP430 target.
Disable PIC/PIE for MSP430 target
Feb 12 2019, 12:45 PM
asl committed rL353877: Disable PIC/PIE for MSP430 target.
Disable PIC/PIE for MSP430 target
Feb 12 2019, 12:45 PM
asl closed D56927: Disable PIC/PIE for MSP430 target.
Feb 12 2019, 12:45 PM · Restricted Project, Restricted Project
asl accepted D56927: Disable PIC/PIE for MSP430 target.
Feb 12 2019, 12:45 PM · Restricted Project, Restricted Project

Feb 5 2019

asl committed rGf1f897cac239: Do not use frame pointer by default for MSP430 (authored by asl).
Do not use frame pointer by default for MSP430
Feb 5 2019, 12:16 PM
asl committed rC353212: Do not use frame pointer by default for MSP430.
Do not use frame pointer by default for MSP430
Feb 5 2019, 12:16 PM
asl committed rL353212: Do not use frame pointer by default for MSP430.
Do not use frame pointer by default for MSP430
Feb 5 2019, 12:16 PM
asl closed D56925: Do not use frame pointer by default for MSP430.
Feb 5 2019, 12:16 PM · Restricted Project, Restricted Project
asl accepted D57333: Initial GSOC 2019 project.

Paul, sorry, I completely missed this review request for some reason... Please rebase and commit, thanks!

Feb 5 2019, 12:16 PM
asl accepted D56925: Do not use frame pointer by default for MSP430.

Ok now

Feb 5 2019, 12:16 PM · Restricted Project, Restricted Project
asl committed rGb26134bf9213: Enable integrated assembler on MSP430 by default. (authored by asl).
Enable integrated assembler on MSP430 by default.
Feb 5 2019, 10:02 AM
asl committed rL353192: Enable integrated assembler on MSP430 by default..
Enable integrated assembler on MSP430 by default.
Feb 5 2019, 10:01 AM
asl closed D56787: [MSP430] Set UseIntegratedAssembler.
Feb 5 2019, 10:01 AM · Restricted Project
asl accepted D56787: [MSP430] Set UseIntegratedAssembler.

LGTM now

Feb 5 2019, 10:00 AM · Restricted Project

Feb 2 2019

asl committed rL352962: Add GSoC 2019 stub.
Add GSoC 2019 stub
Feb 2 2019, 10:03 AM

Jan 27 2019

asl accepted D57290: [www] Remove implemented Clang SA projects.

LGTM

Jan 27 2019, 1:42 PM

Jan 25 2019

asl requested changes to D56927: Disable PIC/PIE for MSP430 target.

Please make sure the test passes.

Jan 25 2019, 2:37 AM · Restricted Project, Restricted Project
asl reopened D56927: Disable PIC/PIE for MSP430 target.

The patch was reverted – the test requires fully configured msp430 configuration and therefore was breaking the bots.

Jan 25 2019, 2:37 AM · Restricted Project, Restricted Project
asl committed rC352186: Revert r352181 as it's breaking the bots.
Revert r352181 as it's breaking the bots
Jan 25 2019, 2:35 AM
asl committed rL352186: Revert r352181 as it's breaking the bots.
Revert r352181 as it's breaking the bots
Jan 25 2019, 2:35 AM
asl committed rL352181: Disable PIC/PIE for MSP430 target by default..
Disable PIC/PIE for MSP430 target by default.
Jan 25 2019, 1:42 AM
asl committed rC352181: Disable PIC/PIE for MSP430 target by default..
Disable PIC/PIE for MSP430 target by default.
Jan 25 2019, 1:42 AM
asl closed D56927: Disable PIC/PIE for MSP430 target.
Jan 25 2019, 1:42 AM · Restricted Project, Restricted Project
asl accepted D56927: Disable PIC/PIE for MSP430 target.
Jan 25 2019, 1:42 AM · Restricted Project, Restricted Project
asl requested changes to D56925: Do not use frame pointer by default for MSP430.

Patch fails to apply. Please rebase.

Jan 25 2019, 1:20 AM · Restricted Project, Restricted Project
asl requested changes to D56787: [MSP430] Set UseIntegratedAssembler.

This breaks CodeGen/MSP430/mult-alt-generic-msp430.ll :)

Jan 25 2019, 1:17 AM · Restricted Project