Page MenuHomePhabricator

asl (Anton Korobeynikov)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2012, 1:04 PM (515 w, 5 d)
Roles
Administrator

Recent Activity

Mon, May 23

asl accepted D125197: [github] format and refactor GitHub workflows.

Thanks!

Mon, May 23, 2:43 PM · Restricted Project, Restricted Project
asl accepted D125851: github: Switch release PR repository to llvm/llvm-project-release-prs.
Mon, May 23, 2:42 PM · Restricted Project, Restricted Project

Tue, May 10

asl added inline comments to D125197: [github] format and refactor GitHub workflows.
Tue, May 10, 1:09 AM · Restricted Project, Restricted Project

Mar 19 2022

asl added a comment to D121614: Add GSOC landing page with instructions for GSOC students..

@nlopes I think we need to better frame the requirement then, ask for CVs (this is always done though) and maybe even organize some kind of interviews? Strongly favouring ones with prior contributions is a good thing IMO

Mar 19 2022, 8:20 AM · Restricted Project

Mar 14 2022

asl added inline comments to D121614: Add GSOC landing page with instructions for GSOC students..
Mar 14 2022, 10:52 AM · Restricted Project

Feb 24 2022

asl committed rG64cc8b275603: Disable Mailgun click tracking (authored by asl).
Disable Mailgun click tracking
Feb 24 2022, 8:04 AM

Jan 27 2022

asl accepted D118401: [MC] Remove a stray space after tab for COFF .def directives.

Neat! :)

Jan 27 2022, 12:15 PM · Restricted Project
asl committed rG1f26aa42cedc: Remove "awaiting-review" labels from closed issues. (authored by asl).
Remove "awaiting-review" labels from closed issues.
Jan 27 2022, 12:07 PM

Jan 21 2022

asl added inline comments to D117832: Update the Bug Life Cycle docs for the switch to GitHub issues.
Jan 21 2022, 1:10 AM · Restricted Project

Jan 19 2022

asl accepted D117745: issue-subscriber: Fix handling of labels with spaces.
Jan 19 2022, 11:27 PM · Restricted Project

Jan 10 2022

asl accepted D116898: docs: update some bug tracker references (NFC).

LGTM, thanks!

Jan 10 2022, 2:26 PM · Restricted Project

Jan 9 2022

asl added inline comments to D116898: docs: update some bug tracker references (NFC).
Jan 9 2022, 12:07 PM · Restricted Project

Dec 29 2021

asl requested changes to D116351: Update Bug report URL to Github Issues.

Will you please check the comments and reword everything using proper terminology and new things we're having on GitHub?

Dec 29 2021, 2:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 28 2021

asl requested changes to D116351: Update Bug report URL to Github Issues.

Thanks for doing this! I added few notes on the way.

Dec 28 2021, 11:09 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 16 2021

asl committed rGea927b504bb0: No need to checkout a repo (authored by asl).
No need to checkout a repo
Dec 16 2021, 1:31 PM
asl committed rG764f96cb3bc3: Send to llvm-bugs (authored by asl).
Send to llvm-bugs
Dec 16 2021, 1:31 PM
asl committed rG25285577874f: Install test mailer for github bugs (authored by asl).
Install test mailer for github bugs
Dec 16 2021, 1:26 PM

Dec 14 2021

asl committed rG84f2ef2f2953: Disable issue labeler in LLVM forks (authored by alexbatashev).
Disable issue labeler in LLVM forks
Dec 14 2021, 9:03 AM
asl closed D115708: Disable issue labeler in LLVM forks.
Dec 14 2021, 9:03 AM · Restricted Project

Dec 13 2021

asl added a comment to D114412: github: Add action for automated issue notification.

@tstellar Does it work for our "complex" labels? E.g. "lld:ELF" or "tools:llvm-ar/llvm-ranlib"?

Dec 13 2021, 9:52 AM · Restricted Project

Dec 12 2021

asl committed rGc16ced99370e: Version bump (authored by asl).
Version bump
Dec 12 2021, 1:59 AM
asl committed rGf3c91b4f3804: Try another labeler implementation (authored by asl).
Try another labeler implementation
Dec 12 2021, 1:55 AM
asl committed rG5ccfb73756e9: Autolabel new issues (authored by asl).
Autolabel new issues
Dec 12 2021, 1:46 AM

Dec 11 2021

asl committed rG686dca86bf62: Enable github issues (authored by asl).
Enable github issues
Dec 11 2021, 1:14 AM

Dec 1 2021

asl committed rGc0b40b96aff5: Disable issues / pull requests via templates in preparation with migration (authored by asl).
Disable issues / pull requests via templates in preparation with migration
Dec 1 2021, 10:44 AM

Nov 22 2021

asl added a comment to D114406: Add issue/PR templates to discourge issue/PR creation.

We can also put into .github/ISSUE_TEMPLATE/config.yml the following:

blank_issues_enabled: false

To disallow non-templated issues

Nov 22 2021, 9:54 PM · Restricted Project

Oct 25 2021

asl added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

@thopre I doubt the refactorings of this kind (change one plotting framework into another) could be split into smaller patches just by the nature of the change, you cannot have "half plot" and one essentially needs all the features ready for the review. So, such large patches are inevitable

Oct 25 2021, 10:26 AM · Restricted Project

Sep 29 2021

asl added inline comments to D110723: [MSP430] Add assembler and MC support for MSP430X shift instructions.
Sep 29 2021, 8:49 AM · Restricted Project
asl accepted D110691: [MSP430] Recognize Bi as an indirect branch in analyzeBranch. NFC..

Indeed, this was an oversight. Bi could be generated from an indirect branch as a result of folding or during the branch relaxation.

Sep 29 2021, 8:31 AM · Restricted Project

Sep 28 2021

asl added a comment to D109324: [MSP430] Add support for MSP430X extended shift instructions.

Will it be possible to split this patch into 3:

Sep 28 2021, 10:58 AM · Restricted Project
asl requested changes to D108301: [MSP430][Clang] Update hard-coded MCU data.

Please see comments inline

Sep 28 2021, 10:55 AM · Restricted Project, Restricted Project
asl committed rGbe610932fa06: [MSP430][Clang] Remove support for -mmcu=msp430 (authored by jozefl).
[MSP430][Clang] Remove support for -mmcu=msp430
Sep 28 2021, 10:48 AM
asl closed D108299: [MSP430][Clang] Remove support for -mmcu=msp430.
Sep 28 2021, 10:48 AM · Restricted Project
asl accepted D108299: [MSP430][Clang] Remove support for -mmcu=msp430.

LGTM, thanks!

Sep 28 2021, 10:45 AM · Restricted Project

Sep 27 2021

asl committed rG6cfb4d46bae1: [llvm-readobj] Support dumping of MSP430 ELF attributes (authored by jozefl).
[llvm-readobj] Support dumping of MSP430 ELF attributes
Sep 27 2021, 2:56 PM
asl closed D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.
Sep 27 2021, 2:56 PM · Restricted Project

Sep 20 2021

asl added a comment to D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

Sorry, I was AFK for a moment. Will review today

Sep 20 2021, 1:36 AM · Restricted Project

Aug 16 2021

asl added a comment to D107968: [llvm-readobj] Refactor ELFDumper::printAttributes().

In general, this looks reasonable refactoring to me. @jhenderson ?

Aug 16 2021, 2:20 AM · Restricted Project
asl accepted D107969: [llvm-readobj] Support dumping of MSP430 ELF attributes.

LGTM, thanks

Aug 16 2021, 2:18 AM · Restricted Project

Mar 18 2021

asl added a comment to D98494: [NFC] Minor cleanup to use default setting of getLastArg().

Indeed! And even worse, there is another 'A' shadowing definition below :)

Mar 18 2021, 1:14 AM · Restricted Project

Mar 17 2021

asl accepted D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver.

LGTM, thanks!

Mar 17 2021, 12:28 PM · Restricted Project
asl added inline comments to D98493: [WoA][MSVC] Use default linker setting in MSVC-compatible driver.
Mar 17 2021, 12:15 PM · Restricted Project
asl accepted D98494: [NFC] Minor cleanup to use default setting of getLastArg().

Looks trivial enough for post-commit review :)

Mar 17 2021, 12:13 PM · Restricted Project

Feb 4 2021

asl requested changes to D94230: [AArch64][SVE] Coalesce ptrue instrinsic calls where possible.

It seems you pushed to master, not main.

Feb 4 2021, 12:32 PM · Restricted Project

Jan 23 2021

asl committed rW24a1eafc1af2: Unbreak (authored by asl).
Unbreak
Jan 23 2021, 11:29 AM

Jan 20 2021

asl committed rWcce2c1efc1fa: Fix a typo (authored by asl).
Fix a typo
Jan 20 2021, 10:01 AM
asl added a comment to D94066: Link fix of CGO website on LLVM website.

Fixed in cce2c1e

Jan 20 2021, 9:59 AM

Jan 18 2021

asl committed rWae841d506318: Add GSoC 2021 stub (authored by asl).
Add GSoC 2021 stub
Jan 18 2021, 1:59 AM

Oct 9 2020

asl added a comment to D89142: llvmbuildectomy.

Can we fold all these LLVMBuild.cmake files into the corresponding cmakelists.txt?

Oct 9 2020, 10:00 AM · Restricted Project

Aug 9 2020

asl added inline comments to D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.
Aug 9 2020, 12:52 PM · Restricted Project

Aug 7 2020

asl requested changes to D84397: [MSP430] Replace known epilogues with branches to __mspabi_func_epilog_N.

Will you please switch to iterators here?

Aug 7 2020, 2:52 AM · Restricted Project

Jul 8 2020

asl accepted D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.

LGTM, thanks!

Jul 8 2020, 2:25 PM · Restricted Project
asl added inline comments to D82646: [MSP430] Align the _Complex ABI with current msp430-gcc.
Jul 8 2020, 5:26 AM · Restricted Project

Jun 30 2020

asl committed rG19e75717eff2: [MSP430] Declare comparison LibCalls as returning i16 instead of i32 (authored by atrosinenko).
[MSP430] Declare comparison LibCalls as returning i16 instead of i32
Jun 30 2020, 1:35 AM
asl committed rG0ee439b705e8: [builtins] Change si_int to int in some helper declarations (authored by atrosinenko).
[builtins] Change si_int to int in some helper declarations
Jun 30 2020, 1:35 AM
asl closed D81285: [builtins] Change si_int to int in some helper declarations.
Jun 30 2020, 1:35 AM · Restricted Project
asl closed D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.
Jun 30 2020, 1:35 AM · Restricted Project

Jun 26 2020

asl committed rGcb56fa2196c5: [MSP430] Update register names (authored by atrosinenko).
[MSP430] Update register names
Jun 26 2020, 5:58 AM
asl committed rGa4e8f7fe3f38: [builtins] Improve compatibility with 16 bit targets (authored by atrosinenko).
[builtins] Improve compatibility with 16 bit targets
Jun 26 2020, 5:58 AM
asl closed D82184: [MSP430] Update register names.
Jun 26 2020, 5:58 AM · Restricted Project, Restricted Project
asl closed D81408: [builtins] Improve compatibility with 16 bit targets.
Jun 26 2020, 5:57 AM · Restricted Project
asl accepted D82635: [MSP430] Declare comparison LibCalls as returning i16 instead of i32.
Jun 26 2020, 5:56 AM · Restricted Project
asl added inline comments to D82557: [MSP430][NFC] Remove redundant condition.
Jun 26 2020, 5:26 AM · Restricted Project

Jun 25 2020

asl committed rGa931ec7ca0ee: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list (authored by atrosinenko).
[builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list
Jun 25 2020, 1:06 PM
asl closed D81282: [builtins] Move more float128-related helpers to GENERIC_TF_SOURCES list.
Jun 25 2020, 1:05 PM · Restricted Project
asl requested changes to D82557: [MSP430][NFC] Remove redundant condition.
Jun 25 2020, 1:05 PM · Restricted Project

Jun 22 2020

asl committed rG16cc759ebd56: Attempt to unbreak the test introduced in 359fae6eb094 on Windows (authored by asl).
Attempt to unbreak the test introduced in 359fae6eb094 on Windows
Jun 22 2020, 4:49 AM
asl committed rG6cb80fbe4052: Revert "[MSP430] Update register names" (authored by asl).
Revert "[MSP430] Update register names"
Jun 22 2020, 3:44 AM
asl added a reverting change for rG8f6620f66303: [MSP430] Update register names: rG6cb80fbe4052: Revert "[MSP430] Update register names".
Jun 22 2020, 3:44 AM
asl committed rG8f6620f66303: [MSP430] Update register names (authored by atrosinenko).
[MSP430] Update register names
Jun 22 2020, 3:44 AM
asl closed D82184: [MSP430] Update register names.
Jun 22 2020, 3:43 AM · Restricted Project, Restricted Project
asl committed rGa5bd75aab861: [MSP430] Enable some basic support for debug information (authored by atrosinenko).
[MSP430] Enable some basic support for debug information
Jun 22 2020, 3:43 AM
asl committed rG359fae6eb094: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data (authored by atrosinenko).
[DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data
Jun 22 2020, 3:43 AM
asl closed D81488: [MSP430] Enable some basic support for debug information.
Jun 22 2020, 3:43 AM · Restricted Project
asl closed D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data.
Jun 22 2020, 3:43 AM · Restricted Project
asl accepted D81488: [MSP430] Enable some basic support for debug information.

LGTM, thanks!

Jun 22 2020, 3:43 AM · Restricted Project
asl accepted D82184: [MSP430] Update register names.

Looks good to me! FP was an old register name from mspgcc time. MSP430 EABI does not use frame pointer at all (seems to be a bug in the ABI, as I do not understand how we could support VLAs or alloca's in this case).

Jun 22 2020, 3:10 AM · Restricted Project, Restricted Project

Jun 18 2020

asl added inline comments to D81515: [llvm] Release-mode ML InlineAdvisor.
Jun 18 2020, 4:52 AM · Restricted Project

Jun 17 2020

asl added inline comments to D81515: [llvm] Release-mode ML InlineAdvisor.
Jun 17 2020, 2:34 PM · Restricted Project
asl added inline comments to D77752: [llvm] Machine Learned policy for inlining -Oz.
Jun 17 2020, 4:16 AM · Restricted Project

Feb 27 2020

asl committed rG7b08aa9549e0: Test commit: update my email (authored by asl).
Test commit: update my email
Feb 27 2020, 4:02 AM

Nov 7 2019

asl accepted D69975: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (3) (baseline tests).
Nov 7 2019, 11:25 PM · Restricted Project

Oct 30 2019

asl accepted D69609: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (Baseline).

In general LGTM. But will you please correct the test names, so I can commit on your behalf?

Oct 30 2019, 11:22 AM · Restricted Project
asl added a comment to D69120: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (2/2).

@joanlluch Yes, having the version with amount does make sense as target may know how to efficiently lower some of the shifts with crazy tricks. And in the view of this patch it's easier to preserve the sequences rather than match and undo later. I guess for MSP430 we'd need to allow 9 as possible "special" shift value, as select is lowered to 3 instructions (test + branch + mov of some kind) and removing branch overall has some additional value like allowing more code folding / reducing register pressure.

Oct 30 2019, 11:21 AM · Restricted Project

Oct 24 2019

asl added inline comments to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
Oct 24 2019, 10:00 AM · Restricted Project
asl added inline comments to D69372: [X86][VARARG] Avoid spilling xmm vararg arguments..
Oct 24 2019, 8:48 AM · Restricted Project

Oct 22 2019

asl added inline comments to D69103: Backend for NEC SX-Aurora.
Oct 22 2019, 5:31 PM · Restricted Project, Restricted Project

Oct 19 2019

asl added a comment to D69116: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine (1/2).

LGTM, thanks!

Oct 19 2019, 10:06 AM · Restricted Project

Oct 16 2019

asl added a comment to D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine.

If they are not necessary, then it would make sense to undo them. At least partially.

Oct 16 2019, 3:10 AM · Restricted Project
asl added a comment to D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine.

@joanlluch There are two things here. We understand that there might be some out-of-tree targets that would benefit from changes in the mainline. However, it is still important to add tests that utilize mainline targets as this ensures that the proposed changes won't e.g. break during some refactoring, etc. So, using MSP430 (probably the smallest) / AVR is perfectly fine for tests, etc.!

Oct 16 2019, 2:32 AM · Restricted Project
asl added a comment to D68982: [TargetLowering][DAGCombine][MSP430] Shift Amount Threshold in DAGCombine.

The MSP430 changes / overall direction looks extremely useful to me. We just need to ensure everything is done properly. This is exactly what @spatel proposed.

Oct 16 2019, 1:33 AM · Restricted Project

Sep 25 2019

asl accepted D67313: [MSP430] Allow msp430_intrcc functions to not have interrupt attribute..

LGTM, thanks!

Sep 25 2019, 8:34 AM · Restricted Project

Aug 31 2019

asl committed rL370567: Add username.
Add username
Aug 31 2019, 2:06 AM

Aug 13 2019

asl removed 1 auditor(s) for rG3a6bdf8f82c8: Remove EnhancedBugReport and RangedBugReport - pull all the extra functionality…: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG685fbda217ee: [GlobalISel] Make LegalizerInfo accessible in LegalizerHelper: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG202d660af100: Fix -Wdocumentation typo. NFCI.: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rGb9bd6ebe1dca: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting…: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed a project from rL368639: Removed builders: llvm-clang-lld-x86_64-debian-fast, ubuntu-gcc7.1-werror.: debug-info.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG2c69b1377cb6: Merging r368581: --------------------------------------------------------------…: lisa6jones6.
Aug 13 2019, 2:17 PM
asl removed 1 auditor(s) for rG97e6d088e946: Merging r368517, r368518, r368519, and r368554:: lisa6jones6.
Aug 13 2019, 2:16 PM