Page MenuHomePhabricator

asl (Anton Korobeynikov)Administrator
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 8 2012, 1:04 PM (371 w, 9 h)
Roles
Administrator

Recent Activity

Tue, Aug 13

asl removed 1 auditor(s) for rG3a6bdf8f82c8: Remove EnhancedBugReport and RangedBugReport - pull all the extra functionality…: lisa6jones6.
Tue, Aug 13, 2:17 PM
asl removed 1 auditor(s) for rG685fbda217ee: [GlobalISel] Make LegalizerInfo accessible in LegalizerHelper: lisa6jones6.
Tue, Aug 13, 2:17 PM
asl removed 1 auditor(s) for rG202d660af100: Fix -Wdocumentation typo. NFCI.: lisa6jones6.
Tue, Aug 13, 2:17 PM
asl removed 1 auditor(s) for rGb9bd6ebe1dca: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting…: lisa6jones6.
Tue, Aug 13, 2:17 PM
asl removed a project from rL368639: Removed builders: llvm-clang-lld-x86_64-debian-fast, ubuntu-gcc7.1-werror.: debug-info.
Tue, Aug 13, 2:17 PM
asl removed 1 auditor(s) for rG2c69b1377cb6: Merging r368581: --------------------------------------------------------------…: lisa6jones6.
Tue, Aug 13, 2:17 PM
asl removed 1 auditor(s) for rG97e6d088e946: Merging r368517, r368518, r368519, and r368554:: lisa6jones6.
Tue, Aug 13, 2:16 PM

Jul 8 2019

asl committed rL365389: JetBrains actually signed the agreement.
JetBrains actually signed the agreement
Jul 8 2019, 2:18 PM

Jun 24 2019

asl accepted D23664: [AAP] (1) Add AAP target triple.

The changes are pretty straightforward :)

Jun 24 2019, 5:51 AM

May 31 2019

asl added a comment to D62639: Fix ABI breakage with noimplicitfloat and varargs functions.

Note that on AArch64, there is no equivalent to x86's use of "al" for varargs calls.

Correct. Everywhere else we're using the same ABI regardless of this flag.

May 31 2019, 6:24 PM · Restricted Project

May 30 2019

asl updated the summary of D62639: Fix ABI breakage with noimplicitfloat and varargs functions.
May 30 2019, 9:31 PM · Restricted Project
asl added a comment to D62639: Fix ABI breakage with noimplicitfloat and varargs functions.

@efriedma The LangRef states that "This attributes disables implicit floating-point instructions". I believe that the definition of "implicit" is very vague here. And clang cmdline documentation does not explain "-mno-implicit-float" at all. What you'd suggest? :)

May 30 2019, 9:31 PM · Restricted Project
asl resigned from D62571: Implement codegen for MSVC unions with reference members.
May 30 2019, 12:34 PM · Restricted Project

May 29 2019

asl created D62639: Fix ABI breakage with noimplicitfloat and varargs functions.
May 29 2019, 7:01 PM · Restricted Project

Apr 11 2019

asl added a comment to D60584: Conversion of a switch table to a bitmap is not profitable for -Os and -Oz compilation.

How many such switches are seen in e.g. LLVM test suite? Could you please share the size reduction statistics?

Apr 11 2019, 3:26 PM

Apr 8 2019

asl committed rL357888: Remove the project.
Remove the project
Apr 8 2019, 1:03 AM

Mar 30 2019

asl added a comment to D60033: [MSP430] Expand Atomic nodes.

Well, what's the overall motivation of all these changes? There are no multiple threads, etc. on msp430. I believe instead of lowering to libcalls we could simply "drop" atomic.

Mar 30 2019, 12:48 PM · Restricted Project

Mar 18 2019

asl edited reviewers for D59460: [MSP430] Use generic operand printer for modifiers, added: mskvortsov; removed: nlewycky.
Mar 18 2019, 5:57 AM · Restricted Project

Feb 26 2019

asl added a comment to rG66b91e66ecc3: Implement necessary bits for flt_rounds gcc builtin. Codegen bits and llvm-gcc….

@wuzish Do you really wanted on comment on commit that is more than 10 years old? Have you looked over the current ToT?

Feb 26 2019, 2:15 AM

Feb 17 2019

asl committed rL354230: Clarify keynote authors.
Clarify keynote authors
Feb 17 2019, 10:46 AM

Feb 16 2019

asl updated subscribers of D58173: [llvm-objcopy] Add --set-start, --change-start, --adjust-start.
Feb 16 2019, 10:36 AM · Restricted Project
asl updated subscribers of rGf6e77311502c: Fix some tests I broke in r354190.
Feb 16 2019, 10:36 AM
asl updated subscribers of D57938: [WebAssembly] Update MC for bulk memory.
Feb 16 2019, 10:35 AM · Restricted Project
asl updated subscribers of D58319: [WebAssembly] Remove getBottom function from CFGStackify (NFC).
Feb 16 2019, 10:35 AM · Restricted Project
asl updated subscribers of rGeac7c3ffaf5d: [Sema] Diagnose floating point conversions based on target semantics.
Feb 16 2019, 10:35 AM
asl removed 1 auditor(s) for rG358f99c7fe27: [clang-tidy] Delete obsolete objc-property-declaration options ✂️: ham999221.
Feb 16 2019, 10:34 AM

Feb 13 2019

asl committed rL353930: Fix authors in outline as well.
Fix authors in outline as well
Feb 13 2019, 1:35 AM
asl committed rL353929: Add more authors.
Add more authors
Feb 13 2019, 1:34 AM

Feb 12 2019

asl committed rGa39eb26bd3f1: Disable PIC/PIE for MSP430 target (authored by asl).
Disable PIC/PIE for MSP430 target
Feb 12 2019, 12:46 PM
asl committed rC353877: Disable PIC/PIE for MSP430 target.
Disable PIC/PIE for MSP430 target
Feb 12 2019, 12:45 PM
asl committed rL353877: Disable PIC/PIE for MSP430 target.
Disable PIC/PIE for MSP430 target
Feb 12 2019, 12:45 PM
asl closed D56927: Disable PIC/PIE for MSP430 target.
Feb 12 2019, 12:45 PM · Restricted Project, Restricted Project
asl accepted D56927: Disable PIC/PIE for MSP430 target.
Feb 12 2019, 12:45 PM · Restricted Project, Restricted Project

Feb 5 2019

asl committed rGf1f897cac239: Do not use frame pointer by default for MSP430 (authored by asl).
Do not use frame pointer by default for MSP430
Feb 5 2019, 12:16 PM
asl committed rC353212: Do not use frame pointer by default for MSP430.
Do not use frame pointer by default for MSP430
Feb 5 2019, 12:16 PM
asl committed rL353212: Do not use frame pointer by default for MSP430.
Do not use frame pointer by default for MSP430
Feb 5 2019, 12:16 PM
asl closed D56925: Do not use frame pointer by default for MSP430.
Feb 5 2019, 12:16 PM · Restricted Project, Restricted Project
asl accepted D57333: Initial GSOC 2019 project.

Paul, sorry, I completely missed this review request for some reason... Please rebase and commit, thanks!

Feb 5 2019, 12:16 PM
asl accepted D56925: Do not use frame pointer by default for MSP430.

Ok now

Feb 5 2019, 12:16 PM · Restricted Project, Restricted Project
asl committed rGb26134bf9213: Enable integrated assembler on MSP430 by default. (authored by asl).
Enable integrated assembler on MSP430 by default.
Feb 5 2019, 10:02 AM
asl committed rL353192: Enable integrated assembler on MSP430 by default..
Enable integrated assembler on MSP430 by default.
Feb 5 2019, 10:01 AM
asl closed D56787: [MSP430] Set UseIntegratedAssembler.
Feb 5 2019, 10:01 AM · Restricted Project
asl accepted D56787: [MSP430] Set UseIntegratedAssembler.

LGTM now

Feb 5 2019, 10:00 AM · Restricted Project

Feb 2 2019

asl committed rL352962: Add GSoC 2019 stub.
Add GSoC 2019 stub
Feb 2 2019, 10:03 AM

Jan 27 2019

asl accepted D57290: [www] Remove implemented Clang SA projects.

LGTM

Jan 27 2019, 1:42 PM

Jan 25 2019

asl requested changes to D56927: Disable PIC/PIE for MSP430 target.

Please make sure the test passes.

Jan 25 2019, 2:37 AM · Restricted Project, Restricted Project
asl reopened D56927: Disable PIC/PIE for MSP430 target.

The patch was reverted – the test requires fully configured msp430 configuration and therefore was breaking the bots.

Jan 25 2019, 2:37 AM · Restricted Project, Restricted Project
asl committed rC352186: Revert r352181 as it's breaking the bots.
Revert r352181 as it's breaking the bots
Jan 25 2019, 2:35 AM
asl committed rL352186: Revert r352181 as it's breaking the bots.
Revert r352181 as it's breaking the bots
Jan 25 2019, 2:35 AM
asl committed rL352181: Disable PIC/PIE for MSP430 target by default..
Disable PIC/PIE for MSP430 target by default.
Jan 25 2019, 1:42 AM
asl committed rC352181: Disable PIC/PIE for MSP430 target by default..
Disable PIC/PIE for MSP430 target by default.
Jan 25 2019, 1:42 AM
asl closed D56927: Disable PIC/PIE for MSP430 target.
Jan 25 2019, 1:42 AM · Restricted Project, Restricted Project
asl accepted D56927: Disable PIC/PIE for MSP430 target.
Jan 25 2019, 1:42 AM · Restricted Project, Restricted Project
asl requested changes to D56925: Do not use frame pointer by default for MSP430.

Patch fails to apply. Please rebase.

Jan 25 2019, 1:20 AM · Restricted Project, Restricted Project
asl requested changes to D56787: [MSP430] Set UseIntegratedAssembler.

This breaks CodeGen/MSP430/mult-alt-generic-msp430.ll :)

Jan 25 2019, 1:17 AM · Restricted Project
asl committed rL352178: [MSP430] Fix absolute addressing mode printing in AsmPrinter.
[MSP430] Fix absolute addressing mode printing in AsmPrinter
Jan 25 2019, 1:14 AM
asl closed D56785: [MSP430] Fix absolute addressing mode printing in AsmPrinter.
Jan 25 2019, 1:14 AM
asl accepted D56785: [MSP430] Fix absolute addressing mode printing in AsmPrinter.
Jan 25 2019, 1:13 AM
asl committed rC352177: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI.
[MSP430] Ajust f32/f64 alignment according to MSP430 EABI
Jan 25 2019, 12:52 AM
asl committed rL352177: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI.
[MSP430] Ajust f32/f64 alignment according to MSP430 EABI
Jan 25 2019, 12:52 AM
asl closed D57015: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI.
Jan 25 2019, 12:52 AM
asl accepted D57015: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI.
Jan 25 2019, 12:51 AM

Jan 17 2019

asl committed rL351449: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds.
CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds
Jan 17 2019, 7:27 AM
asl committed rC351449: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds.
CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds
Jan 17 2019, 7:27 AM
asl closed D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds.
Jan 17 2019, 7:27 AM
asl accepted D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds.

Committed, thanks!

Jan 17 2019, 7:26 AM

Jan 16 2019

asl committed rL351345: [MSP430] Emit a separate section for every interrupt vector.
[MSP430] Emit a separate section for every interrupt vector
Jan 16 2019, 6:07 AM
asl closed D56664: [MSP430] Emit a separate section for every interrupt vector.
Jan 16 2019, 6:07 AM
asl accepted D56664: [MSP430] Emit a separate section for every interrupt vector.
Jan 16 2019, 5:49 AM
asl committed rC351344: [MSP430] Improve support of 'interrupt' attribute.
[MSP430] Improve support of 'interrupt' attribute
Jan 16 2019, 5:48 AM
asl committed rL351344: [MSP430] Improve support of 'interrupt' attribute.
[MSP430] Improve support of 'interrupt' attribute
Jan 16 2019, 5:48 AM
asl closed D56663: [MSP430] Improve support of 'interrupt' attribute.
Jan 16 2019, 5:48 AM
asl accepted D56663: [MSP430] Improve support of 'interrupt' attribute.
Jan 16 2019, 5:44 AM
asl committed rL351340: [MSP430] Fix msp430-toolchain.c on Windows (added in r351228).
[MSP430] Fix msp430-toolchain.c on Windows (added in r351228)
Jan 16 2019, 5:32 AM
asl committed rC351340: [MSP430] Fix msp430-toolchain.c on Windows (added in r351228).
[MSP430] Fix msp430-toolchain.c on Windows (added in r351228)
Jan 16 2019, 5:32 AM
asl closed D56776: [MSP430] Fix msp430-toolchain.c on Windows (added in rL351228).
Jan 16 2019, 5:32 AM
asl accepted D56776: [MSP430] Fix msp430-toolchain.c on Windows (added in rL351228).
Jan 16 2019, 5:26 AM

Jan 15 2019

asl added inline comments to D56658: [MSP430] Add msp430 toochain.
Jan 15 2019, 1:32 PM
asl added inline comments to D56658: [MSP430] Add msp430 toochain.
Jan 15 2019, 1:26 PM
asl closed D56634: [MSP430] Recoginze '{' as a line separator.

Committed as r351233, thanks!

Jan 15 2019, 12:15 PM
asl committed rL351233: [MSP430] Recognize '{' as a line separator.
[MSP430] Recognize '{' as a line separator
Jan 15 2019, 12:14 PM
asl accepted D56634: [MSP430] Recoginze '{' as a line separator.
Jan 15 2019, 11:53 AM
asl committed rC351228: [MSP430] Provide a toolchain description.
[MSP430] Provide a toolchain description
Jan 15 2019, 11:48 AM
asl committed rL351228: [MSP430] Provide a toolchain description.
[MSP430] Provide a toolchain description
Jan 15 2019, 11:48 AM
asl closed D56658: [MSP430] Add msp430 toochain.
Jan 15 2019, 11:48 AM
asl accepted D56658: [MSP430] Add msp430 toochain.
Jan 15 2019, 11:44 AM

Jan 14 2019

asl updated the summary of D56622: [Algorithm] Add make_const_ref corresponding to make_const_ptr.
Jan 14 2019, 5:31 AM
asl removed 1 auditor(s) for rL350766: [libfuzzer][MSVC] Make calls to builtin functions work with MSVC: ham99922.
Jan 14 2019, 5:30 AM

Jan 10 2019

asl committed rL350903: [MSP430] Minor fixes/improvements for assembler/disassembler.
[MSP430] Minor fixes/improvements for assembler/disassembler
Jan 10 2019, 3:06 PM
asl closed D56547: [MSP430] Minor fixes/improvements for assembler/disassembler.
Jan 10 2019, 3:06 PM
asl accepted D56547: [MSP430] Minor fixes/improvements for assembler/disassembler.
Jan 10 2019, 3:02 PM
asl committed rL350902: [MSP430] Add missing instruction forms.
[MSP430] Add missing instruction forms
Jan 10 2019, 2:59 PM
asl closed D56546: [MSP430] Add missing instruction forms.
Jan 10 2019, 2:58 PM
asl accepted D56546: [MSP430] Add missing instruction forms.
Jan 10 2019, 2:58 PM

Jan 9 2019

asl committed rL350712: [MSP430] Optimize 'shl x, 8[+ N] -> swpb(zext(x)) [<< N]' for i16.
[MSP430] Optimize 'shl x, 8[+ N] -> swpb(zext(x)) [<< N]' for i16
Jan 9 2019, 5:06 AM
asl closed D56016: [MSP430] Optimize 'shl x, 8[+ N] -> swpb(zext(x)) [<< N]' for i16.
Jan 9 2019, 5:06 AM
asl accepted D56016: [MSP430] Optimize 'shl x, 8[+ N] -> swpb(zext(x)) [<< N]' for i16.
Jan 9 2019, 5:05 AM
asl committed rL350710: [MSP430] Fix crash while lowering llvm.stacksave/stackrestore.
[MSP430] Fix crash while lowering llvm.stacksave/stackrestore
Jan 9 2019, 4:56 AM
asl closed D54890: [MSP430] Fix crash while lowering llvm.stacksave/stackrestore.
Jan 9 2019, 4:56 AM
asl accepted D54890: [MSP430] Fix crash while lowering llvm.stacksave/stackrestore.
Jan 9 2019, 4:53 AM