Page MenuHomePhabricator

probinson (Paul Robinson)
User

Projects

User Details

User Since
May 9 2013, 11:10 AM (472 w, 1 d)

Recent Activity

Yesterday

probinson added inline comments to D119051: Extend the C++03 definition of POD to include defaulted functions.
Thu, May 26, 1:32 PM · Restricted Project, Restricted Project
probinson committed rG634c8ef69a83: [PS5] Allow dllimport/dllexport same as PS4 (authored by probinson).
[PS5] Allow dllimport/dllexport same as PS4
Thu, May 26, 7:02 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 25

probinson added inline comments to D119051: Extend the C++03 definition of POD to include defaulted functions.
Wed, May 25, 4:01 PM · Restricted Project, Restricted Project
probinson committed rGd8dda57ae779: [PS5] Default to -fno-rtti (authored by probinson).
[PS5] Default to -fno-rtti
Wed, May 25, 6:48 AM · Restricted Project, Restricted Project
probinson added inline comments to D119051: Extend the C++03 definition of POD to include defaulted functions.
Wed, May 25, 6:18 AM · Restricted Project, Restricted Project

Tue, May 24

probinson added a reverting change for rGefebb27b745a: Revert "[PS5] Verify defaults to -fno-stack-size-section": rG4a3e2aff5f84: Reland "[PS5] Verify defaults to -fno-stack-size-section".
Tue, May 24, 10:10 AM · Restricted Project, Restricted Project
probinson committed rG4a3e2aff5f84: Reland "[PS5] Verify defaults to -fno-stack-size-section" (authored by probinson).
Reland "[PS5] Verify defaults to -fno-stack-size-section"
Tue, May 24, 10:10 AM · Restricted Project, Restricted Project
probinson added a reverting change for rG28432b0f6556: [PS5] Verify defaults to -fno-stack-size-section: rGefebb27b745a: Revert "[PS5] Verify defaults to -fno-stack-size-section".
Tue, May 24, 10:01 AM · Restricted Project, Restricted Project
probinson committed rGefebb27b745a: Revert "[PS5] Verify defaults to -fno-stack-size-section" (authored by probinson).
Revert "[PS5] Verify defaults to -fno-stack-size-section"
Tue, May 24, 10:00 AM · Restricted Project, Restricted Project
probinson added a comment to D126224: Add DWARF string debug to clang release notes..

I see some unrelated whitespace changes, we generally don't like mixing those with "real" changes. But the description seems fine to me.

Tue, May 24, 9:58 AM · Restricted Project, Restricted Project
probinson committed rG28432b0f6556: [PS5] Verify defaults to -fno-stack-size-section (authored by probinson).
[PS5] Verify defaults to -fno-stack-size-section
Tue, May 24, 9:48 AM · Restricted Project, Restricted Project
probinson added a comment to D126224: Add DWARF string debug to clang release notes..

While the string would be deduplicated, the offset in the DIEs (or index in DWARFv5, plus offset in .debug_str_offsets) for each of these strings would not. But perhaps that would still be low-cost enough (if we were getting really fancy, we could bake that string offset/index into the abbreviation - though we probably don't have the infrastructure in LLVM's DWARF emission to do that super easily)

Tue, May 24, 7:19 AM · Restricted Project, Restricted Project
probinson added inline comments to D125778: [llvm-dva] 03 - Logical elements.
Tue, May 24, 6:58 AM · Restricted Project, Restricted Project, debug-info

Mon, May 23

probinson added a comment to D126224: Add DWARF string debug to clang release notes..

Unnamed variables are an oddity, sure; we've had to patch a downstream test or two that wasn't being careful enough. But not providing a name is entirely defensible, and consumers should be willing to cope with DWARF that doesn't fully meet their expectations.

Mon, May 23, 2:40 PM · Restricted Project, Restricted Project
probinson committed rG217531f12b4b: [PS5] Make driver's PIC behavior match PS4 (authored by probinson).
[PS5] Make driver's PIC behavior match PS4
Mon, May 23, 12:51 PM · Restricted Project, Restricted Project
probinson committed rGdbd1ba28a3a4: [PS5] Disable a test, same as PS4 (authored by probinson).
[PS5] Disable a test, same as PS4
Mon, May 23, 10:44 AM · Restricted Project, Restricted Project

Wed, May 18

probinson added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Wed, May 18, 6:11 AM · Restricted Project, Restricted Project, debug-info
probinson added inline comments to D125776: [llvm-dva] 01 - Interval tree.
Wed, May 18, 5:12 AM · Restricted Project, Restricted Project, debug-info

Thu, May 5

probinson added a comment to D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

Comparing different DWARF output in a more abstract way is exactly what the llvm-dva tool is designed to do; unfortunately it isn't upstream yet, although @CarlosAlbertoEnciso is working on generating the patches now.
I'd prefer not to have a works-in-a-few-cases-for-one-tool feature come in when a better solution is around the corner.

+1 if that tool is actually coming. @CarlosAlbertoEnciso or @probinson do you have a rough timeline in mind?

Thu, May 5, 5:32 PM · Restricted Project, Restricted Project

Wed, May 4

probinson added a comment to D122251: [lit] Use sharding for GoogleTest format.

The buildbot totals are counting the number of shards across all unit tests. The summary at the end of the log is counting the number of test cases like before.

Wed, May 4, 11:22 AM · Restricted Project, Restricted Project

Mon, May 2

probinson committed rG2ed0123b7fed: [PS5] Check for HasNativeLLVMSupport (authored by probinson).
[PS5] Check for HasNativeLLVMSupport
Mon, May 2, 11:12 AM · Restricted Project, Restricted Project
probinson committed rG214265bce9df: [NFC] Add test for HasNativeLLVMSupport (authored by probinson).
[NFC] Add test for HasNativeLLVMSupport
Mon, May 2, 11:12 AM · Restricted Project, Restricted Project

Thu, Apr 28

probinson added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

This feels like (maybe is?) supporting a target whose assembler happens not to be generally distributed, but which LLVM still supports as a target. For those environments/bots that actually have the assembler installed, having that extra level of validation seems worthwhile.

Thu, Apr 28, 7:40 PM · Restricted Project, Restricted Project
probinson committed rG17f3a92ee5d5: [PS5] Default to omit leaf frame pointer (authored by probinson).
[PS5] Default to omit leaf frame pointer
Thu, Apr 28, 10:36 AM · Restricted Project, Restricted Project
probinson committed rGdb013b28c3d4: [PS5] Defaults for -fdeclspec, -ffunction/data-sections (authored by probinson).
[PS5] Defaults for -fdeclspec, -ffunction/data-sections
Thu, Apr 28, 10:04 AM · Restricted Project, Restricted Project
probinson committed rG501cc4ae304f: [PS5] Rename a test to reflect its new purpose (authored by probinson).
[PS5] Rename a test to reflect its new purpose
Thu, Apr 28, 8:08 AM · Restricted Project, Restricted Project
probinson committed rG451c5578b834: [PS5] Set default cpu to znver2, with no tuning (authored by probinson).
[PS5] Set default cpu to znver2, with no tuning
Thu, Apr 28, 7:51 AM · Restricted Project, Restricted Project
probinson committed rG8854d1244c90: [PS5] Disable exceptions by default (authored by probinson).
[PS5] Disable exceptions by default
Thu, Apr 28, 7:16 AM · Restricted Project, Restricted Project

Apr 27 2022

probinson committed rG7d2dddce8f0d: [PS5] Enable dead-stripping globals in ASan (authored by probinson).
[PS5] Enable dead-stripping globals in ASan
Apr 27 2022, 3:45 PM · Restricted Project, Restricted Project
probinson committed rGfd0e60d78743: [PS5] Test sanitizer options/lib names (authored by probinson).
[PS5] Test sanitizer options/lib names
Apr 27 2022, 1:46 PM · Restricted Project, Restricted Project
probinson added a comment to D114115: [Driver] Support for compressed debug info on Fuchsia.

Lit is aware of zlib's presence or absence, you could use REQUIRES: zlib (or you might factor that bit out into its own test with the REQUIRES).

Apr 27 2022, 12:06 PM · Restricted Project, Restricted Project

Apr 26 2022

probinson committed rG72adc461cca5: [PS5] Add debug option testing for the PS5 target (authored by probinson).
[PS5] Add debug option testing for the PS5 target
Apr 26 2022, 1:43 PM · Restricted Project, Restricted Project
probinson updated subscribers of D124082: [Debuginfo][llvm-dwarfdump][dsymutil] Add dsymutil compatibility dump..

Comparing different DWARF output in a more abstract way is exactly what the llvm-dva tool is designed to do; unfortunately it isn't upstream yet, although @CarlosAlbertoEnciso is working on generating the patches now.
I'd prefer not to have a works-in-a-few-cases-for-one-tool feature come in when a better solution is around the corner.

Apr 26 2022, 7:53 AM · Restricted Project, Restricted Project
probinson committed rGb375882014cc: [PS5] Correctly test for analyzer defaults (authored by probinson).
[PS5] Correctly test for analyzer defaults
Apr 26 2022, 7:19 AM · Restricted Project, Restricted Project

Apr 25 2022

probinson committed rG5c90ecae2db1: [PS5] Driver test for analyzer defaults (authored by probinson).
[PS5] Driver test for analyzer defaults
Apr 25 2022, 12:42 PM · Restricted Project, Restricted Project
probinson added a comment to D124398: [DebugInfo] Don't skip deletion of dead BasicBlocks because of debug-info instructions.

I don't spend a lot of time mucking around with IR transforms, so I'm not clear how _preserving_ the debug instructions makes it _possible_ to delete the block. Intuitively that doesn't make sense.

Apr 25 2022, 9:48 AM · Restricted Project, Restricted Project
probinson added a comment to D121299: [NVPTX] Disable DWARF .file directory for PTX.

I'm okay with doing it this way. My impression over the years (as a debug-info guy, not as a ptxas user) is that ptxas evolves slowly and this is not really "busy work."

Apr 25 2022, 9:10 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

probinson accepted D123920: [OpenMP][IRBuilder] Handle unexcuted EXPECT_FALSE.

LGTM

Apr 22 2022, 7:46 AM · Restricted Project, Restricted Project

Apr 21 2022

probinson committed rGf80e369f61eb: [PS4] Driver: use correct --shared option (authored by probinson).
[PS4] Driver: use correct --shared option
Apr 21 2022, 8:20 AM · Restricted Project, Restricted Project

Apr 20 2022

probinson added a comment to D123534: [dwarf] Emit a DIGlobalVariable for constant strings..

What's the DW_AT_type referring to? (why is there a type called ".str"?)

Apr 20 2022, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
probinson committed rGdfdb2cc0fbc9: [PS5][NFC] Fix a test with a misplaced -x option (authored by probinson).
[PS5][NFC] Fix a test with a misplaced -x option
Apr 20 2022, 8:57 AM · Restricted Project, Restricted Project
probinson committed rGa5c847e8cf2a: [PS4][NFC] Rename classes to align with prevailing practice (authored by probinson).
[PS4][NFC] Rename classes to align with prevailing practice
Apr 20 2022, 8:36 AM · Restricted Project, Restricted Project
probinson added a comment to D123897: [X86] Unbreak LIT/FileCheck.

Offhand, it seems like the next step would be a patch to make the update scripts apply --allow-unused-prefixes to all FileCheck commands. Then all autogenerated scripts would (eventually) DTRT, and this patch could then be reverted.

Apr 20 2022, 6:00 AM · Restricted Project, Restricted Project
probinson added a comment to D123897: [X86] Unbreak LIT/FileCheck.

Apologies, it seems like the feedback here arrives much faster than usual, so there are merge conflicts.
If the current description is still seen as bad, here's a black marker, feel free to fine-tune it.
Thanks!

Apr 20 2022, 5:55 AM · Restricted Project, Restricted Project
probinson updated the summary of D123897: [X86] Unbreak LIT/FileCheck.
Apr 20 2022, 5:54 AM · Restricted Project, Restricted Project

Apr 19 2022

probinson committed rG20c873c12fa5: [PS5] Avoid a driver crash (authored by probinson).
[PS5] Avoid a driver crash
Apr 19 2022, 3:56 PM · Restricted Project, Restricted Project
probinson added a project to D124006: [DebugInfo] Use the 'getTypeAlignIfRequired' function to get DW_AT_alignment correct when attribute((__aligned__)) is present.: debug-info.
Apr 19 2022, 9:44 AM · debug-info, Restricted Project, Restricted Project

Apr 14 2022

probinson committed rG7726ad04e263: [PS5] Add basic PS5 driver behavior (authored by probinson).
[PS5] Add basic PS5 driver behavior
Apr 14 2022, 12:46 PM · Restricted Project, Restricted Project
probinson committed rG7ef9dd3c61fd: [PS4] Fix a couple of typos (authored by probinson).
[PS4] Fix a couple of typos
Apr 14 2022, 10:14 AM · Restricted Project, Restricted Project
probinson committed rG52d346e715cf: [PS4] NFC refactor of PS4 toolchain class, prep for PS5 (authored by probinson).
[PS4] NFC refactor of PS4 toolchain class, prep for PS5
Apr 14 2022, 5:39 AM · Restricted Project, Restricted Project

Apr 8 2022

probinson committed rG6aa8a836c0f6: [RGT] Use GTEST_SKIP() in more places where we skip a test (authored by probinson).
[RGT] Use GTEST_SKIP() in more places where we skip a test
Apr 8 2022, 3:21 PM · Restricted Project, Restricted Project
probinson committed rG78a6f59c2cef: [RGT] Use GTEST_SKIP instead of just returning (authored by probinson).
[RGT] Use GTEST_SKIP instead of just returning
Apr 8 2022, 12:20 PM · Restricted Project, Restricted Project
probinson added a comment to D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc.

(@probinson as someone I've disagreed with about this before)

Personally I think there's limited value in expressing 'auto' in DWARF at all - we could omit function declarations if the return type is not known (undeduced auto) and wouldn't lose much - basically treating them the same as templates that aren't instantiated yet.

Apr 8 2022, 8:18 AM · Restricted Project, Restricted Project

Apr 7 2022

probinson added a comment to D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type..

Oh, this goes back in time a bit of a ways indeed (thanks for the archaeology) - so there was probably no pre-commit review, and the post-commit review doesn't seem to have discussed this aspect of the design, just some other naming details: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20121203/thread.html#158001

Apr 7 2022, 6:13 AM · Restricted Project, Restricted Project, debug-info

Apr 6 2022

probinson committed rG375d93465b3e: [PS4] Fix a buggy cast (authored by probinson).
[PS4] Fix a buggy cast
Apr 6 2022, 12:29 PM · Restricted Project, Restricted Project
probinson committed rG31c971145f5e: [PS4] clang-format PS4CPU.cpp/.h (authored by probinson).
[PS4] clang-format PS4CPU.cpp/.h
Apr 6 2022, 6:53 AM · Restricted Project, Restricted Project

Apr 5 2022

probinson added a comment to D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`.

OK. It is indeed a small obvious fix.

Apr 5 2022, 4:37 PM · Restricted Project, Restricted Project
probinson committed rG1e085448b36d: [PS4] Fix header search list (authored by probinson).
[PS4] Fix header search list
Apr 5 2022, 2:14 PM · Restricted Project, Restricted Project
probinson committed rG077f90315bec: [PS5] Add PS5 as a legal triple component (authored by probinson).
[PS5] Add PS5 as a legal triple component
Apr 5 2022, 12:56 PM · Restricted Project, Restricted Project

Apr 1 2022

probinson added a comment to D122251: [lit] Use sharding for GoogleTest format.

I really like these results but I don't feel confident enough about Python to give a final okay.

Apr 1 2022, 12:26 PM · Restricted Project, Restricted Project
probinson added inline comments to D122371: [mlir][OpenMP][IRBuilder] Add support for nowait on single construct.
Apr 1 2022, 7:16 AM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

probinson added inline comments to D122569: [lit] Support %if ... %else syntax for RUN lines.
Mar 29 2022, 2:30 PM · Restricted Project, Restricted Project
probinson added inline comments to D122251: [lit] Use sharding for GoogleTest format.
Mar 29 2022, 2:25 PM · Restricted Project, Restricted Project
probinson added a comment to D122569: [lit] Support %if ... %else syntax for RUN lines.

I see that for %if feature {A} %else {B} the space before the %else is not preserved in the result.
If there is no %else what happens? e.g., XX %if feature {YY} ZZ Asking because I see no test case for this.

Mar 29 2022, 8:27 AM · Restricted Project, Restricted Project

Mar 25 2022

probinson committed rG6aa039775891: Remove dead code in driver parsing -gsimple-template-names= options (authored by probinson).
Remove dead code in driver parsing -gsimple-template-names= options
Mar 25 2022, 1:23 PM · Restricted Project, Restricted Project
probinson closed D122503: Remove dead code in driver parsing -gsimple-template-names= options.
Mar 25 2022, 1:23 PM · Restricted Project, Restricted Project, debug-info
probinson updated subscribers of D122503: Remove dead code in driver parsing -gsimple-template-names= options.

+cfe-commits; that should have happened automatically?

Mar 25 2022, 1:21 PM · Restricted Project, Restricted Project, debug-info
probinson added a comment to D122503: Remove dead code in driver parsing -gsimple-template-names= options.

Relevant quote from Options.td:

def gsimple_template_names : Flag<["-"], "gsimple-template-names">, Group<g_flags_Group>;
def gsimple_template_names_EQ
    : Joined<["-"], "gsimple-template-names=">,
      HelpText<"Use simple template names in DWARF, or include the full "
               "template name with a modified prefix for validation">,
      Values<"simple,mangled">, Flags<[CC1Option, NoDriverOption]>;
def gno_simple_template_names : Flag<["-"], "gno-simple-template-names">,
                                Group<g_flags_Group>;
Mar 25 2022, 1:19 PM · Restricted Project, Restricted Project, debug-info
probinson requested review of D122503: Remove dead code in driver parsing -gsimple-template-names= options.
Mar 25 2022, 1:18 PM · Restricted Project, Restricted Project, debug-info

Mar 24 2022

probinson added a comment to D122251: [lit] Use sharding for GoogleTest format.

My suspicion is that most peopke just run check-llvm or check-clang, which includes the regular lit tests, and therefore already ends up with things split across he available cores.

Mar 24 2022, 7:29 AM · Restricted Project, Restricted Project

Mar 23 2022

probinson added a comment to D122251: [lit] Use sharding for GoogleTest format.

Do we support using upstream googletest instead of the in-tree copy for the unit test?

Mar 23 2022, 11:48 AM · Restricted Project, Restricted Project

Mar 22 2022

probinson added a comment to D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`.

My original point was that this change is so small and unrelated to anything at the moment that it would be better for whatever s390x or i386 change that needs it, to introduce it then, not beforehand.

So this review should be abandoned in favour of the actual s390x review that needs it, with this change in it.

Mar 22 2022, 12:25 PM · Restricted Project, Restricted Project

Mar 21 2022

probinson added a comment to D121299: [NVPTX] Disable DWARF .file directory for PTX.

I traced it back to 2011 (commit 40f8f2ff "Add support for a new extension to the .file directive") , where it it was added as an extension and (I assume) later included into DWARFv5. Do we still want to support it as an extension for DWARF < 5, or it is only needed for integrated assembler?

Mar 21 2022, 2:45 PM · Restricted Project, Restricted Project, Restricted Project

Mar 18 2022

probinson committed rGbb78dd2e1f81: [RGT] StencilTest: Fix an assertion (authored by probinson).
[RGT] StencilTest: Fix an assertion
Mar 18 2022, 2:14 PM · Restricted Project
probinson added a comment to D121727: [NVPTX] Integrate ptxas to LIT tests.

What I've seen done in other cases is to write a second test file that uses the first test file as input. This lets the second test file have different requirements than the first. In the example here, you wouldn't modify access-non-generic.ll but rather add a second file, say access-non-generic-ptxas.ll that contained just this:

REQUIRES: ptxas
RUN: llc < access-non-generic.ll -march=nvptx -mcpu=sm_20 -o %t.ptx
RUN: ptxas -c %t.ptx -o /dev/null

The upside is, this uses existing lit mechanisms (feature test based on discovery of "ptxas" on PATH, or some environment variable is set).
The downside is, a bit more effort to keep the two files consistent; although in this case, it looks like the "ptxas" commands are pretty simple so I shouldn't think it would be a real burden.

Mar 18 2022, 11:25 AM · Restricted Project, Restricted Project
probinson added a comment to D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`.

You still need a test for this change. It seems there isn't really an existing test for this API; it's used in llvm/unittests/MC/TargetRegistry.cpp, but that's testing the registry rather than the API.

Mar 18 2022, 8:22 AM · Restricted Project, Restricted Project
probinson added a comment to D122003: Add support for more archs in `Triple::getArchTypeForLLVMName`.

Test? I'm a little surprised that changing the spelling of an arch didn't cause any failures.

Mar 18 2022, 8:08 AM · Restricted Project, Restricted Project
probinson accepted D121994: [tests] Make 'object-emission' imply 'default_triple'.

Makes sense, LGTM.

Mar 18 2022, 8:06 AM · Restricted Project, Restricted Project
probinson accepted D119137: Replace Steve Klabnik with Josh Stone as one of the Rust Security Response WG representatives.
Mar 18 2022, 8:02 AM · Restricted Project, Restricted Project
probinson added a comment to D121678: [pseudo] Split greatergreater token..

We had the same thing happen downstream. One of our guys speculates that because some allocations are "owned" by the returned TokenStream, but the returned TokenStream is a temporary, the lifetimes might not be sufficient and some deallocations can happen.
If I change the nested calls stripComments(cook(lex(Code, Opts), Opts)) to separate calls stored to separate locals, the problem goes away.

Mar 18 2022, 6:43 AM · Restricted Project, Restricted Project, Restricted Project

Mar 16 2022

probinson accepted D118850: [PS4] Make __BIGGEST_ALIGNMENT__ 32bytes.

LGTM, sorry I missed this!

Mar 16 2022, 1:13 PM · Restricted Project, Restricted Project
probinson added a comment to D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5.

Mar 16 2022, 11:24 AM · Restricted Project, Restricted Project

Mar 15 2022

probinson abandoned D119040: Fix LookupTest where it was missing an assertion.

Thanks for the change, but the test is actually checking for rename in presence of using-decls. I beleive https://reviews.llvm.org/D121103 is the proper fix here.

Mar 15 2022, 10:39 AM · Restricted Project
probinson added a comment to D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html

I discovered the issue from the failed tests on https://reviews.llvm.org/D113718 where you can see the test output contains a checksum that otherwise doesn't appear. Passing -dwarf-version=6 reproduces the issue.

Mar 15 2022, 10:35 AM · Restricted Project, Restricted Project
probinson added a comment to D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

Fix tests with dwarf 6

Mar 15 2022, 6:42 AM · Restricted Project, Restricted Project

Mar 4 2022

probinson added a reviewer for D119040: Fix LookupTest where it was missing an assertion: hokein.

+ @hokein who has done work in the one place where replaceNestedName is used.

Mar 4 2022, 12:56 PM · Restricted Project
probinson committed rGe22e2774d933: [RGT] DistroTest: Separate environment-specific test functions (authored by probinson).
[RGT] DistroTest: Separate environment-specific test functions
Mar 4 2022, 12:29 PM · Restricted Project
probinson added inline comments to D121002: [DAG] Don't convert undef to 0 when creating buildvector.
Mar 4 2022, 10:29 AM · Restricted Project, Restricted Project
probinson added a comment to D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.

I think the encoding of the line table may make it infeasible to walk backwards. But perhaps the code that does interpret the line table could keep track of the most-recent-nonzero-line and return that in addition to (or instead of) zero, when the requested address does resolve to zero? If it's instead-of, the API would have to return an indication that it was approximated, so this could be displayed appropriately.

Mar 4 2022, 7:21 AM · Restricted Project, Restricted Project

Mar 3 2022

probinson committed rG7b85f0f32f81: [PS4] isPS4 and isPS4CPU are not meaningfully different (authored by probinson).
[PS4] isPS4 and isPS4CPU are not meaningfully different
Mar 3 2022, 8:38 AM · Restricted Project
probinson added a comment to D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.

Incidentally I agree with @jhenderson that there should be some indication in the output that a result is approximate.

Mar 3 2022, 7:41 AM · Restricted Project, Restricted Project
probinson added a comment to D120660: [llvm-symbolizer] Add --approximate-missing-line-numbers Command Line Option.

The decrementing solution came up because in the cases where we see this in the wild, it's symbolizing a backtrace (or possibly just one return address) and the return address naturally doesn't point to the call instruction, it points one past the call instruction; the instruction after a call might have line 0 for various reasons, the most blatant being that it's a noreturn call. But the call instruction itself nearly always will not have line 0.
So, _in practice_, we'll basically decrement once and be done.

Mar 3 2022, 7:30 AM · Restricted Project, Restricted Project

Feb 28 2022

probinson added inline comments to D111457: [test] Add lit helper for windows paths.
Feb 28 2022, 12:23 PM · Restricted Project, Restricted Project, Restricted Project

Feb 22 2022

probinson added a comment to D120066: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue..

Seems to me there have been other cases where .* matching was greedier than expected, so this seems like the right fix.

Feb 22 2022, 9:16 AM · Restricted Project

Feb 17 2022

probinson updated subscribers of D119040: Fix LookupTest where it was missing an assertion.

Ping; + @bkramer who reviewed the original patch that added this test.

Feb 17 2022, 10:05 AM · Restricted Project

Feb 14 2022

probinson added a comment to D118754: [DebugInfo] Always emit `.debug_names` with dwarf 5 for Apple platforms.

The ability to enable/disable accelerators on MachO (not currently possible - since it's hardcoded in the backend) - eg: someone adding -gno-pubnames to reduce debug info size, but in the process breaking lldb's behavior due to missing accelerator tables.

Feb 14 2022, 9:40 AM · Restricted Project

Feb 11 2022

probinson committed rGce5588fdf478: [RGT] Refactor environment-specific checks to use GTEST_SKIP() (authored by probinson).
[RGT] Refactor environment-specific checks to use GTEST_SKIP()
Feb 11 2022, 10:48 AM
probinson committed rGa0ac6a92125c: [RGT] Refactor Windows-specific checks into their own test (authored by probinson).
[RGT] Refactor Windows-specific checks into their own test
Feb 11 2022, 10:48 AM
probinson committed rGd2495b69f29d: [RGT] Exercise both paths through a test (authored by probinson).
[RGT] Exercise both paths through a test
Feb 11 2022, 10:48 AM
probinson added a reviewer for D119040: Fix LookupTest where it was missing an assertion: kadircet.

Ping; +@kadircet

Feb 11 2022, 6:30 AM · Restricted Project