probinson (Paul Robinson)
User

Projects

User Details

User Since
May 9 2013, 11:10 AM (288 w, 6 d)

Recent Activity

Yesterday

probinson added a comment to D54769: [FileCheck] New option -warn.

This is small enough that I'd prefer to see it incorporated into the patch with the "real" warning, rather than have this temporary placeholder diagnostic.

Wed, Nov 21, 8:29 AM

Tue, Nov 20

probinson created D54756: [DebugInfo] NFC Clang test changes for DISubprogram flags.
Tue, Nov 20, 8:02 AM · debug-info
probinson created D54755: [DebugInfo] IR/Bitcode changes for DISubprogram flags.
Tue, Nov 20, 8:00 AM · debug-info

Mon, Nov 19

probinson committed rL347271: It's its.
It's its
Mon, Nov 19, 2:56 PM
probinson committed rL347246: Fix build break from r347239.
Fix build break from r347239
Mon, Nov 19, 10:55 AM
probinson committed rC347239: [DebugInfo] DISubprogram flags get their own flags word. NFC..
[DebugInfo] DISubprogram flags get their own flags word. NFC.
Mon, Nov 19, 10:32 AM
probinson committed rL347239: [DebugInfo] DISubprogram flags get their own flags word. NFC..
[DebugInfo] DISubprogram flags get their own flags word. NFC.
Mon, Nov 19, 10:32 AM
probinson closed D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.
Mon, Nov 19, 10:32 AM · debug-info

Fri, Nov 16

probinson added a comment to D52999: [FileCheck] Annotate input dump (1/7).

Regarding the bit about environment variables, probably the right thing to do is add a lit.local.cfg to the FileCheck test directory, that zaps the environment variables. Then most individual FileCheck tests can assume a default environment, and tests for specific non-defaults can set the environment variables directly in the test file.
It would mean you can't run the FileCheck tests *from lit* with an environment variable set. Unless we invented another env var that lit.local.cfg would look for... but that's for another patch, at this point.

Fri, Nov 16, 11:00 AM
probinson added a comment to D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.

I think this looks good now.

Fri, Nov 16, 10:31 AM · debug-info
probinson added a comment to D52999: [FileCheck] Annotate input dump (1/7).

It really seems like DiagList and AnnotationList ought to be vectors, not lists. They are append-only, and AnnotationList gets converted to a vector anyway to sort it. The code doesn't depend on the element-pointer stability guarantee of a list, except in one place noted below which can be fixed.
It's quite possible a vector would perform less well, in the face of many diags/annotations, but as the diags/annotations are the unusual case, performance is not really a big consideration.

Fri, Nov 16, 10:28 AM
probinson updated the diff for D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.

Delete unneeded ctor. Clang-format.

Fri, Nov 16, 9:37 AM · debug-info

Thu, Nov 15

probinson updated the diff for D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.

Remove new .def file, move content into DebugInfoFlags.def.
Fix one oversight in Clang part, lit tests now all pass.

Thu, Nov 15, 2:24 PM · debug-info
probinson added a comment to D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.

Just to make sure I'm reading this correctly: This patch does not change the bitcode format in any way?

Thu, Nov 15, 12:41 PM · debug-info
probinson created D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC.
Thu, Nov 15, 12:25 PM · debug-info

Wed, Nov 14

probinson committed rL346861: Document how to comment an actual parameter..
Document how to comment an actual parameter.
Wed, Nov 14, 5:46 AM
probinson closed D54446: Document how to comment an actual parameter.
Wed, Nov 14, 5:46 AM
probinson added a comment to D54446: Document how to comment an actual parameter.

My experiments with clang-format show that it is aware of this convention. It will change /*Prefix*/nullptr to /*Prefix*/ nullptr (inserting a space) and will also change /*Prefix=*/ nullptr to /*Prefix=*/nullptr (removing the space, if the comment ends with =).

Wed, Nov 14, 5:40 AM

Tue, Nov 13

probinson added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

Okay, clearly I have not been paying attention. It's not that lit -v enables the warning, it is simply not suppressing the message. This is why lit without -v appears to turn it "off." I get it now. As far as FileCheck itself is concerned, this is always-on.
Have you tried running the entire suite with lit -v to see how often the diagnostic comes up? Now that you don't emit a diagnostic for the multiple-prefix case.

Tue, Nov 13, 1:24 PM
probinson added a comment to D54487: Implement llvm.commandline named metadata.

I don't really see a need for a new directive, it's convenient but does nothing you couldn't do with existing directives.
It does have some downside, in that it's supported only by the LLVM integrated assembler.

Tue, Nov 13, 12:53 PM

Mon, Nov 12

probinson created D54446: Document how to comment an actual parameter.
Mon, Nov 12, 1:48 PM
probinson committed rL346674: [DWARFv5] Emit split type units in .debug_info.dwo..
[DWARFv5] Emit split type units in .debug_info.dwo.
Mon, Nov 12, 8:58 AM
probinson closed D54350: [DWARFv5] Emit split type units in .debug_info.dwo.
Mon, Nov 12, 8:57 AM · debug-info

Fri, Nov 9

probinson created D54350: [DWARFv5] Emit split type units in .debug_info.dwo.
Fri, Nov 9, 1:21 PM · debug-info
probinson committed rL346540: [DWARFv5] Emit normal type units in .debug_info comdats..
[DWARFv5] Emit normal type units in .debug_info comdats.
Fri, Nov 9, 11:08 AM
probinson closed D54282: [DWARFv5] Emit normal type units in .debug_info comdats..
Fri, Nov 9, 11:08 AM · debug-info
probinson updated the diff for D54282: [DWARFv5] Emit normal type units in .debug_info comdats..

Make DwarfDebug responsible for picking which section to use.

Fri, Nov 9, 10:53 AM · debug-info
probinson added inline comments to D54282: [DWARFv5] Emit normal type units in .debug_info comdats..
Fri, Nov 9, 10:28 AM · debug-info
probinson added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

I hadn't thought about -v; I don't think the new diag is currently under -v? The first test isn't using that option...

Fri, Nov 9, 10:00 AM

Thu, Nov 8

probinson created D54282: [DWARFv5] Emit normal type units in .debug_info comdats..
Thu, Nov 8, 3:50 PM · debug-info
probinson added inline comments to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..
Thu, Nov 8, 11:42 AM
probinson added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

Because there is nothing to indicate that a line contains a FileCheck directive, other than that it pattern-matches a user-specified string with an optional suffix, we can't reliably report all typos. So for example:

CHECK-LABEL: A
CHECK: B
CHEKC: C

the third line can't be diagnosed by FileCheck under any reasonable heuristic. So, anything we do is a best-effort, and ideally produces no false positives by default.

Thu, Nov 8, 11:16 AM
probinson added a comment to D54217: Add total function byte size and inline function byte size to "llvm-dwarfdump --statistics".

Looks like I can piggy back on llvm/test/tools/llvm-dwarfdump/X86/statistics.ll

Does anyone know how to run only this test from command line?

Thu, Nov 8, 10:18 AM

Wed, Nov 7

probinson committed rLLD346360: [DWARFv5] Read and dump multiple .debug_info sections..
[DWARFv5] Read and dump multiple .debug_info sections.
Wed, Nov 7, 1:41 PM
probinson committed rL346360: [DWARFv5] Read and dump multiple .debug_info sections..
[DWARFv5] Read and dump multiple .debug_info sections.
Wed, Nov 7, 1:41 PM
probinson closed D53907: [DWARFv5] Read and dump multiple .debug_info sections.
Wed, Nov 7, 1:41 PM · debug-info
probinson added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

AMDGPU does this a lot intentionally for a shared label prefix and unique per run like ones for different subtargets

Yep. Briefly looked at AMDGPU warnings. The very first 4 warnings, in tests basic-loop.ll, basic-call-return.ll, bug-vopc-commute.ll, call-return-types.ll, shows I think that they are dodgy tests, but then I see indeed the intentional use of the shared label prefix.

You two seem to be saying that the concept of a "shared label prefix" justifies this use case. I'm sorry, but I don't know what that phrase means. Could someone please explain? In other words, couldn't these tests just use "CHECK:" (or "GCN:" or whatever prefix they prefer) without "-LABEL"? I believe that's Paul's position.

Wed, Nov 7, 12:04 PM
probinson added a comment to D54187: Add debuginfo-tests that use cdb on Windows.

(Dexter) will step through every line of the program it can, collecting info about each step until it reaches the program exit. It won't currently produce a pass/fail, but rather a score. That is, if it observes that 'x' is visible and has the value 42 it'll get a perfect score.

Seems like it would easy enough to base pass/fail on getting a perfect score, for the purpose of debuginfo-tests.

Wed, Nov 7, 10:52 AM · debug-info
probinson added a comment to D54187: Add debuginfo-tests that use cdb on Windows.

+gbedwell

Just to throw the idea out there, why not abandon debuginfo-tests entirely and try using Dexter for this. Dexter's design center is debug-info quality, not correctness, but it already knows how to drive several different debuggers on multiple platforms.
Dexter would have to become an LLVM project tool, and I'm not sure how Sony management feels about that, but I think this would be an awesome use-case.

Depends where we draw the distinction between quality and correctness. We specifically want a way to test that when we fix a correctness bug, it's actually fixed against Microsoft debuggers.

Wed, Nov 7, 9:04 AM · debug-info
probinson updated subscribers of D54187: Add debuginfo-tests that use cdb on Windows.

Just to throw the idea out there, why not abandon debuginfo-tests entirely and try using Dexter for this. Dexter's design center is debug-info quality, not correctness, but it already knows how to drive several different debuggers on multiple platforms.
Dexter would have to become an LLVM project tool, and I'm not sure how Sony management feels about that, but I think this would be an awesome use-case.

Wed, Nov 7, 8:51 AM · debug-info
probinson added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

I think what we've determined so far is that some uses of CHECK-LABEL simply misunderstand the LABEL suffix, which IMO is because the suffix is very poorly named. Renaming it to something harder to misunderstand would be a lot of churn but ultimately benefit the project's tests. The process of updating all tests with LABEL would necessarily find all the dodgy cases. And with a better-understood FileCheck feature, ultimately I think there would be fewer cases of bad tests.
(It would also help if people responsibly made sure their tests failed when their patch was NOT applied, but we have no process for this.)

Wed, Nov 7, 8:38 AM

Tue, Nov 6

probinson added inline comments to D53907: [DWARFv5] Read and dump multiple .debug_info sections.
Tue, Nov 6, 1:26 PM · debug-info
probinson accepted D53517: [FileCheck] Parse command-line options from FILECHECK_OPTS.

LGTM.
A patch to report an error on multiple -D of the same variable is probably a good thing, particularly since it doesn't work properly.

Tue, Nov 6, 1:06 PM
probinson added inline comments to D53517: [FileCheck] Parse command-line options from FILECHECK_OPTS.
Tue, Nov 6, 8:48 AM
probinson added a comment to D54129: [AArch64] [Windows] Trap after noreturn calls..

We already do this for X86, would it be better to make the check in non-target-specific code? (Just asking, not expressing an opinion.)

Tue, Nov 6, 8:37 AM
probinson added a comment to D54043: Adding debug info to support Fortran (part 1).

Even when DWARF adds something in response to the needs of a specific language, it doesn't use language names in the tags or attributes. So, I think putting "Fortran" in the symbol names here would be inconsistent with that. It's fine to describe it as a Fortran attribute in commentary.
As a hypothetical example, C++ has the concept of a "pure" virtual method declaration, and somebody might come up with a reason to mark those with the new Pure flag.
Which is another reason not to start overloading the existing flags based on assumptions about which languages use which flags. I've started sketching out what it would take to add a separate DISPFlags type/field in DISubprogram.

Tue, Nov 6, 7:45 AM · debug-info
probinson added a comment to D53907: [DWARFv5] Read and dump multiple .debug_info sections.

Ping. For my next trick I was going to do the patch that emits type units in .debug_info instead of .debug_types, for DWARF v5. Would it help to have that up first?

Tue, Nov 6, 6:44 AM · debug-info

Fri, Nov 2

probinson added inline comments to D54043: Adding debug info to support Fortran (part 1).
Fri, Nov 2, 3:14 PM · debug-info
probinson added inline comments to D54049: [DWARF v5] Verifier: Add checks for DW_FORM_strx* forms..
Fri, Nov 2, 2:49 PM
probinson added a comment to D54043: Adding debug info to support Fortran (part 1).

Procedural point: When you upload a diff to Phabricator, please include more context (-U999999 is typical).

Fri, Nov 2, 12:53 PM · debug-info
probinson added a comment to D46061: [DEBUGINFO, NVPTX] Disable emission of ',debug' option if only debug directives are allowed..

Looks like Eric still had some questions here? Or at least hadn't commented
about whether the answers/changes addressed his concerns?

Fri, Nov 2, 9:57 AM

Thu, Nov 1

probinson added a comment to D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink.

Please review all comments to ensure proper punctuation. There are a lot of missing full-stops.

Thu, Nov 1, 1:10 PM
probinson added a comment to D53992: [DebugInfo] Correctly sink DBG_VALUEs in postra-machine-sink.

Presumably this addresses the bad debugging experience for the sample from the PR; does it have any other good/bad effect on the Dexter corpus?

Thu, Nov 1, 1:01 PM
probinson accepted D46061: [DEBUGINFO, NVPTX] Disable emission of ',debug' option if only debug directives are allowed..

LGTM

Thu, Nov 1, 12:45 PM
probinson added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Nice :)
So seems the last unresolved question left is the naming of the new option?
If we do not want to go with -gsingle-file-split-dwarf then what it should be?

What about -fdebug-fission as an alias for -gsplit-dwarf.
And -fsingle-file-debug-fission for the new option?

Or, may be:

-fdebug-fission for the new option and then
-fdebug-fission -fdebug-split-dwo would work together as -gsplit-dwarf?

Thu, Nov 1, 10:27 AM

Wed, Oct 31

probinson added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Any distributed build has to make this work, so the paths in the line table are usable. Not clear what you're thinking might be the problem with the split-in-.o case.

Fair point - same sort of problem, but might need distinct handling (ie: might not work "for free" with existing tools, but need more support), etc, depending on how it's solved?

Mostly just wondering whether Clang would need extra flags to support this - to get a sense of the total/overall solution/surface area of the feature, etc.

Wed, Oct 31, 11:34 AM
probinson added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

I guess in that case your distributed build system would have a constraint that it always ships all the object files back to the primary machine (where you'd be running the debugger)? (perhaps it just always runs the link locally - even though it distributes the compilations - I guess that's probably how things like distcc work, where they only inject themselves into the compilation command, not the linking command maybe?)

Wed, Oct 31, 11:08 AM

Tue, Oct 30

probinson added a comment to D53907: [DWARFv5] Read and dump multiple .debug_info sections.

I reordered the units in the test file, because llvm-dwarfdump will dump all the .debug_info bits before going on to the .debug_types bits. The order of the sections in the file doesn't matter, but the order of the CHECKs does, and this was the simplest way to deal with it.

Tue, Oct 30, 3:26 PM · debug-info
probinson created D53907: [DWARFv5] Read and dump multiple .debug_info sections.
Tue, Oct 30, 3:21 PM · debug-info
probinson added a comment to D52827: [LICM] Make LICM able to hoist phis.

Does this lose debug information? I do very little with optimization passes so I don't know, but it would be nice to keep it in mind.

Tue, Oct 30, 11:03 AM
probinson added inline comments to D53545: [DWARF][NFC] NFC patch for reverted r342218 (refactoring rangelist handling).
Tue, Oct 30, 10:55 AM

Fri, Oct 26

probinson added a comment to D53710: [FileCheck] Warn if a prefix is only used in LABEL checks.

Thanks for looking at this! Answering this one first:

Have you run existing test suites to see how many warnings you get?

I just did, and it came back with some interesting results. For example test/CodeGen/ARM/Windows/mangling.ll:

; RUN: llc -mtriple=thumbv7-windows -mcpu=cortex-a9 -o - %s | FileCheck %s
define void @function() nounwind {
entry:
  ret void
}
; CHECK-LABEL: function

This shows that just checking the label is actually a use-case, which is why I thought a warning would be better; looks like we can't promote it to an error (which is okay I think).

Why isn't that just CHECK? Is that a legitimate use case?

Fri, Oct 26, 8:49 AM

Wed, Oct 24

probinson committed rL345203: Make llvm-dwarfdump -name work on type units..
Make llvm-dwarfdump -name work on type units.
Wed, Oct 24, 2:54 PM
probinson closed D53672: Make llvm-dwarfdump -name work on type units..
Wed, Oct 24, 2:54 PM · debug-info
probinson created D53672: Make llvm-dwarfdump -name work on type units..
Wed, Oct 24, 2:19 PM · debug-info
probinson accepted D47811: [PATCH] [DWARF] Kotlin language.

I've put a note out to the DWARF committee to see if we can streamline the assignment of language codes. As long as there is a source of truth for these, we shouldn't have to wait for DWARF 6 to be published.
The idea has come up before, and now with a motivating case I think it's likely to happen. So if you could hold off a little longer (probably a few days) I can have an answer for you on that point.

Ok I'll wait as long as required, for now I've updated diff regarding my understanding of our yesterday conversation. Thank you for cooperation.

Wed, Oct 24, 11:07 AM

Tue, Oct 23

probinson added a comment to D53519: [CodeGen] skip lifetime end marker in isInTailCallPosition.
In D53519#1272775, @rnk wrote:

Is there some more general property for us to check that this intrinsic shares with other annotation-like intrinsics like llvm.assume?

Tue, Oct 23, 12:28 PM
probinson added a comment to D47811: [PATCH] [DWARF] Kotlin language.

I've put a note out to the DWARF committee to see if we can streamline the assignment of language codes. As long as there is a source of truth for these, we shouldn't have to wait for DWARF 6 to be published.
The idea has come up before, and now with a motivating case I think it's likely to happen. So if you could hold off a little longer (probably a few days) I can have an answer for you on that point.

Tue, Oct 23, 12:22 PM

Oct 22 2018

probinson added inline comments to D46878: Add DW_AT_linkage_name for DW_TAG_labels.
Oct 22 2018, 11:10 AM

Oct 19 2018

probinson added a comment to D47073: Document and Enforce new Host Compiler Policy.

Following up from the BoF and the corresponding email thread:
I think we want to distinguish the general guideline/intent (support N years/releases) from the firm statement "we are actually going to require *this* minimum version starting on *this* date." There seems to be some resistance to having the latter happen on a strict timeline.
Having separated out those two things, we should specify a minimum lead time for the firm statement to go from a warning to an error. I threw out 3 months as a starting point for discussion; I don't think it can reasonably be any less than that. Upgrades like this need to be tested, deployed to lots of people and bots, issues found and corrected. These things take time.

Oct 19 2018, 6:53 PM
probinson updated subscribers of D53364: [llvm-dwarfdump] - Add the support of parsing .debug_loclists..

+wolfgang who has been working in this area also

Oct 19 2018, 12:08 PM
probinson updated subscribers of D47811: [PATCH] [DWARF] Kotlin language.

+echristo re defining an LLVM range of language codes.

Oct 19 2018, 12:05 PM
probinson requested changes to D47811: [PATCH] [DWARF] Kotlin language.

It would be safer if we came up with an LLVM extension range for language constants (assuming the DWARF committee doesn't change the process for assigning language constants). It will be years before DWARF v6 comes out and there is a very reasonable chance that the numbers won't match.
I'd rather we don't ship any LLVM that could emit an incorrect language code.

Oct 19 2018, 12:04 PM

Oct 3 2018

probinson added a comment to D52444: [DWARF] Make llvm-dwarfdump display the .debug_loc.dwo section (fixes PR38991).

(also, I did go back and read the spec - and you're right that call_ref uses an address-width-sized value, and that it could be used in debug_loclists.dwo.

Oct 3 2018, 10:31 AM

Oct 1 2018

probinson added a comment to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

Yes, with this patch, only decimal scale is supported and i will add binary scale as well. (will modify this patch), and related changes too.
and about the front-end, we have a pl1/cobol llvm based front-end (in development) which generates this info.

Oct 1 2018, 4:16 PM · debug-info

Sep 27 2018

probinson added a comment to D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

What I meant by "use case" is, do you have a front end that will make use of these new features?

Sep 27 2018, 12:09 PM · debug-info

Sep 26 2018

probinson updated subscribers of D52295: [DebugInfoMetadata] Added support to generate packed_decimal encoding related dwarf info..

clang-format-diff is your friend.

Sep 26 2018, 5:56 PM · debug-info

Sep 21 2018

probinson added a comment to D52296: [Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option..

Do we generate the .dwo file directly these days? If not, I can imagine wanting to avoid the overhead of the objcopy hack; as long as the linker is smart enough not to bother with the .debug_*.dwo sections this seems like a build-time win.

Sep 21 2018, 7:21 AM

Sep 19 2018

probinson accepted D51908: [DebugInfo] Do not generate address info for removed labels..

LGTM

Sep 19 2018, 11:41 AM

Sep 18 2018

probinson added inline comments to D51908: [DebugInfo] Do not generate address info for removed labels..
Sep 18 2018, 10:40 AM
probinson added inline comments to D52223: [dwarfdump] Verify DW_AT_type..
Sep 18 2018, 10:34 AM · debug-info
probinson added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 18 2018, 6:25 AM · debug-info

Sep 17 2018

probinson added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
In D51976#1237392, @vsk wrote:

I expect that extending dbg.value in this way will be fairly involved. There are a couple questions worth thinking about, imo:

  • Would the extra SSA values need to be constants (or live in registers)? If not, how will their locations be represented in a TAG_variable entry?
  • What's the expected memory size overhead of adding an extra operand to dbg.value? Does it need to be counterbalanced by introducing dbg.value.simple() [for the case where there is an empty DIExpression/extended SSA stack]?
Sep 17 2018, 2:30 PM · debug-info
probinson added a comment to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.

Having read the real testcase now, I understand why you are dropping the debug info now. I would like to point out that we could do better. If we extended llvm.dbg.value to take more than one LLVM SSA Value, then we could produce a DIExpression that selects either %add or %sub depending on the value of %cmp. Let me know if you are interested in implementing this, it should be relatively straight forward to do and would come in useful in all sorts of other situations, too.

That is a very good idea and I am interested in implementing it. A good opportunity to improve my knowledge in that area. I can see the associated benefits.

Sep 17 2018, 10:34 AM · debug-info

Sep 14 2018

probinson added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

Perhaps we could implement this behavior (pr: i.e., omitting the label if it has been optimized away) only if we're tuning for GDB & otherwise produce a label without a low_pc? Not sure how other folks (@aprantl @echristo @probinson @JDevlieghere) feel about this - apply the workaround generally, because it's not super important to have a label for name-lookup porpoises? or is it worth carrying the two codepaths to ensure that slightly more accurate debug info where it's possible (presuming LLDB can cope with it)?

Sep 14 2018, 3:36 AM

Sep 13 2018

probinson added inline comments to D51935: [LLDB] - Improved DWARF5 support..
Sep 13 2018, 4:12 AM

Sep 12 2018

probinson added inline comments to D51976: [DebugInfo][Dexter] Speculated BB presents illegal variable value to debugger.
Sep 12 2018, 9:08 AM · debug-info
probinson added a comment to D51908: [DebugInfo] Do not generate address info for removed labels..

Can you preserved the declaration DIE (at 0x0000007c) while omitting the definition DIE (at 0x00000063)? Does that still cause a problem for GDB?

Sep 12 2018, 2:18 AM

Sep 4 2018

probinson added inline comments to D51640: [DebugInfo] Normalize common kinds of DWARF sub-expressions..
Sep 4 2018, 1:50 PM · debug-info
probinson added inline comments to D51640: [DebugInfo] Normalize common kinds of DWARF sub-expressions..
Sep 4 2018, 12:29 PM · debug-info
probinson updated subscribers of D51340: Add /Zc:DllexportInlines option to clang-cl.

+cfe-commits

Sep 4 2018, 8:12 AM

Aug 28 2018

probinson added a comment to D51315: [debuginfo] generate debug info with asm+.file.

Awesome thanks!

Aug 28 2018, 7:21 AM

Aug 27 2018

probinson accepted D51315: [debuginfo] generate debug info with asm+.file.

The indentation in the test looks a little odd. Please verify there are no hard tabs.
Otherwise LGTM.

Aug 27 2018, 12:55 PM

Aug 22 2018

probinson added inline comments to D51081: [DWARF v5] Refactoring range list dumping to fold DWARF v4 functionality into v5 handling (almost NFC)..
Aug 22 2018, 2:46 PM

Aug 10 2018

probinson added inline comments to D50525: [WIP] Move lldb-mi interpreter tests to LIT.
Aug 10 2018, 8:54 AM

Aug 8 2018

probinson committed rL339302: [DWARF] Verifier now handles .debug_types sections..
[DWARF] Verifier now handles .debug_types sections.
Aug 8 2018, 4:51 PM
probinson closed D50466: [DWARF] Verifier now handles .debug_types sections..
Aug 8 2018, 4:51 PM
probinson added inline comments to D50466: [DWARF] Verifier now handles .debug_types sections..
Aug 8 2018, 4:39 PM
probinson created D50466: [DWARF] Verifier now handles .debug_types sections..
Aug 8 2018, 10:48 AM

Aug 7 2018

probinson abandoned D50197: [DebugInfo/DWARF] Try to make a loop more readable. NFC.

I'm abandoning this minor tweak as I am convinced that there is something more fundamentally wrong here.
llvm-dwarfdump doesn't call the right API sequence to show the bug; it requires a DWP, looking up a specific unit by hash via the DWP index, and then scanning all the units. I can envision how to do a unittest for that, but the unittest infrastructure doesn't currently support building a DWP. I can't take the time right now to address this, but I'll keep it on The List.

Aug 7 2018, 10:47 AM · debug-info