Page MenuHomePhabricator

probinson (Paul Robinson)
User

Projects

User Details

User Since
May 9 2013, 11:10 AM (323 w, 3 d)

Recent Activity

Today

probinson accepted D65039: [DWARF] Add named constants for reserved values of an initial length field..

LGTM

Mon, Jul 22, 7:36 AM · Restricted Project

Fri, Jul 19

probinson added a comment to D64971: [SafeStack] Insert the deref after the offset.
In D64971#1593796, @vsk wrote:

AFAICT the deref is always needed here: my understanding is that dbg.value has to describe the actual value of a variable, not its address (https://www.llvm.org/docs/LangRef.html#diexpression). I admit that keeping the deref may break the dwarf builder, but istm that indicates a bug in the dwarf builder.

Fri, Jul 19, 10:23 AM · Restricted Project

Thu, Jul 18

probinson added a comment to D64893: Ask confirmation when `git llvm push` will push multiple commits.

+1 for defaulting to No.
As a follow-up patch, maybe the script could offer to squash the commits for you.

Thu, Jul 18, 10:59 AM · Restricted Project
probinson added a comment to D64923: [FileCheck]] Canonicalize caret location testing.

Readability is to some extent in the eye of the reader, so I've restrained myself to one suggestion. Otherwise this review is up to James.

Thu, Jul 18, 9:34 AM · Restricted Project
probinson added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 6:44 AM · Restricted Project
probinson added a comment to D63713: Add error handling to the DataExtractor class.

I have been reminded that there's also a desire to make DataExtractor work with 64-bit section sizes. Maybe Cursor should use a 64-bit offset (i.e., size_t not uint32_t), and then migrating from non-Cursor to Cursor APIs will also do the 64-bit transition? We need to bite that bullet at some point. (I kind of expect y'all to say, no way do that later, which is fine; mainly I wanted to refresh that in our collective minds.)

Thu, Jul 18, 6:30 AM · Restricted Project
probinson added a comment to D64875: Add LLVM's LICENSE.txt file to the monorepo root.

@probinson I don't understand what you mean -- what's the issue you see with adding this file right now?

Thu, Jul 18, 6:19 AM · Restricted Project

Wed, Jul 17

probinson added a comment to D64875: Add LLVM's LICENSE.txt file to the monorepo root.

This is imposing a requirement on how downstream projects manage their license files. I'm not saying we can't (eventually) do it this way, but I'm quite sure that's not how Sony handles it right now.

Wed, Jul 17, 11:50 AM · Restricted Project
probinson added a comment to D64544: [DWARF] Add more error handling to debug line parser..

How would you be able to emit a wrong form value for the MD5 hash from assembly? The directive (which I think you came up with?) is just md5 [data]? Deciding which form to emit is hard-coded in MCDwarf.

Wed, Jul 17, 11:39 AM · Restricted Project
probinson added a comment to D64544: [DWARF] Add more error handling to debug line parser..

I was rather hoping for test coverage for all the new error messages this change introduced - is that unrealistic/impractical?

Yeah, the line table is especially tricky to hand-craft compared to checking in an object file. I think it technically can still be hand-crafted assembly (no line directives, etc, just a debug_line section with raw byte (etc) directives) - might be plausible & make it clearer what the input is? (checked in assembly, assembled with llvm-mc then run through llvm-dwarfdump to test the parsing)

Wed, Jul 17, 10:58 AM · Restricted Project
probinson added a comment to D57400: Add a .gitignore file to the root that ignores any files outside of the project directories..

What about downstream users that have added directories in their local forks? Having git suddenly ignore them would be surprising. We are in that situation.

Wed, Jul 17, 10:45 AM
probinson accepted D63713: Add error handling to the DataExtractor class.

I'm happy, but other people obviously have better eyesight than I do. Give Jonas and Blaikie a day to chime in, I think.

Wed, Jul 17, 8:04 AM · Restricted Project

Tue, Jul 16

probinson added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Tue, Jul 16, 9:58 AM · Restricted Project
probinson added a comment to D63713: Add error handling to the DataExtractor class.

Minor stuff.

Tue, Jul 16, 8:53 AM · Restricted Project

Mon, Jul 15

probinson added reviewers for D64780: Disallow most calling convention attributes on PS4.: rnk, rjmccall.

This has my blessing as PS4 code owner, but I'd like other eyes on it with respect to how we've gone about it.
+ rnk, rjmccall as the most likely suspects.

Mon, Jul 15, 5:31 PM · Restricted Project, Restricted Project
probinson accepted D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

If you found the unittests cases because they failed, that's good enough for me.
LGTM

Mon, Jul 15, 8:15 AM · Restricted Project
probinson added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

I mean, the purposes for the patches are different. This one fixes an existing flaw while your suggestion improves code quality. It is usually better not to intermix such different aims in one patch, no?

Mon, Jul 15, 7:13 AM · Restricted Project

Fri, Jul 12

probinson added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

Right, but maybe that worths another patch?

Fri, Jul 12, 11:19 AM · Restricted Project
probinson added a comment to D64630: [DebugInfo] Address performance regression with r364515.

With ASAN, packs of up to 800 DBG_VALUEs in a row appear (for that file)

Fri, Jul 12, 11:10 AM · Restricted Project
probinson added a comment to D64622: [DWARF] Fix the reserved values for unit length in DWARFDebugLine..

This magic number appears in many places; it should have a symbolic name in llvm/include/llvm/BinaryFormat/Dwarf.h, in the LLVMConstants enumeration.

Fri, Jul 12, 11:03 AM · Restricted Project

Thu, Jul 11

probinson committed rG2cb5c46e670c: [clangd] Fix MSVC build failure. (authored by probinson).
[clangd] Fix MSVC build failure.
Thu, Jul 11, 4:49 PM
probinson committed rL365844: [clangd] Fix MSVC build failure..
[clangd] Fix MSVC build failure.
Thu, Jul 11, 4:47 PM
probinson added a comment to D64033: Add column info for inline sites.

LGTM2

Thu, Jul 11, 3:12 PM · Restricted Project

Wed, Jul 10

probinson added a comment to D64033: Add column info for inline sites.

If the change from DW_AT_MIPS_linkage_name to DW_AT_linkage_name made you think the older .o files were MIPS, more likely it is a change in the default DWARF version; older versions of DWARF did not have DW_AT_linkage_name.

Wed, Jul 10, 10:46 AM · Restricted Project
probinson added a comment to D64231: [FileCheck] Simplify numeric variable interface.

I was under the impression that an assertion in the public interface of a library API was not a great idea.

Oops my bad, I forgot about that comment. I think only what's in the FileCheck class should be considered public API. The rest ought to be moved to a different header file and is private. FileCheckNumericVariable is an implementation details IMO.

Wed, Jul 10, 10:34 AM · Restricted Project

Tue, Jul 9

probinson added a comment to D64033: Add column info for inline sites.

I guess we can leave the .s file tests alone. Most of them look like they were derived from real -S output and it would be pedantically consistent to update them, but they don't have to be.
@JDevlieghere once you sort out the odr-member-functions the patch is fine with me. I am mildly curious why all three .o files got smaller.

Tue, Jul 9, 5:19 PM · Restricted Project
probinson committed rG9e04b532dfe2: [CXX] Exercise all paths through these tests. (authored by probinson).
[CXX] Exercise all paths through these tests.
Tue, Jul 9, 1:50 PM
probinson committed rL365555: [CXX] Exercise all paths through these tests..
[CXX] Exercise all paths through these tests.
Tue, Jul 9, 1:49 PM
probinson closed D63894: [CXX] Exercise all paths through these tests.
Tue, Jul 9, 1:48 PM · Restricted Project, Restricted Project
probinson added inline comments to D63894: [CXX] Exercise all paths through these tests.
Tue, Jul 9, 12:58 PM · Restricted Project, Restricted Project
probinson added inline comments to D64189: Allow llc to run passes under the new pass manager one at a time..
Tue, Jul 9, 9:39 AM · Restricted Project
probinson added a comment to D63894: [CXX] Exercise all paths through these tests.

there is no reason to think those paths are tested elsewhere.

Tue, Jul 9, 9:39 AM · Restricted Project, Restricted Project
probinson added a comment to D63894: [CXX] Exercise all paths through these tests.

I would've assumed these conditionals were added by Sony folks for their change in default dialect - that doesn't necessarily mean these tests are needed upstream (the functionality may be tested elsewhere)

Tue, Jul 9, 9:32 AM · Restricted Project, Restricted Project
probinson added a comment to D64188: [NewPM] Port the MIR Printing pass to new pass manager..

Minor stylistic things. Someone who understands passes should look at this.

Tue, Jul 9, 9:21 AM · Restricted Project
probinson added a comment to D64184: [NewPM] Port MachineCopyPropagation to the new pass manager..

Minor drive-by stylistic points. Someone who knows what's going on with passes should look at this.

Tue, Jul 9, 8:54 AM · Restricted Project
probinson added inline comments to D64407: [DWARF] Simplify DWARFAttribute. NFC..
Tue, Jul 9, 8:39 AM · Restricted Project

Mon, Jul 8

probinson committed rG62cbe8ce250f: Fix line endings. NFC (authored by probinson).
Fix line endings. NFC
Mon, Jul 8, 3:36 PM
probinson committed rL365402: Fix line endings. NFC.
Fix line endings. NFC
Mon, Jul 8, 3:35 PM
probinson added a comment to D64231: [FileCheck] Simplify numeric variable interface.

I was under the impression that an assertion in the public interface of a library API was not a great idea.

Mon, Jul 8, 10:40 AM · Restricted Project
probinson accepted D64332: [docs][llvm-dwarfdump] Make some option descriptions clearer and more precise.

LGTM

Mon, Jul 8, 10:35 AM · Restricted Project
probinson added a comment to D64326: Retire VS2015 Support.

So, the point of this is to be able to remove certain workarounds, rather than advance the language feature set, IIUC.
Note that not all workarounds can be removed if we claim our minimum is the very first release of VS2017; see my r361502, to work around something that all of the bots were happy with.
I'm "once burnt, twice shy" about this, because we're not verifying that our claimed minimum build compilers are actually usable.
What is the minimum version of VS2017 used by any bot? Perhaps we should assert that as the minimum, which then makes it my fault for having a too-old build compiler.

Mon, Jul 8, 10:34 AM · Restricted Project
probinson added inline comments to D64332: [docs][llvm-dwarfdump] Make some option descriptions clearer and more precise.
Mon, Jul 8, 8:42 AM · Restricted Project

Sun, Jul 7

probinson added a comment to D63894: [CXX] Exercise all paths through these tests.

Ping. This is pretty straightforward, the only question is whether we want to preserve these older-dialect tests or rip them out.

Sun, Jul 7, 3:42 PM · Restricted Project, Restricted Project
probinson accepted D64135: [lit] Parse command-line options from LIT_OPTS.

LGTM

Sun, Jul 7, 3:37 PM · Restricted Project

Wed, Jul 3

probinson added a comment to D64135: [lit] Parse command-line options from LIT_OPTS.

lit has options?

Wed, Jul 3, 3:36 PM · Restricted Project

Tue, Jul 2

probinson accepted D64036: [Bitcode] Update CHECK-DAG usage in tests.

LGTM

Tue, Jul 2, 1:29 PM · Restricted Project
probinson committed rGa5f3e278c8e0: Use --defsym instead of sed in a test. NFC (authored by probinson).
Use --defsym instead of sed in a test. NFC
Tue, Jul 2, 7:50 AM
probinson committed rL364929: Use --defsym instead of sed in a test. NFC.
Use --defsym instead of sed in a test. NFC
Tue, Jul 2, 7:50 AM
probinson committed rGca4e80182e38: Fix line endings (NFC) (authored by probinson).
Fix line endings (NFC)
Tue, Jul 2, 6:14 AM
probinson committed rL364919: Fix line endings (NFC).
Fix line endings (NFC)
Tue, Jul 2, 6:14 AM
probinson added a comment to D64033: Add column info for inline sites.

I suspect there are more tests that must or should be updated; grepping for "DW_AT_call_" turns up for example:
llvm/test/DebugInfo/NVPTX/debug-info.ll
llvm/test/DebugInfo/X86/dbg-value-inlined-parameter.ll
llvm/test/tools/dsymutil/odr-member-functions.cpp

Tue, Jul 2, 5:23 AM · Restricted Project
probinson updated subscribers of D64036: [Bitcode] Update CHECK-DAG usage in tests.

+adrian who reviewed the patch that introduced upgrade-pointer-address-space.ll.

Tue, Jul 2, 4:55 AM · Restricted Project

Thu, Jun 27

probinson created D63894: [CXX] Exercise all paths through these tests.
Thu, Jun 27, 1:29 PM · Restricted Project, Restricted Project
probinson committed rG1339f74b8a3a: [debug-info] Make a couple of tests more robust. (authored by probinson).
[debug-info] Make a couple of tests more robust.
Thu, Jun 27, 8:54 AM
probinson committed rL364556: [debug-info] Make a couple of tests more robust..
[debug-info] Make a couple of tests more robust.
Thu, Jun 27, 8:53 AM

Wed, Jun 26

probinson added a comment to D46628: [ELF] Add --strip-debug-non-line option.

While all this (the behavior of gmlt) seems unrelated to this patch, really (I agree/understand your description - if you really want to be able to compile things once and link them into debug-ish and non-debug-ish forms, something like the --strip-debug-non-line sounds nice though I can also understand some push-back against it, since it's necessarily going to make broken DWARF, well, except in DWARFv5 where there's an intentional way to support line-table-only debug info (the line table has its own string table, so you can strip /everything/ (including debug_info) except debug_line and debug_line_str, I believe) - perahps that'd be a good way to implement this in a more principled way - work for DWARFv5 only (it wouldn't necessarily need/want to check DWARF version, but be designed to work correctly for DWARFv5 & be weird/bad/problematic before that))

Wed, Jun 26, 10:55 AM · Restricted Project

Mon, Jun 24

probinson added a comment to D63713: Add error handling to the DataExtractor class.

The new API doesn't let you eliminate *all* checks. :-)
Also it introduces some new dependencies as noted inline.

Mon, Jun 24, 11:27 AM · Restricted Project

Jun 21 2019

probinson added a comment to D63591: DWARFDebugLoc: Make parsing and error reporting more robust.

Pick whatever mechanism you like, we should debate it in that patch not here. :-)

Jun 21 2019, 7:34 AM · Restricted Project
probinson added a comment to D63591: DWARFDebugLoc: Make parsing and error reporting more robust.

Ah, hadn't considered statefulness. But if you layer another class on top of DataExtractor to handle the error flag, it would have to be replicating all the offset-is-valid checks, because of course DataExtractor itself doesn't return errors.

Jun 21 2019, 6:56 AM · Restricted Project
probinson committed rL364039: Fix a crash with assembler source and -g..
Fix a crash with assembler source and -g.
Jun 21 2019, 6:18 AM
probinson committed rG26cc5bcb1a39: Fix a crash with assembler source and -g. (authored by probinson).
Fix a crash with assembler source and -g.
Jun 21 2019, 6:09 AM
probinson closed D63573: Fix a crash with assembler source and -g..
Jun 21 2019, 6:09 AM · Restricted Project, debug-info
probinson added a comment to D63591: DWARFDebugLoc: Make parsing and error reporting more robust.

Removing that llvm_unreachable is fine, in that case.
The idea for error handling for DataExtractor sounds reasonable, looks like adding an error flag wouldn't even increase the size.

Jun 21 2019, 5:13 AM · Restricted Project

Jun 20 2019

probinson added inline comments to D63591: DWARFDebugLoc: Make parsing and error reporting more robust.
Jun 20 2019, 1:42 PM · Restricted Project
probinson accepted D63591: DWARFDebugLoc: Make parsing and error reporting more robust.

LGTM but give the West Coast folks a chance to look at it.

Jun 20 2019, 6:43 AM · Restricted Project
probinson added a comment to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

I think I am happy with this, leaving the rest up to James.

Jun 20 2019, 6:35 AM · Restricted Project
probinson added a comment to D63591: DWARFDebugLoc: Make parsing and error reporting more robust.

Looks pretty good, and thanks especially for the error-case tests!
I'll give other folks a chance to chime in if they want to.

Jun 20 2019, 5:56 AM · Restricted Project

Jun 19 2019

probinson added a comment to D63573: Fix a crash with assembler source and -g..

We do not precisely match gcc/gas behavior in some more-peculiar cases, but my assertion is that those should not occur "naturally" and so it's okay. For example:

foo:
    nop
    .file 1 "a.c"

This will cause gcc/gas to emit an error to the effect that file number 1 is already defined (implicitly, because of the line-table record for the first instruction). Clang/llvm-mc will not, we'll just emit an odd-looking line table. I can see how to cause clang/llvm-mc to emit this error, but it feels like it would be a hack done just to match gcc's (likely unintentional) error-detection behavior for an ill-formed assembler file.

Jun 19 2019, 2:36 PM · Restricted Project, debug-info
probinson created D63573: Fix a crash with assembler source and -g..
Jun 19 2019, 2:25 PM · Restricted Project, debug-info
probinson accepted D63125: FileCheck: Return parse error w/ Error & Expected.

LGTM.

Jun 19 2019, 7:11 AM · Restricted Project
probinson accepted D63500: [FileCheck] Stop qualifying expressions as numeric.

LGTM

Jun 19 2019, 6:57 AM · Restricted Project
probinson accepted D63539: [FileCheck] Fix fct param immediate comment style.

LGTM.

Jun 19 2019, 6:51 AM · Restricted Project
probinson added a comment to D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

In any event, this is a project policy change and should have an RFC on llvm-dev, not be proposed in a patch.

Jun 19 2019, 6:47 AM · Restricted Project

Jun 18 2019

probinson added a comment to D63500: [FileCheck] Stop qualifying expressions as numeric.

I think this is a definite improvement in readability, once you fix the two places that seem to have lost a line of commentary.

Jun 18 2019, 12:38 PM · Restricted Project
probinson added a comment to D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

I see the point; certainly when someone emails a patch, the first response is almost always "can you put this on Phab."

Jun 18 2019, 12:19 PM · Restricted Project
probinson added a comment to D58335: [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame..

The dwarfdump changes look okay, but the new tests don't exercise those changes. The simplest thing is probably to RUN llvm-dwarfdump in relax-debug-frame.ll and verify the output describes the frame as expected.

Jun 18 2019, 9:00 AM · Restricted Project
probinson added a comment to D63488: [docs] Phabricator, not the lists is the main entry point for new patches.

Requiring Phabricator raises the barrier to one-off patches from casual contributors, because using Phabricator requires a registration step.
I don't think we should require it until casual users with drive-by patches can contribute easily.

Jun 18 2019, 8:11 AM · Restricted Project

Jun 17 2019

probinson added a comment to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Regarding what to call the @LINE+offset form, I think it's fine to call it "legacy" in the user-facing documentation, but it gets to be a bit much in the internals. I haven't commented every use but you will get the idea in the inline comments.

Jun 17 2019, 2:37 PM · Restricted Project
probinson added inline comments to D58033: Add option for emitting dbg info for call site parameters.
Jun 17 2019, 11:39 AM · Restricted Project, debug-info
probinson added a comment to D54348: Permit multiple .file directives with -g.

As I mentioned in PR38449, I plan to look at this starting this week. Even benign situations such as

foo:
.file 1 "a.c"

are tripping over the assertion. I think the correct tactic is not to remove the places that are doing the checks, but make those places do a better job of tidying up anything that had been done in response to the command-line -g in favor of allowing the embedded directives to DTRT.

Jun 17 2019, 10:21 AM · Restricted Project, debug-info

Jun 5 2019

probinson accepted D60386: FileCheck [6/12]: Introduce numeric variable definition.

I am pretty sure all @jhenderson comments have been addressed, and I'm happy, so LGTM.
As I said previously, it may be a while before I get to your next patch.

Jun 5 2019, 8:18 AM · Restricted Project

Jun 4 2019

probinson added a comment to D60386: FileCheck [6/12]: Introduce numeric variable definition.

Ah ha. The ParenGroup referring to the CHECK line as it has been translated for consumption by the underlying regex package... that was not clear.
In which case the terminology is okay but the commentary could be better, see inline comment.

Jun 4 2019, 10:16 AM · Restricted Project
probinson added a comment to D60386: FileCheck [6/12]: Introduce numeric variable definition.

Grammar nits and one longer point, which is:
I understand where the "parenthesis group" term came from, but I think it's not appropriate here. While a CHECK line is implicitly a regex, and variables are a kind of back-reference, the syntax for variable references (use or def) is not parentheses and the content is not a "group" in any real sense, and so "parenthesis group" is an un-obvious and confusing term.
Because FileCheck uses square brackets, I propose that the least disruptive change at this point would be to call them "bracket expressions." The "bracket" part is obvious, and "expression" because (a) definitions will have a regex, and (b) numeric variable references are implicitly expressions. (Okay, still a bit of a stretch, but less so that "parenthesis group" IMO.)
WDYT?

Jun 4 2019, 9:16 AM · Restricted Project
probinson added a comment to D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC.

Is the compiler missing a check that these parameters are immediates?

Jun 4 2019, 5:45 AM · Restricted Project, Restricted Project

Jun 3 2019

probinson accepted D62084: Fix DWARF DebugInfo unit test errors when cross-compiling.

LGTM

Jun 3 2019, 12:55 PM · Restricted Project
probinson added a comment to D62634: Improve DWARF parsing and accessing by 1% to 2%.

This is intentional behavior in clang (controllable under the -f[no-]split-dwarf-inlining flag, and modified by the -f[no-]debug-info-for-profiling flag).

This extra debug info is used for online symbolication (in the absence of .dwo files) - such as for the sanitizers (accurate symbolication is necessary for correctness in msan, due to msan's necessary use of blacklisting to avoid certain false positives) and some forms of sample based profiling collection.

In the default mode, clang includes, as you noted, just the subprograms that have inlined subroutines in them in this split-dwarf-inlining data.
In -fdebug-info-for-profiling all subprograms are described in the skeleton CU with some minimal attributes (they don't need parameters, local variables/scopes, etc) necessary to do certain profile things I don't know lots about.

Jun 3 2019, 9:15 AM
probinson accepted D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..

Well, the results are at least defined now. Please make sure the commit log mentions "e.g. fold-sext-trunc.ll".
LGTM

Jun 3 2019, 6:31 AM · Restricted Project
probinson added inline comments to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Jun 3 2019, 6:15 AM · Restricted Project
probinson added inline comments to D62805: [DebugInfo] Fix possible invalid dereference of non-engaged Optional..
Jun 3 2019, 5:20 AM · Restricted Project

May 23 2019

probinson added inline comments to D62196: [LiveDebugValues] Close range for previous variable's location when deducing new variable's location.
May 23 2019, 9:20 AM · Restricted Project, debug-info
probinson accepted D62323: [FileCheck] Remove llvm:: prefix.

LGTM, although I commonly see llvm::make_unique to document that we are specifically not using the std:: one. On occasion it is actually ambiguous.

May 23 2019, 9:04 AM · Restricted Project
probinson added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
May 23 2019, 8:58 AM · Restricted Project
probinson committed rGc63b37dd408e: Work around a Visual C++ bug. (authored by probinson).
Work around a Visual C++ bug.
May 23 2019, 8:09 AM
probinson committed rL361502: Work around a Visual C++ bug..
Work around a Visual C++ bug.
May 23 2019, 8:08 AM
probinson committed rC361502: Work around a Visual C++ bug..
Work around a Visual C++ bug.
May 23 2019, 8:08 AM
probinson closed D62202: Work around a Visual C++ bug.
May 23 2019, 8:08 AM · Restricted Project, Restricted Project
probinson added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
May 23 2019, 8:04 AM · Restricted Project
probinson added a comment to D62084: Fix DWARF DebugInfo unit test errors when cross-compiling.

Looks like the right solution, but have you actually tried it with an empty default triple?

May 23 2019, 7:40 AM · Restricted Project
probinson added a comment to D62302: DWARF: Fix address range support in mixed 4+5 scenario.

Drive-by: For the "dead code" did you check whether gcc emits DW_AT_start_scope? LLDB should support more than just what Clang emits.

May 23 2019, 6:59 AM · Restricted Project

May 22 2019

probinson added a comment to D62241: [FileCheck] Introduce substitution subclasses.

Apart from missing 'override' keywords it looks pretty straightforward. LGTM.

May 22 2019, 12:10 PM · Restricted Project