Page MenuHomePhabricator

probinson (Paul Robinson)
User

Projects

User Details

User Since
May 9 2013, 11:10 AM (514 w, 4 d)

Recent Activity

Fri, Mar 17

probinson added a comment to D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units..

Is it possible you need to look only at the immediately preceding field, and not iterate? For example,

struct zero_bitfield {
  char a : 8;
  char : 0;
  char b : 8;
  char c : 8;
};

If processing b sees the zero-length bitfield and does the needful, then when processing c it's sufficient to see that b is a preceding bitfield and know that the needful has been done.

Fri, Mar 17, 7:04 AM · Restricted Project, Restricted Project

Tue, Mar 14

probinson added inline comments to D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units..
Tue, Mar 14, 10:42 AM · Restricted Project, Restricted Project

Fri, Mar 10

probinson added a comment to D143229: [AutoUpgrade] Add flag to disable autoupgrading debug info.

I've only skimmed the discussion, but FTR, Sony licensees are also in a single-compiler environment, which is enforced in a couple of ways. In particular we have a downstream patch to insert the compiler version into the bitcode (modeled on similar code for Darwin IIRC) and the linker will complain if it sees a different version, before starting the LTO machinery.

Fri, Mar 10, 7:52 AM · Restricted Project, Restricted Project

Thu, Mar 9

probinson committed rG9dcf6b19daf8: [PS4/PS5] Remove C_INCLUDE_DIRS handling (authored by probinson).
[PS4/PS5] Remove C_INCLUDE_DIRS handling
Thu, Mar 9, 9:27 AM · Restricted Project, Restricted Project
probinson accepted D145499: [DebugInfo][DWARF] Add doesFormBelongToClass function..

LGTM too

Thu, Mar 9, 7:03 AM · Restricted Project, Restricted Project

Wed, Mar 8

probinson added a project to D145607: [Inliner] Assign dummy debug location to the memcpy for byval argument: debug-info.

+debug-info

Wed, Mar 8, 2:34 PM · debug-info, Restricted Project, Restricted Project
probinson added a comment to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.

(I'm still using // in the test since llvm-mc with the arm-none-eabi triple does not accept
\# or \#\# as a comment).

Wed, Mar 8, 11:44 AM · debug-info, Restricted Project, Restricted Project

Tue, Mar 7

probinson abandoned D145173: Make section attribute and -ffunction-sections play nicely.

I think the GC behavior with explicit section names is currently a little peculiar. For functions without a section name, -ffunction-sections allows GC to happen at the individual function level. With a section name, GC would happen at the level of all-or-nothing per input file, regardless of -ffunction-sections. That just seems unexpected and inconsistent to me.
But it is the current behavior, and given the objections it's not worth pursuing this.

Tue, Mar 7, 6:49 AM · Restricted Project

Mon, Mar 6

probinson added a comment to D144337: Prevent line 0 instructions from dividing a lexical block into ranges.

Defining UnknownLocations as extern in LexicalScopes.cpp gives a link-time error despite removing the "static" keyword from its definition in DwarfDebug.cpp.

Mon, Mar 6, 12:02 PM · Restricted Project, Restricted Project

Fri, Mar 3

probinson added a comment to D145076: [llvm][DebugInfo] Introduce new DW_AT_LLVM_preferred_name attribute.

You don't want to use DW_AT_description for this?

Fri, Mar 3, 2:08 PM · Restricted Project, Restricted Project
probinson added a comment to D143745: Make section attribute and -ffunction-sections play nicely.

See D145173 for a different tactic to solve this.

Fri, Mar 3, 2:01 PM · Restricted Project
probinson added a project to D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes: Restricted Project.

I've looked at this but I'd like someone more in tune with MSVC behavior to review as well.

Fri, Mar 3, 1:43 PM · Restricted Project, Restricted Project
probinson added a comment to D144337: Prevent line 0 instructions from dividing a lexical block into ranges.

It seems strange to define the enum in a header for a module that uses it only once, and externalize it in a module that uses it several times.

Fri, Mar 3, 11:42 AM · Restricted Project, Restricted Project
probinson accepted D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.

Tidy up the test and LGTM.

Fri, Mar 3, 9:54 AM · debug-info, Restricted Project, Restricted Project

Thu, Mar 2

probinson requested review of D145173: Make section attribute and -ffunction-sections play nicely.
Thu, Mar 2, 11:00 AM · Restricted Project

Tue, Feb 28

probinson added a comment to D144585: [Nomination] Adding Nvidia Compiler security representative to the LLVM security group..

Looks like I made this reach the 50% mark, so I think you're good to go.

Tue, Feb 28, 12:00 PM · Restricted Project, Restricted Project
probinson accepted D144585: [Nomination] Adding Nvidia Compiler security representative to the LLVM security group..

Sony has two reps for much the same reason. LGTM.

Tue, Feb 28, 11:59 AM · Restricted Project, Restricted Project

Mon, Feb 27

probinson added a comment to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries.

Sorry for letting this sit so long! Code looks okay, still needs a test. For something like this you probably need an assembler source with a hand-made .debug_line section.

Mon, Feb 27, 10:34 AM · debug-info, Restricted Project, Restricted Project

Thu, Feb 23

probinson committed rG32d441bfb4f3: [PS4/PS5] Specify no <complex.h> or <threads.h> (authored by probinson).
[PS4/PS5] Specify no <complex.h> or <threads.h>
Thu, Feb 23, 7:10 AM · Restricted Project, Restricted Project
probinson closed D144586: [PS4/PS5] Specify no <complex.h> or <threads.h>.
Thu, Feb 23, 7:09 AM · Restricted Project, Restricted Project

Wed, Feb 22

probinson added a comment to D144586: [PS4/PS5] Specify no <complex.h> or <threads.h>.

That's correct, I do see <stdatomic.h> in our SDK.

Wed, Feb 22, 1:46 PM · Restricted Project, Restricted Project
probinson requested review of D144586: [PS4/PS5] Specify no <complex.h> or <threads.h>.
Wed, Feb 22, 11:59 AM · Restricted Project, Restricted Project

Feb 17 2023

probinson committed rG17a90f1196c1: Tighten up a modules test (authored by probinson).
Tighten up a modules test
Feb 17 2023, 6:36 AM · Restricted Project, Restricted Project
probinson closed D144188: Tighten up a modules test.
Feb 17 2023, 6:35 AM · Restricted Project, Restricted Project

Feb 16 2023

probinson added a comment to D144188: Tighten up a modules test.

I looked at this test only because it caused a merge conflict downstream. While it does work, it will not catch some kinds of mistakes; by being less specific in the "not" checks, it will catch more potential problems.

Feb 16 2023, 7:26 AM · Restricted Project, Restricted Project
probinson requested review of D144188: Tighten up a modules test.
Feb 16 2023, 7:22 AM · Restricted Project, Restricted Project

Feb 14 2023

probinson abandoned D143745: Make section attribute and -ffunction-sections play nicely.

Discussion on the GCC bug has persuaded me this is not a good idea. I'll solve my user's problem a different way.
@MaskRay you can close the GCC bug, it looks like I can't do it myself.

Feb 14 2023, 7:05 AM · Restricted Project

Feb 13 2023

probinson added a project to D143513: [DebugInfo] Allow parsing line tables aligned to 4 or 8-byte boundaries: debug-info.

+debug-info tag.

Feb 13 2023, 12:04 PM · debug-info, Restricted Project, Restricted Project

Feb 10 2023

probinson added a comment to D143745: Make section attribute and -ffunction-sections play nicely.

I'm not sure I understand the linker's mechanics here. Let me say some things and you can describe my misunderstanding.

  • If the linker was going to discard all of section foo (in the current scheme), that means it had no reason to retain either f() or g(). In the new scheme, the net result would be the same, both f() and g() are dead and would be discarded. So, no behavior change.
  • If the linker wanted to retain f(), but had no reason to retain g(), then in the current scheme it would retain all of section foo. In the new scheme it would retain f() but discard g(). This is the desired behavior change.
Feb 10 2023, 11:24 AM · Restricted Project
probinson accepted D143749: [ClangDepScan] Add UNSUPPORTED: system-windows to failing P1689.cppm test.

LGTM. A revert isn't cheap when it reverts a test to a broken state.

Feb 10 2023, 10:24 AM · Restricted Project, Restricted Project
probinson added a comment to D143745: Make section attribute and -ffunction-sections play nicely.

This works in my simple test cases, but I'm not 100% sure it's (a) the best place to do this, or (b) the only place that needs to do this.
Really we should guarantee that comdat any wins over comdat nodeduplicate in all cases.

Feb 10 2023, 8:22 AM · Restricted Project
probinson requested review of D143745: Make section attribute and -ffunction-sections play nicely.
Feb 10 2023, 8:17 AM · Restricted Project

Feb 7 2023

probinson accepted D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

LGTM

Feb 7 2023, 6:30 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

probinson added a comment to D143366: [Flang] Restrict emit-asm-from-mlir.mlir to be ran on specific targets using 'target=...'.

The comment suggests that it wants a (default) target that has particular characteristics, so updating REQUIRES to match that intent seems like a better approach.

Feb 6 2023, 5:28 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2023

probinson committed rGecb3cd0946a4: [Driver] Move PS4/PS5 header search path management to the driver (authored by probinson).
[Driver] Move PS4/PS5 header search path management to the driver
Feb 1 2023, 7:41 AM · Restricted Project, Restricted Project

Jan 31 2023

probinson accepted D140123: [TLS] Clamp the alignment of TLS global variables if required by the target.

LGTM, but you might give @arsenm another day before committing.

Jan 31 2023, 12:12 PM · Restricted Project, Restricted Project, Restricted Project
probinson added a comment to D140123: [TLS] Clamp the alignment of TLS global variables if required by the target.

I don't know if this can happen, but what about an LTO scenario with different values for the module flag? I seem to recall module flags needing to provide a merge policy? I might be remembering something else though.
If the result is "fail the compilation" that seems fine.

Jan 31 2023, 9:20 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

probinson committed rG787876b0d592: [unittests] Use GTEST_SKIP() instead of return when appropriate (authored by probinson).
[unittests] Use GTEST_SKIP() instead of return when appropriate
Jan 26 2023, 8:41 AM · Restricted Project, Restricted Project

Jan 25 2023

probinson committed rG7fc871591f13: [unittests] Use GTEST_SKIP() instead of return when appropriate (authored by probinson).
[unittests] Use GTEST_SKIP() instead of return when appropriate
Jan 25 2023, 1:59 PM · Restricted Project, Restricted Project

Jan 24 2023

probinson committed rG78a5f0a78ae1: [TargetParser] Remove an EXPECT that is never executed (authored by probinson).
[TargetParser] Remove an EXPECT that is never executed
Jan 24 2023, 12:28 PM · Restricted Project, Restricted Project

Jan 19 2023

probinson added a reverting change for rG2f8b920f95aa: Revert "[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL": rG725a21b62c2d: Reland "[lit] Stop supporting triple substrings in UNSUPPORTED and.
Jan 19 2023, 1:27 PM · Restricted Project, Restricted Project
probinson committed rG725a21b62c2d: Reland "[lit] Stop supporting triple substrings in UNSUPPORTED and (authored by probinson).
Reland "[lit] Stop supporting triple substrings in UNSUPPORTED and
Jan 19 2023, 1:27 PM · Restricted Project, Restricted Project
probinson added a reverting change for rGa0f8bdbb18a8: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL: rG2f8b920f95aa: Revert "[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL".
Jan 19 2023, 9:28 AM · Restricted Project, Restricted Project
probinson committed rG2f8b920f95aa: Revert "[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL" (authored by probinson).
Revert "[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL"
Jan 19 2023, 9:28 AM · Restricted Project, Restricted Project
probinson added a reverting change for D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL: rG2f8b920f95aa: Revert "[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL".
Jan 19 2023, 9:28 AM · Restricted Project, Restricted Project
probinson added a comment to D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.

Examples added to the commit log.
Entry made in release notes.
I will keep an eye out for bot fail-mail related to this change.

Jan 19 2023, 8:56 AM · Restricted Project, Restricted Project
probinson committed rGa0f8bdbb18a8: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL (authored by probinson).
[lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL
Jan 19 2023, 8:35 AM · Restricted Project, Restricted Project
probinson closed D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.
Jan 19 2023, 8:35 AM · Restricted Project, Restricted Project

Jan 17 2023

probinson added a comment to D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.

One thing to keep in mind here is that folks who rebase patches on top of this patch may get bitten by this issue for a couple weeks, so it may be worth grepping for suspicious patches from time to time, or turning this into an explicit error instead (just for a few weeks).

Jan 17 2023, 11:42 AM · Restricted Project, Restricted Project
probinson added a comment to D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.

I had just one question: what kind of testing did we do / how did we discover all uses of the triple substring matches?

Jan 17 2023, 11:41 AM · Restricted Project, Restricted Project
probinson committed rG09e4449901d7: [PS5] Handle visibility options same as PS4 (authored by probinson).
[PS5] Handle visibility options same as PS4
Jan 17 2023, 11:28 AM · Restricted Project, Restricted Project
probinson committed rGeae8d2260702: [PS4] NFC: rewrite a test to use lit's DEFINE feature (authored by probinson).
[PS4] NFC: rewrite a test to use lit's DEFINE feature
Jan 17 2023, 11:28 AM · Restricted Project, Restricted Project

Jan 13 2023

probinson added inline comments to D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.
Jan 13 2023, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
probinson committed rG4d8b99af7391: [Polly] Fix REQUIRES for nvptx-dependent tests (authored by probinson).
[Polly] Fix REQUIRES for nvptx-dependent tests
Jan 13 2023, 11:28 AM · Restricted Project
probinson closed D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.
Jan 13 2023, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
probinson added a comment to D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.

@tra can I get your okay on this?

Jan 13 2023, 10:34 AM · Restricted Project, Restricted Project, Restricted Project
probinson updated subscribers of D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.

Ping. Add @yln

Jan 13 2023, 7:00 AM · Restricted Project, Restricted Project
probinson committed rG16ee7c49d9e4: [compiler-rt] fix typo in #95507c82 (authored by probinson).
[compiler-rt] fix typo in #95507c82
Jan 13 2023, 6:53 AM · Restricted Project, Restricted Project
probinson committed rG95507c82bcfa: [compiler-rt] Fix XFAIL conditions after converting to 'target=...' (authored by probinson).
[compiler-rt] Fix XFAIL conditions after converting to 'target=...'
Jan 13 2023, 6:24 AM · Restricted Project, Restricted Project

Jan 10 2023

probinson updated subscribers of D141381: [codegen] Store address of indirect arguments on the stack.

Basically you're homing a pointer to the parameter, rather than the parameter itself, which makes sense in this context.

Jan 10 2023, 10:31 AM · Restricted Project, Restricted Project
probinson added inline comments to D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.
Jan 10 2023, 9:52 AM · Restricted Project, Restricted Project, Restricted Project
probinson updated the diff for D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.

Add "This fails today ..." notes to the tests where I added XFAIL: *

Jan 10 2023, 9:50 AM · Restricted Project, Restricted Project, Restricted Project
probinson added a comment to D141381: [codegen] Store address of indirect arguments on the stack.

I should expand on my previous comment. Extending the lifetime of these variables by saving the pointers into local variables, that's fine; just make sure it's not conditional on -g. The only difference between -g and not -g should be metadata and dbg.* instructions.

Jan 10 2023, 8:38 AM · Restricted Project, Restricted Project
probinson added a comment to D141381: [codegen] Store address of indirect arguments on the stack.

This causes codegen to be different depending on whether debug-info is generated. Please don't do that.

Jan 10 2023, 8:34 AM · Restricted Project, Restricted Project
probinson added a comment to D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading.

One minor comment. I don't feel comfortable enough with metadata to actually approve this, however.

Jan 10 2023, 8:21 AM · Restricted Project, Restricted Project
probinson added inline comments to D140123: [TLS] Clamp the alignment of TLS global variables if required by the target.
Jan 10 2023, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Jan 9 2023

probinson added a comment to D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.

Would [target=xxx] be true when the default target matches the one specified by target=xxx, or when the compiler does have enabled back-end for that target?

target=xxx would be true when the default triple matches. The check for having the backend enabled is still xxx-registered-target.

Jan 9 2023, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
probinson added a comment to D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.

Ping

Jan 9 2023, 11:09 AM · Restricted Project, Restricted Project
probinson updated subscribers of D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.

Ping. +tra based on git-log

Jan 9 2023, 11:07 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

probinson added a comment to D140585: CodingStandards: restrict CamelCase variable names guideline to llvm/clang/clang-tools-extra/polly/bolt.

So, the real problem is, once somebody managed to herd the cats all into the same direction (or close enough), the consensus was "no mass conversion to the new style." Which naturally left everything inconsistent.

Jan 5 2023, 1:31 PM · Restricted Project, Restricted Project

Jan 4 2023

probinson requested review of D141007: [lit] Stop supporting triple substrings in UNSUPPORTED and XFAIL.
Jan 4 2023, 11:39 AM · Restricted Project, Restricted Project
probinson committed rGf0f61829415f: [llgdb-tests] Convert test to check 'target=...' (authored by probinson).
[llgdb-tests] Convert test to check 'target=...'
Jan 4 2023, 7:57 AM · Restricted Project
probinson committed rGa26cbd03fe0f: [Driver] Convert test to check 'target=...' (authored by probinson).
[Driver] Convert test to check 'target=...'
Jan 4 2023, 6:46 AM · Restricted Project, Restricted Project

Jan 3 2023

probinson added a comment to D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading.

Please generate diffs with full context (e.g., -U999999 in the diff/show command). It's really helpful to be able to look above and below the modified lines to understand the context of the patch.

Jan 3 2023, 10:35 AM · Restricted Project, Restricted Project
probinson added a comment to D139728: [Polly] Fix REQUIRES for nvptx-dependent tests.

ping

Jan 3 2023, 10:22 AM · Restricted Project, Restricted Project, Restricted Project

Dec 21 2022

probinson committed rGd4959b5a4bb8: [Driver] Fix tests not to fail randomly on Windows (authored by probinson).
[Driver] Fix tests not to fail randomly on Windows
Dec 21 2022, 9:37 AM · Restricted Project, Restricted Project
probinson committed rG088b5d1ad3a3: [docs] Update an example (authored by probinson).
[docs] Update an example
Dec 21 2022, 8:42 AM · Restricted Project, Restricted Project
probinson added a comment to D140479: [docs] Add tips on writing test constraints.

Example updated.

Dec 21 2022, 8:42 AM · Restricted Project, Restricted Project
probinson added inline comments to D140479: [docs] Add tips on writing test constraints.
Dec 21 2022, 8:38 AM · Restricted Project, Restricted Project
probinson committed rG2549b8bdae67: [docs] Add tips on writing test constraints (authored by probinson).
[docs] Add tips on writing test constraints
Dec 21 2022, 8:32 AM · Restricted Project, Restricted Project
probinson requested review of D140479: [docs] Add tips on writing test constraints.
Dec 21 2022, 7:12 AM · Restricted Project, Restricted Project
probinson committed rG566e34829fb6: [lit] Document the 'target=<triple>' feature (authored by probinson).
[lit] Document the 'target=<triple>' feature
Dec 21 2022, 6:12 AM · Restricted Project, Restricted Project, Restricted Project
probinson closed D139869: [lit] Document the 'target=<triple>' feature.
Dec 21 2022, 6:11 AM · Restricted Project, Restricted Project, Restricted Project
probinson committed rG17f804ef4b8f: [hwasan] Convert tests to check 'target=...' (authored by probinson).
[hwasan] Convert tests to check 'target=...'
Dec 21 2022, 5:42 AM · Restricted Project, Restricted Project
probinson committed rG8e6006129013: [compiler-rt] Simplify lit test thumb checks (authored by probinson).
[compiler-rt] Simplify lit test thumb checks
Dec 21 2022, 5:34 AM · Restricted Project, Restricted Project
probinson committed rGc0f17a5ee897: [libcxxabi] Use 'target=' consistently (authored by probinson).
[libcxxabi] Use 'target=' consistently
Dec 21 2022, 5:22 AM · Restricted Project
probinson committed rG016785d9316d: [clang/xray] Convert tests to check 'target=...' (authored by probinson).
[clang/xray] Convert tests to check 'target=...'
Dec 21 2022, 5:20 AM · Restricted Project, Restricted Project
probinson added inline comments to D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading.
Dec 21 2022, 3:37 AM · Restricted Project, Restricted Project
probinson added a comment to D140404: Patch for dbg variable instrinsics to point towards cloned values in JumpThreading.

Please use clang-format-patch to correct some style issues.

Dec 21 2022, 3:30 AM · Restricted Project, Restricted Project

Dec 20 2022

probinson committed rG015f8cd78ec6: [xray] Convert tests to check 'target=...' (authored by probinson).
[xray] Convert tests to check 'target=...'
Dec 20 2022, 7:36 AM · Restricted Project, Restricted Project

Dec 19 2022

probinson committed rG34f220ae3257: Fix gcc 7.5 build break after TypeSize ctors became constexpr (authored by probinson).
Fix gcc 7.5 build break after TypeSize ctors became constexpr
Dec 19 2022, 1:18 PM · Restricted Project, Restricted Project
probinson added a comment to D140332: [ADT] Alias llvm::Optional to std::optional.

Worth trying on MSVC, which is the other more likely place to fail.

Dec 19 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
probinson committed rGe6e4362901ae: [ubsan] Convert tests to check 'target=...' (authored by probinson).
[ubsan] Convert tests to check 'target=...'
Dec 19 2022, 12:04 PM · Restricted Project, Restricted Project
probinson committed rGfbe3f89bcf54: [tsan] Convert tests to check 'target=...' (authored by probinson).
[tsan] Convert tests to check 'target=...'
Dec 19 2022, 11:33 AM · Restricted Project, Restricted Project
probinson committed rG975fa725063f: [sanitizer-common] Convert tests to check 'target=...' (authored by probinson).
[sanitizer-common] Convert tests to check 'target=...'
Dec 19 2022, 11:01 AM · Restricted Project, Restricted Project
probinson committed rG2f6439bcf9bd: [profile] Convert tests to check 'target=...' (authored by probinson).
[profile] Convert tests to check 'target=...'
Dec 19 2022, 9:45 AM · Restricted Project, Restricted Project
probinson committed rG02012a78b8e7: [msan] Convert tests to check 'target=...' (authored by probinson).
[msan] Convert tests to check 'target=...'
Dec 19 2022, 6:45 AM · Restricted Project, Restricted Project
probinson committed rG0773a5cbe860: [lsan] Convert tests to check 'target=...' (authored by probinson).
[lsan] Convert tests to check 'target=...'
Dec 19 2022, 6:26 AM · Restricted Project, Restricted Project

Dec 16 2022

probinson added a comment to D140123: [TLS] Clamp the alignment of TLS global variables if required by the target.

I feel this is too specific and doesn't belong in the datalayout. I think a general maximum global alignment would make a bit more sense? I know very little about object formats

Dec 16 2022, 1:35 PM · Restricted Project, Restricted Project, Restricted Project
probinson committed rG5bdb9254d923: [fuzzer] Fix UNSUPPORTED criteria for two tests (authored by probinson).
[fuzzer] Fix UNSUPPORTED criteria for two tests
Dec 16 2022, 12:48 PM · Restricted Project, Restricted Project