This is an archive of the discontinued LLVM Phabricator instance.

Differential D136789

[clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags
ClosedPublic

Authored by aeubanks on Oct 26 2022, 2:04 PM.

Details

Reviewers
MaskRay
ctetreau
Commits
rG69b2b7282e92: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager…
Summary

These have been no-op for a while and keeping them around may be confusing.

Diff Detail

Event Timeline

aeubanks created this revision.Oct 26 2022, 2:04 PM
Herald added a reviewer: ctetreau. · View Herald TranscriptOct 26 2022, 2:04 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: StephenFan. · View Herald Transcript
aeubanks requested review of this revision.Oct 26 2022, 2:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2022, 2:04 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B194493: Diff 470928.Oct 26 2022, 3:27 PM
Matt added a subscriber: Matt.Oct 27 2022, 9:15 AM
MaskRay accepted this revision.Oct 27 2022, 9:23 AM
MaskRay added inline comments.
clang/docs/ReleaseNotes.rst
161
162

since the last release.

since 15.0.0.

This revision is now accepted and ready to land.Oct 27 2022, 9:23 AM
This revision was landed with ongoing or failed builds.Oct 28 2022, 10:24 AM
Closed by commit rG69b2b7282e92: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager… (authored by aeubanks). · Explain Why
This revision was automatically updated to reflect the committed changes.
aeubanks added a commit: rG69b2b7282e92: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager….

Revision Contents

PathSize
clang/
docs/
2 lines
include/
clang/
Driver/
4 lines
test/
Driver/

Diff 471589

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 152 Lines • ▼ Show 20 Lines .. code-block:: c++
} S; } S;
void f(S s) { void f(S s) {
__asm { __asm {
mov eax, s.bf // Now diagnosed as an error. mov eax, s.bf // Now diagnosed as an error.
mov s.bf, eax // Now diagnosed as an error. mov s.bf, eax // Now diagnosed as an error.
} }
} }
- The ``-fexperimental-new-pass-manager`` and ``-fno-legacy-pass-manager``
MaskRayUnsubmitted
Not Done
ReplyInline Actions
}
}
- - The -fexperimental-new-pass-manager and -fno-legacy-pass-manager flags have
+ - The ``-fexperimental-new-pass-manager`` and ``-fno-legacy-pass-manager`` flags have
been removed. These have been no-ops since the last release.
MaskRay:
flags have been removed. These have been no-ops since 15.0.0.
MaskRayUnsubmitted
Not Done
ReplyInline Actions

since the last release.

since 15.0.0.

MaskRay: > since the last release. since 15.0.0.
What's New in Clang |release|? What's New in Clang |release|?
============================== ==============================
Some of the major new features and improvements to Clang are listed Some of the major new features and improvements to Clang are listed
here. Generic improvements to Clang as a whole or to its underlying here. Generic improvements to Clang as a whole or to its underlying
infrastructure are described first, followed by language-specific infrastructure are described first, followed by language-specific
sections with improvements to Clang's support for those languages. sections with improvements to Clang's support for those languages.
▲ Show 20 Lines • Show All 612 Lines • Show Last 20 Lines

clang/include/clang/Driver/Options.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,008 Lines • ▼ Show 20 Lines
defm jmc : BoolFOption<"jmc", defm jmc : BoolFOption<"jmc",
CodeGenOpts<"JMCInstrument">, DefaultFalse, CodeGenOpts<"JMCInstrument">, DefaultFalse,
PosFlag<SetTrue, [CC1Option], "Enable just-my-code debugging">, PosFlag<SetTrue, [CC1Option], "Enable just-my-code debugging">,
NegFlag<SetFalse>>; NegFlag<SetFalse>>;
def fglobal_isel : Flag<["-"], "fglobal-isel">, Group<f_clang_Group>, def fglobal_isel : Flag<["-"], "fglobal-isel">, Group<f_clang_Group>,
HelpText<"Enables the global instruction selector">; HelpText<"Enables the global instruction selector">;
def fexperimental_isel : Flag<["-"], "fexperimental-isel">, Group<f_clang_Group>, def fexperimental_isel : Flag<["-"], "fexperimental-isel">, Group<f_clang_Group>,
Alias<fglobal_isel>; Alias<fglobal_isel>;
def fno_legacy_pass_manager : Flag<["-"], "fno-legacy-pass-manager">,
Group<f_clang_Group>, Flags<[CC1Option, NoArgumentUnused]>;
def fexperimental_new_pass_manager : Flag<["-"], "fexperimental-new-pass-manager">,
Group<f_clang_Group>, Flags<[CC1Option]>, Alias<fno_legacy_pass_manager>;
def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">, def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">,
Group<f_clang_Group>, Flags<[CC1Option]>, Group<f_clang_Group>, Flags<[CC1Option]>,
HelpText<"Enables experimental strict floating point in LLVM.">, HelpText<"Enables experimental strict floating point in LLVM.">,
MarshallingInfoFlag<LangOpts<"ExpStrictFP">>; MarshallingInfoFlag<LangOpts<"ExpStrictFP">>;
def finput_charset_EQ : Joined<["-"], "finput-charset=">, Flags<[FlangOption, FC1Option]>, Group<f_Group>, def finput_charset_EQ : Joined<["-"], "finput-charset=">, Flags<[FlangOption, FC1Option]>, Group<f_Group>,
HelpText<"Specify the default character set for source files">; HelpText<"Specify the default character set for source files">;
def fexec_charset_EQ : Joined<["-"], "fexec-charset=">, Group<f_Group>; def fexec_charset_EQ : Joined<["-"], "fexec-charset=">, Group<f_Group>;
def finstrument_functions : Flag<["-"], "finstrument-functions">, Group<f_Group>, Flags<[CC1Option]>, def finstrument_functions : Flag<["-"], "finstrument-functions">, Group<f_Group>, Flags<[CC1Option]>,
▲ Show 20 Lines • Show All 4,987 Lines • Show Last 20 Lines

clang/test/Driver/flegacy-pass-manager.c

  • This file was deleted.
/// -fno-legacy-pass-manager and -fexperimental-new-pass-manager are retained
// as no-ops. The inverted options are no longer supported.
// RUN: %clang -### -c -fno-legacy-pass-manager %s 2>&1 | FileCheck %s
// RUN: not %clang -### -flegacy-pass-manager %s
// RUN: %clang -### -c -fexperimental-new-pass-manager %s 2>&1 | FileCheck %s
// RUN: not %clang -### -fno-experimental-new-pass-manager %s
// Just check that there is no argument unused warning. There is no need to
// pass any cc1 options.
// CHECK-NOT: warning: argument unused
clang/include/clang/Driver/Options.td