This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] add svinval extension
ClosedPublic

Authored by BeMg on Oct 23 2022, 8:31 PM.

Details

Summary
  1. Add the svinval extension support
  2. Add the svinval Predicates for its instruction

Note: the svinval instructions defined in https://reviews.llvm.org/D117654

Diff Detail

Event Timeline

BeMg created this revision.Oct 23 2022, 8:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 23 2022, 8:31 PM
BeMg requested review of this revision.Oct 23 2022, 8:31 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 23 2022, 8:31 PM
craig.topper added inline comments.
llvm/lib/Target/RISCV/RISCVInstrInfo.td
814

Can we reorder these so there's aren't so many toggles of Predicates.

Alternatively, you could add Requires<[HasStdSvinval]> to the end of the lines instead of using let Predicates

BeMg updated this revision to Diff 470041.Oct 23 2022, 9:10 PM

Use Requires<[HasStdSvinval]> instead of using let Predicates

Hm, we only have two uses of Requires currently, both of which aren't really for any good reason as far as I can see. It'd be better to keep things uniform with Predicates IMO.

BeMg updated this revision to Diff 470046.Oct 23 2022, 9:58 PM

Reorder the def then use the same let Predicates

reames added a subscriber: reames.Oct 24 2022, 7:49 AM

Please update https://llvm.org/docs/RISCVUsage.html#extensions

It seems like we'd previously accept these instruction without the extension being explicitly named? If so, this is probably worth a release note to document the change in user behavior.

BeMg updated this revision to Diff 470428.Oct 25 2022, 3:06 AM

Update RISCVUsage.html

BeMg edited the summary of this revision. (Show Details)Oct 25 2022, 3:12 AM
reames added inline comments.Oct 25 2022, 9:24 AM
llvm/docs/RISCVUsage.rst
56 ↗(On Diff #470428)

This table is sorted alphabetically, please move above V.

BeMg updated this revision to Diff 470559.Oct 25 2022, 10:48 AM

Update RISCVUsage.rst

BeMg updated this revision to Diff 470722.Oct 25 2022, 11:37 PM
BeMg marked 2 inline comments as done.

rebase

reames accepted this revision.Oct 26 2022, 8:45 AM

LGTM

This revision is now accepted and ready to land.Oct 26 2022, 8:45 AM
This revision was automatically updated to reflect the committed changes.