Details
Details
Diff Detail
Diff Detail
- Repository
 - rG LLVM Github Monorepo
 
Event Timeline
| llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll | ||
|---|---|---|
| 20 | There is something going wrong here, because it should not have been lowered to a call.  | |
Comment Actions
- Use a correct intrinsic name for vector.insert. Before it was llvm.aarch64.vector.insert.
 
| llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll | ||
|---|---|---|
| 20 | Thank you Sander.  | |
| llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll | ||
|---|---|---|
| 129 | I would have expected no asm changes. The test is not equivalent to the previous code.  | |
| llvm/test/CodeGen/AArch64/sve-calling-convention-mixed.ll | ||
|---|---|---|
| 129 | Yes, you were correct. I was taken the same load twice.  | |
Comment Actions
Can you also split this patch in two:
- One for Clang where it will no longer use the legacy ld2/3/4 intrinsics
 - One for LLVM where it removes the old intrinsics and AutoUpgrades the old intrinsics.
 
Comment Actions
LGTM with nit addressed, thanks @CarolineConcatto!
| clang/lib/CodeGen/CGBuiltin.cpp | ||
|---|---|---|
| 8866 | nit: s/VTy->getElementCount().getKnownMinValue()/VTy->getMinNumElements()/  | |
nit: s/VTy->getElementCount().getKnownMinValue()/VTy->getMinNumElements()/