Page MenuHomePhabricator

llvm-c: Add LLVMDeleteInstruction to fix a test issue
ClosedPublic

Authored by nhaehnle on Jul 5 2022, 2:13 AM.

Details

Summary

Not deleting the loose instruction with metadata associated to it causes
an assertion when the LLVMContext is destroyed. This was previously
hidden by the fact that llvm-c-test does not call LLVMShutdown. The
planned removal of ManagedStatic exposed this issue.

Diff Detail

Event Timeline

nhaehnle created this revision.Jul 5 2022, 2:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: hiraditya. · View Herald Transcript
nhaehnle requested review of this revision.Jul 5 2022, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:13 AM
lattner accepted this revision.Jul 5 2022, 12:31 PM
This revision is now accepted and ready to land.Jul 5 2022, 12:31 PM
This revision was landed with ongoing or failed builds.Jul 7 2022, 5:29 AM
This revision was automatically updated to reflect the committed changes.