Page MenuHomePhabricator

ManagedStatic: remove from DebugCounter
ClosedPublic

Authored by nhaehnle on Jul 5 2022, 2:14 AM.

Details

Summary

Follow the pattern used in MLIR for the cl::opt instances.

Diff Detail

Event Timeline

nhaehnle created this revision.Jul 5 2022, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:14 AM
nhaehnle requested review of this revision.Jul 5 2022, 2:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:14 AM
lattner resigned from this revision.Jul 26 2022, 10:44 AM
nhaehnle updated this revision to Diff 449604.Aug 3 2022, 2:31 AM
  • make DebugCounter::isCountingEnabled public so that the DebugCounterOwner doesn't have to be a nested class. This simplifies later changes
This revision is now accepted and ready to land.Aug 3 2022, 11:17 AM
This revision was landed with ongoing or failed builds.Aug 25 2022, 10:10 AM
This revision was automatically updated to reflect the committed changes.
dblaikie added inline comments.
llvm/lib/Support/DebugCounter.cpp
72–75

This might be an unnecessary layer of indirection - the static member could be in DebugCounter::instance() directly?