Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Paths

Table of Contentst

Fix test: LLVMGetBitcodeModule takes ownership of memory buffer
ClosedPublic
Actions

Authored by nhaehnle on Jul 5 2022, 2:13 AM.

Details

Reviewers

efriedma
lattner
deadalnix
nikic

Commits

rG5a731d733c56: Fix test: LLVMGetBitcodeModule takes ownership of memory buffer

Summary

Clarify this behavior in the C interface header file and fix a related
bug in a test.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

nhaehnle created this revision.Jul 5 2022, 2:13 AM

Herald added a reviewer: deadalnix. · View Herald TranscriptJul 5 2022, 2:13 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added a subscriber: yaxunl. · View Herald Transcript

nhaehnle requested review of this revision.Jul 5 2022, 2:13 AM

Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:13 AM

nhaehnle added a child revision: D129114: llvm-c: Add LLVMDeleteInstruction to fix a test issue.Jul 5 2022, 2:25 AM

foad added a subscriber: foad.Jul 5 2022, 2:40 AM

foad added inline comments.

llvm/include/llvm-c/BitReader.h
65	Spurious `*`

Harbormaster completed remote builds in B173642: Diff 442212.Jul 5 2022, 3:33 AM

nhaehnle marked an inline comment as done.Jul 5 2022, 11:07 AM

nhaehnle added inline comments.

llvm/include/llvm-c/BitReader.h
65	Thanks, fixing it.

Address review comment

Harbormaster completed remote builds in B173744: Diff 442359.Jul 5 2022, 12:22 PM

LGTM. Weird API.

This revision is now accepted and ready to land.Jul 8 2022, 1:02 AM

This revision was landed with ongoing or failed builds.Jul 8 2022, 11:07 AM

Closed by commit rG5a731d733c56: Fix test: LLVMGetBitcodeModule takes ownership of memory buffer (authored by nhaehnle). · Explain Why

This revision was automatically updated to reflect the committed changes.

nhaehnle added a commit: rG5a731d733c56: Fix test: LLVMGetBitcodeModule takes ownership of memory buffer.

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm-c/

BitReader.h

9 lines

tools/

llvm-c-test/

diagnostic.c

9 lines

Diff 443294

View Options

llvm/include/llvm-c/BitReader.h