Page MenuHomePhabricator

Fix test: LLVMGetBitcodeModule takes ownership of memory buffer
ClosedPublic

Authored by nhaehnle on Jul 5 2022, 2:13 AM.

Details

Summary

Clarify this behavior in the C interface header file and fix a related
bug in a test.

Diff Detail

Event Timeline

nhaehnle created this revision.Jul 5 2022, 2:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: yaxunl. · View Herald Transcript
nhaehnle requested review of this revision.Jul 5 2022, 2:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:13 AM
foad added a subscriber: foad.Jul 5 2022, 2:40 AM
foad added inline comments.
llvm/include/llvm-c/BitReader.h
65

Spurious *

nhaehnle marked an inline comment as done.Jul 5 2022, 11:07 AM
nhaehnle added inline comments.
llvm/include/llvm-c/BitReader.h
65

Thanks, fixing it.

nhaehnle updated this revision to Diff 442359.Jul 5 2022, 11:07 AM
nhaehnle marked an inline comment as done.

Address review comment

nikic accepted this revision.Jul 8 2022, 1:02 AM
nikic added a subscriber: nikic.

LGTM. Weird API.

This revision is now accepted and ready to land.Jul 8 2022, 1:02 AM
This revision was landed with ongoing or failed builds.Jul 8 2022, 11:07 AM
This revision was automatically updated to reflect the committed changes.