Page MenuHomePhabricator

ManagedStatic: remove from PassManagerBuilder
Needs ReviewPublic

Authored by nhaehnle on Jul 5 2022, 2:17 AM.

Details

Reviewers
efriedma
lattner

Diff Detail

Event Timeline

nhaehnle created this revision.Jul 5 2022, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:17 AM
nhaehnle requested review of this revision.Jul 5 2022, 2:17 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 5 2022, 2:17 AM
efriedma added inline comments.Fri, Jul 29, 1:28 PM
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
240

I don't think you've managed to quite capture the intended semantic here. Note the comment mentions what happens after GlobalExtensions is destroyed...

nhaehnle updated this revision to Diff 449591.Wed, Aug 3, 1:49 AM
  • reset GlobalExtensionsConstructed in the destructor of GlobalExtensions
llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
240

I think you're right. I must've intended to add a destructor for GlobalExtensions (why else define the struct?) but then forgot...