I can't remove the function just yet as it is used in the generated .inc files.
I would also like to provide a way to compare alignment with TypeSize since it came up a few times.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
| llvm/lib/Target/ARM/ARMISelLowering.cpp | ||
|---|---|---|
| 5583 | Even though this works, I think this is conceptually misleading: 4 here is an offset, not an alignment. So I think this should be: commonAlignment(Ld->getAlign(), 4) | |
| 14797 | ditto | |
| llvm/lib/Target/Mips/MipsSEISelLowering.cpp | ||
| 1186 | ditto | |
| 1221 | ditto | |
| llvm/lib/Target/PowerPC/PPCISelLowering.cpp | ||
| 15317 | ditto | |
| llvm/lib/Target/ARM/ARMISelLowering.cpp | ||
|---|---|---|
| 5583 | Good catch, thx! | |
Even though this works, I think this is conceptually misleading: 4 here is an offset, not an alignment. So I think this should be:
commonAlignment(Ld->getAlign(), 4)