This is an archive of the discontinued LLVM Phabricator instance.

[cmake] Remove LLVM_ENABLE_NEW_PASS_MANAGER cmake option
ClosedPublic

Authored by nikic on Apr 5 2022, 6:26 AM.

Details

Summary

Or rather, error out if it is set to something other than ON. This removes the ability to enable the legacy pass manager by default, but does not remove the ability to explicitly enable it through various flags like -flegacy-pass-manager or -enable-new-pm=0.

I checked, and our test suite definitely doesn't pass with LLVM_ENABLE_NEW_PASS_MANAGER=OFF anymore.

Diff Detail

Event Timeline

nikic created this revision.Apr 5 2022, 6:26 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: pmatos, asb, ormris and 7 others. · View Herald Transcript
nikic requested review of this revision.Apr 5 2022, 6:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2022, 6:26 AM
aeubanks accepted this revision.Apr 5 2022, 8:29 AM

thanks!

This revision is now accepted and ready to land.Apr 5 2022, 8:29 AM
MaskRay accepted this revision.Apr 5 2022, 9:33 AM

LGTM.

lld/ELF/Driver.cpp
1104–1105

clang-format

asbirlea accepted this revision.Apr 5 2022, 1:11 PM

Thank you!

This revision was landed with ongoing or failed builds.Apr 6 2022, 12:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2022, 12:52 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript