This is an archive of the discontinued LLVM Phabricator instance.

[NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`
ClosedPublic

Authored by achieveartificialintelligence on Feb 15 2022, 8:22 AM.

Diff Detail

Event Timeline

achieveartificialintelligence requested review of this revision.Feb 15 2022, 8:22 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
yota9 removed a subscriber: yota9.Feb 15 2022, 8:23 AM
pengfei added a subscriber: skan.Feb 15 2022, 8:31 AM
skan added a reviewer: skan.Feb 15 2022, 7:08 PM
skan accepted this revision.Feb 15 2022, 7:12 PM

MCRegisterInfo is not used b/c it can be got from MCContext. It makes sense to remove it in the parameters.

This revision is now accepted and ready to land.Feb 15 2022, 7:12 PM
This revision was landed with ongoing or failed builds.Feb 15 2022, 7:47 PM
This revision was automatically updated to reflect the committed changes.
skan added a comment.Feb 15 2022, 10:37 PM

@achieveartificialintelligence Please explain why a patch is reverted in the commit message next time.

@achieveartificialintelligence Please explain why a patch is reverted in the commit message next time.

OK, thanks for your guidance!