Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (158 w, 1 d)

Recent Activity

Wed, May 23

Eugene.Zelenko added a comment to D47157: Warning for framework headers using double quote includes.

Hi Eugene,

You could just not include new warning into -Wall and -Wextra. Those who will want to check #include statements correctness could enable it explicitly.

This is exactly what's happening in the patch, the new warning isn't part of -Wall or -Wextra, and is marked DefaultIgnore, which means that will fire only when -Wquoted-include-in-framework-header is passed to the driver. Am I missing something from your explanation?

Thanks,

Wed, May 23, 5:05 PM

Mon, May 21

Eugene.Zelenko added a comment to D47157: Warning for framework headers using double quote includes.

The warning is off by default.

We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default?

Right. I believe this is going to be used in practice, the reason I'm adding it involves some user demand for such warning. Such quoted include use in frameworks happen often and we would like a smooth transition to happen here (e.g. do not initially affect -Werror users). If it proves worth it, we can migrate to on by default in the future. It wouldn't be a problem if we have it on by default on open source and disable by default downstream, but I rather be consistent.

Mon, May 21, 3:49 PM
Eugene.Zelenko added a comment to D47157: Warning for framework headers using double quote includes.

See also PR22165.

Mon, May 21, 2:02 PM

May 8 2018

Eugene.Zelenko added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

I think will be good idea to store data in JSON format too.

May 8 2018, 3:30 PM · Restricted Project
Eugene.Zelenko added inline comments to D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module.
May 8 2018, 2:30 PM · Restricted Project

May 6 2018

Eugene.Zelenko added inline comments to D46504: [clang-tidy] Profile is a per-AST (per-TU) data..
May 6 2018, 4:20 PM · Restricted Project

May 3 2018

Eugene.Zelenko added a comment to D46407: [tools] Introduce llvm-strip.

Will be good idea to add documentation and item in Release Notes.

May 3 2018, 3:41 PM
Eugene.Zelenko added a comment to D46378: Undef the macros after their use.

I don't see anything wrong with this change, but will be good idea to wait for code owner approval.

May 3 2018, 6:11 AM

May 2 2018

Eugene.Zelenko added inline comments to D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions..
May 2 2018, 6:24 AM · Restricted Project

May 1 2018

Eugene.Zelenko added reviewers for D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup: hokein, aaron.ballman, ilya-biryukov.
May 1 2018, 10:12 AM · Restricted Project
Eugene.Zelenko added inline comments to D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup.
May 1 2018, 10:12 AM · Restricted Project
Eugene.Zelenko added inline comments to D46243: Move Schedule class to header file for allowing inheritance.
May 1 2018, 7:34 AM

Apr 30 2018

Eugene.Zelenko removed a reviewer for D46265: StackColoring: better handling of statically unreachable code: Eugene.Zelenko.
Apr 30 2018, 8:26 AM
Eugene.Zelenko added inline comments to D46243: Move Schedule class to header file for allowing inheritance.
Apr 30 2018, 6:36 AM
Eugene.Zelenko removed a reviewer for D46243: Move Schedule class to header file for allowing inheritance: Eugene.Zelenko.
Apr 30 2018, 6:36 AM

Apr 22 2018

Eugene.Zelenko edited reviewers for D45932: [clang-tidy][modernize-raw-string-literal] Don't replace upper ASCII with raw literals, added: alexfh, aaron.ballman, hokein, ilya-biryukov; removed: xazax.hun, LegalizeAdulthood.
Apr 22 2018, 4:23 PM · Restricted Project

Apr 20 2018

Eugene.Zelenko added reviewers for D45891: [clang-tidy] Improve bugprone-unused-return-value check: hokein, aaron.ballman, ilya-biryukov.
Apr 20 2018, 1:23 PM · Restricted Project

Apr 19 2018

Eugene.Zelenko added inline comments to D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions..
Apr 19 2018, 6:30 PM · Restricted Project
Eugene.Zelenko added inline comments to D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions..
Apr 19 2018, 6:00 PM · Restricted Project

Apr 18 2018

Eugene.Zelenko added a comment to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..

You are doing a great job and i learn new stuff :)

  • What do you think about having these functions in a class? Now, we need to recalculate and reanalyze the scope for every variable, multiple times (reference tracking). It would be nice to do it as lazy as possible and memorize the results. Especially addressing the use-case for the const-check, storing that a reference is not modified will save a lot of work = performance
Apr 18 2018, 10:32 AM · Restricted Project

Apr 17 2018

Eugene.Zelenko added a comment to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..

*hust* /llvm/tools/clang/lib/Analysis/PseudoConstantAnalysis.cpp

I will check this one first, before we get crazy and implemented something twice.

Apr 17 2018, 6:57 AM · Restricted Project

Apr 16 2018

Eugene.Zelenko added inline comments to D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions..
Apr 16 2018, 3:47 PM · Restricted Project
Eugene.Zelenko added reviewers for D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions.: alexfh, hokein, aaron.ballman, ilya-biryukov.
Apr 16 2018, 3:40 PM · Restricted Project
Eugene.Zelenko added a comment to D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions..

Please also take a look on 26817 for another idea for .data().

Apr 16 2018, 3:39 PM · Restricted Project
Eugene.Zelenko added a comment to D45444: [clang-tidy] WIP: implement new check for const-correctness.
  • I would imagine things could get messier if this check expands to also check for turning member functions const: it's basically checking CxxThisExpr, being a handle, is not modified within a member function, but note there's no VarDecl for "this".
Apr 16 2018, 10:35 AM

Apr 15 2018

Eugene.Zelenko added a comment to D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement..

See also D45444.

Apr 15 2018, 7:22 PM · Restricted Project
Eugene.Zelenko retitled D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement. from Add a new check, readability-unmodified-non-const-variable, that finds declarations of non-const variables that never get modified. to [clang-tidy] Add a new check, readability-unmodified-non-const-variable, that finds declarations of non-const variables that never get modified..
Apr 15 2018, 7:21 PM · Restricted Project

Apr 12 2018

Eugene.Zelenko added a comment to D45601: Warn on bool* to bool conversion.

There is Clang-tidy's readability-implicit-bool-conversion check.

Apr 12 2018, 4:39 PM
Eugene.Zelenko removed a reviewer for D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree: Eugene.Zelenko.
Apr 12 2018, 6:34 AM
Eugene.Zelenko added inline comments to D45420: [NFC] [LoopUtil] Moved RecurrenceDescriptor/LoopDescriptor from Transform/Utils/LoopUtils.* to Analysis tree.
Apr 12 2018, 6:31 AM

Apr 10 2018

Eugene.Zelenko added a comment to D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'.

How about doing same for objc-property-declaration?

Apr 10 2018, 6:07 PM · Restricted Project
Eugene.Zelenko added a comment to D45444: [clang-tidy] WIP: implement new check for const-correctness.

It'll be good idea to have option to apply this check for pointer/references only, or include built-in types/enums.

Agreed. I aim at a mark handles const(default on), mark values const(default on for objects), mark pointer (const int * >> const <<) const (default off)

What do you mean by built-in types/enums? That they are configurable separate to objects?

Apr 10 2018, 10:32 AM
Eugene.Zelenko added inline comments to D45468: [clang-tidy] Adding Fuchsia checker for human-readable logging.
Apr 10 2018, 10:19 AM · Restricted Project

Apr 9 2018

Eugene.Zelenko added a comment to D45444: [clang-tidy] WIP: implement new check for const-correctness.

Will be good idea to add HICPP alias.

Apr 9 2018, 3:16 PM
Eugene.Zelenko added a comment to D45444: [clang-tidy] WIP: implement new check for const-correctness.

It'll be good idea to have option to apply this check for pointer/references only, or include built-in types/enums.

Apr 9 2018, 11:01 AM

Apr 8 2018

Eugene.Zelenko added a comment to D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'.

If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like objc-ivar-declaration and objc-property-declaration.

Thanks for the suggestion. I understand your point that they are both naming convention, however, they are about different components and using totally different naming rules. PropertyDeclarationCheck is already a very complicated check (the most complicated one for ObjC), I would rather not make it more heavy and try my best to split independent logic to different checks.

See readability-identifier-naming as example of multiple rules in one check.

I took a look at IdentifierNamingCheck. Here's my thought:

  1. IdentifierNamingCheck is trying to apply configurable naming convention to C++ identifiers, and all the identifiers will share the same style set. That is not the case of ObjC, where we follow Apple's programming guide, and different types of identifiers are using different style.
  2. Such pattern can handle complicated requirements but to me it is not simple enough to read and maintain. I would rather keep things simple and clear as long as we have choice.

    However, this check provides a good example of refactoring if in the future we have the needs of organizing complicated naming styles. Moving from simplicity to complexity is always easier. Thanks for pointing this out for us.

My point is not flexibility of configuration, but handling of various types of identifiers in same check, even if conventions are different.

Yes I understand but I mean "flexibility of configuration" is one of the reasons of handling of various types of identifiers in same check, but we don't need it here.

Apr 8 2018, 3:22 PM · Restricted Project
Eugene.Zelenko added a comment to D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'.

If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like objc-ivar-declaration and objc-property-declaration.

Thanks for the suggestion. I understand your point that they are both naming convention, however, they are about different components and using totally different naming rules. PropertyDeclarationCheck is already a very complicated check (the most complicated one for ObjC), I would rather not make it more heavy and try my best to split independent logic to different checks.

See readability-identifier-naming as example of multiple rules in one check.

I took a look at IdentifierNamingCheck. Here's my thought:

  1. IdentifierNamingCheck is trying to apply configurable naming convention to C++ identifiers, and all the identifiers will share the same style set. That is not the case of ObjC, where we follow Apple's programming guide, and different types of identifiers are using different style.
  2. Such pattern can handle complicated requirements but to me it is not simple enough to read and maintain. I would rather keep things simple and clear as long as we have choice.

    However, this check provides a good example of refactoring if in the future we have the needs of organizing complicated naming styles. Moving from simplicity to complexity is always easier. Thanks for pointing this out for us.
Apr 8 2018, 7:05 AM · Restricted Project

Apr 7 2018

Eugene.Zelenko added a comment to D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'.

If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like objc-ivar-declaration and objc-property-declaration.

Thanks for the suggestion. I understand your point that they are both naming convention, however, they are about different components and using totally different naming rules. PropertyDeclarationCheck is already a very complicated check (the most complicated one for ObjC), I would rather not make it more heavy and try my best to split independent logic to different checks.

Apr 7 2018, 8:22 PM · Restricted Project

Apr 6 2018

Eugene.Zelenko added a comment to D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_'.

If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like objc-ivar-declaration and objc-property-declaration.

Apr 6 2018, 5:23 PM · Restricted Project
Eugene.Zelenko retitled D45392: [clang-tidy] add new check to find out objc ivars which do not have prefix '_' from add new check to find out objc ivars which do not have prefix '_' to [clang-tidy] add new check to find out objc ivars which do not have prefix '_'.
Apr 6 2018, 5:16 PM · Restricted Project

Apr 4 2018

Eugene.Zelenko added a comment to D44519: Add llvm-exegesis tool..

I found /usr/lib/libpfm.so.3.10.0

Apr 4 2018, 11:34 AM
Eugene.Zelenko added a comment to D44519: Add llvm-exegesis tool..

Looks like CMake is not checking for external dependencies properly. I got build error on RHEL 6 because of missing perfmon/perf_event.h. Most likely perfmon version is too old on RHEL6.

Apr 4 2018, 11:22 AM

Mar 31 2018

Eugene.Zelenko added inline comments to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.
Mar 31 2018, 8:58 AM · Restricted Project

Mar 29 2018

Eugene.Zelenko added inline comments to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen.
Mar 29 2018, 2:49 PM · Restricted Project
Eugene.Zelenko added inline comments to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen.
Mar 29 2018, 2:11 PM · Restricted Project
Eugene.Zelenko added a comment to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.

Will be good idea to clarify where TEMP_FAILURE_RETRY come from.

Mar 29 2018, 1:21 PM · Restricted Project
Eugene.Zelenko retitled D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY from Add a clang-tidy check to catch comparisons in TEMP_FAILURE_RETRY to [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.
Mar 29 2018, 1:01 PM · Restricted Project
Eugene.Zelenko added inline comments to D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY.
Mar 29 2018, 1:01 PM · Restricted Project
Eugene.Zelenko added inline comments to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen.
Mar 29 2018, 11:10 AM · Restricted Project
Eugene.Zelenko edited reviewers for D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen, added: hokein, ilya-biryukov; removed: xazax.hun.
Mar 29 2018, 11:10 AM · Restricted Project
Eugene.Zelenko added inline comments to D45050: [clang-tidy] New checker for not null-terminated result caused by strlen or wcslen.
Mar 29 2018, 10:49 AM · Restricted Project
Eugene.Zelenko added inline comments to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.
Mar 29 2018, 10:23 AM · Restricted Project

Mar 28 2018

Eugene.Zelenko added inline comments to D33537: [clang-tidy] Exception Escape Checker.
Mar 28 2018, 10:06 AM · Restricted Project

Mar 27 2018

Eugene.Zelenko added a comment to D44948: Add diagnostic -Waggregate-ctors, "aggregate type has user-declared constructors".

Please mention new diagnostics in documentation and Release Notes.

Mar 27 2018, 4:46 PM · Restricted Project
Eugene.Zelenko added reviewers for D44948: Add diagnostic -Waggregate-ctors, "aggregate type has user-declared constructors": rsmith, erichkeane, dblaikie.
Mar 27 2018, 4:45 PM · Restricted Project

Mar 26 2018

Eugene.Zelenko added a comment to D43341: [clang-doc] Implement reducer portion of the frontend framework.

Please mention new tool in Release Notes and use :doc: to refer to its manual.

Mar 26 2018, 5:02 PM · Restricted Project
Eugene.Zelenko added a comment to D44912: [clang-doc] Removing -Wunused-variable warning.

I think it's fine to commit trivial fixes without going via review.

Mar 26 2018, 4:07 PM · Restricted Project
Eugene.Zelenko added reviewers for D44906: [clang-tidy] Define __clang_analyzer__ macro for clang-tidy for compatibility with clang static analyzer: alexfh, hokein, aaron.ballman.
Mar 26 2018, 1:37 PM · Restricted Project
Eugene.Zelenko added a comment to D41648: [clang-tidy] implement cppcoreguidelines macro rules.

Which checks do you have in mind?

Mar 26 2018, 10:10 AM
Eugene.Zelenko added inline comments to D41648: [clang-tidy] implement cppcoreguidelines macro rules.
Mar 26 2018, 9:07 AM
Eugene.Zelenko added inline comments to D41648: [clang-tidy] implement cppcoreguidelines macro rules.
Mar 26 2018, 9:04 AM

Mar 23 2018

Eugene.Zelenko added a comment to D44826: Add -Wunused-using, a warning that finds unused using declarations..

Please also mention new warning in Release Notes and documentation.

Mar 23 2018, 11:22 AM · Restricted Project
Eugene.Zelenko added a comment to D44826: Add -Wunused-using, a warning that finds unused using declarations..

This duplicates Clang-tidy misc-unused-using-decls. If Clang will provide same or better functionality, it should be removed.

Mar 23 2018, 11:19 AM · Restricted Project
Eugene.Zelenko added inline comments to D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons.
Mar 23 2018, 8:07 AM · Restricted Project
Eugene.Zelenko added inline comments to D33537: [clang-tidy] Exception Escape Checker.
Mar 23 2018, 6:55 AM · Restricted Project

Mar 22 2018

Eugene.Zelenko added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 22 2018, 1:06 PM · Restricted Project
Eugene.Zelenko added inline comments to D44602: [clang-tidy] readability-function-size: add VariableThreshold param..
Mar 22 2018, 6:55 AM · Restricted Project

Mar 20 2018

Eugene.Zelenko created D44694: [clang-tidy] Use :doc: for check links in Release Notes.
Mar 20 2018, 11:18 AM · Restricted Project
Eugene.Zelenko added inline comments to D44519: Add llvm-exegesis tool..
Mar 20 2018, 10:59 AM

Mar 19 2018

Eugene.Zelenko added inline comments to D44636: [Release Notes] Add release note for llvm-mca.
Mar 19 2018, 1:37 PM

Mar 17 2018

Eugene.Zelenko added inline comments to D44602: [clang-tidy] readability-function-size: add VariableThreshold param..
Mar 17 2018, 2:30 PM · Restricted Project

Mar 16 2018

Eugene.Zelenko added inline comments to D44519: Add llvm-exegesis tool..
Mar 16 2018, 6:20 AM
Eugene.Zelenko added inline comments to D44519: Add llvm-exegesis tool..
Mar 16 2018, 6:16 AM

Mar 15 2018

Eugene.Zelenko added inline comments to D44519: Add llvm-exegesis tool..
Mar 15 2018, 12:38 PM
Eugene.Zelenko added a comment to D44519: Add llvm-exegesis tool..

Please run Clang-format and Clang-tidy modernize.

Mar 15 2018, 12:35 PM

Mar 14 2018

Eugene.Zelenko added inline comments to D44464: allow custom OptBisect classes set to LLVMContext.
Mar 14 2018, 7:01 AM

Mar 13 2018

Eugene.Zelenko added inline comments to D44346: [clang-tidy] Add Zircon module to clang-tidy.
Mar 13 2018, 2:38 PM · Restricted Project
Eugene.Zelenko added reviewers for D44143: [clang-tidy] Create properly seeded random generator check: hokein, ilya-biryukov.
Mar 13 2018, 11:28 AM · Restricted Project
Eugene.Zelenko added inline comments to D44143: [clang-tidy] Create properly seeded random generator check.
Mar 13 2018, 11:28 AM · Restricted Project

Mar 11 2018

Eugene.Zelenko added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 11 2018, 4:46 PM · Restricted Project

Mar 10 2018

Eugene.Zelenko edited reviewers for D44354: [lldb] Unbreak lldb builds due to r327219, added: labath, zturner; removed: Eugene.Zelenko.
Mar 10 2018, 12:42 PM · Restricted Project

Mar 9 2018

Eugene.Zelenko added inline comments to D44346: [clang-tidy] Add Zircon module to clang-tidy.
Mar 9 2018, 9:10 PM · Restricted Project
Eugene.Zelenko added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 9 2018, 1:53 PM · Restricted Project
Eugene.Zelenko edited reviewers for D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods, added: hokein, aaron.ballman, ilya-biryukov; removed: klimek.
Mar 9 2018, 10:18 AM · Restricted Project
Eugene.Zelenko added inline comments to D44295: [clang-tidy] Detect and fix calls to grand-...parent virtual methods instead of calls to parent's virtual methods.
Mar 9 2018, 10:15 AM · Restricted Project

Mar 6 2018

Eugene.Zelenko added inline comments to D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics.
Mar 6 2018, 4:31 PM · Restricted Project
Eugene.Zelenko added a comment to D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics.

Please mention new module in Release Notes. I think new modules should be before new checks there.

Mar 6 2018, 4:24 PM · Restricted Project
Eugene.Zelenko added reviewers for D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics: hokein, aaron.ballman, ilya-biryukov.
Mar 6 2018, 1:29 PM · Restricted Project
Eugene.Zelenko added a comment to D44140: Add missing header for InstructionCombining.cpp, in order to export LLVMInitializeInstCombine as extern "C".

I cannot commit this patch myself. I do not have permissions.

Mar 6 2018, 8:35 AM
Eugene.Zelenko accepted D44140: Add missing header for InstructionCombining.cpp, in order to export LLVMInitializeInstCombine as extern "C".
Mar 6 2018, 8:10 AM
Eugene.Zelenko added a comment to D44140: Add missing header for InstructionCombining.cpp, in order to export LLVMInitializeInstCombine as extern "C".

Please run Clang-fromat. If I'm not mistaken, llvm-c/Initialization.h should be after InstCombineInternal.h.

Mar 6 2018, 6:46 AM

Mar 5 2018

Eugene.Zelenko added inline comments to D41102: Setup clang-doc frontend framework.
Mar 5 2018, 6:17 PM · Restricted Project

Mar 2 2018

Eugene.Zelenko added a comment to D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith.

Thanks everyone for your comments! I renamed the namespace and filenames to 'abseil'.

@Eugene.Zelenko, definitely interested in extending this to a C++20 modernize check and adding absl::EndsWith() support, would it be OK though to do this in a later patch?

Mar 2 2018, 12:01 PM · Restricted Project

Mar 1 2018

Eugene.Zelenko added a comment to D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith.

By the word, may be similar check for std::string::rfind() and std::string::ends_with() (does abseil have analog) should be added too?

Mar 1 2018, 6:26 AM · Restricted Project
Eugene.Zelenko added a comment to D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith.

I need a bit more context because I'm unfamiliar with absl. What is this module's intended use?

As absl has been open-sourced (https://github.com/abseil/abseil-cpp), I think there will be more absl-related checks contributed from google or external contributors in the future, so it make sense to create a new module.

@niko, could you please refine the code style of this patch to follow the LLVM code standard (especially the variable name, should be camel case "VariableName")?

Mar 1 2018, 6:25 AM · Restricted Project
Eugene.Zelenko removed a reviewer for D43929: [RewriteStatepoints] Fix stale parse points: Eugene.Zelenko.
Mar 1 2018, 6:19 AM

Feb 28 2018

Eugene.Zelenko added inline comments to D43870: [clang-tidy] Another batch of checks to rename from misc- to bugprone-..
Feb 28 2018, 10:20 AM

Feb 27 2018

Eugene.Zelenko added a comment to D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith.

std::basic_string::starts_with() was suggested for C++20. May be will be good idea to generalize code to create absl and modernize checks?

Feb 27 2018, 6:30 PM · Restricted Project
Eugene.Zelenko retitled D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith from [tidy] Add check: replace string::find(...) == 0 with absl::StartsWith to [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith.
Feb 27 2018, 6:26 PM · Restricted Project
Eugene.Zelenko added a comment to D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith.

Please add new module in docs/clang-tidy/index.rst and mention it in release notes.

Feb 27 2018, 6:25 PM · Restricted Project