Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (197 w, 5 d)

Recent Activity

Yesterday

Eugene.Zelenko added inline comments to D59639: [clangd] Print template arguments helper.
Fri, Mar 22, 6:49 AM · Restricted Project

Thu, Mar 21

Eugene.Zelenko added inline comments to D59639: [clangd] Print template arguments helper.
Thu, Mar 21, 8:38 AM · Restricted Project

Wed, Mar 20

Eugene.Zelenko added inline comments to D59605: [clangd] Introduce background-indexer.
Wed, Mar 20, 10:57 AM · Restricted Project
Eugene.Zelenko added inline comments to D59599: [clangd] Fix a crash while printing Template Arguments.
Wed, Mar 20, 10:47 AM · Restricted Project
Eugene.Zelenko added inline comments to D59605: [clangd] Introduce background-indexer.
Wed, Mar 20, 10:47 AM · Restricted Project

Tue, Mar 19

Eugene.Zelenko added inline comments to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.
Tue, Mar 19, 9:43 AM · Restricted Project

Thu, Mar 7

Eugene.Zelenko added inline comments to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.
Thu, Mar 7, 12:38 PM · Restricted Project, Restricted Project
Eugene.Zelenko removed a project from D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator: Restricted Project.
Thu, Mar 7, 12:35 PM · Restricted Project, Restricted Project

Wed, Mar 6

Eugene.Zelenko added reviewers for D58977: [clang-tidy] Add the abseil-time-comparison check: aaron.ballman, alexfh.
Wed, Mar 6, 8:10 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D58977: [clang-tidy] Add the abseil-time-comparison check.
Wed, Mar 6, 8:09 AM · Restricted Project, Restricted Project

Sat, Mar 2

Eugene.Zelenko added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Sat, Mar 2, 1:44 PM · Restricted Project

Wed, Feb 27

Eugene.Zelenko added inline comments to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
Wed, Feb 27, 3:54 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Feb 25

Eugene.Zelenko added reviewers for D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.: hokein, aaron.ballman, JonasToth.
Mon, Feb 25, 2:25 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower: hokein, aaron.ballman, JonasToth.
Mon, Feb 25, 4:46 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D58606: [clang-tidy] misc-string-integer-assignment: fix false positive: hokein, aaron.ballman, JonasToth.
Mon, Feb 25, 4:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 21 2019

Eugene.Zelenko added inline comments to D58478: [index-while-building] FileIndexRecord.
Feb 21 2019, 1:22 PM · Restricted Project

Feb 20 2019

Eugene.Zelenko added inline comments to D58478: [index-while-building] FileIndexRecord.
Feb 20 2019, 4:26 PM · Restricted Project

Feb 16 2019

Eugene.Zelenko added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 16 2019, 8:50 AM · Restricted Project, Restricted Project

Feb 12 2019

Eugene.Zelenko added inline comments to D58162: [hwasan] Runtime flags for malloc bisection..
Feb 12 2019, 6:31 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 12 2019, 11:54 AM · Restricted Project, Restricted Project

Feb 11 2019

Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 11 2019, 2:40 PM · Restricted Project
Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 11 2019, 7:55 AM · Restricted Project

Feb 10 2019

Eugene.Zelenko removed a reviewer for D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682): Eugene.Zelenko.
Feb 10 2019, 1:10 PM · Restricted Project

Feb 9 2019

Eugene.Zelenko added a comment to D33841: [clang-tidy] redundant keyword check.

Please mention new check in Release Notes.

Feb 9 2019, 1:32 PM · Restricted Project

Feb 8 2019

Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 8 2019, 7:18 PM · Restricted Project
Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 8 2019, 6:51 PM · Restricted Project
Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 8 2019, 5:54 PM · Restricted Project
Eugene.Zelenko added inline comments to D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted).
Feb 8 2019, 1:49 PM · Restricted Project, Restricted Project

Feb 7 2019

Eugene.Zelenko set the repository for D55725: [OpenMP] Add libs to clang-dedicated directories to rOMP OpenMP.
Feb 7 2019, 10:09 AM · Restricted Project

Feb 5 2019

Eugene.Zelenko added a comment to D57757: [scudo][standalone] Do not error out on spurious C(XX) flags.

May be removing -stdlib is better solution since it contradict with -nostdinc++?

Feb 5 2019, 11:01 AM · Restricted Project, Restricted Project

Feb 4 2019

Eugene.Zelenko added a comment to D57412: [scudo] Initial standalone skeleton check-in.

Build with -DLLVM_ENABLE_LIBCXX=ON is broken because:

Feb 4 2019, 6:35 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals.
Feb 4 2019, 11:35 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2019

Herald added a project to D35937: [clang-tidy] Add new readability non-idiomatic static access: Restricted Project.

Please look at recently filed PR40544.

Feb 1 2019, 11:03 AM · Restricted Project, Restricted Project

Jan 30 2019

Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Jan 30 2019, 6:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D57457: [docs][mips] 8.0 Release notes.
Jan 30 2019, 1:11 PM
Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Jan 30 2019, 11:06 AM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D57435: [clang-tidy] Add abseil-wrap-unique check from [clang-tidy] created wrap-unique check to [clang-tidy] Add abseil-wrap-unique check.
Jan 30 2019, 11:02 AM · Restricted Project, Restricted Project

Jan 29 2019

Eugene.Zelenko added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 29 2019, 11:40 AM · Restricted Project, Restricted Project

Jan 28 2019

Eugene.Zelenko added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 28 2019, 1:27 PM · Restricted Project, Restricted Project

Jan 26 2019

Eugene.Zelenko added a comment to D57113: [clang-tidy] openmp-use-default-none - a new check.

New module is still not mentioned in docs/clang-tidy/index.rst.

Jan 26 2019, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2019

Eugene.Zelenko added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 24 2019, 1:45 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

A few questions:

  1. why do we want to lint just clang-tidy docs and not all LLVM's .rst files?
Jan 24 2019, 10:20 AM · Restricted Project

Jan 23 2019

Eugene.Zelenko added a comment to D57113: [clang-tidy] openmp-use-default-none - a new check.

Please mention new module in docs/clang-tidy/index.rst.

Jan 23 2019, 12:45 PM · Restricted Project, Restricted Project, Restricted Project

Jan 21 2019

Eugene.Zelenko added a comment to D56946: [Documentation] Use HTTPS whenever possible in Clang.

Yes, I tested all URLs, but I think independent testing will not be excessive.

Jan 21 2019, 6:45 AM · Restricted Project

Jan 18 2019

Eugene.Zelenko added inline comments to D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️.
Jan 18 2019, 4:54 PM · Restricted Project
Eugene.Zelenko created D56946: [Documentation] Use HTTPS whenever possible in Clang.
Jan 18 2019, 4:43 PM · Restricted Project
Eugene.Zelenko updated the diff for D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.

Don't use HTTPS for www.codingstandard.com

Jan 18 2019, 1:03 PM · Restricted Project
Eugene.Zelenko created D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.
Jan 18 2019, 12:01 PM · Restricted Project

Jan 17 2019

Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

I requested merge of updated documentation into 8.0 branch in PR40369.

Jan 17 2019, 5:09 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

By the word, I noticed that HTTP was used and replaced it with HTTPS in Contributing.rst. Will be good idea to do the same in other documentation.

Jan 17 2019, 12:13 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

I fixed links.

Jan 17 2019, 12:13 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

clang-tools-sphinx-docs bot is failing because of:

Jan 17 2019, 10:50 AM · Restricted Project

Jan 16 2019

Eugene.Zelenko added inline comments to D56819: Document toolchain update policy.
Jan 16 2019, 5:14 PM

Jan 14 2019

Eugene.Zelenko added reviewers for D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.: alexfh, hokein, aaron.ballman, JonasToth.
Jan 14 2019, 10:19 AM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@Eugene.Zelenko

I would suggest to rename contribution to Contributing (see LLVM documentation) and integrations to Integrations.

Sure, done.

Will be also good idea to fix D55523 script warnings.

The script warns about double spaces and line width in the table, for example:

warning: line 39 contains double spaces
warning: line 39 is in excess of 80 characters (196)

These spaces and width are intended since they 'draw' the table layout. Do you think we could ignore such warnings in this particular case?

Jan 14 2019, 10:16 AM · Restricted Project

Jan 13 2019

Eugene.Zelenko added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

It'll be worth to mention change in Release Notes (in changes list, in alphabetical order).

Jan 13 2019, 6:04 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D56644: [clang-tidy] readability-container-size-empty handle std::string length(), added: hokein, JonasToth; removed: Eugene.Zelenko.
Jan 13 2019, 6:02 AM · Restricted Project, Restricted Project

Jan 11 2019

Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

I would suggest to rename contribution to Contributing (see LLVM documentation) and integrations to Integrations.

Jan 11 2019, 4:32 PM · Restricted Project
Eugene.Zelenko added reviewers for D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.: hokein, aaron.ballman, JonasToth.
Jan 11 2019, 10:29 AM · Restricted Project
Eugene.Zelenko added inline comments to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.
Jan 11 2019, 10:28 AM · Restricted Project

Jan 10 2019

Eugene.Zelenko set the repository for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check to rCTE Clang Tools Extra.
Jan 10 2019, 5:36 PM · Restricted Project
Eugene.Zelenko added inline comments to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Jan 10 2019, 3:24 PM · Restricted Project
Eugene.Zelenko set the repository for D56563: [clang-tidy] add options documentation to readability-identifier-naming checker to rCTE Clang Tools Extra.
Jan 10 2019, 3:17 PM · Restricted Project
Eugene.Zelenko added a comment to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.

Thank you for keeping documentation up-to-date with code!

Jan 10 2019, 3:16 PM · Restricted Project
Eugene.Zelenko added a comment to D56536: [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker.

LGTM.
I am in favour of running clang-tidy on LLVM (i do have a private buildbot doing so, but for testing clang-tidy itself).

Take a look at clang-tidy/utils/run-clang-tidy.py and https://reviews.llvm.org/D54141 for speed up and better error messages, because deduplicated output.

Jan 10 2019, 12:09 PM
Eugene.Zelenko added inline comments to D54945: This commit adds a chapter about clang-tidy integrations.
Jan 10 2019, 11:46 AM · Restricted Project

Jan 9 2019

Eugene.Zelenko added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..
Jan 9 2019, 3:36 PM · Restricted Project
Eugene.Zelenko added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..

It'll be worth to add next suggestion:

Jan 9 2019, 10:43 AM · Restricted Project

Jan 8 2019

Eugene.Zelenko added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Jan 8 2019, 12:52 PM · Restricted Project
Eugene.Zelenko added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Jan 8 2019, 10:32 AM · Restricted Project
Eugene.Zelenko added reviewers for D56424: [clang-tidy] Add check for underscores in googletest names.: alexfh, aaron.ballman.
Jan 8 2019, 10:32 AM · Restricted Project
Eugene.Zelenko added inline comments to D56160: [clang-tidy] modernize-use-trailing-return-type check.
Jan 8 2019, 6:14 AM · Restricted Project
Eugene.Zelenko removed a reviewer for D56435: We can improve the performance (generally) by memo-izing the action to map a debug location to its function summary.: Eugene.Zelenko.
Jan 8 2019, 6:05 AM
Eugene.Zelenko removed a reviewer for D55094: Ignore PhiNodes when mapping sample profile data: Eugene.Zelenko.
Jan 8 2019, 6:05 AM

Jan 4 2019

Eugene.Zelenko set the repository for D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py to rCTE Clang Tools Extra.
Jan 4 2019, 5:56 PM · Restricted Project
Eugene.Zelenko added reviewers for D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr: alexfh, hokein, aaron.ballman, JonasToth.
Jan 4 2019, 10:58 AM · Restricted Project

Jan 2 2019

Eugene.Zelenko added inline comments to D56160: [clang-tidy] modernize-use-trailing-return-type check.
Jan 2 2019, 4:22 PM · Restricted Project

Dec 30 2018

Eugene.Zelenko added reviewers for D56160: [clang-tidy] modernize-use-trailing-return-type check: hokein, aaron.ballman, JonasToth.
Dec 30 2018, 11:11 AM · Restricted Project
Eugene.Zelenko added a comment to D56160: [clang-tidy] modernize-use-trailing-return-type check.

Please mention new check in Release Notes and list of checks. It'll be good idea to used add_new_check.py.

Dec 30 2018, 11:10 AM · Restricted Project

Dec 21 2018

Eugene.Zelenko added inline comments to D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
Dec 21 2018, 11:06 AM · Restricted Project

Dec 18 2018

Eugene.Zelenko set the repository for D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff to rCTE Clang Tools Extra.
Dec 18 2018, 1:43 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Please run script from D55523 over your changes.

Dec 18 2018, 6:54 AM · Restricted Project

Dec 17 2018

Eugene.Zelenko added inline comments to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).
Dec 17 2018, 6:23 PM · Restricted Project
Eugene.Zelenko added a reviewer for D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403): hokein.
Dec 17 2018, 2:56 PM · Restricted Project
Eugene.Zelenko added a comment to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).

Please close PR25403 after commit.

Dec 17 2018, 2:55 PM · Restricted Project
Eugene.Zelenko added reviewers for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments: alexfh, hokein, aaron.ballman.
Dec 17 2018, 2:53 PM · Restricted Project
Eugene.Zelenko removed a reviewer for D55758: [TableGen] : Extend !if semantics through new language feature !ifs: Eugene.Zelenko.
Dec 17 2018, 6:34 AM

Dec 13 2018

Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

I think will be good idea to discuss wider application for this script in llvm-dev. If LLVM use Clng-format, why not to use this script?

Dec 13 2018, 2:25 PM · Restricted Project
Eugene.Zelenko added inline comments to D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍.
Dec 13 2018, 11:15 AM · Restricted Project
Eugene.Zelenko added reviewers for D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍: alexfh, hokein, aaron.ballman, JonasToth.
Dec 13 2018, 11:14 AM · Restricted Project

Dec 12 2018

Eugene.Zelenko added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Dec 12 2018, 6:24 PM · Restricted Project
Eugene.Zelenko added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Dec 12 2018, 4:37 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

I think will be good idea to rename script to validate_documentation.py. Or may be lint?

Dec 12 2018, 10:52 AM · Restricted Project
Eugene.Zelenko added a comment to D55594: [clang-tidy] update readability-* and zircon-* check documentation to remove extraneous characters.

Looks OK for me, but I agree with Jonas, it's better to commit changes made with final version.

Dec 12 2018, 6:26 AM · Restricted Project

Dec 11 2018

Eugene.Zelenko added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Dec 11 2018, 6:30 PM · Restricted Project
Eugene.Zelenko added a comment to D55584: [LLDB] Simplify Boolean expressions.

Thank you for cleanup effort!

Dec 11 2018, 5:19 PM · Restricted Project
Eugene.Zelenko retitled D55584: [LLDB] Simplify Boolean expressions from Simplify boolean expressions to [LLDB] Simplify Boolean expressions.
Dec 11 2018, 5:13 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

  • Ensure same length of headers titles and markup.

Could you explain what you mean by this? I'm assuming you mean that when you see a title with --- or === or ^^^ then you expect the line about to be the exact same length, is that correct?

Example
-------

Yes, you understood correctly.

This should make you happy!

Checking .\../docs/clang-tidy/checks\hicpp-no-assembler.rst...
warning: line 4 title and markup non matching lengths
.. title:: clang-tidy - hicpp-no-assembler

hicpp-no-assembler
===================

Check for assembler statements. No fix is offered.
Dec 11 2018, 10:22 AM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

  • Ensure same length of headers titles and markup.

Could you explain what you mean by this? I'm assuming you mean that when you see a title with --- or === or ^^^ then you expect the line about to be the exact same length, is that correct?

Example
-------
Dec 11 2018, 6:20 AM · Restricted Project

Dec 10 2018

Eugene.Zelenko added inline comments to D55410: [clang-tidy] check for flagging using declarations in headers.
Dec 10 2018, 5:26 PM · Restricted Project