Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (188 w, 6 d)

Recent Activity

Fri, Jan 18

Eugene.Zelenko added inline comments to D56945: [clang-tidy] Delete obsolete objc-property-declaration options ✂️.
Fri, Jan 18, 4:54 PM · Restricted Project
Eugene.Zelenko created D56946: [Documentation] Use HTTPS whenever possible in Clang.
Fri, Jan 18, 4:43 PM · Restricted Project
Eugene.Zelenko updated the diff for D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.

Don't use HTTPS for www.codingstandard.com

Fri, Jan 18, 1:03 PM · Restricted Project
Eugene.Zelenko created D56926: [Documentation] Use HTTPS whenever possible in clang-tools-extra.
Fri, Jan 18, 12:01 PM · Restricted Project

Thu, Jan 17

Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

I requested merge of updated documentation into 8.0 branch in PR40369.

Thu, Jan 17, 5:09 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

By the word, I noticed that HTTP was used and replaced it with HTTPS in Contributing.rst. Will be good idea to do the same in other documentation.

Thu, Jan 17, 12:13 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

I fixed links.

Thu, Jan 17, 12:13 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

clang-tools-sphinx-docs bot is failing because of:

Thu, Jan 17, 10:50 AM · Restricted Project

Wed, Jan 16

Eugene.Zelenko added inline comments to D56819: Document toolchain update policy.
Wed, Jan 16, 5:14 PM

Mon, Jan 14

Eugene.Zelenko added reviewers for D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.: alexfh, hokein, aaron.ballman, JonasToth.
Mon, Jan 14, 10:19 AM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

@Eugene.Zelenko

I would suggest to rename contribution to Contributing (see LLVM documentation) and integrations to Integrations.

Sure, done.

Will be also good idea to fix D55523 script warnings.

The script warns about double spaces and line width in the table, for example:

warning: line 39 contains double spaces
warning: line 39 is in excess of 80 characters (196)

These spaces and width are intended since they 'draw' the table layout. Do you think we could ignore such warnings in this particular case?

Mon, Jan 14, 10:16 AM · Restricted Project

Sun, Jan 13

Eugene.Zelenko added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

It'll be worth to mention change in Release Notes (in changes list, in alphabetical order).

Sun, Jan 13, 6:04 AM · Restricted Project
Eugene.Zelenko edited reviewers for D56644: [clang-tidy] readability-container-size-empty handle std::string length(), added: hokein, JonasToth; removed: Eugene.Zelenko.
Sun, Jan 13, 6:02 AM · Restricted Project

Fri, Jan 11

Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

I would suggest to rename contribution to Contributing (see LLVM documentation) and integrations to Integrations.

Fri, Jan 11, 4:32 PM · Restricted Project
Eugene.Zelenko added reviewers for D56585: [clang-tidy] Treat references to smart pointers correctly in use-after-move.: hokein, aaron.ballman, JonasToth.
Fri, Jan 11, 10:29 AM · Restricted Project
Eugene.Zelenko added inline comments to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.
Fri, Jan 11, 10:28 AM · Restricted Project

Thu, Jan 10

Eugene.Zelenko set the repository for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check to rCTE Clang Tools Extra.
Thu, Jan 10, 5:36 PM · Restricted Project
Eugene.Zelenko added inline comments to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Thu, Jan 10, 3:24 PM · Restricted Project
Eugene.Zelenko set the repository for D56563: [clang-tidy] add options documentation to readability-identifier-naming checker to rCTE Clang Tools Extra.
Thu, Jan 10, 3:17 PM · Restricted Project
Eugene.Zelenko added a comment to D56563: [clang-tidy] add options documentation to readability-identifier-naming checker.

Thank you for keeping documentation up-to-date with code!

Thu, Jan 10, 3:16 PM · Restricted Project
Eugene.Zelenko added a comment to D56536: [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker.

LGTM.
I am in favour of running clang-tidy on LLVM (i do have a private buildbot doing so, but for testing clang-tidy itself).

Take a look at clang-tidy/utils/run-clang-tidy.py and https://reviews.llvm.org/D54141 for speed up and better error messages, because deduplicated output.

Thu, Jan 10, 12:09 PM
Eugene.Zelenko added inline comments to D54945: This commit adds a chapter about clang-tidy integrations.
Thu, Jan 10, 11:46 AM · Restricted Project

Wed, Jan 9

Eugene.Zelenko added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..
Wed, Jan 9, 3:36 PM
Eugene.Zelenko added a comment to D56482: DO NOT SUBMIT. Draft for guidelines on using Phabricator..

It'll be worth to add next suggestion:

Wed, Jan 9, 10:43 AM

Tue, Jan 8

Eugene.Zelenko added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Tue, Jan 8, 12:52 PM · Restricted Project
Eugene.Zelenko added inline comments to D56424: [clang-tidy] Add check for underscores in googletest names..
Tue, Jan 8, 10:32 AM · Restricted Project
Eugene.Zelenko added reviewers for D56424: [clang-tidy] Add check for underscores in googletest names.: alexfh, aaron.ballman.
Tue, Jan 8, 10:32 AM · Restricted Project
Eugene.Zelenko added inline comments to D56160: [clang-tidy] modernize-use-trailing-return check.
Tue, Jan 8, 6:14 AM · Restricted Project
Eugene.Zelenko removed a reviewer for D56435: We can improve the performance (generally) by memo-izing the action to map a debug location to its function summary.: Eugene.Zelenko.
Tue, Jan 8, 6:05 AM
Eugene.Zelenko removed a reviewer for D55094: Ignore PhiNodes when mapping sample profile data: Eugene.Zelenko.
Tue, Jan 8, 6:05 AM

Fri, Jan 4

Eugene.Zelenko set the repository for D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py to rCTE Clang Tools Extra.
Fri, Jan 4, 5:56 PM · Restricted Project
Eugene.Zelenko added reviewers for D56323: [clang-tidy] Handle member variables in readability-simplify-boolean-expr: alexfh, hokein, aaron.ballman, JonasToth.
Fri, Jan 4, 10:58 AM · Restricted Project

Wed, Jan 2

Eugene.Zelenko added inline comments to D56160: [clang-tidy] modernize-use-trailing-return check.
Wed, Jan 2, 4:22 PM · Restricted Project

Sun, Dec 30

Eugene.Zelenko added reviewers for D56160: [clang-tidy] modernize-use-trailing-return check: hokein, aaron.ballman, JonasToth.
Sun, Dec 30, 11:11 AM · Restricted Project
Eugene.Zelenko added a comment to D56160: [clang-tidy] modernize-use-trailing-return check.

Please mention new check in Release Notes and list of checks. It'll be good idea to used add_new_check.py.

Sun, Dec 30, 11:10 AM · Restricted Project

Dec 21 2018

Eugene.Zelenko added inline comments to D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
Dec 21 2018, 11:06 AM · Restricted Project

Dec 18 2018

Eugene.Zelenko set the repository for D55848: [clang-tidy] Add export-fixes flag to clang-tidy-diff to rCTE Clang Tools Extra.
Dec 18 2018, 1:43 PM · Restricted Project
Eugene.Zelenko added a comment to D54945: This commit adds a chapter about clang-tidy integrations.

Please run script from D55523 over your changes.

Dec 18 2018, 6:54 AM · Restricted Project

Dec 17 2018

Eugene.Zelenko added inline comments to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).
Dec 17 2018, 6:23 PM · Restricted Project
Eugene.Zelenko added a reviewer for D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403): hokein.
Dec 17 2018, 2:56 PM · Restricted Project
Eugene.Zelenko added a comment to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).

Please close PR25403 after commit.

Dec 17 2018, 2:55 PM · Restricted Project
Eugene.Zelenko added reviewers for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments: alexfh, hokein, aaron.ballman.
Dec 17 2018, 2:53 PM · Restricted Project
Eugene.Zelenko removed a reviewer for D55758: [TableGen] : Extend !if semantics through new language feature !ifs: Eugene.Zelenko.
Dec 17 2018, 6:34 AM

Dec 13 2018

Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

I think will be good idea to discuss wider application for this script in llvm-dev. If LLVM use Clng-format, why not to use this script?

Dec 13 2018, 2:25 PM · Restricted Project
Eugene.Zelenko added inline comments to D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍.
Dec 13 2018, 11:15 AM · Restricted Project
Eugene.Zelenko added reviewers for D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍: alexfh, hokein, aaron.ballman, JonasToth.
Dec 13 2018, 11:14 AM · Restricted Project

Dec 12 2018

Eugene.Zelenko added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Dec 12 2018, 6:24 PM · Restricted Project
Eugene.Zelenko added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Dec 12 2018, 4:37 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

I think will be good idea to rename script to validate_documentation.py. Or may be lint?

Dec 12 2018, 10:52 AM · Restricted Project
Eugene.Zelenko added a comment to D55594: [clang-tidy] update readability-* and zircon-* check documentation to remove extraneous characters.

Looks OK for me, but I agree with Jonas, it's better to commit changes made with final version.

Dec 12 2018, 6:26 AM · Restricted Project

Dec 11 2018

Eugene.Zelenko added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Dec 11 2018, 6:30 PM
Eugene.Zelenko added a comment to D55584: [LLDB] Simplify Boolean expressions.

Thank you for cleanup effort!

Dec 11 2018, 5:19 PM · Restricted Project
Eugene.Zelenko retitled D55584: [LLDB] Simplify Boolean expressions from Simplify boolean expressions to [LLDB] Simplify Boolean expressions.
Dec 11 2018, 5:13 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

  • Ensure same length of headers titles and markup.

Could you explain what you mean by this? I'm assuming you mean that when you see a title with --- or === or ^^^ then you expect the line about to be the exact same length, is that correct?

Example
-------

Yes, you understood correctly.

This should make you happy!

Checking .\../docs/clang-tidy/checks\hicpp-no-assembler.rst...
warning: line 4 title and markup non matching lengths
.. title:: clang-tidy - hicpp-no-assembler

hicpp-no-assembler
===================

Check for assembler statements. No fix is offered.
Dec 11 2018, 10:22 AM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

  • Ensure same length of headers titles and markup.

Could you explain what you mean by this? I'm assuming you mean that when you see a title with --- or === or ^^^ then you expect the line about to be the exact same length, is that correct?

Example
-------
Dec 11 2018, 6:20 AM · Restricted Project

Dec 10 2018

Eugene.Zelenko added inline comments to D55410: [clang-tidy] check for flagging using declarations in headers.
Dec 10 2018, 5:26 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

Other common problems which will be great to detect with this script:

Dec 10 2018, 12:57 PM · Restricted Project
Eugene.Zelenko added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 10 2018, 12:54 PM · Restricted Project
Eugene.Zelenko added a comment to D55508: [clang-tidy] insert release notes for new checkers alphabetically.

By the word, will be good idea to have script which check alphabetical order and use it during build. Sometimes alphabetical order may be violated after merge with trunk.

Dec 10 2018, 11:46 AM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

Thank you for great idea! I think running this script should be part of build, like running Clang-format in Polly.

Dec 10 2018, 11:14 AM · Restricted Project
Eugene.Zelenko added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 10 2018, 6:24 AM · Restricted Project
Eugene.Zelenko added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 10 2018, 6:06 AM · Restricted Project
Eugene.Zelenko added a comment to D55508: [clang-tidy] insert release notes for new checkers alphabetically.

Thank you for this fix!

Dec 10 2018, 6:02 AM · Restricted Project
Eugene.Zelenko edited reviewers for D55508: [clang-tidy] insert release notes for new checkers alphabetically, added: hokein; removed: Eugene.Zelenko.
Dec 10 2018, 6:01 AM · Restricted Project

Dec 7 2018

Eugene.Zelenko added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 7 2018, 2:23 PM · Restricted Project
Eugene.Zelenko added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 7 2018, 1:38 PM · Restricted Project
Eugene.Zelenko added inline comments to D55433: [clang-tidy] Adding a new modernize use nodiscard checker.
Dec 7 2018, 10:54 AM · Restricted Project
Eugene.Zelenko added reviewers for D55433: [clang-tidy] Adding a new modernize use nodiscard checker: hokein, JonasToth.
Dec 7 2018, 10:51 AM · Restricted Project
Eugene.Zelenko added inline comments to D55410: [clang-tidy] check for flagging using declarations in headers.
Dec 7 2018, 10:51 AM · Restricted Project
Eugene.Zelenko added inline comments to D55410: [clang-tidy] check for flagging using declarations in headers.
Dec 7 2018, 10:46 AM · Restricted Project

Dec 5 2018

Eugene.Zelenko added inline comments to D55346: [clang-tidy] check for using declaration qualification.
Dec 5 2018, 7:22 PM · Restricted Project
Eugene.Zelenko added inline comments to D55346: [clang-tidy] check for using declaration qualification.
Dec 5 2018, 6:22 PM · Restricted Project
Eugene.Zelenko added reviewers for D55346: [clang-tidy] check for using declaration qualification: alexfh, hokein, aaron.ballman.
Dec 5 2018, 6:16 PM · Restricted Project

Dec 4 2018

Eugene.Zelenko added inline comments to D42682: [clang-tidy] Add io-functions-misused checker.
Dec 4 2018, 4:46 PM · Restricted Project
Eugene.Zelenko added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 4 2018, 10:12 AM · Restricted Project

Nov 30 2018

Eugene.Zelenko added a comment to D54757: [clang-tidy] new check: bugprone-branch-clone.

Please close PR30233 after committing patch.

Nov 30 2018, 2:06 PM · Restricted Project

Nov 29 2018

Eugene.Zelenko added inline comments to D54757: [clang-tidy] new check: bugprone-branch-clone.
Nov 29 2018, 1:53 PM · Restricted Project
Eugene.Zelenko added inline comments to D55044: [clang-tidy] check for Abseil make_unique.
Nov 29 2018, 10:25 AM · Restricted Project
Eugene.Zelenko retitled D55044: [clang-tidy] check for Abseil make_unique from [cfe-dev] clang-tidy check for Abseil make_unique to [clang-tidy] check for Abseil make_unique.
Nov 29 2018, 10:24 AM · Restricted Project

Nov 28 2018

Eugene.Zelenko added inline comments to D54945: This commit adds a chapter about clang-tidy integrations.
Nov 28 2018, 4:55 PM · Restricted Project

Nov 27 2018

Eugene.Zelenko added a project to D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness: Restricted Project.
Nov 27 2018, 2:24 PM · Restricted Project
Eugene.Zelenko added inline comments to D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness.
Nov 27 2018, 2:23 PM · Restricted Project

Nov 21 2018

Eugene.Zelenko added a comment to D54757: [clang-tidy] new check: bugprone-branch-clone.

Bar the previous comments, I really like this. The test suite is massive and well-constructed. Do we know of any real-world findings, maybe even from LLVM?

Nov 21 2018, 6:39 AM · Restricted Project

Nov 20 2018

Eugene.Zelenko added inline comments to D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 20 2018, 6:34 PM · Restricted Project
Eugene.Zelenko added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Nov 20 2018, 1:00 PM
Eugene.Zelenko edited reviewers for D54757: [clang-tidy] new check: bugprone-branch-clone, added: JonasToth; removed: xazax.hun, whisperity.
Nov 20 2018, 10:46 AM · Restricted Project
Eugene.Zelenko added inline comments to D54757: [clang-tidy] new check: bugprone-branch-clone.
Nov 20 2018, 10:43 AM · Restricted Project

Nov 9 2018

Eugene.Zelenko added inline comments to D54349: [clang-tidy] new check 'readability-redundant-preprocessor'.
Nov 9 2018, 2:02 PM · Restricted Project

Nov 8 2018

Eugene.Zelenko added inline comments to D54269: Introduce shard storage to auto-index..
Nov 8 2018, 4:00 PM
Eugene.Zelenko added a comment to D54262: [clang-tidy] Add `delete this` bugprone check (PR38741).

Please also add regression test case. Is should also cover standalone function with this variable.

Nov 8 2018, 10:26 AM · Restricted Project
Eugene.Zelenko added a comment to D54262: [clang-tidy] Add `delete this` bugprone check (PR38741).

Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).

Nov 8 2018, 10:24 AM · Restricted Project
Eugene.Zelenko added reviewers for D54262: [clang-tidy] Add `delete this` bugprone check (PR38741): aaron.ballman, JonasToth.
Nov 8 2018, 10:24 AM · Restricted Project
Eugene.Zelenko added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 8 2018, 10:12 AM · Restricted Project

Nov 7 2018

Eugene.Zelenko added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 7 2018, 5:49 PM · Restricted Project
Eugene.Zelenko retitled D54246: [clang-tidy] Add the abseil-duration-factory-scale check from Add the abseil-duration-factory-scale clang-tidy check to [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 7 2018, 5:38 PM · Restricted Project
Eugene.Zelenko added a comment to D54222: [clang-tidy] Add a check to detect returning static locals in public headers.

Please mention new check in Release Notes (in alphabetical order).

Nov 7 2018, 3:36 PM · Restricted Project
Eugene.Zelenko removed a reviewer for D54203: Use template instead of void* -based type erasure in MachineRegistry: Eugene.Zelenko.
Nov 7 2018, 1:56 PM
Eugene.Zelenko retitled D54222: [clang-tidy] Add a check to detect returning static locals in public headers from [clang-tidy/checks] Add a checker to detect returning static locals in public headers to [clang-tidy] Add a check to detect returning static locals in public headers.
Nov 7 2018, 1:53 PM · Restricted Project
Eugene.Zelenko added reviewers for D54222: [clang-tidy] Add a check to detect returning static locals in public headers: hokein, JonasToth.
Nov 7 2018, 1:53 PM · Restricted Project
Eugene.Zelenko added a comment to D54222: [clang-tidy] Add a check to detect returning static locals in public headers.

C++ Core Guidelines also mentioned similar patterns, so may be this check belongs to bugprone module?

Nov 7 2018, 1:52 PM · Restricted Project