Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (223 w, 6 d)

Recent Activity

Fri, Sep 20

Eugene.Zelenko added inline comments to D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads.
Fri, Sep 20, 5:11 PM · Restricted Project
Eugene.Zelenko added inline comments to D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads.
Fri, Sep 20, 5:11 PM · Restricted Project

Wed, Sep 18

Eugene.Zelenko added inline comments to D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Wed, Sep 18, 5:31 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Wed, Sep 18, 5:31 PM · Restricted Project, Restricted Project

Mon, Sep 16

Eugene.Zelenko added inline comments to D67632: [libTooling] Introduce new library of source-code builders..
Mon, Sep 16, 4:23 PM · Restricted Project

Fri, Sep 13

Eugene.Zelenko added inline comments to D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable..
Fri, Sep 13, 6:46 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage from New ClangTidy check to warn when storing dispatch_once_t in non-static, non-global storage to [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
Fri, Sep 13, 4:37 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable. from New ClangTidy check to warn when writing to a dispatch_once_t variable. to [clang-tidy] New check to warn when writing to a dispatch_once_t variable..
Fri, Sep 13, 4:37 PM · Restricted Project, Restricted Project

Thu, Sep 12

Eugene.Zelenko added reviewers for D67501: [clang-tidy] Fix relative path in header-filter.: hokein, aaron.ballman, gribozavr.
Thu, Sep 12, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Sep 11

Eugene.Zelenko added reviewers for D67460: clang-tidy: modernize-use-using work with multi-argument templates: hokein, aaron.ballman.
Wed, Sep 11, 4:30 PM · Restricted Project, Restricted Project

Fri, Sep 6

Eugene.Zelenko added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

It'll be reasonable to get IncludeStyle default from .clang-format.

I looked at existing checks and they all do the same thing as this one. In fact I got the code for this by directly copypasting an existing check.

Fri, Sep 6, 2:22 PM · Restricted Project
Eugene.Zelenko added a comment to D64671: [clang-tidy] New check: misc-init-local-variables.

It'll be reasonable to get IncludeStyle default from .clang-format.

Fri, Sep 6, 1:55 PM · Restricted Project
Eugene.Zelenko added inline comments to D67265: [clang-tidy] Magic number checker shouldn't warn on user defined string literals.
Fri, Sep 6, 6:52 AM · Restricted Project

Tue, Sep 3

Eugene.Zelenko added reviewers for D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field: alexfh, hokein, aaron.ballman.
Tue, Sep 3, 5:40 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field.

Please mention new option in Release Notes.

Tue, Sep 3, 5:40 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Tue, Sep 3, 10:06 AM · Restricted Project, Restricted Project

Mon, Sep 2

Eugene.Zelenko retitled D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos. from Fix bugprone-argument-comment bug if there are marcos. to [clang-tidy] Fix bugprone-argument-comment bug if there are marcos..
Mon, Sep 2, 9:56 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko retitled D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked. from Fix bugprone-argument-comment bug: negative literal number is not checked. to [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked..
Mon, Sep 2, 9:56 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Aug 28

Eugene.Zelenko added reviewers for D66864: [clang-tidy] readability-identifier-naming shouldn't complain about CRTP pseudo-overrides: alexfh, hokein, aaron.ballman.
Wed, Aug 28, 3:40 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Aug 26

Eugene.Zelenko added inline comments to D66627: [clang-tidy] add checks to bugprone-posix-return.
Mon, Aug 26, 2:05 PM · Restricted Project
Eugene.Zelenko added a comment to D66627: [clang-tidy] add checks to bugprone-posix-return.

It'll be reasonable to mention changes in Release Notes and check documentation.

Mon, Aug 26, 1:39 PM · Restricted Project

Sat, Aug 24

Eugene.Zelenko added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Sat, Aug 24, 8:07 AM · Restricted Project
Eugene.Zelenko added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Sat, Aug 24, 6:53 AM · Restricted Project

Aug 22 2019

Eugene.Zelenko added inline comments to D66627: [clang-tidy] add checks to bugprone-posix-return.
Aug 22 2019, 9:54 PM · Restricted Project
Eugene.Zelenko added inline comments to D66627: [clang-tidy] add checks to bugprone-posix-return.
Aug 22 2019, 6:22 PM · Restricted Project

Aug 16 2019

Eugene.Zelenko edited reviewers for D66365: [clang-tidy] [readability-convert-member-functions-to-static] ignore functions that hide base class methods, added: alexfh, hokein; removed: Eugene.Zelenko.
Aug 16 2019, 1:39 PM · Restricted Project, Restricted Project

Aug 9 2019

Eugene.Zelenko added a comment to D66029: llvm-canon.

Please also add documentation and mention new tool in LLVM documentation and Release Notes.

Aug 9 2019, 4:45 PM · Restricted Project
Eugene.Zelenko added inline comments to D66029: llvm-canon.
Aug 9 2019, 4:42 PM · Restricted Project
Eugene.Zelenko added a comment to D65912: [clang-tidy] Add new check for math constants.

... then I have a script that runs clang-tidy over all the compilation units in a compilation database

Can you share this script please? :)

Aug 9 2019, 11:37 AM · Restricted Project, Restricted Project

Aug 8 2019

Eugene.Zelenko removed reviewers for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM: arsenm, bogner.
Aug 8 2019, 11:10 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM: alexfh, hokein, aaron.ballman.
Aug 8 2019, 10:58 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM.

I think patch should be split at least on Clang-tidy check and results of its run on LLVM code. Probably per-target patches is even better solution.

Aug 8 2019, 10:56 AM · Restricted Project, Restricted Project
Eugene.Zelenko removed a reviewer for D65945: [LLVM][Alignment] Make functions using log of alignment explicit: Eugene.Zelenko.
Aug 8 2019, 10:14 AM · Restricted Project

Aug 7 2019

Eugene.Zelenko retitled D65917: [clang-tidy] Added check for the Google style guide's category method naming rule. from Added clang-tidy module for the Google style guide's category method naming rule. to [clang-tidy] Added check for the Google style guide's category method naming rule..
Aug 7 2019, 10:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Aug 7 2019, 10:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D65912: [clang-tidy] Add new check for math constants from Add new check for math constants to [clang-tidy] Add new check for math constants.
Aug 7 2019, 5:46 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D65912: [clang-tidy] Add new check for math constants.

May be this check belongs to readability module?

Aug 7 2019, 5:45 PM · Restricted Project, Restricted Project

Aug 6 2019

Eugene.Zelenko added reviewers for D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls: alexfh, hokein, aaron.ballman.
Aug 6 2019, 3:08 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D65828: [clang-tidy] Add check to linuxkernel for unbalanced irq calls.
Aug 6 2019, 3:08 PM · Restricted Project, Restricted Project

Aug 5 2019

Eugene.Zelenko added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Please also add installation, since pretty-printers should be shipped with libc++, same as GCC does with libstdc++ and its pretty-printers.

Did these pretty-printers exist for libc++ before this patch? If so, how were they shipped?

Aug 5 2019, 10:18 AM · Restricted Project
Eugene.Zelenko added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

I want to echo this. This is really cool. I _really_ hope we can get something similar for LLDB.

LLDB has pretty-printers. They are implemented in C++ instead of scripting.

Sorry, my point is that we don't have the pretty-printer tests checked into libc++ and part of its test suite, which has been a source of pain in the past. Changing that situation is what I was referring to when I said "I hope we can get something similar for LLDB".

Aug 5 2019, 9:56 AM · Restricted Project
Eugene.Zelenko added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

wow. This is a fantastic amount of work. Thank you. No longer will libc++ accidentally break the pretty printers!

I want to echo this. This is really cool. I _really_ hope we can get something similar for LLDB.

Aug 5 2019, 9:48 AM · Restricted Project

Aug 2 2019

Eugene.Zelenko added inline comments to D65622: [clang-doc] Update documentation.
Aug 2 2019, 11:55 AM · Restricted Project, Restricted Project

Aug 1 2019

Eugene.Zelenko added a comment to D65609: Add gdb pretty printers for a wide variety of libc++ data structures..

Please also add installation, since pretty-printers should be shipped with libc++, same as GCC does with libstdc++ and its pretty-printers.

Aug 1 2019, 4:08 PM · Restricted Project

Jul 30 2019

Eugene.Zelenko added a comment to D65483: [clang-doc] Add link to source code in file definitions.

It'll be reasonable to mention new command-line arguments in documentation and Release Notes.

Jul 30 2019, 7:17 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D65483: [clang-doc] Add link to source code in file definitions from [clang-format] Add link to source code in file definitions to [clang-doc] Add link to source code in file definitions.
Jul 30 2019, 5:21 PM · Restricted Project, Restricted Project

Jul 26 2019

Eugene.Zelenko accepted D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..
Jul 26 2019, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..

Sorry, I didn't notice that D59963 was committed. In general it's not good idea to commit changes when patch was not approved.

Jul 26 2019, 1:20 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D65343: [clang-tidy] Fix the documentation for linuxkernel-must-use-errs..

Looks OK, but please make this changes in D59963.

Jul 26 2019, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 26 2019, 9:54 AM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2019

Eugene.Zelenko added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 25 2019, 3:33 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Jul 25 2019, 9:50 AM · Restricted Project, Restricted Project, Restricted Project

Jul 22 2019

Eugene.Zelenko added inline comments to D65107: [clang-doc] Fix html entities in rendered text.
Jul 22 2019, 1:35 PM · Restricted Project, Restricted Project

Jul 15 2019

Eugene.Zelenko added inline comments to D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.
Jul 15 2019, 6:52 AM · Restricted Project, Restricted Project

Jul 12 2019

Eugene.Zelenko retitled D64671: [clang-tidy] New check: misc-init-local-variables from New clang-tidy check: misc-init-local-variables to [clang-tidy] New check: misc-init-local-variables.
Jul 12 2019, 4:24 PM · Restricted Project
Eugene.Zelenko added reviewers for D64671: [clang-tidy] New check: misc-init-local-variables: hokein, aaron.ballman, JonasToth.
Jul 12 2019, 4:22 PM · Restricted Project
Eugene.Zelenko added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Jul 12 2019, 4:21 PM · Restricted Project

Jul 10 2019

Eugene.Zelenko added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

Docs exist for these checks on the analyzer side, they're just all on the same page and hyperlinking to them individually is difficult because the links have a nonstandard naming convention. Currently I'm just linking to that page.

Jul 10 2019, 3:13 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

May be script should generate documentation during build, so files .rst files are not needed?

Jul 10 2019, 2:26 PM · Restricted Project, Restricted Project

Jul 9 2019

Eugene.Zelenko removed a reviewer for D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug: Eugene.Zelenko.
Jul 9 2019, 4:42 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
Jul 9 2019, 4:41 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D64407: [DWARF] Simplify DWARFAttribute. NFC..
Jul 9 2019, 6:12 AM · Restricted Project

Jul 3 2019

Eugene.Zelenko added inline comments to D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters..
Jul 3 2019, 2:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D64123: Add clang-llvm-rename tool..

There is clang-rename already. May be new functionality should be added there?

Jul 3 2019, 3:38 AM · Restricted Project

Jun 28 2019

Eugene.Zelenko added inline comments to D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check..
Jun 28 2019, 7:17 AM · Restricted Project, Restricted Project

Jun 25 2019

Eugene.Zelenko added reviewers for D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.: alexfh, hokein, aaron.ballman.
Jun 25 2019, 1:35 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D63763: [clang-tidy] Update documentation for Qt Creator integration..

Looks OK for me, but will be good idea to hear other people too.

Jun 25 2019, 6:28 AM · Restricted Project

Jun 24 2019

Eugene.Zelenko added inline comments to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.
Jun 24 2019, 7:57 AM · Restricted Project

Jun 21 2019

Eugene.Zelenko added inline comments to D63663: [clang-doc] Add html links to references.
Jun 21 2019, 3:08 PM · Restricted Project, Restricted Project

Jun 20 2019

Eugene.Zelenko added inline comments to D63623: [clang-tidy] new check: bugprone-posix-return.
Jun 20 2019, 4:14 PM · Restricted Project, Restricted Project

Jun 19 2019

Eugene.Zelenko added inline comments to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.
Jun 19 2019, 10:04 AM · Restricted Project

Jun 18 2019

Eugene.Zelenko added inline comments to D63324: [clang-tidy] Replace memcpy by std::copy.
Jun 18 2019, 7:14 AM · Restricted Project, Restricted Project

Jun 15 2019

Eugene.Zelenko added inline comments to D63324: [clang-tidy] Replace memcpy by std::copy.
Jun 15 2019, 12:28 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D63324: [clang-tidy] Replace memcpy by std::copy.
Jun 15 2019, 8:28 AM · Restricted Project, Restricted Project

Jun 14 2019

Eugene.Zelenko added inline comments to D63367: [clang-doc] Add basic support for templates and typedef.
Jun 14 2019, 5:48 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D63324: [clang-tidy] Replace memcpy by std::copy: alexfh, hokein, aaron.ballman, JonasToth.
Jun 14 2019, 10:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D63324: [clang-tidy] Replace memcpy by std::copy.

New check must be mentioned in Release Notes and its documentation provided.

Jun 14 2019, 10:22 AM · Restricted Project, Restricted Project

Jun 6 2019

Eugene.Zelenko added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

I think will be good idea to replace upgrade with modernize to be consistent with similar checks in other module.

Jun 6 2019, 5:28 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62437: [clang-tidy] Splits fuchsia-default-arguments.
Jun 6 2019, 2:37 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2019

Eugene.Zelenko added reviewers for D62829: [clang-tidy] Check for dynamically initialized statics in headers.: alexfh, hokein, aaron.ballman, JonasToth.
Jun 3 2019, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62829: [clang-tidy] Check for dynamically initialized statics in headers..
Jun 3 2019, 5:14 PM · Restricted Project, Restricted Project, Restricted Project

May 31 2019

Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 4:13 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.: aaron.ballman.
May 31 2019, 10:09 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2019

Eugene.Zelenko added inline comments to D62437: [clang-tidy] Splits fuchsia-default-arguments.
May 24 2019, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D62437: [clang-tidy] Splits fuchsia-default-arguments.

Please mention renaming of existing check in Release Notes (after list of new checks).

May 24 2019, 4:45 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62437: [clang-tidy] Splits fuchsia-default-arguments: alexfh, hokein, aaron.ballman, JonasToth.
May 24 2019, 4:45 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming: alexfh, hokein, aaron.ballman, JonasToth.
May 24 2019, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2019

Eugene.Zelenko added a comment to D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.

Please mention alias (in aliases list) in Release Notes.

May 21 2019, 8:48 AM · Restricted Project

May 16 2019

Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 16 2019, 6:23 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.: alexfh, hokein, aaron.ballman, JonasToth.
May 16 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 16 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files: JonasToth.
May 16 2019, 8:00 AM · Restricted Project
Eugene.Zelenko added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Will be good idea to mention new option in the Release Notes.

May 16 2019, 8:00 AM · Restricted Project

May 15 2019

Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 15 2019, 4:07 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.: hokein, aaron.ballman, JonasToth.
May 15 2019, 4:07 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 15 2019, 4:04 PM · Restricted Project, Restricted Project, Restricted Project

May 9 2019

Eugene.Zelenko added reviewers for D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static: hokein, JonasToth.
May 9 2019, 1:14 PM · Restricted Project, Restricted Project, Restricted Project