Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (240 w, 4 d)

Recent Activity

Yesterday

Eugene.Zelenko added inline comments to D72848: Remove some SVN-specific code..
Fri, Jan 17, 10:13 AM · Restricted Project

Thu, Jan 16

Eugene.Zelenko added inline comments to D72848: Remove some SVN-specific code..
Thu, Jan 16, 9:54 AM · Restricted Project
Eugene.Zelenko added a reviewer for D72827: clang-format: [JS] Handle keyword-named methods.: MyDeveloperDay.
Thu, Jan 16, 6:10 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Thu, Jan 16, 6:04 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc.
Thu, Jan 16, 6:04 AM · Restricted Project, Restricted Project

Wed, Jan 15

Eugene.Zelenko removed a reviewer for D72816: [CallGraph] Add invalidate method.: Eugene.Zelenko.
Wed, Jan 15, 5:38 PM · Restricted Project
Eugene.Zelenko removed a reviewer for D72815: [BrachProbablityInfo] Add invalidate method.: Eugene.Zelenko.
Wed, Jan 15, 5:38 PM · Restricted Project
Eugene.Zelenko added a reviewer for D72793: [clang-format] Expand the SpacesAroundConditions option to include catch statements: MyDeveloperDay.
Wed, Jan 15, 11:37 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

By the word, please rebase, because Release Notes were reset after version 10 branching.

Wed, Jan 15, 10:50 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer: JonasToth.
Wed, Jan 15, 3:24 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.
Wed, Jan 15, 3:24 AM · Restricted Project, Restricted Project

Tue, Jan 14

Eugene.Zelenko retitled D72730: [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings from [clang-tools-extra] run-clang-tidy -export-fixes exports only fixes, not all warnings to [clang-tidy] run-clang-tidy -export-fixes exports only fixes, not all warnings.
Tue, Jan 14, 4:34 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Tue, Jan 14, 3:04 PM · Restricted Project, Restricted Project

Mon, Jan 13

Eugene.Zelenko added a comment to D72121: [clang-tidy] Fix readability-identifier-naming missing member variables .

Please also close PRs.

Mon, Jan 13, 11:41 AM · Restricted Project, Restricted Project
Eugene.Zelenko updated the diff for D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes.

Renamed "New aliases" to "New check aliases".

Mon, Jan 13, 10:16 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes.

Both scripts works fine. However rename script should also sort entries alphabetically, but probably this should be separate patch.

Mon, Jan 13, 10:16 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72484: [clang-tidy] Fix check for Abseil internal namespace access.

It is my first time submitting clang-tidy change. So I'm not sure of the procedure exactly. Do we wait for something from me?

Mon, Jan 13, 8:03 AM · Restricted Project, Restricted Project

Sun, Jan 12

Eugene.Zelenko added a comment to D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness.

As an aside, once this is merged in, I dream of a "fix-it" for old style C code:

int foo;

...
/* page of code which does not use either foo or bar */
...
foo = 5;

Moves the foo declaration to the line where it is actually first initialized. Then run the constify tool on top.

Sun, Jan 12, 7:46 AM · Restricted Project, Restricted Project

Sat, Jan 11

Eugene.Zelenko added inline comments to D72553: [clang-tidy] Add performance-prefer-preincrement check.
Sat, Jan 11, 8:19 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.

could this do with an alias into performance?

Sat, Jan 11, 6:56 AM · Restricted Project, Restricted Project

Fri, Jan 10

Eugene.Zelenko added a comment to D72553: [clang-tidy] Add performance-prefer-preincrement check.

It'll be reasonable to submit patches generated by check into trunk. May be after branching release.

Fri, Jan 10, 10:18 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72553: [clang-tidy] Add performance-prefer-preincrement check.
Fri, Jan 10, 10:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
Fri, Jan 10, 6:13 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..
Fri, Jan 10, 3:02 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

Documentation and Release Notes entry are still missing..

Fri, Jan 10, 1:59 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Fri, Jan 10, 1:20 PM · Restricted Project, Restricted Project
Eugene.Zelenko created D72527: [clang-tidy] adjust scripts to subsubsections in Release Notes.
Fri, Jan 10, 11:29 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Fri, Jan 10, 11:09 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Fri, Jan 10, 10:50 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Fri, Jan 10, 10:03 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.

Please describe options in documentation. See other checks documentation as example.

Fri, Jan 10, 7:15 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

Please rebase from trunk. I sorted Clang-tidy entries in Release Notes and aliases have own subsubsection. Please keep alphabetical order there.

Fri, Jan 10, 6:55 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.

Please rebase from trunk. I sorted Clang-tidy entries in Release Notes and aliases have own subsubsection. Please keep alphabetical order there.

Fri, Jan 10, 6:48 AM · Restricted Project, Restricted Project

Thu, Jan 9

Eugene.Zelenko added a comment to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.

It may be reasonable to provide options to expand list of problematic functions. See bugprone-suspicious-string-compare as example.

Thu, Jan 9, 6:49 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72484: [clang-tidy] Fix check for Abseil internal namespace access.

Please mark fixed comments as done.

Thu, Jan 9, 6:44 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72488: [clang-tidy] Add check for CERT-OOP57-CPP.
Thu, Jan 9, 6:40 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D72488: [clang-tidy] Add check for CERT-OOP57-CPP: alexfh, hokein, aaron.ballman, JonasToth.
Thu, Jan 9, 6:35 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72484: [clang-tidy] Fix check for Abseil internal namespace access.

Should be change mentioned in Release Notes?

Thu, Jan 9, 2:56 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D72484: [clang-tidy] Fix check for Abseil internal namespace access from Fix clang-tidy check for Abseil internal namespace access to [clang-tidy] Fix check for Abseil internal namespace access.
Thu, Jan 9, 2:56 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.

It'll be reasonable to mention changes in Release Notes (in checks changes section, in alphabetical order).

Thu, Jan 9, 10:14 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72448: [clang-tidy] readability-redundant-string-init now flags redundant initialisation in Field Decls and Constructor Initialisers.
Thu, Jan 9, 6:56 AM · Restricted Project, Restricted Project
Eugene.Zelenko removed a reviewer for D72441: [CodeGen] Store LiveRegs in SetVector: Eugene.Zelenko.
Thu, Jan 9, 6:37 AM · Restricted Project

Wed, Jan 8

Eugene.Zelenko retitled D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix from Refresh the add_new_check.py now that we use a table + autofix to [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix.
Wed, Jan 8, 4:05 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72217: [clang-tidy] Added readability-qualified-auto check.
Wed, Jan 8, 11:55 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72217: [clang-tidy] Added readability-qualified-auto check.
Wed, Jan 8, 8:18 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72217: [clang-tidy] Added readability-qualified-auto check.
Wed, Jan 8, 7:59 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72217: [clang-tidy] Added readability-qualified-auto check.
Wed, Jan 8, 6:53 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.
Wed, Jan 8, 6:44 AM · Restricted Project, Restricted Project

Tue, Jan 7

Eugene.Zelenko added a parent revision for D72378: [clang-tidy] Add `bugprone-reserved-identifier`: D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming.
Tue, Jan 7, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72378: [clang-tidy] Add `bugprone-reserved-identifier`.
Tue, Jan 7, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a child revision for D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming: D72378: [clang-tidy] Add `bugprone-reserved-identifier`.
Tue, Jan 7, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

By the word, will be interesting to see results of this check run on LLVM code. Probably results should be split on modules.

Tue, Jan 7, 5:32 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef: alexfh, hokein.
Tue, Jan 7, 4:18 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72373: [clang-tidy] extend misc-misplaced-const to detect using besides typedef.
Tue, Jan 7, 4:12 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72362: [clang-tidy] misc-no-recursion: a new check.

It'll be reasonable to add CERT alias.

Tue, Jan 7, 2:35 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D72339: [lld] NFC: fix trivial typos in comments: ruiu.
Tue, Jan 7, 10:05 AM · Restricted Project, lld

Mon, Jan 6

Eugene.Zelenko added inline comments to D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming.
Mon, Jan 6, 2:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72282: [clang-tidy] Add `bugprone-unintended-adl`.
Mon, Jan 6, 11:03 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72282: [clang-tidy] Add `bugprone-unintended-adl`.
Mon, Jan 6, 10:35 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming.
Mon, Jan 6, 10:06 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D72276: [clang-format] Add IndentCaseBlocks option, added: MyDeveloperDay; removed: Restricted Project.
Mon, Jan 6, 8:58 AM · Restricted Project, Restricted Project

Sun, Jan 5

Eugene.Zelenko added a comment to D72239: [clang-tidy] new opencl recursion not supported check.

I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency.

Sun, Jan 5, 10:04 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72241: [clang-tidy] new altera single work item barrier check.

I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency.

Sun, Jan 5, 9:59 PM · Restricted Project, Restricted Project
Eugene.Zelenko set the repository for D72235: [clang-tidy] new altera unroll loops check to rG LLVM Github Monorepo.
Sun, Jan 5, 5:39 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72235: [clang-tidy] new altera unroll loops check.

I think will be good idea to separate module code in own review or refer to previous one of previous reviews as dependency.

Sun, Jan 5, 5:39 PM · Restricted Project, Restricted Project, Restricted Project

Sat, Jan 4

Eugene.Zelenko added inline comments to D72217: [clang-tidy] Added readability-qualified-auto check.
Sat, Jan 4, 10:10 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72218: [clang-tidy] new altera kernel name restriction check.
Sat, Jan 4, 10:10 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72218: [clang-tidy] new altera kernel name restriction check.
Sat, Jan 4, 10:01 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D72217: [clang-tidy] Added readability-qualified-auto check: alexfh, hokein.
Sat, Jan 4, 10:01 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72217: [clang-tidy] Added readability-qualified-auto check.

May be check belong to LLVM module?

Sat, Jan 4, 10:01 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.

@eugene Please don't use auto when type is spelled in same statement or iterator. do you mean type is not spelled ?

Sat, Jan 4, 2:50 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names.
Sat, Jan 4, 1:55 PM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D72213: [clang-tidy] Add `bugprone-reserved-identifier` to flag usages of reserved C++ names, added: hokein, aaron.ballman; removed: alexfh_.
Sat, Jan 4, 1:37 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D72196: [lld] Fix trivial typos in comments: ruiu.
Sat, Jan 4, 7:41 AM · Restricted Project, lld

Fri, Jan 3

Eugene.Zelenko added a reviewer for D72150: Allow space after C-style cast in C# code: MyDeveloperDay.
Fri, Jan 3, 6:49 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D72140: [clang-tools-extra] NFC: Fix trivial typos in comments: aaron.ballman, gribozavr.
Fri, Jan 3, 8:03 AM · Restricted Project

Thu, Jan 2

Eugene.Zelenko added a reviewer for D72091: [docs] NFC: Fix typos in documents: hans.
Thu, Jan 2, 11:53 AM · Restricted Project
Eugene.Zelenko added reviewers for D72087: [clang-tools-extra] NFC: Fix trivial typos in comments: aaron.ballman, gribozavr.
Thu, Jan 2, 10:08 AM · Restricted Project

Sun, Dec 29

Eugene.Zelenko added reviewers for D71982: [docs] Update path to clang-tools-extra: alexfh, aaron.ballman, ilya-biryukov, juliehockett.
Sun, Dec 29, 10:00 PM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D71980: [clang-tidy] Disable Checks on If constexpr statements in template Instantiations for BugproneBranchClone and ReadabilityBracesAroundStatements from Fix ClangTidy Bug - 44229, 33203 and 32204 to [clang-tidy] Fix bug - 44229, 33203 and 32204.
Sun, Dec 29, 4:20 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check.
Sun, Dec 29, 4:10 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71973: [clang-tidy] Add bugprone-suspicious-memory-comparison check.
Sun, Dec 29, 2:31 PM · Restricted Project, Restricted Project

Mon, Dec 23

Eugene.Zelenko retitled D71846: [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364 from Fix for https://bugs.llvm.org/show_bug.cgi?id=44364 to [ASTMatchers] Fix for https://bugs.llvm.org/show_bug.cgi?id=44364.
Mon, Dec 23, 6:40 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D70876: [clang-tidy] Add spuriously-wake-up-functions check.
Mon, Dec 23, 2:51 PM · Restricted Project, Restricted Project

Fri, Dec 20

Eugene.Zelenko added inline comments to D36051: Move from a long list of checkers to tables.
Fri, Dec 20, 9:59 AM · Restricted Project
Eugene.Zelenko added a comment to D36051: Move from a long list of checkers to tables.

May be also split table by checks groups?

Fri, Dec 20, 6:38 AM · Restricted Project

Thu, Dec 19

Eugene.Zelenko added inline comments to D71707: clang-tidy: new bugprone-pointer-cast-widening.
Thu, Dec 19, 1:32 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D71707: clang-tidy: new bugprone-pointer-cast-widening.

Please add documentation and mention new check in Release Notes.

Thu, Dec 19, 9:13 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D71707: clang-tidy: new bugprone-pointer-cast-widening, added: hokein, aaron.ballman; removed: labath.
Thu, Dec 19, 9:13 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D71686: Fix false positive in magic number checker, added: hokein; removed: Eugene.Zelenko.
Thu, Dec 19, 7:13 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D71686: Fix false positive in magic number checker.

Please mention fix in Release Notes.

Thu, Dec 19, 7:13 AM · Restricted Project, Restricted Project

Dec 18 2019

Eugene.Zelenko added a comment to D71594: testing clang-tidy.

Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set of custom rules be used?

Yes, clang-tidy uses the .clang-tidy. Do you want to enable additional rules for a subproject?

Dec 18 2019, 6:57 AM · Restricted Project, Restricted Project

Dec 17 2019

Eugene.Zelenko added a comment to D71594: testing clang-tidy.

Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set of custom rules be used?

Dec 17 2019, 9:55 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.: alexfh, hokein, aaron.ballman.
Dec 17 2019, 6:58 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals..

Please add documentation and mention new check in Release Notes.

Dec 17 2019, 6:58 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D71594: testing clang-tidy: alexfh, hokein, aaron.ballman.
Dec 17 2019, 6:58 AM · Restricted Project, Restricted Project

Dec 12 2019

Eugene.Zelenko added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

This check is to enforce C++ core guideline C.49 while the modernize check enforces guideline C.48. The two must be synchronized, and I think that this new check should do that: for initializations that should be done using in-class initializers according to the other checker this checker must suggest the same. For the rest we should suggest member initializers in the constructor.

Dec 12 2019, 6:38 AM · Restricted Project, Restricted Project

Dec 9 2019

Eugene.Zelenko added a reviewer for D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer: hokein.
Dec 9 2019, 6:50 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D71199: [clang-tidy] New check cppcoreguidelines-prefer-member-initializer.

Clang-tidy also has modernize-use-default-member-init. Will be good idea to mention this check in documentation and otherwise as well as draw distinction (C++ version, coding guidelines, etc) in use cases.

Dec 9 2019, 6:50 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D71174: [clang-tidy] new check: bugprone-signed-char-misuse.
Dec 9 2019, 6:41 AM · Restricted Project, Restricted Project