Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (206 w, 17 h)

Recent Activity

Thu, May 16

Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
Thu, May 16, 6:23 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.: alexfh, hokein, aaron.ballman, JonasToth.
Thu, May 16, 6:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
Thu, May 16, 6:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files: JonasToth.
Thu, May 16, 8:00 AM · Restricted Project
Eugene.Zelenko added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Will be good idea to mention new option in the Release Notes.

Thu, May 16, 8:00 AM · Restricted Project

Wed, May 15

Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
Wed, May 15, 4:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.: hokein, aaron.ballman, JonasToth.
Wed, May 15, 4:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
Wed, May 15, 4:04 PM · Restricted Project, Restricted Project

Thu, May 9

Eugene.Zelenko added reviewers for D61749: [clang-tidy] initial version of readability-static-const-method: hokein, JonasToth.
Thu, May 9, 1:14 PM · Restricted Project, Restricted Project
Eugene.Zelenko updated subscribers of D61749: [clang-tidy] initial version of readability-static-const-method.

@JonasToth tried to implement const check, so probably const and static part should be split. It's hard to tell about state of existing implementation, but you could continue it or at least borrow ideas and tests.

Thu, May 9, 1:13 PM · Restricted Project, Restricted Project

Fri, May 3

Eugene.Zelenko added reviewers for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard: hokein, aaron.ballman, JonasToth.
Fri, May 3, 8:49 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.
Fri, May 3, 8:49 AM · Restricted Project, Restricted Project

Wed, May 1

Eugene.Zelenko added inline comments to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
Wed, May 1, 4:55 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..
Wed, May 1, 10:52 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.: alexfh, hokein, JonasToth.
Wed, May 1, 10:12 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..
Wed, May 1, 10:10 AM · Restricted Project, Restricted Project

Tue, Apr 30

Eugene.Zelenko retitled D61350: [clang-tidy] New check calling out uses of +new in Objective-C code from New clang-tidy check calling out uses of +new in Objective-C code to [clang-tidy] New check calling out uses of +new in Objective-C code.
Tue, Apr 30, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code: alexfh, aaron.ballman, JonasToth.
Tue, Apr 30, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
Tue, Apr 30, 6:09 PM · Restricted Project, Restricted Project

Fri, Apr 26

Eugene.Zelenko added inline comments to D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.
Fri, Apr 26, 5:00 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL: JonasToth, hokein.
Fri, Apr 26, 2:06 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.
Fri, Apr 26, 2:06 PM · Restricted Project, Restricted Project

Mon, Apr 22

Eugene.Zelenko added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Mon, Apr 22, 3:51 PM · Restricted Project, Restricted Project

Apr 16 2019

Eugene.Zelenko added inline comments to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).
Apr 16 2019, 10:12 AM · Restricted Project, Restricted Project

Apr 12 2019

Eugene.Zelenko added a reviewer for D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check': hokein.
Apr 12 2019, 1:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'.

Please use check for consistency with rest of Clang-tidy.

Apr 12 2019, 1:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 12 2019, 11:28 AM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2019

Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Apr 10 2019, 6:15 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Apr 10 2019, 4:17 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Apr 10 2019, 1:46 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 10 2019, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2019

Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 9 2019, 11:45 AM · Restricted Project, Restricted Project

Apr 4 2019

Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 4 2019, 9:44 AM · Restricted Project, Restricted Project

Apr 3 2019

Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 3 2019, 7:06 AM · Restricted Project, Restricted Project

Apr 2 2019

Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Apr 2 2019, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 2 2019, 11:18 AM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check from Add clang-tidy/checks/misc-placement-new-target-size check to [clang-tidy] Add misc-placement-new-target-size check.
Apr 2 2019, 11:12 AM · Restricted Project, Restricted Project

Apr 1 2019

Eugene.Zelenko added a comment to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.

Do we have any checker to recommend llvm functions over std ?

e.g. llvm::sort, llvm::all_of, ...

Apr 1 2019, 11:10 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2019

Eugene.Zelenko added a comment to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 28 2019, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 28 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko retitled D59963: [clang-tidy] Add a module for the Linux kernel. from Add a clang-tidy module for the Linux kernel. to [clang-tidy] Add module for the Linux kernel..
Mar 28 2019, 3:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D59963: [clang-tidy] Add a module for the Linux kernel..

I think linuxkernel name will be less ambiguous.

Mar 28 2019, 3:20 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

I know that code-checker and code-compass have something like this to signal importance of problems (say bugprone and cert differ from readability for example).

Mar 28 2019, 11:59 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59930: Parallel STL version updated.
Mar 28 2019, 11:39 AM
Eugene.Zelenko added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Mar 28 2019, 11:39 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited projects for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks., added: Restricted Project; removed Restricted Project.
Mar 28 2019, 8:47 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Mar 28 2019, 8:47 AM · Restricted Project, Restricted Project

Mar 27 2019

Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Mar 27 2019, 5:05 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Mar 27 2019, 10:03 AM · Restricted Project
Eugene.Zelenko added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Mar 27 2019, 9:46 AM · Restricted Project
Eugene.Zelenko edited projects for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable, added: Restricted Project; removed Restricted Project.
Mar 27 2019, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Mar 27 2019, 8:06 AM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2019

Eugene.Zelenko added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.
Mar 26 2019, 1:02 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 26 2019, 11:50 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.
Mar 26 2019, 9:28 AM · Restricted Project, Restricted Project

Mar 25 2019

Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 25 2019, 6:20 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals: hokein, aaron.ballman, JonasToth.
Mar 25 2019, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 25 2019, 3:23 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2019

Eugene.Zelenko added inline comments to D59639: [clangd] Print template arguments helper.
Mar 22 2019, 6:49 AM · Restricted Project, Restricted Project

Mar 21 2019

Eugene.Zelenko added inline comments to D59639: [clangd] Print template arguments helper.
Mar 21 2019, 8:38 AM · Restricted Project, Restricted Project

Mar 20 2019

Eugene.Zelenko added inline comments to D59605: [clangd] Introduce background-indexer.
Mar 20 2019, 10:57 AM · Restricted Project
Eugene.Zelenko added inline comments to D59599: [clangd] Fix a crash while printing Template Arguments.
Mar 20 2019, 10:47 AM · Restricted Project
Eugene.Zelenko added inline comments to D59605: [clangd] Introduce background-indexer.
Mar 20 2019, 10:47 AM · Restricted Project

Mar 19 2019

Eugene.Zelenko added inline comments to D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture.
Mar 19 2019, 9:43 AM · Restricted Project

Mar 7 2019

Eugene.Zelenko added inline comments to D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator.
Mar 7 2019, 12:38 PM · Restricted Project, Restricted Project
Eugene.Zelenko removed a project from D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator: Restricted Project.
Mar 7 2019, 12:35 PM · Restricted Project, Restricted Project

Mar 6 2019

Eugene.Zelenko added reviewers for D58977: [clang-tidy] Add the abseil-time-comparison check: aaron.ballman, alexfh.
Mar 6 2019, 8:10 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D58977: [clang-tidy] Add the abseil-time-comparison check.
Mar 6 2019, 8:09 AM · Restricted Project, Restricted Project

Mar 2 2019

Eugene.Zelenko added inline comments to D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check.
Mar 2 2019, 1:44 PM · Restricted Project

Feb 27 2019

Eugene.Zelenko added inline comments to D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions.
Feb 27 2019, 3:54 PM · Restricted Project, Restricted Project, Restricted Project

Feb 25 2019

Eugene.Zelenko added reviewers for D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.: hokein, aaron.ballman, JonasToth.
Feb 25 2019, 2:25 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower: hokein, aaron.ballman, JonasToth.
Feb 25 2019, 4:46 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D58606: [clang-tidy] misc-string-integer-assignment: fix false positive: hokein, aaron.ballman, JonasToth.
Feb 25 2019, 4:46 AM · Restricted Project, Restricted Project, Restricted Project

Feb 21 2019

Eugene.Zelenko added inline comments to D58478: [index-while-building] FileIndexRecord.
Feb 21 2019, 1:22 PM · Restricted Project

Feb 20 2019

Eugene.Zelenko added inline comments to D58478: [index-while-building] FileIndexRecord.
Feb 20 2019, 4:26 PM · Restricted Project

Feb 16 2019

Eugene.Zelenko added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 16 2019, 8:50 AM · Restricted Project, Restricted Project

Feb 12 2019

Eugene.Zelenko added inline comments to D58162: [hwasan] Runtime flags for malloc bisection..
Feb 12 2019, 6:31 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 12 2019, 11:54 AM · Restricted Project, Restricted Project

Feb 11 2019

Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 11 2019, 2:40 PM · Restricted Project
Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 11 2019, 7:55 AM · Restricted Project

Feb 10 2019

Eugene.Zelenko removed a reviewer for D58016: fixes copy constructor generation of classes containing 0-length arrays followed by exactly 1 trivial field (fixes #40682): Eugene.Zelenko.
Feb 10 2019, 1:10 PM · Restricted Project

Feb 9 2019

Eugene.Zelenko added a comment to D33841: [clang-tidy] redundant keyword check.

Please mention new check in Release Notes.

Feb 9 2019, 1:32 PM · Restricted Project

Feb 8 2019

Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 8 2019, 7:18 PM · Restricted Project
Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 8 2019, 6:51 PM · Restricted Project
Eugene.Zelenko added inline comments to D57990: Use std::make_shared in LLDB (NFC).
Feb 8 2019, 5:54 PM · Restricted Project
Eugene.Zelenko added inline comments to D57966: [clang-tidy] add camelBackOrCase casing style to readability-identifier-naming to support change to variable naming policy (if adopted).
Feb 8 2019, 1:49 PM · Restricted Project, Restricted Project

Feb 7 2019

Eugene.Zelenko set the repository for D55725: [OpenMP] Add libs to clang-dedicated directories to rOMP OpenMP.
Feb 7 2019, 10:09 AM · Restricted Project

Feb 5 2019

Eugene.Zelenko added a comment to D57757: [scudo][standalone] Do not error out on spurious C(XX) flags.

May be removing -stdlib is better solution since it contradict with -nostdinc++?

Feb 5 2019, 11:01 AM · Restricted Project, Restricted Project

Feb 4 2019

Eugene.Zelenko added a comment to D57412: [scudo] Initial standalone skeleton check-in.

Build with -DLLVM_ENABLE_LIBCXX=ON is broken because:

Feb 4 2019, 6:35 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D57674: [clang-tidy] Add options to bugprone-argument-comment to add missing argument comments to literals.
Feb 4 2019, 11:35 AM · Restricted Project, Restricted Project, Restricted Project

Feb 1 2019

Herald added a project to D35937: [clang-tidy] Add new readability non-idiomatic static access: Restricted Project.

Please look at recently filed PR40544.

Feb 1 2019, 11:03 AM · Restricted Project, Restricted Project

Jan 30 2019

Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Jan 30 2019, 6:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D57457: [docs][mips] 8.0 Release notes.
Jan 30 2019, 1:11 PM
Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Jan 30 2019, 11:06 AM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D57435: [clang-tidy] Add abseil-wrap-unique check from [clang-tidy] created wrap-unique check to [clang-tidy] Add abseil-wrap-unique check.
Jan 30 2019, 11:02 AM · Restricted Project, Restricted Project

Jan 29 2019

Eugene.Zelenko added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 29 2019, 11:40 AM · Restricted Project, Restricted Project

Jan 28 2019

Eugene.Zelenko added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 28 2019, 1:27 PM · Restricted Project, Restricted Project

Jan 26 2019

Eugene.Zelenko added a comment to D57113: [clang-tidy] openmp-use-default-none - a new check.

New module is still not mentioned in docs/clang-tidy/index.rst.

Jan 26 2019, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2019

Eugene.Zelenko added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 24 2019, 1:45 PM · Restricted Project
Eugene.Zelenko added a comment to D55523: [clang-tidy] Linting .rst documentation.

A few questions:

  1. why do we want to lint just clang-tidy docs and not all LLVM's .rst files?
Jan 24 2019, 10:20 AM · Restricted Project