- User Since
- Jun 8 2015, 2:10 PM (166 w, 2 d)
Mon, Aug 13
You could use Differential revision: <review URL> in commit description to close review automatically.
Fri, Aug 10
Check documentation is missing.
Thu, Aug 9
Why not to use dependencies instead of deps in check's name?
Tue, Aug 7
Sat, Aug 4
Mon, Jul 30
Fri, Jul 27
Thu, Jul 26
Tue, Jul 24
Tue, Jul 17
Adding C++ Core Guidelines alias is definitely low-hanging fruit which could be implemented within this patch.
But you could also take a look at the enforcement of some coding
guidelines (my personal todolists:
https://github.com/JonasToth/HighIntegrityTooling). There are always low
hanging fruit checks. Implementing something there helps getting used to
the codebase of clang, too.
Jul 14 2018
Jul 11 2018
C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic constants, so I think check should be moved into cppcoreguidelines module.
Jul 10 2018
It's highly likely that this part of coding guidelines.
Jul 3 2018
bugprone seems to be proper category for this check.
Jun 20 2018
May 23 2018
May 21 2018
The warning is off by default.
We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default?
Right. I believe this is going to be used in practice, the reason I'm adding it involves some user demand for such warning. Such quoted include use in frameworks happen often and we would like a smooth transition to happen here (e.g. do not initially affect -Werror users). If it proves worth it, we can migrate to on by default in the future. It wouldn't be a problem if we have it on by default on open source and disable by default downstream, but I rather be consistent.
See also PR22165.
May 8 2018
I think will be good idea to store data in JSON format too.
May 6 2018
May 3 2018
Will be good idea to add documentation and item in Release Notes.
I don't see anything wrong with this change, but will be good idea to wait for code owner approval.
May 2 2018
May 1 2018
Apr 30 2018
Apr 22 2018
Apr 20 2018
Apr 19 2018
Apr 18 2018
Apr 17 2018
Apr 16 2018
Please also take a look on 26817 for another idea for .data().
Apr 15 2018
See also D45444.
Apr 12 2018
There is Clang-tidy's readability-implicit-bool-conversion check.
Apr 10 2018
How about doing same for objc-property-declaration?
Apr 9 2018
Will be good idea to add HICPP alias.
It'll be good idea to have option to apply this check for pointer/references only, or include built-in types/enums.
Apr 8 2018
Apr 7 2018
Apr 6 2018
If this is Apple guideline, check name should reflect this. I think will be good idea to have general check for Apple naming conventions instead of separate checks for specific situations like objc-ivar-declaration and objc-property-declaration.
Apr 4 2018
I found /usr/lib/libpfm.so.3.10.0
Looks like CMake is not checking for external dependencies properly. I got build error on RHEL 6 because of missing perfmon/perf_event.h. Most likely perfmon version is too old on RHEL6.
Mar 31 2018
Mar 29 2018
Will be good idea to clarify where TEMP_FAILURE_RETRY come from.
Mar 28 2018
Mar 27 2018
Please mention new diagnostics in documentation and Release Notes.
Mar 26 2018
Please mention new tool in Release Notes and use :doc: to refer to its manual.
I think it's fine to commit trivial fixes without going via review.
Mar 23 2018
Please also mention new warning in Release Notes and documentation.
This duplicates Clang-tidy misc-unused-using-decls. If Clang will provide same or better functionality, it should be removed.