- User Since
- Jun 8 2015, 2:10 PM (175 w, 4 d)
Wed, Oct 17
Will be good idea to mention improvements in Release Notes.
Tue, Oct 16
By the word, why this check could not be generalized to any function/method which have floating-point and integer variants?
Fri, Oct 12
Thu, Oct 11
Tue, Oct 9
GCC has -Wignored-qualifiers for long time, so may be better to implement it in Clang?
Mon, Oct 8
Sun, Oct 7
Fri, Oct 5
Thu, Oct 4
It'll be good idea to handle climits constants too.
I think modernize is better module for this check.
Tue, Oct 2
Fri, Sep 28
May be we should also create MISRA module?
How about creating CERT alias?
Thu, Sep 27
Wed, Sep 26
Thu, Sep 20
Wed, Sep 19
Looks like you patch is not based on trunk. Please rebase.
Sep 15 2018
Sep 11 2018
I would suggest to use declaration or declarations in check name instead of abbreviation.
Sep 7 2018
Sep 2 2018
Aug 28 2018
I still thik will be good idea to rename check (deps -> dependencies).
Aug 24 2018
Indentation of example in documentation is still fixed.
Example in documentation was not fixed.
Aug 23 2018
Aug 22 2018
Is it possible to implement fix-it?
Aug 21 2018
Please rebase from trunk.
Aug 19 2018
Aug 17 2018
Somehow documentation file was not committed.
Aug 16 2018
Aug 13 2018
You could use Differential revision: <review URL> in commit description to close review automatically.
Aug 10 2018
Check documentation is missing.
Aug 9 2018
Why not to use dependencies instead of deps in check's name?
Aug 7 2018
Aug 4 2018
Jul 30 2018
Jul 27 2018
Jul 26 2018
Jul 24 2018
Jul 17 2018
Adding C++ Core Guidelines alias is definitely low-hanging fruit which could be implemented within this patch.
But you could also take a look at the enforcement of some coding
guidelines (my personal todolists:
https://github.com/JonasToth/HighIntegrityTooling). There are always low
hanging fruit checks. Implementing something there helps getting used to
the codebase of clang, too.
Jul 14 2018
Jul 11 2018
C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic constants, so I think check should be moved into cppcoreguidelines module.
Jul 10 2018
It's highly likely that this part of coding guidelines.
Jul 3 2018
bugprone seems to be proper category for this check.
Jun 20 2018
May 23 2018
May 21 2018
The warning is off by default.
We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default?
Right. I believe this is going to be used in practice, the reason I'm adding it involves some user demand for such warning. Such quoted include use in frameworks happen often and we would like a smooth transition to happen here (e.g. do not initially affect -Werror users). If it proves worth it, we can migrate to on by default in the future. It wouldn't be a problem if we have it on by default on open source and disable by default downstream, but I rather be consistent.
See also PR22165.
May 8 2018
I think will be good idea to store data in JSON format too.
May 6 2018
May 3 2018
Will be good idea to add documentation and item in Release Notes.
I don't see anything wrong with this change, but will be good idea to wait for code owner approval.