Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (363 w, 4 d)

Recent Activity

Mon, May 23

Eugene.Zelenko edited reviewers for D126247: `readability-indentifier-naming` resolution order and examples, added: alexfh, aaron.ballman, njames93, LegalizeAdulthood; removed: Restricted Project.
Mon, May 23, 3:39 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D126247: `readability-indentifier-naming` resolution order and examples.
Mon, May 23, 3:38 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D126186: [clang-tidy] Extend cert-oop57-cpp to check non-zero memset values.
Mon, May 23, 7:30 AM · Restricted Project, Restricted Project

Sat, May 21

Eugene.Zelenko added reviewers for D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04): alexfh, aaron.ballman, njames93, LegalizeAdulthood.
Sat, May 21, 9:48 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy: njames93, LegalizeAdulthood.
Sat, May 21, 7:30 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D126097: [clang-tidy] Adds the NSDateFormatter checker to clang-tidy.
Sat, May 21, 7:29 AM · Restricted Project, Restricted Project

Fri, May 20

Eugene.Zelenko added reviewers for D126034: [clang-tidy] bugfix in InfiniteLoopCheck to not print warnings for unevaluated loops: njames93, LegalizeAdulthood.
Fri, May 20, 7:30 AM · Restricted Project, Restricted Project, Restricted Project

Wed, May 18

Eugene.Zelenko retitled D125885: [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals from bugprone-argument-comment: Ignore calls to user-defined literals to [clang-tidy] bugprone-argument-comment: Ignore calls to user-defined literals.
Wed, May 18, 7:10 AM · Restricted Project, Restricted Project

Wed, May 4

Eugene.Zelenko added inline comments to D124918: [clang-tidy] Add a new check for non-trivial unused variables..
Wed, May 4, 8:07 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D124918: [clang-tidy] Add a new check for non-trivial unused variables..
Wed, May 4, 7:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D124918: [clang-tidy] Add a new check for non-trivial unused variables. from Add a new clang-tidy for non-trivial unused variables. to [clang-tidy] Add a new check for non-trivial unused variables..
Wed, May 4, 7:14 AM · Restricted Project, Restricted Project

Fri, Apr 29

Eugene.Zelenko added inline comments to D124650: [clang-tidy] Simplify boolean expressions by DeMorgan's theorem.
Fri, Apr 29, 7:22 AM · Restricted Project, Restricted Project

Apr 13 2022

Eugene.Zelenko added inline comments to D123655: [clang-tidy] Add portability-std-allocator-const check.
Apr 13 2022, 11:59 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D123655: [clang-tidy] Add portability-std-allocator-const check.

Shouldn't this check be enabled only when libstdc++ is used?

Apr 13 2022, 7:32 AM · Restricted Project, Restricted Project

Mar 27 2022

Eugene.Zelenko added reviewers for D122544: Utilize comparison operation implemented in APInt: alexfh, aaron.ballman, LegalizeAdulthood.
Mar 27 2022, 8:00 AM · Restricted Project, Restricted Project

Mar 20 2022

Eugene.Zelenko edited reviewers for D122111: [clang-tidy] Fix false positives in `misc-redundant-expression` check, added: njames93, LegalizeAdulthood; removed: pavelkryukov.
Mar 20 2022, 9:50 PM · Restricted Project, Restricted Project

Mar 8 2022

Eugene.Zelenko added reviewers for D121214: [clang-tidy][docs][NFC] Refer to the CERT rule in bugprone-shared-ptr-array-mismatch docs: njames93, LegalizeAdulthood.
Mar 8 2022, 7:28 AM · Restricted Project, Restricted Project

Mar 5 2022

Eugene.Zelenko added inline comments to D121019: [clang-tools-extra] Document clang tidy unit tests target.
Mar 5 2022, 7:22 AM · Restricted Project, Restricted Project

Feb 24 2022

Eugene.Zelenko added a reviewer for D120470: [clang-tidy] Update tests to include opencl-c-base.h: aaron.ballman.
Feb 24 2022, 7:28 AM · Restricted Project

Feb 23 2022

Eugene.Zelenko added a comment to D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file.

About procedure :-) You could not approve patches yourself, this is task for reviewers. If content of this patch will be merged to another one, just abandon this one.

Feb 23 2022, 7:35 AM · Restricted Project

Feb 22 2022

Eugene.Zelenko added a comment to D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file.

I think will be good to merge these changes to D120331.

Feb 22 2022, 9:48 PM · Restricted Project
Eugene.Zelenko added reviewers for D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file: alexfh, aaron.ballman, njames93, LegalizeAdulthood.
Feb 22 2022, 9:47 PM · Restricted Project
Eugene.Zelenko added inline comments to D120385: [clang-tidy][run-clang-tidy.py] Mutual exclusion of -config and -config-file.
Feb 22 2022, 9:47 PM · Restricted Project
Eugene.Zelenko added reviewers for D120331: [clang-tidy][run-clang-tidy.py] Add --config-file=<string> option: alexfh, aaron.ballman, njames93, LegalizeAdulthood.
Feb 22 2022, 9:41 AM · Restricted Project, Restricted Project

Feb 19 2022

Eugene.Zelenko added reviewers for D120187: [clang-tidy] Allow newline characters as separators for checks in Clang-Tidy configurations: aaron.ballman, njames93, LegalizeAdulthood.
Feb 19 2022, 7:55 AM · Restricted Project, Restricted Project

Feb 16 2022

Eugene.Zelenko added reviewers for D119949: [Clang-tidy] Check the existence of ElaboratedType's qualifiers: njames93, LegalizeAdulthood.
Feb 16 2022, 9:46 AM · Restricted Project

Feb 15 2022

Eugene.Zelenko removed a reviewer for D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`: Eugene.Zelenko.
Feb 15 2022, 8:29 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2022

Eugene.Zelenko removed a reviewer for D119804: [docs] HowToCrossCompileLLVM.rst: update cmake options: Eugene.Zelenko.
Feb 14 2022, 7:10 PM · Restricted Project

Feb 11 2022

Eugene.Zelenko added inline comments to D119562: [clang-tidy] Provide fine control of color in run-clang-tidy.
Feb 11 2022, 10:37 AM · Restricted Project
Eugene.Zelenko added inline comments to D119562: [clang-tidy] Provide fine control of color in run-clang-tidy.
Feb 11 2022, 10:24 AM · Restricted Project

Feb 10 2022

Eugene.Zelenko added reviewers for D119481: run-clang-tidy: Fix infinite loop on windows: aaron.ballman, LegalizeAdulthood, njames93.
Feb 10 2022, 3:43 PM · Restricted Project, Restricted Project

Feb 7 2022

Eugene.Zelenko added reviewers for D119165: [clang-tidy] Add processing lambda captures at bugprone-use-after-move check: njames93, LegalizeAdulthood.
Feb 7 2022, 12:26 PM · Restricted Project

Feb 6 2022

Eugene.Zelenko added a reviewer for D119098: [clang-tidy] Ignore variable template partial specializations in `misc-definitions-in-headers`: aaron.ballman.
Feb 6 2022, 6:15 PM · Restricted Project

Feb 1 2022

Eugene.Zelenko added reviewers for D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check: aaron.ballman, njames93.
Feb 1 2022, 6:02 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check.
Feb 1 2022, 6:02 PM · Restricted Project, Restricted Project

Jan 31 2022

Eugene.Zelenko added a comment to D118520: [clang-tidy] Output currently processing check and nodes on crash.

Sure, this is important improvement.

Jan 31 2022, 7:25 AM · Restricted Project

Jan 28 2022

Eugene.Zelenko added inline comments to D118520: [clang-tidy] Output currently processing check and nodes on crash.
Jan 28 2022, 6:16 PM · Restricted Project

Jan 25 2022

Eugene.Zelenko added reviewers for D118104: Make run-clang-tidy.py print the configured checks correctly: aaron.ballman, njames93, LegalizeAdulthood.
Jan 25 2022, 7:29 AM · Restricted Project

Jan 24 2022

Eugene.Zelenko edited reviewers for D118016: [clang-tidy] Change code of SignalHandlerCheck (NFC)., added: njames93, LegalizeAdulthood; removed: Eugene.Zelenko.
Jan 24 2022, 7:05 AM · Restricted Project

Jan 23 2022

Eugene.Zelenko added reviewers for D118010: [clang-tidy] Fix nested namespaces in `readability-static-definition-in-anonymous-namespace` check: aaron.ballman, njames93, LegalizeAdulthood.
Jan 23 2022, 6:01 PM · Restricted Project

Jan 22 2022

Eugene.Zelenko added inline comments to D117939: [clang-tidy] Add more documentation about check development.
Jan 22 2022, 9:05 PM · Restricted Project
Eugene.Zelenko added inline comments to D117939: [clang-tidy] Add more documentation about check development.
Jan 22 2022, 5:58 PM · Restricted Project

Jan 21 2022

Eugene.Zelenko added a comment to D117939: [clang-tidy] Add more documentation about check development.

It's also make sense to mention isLanguageVersionSupported.

Jan 21 2022, 9:47 PM · Restricted Project
Eugene.Zelenko added reviewers for D56644: [clang-tidy] readability-container-size-empty handle std::string length(): njames93, LegalizeAdulthood.
Jan 21 2022, 10:40 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D56644: [clang-tidy] readability-container-size-empty handle std::string length().

It'll be great to finalize patch and close issue #37603.

Jan 21 2022, 10:39 AM · Restricted Project, Restricted Project

Jan 17 2022

Eugene.Zelenko added inline comments to D117522: [clang-tidy] Add modernize-macro-to-enum check.
Jan 17 2022, 5:38 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index: njames93, LegalizeAdulthood.
Jan 17 2022, 7:31 AM · Restricted Project

Jan 14 2022

Eugene.Zelenko added reviewers for D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'.: aaron.ballman, njames93, LegalizeAdulthood.
Jan 14 2022, 7:17 AM · Restricted Project
Eugene.Zelenko added a comment to D117306: [clang-tidy] Add new check 'shared-ptr-array-mismatch'..

I think this check belongs to bugprone module. How about std::unique_ptr?

Jan 14 2022, 7:16 AM · Restricted Project

Jan 13 2022

Eugene.Zelenko added inline comments to D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index.
Jan 13 2022, 7:37 AM · Restricted Project
Eugene.Zelenko added inline comments to D117205: [clang-tidy] Support custom fix hint for cppcoreguidelines-pro-bounds-constant-array-index.
Jan 13 2022, 7:26 AM · Restricted Project

Jan 12 2022

Eugene.Zelenko retitled D117090: [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue from Fix `readability-non-const-parameter` for parameter referenced by an lvalue to [clang-tidy] Fix `readability-non-const-parameter` for parameter referenced by an lvalue.
Jan 12 2022, 2:44 PM · Restricted Project
Eugene.Zelenko added reviewers for D117129: [clang-tidy] Extract Class IncluderClangTidyCheck: aaron.ballman, njames93.
Jan 12 2022, 2:43 PM · Restricted Project

Jan 10 2022

Eugene.Zelenko added a reviewer for D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check: njames93.
Jan 10 2022, 6:55 AM · Restricted Project

Jan 9 2022

Eugene.Zelenko added inline comments to D116875: [clang-tidy] Add performance-inefficient-array-traversal check.
Jan 9 2022, 6:39 AM · Restricted Project

Jan 8 2022

Eugene.Zelenko added inline comments to D116875: [clang-tidy] Add performance-inefficient-array-traversal check.
Jan 8 2022, 9:43 PM · Restricted Project

Jan 5 2022

Eugene.Zelenko retitled D116658: [clang-format][NFC] Fix typo in comment from [clang-format] Fix typo in comment to [clang-format][NFC] Fix typo in comment.
Jan 5 2022, 7:08 AM · Restricted Project, Restricted Project

Jan 4 2022

Eugene.Zelenko added reviewers for D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check: aaron.ballman, LegalizeAdulthood.
Jan 4 2022, 7:26 AM · Restricted Project
Eugene.Zelenko added inline comments to D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check.
Jan 4 2022, 7:26 AM · Restricted Project

Jan 3 2022

Eugene.Zelenko added a reviewer for D116550: [clang-tidy] Recognize transformer checks as providing fixits: aaron.ballman.
Jan 3 2022, 3:37 PM · Restricted Project

Jan 2 2022

Eugene.Zelenko edited reviewers for D116512: [clang-tidy] Limit non-Strict mode to public functions, added: aaron.ballman; removed: Eugene.Zelenko.
Jan 2 2022, 6:55 PM · Restricted Project
Eugene.Zelenko edited reviewers for D116513: [clang-tidy] Fix bugs in misc-unused-parameters for Constructors calls site, added: aaron.ballman; removed: Eugene.Zelenko.
Jan 2 2022, 6:54 PM · Restricted Project
Eugene.Zelenko added inline comments to D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects.
Jan 2 2022, 2:27 PM · Restricted Project
Eugene.Zelenko added a comment to D7982: [clang-tidy] Add readability-duplicate-include check.

Functionality-wise this check is superseded by Include What You Use.

Jan 2 2022, 9:00 AM · Restricted Project
Eugene.Zelenko added inline comments to D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects.
Jan 2 2022, 6:25 AM · Restricted Project

Jan 1 2022

Eugene.Zelenko added a comment to D116478: [clang-tidy] A semicolon-separated list of the names of functions or methods to be considered as not having side-effects.

Please mention new option in Release Notes (in changes in existing checks section).

Jan 1 2022, 6:22 PM · Restricted Project

Dec 31 2021

Eugene.Zelenko retitled D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function. from Fix `readability-const-return-type` for pure virtual function. to [clang-tidy] Fix `readability-const-return-type` for pure virtual function..
Dec 31 2021, 7:26 AM · Restricted Project

Dec 30 2021

Eugene.Zelenko added a reviewer for D116425: [clang-tidy] Improve modernize-redundant-void-arg to recognize macro uses: aaron.ballman.
Dec 30 2021, 7:21 PM · Restricted Project
Eugene.Zelenko added a comment to D116359: Demo fix for readability-redundant-control-flow (WIP).

By the word, I run this check over entire LLVM code base (but only X86 architecture) and there were only 8 detected occurrences. It make sense to fix them across entire code base and enable check on top level .clang-tidy.

Dec 30 2021, 4:01 PM · Restricted Project

Dec 29 2021

Eugene.Zelenko added a reviewer for D116386: [clang-tidy] Narrow cppguidelines-macro-usage to actual constants: aaron.ballman.
Dec 29 2021, 9:28 PM · Restricted Project
Eugene.Zelenko added a comment to D116356: Demo fix for modernize-use-override (WIP).

Sorry for being unclear. I mean checks applied in D116355, D116359, etc.

Dec 29 2021, 3:18 PM · Restricted Project
Eugene.Zelenko added a comment to D116356: Demo fix for modernize-use-override (WIP).
Dec 29 2021, 2:31 PM · Restricted Project
Eugene.Zelenko added a comment to D116356: Demo fix for modernize-use-override (WIP).

By the word, since Clang-tidy issue was fixed at least in this part of LLVM code base, it's reasonable to enable this check in local .clang-tidy, so it'll be enforced automatically for those who run the tool.

Dec 29 2021, 8:35 AM · Restricted Project

Dec 5 2021

Eugene.Zelenko added a reviewer for D115124: [clang-tidy] Fix `readability-container-size-empty` check for smart pointers: aaron.ballman.
Dec 5 2021, 9:51 PM · Restricted Project, Restricted Project

Nov 25 2021

Eugene.Zelenko added inline comments to D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new.
Nov 25 2021, 9:04 AM · Restricted Project

Nov 19 2021

Eugene.Zelenko added a reviewer for D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs: aaron.ballman.
Nov 19 2021, 9:58 PM · Restricted Project, Restricted Project
Eugene.Zelenko edited reviewers for D114299: [clang-tidy] Fix `readability-redundant-declaration` false positive for template friend declaration, added: aaron.ballman; removed: Eugene.Zelenko.
Nov 19 2021, 4:42 PM · Restricted Project

Nov 15 2021

Eugene.Zelenko added a reviewer for D113946: [libc][clang-tidy] fix namespace check for externals: aaron.ballman.
Nov 15 2021, 10:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D113946: [libc][clang-tidy] fix namespace check for externals.
Nov 15 2021, 9:57 PM · Restricted Project, Restricted Project
Eugene.Zelenko removed a reviewer for D113885: [MachineCSE] Use isAsCheapAsAMove in TargetInstrInfo: Eugene.Zelenko.
Nov 15 2021, 7:01 AM · Restricted Project

Nov 14 2021

Eugene.Zelenko added inline comments to D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files.
Nov 14 2021, 5:24 PM · Restricted Project

Nov 13 2021

Eugene.Zelenko added a reviewer for D113828: [clang-tidy] Fix false positives in `fuchsia-trailing-return` check involving deduction guides: juliehockett.
Nov 13 2021, 5:34 PM · Restricted Project
Eugene.Zelenko added a reviewer for D113830: [clang-tidy] Fix false positive in `readability-identifier-naming` check involving `override` attribute: aaron.ballman.
Nov 13 2021, 5:33 PM · Restricted Project

Nov 12 2021

Eugene.Zelenko added a reviewer for D113804: [clang-tidy] Fix behavior of `modernize-use-using` with nested structs/unions: aaron.ballman.
Nov 12 2021, 2:27 PM · Restricted Project, Restricted Project

Nov 11 2021

Eugene.Zelenko added a reviewer for D113708: [clang-tidy] Fix `bugprone-use-after-move` check to also consider moves in constructor initializers: aaron.ballman.
Nov 11 2021, 10:00 PM · Restricted Project
Eugene.Zelenko removed a reviewer for D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators: Eugene.Zelenko.
Nov 11 2021, 6:52 AM · Restricted Project
Eugene.Zelenko added a comment to D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators.

Please wait for @aaron.ballman approval.

Nov 11 2021, 6:52 AM · Restricted Project

Nov 10 2021

Eugene.Zelenko edited reviewers for D113585: [clang-tidy] Fix false positive in `bugprone-throw-keyword-missing` check, added: aaron.ballman; removed: Eugene.Zelenko.
Nov 10 2021, 11:36 AM · Restricted Project

Nov 9 2021

Eugene.Zelenko removed a reviewer for D113242: Adding a key_type definition to MapVector: Eugene.Zelenko.
Nov 9 2021, 10:26 AM · Restricted Project

Nov 1 2021

Eugene.Zelenko added a comment to D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions.

Please mention improvement in Release Notes, in Changes in existing checks section. See example.

Nov 1 2021, 7:00 AM · Restricted Project
Eugene.Zelenko added a reviewer for D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions: aaron.ballman.
Nov 1 2021, 6:57 AM · Restricted Project

Oct 26 2021

Eugene.Zelenko removed a reviewer for D112336: [Serialization] Fix a uniqueness check: Eugene.Zelenko.
Oct 26 2021, 12:15 PM · Restricted Project

Oct 25 2021

Eugene.Zelenko added inline comments to D112409: [clang-tidy] Add check 'cert-err33-c'..
Oct 25 2021, 9:26 AM · Restricted Project

Oct 16 2021

Eugene.Zelenko added reviewers for D111909: [clang-tidy] DefinitionsInHeadersCheck: Added option for checking C Code: hokein, aaron.ballman, njames93.
Oct 16 2021, 7:06 AM · Restricted Project

Oct 12 2021

Eugene.Zelenko added inline comments to D111623: [clang-tidy] Update documentation of check bugprone-unused-return-value [NFC]..
Oct 12 2021, 7:30 AM · Restricted Project

Oct 6 2021

Eugene.Zelenko added inline comments to D111208: [clang-tidy] Support globbing in NOLINT* expressions.
Oct 6 2021, 7:37 AM · Restricted Project

Sep 26 2021

Eugene.Zelenko edited reviewers for D110493: [clang-tidy] Fix bug in readability-uppercase-literal-suffix, added: aaron.ballman; removed: llvm-commits, cfe-commits.
Sep 26 2021, 9:56 PM · Restricted Project

Sep 14 2021

Eugene.Zelenko added a comment to D108893: clang-tidy: introduce readability-containter-data-pointer check.

So you'd like to see that extra functionality added now? (I don't think it makes sense to have the check as-is in both readability and modernize.)

Sep 14 2021, 7:35 AM · Restricted Project
Eugene.Zelenko added a comment to D108893: clang-tidy: introduce readability-containter-data-pointer check.

What about adding modernize/bugprone aliases?

I'd be fine if we wanted to add aliases, but I'd sort of expect some extra functionality out of a check in those modules. I think it's fine to land this now, and we can add aliases in a follow-up. WDYT?

Sep 14 2021, 7:17 AM · Restricted Project
Eugene.Zelenko added a comment to D108893: clang-tidy: introduce readability-containter-data-pointer check.

What about adding modernize/bugprone aliases?

Sep 14 2021, 7:01 AM · Restricted Project