Page MenuHomePhabricator
People Eugene.Zelenko

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (406 w, 6 d)

Recent Activity
View All

Today

Eugene.Zelenko added inline comments to D146921: [clang-tidy] Implement cppcoreguidelines F.19.
Sun, Mar 26, 3:31 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor.
Sun, Mar 26, 3:31 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D146904: [clang-tidy] Fix extern fixes in readability-redundant-declaration.
Sun, Mar 26, 6:47 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D146913: [clang-tidy] Add option to ignore user-defined literals in readability-magic-numbers.
Sun, Mar 26, 6:37 AM · Restricted Project, Restricted Project

Yesterday

Eugene.Zelenko added reviewers for D146887: [clang-tidy] Fix if-constexpr false-positive in readability-misleading-indentation: aaron.ballman, carlosgalvezp.
Sat, Mar 25, 7:10 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D146875: [clang-tidy] Fix example provided by add_new_check.py: aaron.ballman, carlosgalvezp.
Sat, Mar 25, 9:07 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check.
Sat, Mar 25, 7:04 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D144522: [clang-tidy] Add readability-operators-representation check.
Sat, Mar 25, 6:59 AM · Restricted Project, Restricted Project

Fri, Mar 24

Eugene.Zelenko added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Fri, Mar 24, 7:14 AM · Restricted Project, Restricted Project

Thu, Mar 23

Eugene.Zelenko added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Thu, Mar 23, 10:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D146712: [clang-tidy] Add portability-non-portable-integer-constant check: LegalizeAdulthood, PiotrZSL.
Thu, Mar 23, 7:25 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D146712: [clang-tidy] Add portability-non-portable-integer-constant check.

Please add alias entry in Release Notes.

Thu, Mar 23, 7:25 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Thu, Mar 23, 7:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Thu, Mar 23, 7:10 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D146713: [clang-tidy][NFC] Improve naming convention in google-readability-avoid-underscore-in-googletest-name.

But will be good idea to give a chance to other reviewers to take a look.

Thu, Mar 23, 7:02 AM · Restricted Project, Restricted Project

Wed, Mar 22

Eugene.Zelenko added inline comments to D146655: [clang-tidy] Ignore DISABLED_ in test suite name in google-avoid-underscore-in-googletest-name.
Wed, Mar 22, 12:07 PM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D146653: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder.
Wed, Mar 22, 11:44 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D146653: [clang-tidy][NFC] Move avoid-underscore-in-googletest-name to google folder: njames93.
Wed, Mar 22, 11:44 AM · Restricted Project, Restricted Project

Tue, Mar 21

Eugene.Zelenko added reviewers for D146520: [clang-tidy] Fix checks filter with warnings-as-errors: aaron.ballman, carlosgalvezp, PiotrZSL.
Tue, Mar 21, 7:04 AM · Restricted Project, Restricted Project

Sun, Mar 19

Eugene.Zelenko added inline comments to D146368: [clang-tidy] Add readability-reference-to-constructed-temporary check.
Sun, Mar 19, 7:44 AM · Restricted Project, Restricted Project

Fri, Mar 17

Eugene.Zelenko added reviewers for D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer: aaron.ballman, carlosgalvezp, PiotrZSL.
Fri, Mar 17, 7:35 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D146288: clang-tidy: Detect use-after-move in CXXCtorInitializer.
Fri, Mar 17, 7:35 AM · Restricted Project, Restricted Project

Mon, Mar 13

Eugene.Zelenko added reviewers for D145958: [clang-tidy] Fix minor bug in bugprone-too-small-loop-variable: aaron.ballman, carlosgalvezp.
Mon, Mar 13, 11:02 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D145906: [clang-tidy] Correctly handle evaluation order of designated initializers.: aaron.ballman, carlosgalvezp, PiotrZSL.
Mon, Mar 13, 7:51 AM · Restricted Project, Restricted Project

Sun, Mar 12

Eugene.Zelenko added inline comments to D145865: [clang-tidy] Multiple fixes to bugprone-exception-escape.
Sun, Mar 12, 8:34 AM · Restricted Project, Restricted Project

Sat, Mar 11

Eugene.Zelenko added reviewers for D145856: [clang-tidy] Let misc-const-correctness detect auto local variables that can be made const: aaron.ballman, carlosgalvezp, PiotrZSL.
Sat, Mar 11, 6:21 PM · Restricted Project, Restricted Project

Thu, Mar 9

Eugene.Zelenko added reviewers for D145730: [clang-tidy] Fix readability-redundant-string-cstr for smart pointer #576705: aaron.ballman, carlosgalvezp, PiotrZSL.
Thu, Mar 9, 1:48 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check: aaron.ballman.
Thu, Mar 9, 1:04 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D145720: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check.
Thu, Mar 9, 1:04 PM · Restricted Project, Restricted Project

Wed, Mar 8

Eugene.Zelenko added reviewers for D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check: aaron.ballman, carlosgalvezp.
Wed, Mar 8, 6:40 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D145617: [clang-tidy] Add readability-avoid-unconditional-preprocessor-if check.
Wed, Mar 8, 6:40 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.: aaron.ballman, carlosgalvezp, PiotrZSL.
Wed, Mar 8, 7:51 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments..
Wed, Mar 8, 7:50 AM · Restricted Project, Restricted Project

Sat, Mar 4

Eugene.Zelenko added reviewers for D145305: [clang-tidy] altera-id-dependent-backward-branch: do not mark all variables: aaron.ballman, carlosgalvezp.
Sat, Mar 4, 7:15 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D145304: [clang-tidy] altera-id-dependent-backward-branch: refactor test: njames93, aaron.ballman, carlosgalvezp.
Sat, Mar 4, 7:14 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D145303: clang-tidy altera-id-dependent-backward-branch: print notes after warning: aaron.ballman, carlosgalvezp.
Sat, Mar 4, 7:13 AM · Restricted Project, Restricted Project

Thu, Mar 2

Eugene.Zelenko added inline comments to D145138: [clang-tidy] Implement FixIts for C arrays.
Thu, Mar 2, 8:19 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D145138: [clang-tidy] Implement FixIts for C arrays: aaron.ballman, carlosgalvezp.
Thu, Mar 2, 7:24 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D145138: [clang-tidy] Implement FixIts for C arrays.
Thu, Mar 2, 7:22 AM · Restricted Project, Restricted Project

Sat, Feb 25

Eugene.Zelenko added a comment to D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support.

@carlosgalvezp: Sorry, there are too much Clang specifics in this patch, so I could not be reviewer.

Sat, Feb 25, 5:59 PM · Restricted Project, Restricted Project
Eugene.Zelenko removed a reviewer for D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support: Eugene.Zelenko.
Sat, Feb 25, 5:58 PM · Restricted Project, Restricted Project

Feb 24 2023

Eugene.Zelenko added inline comments to D144748: [clang-tidy] Add bugprone-empty-catch check.
Feb 24 2023, 12:32 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D144748: [clang-tidy] Add bugprone-empty-catch check: aaron.ballman, carlosgalvezp.
Feb 24 2023, 12:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D144748: [clang-tidy] Add bugprone-empty-catch check.
Feb 24 2023, 12:22 PM · Restricted Project, Restricted Project

Feb 22 2023

Eugene.Zelenko added reviewers for D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation: aaron.ballman, carlosgalvezp.
Feb 22 2023, 3:02 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D144594: [clang-tidy] Fix bugprone-copy-constructor-init documentation.
Feb 22 2023, 3:02 PM · Restricted Project, Restricted Project

Feb 16 2023

Eugene.Zelenko added reviewers for D144206: [clang-tidy] Fix false-positive in cppcoreguidelines-slicing: aaron.ballman, carlosgalvezp.
Feb 16 2023, 4:49 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D144216: [clang-tidy] Extract string header from redundant-string-cstr checker.

May be you could use heard in other test in same patch?

Feb 16 2023, 4:49 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D144216: [clang-tidy] Extract string header from redundant-string-cstr checker: aaron.ballman, carlosgalvezp.
Feb 16 2023, 4:48 PM · Restricted Project, Restricted Project

Feb 15 2023

Eugene.Zelenko added reviewers for D144037: [clang-tidy] allow tests to use --config-file instead of --config: aaron.ballman, carlosgalvezp.
Feb 15 2023, 7:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D144037: [clang-tidy] allow tests to use --config-file instead of --config.
Feb 15 2023, 7:20 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D144041: [clang-tidy] add primitive types for hungarian identifier-naming (unsigned char and void): aaron.ballman, carlosgalvezp.
Feb 15 2023, 7:19 AM · Restricted Project, Restricted Project

Feb 14 2023

Eugene.Zelenko accepted D143996: [clang-tidy][doc] Remove unused variable.
Feb 14 2023, 8:36 AM · Restricted Project, Restricted Project
Eugene.Zelenko requested changes to D143996: [clang-tidy][doc] Remove unused variable.
Feb 14 2023, 7:19 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D143996: [clang-tidy][doc] Remove unused variable: aaron.ballman, carlosgalvezp, Eugene.Zelenko.
Feb 14 2023, 7:18 AM · Restricted Project, Restricted Project

Feb 13 2023

Eugene.Zelenko added reviewers for D143971: [clang-tidy] Flag more buggy string constructor cases: aaron.ballman, carlosgalvezp.
Feb 13 2023, 7:02 PM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D143917: [clang-tidy] Clarify bugprone-branch-clone diagnostic message.
Feb 13 2023, 11:02 AM · Restricted Project, Restricted Project

Feb 12 2023

Eugene.Zelenko added inline comments to D143851: [clang-tidy] Tweak 'rule of 3/5' checks to allow defaulting a destructor outside the class..
Feb 12 2023, 10:24 PM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D143843: [clang-tidy][NFC] Remove ModernizeTidyModule::getModuleOptions.

But will be good idea to notify authors of checks if they are still active.

Feb 12 2023, 7:34 AM · Restricted Project, Restricted Project

Feb 6 2023

Eugene.Zelenko added reviewers for D143375: clang-tidy: Count template constructors in modernize-use-default-member-init: aaron.ballman, carlosgalvezp.
Feb 6 2023, 7:19 AM · Restricted Project, Restricted Project

Feb 5 2023

Eugene.Zelenko accepted D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options.

Looks OK for me, but please wait for other opinion(s).

Feb 5 2023, 9:11 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D143342: [clang-tidy] Support std::format and std::print in readability-redundant-string-cstr: aaron.ballman, carlosgalvezp.
Feb 5 2023, 7:32 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D142655: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options.
Feb 5 2023, 7:18 AM · Restricted Project, Restricted Project

Jan 31 2023

Eugene.Zelenko edited reviewers for D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options, added: aaron.ballman, hokein, gribozavr2, carlosgalvezp; removed: Restricted Project.
Jan 31 2023, 11:02 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

Eugene.Zelenko added reviewers for D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle: aaron.ballman, hokein, gribozavr2, carlosgalvezp.
Jan 26 2023, 5:55 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D142592: [clang-tidy][libc] Add an inline function checker for the libc project..
Jan 26 2023, 4:44 PM · Restricted Project, Restricted Project

Jan 25 2023

Eugene.Zelenko added reviewers for D142592: [clang-tidy][libc] Add an inline function checker for the libc project.: hokein, gribozavr2, carlosgalvezp.
Jan 25 2023, 7:15 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D142592: [clang-tidy][libc] Add an inline function checker for the libc project..

Please add entry in Release Notes.

Jan 25 2023, 7:14 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D142587: [clang-tidy] Improved too-small-loop-variable with bit-field support: aaron.ballman, hokein, gribozavr2, carlosgalvezp.
Jan 25 2023, 3:36 PM · Restricted Project, Restricted Project

Jan 22 2023

Eugene.Zelenko accepted D142307: [clang-tidy][NFC] Use C++17 nested namespaces in clang-tidy headers.

Looks OK for me, but please fix small formatting issues. Will be good idea to await for other eyes.

Jan 22 2023, 9:34 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options.

D142123 also cries for it :-) Somehow I was not able to make comments there :-(

Jan 22 2023, 7:14 AM · Restricted Project, Restricted Project

Jan 19 2023

Eugene.Zelenko added inline comments to D141133: [clang-tidy] Implement CppCoreGuideline F.54.
Jan 19 2023, 7:11 PM · Restricted Project, Restricted Project

Jan 16 2023

Eugene.Zelenko added reviewers for D141838: [clang-tidy] fix a false positive of `cppcoreguidelines-avoid-non-const-global-variables`: aaron.ballman, LegalizeAdulthood.
Jan 16 2023, 7:51 AM · Restricted Project, Restricted Project

Jan 15 2023

Eugene.Zelenko edited reviewers for D141787: [clang-tidy] fix a false positive of `modernize-concat-nested-namespaces`, added: aaron.ballman, LegalizeAdulthood, hokein, gribozavr; removed: Eugene.Zelenko.
Jan 15 2023, 6:37 AM · Restricted Project, Restricted Project

Jan 14 2023

Eugene.Zelenko added inline comments to D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py.
Jan 14 2023, 9:50 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py.
Jan 14 2023, 9:48 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D141769: [clang-tidy][NFC] Use C++17 nested namespaces in add_new_check.py and rename_check.py.

But will be good idea if other eyes will look too.

Jan 14 2023, 9:45 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options.

Looks OK for me, but please improve Release Notes. Will be good idea to wait for developers approval.

Jan 14 2023, 6:54 AM · Restricted Project, Restricted Project

Jan 12 2023

Eugene.Zelenko accepted D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option.
Jan 12 2023, 8:27 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option.
Jan 12 2023, 8:07 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D141583: [clang-tidy][doc] Deprecate the AnalyzeTemporaryDtors option.
Jan 12 2023, 7:02 AM · Restricted Project, Restricted Project

Jan 10 2023

Eugene.Zelenko updated subscribers of D141391: [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes.
In D141391#4040002, @ccotter wrote:

I can't land these myself, so if you are able to, would you mind doing so? Thanks!

Jan 10 2023, 8:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D141391: [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes.

Thank you for fix! Such issues may be result of rebase artifacts and slip into code base.

Jan 10 2023, 8:10 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert.
Jan 10 2023, 7:44 AM · Restricted Project, Restricted Project

Jan 8 2023

Eugene.Zelenko added a comment to D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options.

It'll be good idea to check that HeaderFileExtensions and ImplementationFileExtensions do not overlap.

Jan 8 2023, 8:48 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D141133: [clang-tidy] Implement CppCoreGuideline F.54.
Jan 8 2023, 7:28 AM · Restricted Project, Restricted Project

Jan 6 2023

Eugene.Zelenko accepted D141144: [clang-tidy][doc] Improve clang-tidy documentation.

But will be good idea to wait for other reviewers.

Jan 6 2023, 10:36 AM · Restricted Project, Restricted Project
Eugene.Zelenko requested changes to D141144: [clang-tidy][doc] Improve clang-tidy documentation.
Jan 6 2023, 10:11 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D141144: [clang-tidy][doc] Improve clang-tidy documentation.
Jan 6 2023, 10:11 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D141133: [clang-tidy] Implement CppCoreGuideline F.54: aaron.ballman, LegalizeAdulthood, hokein, gribozavr.
Jan 6 2023, 7:09 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D141133: [clang-tidy] Implement CppCoreGuideline F.54.
Jan 6 2023, 7:07 AM · Restricted Project, Restricted Project
Eugene.Zelenko accepted D141118: [clang-tidy][NFC] Remove unused User argument in misc-misleading-bidirectional check.

Looks OK for me, but please wait for more active developers' opinion.

Jan 6 2023, 6:55 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty: aaron.ballman, LegalizeAdulthood.
Jan 6 2023, 6:42 AM · Restricted Project, Restricted Project

Jan 5 2023

Eugene.Zelenko added reviewers for D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result: aaron.ballman, hokein, LegalizeAdulthood.
Jan 5 2023, 12:55 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D141058: [clang-tidy] fix wrong fixup for bugprone-implicit-widening-of-multiplication-result.
Jan 5 2023, 12:54 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options: hokein.
Jan 5 2023, 7:11 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`.
Jan 5 2023, 6:45 AM · Restricted Project, Restricted Project

Jan 4 2023

Eugene.Zelenko added a comment to D141000: [clang-tidy] Introduce HeaderFileExtensions and ImplementationFileExtensions options.

Looks OK for me, but probably will be good idea to remove check-specific options in same commit.

Jan 4 2023, 10:03 AM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`: aaron.ballman, LegalizeAdulthood, gribozavr, hokein.
Jan 4 2023, 7:01 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D140968: [clang-tidy] Add check for passing the result of `std::string::c_str` to `strlen`.
Jan 4 2023, 7:00 AM · Restricted Project, Restricted Project