Page MenuHomePhabricator

Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (214 w, 6 d)

Recent Activity

Mon, Jul 15

Eugene.Zelenko added inline comments to D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops.
Mon, Jul 15, 6:52 AM · Restricted Project, Restricted Project

Fri, Jul 12

Eugene.Zelenko retitled D64671: [clang-tidy] New check: misc-init-local-variables from New clang-tidy check: misc-init-local-variables to [clang-tidy] New check: misc-init-local-variables.
Fri, Jul 12, 4:24 PM · Restricted Project
Eugene.Zelenko added reviewers for D64671: [clang-tidy] New check: misc-init-local-variables: hokein, aaron.ballman, JonasToth.
Fri, Jul 12, 4:22 PM · Restricted Project
Eugene.Zelenko added inline comments to D64671: [clang-tidy] New check: misc-init-local-variables.
Fri, Jul 12, 4:21 PM · Restricted Project

Wed, Jul 10

Eugene.Zelenko added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

Docs exist for these checks on the analyzer side, they're just all on the same page and hyperlinking to them individually is difficult because the links have a nonstandard naming convention. Currently I'm just linking to that page.

Wed, Jul 10, 3:13 PM · Restricted Project
Eugene.Zelenko added a comment to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.

May be script should generate documentation during build, so files .rst files are not needed?

Wed, Jul 10, 2:26 PM · Restricted Project

Tue, Jul 9

Eugene.Zelenko removed a reviewer for D61466: [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug: Eugene.Zelenko.
Tue, Jul 9, 4:42 PM · Restricted Project
Eugene.Zelenko added inline comments to D64454: [clang-tidy] Adding static analyzer check to list of clang-tidy checks.
Tue, Jul 9, 4:41 PM · Restricted Project
Eugene.Zelenko added inline comments to D64407: [DWARF] Simplify DWARFAttribute. NFC..
Tue, Jul 9, 6:12 AM · Restricted Project

Wed, Jul 3

Eugene.Zelenko added inline comments to D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters..
Wed, Jul 3, 2:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D64123: Add clang-llvm-rename tool..

There is clang-rename already. May be new functionality should be added there?

Wed, Jul 3, 3:38 AM · Restricted Project

Fri, Jun 28

Eugene.Zelenko added inline comments to D63929: [clang-tidy] - Introduce abseil-prefixed-thread-annotations check..
Fri, Jun 28, 7:17 AM · Restricted Project, Restricted Project

Tue, Jun 25

Eugene.Zelenko added reviewers for D63784: [clang-tidy] Fix ClangTidyTest to initialize context before checks.: alexfh, hokein, aaron.ballman.
Tue, Jun 25, 1:35 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D63763: [clang-tidy] Update documentation for Qt Creator integration..

Looks OK for me, but will be good idea to hear other people too.

Tue, Jun 25, 6:28 AM · Restricted Project

Mon, Jun 24

Eugene.Zelenko added inline comments to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.
Mon, Jun 24, 7:57 AM · Restricted Project

Jun 21 2019

Eugene.Zelenko added inline comments to D63663: [clang-doc] Add html links to references.
Jun 21 2019, 3:08 PM · Restricted Project, Restricted Project

Jun 20 2019

Eugene.Zelenko added inline comments to D63623: [clang-tidy] new check: bugprone-posix-return.
Jun 20 2019, 4:14 PM · Restricted Project, Restricted Project

Jun 19 2019

Eugene.Zelenko added inline comments to D63559: [clangd] Added functionality for getting semantic highlights for variable and function declarations.
Jun 19 2019, 10:04 AM · Restricted Project

Jun 18 2019

Eugene.Zelenko added inline comments to D63324: [clang-tidy] Replace memcpy by std::copy.
Jun 18 2019, 7:14 AM · Restricted Project, Restricted Project

Jun 15 2019

Eugene.Zelenko added inline comments to D63324: [clang-tidy] Replace memcpy by std::copy.
Jun 15 2019, 12:28 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D63324: [clang-tidy] Replace memcpy by std::copy.
Jun 15 2019, 8:28 AM · Restricted Project, Restricted Project

Jun 14 2019

Eugene.Zelenko added inline comments to D63367: [clang-doc] Add basic support for templates and typedef.
Jun 14 2019, 5:48 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D63324: [clang-tidy] Replace memcpy by std::copy: alexfh, hokein, aaron.ballman, JonasToth.
Jun 14 2019, 10:22 AM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D63324: [clang-tidy] Replace memcpy by std::copy.

New check must be mentioned in Release Notes and its documentation provided.

Jun 14 2019, 10:22 AM · Restricted Project, Restricted Project

Jun 6 2019

Eugene.Zelenko added a comment to D62977: [clang-tidy]: Google: new check 'google-upgrade-googletest-case'.

I think will be good idea to replace upgrade with modernize to be consistent with similar checks in other module.

Jun 6 2019, 5:28 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62437: [clang-tidy] Splits fuchsia-default-arguments.
Jun 6 2019, 2:37 PM · Restricted Project, Restricted Project, Restricted Project

Jun 3 2019

Eugene.Zelenko added reviewers for D62829: [clang-tidy] Check for dynamically initialized statics in headers.: alexfh, hokein, aaron.ballman, JonasToth.
Jun 3 2019, 5:14 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62829: [clang-tidy] Check for dynamically initialized statics in headers..
Jun 3 2019, 5:14 PM · Restricted Project, Restricted Project

May 31 2019

Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 4:13 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 11:25 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62736: [clang-tidy] Fix make-unique check to work in C++17 mode..
May 31 2019, 10:09 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.: aaron.ballman.
May 31 2019, 10:09 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2019

Eugene.Zelenko added inline comments to D62437: [clang-tidy] Splits fuchsia-default-arguments.
May 24 2019, 4:50 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D62437: [clang-tidy] Splits fuchsia-default-arguments.

Please mention renaming of existing check in Release Notes (after list of new checks).

May 24 2019, 4:45 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62437: [clang-tidy] Splits fuchsia-default-arguments: alexfh, hokein, aaron.ballman, JonasToth.
May 24 2019, 4:45 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62404: [clang-tidy] Fix null pointer dereference in readability-identifier-naming: alexfh, hokein, aaron.ballman, JonasToth.
May 24 2019, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

May 21 2019

Eugene.Zelenko added a comment to D62192: [clang-tidy]: Add cert-oop54-cpp alias for bugprone-unhandled-self-assignment.

Please mention alias (in aliases list) in Release Notes.

May 21 2019, 8:48 AM · Restricted Project

May 16 2019

Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 16 2019, 6:23 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.: alexfh, hokein, aaron.ballman, JonasToth.
May 16 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module..
May 16 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added a reviewer for D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files: JonasToth.
May 16 2019, 8:00 AM · Restricted Project
Eugene.Zelenko added a comment to D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files.

Will be good idea to mention new option in the Release Notes.

May 16 2019, 8:00 AM · Restricted Project

May 15 2019

Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 15 2019, 4:07 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.: hokein, aaron.ballman, JonasToth.
May 15 2019, 4:07 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module..
May 15 2019, 4:04 PM · Restricted Project, Restricted Project, Restricted Project

May 9 2019

Eugene.Zelenko added reviewers for D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static: hokein, JonasToth.
May 9 2019, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko updated subscribers of D61749: [clang-tidy] initial version of readability-convert-member-functions-to-static.

@JonasToth tried to implement const check, so probably const and static part should be split. It's hard to tell about state of existing implementation, but you could continue it or at least borrow ideas and tests.

May 9 2019, 1:13 PM · Restricted Project, Restricted Project, Restricted Project

May 3 2019

Eugene.Zelenko added reviewers for D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard: hokein, aaron.ballman, JonasToth.
May 3 2019, 8:49 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard.
May 3 2019, 8:49 AM · Restricted Project, Restricted Project

May 1 2019

Eugene.Zelenko added inline comments to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 1 2019, 4:55 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..
May 1 2019, 10:52 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule.: alexfh, hokein, JonasToth.
May 1 2019, 10:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61386: [clang-tidy] Add support writing a check as a Transformer rewrite rule..
May 1 2019, 10:10 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 30 2019

Eugene.Zelenko retitled D61350: [clang-tidy] New check calling out uses of +new in Objective-C code from New clang-tidy check calling out uses of +new in Objective-C code to [clang-tidy] New check calling out uses of +new in Objective-C code.
Apr 30 2019, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61350: [clang-tidy] New check calling out uses of +new in Objective-C code: alexfh, aaron.ballman, JonasToth.
Apr 30 2019, 6:09 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
Apr 30 2019, 6:09 PM · Restricted Project, Restricted Project

Apr 26 2019

Eugene.Zelenko added inline comments to D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.
Apr 26 2019, 5:00 PM · Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL: JonasToth, hokein.
Apr 26 2019, 2:06 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D61209: [clang-tidy] Fix readability-redundant-smartptr-get for MSVC STL.
Apr 26 2019, 2:06 PM · Restricted Project, Restricted Project

Apr 22 2019

Eugene.Zelenko added inline comments to D59963: [clang-tidy] Add a module for the Linux kernel..
Apr 22 2019, 3:51 PM · Restricted Project, Restricted Project

Apr 16 2019

Eugene.Zelenko added inline comments to D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403).
Apr 16 2019, 10:12 AM · Restricted Project, Restricted Project

Apr 12 2019

Eugene.Zelenko added a reviewer for D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check': hokein.
Apr 12 2019, 1:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'.

Please use check for consistency with rest of Clang-tidy.

Apr 12 2019, 1:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 12 2019, 11:28 AM · Restricted Project, Restricted Project, Restricted Project

Apr 10 2019

Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Apr 10 2019, 6:15 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Apr 10 2019, 4:17 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60533: [asan_symbolize] Teach `asan_symbolize.py` to symbolicate partially symbolicated ASan reports..
Apr 10 2019, 1:46 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment.
Apr 10 2019, 10:02 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2019

Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 9 2019, 11:45 AM · Restricted Project, Restricted Project

Apr 4 2019

Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 4 2019, 9:44 AM · Restricted Project, Restricted Project

Apr 3 2019

Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 3 2019, 7:06 AM · Restricted Project, Restricted Project

Apr 2 2019

Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Apr 2 2019, 3:31 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check.
Apr 2 2019, 11:18 AM · Restricted Project, Restricted Project
Eugene.Zelenko retitled D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check from Add clang-tidy/checks/misc-placement-new-target-size check to [clang-tidy] Add misc-placement-new-target-size check.
Apr 2 2019, 11:12 AM · Restricted Project, Restricted Project

Apr 1 2019

Eugene.Zelenko added a comment to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.

Do we have any checker to recommend llvm functions over std ?

e.g. llvm::sort, llvm::all_of, ...

Apr 1 2019, 11:10 AM · Restricted Project, Restricted Project, Restricted Project

Mar 28 2019

Eugene.Zelenko added a comment to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 28 2019, 6:35 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 28 2019, 6:22 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko retitled D59963: [clang-tidy] Add a module for the Linux kernel. from Add a clang-tidy module for the Linux kernel. to [clang-tidy] Add module for the Linux kernel..
Mar 28 2019, 3:22 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D59963: [clang-tidy] Add a module for the Linux kernel..

I think linuxkernel name will be less ambiguous.

Mar 28 2019, 3:20 PM · Restricted Project, Restricted Project
Eugene.Zelenko added a comment to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..

I think the idea is good and implementation, too. If we iterate all checks anyway (probably?) we could think about adding a severity to the checks, too?

I know that code-checker and code-compass have something like this to signal importance of problems (say bugprone and cert differ from readability for example).

Mar 28 2019, 11:59 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59930: Parallel STL version updated.
Mar 28 2019, 11:39 AM
Eugene.Zelenko added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Mar 28 2019, 11:39 AM · Restricted Project, Restricted Project
Eugene.Zelenko edited projects for D59932: [clang-tidy] Add fix descriptions to clang-tidy checks., added: Restricted Project; removed Restricted Project.
Mar 28 2019, 8:47 AM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59932: [clang-tidy] Add fix descriptions to clang-tidy checks..
Mar 28 2019, 8:47 AM · Restricted Project, Restricted Project

Mar 27 2019

Eugene.Zelenko added inline comments to D57435: [clang-tidy] Add abseil-wrap-unique check.
Mar 27 2019, 5:05 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Mar 27 2019, 10:03 AM · Restricted Project
Eugene.Zelenko added inline comments to D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library.
Mar 27 2019, 9:46 AM · Restricted Project
Eugene.Zelenko edited projects for D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable, added: Restricted Project; removed Restricted Project.
Mar 27 2019, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable.
Mar 27 2019, 8:06 AM · Restricted Project, Restricted Project, Restricted Project

Mar 26 2019

Eugene.Zelenko added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.
Mar 26 2019, 1:02 PM · Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 26 2019, 11:50 AM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.
Mar 26 2019, 9:28 AM · Restricted Project, Restricted Project

Mar 25 2019

Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 25 2019, 6:20 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added reviewers for D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals: hokein, aaron.ballman, JonasToth.
Mar 25 2019, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
Eugene.Zelenko added inline comments to D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals.
Mar 25 2019, 3:23 PM · Restricted Project, Restricted Project, Restricted Project

Mar 22 2019

Eugene.Zelenko added inline comments to D59639: [clangd] Print template arguments helper.
Mar 22 2019, 6:49 AM · Restricted Project, Restricted Project

Mar 21 2019

Eugene.Zelenko added inline comments to D59639: [clangd] Print template arguments helper.
Mar 21 2019, 8:38 AM · Restricted Project, Restricted Project

Mar 20 2019

Eugene.Zelenko added inline comments to D59605: [clangd] Introduce background-indexer.
Mar 20 2019, 10:57 AM · Restricted Project
Eugene.Zelenko added inline comments to D59599: [clangd] Fix a crash while printing Template Arguments.
Mar 20 2019, 10:47 AM · Restricted Project