Eugene.Zelenko (Eugene Zelenko)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2015, 2:10 PM (175 w, 4 d)

Recent Activity

Wed, Oct 17

Eugene.Zelenko added a comment to D53382: [clang-doc] Update documentation.

Will be good idea to mention improvements in Release Notes.

Wed, Oct 17, 4:11 PM · Restricted Project

Tue, Oct 16

Eugene.Zelenko added a comment to D53339: [clang-tidy] Add the abseil-duration-factory-float check.

By the word, why this check could not be generalized to any function/method which have floating-point and integer variants?

Tue, Oct 16, 5:12 PM · Restricted Project
Eugene.Zelenko retitled D53339: [clang-tidy] Add the abseil-duration-factory-float check from Add the abseil-duration-factory-float clang-tidy check to [clang-tidy] Add the abseil-duration-factory-float check.
Tue, Oct 16, 5:07 PM · Restricted Project
Eugene.Zelenko added inline comments to D53339: [clang-tidy] Add the abseil-duration-factory-float check.
Tue, Oct 16, 5:05 PM · Restricted Project

Fri, Oct 12

Eugene.Zelenko added inline comments to D48866: [clang-tidy] Add incorrect-pointer-cast checker.
Fri, Oct 12, 6:42 PM
Eugene.Zelenko added inline comments to D52771: [clang-tidy] Non-private member variables in classes (MISRA, CppCoreGuidelines, HICPP).
Fri, Oct 12, 6:34 PM · Restricted Project
Eugene.Zelenko retitled D53217: [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete from clang-tidy: add IgnoreMacros option to modernize-use-equals-delete to [clang-tidy] add IgnoreMacros option to modernize-use-equals-delete.
Fri, Oct 12, 2:24 PM · Restricted Project

Thu, Oct 11

Eugene.Zelenko added inline comments to D53170: [clang-doc] Switch to default to all-TUs executor.
Thu, Oct 11, 2:36 PM · Restricted Project
Eugene.Zelenko added inline comments to D53025: [clang-tidy] implement new check for const return types..
Thu, Oct 11, 12:57 PM · Restricted Project

Tue, Oct 9

Eugene.Zelenko added reviewers for D53025: [clang-tidy] implement new check for const return types.: alexfh, hokein.
Tue, Oct 9, 10:47 AM · Restricted Project
Eugene.Zelenko added a comment to D53025: [clang-tidy] implement new check for const return types..

GCC has -Wignored-qualifiers for long time, so may be better to implement it in Clang?

Tue, Oct 9, 10:45 AM · Restricted Project

Mon, Oct 8

Eugene.Zelenko added inline comments to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.
Mon, Oct 8, 10:01 AM · Restricted Project

Sun, Oct 7

Eugene.Zelenko added reviewers for D52971: [clang-tidy] Customize FileCheck prefix in check_clang-tidy.py to support multiple prefixes: hokein, aaron.ballman, JonasToth.
Sun, Oct 7, 2:12 PM · Restricted Project

Fri, Oct 5

Eugene.Zelenko added inline comments to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.
Fri, Oct 5, 10:11 AM · Restricted Project

Thu, Oct 4

Eugene.Zelenko added inline comments to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.
Thu, Oct 4, 1:17 PM · Restricted Project
Eugene.Zelenko added a comment to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.

It'll be good idea to handle climits constants too.

Thu, Oct 4, 10:54 AM · Restricted Project
Eugene.Zelenko added a comment to D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.

I think modernize is better module for this check.

Thu, Oct 4, 10:29 AM · Restricted Project
Eugene.Zelenko retitled D52892: [Clang-tidy] readability check to convert numerical constants to std::numeric_limits from [Clang-tidy: readability] readability check to convert numerical constants to std::numeric_limits to [Clang-tidy] readability check to convert numerical constants to std::numeric_limits.
Thu, Oct 4, 10:23 AM · Restricted Project

Tue, Oct 2

Eugene.Zelenko added reviewers for D52782: [clang-tidy] Sequence statements with multiple parents correctly (PR39149): alexfh, hokein, aaron.ballman, JonasToth.
Tue, Oct 2, 10:40 AM · Restricted Project

Fri, Sep 28

Eugene.Zelenko added inline comments to D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4).
Fri, Sep 28, 2:27 PM · Restricted Project
Eugene.Zelenko added a comment to D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4).

May be we should also create MISRA module?

Fri, Sep 28, 2:27 PM · Restricted Project
Eugene.Zelenko added a comment to D51949: [clang-tidy] new check 'readability-isolate-declaration'.

How about creating CERT alias?

Fri, Sep 28, 11:27 AM · Restricted Project

Thu, Sep 27

Eugene.Zelenko edited reviewers for D52613: [ADT] Change the `IntervalMap` alignment assert for x86 MSVC, added: hans; removed: Eugene.Zelenko.
Thu, Sep 27, 12:47 PM

Wed, Sep 26

Eugene.Zelenko added a project to D52552: [clang-tidy] Flag Classes Inheriting From Structs: Restricted Project.
Wed, Sep 26, 1:10 PM · Restricted Project
Eugene.Zelenko added inline comments to D52552: [clang-tidy] Flag Classes Inheriting From Structs.
Wed, Sep 26, 10:26 AM · Restricted Project

Thu, Sep 20

Eugene.Zelenko retitled D52334: [clang-tidy] Build it even without static analyzer from Build clang-tidy even without static analyzer to [clang-tidy] Build it even without static analyzer.
Thu, Sep 20, 7:21 PM · Restricted Project

Wed, Sep 19

Eugene.Zelenko added a comment to D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.

Looks like you patch is not based on trunk. Please rebase.

Wed, Sep 19, 3:47 PM · Restricted Project
Eugene.Zelenko added inline comments to D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Wed, Sep 19, 3:38 PM · Restricted Project
Eugene.Zelenko retitled D52281: [clang-tidy] Add modernize check to use std::invoke in generic code from Use std::invoke in generic code to [clang-tidy] Add modernize check to use std::invoke in generic code.
Wed, Sep 19, 3:36 PM · Restricted Project
Eugene.Zelenko added inline comments to D52281: [clang-tidy] Add modernize check to use std::invoke in generic code.
Wed, Sep 19, 3:35 PM · Restricted Project

Sep 15 2018

Eugene.Zelenko added a project to D52136: [clang-tidy] Add modernize-concat-nested-namespaces check: Restricted Project.
Sep 15 2018, 8:42 AM · Restricted Project
Eugene.Zelenko added inline comments to D52136: [clang-tidy] Add modernize-concat-nested-namespaces check.
Sep 15 2018, 8:42 AM · Restricted Project
Eugene.Zelenko added a project to D52135: [Clang-Tidy: modernize] Fix for modernize-redundant-void-arg: complains about variable cast to void: Restricted Project.
Sep 15 2018, 8:40 AM · Restricted Project

Sep 11 2018

Eugene.Zelenko added a comment to D51949: [clang-tidy] new check 'readability-isolate-declaration'.

I would suggest to use declaration or declarations in check name instead of abbreviation.

Sep 11 2018, 3:59 PM · Restricted Project
Eugene.Zelenko added inline comments to D51949: [clang-tidy] new check 'readability-isolate-declaration'.
Sep 11 2018, 3:52 PM · Restricted Project
Eugene.Zelenko added a reviewer for D51949: [clang-tidy] new check 'readability-isolate-declaration': omtcyfz.
Sep 11 2018, 3:52 PM · Restricted Project

Sep 7 2018

Eugene.Zelenko removed a reviewer for D51824: StmtPrinter: allow customizing the end-of-line character: Eugene.Zelenko.
Sep 7 2018, 7:09 PM · Restricted Project

Sep 2 2018

Eugene.Zelenko added inline comments to D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜.
Sep 2 2018, 7:45 AM · Restricted Project
Eugene.Zelenko added reviewers for D51575: [clang-tidy] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜: alexfh, aaron.ballman.
Sep 2 2018, 7:45 AM · Restricted Project

Aug 28 2018

Eugene.Zelenko added a comment to D50542: [clang-tidy] Add abseil-no-internal-deps check.

I still thik will be good idea to rename check (deps -> dependencies).

Aug 28 2018, 10:05 AM · Restricted Project

Aug 24 2018

Eugene.Zelenko added a comment to D51132: [clang-tidy] abseil-redundant-strcat-calls-check .

Indentation of example in documentation is still fixed.

Aug 24 2018, 1:17 PM · Restricted Project
Eugene.Zelenko added a comment to D51132: [clang-tidy] abseil-redundant-strcat-calls-check .

Example in documentation was not fixed.

Aug 24 2018, 1:06 PM · Restricted Project

Aug 23 2018

Eugene.Zelenko added inline comments to D51061: [clang-tidy] abseil-str-cat-append.
Aug 23 2018, 10:40 AM · Restricted Project
Eugene.Zelenko added inline comments to D51132: [clang-tidy] abseil-redundant-strcat-calls-check .
Aug 23 2018, 10:21 AM · Restricted Project
Eugene.Zelenko added inline comments to D51132: [clang-tidy] abseil-redundant-strcat-calls-check .
Aug 23 2018, 10:11 AM · Restricted Project

Aug 22 2018

Eugene.Zelenko added reviewers for D51132: [clang-tidy] abseil-redundant-strcat-calls-check : aaron.ballman, ilya-biryukov.
Aug 22 2018, 5:11 PM · Restricted Project
Eugene.Zelenko added a comment to D51132: [clang-tidy] abseil-redundant-strcat-calls-check .

Is it possible to implement fix-it?

Aug 22 2018, 5:11 PM · Restricted Project
Eugene.Zelenko added inline comments to D51061: [clang-tidy] abseil-str-cat-append.
Aug 22 2018, 10:15 AM · Restricted Project

Aug 21 2018

Eugene.Zelenko added reviewers for D51061: [clang-tidy] abseil-str-cat-append: aaron.ballman, ilya-biryukov.
Aug 21 2018, 5:49 PM · Restricted Project
Eugene.Zelenko added inline comments to D51061: [clang-tidy] abseil-str-cat-append.
Aug 21 2018, 5:48 PM · Restricted Project
Eugene.Zelenko added inline comments to D50580: [clang-tidy] Abseil: no namespace check.
Aug 21 2018, 2:55 PM · Restricted Project
Eugene.Zelenko added a comment to D50580: [clang-tidy] Abseil: no namespace check.

Please rebase from trunk.

Aug 21 2018, 10:03 AM · Restricted Project

Aug 19 2018

Eugene.Zelenko removed a reviewer for D50945: [Lex] Make HeaderMaps a unique_ptr vector: Eugene.Zelenko.
Aug 19 2018, 7:27 AM · Restricted Project

Aug 17 2018

Eugene.Zelenko added a comment to D50389: [clang-tidy] Abseil: integral division of Duration check.

Somehow documentation file was not committed.

Aug 17 2018, 11:10 AM · Restricted Project

Aug 16 2018

Eugene.Zelenko added inline comments to D50862: [clang-tidy] Abseil: faster strsplit delimiter check.
Aug 16 2018, 5:41 PM · Restricted Project

Aug 13 2018

Eugene.Zelenko added a comment to D48909: [clang-doc] Update BitcodeReader to use llvm::Error.

You could use Differential revision: <review URL> in commit description to close review automatically.

Aug 13 2018, 3:40 PM · Restricted Project

Aug 10 2018

Eugene.Zelenko added reviewers for D50580: [clang-tidy] Abseil: no namespace check: aaron.ballman, ilya-biryukov.
Aug 10 2018, 4:55 PM · Restricted Project
Eugene.Zelenko added a comment to D50580: [clang-tidy] Abseil: no namespace check.

Check documentation is missing.

Aug 10 2018, 4:54 PM · Restricted Project
Eugene.Zelenko added inline comments to D50542: [clang-tidy] Add abseil-no-internal-deps check.
Aug 10 2018, 10:21 AM · Restricted Project

Aug 9 2018

Eugene.Zelenko retitled D50542: [clang-tidy] Add abseil-no-internal-deps check from [Clang-Tidy] Check for abseil to [clang-tidy] Add abseil-no-internal-deps check.
Aug 9 2018, 7:05 PM · Restricted Project
Eugene.Zelenko added a comment to D50542: [clang-tidy] Add abseil-no-internal-deps check.

Why not to use dependencies instead of deps in check's name?

Aug 9 2018, 7:04 PM · Restricted Project

Aug 7 2018

Eugene.Zelenko edited reviewers for D50389: [clang-tidy] Abseil: integral division of Duration check, added: alexfh, ilya-biryukov; removed: Restricted Project.
Aug 7 2018, 10:22 AM · Restricted Project

Aug 4 2018

Eugene.Zelenko added inline comments to D50299: Migrate to llvm::unique_function instead of static member functions for callbacks.
Aug 4 2018, 9:59 PM

Jul 30 2018

Eugene.Zelenko added inline comments to D50034: Add a CommandGuide for llvm-objdump.
Jul 30 2018, 7:23 PM

Jul 27 2018

Eugene.Zelenko added reviewers for D49910: [clang-tidy] Recognize [[clang::reinitializes]] attribute in bugprone-use-after-move: alexfh, hokein.
Jul 27 2018, 10:13 AM · Restricted Project
Eugene.Zelenko added reviewers for D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while: alexfh, aaron.ballman, hokein.
Jul 27 2018, 10:12 AM · Restricted Project

Jul 26 2018

Eugene.Zelenko added inline comments to D49890: Clang-Tidy Export Problem.
Jul 26 2018, 6:40 PM · Restricted Project
Eugene.Zelenko added inline comments to D49890: Clang-Tidy Export Problem.
Jul 26 2018, 5:52 PM · Restricted Project
Eugene.Zelenko added reviewers for D49890: Clang-Tidy Export Problem: aaron.ballman, hokein, ilya-biryukov.
Jul 26 2018, 5:51 PM · Restricted Project
Eugene.Zelenko added inline comments to D49890: Clang-Tidy Export Problem.
Jul 26 2018, 5:50 PM · Restricted Project
Eugene.Zelenko retitled D49864: [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--) from The script clang-tidy-diff.py doesn't accept 'pass by' options (--) to [clang-tidy] The script clang-tidy-diff.py doesn't accept 'pass by' options (--).
Jul 26 2018, 10:13 AM · Restricted Project
Eugene.Zelenko removed a reviewer for D49223: [AST] Check described template at structural equivalence check.: Eugene.Zelenko.
Jul 26 2018, 10:04 AM · Restricted Project
Eugene.Zelenko added reviewers for D49851: [clang-tidy] run-clang-tidy add synchronisation to the output: alexfh, hokein.
Jul 26 2018, 9:00 AM · Restricted Project

Jul 24 2018

Eugene.Zelenko added inline comments to D49114: [clang-tidy] Add a check for "magic numbers".
Jul 24 2018, 7:11 PM
Eugene.Zelenko added inline comments to D49114: [clang-tidy] Add a check for "magic numbers".
Jul 24 2018, 7:00 PM

Jul 17 2018

Eugene.Zelenko added inline comments to D49114: [clang-tidy] Add a check for "magic numbers".
Jul 17 2018, 4:37 PM
Eugene.Zelenko added a comment to D49114: [clang-tidy] Add a check for "magic numbers".

Adding C++ Core Guidelines alias is definitely low-hanging fruit which could be implemented within this patch.

Jul 17 2018, 10:18 AM
Eugene.Zelenko added a comment to D45444: [clang-tidy] implement new check for const-correctness.

But you could also take a look at the enforcement of some coding
guidelines (my personal todolists:
https://github.com/JonasToth/CppCoreGuidelinesTooling 
https://github.com/JonasToth/HighIntegrityTooling). There are always low
hanging fruit checks. Implementing something there helps getting used to
the codebase of clang, too.

Jul 17 2018, 10:14 AM
Eugene.Zelenko removed a reviewer for D49412: Enrich inline messages: Eugene.Zelenko.
Jul 17 2018, 10:11 AM

Jul 14 2018

Eugene.Zelenko retitled D49334: [LLDB} Added syntax highlighting support from Added syntax highlighting support to [LLDB} Added syntax highlighting support.
Jul 14 2018, 10:46 AM · Restricted Project

Jul 11 2018

Eugene.Zelenko added inline comments to D49114: [clang-tidy] Add a check for "magic numbers".
Jul 11 2018, 4:45 PM
Eugene.Zelenko added inline comments to D49114: [clang-tidy] Add a check for "magic numbers".
Jul 11 2018, 4:08 PM
Eugene.Zelenko added a comment to D49114: [clang-tidy] Add a check for "magic numbers".

C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic constants, so I think check should be moved into cppcoreguidelines module.

The same guidelines existed in medical and aerospace environments for many years before C++ Core Guidelines. In fact the same checker should run just fine on C code (I'm not sure about Objective-C).

I am not opposed to moving it, if this is where the consensus leads - I know where to find it :)

Jul 11 2018, 3:20 PM
Eugene.Zelenko added a comment to D49114: [clang-tidy] Add a check for "magic numbers".

C++ Core Guidelines contains ES.45: Avoid "magic constants"; use symbolic constants, so I think check should be moved into cppcoreguidelines module.

Jul 11 2018, 1:33 PM

Jul 10 2018

Eugene.Zelenko added a comment to D49114: [clang-tidy] Add a check for "magic numbers".

It's highly likely that this part of coding guidelines.

Jul 10 2018, 2:06 PM

Jul 3 2018

Eugene.Zelenko added inline comments to D48908: [clang-doc] Pass over function-internal declarations.
Jul 3 2018, 7:29 PM · Restricted Project
Eugene.Zelenko added inline comments to D48909: [clang-doc] Update BitcodeReader to use llvm::Error.
Jul 3 2018, 7:28 PM · Restricted Project
Eugene.Zelenko removed a reviewer for D48894: [AST] Rename some Redeclarable functions to reduce confusion: Eugene.Zelenko.
Jul 3 2018, 3:54 PM · Restricted Project
Eugene.Zelenko added a comment to D48866: [clang-tidy] Add incorrect-pointer-cast checker.

bugprone seems to be proper category for this check.

Jul 3 2018, 8:16 AM

Jun 20 2018

Eugene.Zelenko added inline comments to D43424: [clang-doc] Implement a (simple) Markdown generator.
Jun 20 2018, 1:44 PM · Restricted Project

May 23 2018

Eugene.Zelenko added a comment to D47157: Warning for framework headers using double quote includes.

Hi Eugene,

You could just not include new warning into -Wall and -Wextra. Those who will want to check #include statements correctness could enable it explicitly.

This is exactly what's happening in the patch, the new warning isn't part of -Wall or -Wextra, and is marked DefaultIgnore, which means that will fire only when -Wquoted-include-in-framework-header is passed to the driver. Am I missing something from your explanation?

Thanks,

May 23 2018, 5:05 PM

May 21 2018

Eugene.Zelenko added a comment to D47157: Warning for framework headers using double quote includes.

The warning is off by default.

We typically do not add off-by-default warnings because experience has shown the rarely get enabled in practice. Can you explain a bit more about why this one is off by default?

Right. I believe this is going to be used in practice, the reason I'm adding it involves some user demand for such warning. Such quoted include use in frameworks happen often and we would like a smooth transition to happen here (e.g. do not initially affect -Werror users). If it proves worth it, we can migrate to on by default in the future. It wouldn't be a problem if we have it on by default on open source and disable by default downstream, but I rather be consistent.

May 21 2018, 3:49 PM
Eugene.Zelenko added a comment to D47157: Warning for framework headers using double quote includes.

See also PR22165.

May 21 2018, 2:02 PM

May 8 2018

Eugene.Zelenko added a comment to D46602: [clang-tidy] Store checks profiling info as JSON files.

I think will be good idea to store data in JSON format too.

May 8 2018, 3:30 PM · Restricted Project
Eugene.Zelenko added inline comments to D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module.
May 8 2018, 2:30 PM · Restricted Project

May 6 2018

Eugene.Zelenko added inline comments to D46504: [clang-tidy] Profile is a per-AST (per-TU) data..
May 6 2018, 4:20 PM · Restricted Project

May 3 2018

Eugene.Zelenko added a comment to D46407: [tools] Introduce llvm-strip.

Will be good idea to add documentation and item in Release Notes.

May 3 2018, 3:41 PM
Eugene.Zelenko added a comment to D46378: Undef the macros after their use.

I don't see anything wrong with this change, but will be good idea to wait for code owner approval.

May 3 2018, 6:11 AM

May 2 2018

Eugene.Zelenko added inline comments to D45702: [clang-tidy] Add a new check, readability-simplify-subscript-expr, that simplifies subscript expressions..
May 2 2018, 6:24 AM · Restricted Project

May 1 2018

Eugene.Zelenko added reviewers for D46317: [clang-tidy] New check bugprone-map-subscript-operator-lookup: hokein, aaron.ballman, ilya-biryukov.
May 1 2018, 10:12 AM · Restricted Project