- User Since
- May 9 2013, 11:10 AM (258 w, 4 d)
Thu, Apr 19
Wed, Apr 18
Wed, Apr 11
Mon, Apr 9
Fri, Apr 6
I slightly changed some of the tests at r329403.
It should simplify the diff from your patch.
I think that (1) is as good as (2), because (2) will have to be something complex to handle all microarchitectures, so I'd rather leave this complexity to be dealt with by libpfm, which was designed for this very purpose.
I am a bit confused. Does it mean that exegesis will always have the dependency on libpfm (which means, it would only work on systems that provide it, for the cpus known by the installed lib version on the system)?
It does not *have to*, but until a better solution comes along, yes :) Just peeking at the tables in libpfm to abstract both OS and hardware really makes me want to not have to handle that !
I like this version of the script. The output is easier to read now that you removed all the needless tablegen variables with regexpr.
I don't have a strong opinion on which version to use for this script (whether python 2.7 or 3).
So, the script looks good to me.
Thu, Apr 5
I am going to fix it now.
I guess I should have used int64_t ...
Wed, Apr 4
Tue, Apr 3
Thu, Mar 29
It looks good to me.
About the bzhi/bextr change:
Your new patch looks good to me.
The btver2 change looks good to me. Thanks!
Wed, Mar 28
Mon, Mar 26
Mar 24 2018
Mar 23 2018
Mar 21 2018
Committed revision 328129.
Mar 20 2018
The changes to CodeGenSchedule.cpp looks good to me. I will let other people review the AArch64/ARM scheduling model changes.
P.s.: I also like the idea of having a warning (at least in debug mode) for when there is only one matching instruction.
Mar 19 2018
Addressed review comments.
Mar 16 2018
Forgot to add a string message to the new asserts.
Address review comments.
Mar 15 2018
Please let me know what you think.
Thanks for the feedback.
Mar 14 2018
Mar 13 2018
Mar 12 2018
Mar 10 2018
If this patch is to unbreak the buildbots, then I think you should just commit it.
We don't want to leave the buildbots in a failing state for too long.
Mar 9 2018
Mar 7 2018
Mar 6 2018
Mar 5 2018
Mar 2 2018
Patch updated. Addressed review comments from Brian.
Thanks Brian for the feedback!
Mar 1 2018
Nov 9 2017
I made a couple of (minor) comments below.
Nov 8 2017
Overall, the patch looks good to me.
I made some minor comments below.
Oct 23 2017
Oct 12 2017
Aug 29 2017
I noticed that you forgot to include llvm-commits as a subscriber.
May 12 2017
Thanks for fixing the issue with debug values.
May 11 2017
Currently, we set 'SawStore' if there is at least one 'mayStore' instruction in the scheduling region.
May 10 2017
May 9 2017
May 8 2017