This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] update zfh and zfhmin extention to v1.0
ClosedPublic

Authored by achieveartificialintelligence on Jan 12 2022, 2:13 AM.

Details

Diff Detail

Event Timeline

achieveartificialintelligence requested review of this revision.Jan 12 2022, 2:13 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 12 2022, 2:13 AM
craig.topper added inline comments.Jan 12 2022, 10:04 AM
clang/test/Preprocessor/riscv-target-features.c
230–231

If it's not experimental now, do you need -menable-experimental-extensions?

llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td
1

While you're in here can you fix this line by replacing 'FH' with 'Zfh'

achieveartificialintelligence marked 2 inline comments as done.

Address @craig.topper's comments

A new test inline-asm-zfh-constraint-f.ll was added today that needs it's RUN line updated.

clang/test/Preprocessor/riscv-target-features.c
230–231

Remove -menable-experimental-extensions

238

Remove -menable-experimental-extensions

llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td
1

RISCVInstrInfoFH.td should be RISCVInstrInfoZfh.td

achieveartificialintelligence marked 3 inline comments as done.

Address @craig.topper's comments

This revision is now accepted and ready to land.Jan 14 2022, 5:17 PM
This revision was landed with ongoing or failed builds.Jan 14 2022, 5:21 PM
This revision was automatically updated to reflect the committed changes.