This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Revert Zfhmin related changes that aren't tested and depend on f16 being a legal type.
ClosedPublic

Authored by craig.topper on Dec 15 2021, 12:11 PM.

Details

Summary

Our Zfhmin support is only MC layer, but these are CodeGen layer
interfaces. If f16 isn't a Legal type for CodeGen with Zfhmin, then
these interfaces should keep their non-Zfh behavior.

Diff Detail

Unit TestsFailed

Event Timeline

craig.topper created this revision.Dec 15 2021, 12:11 PM
craig.topper requested review of this revision.Dec 15 2021, 12:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2021, 12:11 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
craig.topper retitled this revision from [RISCV] Revert Zfhmin related changes that aren't tested and depended on f16 being a legal type. to [RISCV] Revert Zfhmin related changes that aren't tested and depend on f16 being a legal type..Dec 15 2021, 12:12 PM
asb added a comment.EditedDec 15 2021, 12:18 PM

Thanks Craig, My bad for missing/misunderstanding this in the review of the previous patch.

Could you please add a test (can be a dead simple non-exhaustive one) that would show the change in behaviour?

Added test for the calling convention change. FPImmLegal will require more investigation of DAG combiners to see if it is even possible to hit.

craig.topper added inline comments.Dec 15 2021, 12:57 PM
llvm/test/CodeGen/RISCV/calling-conv-half.ll
118

Prior to this patch, we would pass in a GPR instead of FPR.

luismarques accepted this revision.Dec 16 2021, 7:30 AM

Thanks!

This revision is now accepted and ready to land.Dec 16 2021, 7:30 AM
This revision was landed with ongoing or failed builds.Dec 16 2021, 8:56 AM
This revision was automatically updated to reflect the committed changes.