This is an archive of the discontinued LLVM Phabricator instance.

Adjust "end namespace" comment in MLIR to match new agree'd coding style
ClosedPublic

Authored by mehdi_amini on Dec 7 2021, 5:04 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 7 2021, 5:04 PM
mehdi_amini requested review of this revision.Dec 7 2021, 5:04 PM
rriddle accepted this revision.Dec 7 2021, 10:03 PM

LGTM, though a few have trailing periods that we should also drop

mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp
269

Can we trim the trailing period on all of these?

mlir/lib/Dialect/Affine/IR/AffineOps.cpp
2037

same here

mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
194

same

mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
317

same here and a few others

This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2021, 10:05 PM
This revision was automatically updated to reflect the committed changes.

LGTM, though a few have trailing periods that we should also drop

Fixed these before pushing