User Details
- User Since
- Apr 29 2021, 6:43 AM (99 w, 3 d)
Wed, Mar 1
Oct 4 2022
Sep 14 2022
OK, LGTM then
Sep 10 2022
Could you pls specify a list of these small bug fixes, at the very high level at least? An ideal variant would be to not mix them up with this regularization stuff at all.
Aug 31 2022
Aug 30 2022
- clang-format
Aug 28 2022
- Address comments
Aug 27 2022
Aug 12 2022
LGTM regarding removal of unrelated SPIR-V code
Aug 11 2022
Jul 21 2022
To me it seems as an unnecessarily huge change. Can't it be split, at least keep PrepareFunctions and other minor changes separate?
Jul 7 2022
Jul 2 2022
@iliya-diyachkov FYI there're 6 more passing tests which are not upstreamed yet, but I've not added them here since they're irrelevant to the current changes
- Fix potential failure, add 2 newly passed LITs
Restore
Fix potential failure, add 2 newly passed LITs
Jun 23 2022
May 17 2022
LGTM
May 16 2022
May 11 2022
To me this subset of tests looks very counter-intuitive, I'd strongly prefer to have LITs related commits formed by some tests' common properties, e.g. '[SPIR-V] Add simple transcoding tests'. What was your motivation behind this particular subset, are these the only tests currently passing?
Apr 20 2022
Feb 14 2022
Feb 9 2022
Feb 8 2022
Feb 3 2022
Feb 2 2022
Jan 11 2022
Jan 10 2022
Dec 31 2021
Iliya, since this is the 3rd patch of a total of 6, do I understand
correctly that the second one is https://reviews.llvm.org/D115786 from
Michal?
Sep 21 2021
Ping
Sep 17 2021
Someone pls commit this, I don't have an access
Sep 15 2021
Rebased, added a test.
Sep 2 2021
Aug 26 2021
Can someone pls commit this? I don't have an access to do that myself
Gentle ping
Aug 25 2021
Fix clang-tidy warning
Aug 20 2021
Aug 19 2021
Jul 13 2021
Let me explain my problem with a short example. Assume we have the following IR:
Jul 8 2021
@qcolombet @arsenm @foad this change is already abandoned, but my question seems directly related to it.
May 21 2021
May 19 2021
May 18 2021
May 17 2021
@aemerson @foad if no one has any idea how to make CRTP approach feasible here, then I'd suggest to merge this, I have no write access though
May 13 2021
May 11 2021
May 7 2021
Gentle ping
Apr 29 2021
Rebased