Page MenuHomePhabricator

carlosgalvezp (Carlos Galvez)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 22 2021, 11:35 PM (61 w, 3 d)

Recent Activity

Thu, Nov 24

carlosgalvezp added a comment to D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Another week, another ping @njames93 @aaron.ballman

Thu, Nov 24, 4:10 AM · Restricted Project, Restricted Project

Thu, Nov 17

carlosgalvezp added a comment to D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

@njames93 Ping again. Alternatively, could someone else review? @aaron.ballman maybe?

Thu, Nov 17, 5:52 AM · Restricted Project, Restricted Project

Thu, Nov 10

carlosgalvezp added a comment to D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

@njames93 Friendly ping

Thu, Nov 10, 7:42 AM · Restricted Project, Restricted Project

Sun, Nov 6

carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Simplify code for printing the type of the declaration.

Sun, Nov 6, 4:11 AM · Restricted Project, Restricted Project

Fri, Nov 4

carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Fix typo in binding names

Fri, Nov 4, 6:28 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Remove some code duplication

Fri, Nov 4, 6:14 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Update commit message

Fri, Nov 4, 1:31 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Move to misc

Fri, Nov 4, 1:30 AM · Restricted Project, Restricted Project

Thu, Nov 3

carlosgalvezp added a comment to D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

I'm not entirely sure why this belongs in the modernize module given anonymous namespaces have been in c++ forever, maybe its more of a misc check? Also the modernize checks are meant to actually emit fixes(ignore the c arrays check :) ), Right now, this only warn, it doesn't appear to act

Thu, Nov 3, 2:02 PM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Address review comments.

Thu, Nov 3, 11:51 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Add reference to undeprecation of static.

Thu, Nov 3, 8:13 AM · Restricted Project, Restricted Project
carlosgalvezp added reviewers for D137340: [clang-tidy] Add misc-use-anonymous-namespace check: njames93, Eugene.Zelenko.
Thu, Nov 3, 8:05 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D137340: [clang-tidy] Add misc-use-anonymous-namespace check.

Fix release notes.

Thu, Nov 3, 8:03 AM · Restricted Project, Restricted Project
carlosgalvezp requested review of D137340: [clang-tidy] Add misc-use-anonymous-namespace check.
Thu, Nov 3, 8:00 AM · Restricted Project, Restricted Project

Oct 10 2022

carlosgalvezp committed rG1ae33bf42680: [clang-tidy] Add cppcoreguidelines-avoid-do-while check (authored by carlosgalvezp).
[clang-tidy] Add cppcoreguidelines-avoid-do-while check
Oct 10 2022, 12:30 AM · Restricted Project, Restricted Project
carlosgalvezp closed D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.
Oct 10 2022, 12:30 AM · Restricted Project, Restricted Project

Oct 4 2022

carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

@njames93 Ping

Oct 4 2022, 5:14 AM · Restricted Project, Restricted Project

Sep 15 2022

carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

@njames93 Friendly ping. The patch has addressed all comments and remained unchanged for 2 weeks. I would like to land it latest next week. If you are happy with the patch, please accept the review. Alternatively, please let me know if you intend to continue reviewing.

I do intend, but I'm currently between 2 jobs and accommodation atm, once life settles down next week, I should have more time.

Sep 15 2022, 11:43 PM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Adjust warning message for consistency.

Sep 15 2022, 8:12 AM · Restricted Project, Restricted Project

Sep 11 2022

carlosgalvezp added a reviewer for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check: bigdavedev.
Sep 11 2022, 11:40 PM · Restricted Project, Restricted Project

Sep 6 2022

carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

@njames93 Friendly ping. The patch has addressed all comments and remained unchanged for 2 weeks. I would like to land it latest next week. If you are happy with the patch, please accept the review. Alternatively, please let me know if you intend to continue reviewing.

Sep 6 2022, 11:38 PM · Restricted Project, Restricted Project

Aug 31 2022

carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

@njames93 Is there anything else I should address?

Aug 31 2022, 2:56 AM · Restricted Project, Restricted Project

Aug 25 2022

carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Rename option to IgnoreMacros and update logic and tests.

Aug 25 2022, 11:41 PM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

The AllowWhileFlase option seems the wrong way to go about silencing do while(false) macros. Would it not make more sense to just ignore macros, or if you want more specificty don't warn on macros with a false condition?

Strictly speaking, the C++ Core Guidelines do not make any such exception for macros. That's why I thought an option would allow both users who want to comply strictly, and users who want a bit more flexibility (without having to NOLINT their way out of it). Similar options exist for other C++ Core Guidelines checks.

Aug 25 2022, 11:22 PM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

The AllowWhileFlase option seems the wrong way to go about silencing do while(false) macros. Would it not make more sense to just ignore macros, or if you want more specificty don't warn on macros with a false condition?

Aug 25 2022, 6:30 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Add a couple more tests.

Aug 25 2022, 5:16 AM · Restricted Project, Restricted Project

Aug 23 2022

carlosgalvezp added inline comments to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.
Aug 23 2022, 7:47 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

PS: @aaron.ballman I didn't add you as reviewer since you have expressed in the past that you'd prefer not to review C++ Core Guidelines patches. Let me know if that has changed :)

Aug 23 2022, 7:46 AM · Restricted Project, Restricted Project
carlosgalvezp added inline comments to D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.
Aug 23 2022, 7:44 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Address comments

Aug 23 2022, 7:44 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Fix typo

Aug 23 2022, 4:45 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Add check to list of checks.

Aug 23 2022, 4:37 AM · Restricted Project, Restricted Project
carlosgalvezp added reviewers for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check: njames93, alexfh, LegalizeAdulthood.
Aug 23 2022, 4:36 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Document default value

Aug 23 2022, 4:35 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.

Fix typo

Aug 23 2022, 4:34 AM · Restricted Project, Restricted Project
carlosgalvezp requested review of D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check.
Aug 23 2022, 4:30 AM · Restricted Project, Restricted Project

Aug 19 2022

carlosgalvezp added a comment to D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.

Thanks for the review!

Aug 19 2022, 1:28 AM · Restricted Project, Restricted Project
carlosgalvezp committed rG3fd4213059a4: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members… (authored by carlosgalvezp).
[clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members…
Aug 19 2022, 1:27 AM · Restricted Project, Restricted Project
carlosgalvezp closed D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.
Aug 19 2022, 1:27 AM · Restricted Project, Restricted Project

Aug 17 2022

carlosgalvezp updated the diff for D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.

Fix typo

Aug 17 2022, 11:39 PM · Restricted Project, Restricted Project
carlosgalvezp added inline comments to D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.
Aug 17 2022, 11:38 PM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.

Update implicit lambda captures to use the captured variables
inside the lambdas.

Aug 17 2022, 11:37 PM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.

Added unit test for implicit capture (ref and value)

Aug 17 2022, 7:02 AM · Restricted Project, Restricted Project

Aug 15 2022

carlosgalvezp added a comment to D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`.

but removing those options can break people's .clang-tidy config files

Aren't there deprecation mechanisms? I think trying to be backwards compatible across all possible versions can lead to suboptimal solutions and make the tool harder to use and hard/slow to adapt to the needs of the community.

Nothing stops us from deprecating config options with some nice diagnostic behavior, but again, this pushes the work off onto the user to maintain their scripts and gives them an inconsistent interface to clang-tidy where some checks get formatting options and other checks do not.

Aug 15 2022, 8:07 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D131386: [clang-tidy] Added `ConstAlignment` option to `misc-const-correctness`.

but removing those options can break people's .clang-tidy config files

Aug 15 2022, 7:42 AM · Restricted Project, Restricted Project

Aug 13 2022

carlosgalvezp updated the diff for D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.

Test also capture by reference.

Aug 13 2022, 1:22 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.

Please mention changes in Release Notes.

Aug 13 2022, 1:10 AM · Restricted Project, Restricted Project

Aug 12 2022

carlosgalvezp requested review of D131780: [clang-tidy] Do not trigger cppcoreguidelines-avoid-const-or-ref-data-members on lambda captures.
Aug 12 2022, 7:56 AM · Restricted Project, Restricted Project

Aug 11 2022

carlosgalvezp added a comment to D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning).

Hi @carlosgalvezp
Yes, sorry, maybe screenshot and example from issue in our bugtracker is not the best one.
You can check it on this sample from clang-tidy tests:
The "hicpp-signed-bitwise" will point to

URes = UValue & -1;

[UValue] instead of -1, which looks confusing.

Aug 11 2022, 11:09 PM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning).

On the other hand, if the 0xFF becomes 0xFFu, then Clang performs an integer promotion to unsigned int instead of int, and that's why clang-tidy no longer complains.

Aug 11 2022, 7:43 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D131678: hicpp-signed-bitwise - Return location of the operand (and not of the operator beginning).

I looked at the screenshot in the link you posted. What is the type of value?

Aug 11 2022, 7:40 AM · Restricted Project, Restricted Project
carlosgalvezp committed rG9ae5896d9673: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check (authored by carlosgalvezp).
[clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check
Aug 11 2022, 1:33 AM · Restricted Project, Restricted Project
carlosgalvezp closed D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Aug 11 2022, 1:33 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Rebase

Aug 11 2022, 1:17 AM · Restricted Project, Restricted Project

Aug 8 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

@njames93 Friendly ping.

Aug 8 2022, 12:19 AM · Restricted Project, Restricted Project

Aug 1 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

@njames93 I've updated the patch with extra type information, let me know if you think it's good enough!

Aug 1 2022, 2:19 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
  • Display type information in the diagnostic.
  • Rebase onto latest main.
Aug 1 2022, 2:18 AM · Restricted Project, Restricted Project

Jul 28 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Great feedback, thanks! I had some ideas on how to go around the issues, looking forward to your thoughts.

Jul 28 2022, 10:09 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

@njames93 Would you mind reviewing? Thanks!

Jul 28 2022, 6:44 AM · Restricted Project, Restricted Project
carlosgalvezp added a reviewer for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check: njames93.
Jul 28 2022, 6:44 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Rebase onto latest main.

Jul 28 2022, 6:43 AM · Restricted Project, Restricted Project

Jul 20 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Ping to reviewers

Jul 20 2022, 11:12 PM · Restricted Project, Restricted Project

Jul 14 2022

carlosgalvezp edited reviewers for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check, added: dfrib, bigdavedev; removed: aaron.ballman, alexfh, njames93, Eugene.Zelenko.
Jul 14 2022, 6:32 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jul 14 2022, 6:30 AM · Restricted Project, Restricted Project

Jul 10 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

@LegalizeAdulthood I've addressed your comments, is there anything else that should be fixed before landing the patch?

Jul 10 2022, 7:01 AM · Restricted Project, Restricted Project

Jul 4 2022

Herald added a reviewer for D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables: NoQ.
Jul 4 2022, 1:20 AM · Restricted Project, Restricted Project, Restricted Project

Jul 3 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

@LegalizeAdulthood Thanks for the review! I've now rebased and addressed your comments. I've also verify the docs with the command you suggested, I was missing -DLLVM_ENABLE_SPHINX in the cmake command.

Jul 3 2022, 11:51 PM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Address review comments.

Jul 3 2022, 11:50 PM · Restricted Project, Restricted Project

Jul 1 2022

Herald added a project to D30538: Add documentation for -fno-strict-aliasing: Restricted Project.

Hi, is this commit still valid? Why hasn't it been pushed?

Jul 1 2022, 12:44 AM · Restricted Project

Jun 25 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

@LegalizeAdulthood I've addressed your comments, thanks for the clear instructions! One thing I didn't manage to do is build the target docs-clang-tools-html, it says it doesn't exist. I've enabled LLVM_BUILD_DOCS=ON in the CMake call - do you know if I need to enable something else?

Jun 25 2022, 4:55 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Fix test name

Jun 25 2022, 4:53 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Rebase and fix directory structure for doc and test.

Jun 25 2022, 4:50 AM · Restricted Project, Restricted Project

Jun 16 2022

carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Kind ping to reviewers :)

Jun 16 2022, 2:33 AM · Restricted Project, Restricted Project

Jun 9 2022

carlosgalvezp added a comment to D127446: [clang-tidy] Add `-verify-config` command line argument.

This sounds like great functionality, surely saving a lot of headaches! Any reason why we wouldn't want this active by default? I'd personally even go one step further and make it hard errors - warnings are easy to miss and ignore - but I can see how it can be problematic for some people.

Jun 9 2022, 11:20 PM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Remove copy-paste comment

Jun 9 2022, 2:58 AM · Restricted Project, Restricted Project
carlosgalvezp added inline comments to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jun 9 2022, 2:54 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Address review comments.
Rebase on latest main.

Jun 9 2022, 2:53 AM · Restricted Project, Restricted Project

Jun 8 2022

carlosgalvezp added a reviewer for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check: Eugene.Zelenko.
Jun 8 2022, 7:05 AM · Restricted Project, Restricted Project

Jun 3 2022

carlosgalvezp added a reviewer for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check: njames93.
Jun 3 2022, 4:43 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jun 3 2022, 2:39 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Fix review comments

Jun 3 2022, 2:39 AM · Restricted Project, Restricted Project
carlosgalvezp added inline comments to D126891: [clang-tidy] The check should ignore final classes.
Jun 3 2022, 1:19 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D126891: [clang-tidy] The check should ignore final classes.

Oh, I see the unit test now, indeed Base does not have a virtual destructor. LGTM then!

Jun 3 2022, 1:18 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D126891: [clang-tidy] The check should ignore final classes.

Hmm, MostDerived does have a public virtual destructor in your example already - if the base class destructor is virtual, the child class destructor is virtual. In that sense the check should not warn.

Seems like there's some deeper problem in the check?

Not quite. None of the destructors are virtual in the example. In fact, the MostDerived has a public and non-virtual destructor.

Jun 3 2022, 1:15 AM · Restricted Project, Restricted Project

Jun 2 2022

carlosgalvezp added a comment to D126891: [clang-tidy] The check should ignore final classes.

Hmm, MostDerived does have a public virtual destructor in your example already - if the base class destructor is virtual, the child class destructor is virtual. In that sense the check should not warn.

Jun 2 2022, 11:32 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Move logic from check to registerMatchers

Jun 2 2022, 8:07 AM · Restricted Project, Restricted Project
carlosgalvezp added a reviewer for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check: alexfh.
Jun 2 2022, 7:32 AM · Restricted Project, Restricted Project
carlosgalvezp added reviewers for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check: aaron.ballman, LegalizeAdulthood.
Jun 2 2022, 7:32 AM · Restricted Project, Restricted Project
carlosgalvezp updated the diff for D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.

Fix FIXME

Jun 2 2022, 7:29 AM · Restricted Project, Restricted Project
carlosgalvezp requested review of D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check.
Jun 2 2022, 7:27 AM · Restricted Project, Restricted Project

Feb 20 2022

carlosgalvezp added a comment to D117522: [clang-tidy] Add modernize-macro-to-enum check.

I tried to download the diff and apply it from the root of llvm-project, but I must be doing something wrong...

Feb 20 2022, 3:03 AM · Restricted Project, Restricted Project
carlosgalvezp added a comment to D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h.

Was there any real use case for making this polymorphic, The overhead for a virtual function call seems a little unnecessary IMO?

Feb 20 2022, 2:21 AM · Restricted Project

Feb 18 2022

carlosgalvezp abandoned D112730: [clang-tidy] Add AUTOSAR module.

Understood, thanks a lot for the clarification and for the time taken!

Feb 18 2022, 10:54 AM · Restricted Project

Feb 14 2022

carlosgalvezp added a comment to D112730: [clang-tidy] Add AUTOSAR module.

Thanks a lot @tonic for your update and for the work done in the last months ! It's indeed very sad to hear the news. It's a pity that the work will probably be duplicated in many local forks with sub-optimal solutions instead of a centralized, high-quality, peer-reviewed open-source solution.

I'm not very familiar with the terms so I'm not sure I fully understand the reasons why we are advised not to proceed. Could you clarify/elaborate on what it means "the exact patent burden is not disclosed"? I was hoping that the written consent we got from AUTOSAR would be a strong basis to move forward.

Feb 14 2022, 12:36 AM · Restricted Project

Feb 12 2022

carlosgalvezp added a comment to D112730: [clang-tidy] Add AUTOSAR module.

Thanks a lot @tonic for your update and for the work done in the last months ! It's indeed very sad to hear the news. It's a pity that the work will probably be duplicated in many local forks with sub-optimal solutions instead of a centralized, high-quality, peer-reviewed open-source solution.

Feb 12 2022, 1:54 AM · Restricted Project

Feb 6 2022

carlosgalvezp added a comment to D117522: [clang-tidy] Add modernize-macro-to-enum check.

Ok, thanks for the explanation! I'm mostly interested on the warning message, we've had situations before where the warning describes the problem and the solution, which can easily lead to confusion. From the tests I can see the message is quite generic "use an enum", so it won't push users to prefer one variant over the other.

Feb 6 2022, 9:12 AM · Restricted Project, Restricted Project

Feb 2 2022

carlosgalvezp added a comment to D117522: [clang-tidy] Add modernize-macro-to-enum check.

Since this is a modernize check, shouldn't it be proposing to use enum class instead of enum? This will conflict with Enum.3 from cppcoreguidelines, and I don't think it's unreasonable that people enable both modernize* and cppcoreguidelines*. Not sure if such a check for Enum.3 exists today but it could easily be added in the future.

Feb 2 2022, 8:05 AM · Restricted Project, Restricted Project

Jan 28 2022

carlosgalvezp added a comment to D118104: Make run-clang-tidy.py print the configured checks correctly.

Anyone have an idea why it's still building?

Jan 28 2022, 12:34 AM · Restricted Project

Jan 26 2022

carlosgalvezp added inline comments to D118104: Make run-clang-tidy.py print the configured checks correctly.
Jan 26 2022, 3:20 PM · Restricted Project
carlosgalvezp added a comment to D118104: Make run-clang-tidy.py print the configured checks correctly.

Perhaps the patch was applied on a too old baseline, could you try rebasing on top of latest main?

Jan 26 2022, 7:27 AM · Restricted Project