This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Bump rvv-related extensions from 0.10 to 1.0
ClosedPublic

Authored by eopXD on Nov 2 2021, 12:09 AM.

Diff Detail

Event Timeline

eopXD created this revision.Nov 2 2021, 12:09 AM
eopXD requested review of this revision.Nov 2 2021, 12:09 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 2 2021, 12:09 AM
eopXD updated this revision to Diff 383987.Nov 2 2021, 12:13 AM

Rebase.

ego added a subscriber: ego.Dec 9 2021, 8:59 AM
eopXD updated this revision to Diff 401546.Jan 20 2022, 1:28 AM

Rebase.

eopXD updated this revision to Diff 401564.Jan 20 2022, 2:24 AM

Update code.

If we're bumping it to 1.0, does that mean it's no longer "experimental"?

asb added a comment.Jan 20 2022, 5:42 AM

If we're bumping it to 1.0, does that mean it's no longer "experimental"?

Whether RVV is non-experimental or not is the big open question for 14.0. I've put it on the agenda for today's sync call.

craig.topper accepted this revision.Jan 20 2022, 10:10 AM

LGTM

clang/test/Preprocessor/riscv-target-features.c
220

Does this line pass even if you don't change it since we don't match to the end of the line? I might suggest we go through this file and put {{{$}} on the end of lines, but that can be a separate change. Or we add the #define to each line and pass --match-full-lines to FileCheck.

This revision is now accepted and ready to land.Jan 20 2022, 10:10 AM
eopXD marked an inline comment as done.Jan 20 2022, 10:37 AM
eopXD added inline comments.
clang/test/Preprocessor/riscv-target-features.c
220

Created D117808

eopXD updated this revision to Diff 401700.Jan 20 2022, 10:52 AM
eopXD marked an inline comment as done.

Rebase.

eopXD updated this revision to Diff 401861.Jan 20 2022, 10:10 PM

Rebase.
Resolve conflict due to zvlsseg removal.

This revision was automatically updated to reflect the committed changes.