According to v-spec v1.0, zve-32x is the new minimum extension to include
to have vector instructions.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
The title of this patch isn't descriptive of the changes in this patch. Based on the title I would only expect changes to RISCVEmitter.cpp. Can you clarify the title?
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c | ||
---|---|---|
3 ↗ | (On Diff #383983) | Why do we need to add zve32x and zve64x to the command line? Doesn't zve64x imply zve32x? |
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vaadd.c | ||
---|---|---|
3 ↗ | (On Diff #383983) | Rebased. |
Comment Actions
LGTM but I don't have full scope on the builtins side of things. I'd also add a missing word to the title: "Change TARGET_BUILTIN to require ..."