[RISCV] Optimize vp.store with an all ones mask to avoid a vmset.
ClosedPublic
Actions

Authored by craig.topper on Sep 21 2021, 3:55 PM.

Details

Reviewers

Commits

rGb33a1cc05b48: [RISCV] Optimize vp.store with an all ones mask to avoid a vmset.

Summary

We can use riscv_vse intrinsic instead of riscv_vse_mask. The code here
is based on similar code for handling masked.scatter and vp.scatter.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

craig.topper created this revision.Sep 21 2021, 3:55 PM

Herald added subscribers: vkmr, evandro, luismarques and 24 others. · View Herald TranscriptSep 21 2021, 3:55 PM

craig.topper requested review of this revision.Sep 21 2021, 3:55 PM

Herald added a project: Restricted Project. · View Herald TranscriptSep 21 2021, 3:55 PM

Herald added a subscriber: MaskRay. · View Herald Transcript

Add fixed vector test.

Harbormaster completed remote builds in B125007: Diff 374062.Sep 21 2021, 4:21 PM

craig.topper added a child revision: D109482: [RISCV] Fold store of vmv.x.s to a vse with VL=1..Sep 21 2021, 4:45 PM

LGTM. Good spot, sorry for missing that originally.

This revision is now accepted and ready to land.Sep 22 2021, 1:43 AM

This revision was landed with ongoing or failed builds.Sep 22 2021, 9:21 AM

Closed by commit rGb33a1cc05b48: [RISCV] Optimize vp.store with an all ones mask to avoid a vmset. (authored by craig.topper). · Explain Why

This revision was automatically updated to reflect the committed changes.

craig.topper added a commit: rGb33a1cc05b48: [RISCV] Optimize vp.store with an all ones mask to avoid a vmset..

frasercrmck mentioned this in D113022: [RISCV] Optimize vp.load with an all-ones mask.Nov 2 2021, 7:54 AM

frasercrmck mentioned this in rGd065b03801d9: [RISCV] Optimize vp.load with an all-ones mask.Nov 2 2021, 10:32 AM

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Target/

RISCV/

RISCVISelLowering.cpp

24 lines

test/

CodeGen/

RISCV/

rvv/

vpstore.ll

12 lines

Diff 374061

View Options

llvm/lib/Target/RISCV/RISCVISelLowering.cpp