This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Rename prefix `FeatureExt*` to `FeatureStdExt*` for all sub-extension

Authored by Jim on Aug 16 2021, 11:02 PM.



Rename prefix FeatureExt* to FeatureStdExt* for all sub-extension for consistency

Diff Detail

Event Timeline

Jim created this revision.Aug 16 2021, 11:02 PM
Jim requested review of this revision.Aug 16 2021, 11:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2021, 11:02 PM
asb accepted this revision.Aug 19 2021, 4:51 AM

I'd block on comment from one of the other reviewers who have been active with RVV, but unless I'm missing something this makes a lot of sense to me.

This revision is now accepted and ready to land.Aug 19 2021, 4:51 AM
craig.topper added inline comments.Aug 19 2021, 8:38 AM

This patch makes things consistent, but I'm not sure why the bools in RISCVSubtarget.h have "Std" in their name.

Jim marked an inline comment as done.Aug 19 2021, 7:12 PM
Jim added inline comments.

The bools have prefix hasStdExt*. All of sub-extensions are all the same.
Or the SubtargetFeatures should be fixed to have prefix FeatureStdExt* for all of sub-extension.

HsiangKai added inline comments.Aug 24 2021, 4:46 AM

I prefer to make it consistent for subtarget features. To add all "Std", include sub-extensions.

Jim updated this revision to Diff 369391.Aug 30 2021, 1:07 AM
Jim marked an inline comment as done.

Add "Std" for all sub-extensions.

Jim retitled this revision from [RISCV] Rename FeatureStdExtZvlsseg to FeatureExtZvlsseg to [RISCV] Rename prefix `FeatureExt*` to `FeatureStdExt*` for all sub-extension.Aug 30 2021, 1:19 AM
Jim edited the summary of this revision. (Show Details)
asb added a comment.Sep 2 2021, 1:48 AM

I've got no objections to this mass rename - anyone else have views?

Sorry for late reply. It looks good to me. Thanks, @Jim.

HsiangKai accepted this revision.Sep 12 2021, 9:02 PM
This revision was landed with ongoing or failed builds.Sep 13 2021, 1:23 AM
This revision was automatically updated to reflect the committed changes.