This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility
ClosedPublic

Authored by NeHuang on Jul 14 2021, 2:41 PM.

Details

Summary

This patch is in a series of patches to provide builtins for compatibility
with the XL compiler. This patch adds the builtins and instrisics for population
count, reversed load and store related operations.

Diff Detail

Event Timeline

NeHuang created this revision.Jul 14 2021, 2:41 PM
NeHuang requested review of this revision.Jul 14 2021, 2:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2021, 2:41 PM
nemanjai accepted this revision.Jul 15 2021, 1:42 PM

LGTM as long as the redundant clear is removed.

clang/lib/CodeGen/CGBuiltin.cpp
15098

Isn't this just Ops[0]?

llvm/lib/Target/PowerPC/PPCInstrInfo.td
5276

The clear is redundant. Why do we need to clear the bits that we won't store to begin with?

This revision is now accepted and ready to land.Jul 15 2021, 1:42 PM
This revision was landed with ongoing or failed builds.Jul 15 2021, 3:24 PM
This revision was automatically updated to reflect the committed changes.
NeHuang marked an inline comment as done.