Page MenuHomePhabricator

[RISCV] Fix StackOffset calculation when using sp to access the fixed stack object in the case of rvv vector objects existed
ClosedPublic

Authored by StephenFan on Sun, Apr 11, 10:43 PM.

Details

Summary

When rvv vector objects existed, using sp to access the fixed stack object will pass the rvv vector objects field. So the StackOffset needs add a scalable offset of the size of rvv vector objects field

Diff Detail

Event Timeline

StephenFan created this revision.Sun, Apr 11, 10:43 PM
StephenFan requested review of this revision.Sun, Apr 11, 10:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Apr 11, 10:43 PM

I think this makes sense to me but I'm not sure I'd give approval alone.

I think this makes sense to me but I'm not sure I'd give approval alone.

Thanks, @frasercrmck . Then let me wait for other reviewers.

HsiangKai accepted this revision.Mon, Apr 26, 6:52 PM

LGTM. Before landing, you need to rebase and update your test case.

This revision is now accepted and ready to land.Mon, Apr 26, 6:52 PM
This revision was landed with ongoing or failed builds.Thu, Apr 29, 8:03 PM
This revision was automatically updated to reflect the committed changes.