This is an archive of the discontinued LLVM Phabricator instance.

Differential D99757

[flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region
ClosedPublic

Authored by arnamoy10 on Apr 1 2021, 11:39 AM.

Details

Reviewers
kiranchandramohan
bryanpkc
SouraVX
clementval
kiranktp
AMDChirag
sscalpone
jdoerfert
Commits
rGa40b60995882: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a…
Summary

This patch adds the semantic check for occurrence of constructs nested inside a SIMD region.

To make the test generalized for multiple constructs, to avoid repeats, the check is done while Enter()-ing the top level OpenMPConstruct

Also adds a test case.

It also modifies an existing test case for nested ordered clause check because with the current check introduced, the previous test shows two sema check failures instead of one.

PS: The check is currently supporting SIMD loops, but not declare SIMD directive.

Diff Detail

Event Timeline

arnamoy10 created this revision.Apr 1 2021, 11:39 AM
Herald added a reviewer: sscalpone. · View Herald TranscriptApr 1 2021, 11:39 AM
Herald added subscribers: jdoerfert, jfb, guansong, yaxunl. · View Herald Transcript
arnamoy10 requested review of this revision.Apr 1 2021, 11:39 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptApr 1 2021, 11:39 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, sstefan1. · View Herald Transcript
arnamoy10 edited the summary of this revision. (Show Details)Apr 1 2021, 11:40 AM
Harbormaster completed remote builds in B96778: Diff 334782.Apr 1 2021, 12:36 PM
clementval added inline comments.Apr 1 2021, 8:39 PM
flang/lib/Semantics/check-omp-structure.cpp
150

It is also considered nested is it's bigger than 1. So it should be >= 1?

270

Apply clang-format please.

arnamoy10 updated this revision to Diff 335241.Apr 5 2021, 6:06 AM
  1. Modifying the if-check to trigger the test.
  2. Clang-formatting.
Harbormaster completed remote builds in B97114: Diff 335241.Apr 5 2021, 6:46 AM
kiranchandramohan added inline comments.Apr 5 2021, 7:35 AM
flang/lib/Semantics/check-omp-structure.cpp
267

Nit: use braced initializers.

flang/test/Semantics/omp-nested-simd.f90
75

Which revision of the standard are you following here?

4.5:
An ordered construct with the simd clause is the only OpenMP construct that can be encountered during execution of a simd region.

5.0, 5.1:
The only OpenMP constructs that can be encountered during execution of a simd region are the atomic construct, the loop construct, the simd construct and the ordered construct with the simd clause.

arnamoy10 updated this revision to Diff 336507.Apr 9 2021, 10:06 AM

Updating the checks (and test cases) to be compliant with the 5.0/5.1 standard.

arnamoy10 added inline comments.Apr 9 2021, 10:07 AM
flang/test/Semantics/omp-nested-simd.f90
75

Thanks for the comment. Initially the check I implemented was based on gfortran (latest) error messages. I updated the checks to reflect the OpenMP 5.0/5.1 standard.

Harbormaster completed remote builds in B98029: Diff 336507.Apr 9 2021, 10:57 AM
kiranchandramohan added inline comments.Apr 11 2021, 3:10 PM
flang/lib/Semantics/check-omp-structure.cpp
151

Can you check for the SIMD construct before calling this function?

272

Nit: use braced initializer.

273

Will simd be always the parent construct? Are there cases where it can become an ancestor but not the immediate parent?

kiranchandramohan requested changes to this revision.Apr 11 2021, 4:16 PM
This revision now requires changes to proceed.Apr 11 2021, 4:16 PM
arnamoy10 updated this revision to Diff 337542.Apr 14 2021, 1:46 PM

Addressing review comment to check for SIMD construct in the whole context chain instead of only searching at the immediate parent level.

Also added a test accordingly.

Harbormaster completed remote builds in B98753: Diff 337542.Apr 14 2021, 3:00 PM
kiranchandramohan requested changes to this revision.Apr 25 2021, 7:05 AM

Have a question here.

flang/lib/Semantics/check-omp-structure.cpp
262

Nit: A TODO for the loop construct.

280

Here ordered is a block-directive. But below it is a standalone directive. Is it parsed both ways?

294

Here ordered is a standalone directive. See above.

This revision now requires changes to proceed.Apr 25 2021, 7:05 AM
arnamoy10 updated this revision to Diff 341246.Apr 28 2021, 9:46 AM

Small change in function docstring as per reviewers suggestion.

flang/lib/Semantics/check-omp-structure.cpp
262

Thanks, added.

280

Yes, according to here,

If the depend clause is specified, the ordered construct is a stand-alone directive.
Harbormaster completed remote builds in B101450: Diff 341246.Apr 28 2021, 11:34 AM
kiranchandramohan accepted this revision.Apr 29 2021, 4:12 PM

LGTM. I have a Nit comment about a counter. Leaving the decision to you on whether to consider it or not.

flang/lib/Semantics/check-directive-structure.h
224 ↗(On Diff #341246)

Nit: gven -> given

flang/lib/Semantics/check-omp-structure.cpp
151

Nit: Would it be better to keep a counter which counts the constructs in the simdSet? The counter can be incremented on Entering a simdSet construct and decremented on leaving. If counter is greater than 1 then FindDirInWholeContext is true. This way we avoid going through all the entries in dirContext_ everytime we see a construct.

270

Nit: not -> note

This revision is now accepted and ready to land.Apr 29 2021, 4:12 PM
arnamoy10 updated this revision to Diff 343150.May 5 2021, 12:49 PM

Using a variable to identify SIMD nesting as per suggestion to avoid expensive traversals.

flang/lib/Semantics/check-omp-structure.cpp
151

Thanks for the suggestion. Updated

Harbormaster completed remote builds in B102822: Diff 343150.May 5 2021, 1:31 PM
kiranchandramohan accepted this revision.May 5 2021, 2:45 PM

LGTM.

flang/lib/Semantics/check-directive-structure.h
323 ↗(On Diff #343150)

Nit: Braced initialization.

Closed by commit rGa40b60995882: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a… (authored by arnamoy10). · Explain WhyMay 6 2021, 12:08 PM
This revision was automatically updated to reflect the committed changes.
arnamoy10 added a commit: rGa40b60995882: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a….

Revision Contents

PathSize
flang/
lib/
Semantics/
1 line
48 lines
test/
Semantics/
206 lines
11 lines

Diff 335241

flang/lib/Semantics/check-omp-structure.h

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesprivate:
void SetLoopInfo(const parser::OpenMPLoopConstruct &x); void SetLoopInfo(const parser::OpenMPLoopConstruct &x);
void CheckIsLoopIvPartOfClause( void CheckIsLoopIvPartOfClause(
llvmOmpClause clause, const parser::OmpObjectList &ompObjectList); llvmOmpClause clause, const parser::OmpObjectList &ompObjectList);
void CheckWorkshareBlockStmts(const parser::Block &, parser::CharBlock); void CheckWorkshareBlockStmts(const parser::Block &, parser::CharBlock);
void CheckLoopItrVariableIsInt(const parser::OpenMPLoopConstruct &x); void CheckLoopItrVariableIsInt(const parser::OpenMPLoopConstruct &x);
void CheckDoWhile(const parser::OpenMPLoopConstruct &x); void CheckDoWhile(const parser::OpenMPLoopConstruct &x);
void CheckCycleConstraints(const parser::OpenMPLoopConstruct &x); void CheckCycleConstraints(const parser::OpenMPLoopConstruct &x);
void CheckSIMDNest(const parser::OpenMPConstruct &x);
std::int64_t GetOrdCollapseLevel(const parser::OpenMPLoopConstruct &x); std::int64_t GetOrdCollapseLevel(const parser::OpenMPLoopConstruct &x);
void CheckIfDoOrderedClause(const parser::OmpBlockDirective &blkDirectiv); void CheckIfDoOrderedClause(const parser::OmpBlockDirective &blkDirectiv);
bool CheckReductionOperators(const parser::OmpClause::Reduction &); bool CheckReductionOperators(const parser::OmpClause::Reduction &);
bool CheckIntrinsicOperator( bool CheckIntrinsicOperator(
const parser::DefinedOperator::IntrinsicOperator &); const parser::DefinedOperator::IntrinsicOperator &);
void CheckReductionTypeList(const parser::OmpClause::Reduction &); void CheckReductionTypeList(const parser::OmpClause::Reduction &);
void CheckReductionArraySection(const parser::OmpObjectList &ompObjectList); void CheckReductionArraySection(const parser::OmpObjectList &ompObjectList);
void CheckIntentInPointerAndDefinable( void CheckIntentInPointerAndDefinable(
Show All 9 Lines

flang/lib/Semantics/check-omp-structure.cpp

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Lines context_.Say(source,
"A worksharing region may not be closely nested inside a " "A worksharing region may not be closely nested inside a "
"worksharing, explicit task, taskloop, critical, ordered, atomic, or " "worksharing, explicit task, taskloop, critical, ordered, atomic, or "
"master region"_err_en_US); "master region"_err_en_US);
return true; return true;
} }
return false; return false;
} }
void OmpStructureChecker::Enter(const parser::OpenMPConstruct &) { void OmpStructureChecker::Enter(const parser::OpenMPConstruct &x) {
// 2.8.1 TODO: Simd Construct with Ordered Construct Nesting check // Simd Construct with Ordered Construct Nesting check
// We cannot use CurrentDirectiveIsNested() here because
// PushContextAndClauseSets() has not been called yet, it is
// called individually for each construct. Therefore a
// dirContext_ size `1` means the current construct is nested
if (dirContext_.size() >= 1) {
clementvalUnsubmitted
Not Done
ReplyInline Actions

It is also considered nested is it's bigger than 1. So it should be >= 1?

clementval: It is also considered nested is it's bigger than 1. So it should be >= 1?
CheckSIMDNest(x);
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Can you check for the SIMD construct before calling this function?

kiranchandramohan: Can you check for the SIMD construct before calling this function?
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Nit: Would it be better to keep a counter which counts the constructs in the simdSet? The counter can be incremented on Entering a simdSet construct and decremented on leaving. If counter is greater than 1 then FindDirInWholeContext is true. This way we avoid going through all the entries in dirContext_ everytime we see a construct.

kiranchandramohan: Nit: Would it be better to keep a counter which counts the constructs in the simdSet? The…
arnamoy10AuthorUnsubmitted
Done
ReplyInline Actions

Thanks for the suggestion. Updated

arnamoy10: Thanks for the suggestion. Updated
}
} }
void OmpStructureChecker::Enter(const parser::OpenMPLoopConstruct &x) { void OmpStructureChecker::Enter(const parser::OpenMPLoopConstruct &x) {
const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)};
const auto &beginDir{std::get<parser::OmpLoopDirective>(beginLoopDir.t)}; const auto &beginDir{std::get<parser::OmpLoopDirective>(beginLoopDir.t)};
// check matching, End directive is optional // check matching, End directive is optional
if (const auto &endLoopDir{ if (const auto &endLoopDir{
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines for (const parser::DoConstruct *loop{&*loopConstruct}; loop;) {
const auto &block{std::get<parser::Block>(loop->t)}; const auto &block{std::get<parser::Block>(loop->t)};
const auto it{block.begin()}; const auto it{block.begin()};
loop = it != block.end() ? parser::Unwrap<parser::DoConstruct>(*it) loop = it != block.end() ? parser::Unwrap<parser::DoConstruct>(*it)
: nullptr; : nullptr;
} }
} }
} }
void OmpStructureChecker::CheckSIMDNest(const parser::OpenMPConstruct &c) {
// Check if the parent context has the SIMD clause
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Nit: A TODO for the loop construct.

kiranchandramohan: Nit: A TODO for the loop construct.
arnamoy10AuthorUnsubmitted
Done
ReplyInline Actions

Thanks, added.

arnamoy10: Thanks, added.
// Please not that we use GetContext() instead of GetContextParent()
// because PushContextAndClauseSets() has not been called on the
// current context yet.
// TODO: Check for declare simd regions.
bool eligibleSIMD = false;
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Nit: use braced initializers.

kiranchandramohan: Nit: use braced initializers.
if (llvm::omp::simdSet.test(GetContext().directive)) {
std::visit(Fortran::common::visitors{
[&](const parser::OpenMPBlockConstruct &c) {
clementvalUnsubmitted
Not Done
ReplyInline Actions

Apply clang-format please.

clementval: Apply clang-format please.
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Nit: not -> note

kiranchandramohan: Nit: not -> note
// Allow `!$OMP ORDERED SIMD`
const auto &beginBlockDir{
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Nit: use braced initializer.

kiranchandramohan: Nit: use braced initializer.
std::get<parser::OmpBeginBlockDirective>(c.t)};
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Will simd be always the parent construct? Are there cases where it can become an ancestor but not the immediate parent?

kiranchandramohan: Will simd be always the parent construct? Are there cases where it can become an ancestor but…
const auto &clauses{
std::get<parser::OmpClauseList>(beginBlockDir.t)};
for (const auto &clause : clauses.v) {
if (std::get_if<parser::OmpClause::Simd>(&clause.u)) {
eligibleSIMD = true;
break;
}
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Here ordered is a block-directive. But below it is a standalone directive. Is it parsed both ways?

kiranchandramohan: Here ordered is a block-directive. But below it is a standalone directive. Is it parsed both…
arnamoy10AuthorUnsubmitted
Done
ReplyInline Actions

Yes, according to here,

If the depend clause is specified, the ordered construct is a stand-alone directive.
arnamoy10: Yes, according to [[ https://www.openmp.org/spec-html/5.0/openmpsu97.html | here ]], ``` If…
}
},
[&](const parser::OpenMPAtomicConstruct &c) {
// Allow `!$OMP ATOMIC`
eligibleSIMD = true;
},
[&](const auto &c) {},
},
c.u);
if (!eligibleSIMD) {
context_.Say(parser::FindSourceLocation(c),
"OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC'"
" may not be nested inside 'SIMD' region."_err_en_US);
}
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Here ordered is a standalone directive. See above.

kiranchandramohan: Here ordered is a standalone directive. See above.
}
}
std::int64_t OmpStructureChecker::GetOrdCollapseLevel( std::int64_t OmpStructureChecker::GetOrdCollapseLevel(
const parser::OpenMPLoopConstruct &x) { const parser::OpenMPLoopConstruct &x) {
const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)};
const auto &clauseList{std::get<parser::OmpClauseList>(beginLoopDir.t)}; const auto &clauseList{std::get<parser::OmpClauseList>(beginLoopDir.t)};
std::int64_t orderedCollapseLevel{1}; std::int64_t orderedCollapseLevel{1};
std::int64_t orderedLevel{0}; std::int64_t orderedLevel{0};
std::int64_t collapseLevel{0}; std::int64_t collapseLevel{0};
▲ Show 20 Lines • Show All 1,241 Lines • Show Last 20 Lines

flang/test/Semantics/omp-nested-simd.f90

  • This file was added.
! RUN: %S/test_errors.sh %s %t %flang_fc1 -fopenmp
! OpenMP Version 4.5
! Various checks with the nesting of SIMD construct
SUBROUTINE NESTED_GOOD(N)
INTEGER N, I, J, K, A(10), B(10)
!$OMP SIMD
DO I = 1,N
!$OMP ATOMIC
K = K + 1
IF (I <= 10) THEN
!$OMP ORDERED SIMD
DO J = 1,N
A(J) = J
END DO
!$OMP END ORDERED
ENDIF
END DO
!$OMP END SIMD
END SUBROUTINE NESTED_GOOD
SUBROUTINE NESTED_BAD(N)
INTEGER N, I, J, K, A(10), B(10)
!$OMP SIMD
DO I = 1,N
!$OMP ATOMIC
K = K + 1
IF (I <= 10) THEN
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP SIMD
DO J = 1,N
A(J) = J
END DO
!$OMP END SIMD
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp task
do J = 1, N
K = 2
end do
!$omp end task
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp teams
do J = 1, N
K = 2
end do
!$omp end teams
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp target
do J = 1, N
K = 2
end do
!$omp end target
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP DO
DO J = 1,N
A(J) = J
END DO
!$OMP END DO
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP PARALLEL DO
DO J = 1,N
A(J) = J
END DO
!$OMP END PARALLEL DO
ENDIF
END DO
!$OMP END SIMD
!$OMP DO SIMD
DO I = 1,N
!$OMP ATOMIC
K = K + 1
IF (I <= 10) THEN
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
kiranchandramohanUnsubmitted
Not Done
ReplyInline Actions

Which revision of the standard are you following here?

4.5:
An ordered construct with the simd clause is the only OpenMP construct that can be encountered during execution of a simd region.

5.0, 5.1:
The only OpenMP constructs that can be encountered during execution of a simd region are the atomic construct, the loop construct, the simd construct and the ordered construct with the simd clause.

kiranchandramohan: Which revision of the standard are you following here? 4.5: An ordered construct with the…
arnamoy10AuthorUnsubmitted
Done
ReplyInline Actions

Thanks for the comment. Initially the check I implemented was based on gfortran (latest) error messages. I updated the checks to reflect the OpenMP 5.0/5.1 standard.

arnamoy10: Thanks for the comment. Initially the check I implemented was based on `gfortran` (latest)…
!$OMP SIMD
DO J = 1,N
A(J) = J
END DO
!$OMP END SIMD
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp task
do J = 1, N
K = 2
end do
!$omp end task
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp teams
do J = 1, N
K = 2
end do
!$omp end teams
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp target
do J = 1, N
K = 2
end do
!$omp end target
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP DO
DO J = 1,N
A(J) = J
END DO
!$OMP END DO
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP PARALLEL DO
DO J = 1,N
A(J) = J
END DO
!$OMP END PARALLEL DO
ENDIF
END DO
!$OMP END DO SIMD
!$OMP PARALLEL DO SIMD
DO I = 1,N
!$OMP ATOMIC
K = K + 1
IF (I <= 10) THEN
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP SIMD
DO J = 1,N
A(J) = J
END DO
!$OMP END SIMD
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp task
do J = 1, N
K = 2
end do
!$omp end task
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp teams
do J = 1, N
K = 2
end do
!$omp end teams
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp target
do J = 1, N
K = 2
end do
!$omp end target
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP DO
DO J = 1,N
A(J) = J
END DO
!$OMP END DO
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP PARALLEL DO
DO J = 1,N
A(J) = J
END DO
!$OMP END PARALLEL DO
ENDIF
END DO
!$OMP END PARALLEL DO SIMD
!$OMP TARGET SIMD
DO I = 1,N
!$OMP ATOMIC
K = K + 1
IF (I <= 10) THEN
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP SIMD
DO J = 1,N
A(J) = J
END DO
!$OMP END SIMD
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp task
do J = 1, N
K = 2
end do
!$omp end task
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp teams
do J = 1, N
K = 2
end do
!$omp end teams
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$omp target
do J = 1, N
K = 2
end do
!$omp end target
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP DO
DO J = 1,N
A(J) = J
END DO
!$OMP END DO
!ERROR: OpenMP constructs other than `!$OMP ORDERED SIMD` or '!$OMP ATOMIC' may not be nested inside 'SIMD' region.
!$OMP PARALLEL DO
DO J = 1,N
A(J) = J
END DO
!$OMP END PARALLEL DO
ENDIF
END DO
!$OMP END TARGET SIMD
END SUBROUTINE NESTED_BAD

flang/test/Semantics/omp-ordered-simd.f90

Show All 16 Lines DO I = 1,N
ENDIF ENDIF
END DO END DO
!$OMP END SIMD !$OMP END SIMD
END SUBROUTINE ORDERED_GOOD END SUBROUTINE ORDERED_GOOD
SUBROUTINE ORDERED_BAD(N) SUBROUTINE ORDERED_BAD(N)
INTEGER N, I, A(10), B(10), C(10) INTEGER N, I, A(10), B(10), C(10)
!$OMP DO SIMD
DO I = 1,N
IF (I <= 10) THEN
!ERROR: The ORDERED clause must be present on the loop construct if any ORDERED region ever binds to a loop region arising from the loop construct.
!$OMP ORDERED
CALL WORK(I)
!$OMP END ORDERED
ENDIF
END DO
!$OMP END DO SIMD
!$OMP PARALLEL DO !$OMP PARALLEL DO
DO I = 1,N DO I = 1,N
IF (I <= 10) THEN IF (I <= 10) THEN
!ERROR: The ORDERED clause must be present on the loop construct if any ORDERED region ever binds to a loop region arising from the loop construct. !ERROR: The ORDERED clause must be present on the loop construct if any ORDERED region ever binds to a loop region arising from the loop construct.
!$OMP ORDERED !$OMP ORDERED
CALL WORK(I) CALL WORK(I)
!$OMP END ORDERED !$OMP END ORDERED
ENDIF ENDIF
▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines