Page MenuHomePhabricator

SouraVX (Sourabh Singh Tomar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2019, 11:05 PM (84 w, 4 d)

Recent Activity

Fri, Apr 9

SouraVX added a comment to D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

The new driver is still called flang-new

I presume eventually next step would be replace that as well ?

Fri, Apr 9, 4:10 AM · Restricted Project, Restricted Project
SouraVX added a comment to D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

One step at a time :)

+1 :)

Fri, Apr 9, 4:07 AM · Restricted Project, Restricted Project
SouraVX accepted D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

LGTM. Thanks for the patch! and congratulations on the milestone of bringing experimental driver to mainline!

Fri, Apr 9, 4:03 AM · Restricted Project, Restricted Project

Sat, Apr 3

SouraVX updated subscribers of D99024: [OpenMP][OMPIRBuilder] Adding support for `omp atomic`.

Thanks! @fghanim for the patch :)

Sat, Apr 3, 12:45 AM · Restricted Project, Restricted Project

Fri, Apr 2

SouraVX added a project to D99024: [OpenMP][OMPIRBuilder] Adding support for `omp atomic`: Restricted Project.
Fri, Apr 2, 9:49 AM · Restricted Project, Restricted Project

Wed, Mar 31

SouraVX abandoned D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Wed, Mar 31, 12:38 AM · debug-info, Restricted Project

Tue, Mar 30

SouraVX committed rGf13f0505515d: [DebugInfo] Support for signed constants inside DIExpression (authored by SouraVX).
[DebugInfo] Support for signed constants inside DIExpression
Tue, Mar 30, 10:51 AM
SouraVX closed D99273: [DebugInfo] Support for signed constants inside DIExpression.
Tue, Mar 30, 10:50 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.
  • Addressed @aprantl review comments. Thanks!.
Tue, Mar 30, 10:02 AM · Restricted Project, debug-info
SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Tue, Mar 30, 6:39 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Minor comment correction.

Tue, Mar 30, 6:35 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.
  • Rebased & addressed @aprantl review comments.
Tue, Mar 30, 6:32 AM · Restricted Project, debug-info

Mon, Mar 29

SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mon, Mar 29, 12:27 PM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Rebased

Mon, Mar 29, 12:24 PM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Changes:

  • Rebased to the tip.
  • Addressed @aprantl review comments.
Mon, Mar 29, 12:22 PM · Restricted Project, debug-info

Thu, Mar 25

SouraVX added a reviewer for D99273: [DebugInfo] Support for signed constants inside DIExpression: jmorse.
Thu, Mar 25, 10:07 AM · Restricted Project, debug-info
SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Thu, Mar 25, 10:06 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Thanks for the review @jmorse!

  • Addressed review comments by @jmorse.
  • Reinforced checks for both isUnsignedConstant and isSignedConstant.
  • Added an invalid expression test case covering isSignedConstant 6 arguments case with operand 0 and operand 2 matching.
Thu, Mar 25, 10:05 AM · Restricted Project, debug-info
SouraVX updated the summary of D99273: [DebugInfo] Support for signed constants inside DIExpression.
Thu, Mar 25, 12:56 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.
  • Minor comment updation in isSignedConstant Function in DebugInfoMetadata.cpp
Thu, Mar 25, 12:53 AM · Restricted Project, debug-info
SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Thu, Mar 25, 12:29 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Changes:

  • Rebased to tip.
  • Addressed @dstenb review comments regarding covering fragments and added test case to excercise that.
  • Addressed @aprantl review comments of combinining check to a single function i.e isConstant.
  • Replaced most checks of isUnsignedConstant with isConstant adding appropriate test case modifications to exercise the changes.
Thu, Mar 25, 12:22 AM · Restricted Project, debug-info

Wed, Mar 24

SouraVX added a reviewer for D99273: [DebugInfo] Support for signed constants inside DIExpression: dstenb.
Wed, Mar 24, 9:24 AM · Restricted Project, debug-info
SouraVX added a comment to D99273: [DebugInfo] Support for signed constants inside DIExpression.

Thanks for review @dstenb !

Wed, Mar 24, 9:24 AM · Restricted Project, debug-info
SouraVX added a comment to D99273: [DebugInfo] Support for signed constants inside DIExpression.

Patch is stemmed from the discussions from https://reviews.llvm.org/D97311

Wed, Mar 24, 9:02 AM · Restricted Project, debug-info
SouraVX requested review of D99273: [DebugInfo] Support for signed constants inside DIExpression.
Wed, Mar 24, 9:00 AM · Restricted Project, debug-info

Tue, Mar 16

SouraVX committed rG8ca16e977862: [flang] Replace Arithmetic Ops with their builtin conunterpart (authored by SouraVX).
[flang] Replace Arithmetic Ops with their builtin conunterpart
Tue, Mar 16, 8:28 PM
SouraVX closed D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart.
Tue, Mar 16, 8:28 PM · Restricted Project, Restricted Project
SouraVX added a project to D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart: Restricted Project.
Tue, Mar 16, 9:16 AM · Restricted Project, Restricted Project
SouraVX requested review of D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart.
Tue, Mar 16, 9:15 AM · Restricted Project, Restricted Project

Mar 10 2021

SouraVX added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Here's an example that seems to work:

...

Mar 10 2021, 2:52 AM · debug-info, Restricted Project

Mar 8 2021

SouraVX added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 10:08 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 10:02 AM · Restricted Project, Restricted Project

Mar 3 2021

SouraVX abandoned D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro..
Mar 3 2021, 8:13 PM · Restricted Project
SouraVX abandoned D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

code is pretty stale here, primary problem still persists. Abandoning for now.

Mar 3 2021, 8:12 PM · Restricted Project

Mar 1 2021

SouraVX retitled D97403: [flang] update character tests to use gtest from updated character tests to gtest to [flang] updated character tests to gtest.
Mar 1 2021, 8:47 PM · Restricted Project, Restricted Project

Feb 26 2021

SouraVX added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Have you considered instead introducing a bool isConstant field in DILocalVariable? This way we could reuse all the machinery for local/global variables and only need to switch out the TAG in AsmPrinter.

Feb 26 2021, 8:04 AM · debug-info, Restricted Project

Feb 24 2021

SouraVX added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Could you please add a Unit test for this(as we don't have clang, flang, or MLIR interfacing for dynamic workshare loops).

Feb 24 2021, 9:03 AM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX added a project to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic: Restricted Project.
Feb 24 2021, 8:29 AM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX added a comment to D97349: [flang] Change existing runtime tests to use gtest.

Thanks for the patch! Could you please clang-format the patch(this is will remove lot of Lint warning/noise) and ease up the review.
If you're using arcanist then that will automatically take care of formatting(provided clang-format should be in system path.) Or if you're using web UI then you may have to do it manually (git-clang-format HEAD~).
More details: https://llvm.org/docs/Phabricator.html

Feb 24 2021, 6:17 AM · Restricted Project, Restricted Project
SouraVX added a reviewer for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants: cchen15.
Feb 24 2021, 2:25 AM · debug-info, Restricted Project
SouraVX retitled D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants from [WIP][DebugInfo] Introduce DIConstant metadata for representing named constants to [DebugInfo] Introduce DIConstant metadata for representing named constants.
Feb 24 2021, 12:50 AM · debug-info, Restricted Project
SouraVX updated the diff for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Resolved the previous mentioned issue. Ready for review.

Feb 24 2021, 12:48 AM · debug-info, Restricted Project

Feb 23 2021

SouraVX added inline comments to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Feb 23 2021, 11:46 AM · debug-info, Restricted Project
SouraVX added a project to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants: debug-info.
Feb 23 2021, 11:38 AM · debug-info, Restricted Project
SouraVX updated the diff for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Rebase + clang-format

Feb 23 2021, 11:34 AM · debug-info, Restricted Project
SouraVX requested review of D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Feb 23 2021, 11:33 AM · debug-info, Restricted Project

Feb 21 2021

SouraVX accepted D96777: [clang][driver] Set the input type to Fortran when reading from stdin.

Thanks! for the patch.
This code touches some of the clang part, Anyway changes are pretty self-explanatory. I'll leave this one to you, if you want land it or wait from someone from clang community to take a look :)

Feb 21 2021, 9:18 PM · Restricted Project, Restricted Project
SouraVX accepted D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.
Feb 21 2021, 9:09 PM · Restricted Project, Restricted Project

Feb 17 2021

SouraVX added inline comments to D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.
Feb 17 2021, 10:25 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.
Feb 17 2021, 7:56 AM · Restricted Project, Restricted Project
SouraVX added a comment to D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.

Thanks! for the patch @awarzynski . I support this enhancement. LGTM(Not accepting formally :) ), Let's wait and hear from others also, what's their take on this.

Feb 17 2021, 7:53 AM · Restricted Project, Restricted Project

Feb 11 2021

SouraVX committed rG6a7deff58e3f: [flang] Remove `LINK_WITH_FIR` cmake switch (authored by SouraVX).
[flang] Remove `LINK_WITH_FIR` cmake switch
Feb 11 2021, 9:22 AM
SouraVX closed D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 11 2021, 9:22 AM · Restricted Project, Restricted Project

Feb 10 2021

SouraVX added inline comments to D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 10 2021, 9:03 AM · Restricted Project, Restricted Project
SouraVX updated the diff for D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.

Addressed @tskeith comments.

Feb 10 2021, 9:03 AM · Restricted Project, Restricted Project
SouraVX requested review of D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 10 2021, 5:16 AM · Restricted Project, Restricted Project

Feb 9 2021

SouraVX added a comment to D67563: Debug Info: Add support for named constants.

How do Fortran compilers represent regular versus inout arguments in DWARF?

According to godbolt.org, gfortran 8.2 emits the same DWARF for in and inout parameters. That doesn't help :-)

Feb 9 2021, 11:23 PM · Restricted Project, debug-info

Feb 4 2021

SouraVX committed rGbca0619a1bca: [flang] Adapt mlir based error status handling in `tco` tool (authored by SouraVX).
[flang] Adapt mlir based error status handling in `tco` tool
Feb 4 2021, 9:37 PM
SouraVX closed D96068: [flang] Adapt mlir based error status handling in `tco` tool.
Feb 4 2021, 9:37 PM · Restricted Project, Restricted Project
SouraVX added a comment to D96068: [flang] Adapt mlir based error status handling in `tco` tool.

@mehdi_amini are you Okay with this patch ?

Feb 4 2021, 9:14 PM · Restricted Project, Restricted Project
SouraVX updated the summary of D96068: [flang] Adapt mlir based error status handling in `tco` tool.
Feb 4 2021, 11:43 AM · Restricted Project, Restricted Project
SouraVX requested review of D96068: [flang] Adapt mlir based error status handling in `tco` tool.
Feb 4 2021, 11:31 AM · Restricted Project, Restricted Project

Feb 3 2021

SouraVX committed rGf2879559ac11: [flang] Enable FIR types and Dialect round trip tests (authored by SouraVX).
[flang] Enable FIR types and Dialect round trip tests
Feb 3 2021, 10:17 AM
SouraVX closed D95958: [flang] Enable FIR types and Dialect round trip tests.
Feb 3 2021, 10:17 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95958: [flang] Enable FIR types and Dialect round trip tests.

Can be tested locally as:

make(or ninja) check-flang-fir
Feb 3 2021, 9:42 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

Enabled tests for this in: https://reviews.llvm.org/D95958
Builds clean.
@mehdi_amini Apologies, I totally forgot and landed without your approval :(, if you have any concerns please share I'll try to address as a post commit thing or if you want I can revert it.

Feb 3 2021, 9:39 AM · Restricted Project, Restricted Project
SouraVX requested review of D95958: [flang] Enable FIR types and Dialect round trip tests.
Feb 3 2021, 9:35 AM · Restricted Project, Restricted Project
SouraVX committed rG4463e39d91c6: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect (authored by SouraVX).
[flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect
Feb 3 2021, 9:28 AM
SouraVX closed D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.
Feb 3 2021, 9:28 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

@schweitz, fir-ops.fir is marked as Unsupported. Seems like tco is not ready ?

// RUN: tco -emit-fir %s | tco -emit-fir | FileCheck %s
// UNSUPPORTED: !fir
Feb 3 2021, 9:25 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

Built and tested locally.

I think the fir-ops.fir test might need to be updated.

Thanks for the renaming merge!

Feb 3 2021, 8:21 AM · Restricted Project, Restricted Project
SouraVX added reviewers for D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect: jeanPerier, kiranktp.
Feb 3 2021, 6:41 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

Built and tested locally.

Feb 3 2021, 6:38 AM · Restricted Project, Restricted Project
SouraVX requested review of D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.
Feb 3 2021, 6:34 AM · Restricted Project, Restricted Project

Jan 28 2021

SouraVX added inline comments to D95399: [flang][fir] Upstream FIR dialect changes..
Jan 28 2021, 8:43 AM · Unknown Object (Project), Restricted Project, Restricted Project
SouraVX accepted D95127: [flang][driver] Disallow non-existent input files in the frontend driver.

LGTM! Please wait for @sameeranjoshi to have a look.

Jan 28 2021, 3:30 AM · Restricted Project, Restricted Project

Jan 27 2021

SouraVX accepted D95469: [flang][openacc] Allow multiple wait clauses.

LGTM!

Jan 27 2021, 7:40 AM · Restricted Project, Restricted Project

Jan 26 2021

SouraVX added inline comments to D95469: [flang][openacc] Allow multiple wait clauses.
Jan 26 2021, 8:45 PM · Restricted Project, Restricted Project
SouraVX accepted D95470: [flang][openacc] Fix clause restriction for exit data directive.

LGTM! Thanks!

Jan 26 2021, 8:39 PM · Restricted Project, Restricted Project
SouraVX accepted D95473: [flang][openacc] Fix clause restriction for host_data directive.

LGTM! Thanks!

Jan 26 2021, 8:37 PM · Restricted Project, Restricted Project
SouraVX accepted D95328: [flang][openacc][NFC] Organize clause validity tests by directive.

Thanks! LGTM! Same approach I followed in openmp work, keeping test cases short and dedicated for instance (a directive and all it's assoicated clauses). It pays off in diagnosing/modifying when some test case fails(due to 2 branch development).

Jan 26 2021, 6:14 AM · Restricted Project, Restricted Project

Jan 12 2021

SouraVX committed rG4744478b99f1: [mlir][openmp][NFCI] Rename `continuationIP` to `continuationBlock` (authored by SouraVX).
[mlir][openmp][NFCI] Rename `continuationIP` to `continuationBlock`
Jan 12 2021, 2:17 AM

Jan 5 2021

SouraVX accepted D93301: [flang][driver] Add support for `-c` and `-emit-obj`.

LGTM! - Thanks!

Jan 5 2021, 10:09 PM · Restricted Project, Restricted Project

Dec 20 2020

SouraVX accepted D93558: [docs] Release notes for IsDecl in DIModule..

LGTM, Thanks!

Dec 20 2020, 9:50 PM · Restricted Project

Dec 17 2020

SouraVX accepted D93462: [DebugInfo] Support Fortran 'use <external module>' statement..

LGTM! Thanks for the patch.
One small thing, do you mind adding a one liner to release notes ? It would help in tracking extensions to Debug Metadata(previous extensions of DIModule were part of LLVM11).

Dec 17 2020, 10:19 PM · debug-info, Restricted Project
SouraVX added a project to D93462: [DebugInfo] Support Fortran 'use <external module>' statement.: debug-info.
Dec 17 2020, 10:13 PM · debug-info, Restricted Project
SouraVX updated subscribers of D93462: [DebugInfo] Support Fortran 'use <external module>' statement..
Dec 17 2020, 8:35 AM · debug-info, Restricted Project

Dec 15 2020

SouraVX added a comment to D93301: [flang][driver] Add support for `-c` and `-emit-obj`.

Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look.

Dec 15 2020, 8:32 PM · Restricted Project, Restricted Project

Dec 11 2020

SouraVX accepted D93088: [OpenMPIRBuilder] Various changes required for tileLoops..

LGTM Thank You @Meinersbur for taking out time :).

Dec 11 2020, 1:02 AM · Restricted Project

Dec 9 2020

SouraVX added inline comments to D92974: [OpenMPIRBuilder] Implement tileLoops..
Dec 9 2020, 11:36 PM · Restricted Project
SouraVX added a comment to D92974: [OpenMPIRBuilder] Implement tileLoops..

Thanks for the patch! Some NIT's related to refactoring/moving inline. I've tried to highlight some parts, if you like the idea in general, there might be more opportunities to reduce the size of this patch(thus capturing the most crucial part tileLoop).

Dec 9 2020, 10:17 PM · Restricted Project

Dec 8 2020

SouraVX accepted D92443: [flang][openacc] Avoid use of init, shutdown and set in compute construct.

LGTM, Thanks!

Dec 8 2020, 7:35 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D92120: [flang][openacc] Update reference to OpenACC 3.1 specification.
Dec 8 2020, 7:28 AM · Restricted Project, Restricted Project, Unknown Object (Project)
SouraVX accepted D92120: [flang][openacc] Update reference to OpenACC 3.1 specification.
Dec 8 2020, 7:19 AM · Restricted Project, Restricted Project, Unknown Object (Project)

Dec 7 2020

SouraVX added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Dec 7 2020, 7:17 AM · Unknown Object (Project)

Dec 6 2020

SouraVX committed rGc11d868a39cb: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR (authored by SouraVX).
[MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR
Dec 6 2020, 8:54 PM
SouraVX closed D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Dec 6 2020, 8:54 PM · Unknown Object (Project)

Dec 4 2020

SouraVX added a comment to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.

@ftynse would you mind having a look at D87247 ?

Dec 4 2020, 4:09 AM · Restricted Project, Restricted Project

Dec 3 2020

SouraVX accepted D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType.

LGTM Thanks! Please wait for @aprantl for any comments/approval.

Dec 3 2020, 9:59 PM · debug-info, Restricted Project