The new driver is still called flang-new

I presume eventually next step would be replace that as well ?

One step at a time :)

+1 :)

LGTM. Thanks for the patch! and congratulations on the milestone of bringing experimental driver to mainline!

Thanks! @fghanim for the patch :)

• Addressed @aprantl review comments. Thanks!.

Minor comment correction.

• Rebased & addressed @aprantl review comments.

Rebased

Changes:

• Rebased to the tip.
• Addressed @aprantl review comments.

Thanks for the review @jmorse!

• Addressed review comments by @jmorse.
• Reinforced checks for both isUnsignedConstant and isSignedConstant.
• Added an invalid expression test case covering isSignedConstant 6 arguments case with operand 0 and operand 2 matching.

• Minor comment updation in isSignedConstant Function in DebugInfoMetadata.cpp

Changes:

• Rebased to tip.
• Addressed @dstenb review comments regarding covering fragments and added test case to excercise that.
• Addressed @aprantl review comments of combinining check to a single function i.e isConstant.
• Replaced most checks of isUnsignedConstant with isConstant adding appropriate test case modifications to exercise the changes.

Thanks for review @dstenb !

Patch is stemmed from the discussions from https://reviews.llvm.org/D97311

In D97311#2590688, @aprantl wrote:

Here's an example that seems to work:

...

code is pretty stale here, primary problem still persists. Abandoning for now.

In D97311#2588856, @aprantl wrote:

Have you considered instead introducing a bool isConstant field in DILocalVariable? This way we could reuse all the machinery for local/global variables and only need to switch out the TAG in AsmPrinter.

Could you please add a Unit test for this(as we don't have clang, flang, or MLIR interfacing for dynamic workshare loops).

Thanks for the patch! Could you please clang-format the patch(this is will remove lot of Lint warning/noise) and ease up the review.
If you're using arcanist then that will automatically take care of formatting(provided clang-format should be in system path.) Or if you're using web UI then you may have to do it manually (git-clang-format HEAD~).
More details: https://llvm.org/docs/Phabricator.html

Resolved the previous mentioned issue. Ready for review.

Rebase + clang-format

Thanks! for the patch.
This code touches some of the clang part, Anyway changes are pretty self-explanatory. I'll leave this one to you, if you want land it or wait from someone from clang community to take a look :)

Thanks! for the patch @awarzynski . I support this enhancement. LGTM(Not accepting formally :) ), Let's wait and hear from others also, what's their take on this.

Addressed @tskeith comments.

In D67563#1675361, @aprantl wrote:

In D67563#1675356, @aprantl wrote:

How do Fortran compilers represent regular versus inout arguments in DWARF?

According to godbolt.org, gfortran 8.2 emits the same DWARF for in and inout parameters. That doesn't help :-)

@mehdi_amini are you Okay with this patch ?

Can be tested locally as:

make(or ninja) check-flang-fir

Enabled tests for this in: https://reviews.llvm.org/D95958
Builds clean.
@mehdi_amini Apologies, I totally forgot and landed without your approval :(, if you have any concerns please share I'll try to address as a post commit thing or if you want I can revert it.

@schweitz, fir-ops.fir is marked as Unsupported. Seems like tco is not ready ?

// RUN: tco -emit-fir %s | tco -emit-fir | FileCheck %s
// UNSUPPORTED: !fir

In D95950#2539385, @schweitz wrote:

In D95950#2539183, @SouraVX wrote:

Built and tested locally.

I think the fir-ops.fir test might need to be updated.

Thanks for the renaming merge!

Built and tested locally.

LGTM! Please wait for @sameeranjoshi to have a look.

LGTM!

LGTM! Thanks!

LGTM! Thanks!

Thanks! LGTM! Same approach I followed in openmp work, keeping test cases short and dedicated for instance (a directive and all it's assoicated clauses). It pays off in diagnosing/modifying when some test case fails(due to 2 branch development).

LGTM! - Thanks!

LGTM, Thanks!

LGTM! Thanks for the patch.
One small thing, do you mind adding a one liner to release notes ? It would help in tracking extensions to Debug Metadata(previous extensions of DIModule were part of LLVM11).

Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look.

LGTM Thank You @Meinersbur for taking out time :).

Thanks for the patch! Some NIT's related to refactoring/moving inline. I've tried to highlight some parts, if you like the idea in general, there might be more opportunities to reduce the size of this patch(thus capturing the most crucial part tileLoop).

LGTM, Thanks!

@ftynse would you mind having a look at D87247 ?

LGTM Thanks! Please wait for @aprantl for any comments/approval.