Page MenuHomePhabricator

SouraVX (Sourabh Singh Tomar)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2019, 11:05 PM (143 w, 3 d)

Recent Activity

Jun 13 2021

SouraVX added a project to D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C: debug-info.
Jun 13 2021, 10:08 PM · debug-info, Restricted Project
SouraVX added a comment to D104118: [OpenCL] Use DW_LANG_OpenCL language tag for OpenCL C.

Note: there is currently no DWARF language code defined for C++ for OpenCL, so we must use DW_LANG_C_plus_plus* if we wish to be able to determine whether output has been generated from C++ for OpenCL source or from OpenCL C source. I have raised DWARF issue 210514.1 to add a dedicated C++ for OpenCL code in the next version of DWARF, but for now I believe that it is best to use DW_LANG_OpenCL for OpenCL C only, and not for C++ for OpenCL.

I could perhaps add a note regarding this to the commit message but am concerned about overcomplicating the message.

Jun 13 2021, 9:57 PM · debug-info, Restricted Project

Jun 11 2021

SouraVX added a comment to D103177: [flang][driver] Extend the `flang` bash script to act as a driver.

Overall I support & I'd like to have one driver i.e flang-new considering all the effort that has gone in it and the long term plan associated with the driver(that will cater to the entire flang project as a primary interface). :)

Jun 11 2021, 9:56 AM · Restricted Project, Restricted Project

Jun 7 2021

SouraVX accepted D103502: [DebugInfo] Bug 41152 - Improve dumping of empty location expressions.

It looks like the existing test is producing an empty range as a side-effect of the behaviour under test, and so it would be quite possible that the test coverage would be lost if this beahviour changed/the testing method changed for it. What do others think?

Jun 7 2021, 7:48 AM · debug-info, Restricted Project

Jun 2 2021

SouraVX added inline comments to D103502: [DebugInfo] Bug 41152 - Improve dumping of empty location expressions.
Jun 2 2021, 9:46 AM · debug-info, Restricted Project

Jun 1 2021

SouraVX added a comment to D103502: [DebugInfo] Bug 41152 - Improve dumping of empty location expressions.

Please clang-format the patch :)
FYI https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

Jun 1 2021, 9:32 PM · debug-info, Restricted Project
SouraVX added a project to D103502: [DebugInfo] Bug 41152 - Improve dumping of empty location expressions: debug-info.
Jun 1 2021, 9:29 PM · debug-info, Restricted Project

May 26 2021

SouraVX added a project to D103131: support debug info for alias variable: debug-info.
May 26 2021, 12:28 AM · debug-info, Restricted Project, Restricted Project

May 25 2021

SouraVX added a project to D102849: [flang][driver] Add support for the "-init-only" option: Restricted Project.
May 25 2021, 9:43 PM · Restricted Project, Restricted Project

May 24 2021

SouraVX added a comment to D102816: [MLIR][OpenMP]Basic OpenMP target operation.

Thanks @abidmalikwaterloo for the patch!

May 24 2021, 6:54 AM · Restricted Project, Restricted Project

Apr 30 2021

SouraVX added reviewers for D101503: [OpenMPIRBuilder] Add createOffloadMaptypes and createOffloadMapnames functions: abidmalikwaterloo, ftynse.
Apr 30 2021, 1:37 AM · Restricted Project, Restricted Project

Apr 20 2021

SouraVX added inline comments to D100556: [flang][driver] Refactor methods for parsing options (nfc).
Apr 20 2021, 3:53 AM · Restricted Project, Restricted Project
SouraVX accepted D100556: [flang][driver] Refactor methods for parsing options (nfc).

LG - Thanks! with one question inline :)

Apr 20 2021, 3:45 AM · Restricted Project, Restricted Project
SouraVX accepted D100655: [flang][nfc] Port 2 tests to use the new driver when enabled.
Apr 20 2021, 3:38 AM · Restricted Project, Restricted Project

Apr 15 2021

SouraVX added a reviewer for D75485: Support DW_FORM_strx* in llvm-dwp.: ikudrin.
Apr 15 2021, 10:04 PM · Restricted Project
SouraVX added a reviewer for D100458: Handle DW_FORM_strx[1-4] in llvm-dwp: ikudrin.
Apr 15 2021, 10:03 PM · Restricted Project
SouraVX committed rG5064a34165cc: [flang][OpenMP] Remove `OmpEndLoopDirective` handles from code. (authored by SouraVX).
[flang][OpenMP] Remove `OmpEndLoopDirective` handles from code.
Apr 15 2021, 11:31 AM
SouraVX closed D100576: [flang][OpenMP] Remove `OmpEndLoopDirective` handles from code..
Apr 15 2021, 11:30 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX updated the summary of D100576: [flang][OpenMP] Remove `OmpEndLoopDirective` handles from code..
Apr 15 2021, 9:25 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX added reviewers for D100576: [flang][OpenMP] Remove `OmpEndLoopDirective` handles from code.: kiranchandramohan, schweitz, clementval, kiranktp.
Apr 15 2021, 9:24 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX requested review of D100576: [flang][OpenMP] Remove `OmpEndLoopDirective` handles from code..
Apr 15 2021, 9:23 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2021

SouraVX added a comment to D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

The new driver is still called flang-new

I presume eventually next step would be replace that as well ?

Apr 9 2021, 4:10 AM · Restricted Project, Restricted Project
SouraVX added a comment to D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

One step at a time :)

+1 :)

Apr 9 2021, 4:07 AM · Restricted Project, Restricted Project
SouraVX accepted D100174: [flang][driver] Remove `%flang-new` from the LIT configuration.

LGTM. Thanks for the patch! and congratulations on the milestone of bringing experimental driver to mainline!

Apr 9 2021, 4:03 AM · Restricted Project, Restricted Project

Apr 3 2021

SouraVX updated subscribers of D99024: [OpenMP][OMPIRBuilder] Adding support for `omp atomic`.

Thanks! @fghanim for the patch :)

Apr 3 2021, 12:45 AM · Restricted Project, Restricted Project

Apr 2 2021

SouraVX added a project to D99024: [OpenMP][OMPIRBuilder] Adding support for `omp atomic`: Restricted Project.
Apr 2 2021, 9:49 AM · Restricted Project, Restricted Project

Mar 31 2021

SouraVX abandoned D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Mar 31 2021, 12:38 AM · debug-info, Restricted Project

Mar 30 2021

SouraVX committed rGf13f0505515d: [DebugInfo] Support for signed constants inside DIExpression (authored by SouraVX).
[DebugInfo] Support for signed constants inside DIExpression
Mar 30 2021, 10:51 AM
SouraVX closed D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 30 2021, 10:50 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.
  • Addressed @aprantl review comments. Thanks!.
Mar 30 2021, 10:02 AM · Restricted Project, debug-info
SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 30 2021, 6:39 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Minor comment correction.

Mar 30 2021, 6:35 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.
  • Rebased & addressed @aprantl review comments.
Mar 30 2021, 6:32 AM · Restricted Project, debug-info

Mar 29 2021

SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 29 2021, 12:27 PM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Rebased

Mar 29 2021, 12:24 PM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Changes:

  • Rebased to the tip.
  • Addressed @aprantl review comments.
Mar 29 2021, 12:22 PM · Restricted Project, debug-info

Mar 25 2021

SouraVX added a reviewer for D99273: [DebugInfo] Support for signed constants inside DIExpression: jmorse.
Mar 25 2021, 10:07 AM · Restricted Project, debug-info
SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 25 2021, 10:06 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Thanks for the review @jmorse!

  • Addressed review comments by @jmorse.
  • Reinforced checks for both isUnsignedConstant and isSignedConstant.
  • Added an invalid expression test case covering isSignedConstant 6 arguments case with operand 0 and operand 2 matching.
Mar 25 2021, 10:05 AM · Restricted Project, debug-info
SouraVX updated the summary of D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 25 2021, 12:56 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.
  • Minor comment updation in isSignedConstant Function in DebugInfoMetadata.cpp
Mar 25 2021, 12:53 AM · Restricted Project, debug-info
SouraVX added inline comments to D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 25 2021, 12:29 AM · Restricted Project, debug-info
SouraVX updated the diff for D99273: [DebugInfo] Support for signed constants inside DIExpression.

Thanks @aprantl for reviewing this.
Changes:

  • Rebased to tip.
  • Addressed @dstenb review comments regarding covering fragments and added test case to excercise that.
  • Addressed @aprantl review comments of combinining check to a single function i.e isConstant.
  • Replaced most checks of isUnsignedConstant with isConstant adding appropriate test case modifications to exercise the changes.
Mar 25 2021, 12:22 AM · Restricted Project, debug-info

Mar 24 2021

SouraVX added a reviewer for D99273: [DebugInfo] Support for signed constants inside DIExpression: dstenb.
Mar 24 2021, 9:24 AM · Restricted Project, debug-info
SouraVX added a comment to D99273: [DebugInfo] Support for signed constants inside DIExpression.

Thanks for review @dstenb !

Mar 24 2021, 9:24 AM · Restricted Project, debug-info
SouraVX added a comment to D99273: [DebugInfo] Support for signed constants inside DIExpression.

Patch is stemmed from the discussions from https://reviews.llvm.org/D97311

Mar 24 2021, 9:02 AM · Restricted Project, debug-info
SouraVX requested review of D99273: [DebugInfo] Support for signed constants inside DIExpression.
Mar 24 2021, 9:00 AM · Restricted Project, debug-info

Mar 16 2021

SouraVX committed rG8ca16e977862: [flang] Replace Arithmetic Ops with their builtin conunterpart (authored by SouraVX).
[flang] Replace Arithmetic Ops with their builtin conunterpart
Mar 16 2021, 8:28 PM
SouraVX closed D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart.
Mar 16 2021, 8:28 PM · Restricted Project, Restricted Project
SouraVX added a project to D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart: Restricted Project.
Mar 16 2021, 9:16 AM · Restricted Project, Restricted Project
SouraVX requested review of D98719: [flang] Replace Arithmetic Ops with their builtin conunterpart.
Mar 16 2021, 9:15 AM · Restricted Project, Restricted Project

Mar 10 2021

SouraVX added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Here's an example that seems to work:

...

Mar 10 2021, 2:52 AM · debug-info, Restricted Project

Mar 8 2021

SouraVX added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 10:08 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D98063: [flang][fir] Add the pre-code gen rewrite pass and codegen ops..
Mar 8 2021, 10:02 AM · Restricted Project, Restricted Project

Mar 3 2021

SouraVX abandoned D72597: [lldb][DWARF] Added support for new forms in DWARFv5 macro..
Mar 3 2021, 8:13 PM · Restricted Project
SouraVX abandoned D85018: [WIP][POC][DebugInfo] Support for DW_AT_start_scope for scoped variables.

code is pretty stale here, primary problem still persists. Abandoning for now.

Mar 3 2021, 8:12 PM · Restricted Project

Mar 1 2021

SouraVX retitled D97403: [flang] update character tests to use gtest from updated character tests to gtest to [flang] updated character tests to gtest.
Mar 1 2021, 8:47 PM · Restricted Project, Restricted Project

Feb 26 2021

SouraVX added a comment to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Have you considered instead introducing a bool isConstant field in DILocalVariable? This way we could reuse all the machinery for local/global variables and only need to switch out the TAG in AsmPrinter.

Feb 26 2021, 8:04 AM · debug-info, Restricted Project

Feb 24 2021

SouraVX added a comment to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic.

Could you please add a Unit test for this(as we don't have clang, flang, or MLIR interfacing for dynamic workshare loops).

Feb 24 2021, 9:03 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX added a project to D97393: [OpenMP IRBuilder, MLIR] Add support for OpenMP do schedule dynamic: Restricted Project.
Feb 24 2021, 8:29 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX added a comment to D97349: [flang] Change existing runtime tests to use gtest.

Thanks for the patch! Could you please clang-format the patch(this is will remove lot of Lint warning/noise) and ease up the review.
If you're using arcanist then that will automatically take care of formatting(provided clang-format should be in system path.) Or if you're using web UI then you may have to do it manually (git-clang-format HEAD~).
More details: https://llvm.org/docs/Phabricator.html

Feb 24 2021, 6:17 AM · Restricted Project, Restricted Project
SouraVX added a reviewer for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants: cchen15.
Feb 24 2021, 2:25 AM · debug-info, Restricted Project
SouraVX retitled D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants from [WIP][DebugInfo] Introduce DIConstant metadata for representing named constants to [DebugInfo] Introduce DIConstant metadata for representing named constants.
Feb 24 2021, 12:50 AM · debug-info, Restricted Project
SouraVX updated the diff for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Resolved the previous mentioned issue. Ready for review.

Feb 24 2021, 12:48 AM · debug-info, Restricted Project

Feb 23 2021

SouraVX added inline comments to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Feb 23 2021, 11:46 AM · debug-info, Restricted Project
SouraVX added a project to D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants: debug-info.
Feb 23 2021, 11:38 AM · debug-info, Restricted Project
SouraVX updated the diff for D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.

Rebase + clang-format

Feb 23 2021, 11:34 AM · debug-info, Restricted Project
SouraVX requested review of D97311: [DebugInfo] Introduce DIConstant metadata for representing named constants.
Feb 23 2021, 11:33 AM · debug-info, Restricted Project

Feb 21 2021

SouraVX accepted D96777: [clang][driver] Set the input type to Fortran when reading from stdin.

Thanks! for the patch.
This code touches some of the clang part, Anyway changes are pretty self-explanatory. I'll leave this one to you, if you want land it or wait from someone from clang community to take a look :)

Feb 21 2021, 9:18 PM · Restricted Project, Restricted Project
SouraVX accepted D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.
Feb 21 2021, 9:09 PM · Restricted Project, Restricted Project

Feb 17 2021

SouraVX added inline comments to D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.
Feb 17 2021, 10:25 AM · Restricted Project, Restricted Project
SouraVX added inline comments to D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.
Feb 17 2021, 7:56 AM · Restricted Project, Restricted Project
SouraVX added a comment to D96864: [flang][driver] Add -Xflang and make -test-io a frontend-only flag.

Thanks! for the patch @awarzynski . I support this enhancement. LGTM(Not accepting formally :) ), Let's wait and hear from others also, what's their take on this.

Feb 17 2021, 7:53 AM · Restricted Project, Restricted Project

Feb 11 2021

SouraVX committed rG6a7deff58e3f: [flang] Remove `LINK_WITH_FIR` cmake switch (authored by SouraVX).
[flang] Remove `LINK_WITH_FIR` cmake switch
Feb 11 2021, 9:22 AM
SouraVX closed D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 11 2021, 9:22 AM · Restricted Project, Restricted Project

Feb 10 2021

SouraVX added inline comments to D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 10 2021, 9:03 AM · Restricted Project, Restricted Project
SouraVX updated the diff for D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.

Addressed @tskeith comments.

Feb 10 2021, 9:03 AM · Restricted Project, Restricted Project
SouraVX requested review of D96411: [flang] Remove `LINK_WITH_FIR` cmake switch.
Feb 10 2021, 5:16 AM · Restricted Project, Restricted Project

Feb 9 2021

SouraVX added a comment to D67563: Debug Info: Add support for named constants.

How do Fortran compilers represent regular versus inout arguments in DWARF?

According to godbolt.org, gfortran 8.2 emits the same DWARF for in and inout parameters. That doesn't help :-)

Feb 9 2021, 11:23 PM · Restricted Project, debug-info

Feb 4 2021

SouraVX committed rGbca0619a1bca: [flang] Adapt mlir based error status handling in `tco` tool (authored by SouraVX).
[flang] Adapt mlir based error status handling in `tco` tool
Feb 4 2021, 9:37 PM
SouraVX closed D96068: [flang] Adapt mlir based error status handling in `tco` tool.
Feb 4 2021, 9:37 PM · Restricted Project, Restricted Project
SouraVX added a comment to D96068: [flang] Adapt mlir based error status handling in `tco` tool.

@mehdi_amini are you Okay with this patch ?

Feb 4 2021, 9:14 PM · Restricted Project, Restricted Project
SouraVX updated the summary of D96068: [flang] Adapt mlir based error status handling in `tco` tool.
Feb 4 2021, 11:43 AM · Restricted Project, Restricted Project
SouraVX requested review of D96068: [flang] Adapt mlir based error status handling in `tco` tool.
Feb 4 2021, 11:31 AM · Restricted Project, Restricted Project

Feb 3 2021

SouraVX committed rGf2879559ac11: [flang] Enable FIR types and Dialect round trip tests (authored by SouraVX).
[flang] Enable FIR types and Dialect round trip tests
Feb 3 2021, 10:17 AM
SouraVX closed D95958: [flang] Enable FIR types and Dialect round trip tests.
Feb 3 2021, 10:17 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95958: [flang] Enable FIR types and Dialect round trip tests.

Can be tested locally as:

make(or ninja) check-flang-fir
Feb 3 2021, 9:42 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

Enabled tests for this in: https://reviews.llvm.org/D95958
Builds clean.
@mehdi_amini Apologies, I totally forgot and landed without your approval :(, if you have any concerns please share I'll try to address as a post commit thing or if you want I can revert it.

Feb 3 2021, 9:39 AM · Restricted Project, Restricted Project
SouraVX requested review of D95958: [flang] Enable FIR types and Dialect round trip tests.
Feb 3 2021, 9:35 AM · Restricted Project, Restricted Project
SouraVX committed rG4463e39d91c6: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect (authored by SouraVX).
[flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect
Feb 3 2021, 9:28 AM
SouraVX closed D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.
Feb 3 2021, 9:28 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

@schweitz, fir-ops.fir is marked as Unsupported. Seems like tco is not ready ?

// RUN: tco -emit-fir %s | tco -emit-fir | FileCheck %s
// UNSUPPORTED: !fir
Feb 3 2021, 9:25 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

Built and tested locally.

I think the fir-ops.fir test might need to be updated.

Thanks for the renaming merge!

Feb 3 2021, 8:21 AM · Restricted Project, Restricted Project
SouraVX added reviewers for D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect: jeanPerier, kiranktp.
Feb 3 2021, 6:41 AM · Restricted Project, Restricted Project
SouraVX added a comment to D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.

Built and tested locally.

Feb 3 2021, 6:38 AM · Restricted Project, Restricted Project
SouraVX requested review of D95950: [flang][NFCI] Relpace `LoopOp` Op with `DoLoopOp` Op in FIR Dialect.
Feb 3 2021, 6:34 AM · Restricted Project, Restricted Project

Jan 28 2021

SouraVX added inline comments to D95399: [flang][fir] Upstream FIR dialect changes..
Jan 28 2021, 8:43 AM · Restricted Project, Restricted Project, Restricted Project
SouraVX accepted D95127: [flang][driver] Disallow non-existent input files in the frontend driver.

LGTM! Please wait for @sameeranjoshi to have a look.

Jan 28 2021, 3:30 AM · Restricted Project, Restricted Project

Jan 27 2021

SouraVX accepted D95469: [flang][openacc] Allow multiple wait clauses.

LGTM!

Jan 27 2021, 7:40 AM · Restricted Project, Restricted Project

Jan 26 2021

SouraVX added inline comments to D95469: [flang][openacc] Allow multiple wait clauses.
Jan 26 2021, 8:45 PM · Restricted Project, Restricted Project