- User Since
- Aug 27 2019, 11:05 PM (84 w, 4 d)
Fri, Apr 9
The new driver is still called flang-new
I presume eventually next step would be replace that as well ?
One step at a time :)
LGTM. Thanks for the patch! and congratulations on the milestone of bringing experimental driver to mainline!
Sat, Apr 3
Thanks! @fghanim for the patch :)
Fri, Apr 2
Wed, Mar 31
Tue, Mar 30
- Addressed @aprantl review comments. Thanks!.
Minor comment correction.
- Rebased & addressed @aprantl review comments.
Mon, Mar 29
- Rebased to the tip.
- Addressed @aprantl review comments.
Thu, Mar 25
Thanks for the review @jmorse!
- Addressed review comments by @jmorse.
- Reinforced checks for both isUnsignedConstant and isSignedConstant.
- Added an invalid expression test case covering isSignedConstant 6 arguments case with operand 0 and operand 2 matching.
- Minor comment updation in isSignedConstant Function in DebugInfoMetadata.cpp
- Rebased to tip.
- Addressed @dstenb review comments regarding covering fragments and added test case to excercise that.
- Addressed @aprantl review comments of combinining check to a single function i.e isConstant.
- Replaced most checks of isUnsignedConstant with isConstant adding appropriate test case modifications to exercise the changes.
Wed, Mar 24
Thanks for review @dstenb !
Patch is stemmed from the discussions from https://reviews.llvm.org/D97311
Tue, Mar 16
Mar 10 2021
Mar 8 2021
Mar 3 2021
code is pretty stale here, primary problem still persists. Abandoning for now.
Mar 1 2021
Feb 26 2021
Feb 24 2021
Could you please add a Unit test for this(as we don't have clang, flang, or MLIR interfacing for dynamic workshare loops).
Thanks for the patch! Could you please clang-format the patch(this is will remove lot of Lint warning/noise) and ease up the review.
If you're using arcanist then that will automatically take care of formatting(provided clang-format should be in system path.) Or if you're using web UI then you may have to do it manually (git-clang-format HEAD~).
More details: https://llvm.org/docs/Phabricator.html
Resolved the previous mentioned issue. Ready for review.
Feb 23 2021
Rebase + clang-format
Feb 21 2021
Thanks! for the patch.
This code touches some of the clang part, Anyway changes are pretty self-explanatory. I'll leave this one to you, if you want land it or wait from someone from clang community to take a look :)
Feb 17 2021
Thanks! for the patch @awarzynski . I support this enhancement. LGTM(Not accepting formally :) ), Let's wait and hear from others also, what's their take on this.
Feb 11 2021
Feb 10 2021
Addressed @tskeith comments.
Feb 9 2021
Feb 4 2021
@mehdi_amini are you Okay with this patch ?
Feb 3 2021
Can be tested locally as:
make(or ninja) check-flang-fir
Enabled tests for this in: https://reviews.llvm.org/D95958
@mehdi_amini Apologies, I totally forgot and landed without your approval :(, if you have any concerns please share I'll try to address as a post commit thing or if you want I can revert it.
@schweitz, fir-ops.fir is marked as Unsupported. Seems like tco is not ready ?
// RUN: tco -emit-fir %s | tco -emit-fir | FileCheck %s // UNSUPPORTED: !fir
Built and tested locally.
Jan 28 2021
LGTM! Please wait for @sameeranjoshi to have a look.
Jan 27 2021
Jan 26 2021
Thanks! LGTM! Same approach I followed in openmp work, keeping test cases short and dedicated for instance (a directive and all it's assoicated clauses). It pays off in diagnosing/modifying when some test case fails(due to 2 branch development).
Jan 12 2021
Jan 5 2021
LGTM! - Thanks!
Dec 20 2020
Dec 17 2020
LGTM! Thanks for the patch.
One small thing, do you mind adding a one liner to release notes ? It would help in tracking extensions to Debug Metadata(previous extensions of DIModule were part of LLVM11).
Dec 15 2020
Thanks! for the patch, some minor comments inlined. Rest LGTM. Let others also have a look.
Dec 11 2020
LGTM Thank You @Meinersbur for taking out time :).
Dec 9 2020
Thanks for the patch! Some NIT's related to refactoring/moving inline. I've tried to highlight some parts, if you like the idea in general, there might be more opportunities to reduce the size of this patch(thus capturing the most crucial part tileLoop).
Dec 8 2020
Dec 7 2020
Dec 6 2020
Dec 4 2020
Dec 3 2020
LGTM Thanks! Please wait for @aprantl for any comments/approval.