User Details
- User Since
- Nov 26 2020, 5:33 AM (83 w, 5 d)
Today
Yesterday
Thu, Jun 30
Thanks for working on this patch. I think we need to add a testcase in flang/test/Lower/OpenMP/simd.f90
Mon, Jun 27
Rebasing. Also did not attempt to move this before loop-bounds creation (will not be a simple fix IMHO), adding a TODO
Mon, Jun 13
Mon, Jun 6
Fixing fortran->FIR testcase after rebasing.
Rebase before land
May 30 2022
Adding testcase, thanks @kiranchandramohan
Rebase before land
Rebasing and fixing minor stuff based on comments.
May 16 2022
Addressing reviewers comments. No test case for clauses could be added as we currently support simd without any clauses
Addressing reviewers comments. No test case for clauses could be added as we currently support simd without any clauses
May 10 2022
Fixing the test case
May 9 2022
Apr 11 2022
LGTM
Apr 7 2022
- Do we need a verifier for this?
- If yes, then we should add test cases (in invalid.mlir). Also we probably should add a test case to verify the printer in ops.mlir.
Mar 21 2022
@shraiysh Thanks for the comments. I have already addressed @kiranchandramohan 's comments as much as I could. If you are OK, can you please accept this patch, because Kiran might be busy. Thank you
Mar 15 2022
Mar 14 2022
Rebase on main and fix line character count
Mar 7 2022
Addressing reviewers' comments
Mar 1 2022
Addressing reviewers' comments.
Jan 24 2022
Jan 19 2022
Jan 18 2022
Making any_of one-liner.
- Trying to tackle a test failure
- Adding any_of() as per reviewer's suggestion.
Jan 17 2022
Updating as per reviewers comments.
Dec 17 2021
Addressing reviewers comments:
Dec 13 2021
Thanks @Meinersbur for the comments. Addressing reviewers comments:
Dec 6 2021
Addressing reviewers comments Major changes are as follows:
- Skipping unsupported clauses and skip the case when there is an ordered directive inside the simd construct
- Traversing all the blocks in the Canonical loop body (not only the first block of the loop body) to look for locations to insert metadata
- Making metadata unique for each Canonical loop
- Update test case to reflect changes.
Dec 1 2021
Nov 22 2021
Oct 5 2021
Sep 22 2021
Sep 13 2021
Sep 9 2021
Updated changes as per comments.
Aug 24 2021
Aug 16 2021
Aug 13 2021
Aug 4 2021
Jul 27 2021
Jul 14 2021
I will land this patch for him @kiranchandramohan , thanks for reviewing.
Jun 18 2021
Jun 8 2021
Using the recently introduced OmpDirectiveSet workShareSet to do the nesting check.
Jun 4 2021
May 13 2021
Updating the algorithm as per suggestion, to skip collection of loop induction variable if no linear clause is found
May 7 2021
Removing master construct from the error set.
May 6 2021
Updating the patch to use the recent merged workShareSet (that included tests for combined constructs for worksharing loops).
May 5 2021
Using a variable to identify SIMD nesting as per suggestion to avoid expensive traversals.
Apr 29 2021
Addressing comments.
Apr 28 2021
Small change in function docstring as per reviewers suggestion.
Addressing reviewers' comments, avoiding additional traversals of the parse tree nodes.
Apr 27 2021
Addressing comments.
LGTM
Apr 26 2021
Addressing reviewers comments: