User Details
User Details
- User Since
- Nov 26 2020, 5:33 AM (83 w, 5 d)
Today
Today
arnamoy10 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Yesterday
Yesterday
arnamoy10 added inline comments to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Thu, Jun 30
Thu, Jun 30
arnamoy10 added a comment to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Thanks for working on this patch. I think we need to add a testcase in flang/test/Lower/OpenMP/simd.f90
Mon, Jun 27
Mon, Jun 27
arnamoy10 updated the diff for D127137: [flang][OpenMP] Fix firstprivate bug.
Rebasing. Also did not attempt to move this before loop-bounds creation (will not be a simple fix IMHO), adding a TODO
Mon, Jun 13
Mon, Jun 13
arnamoy10 committed rG3f4a63e5f882: [Flang][OpenMP] Implementation of lowering of SIMD construct. (authored by arnamoy10).
[Flang][OpenMP] Implementation of lowering of SIMD construct.
Mon, Jun 6
Mon, Jun 6
arnamoy10 requested review of D127137: [flang][OpenMP] Fix firstprivate bug.
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Fixing fortran->FIR testcase after rebasing.
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Rebase before land
May 30 2022
May 30 2022
arnamoy10 committed rG314abe3922c1: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal… (authored by arnamoy10).
[flang][OpenMP] Check for occurrence of multiple list items in nontemporal…
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Adding testcase, thanks @kiranchandramohan
arnamoy10 updated the diff for D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.
Rebase before land
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Rebasing and fixing minor stuff based on comments.
May 16 2022
May 16 2022
arnamoy10 added inline comments to D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Addressing reviewers comments. No test case for clauses could be added as we currently support simd without any clauses
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Addressing reviewers comments. No test case for clauses could be added as we currently support simd without any clauses
May 10 2022
May 10 2022
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Fixing the test case
May 9 2022
May 9 2022
arnamoy10 requested review of D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Apr 11 2022
Apr 11 2022
LGTM
Apr 11 2022, 6:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Apr 7 2022
Apr 7 2022
arnamoy10 added a comment to D123350: [MLIR][OpenMP] Add support for threadprivate directive.
- Do we need a verifier for this?
- If yes, then we should add test cases (in invalid.mlir). Also we probably should add a test case to verify the printer in ops.mlir.
Apr 7 2022, 7:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Mar 21 2022
Mar 21 2022
arnamoy10 updated the diff for D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.
@shraiysh Thanks for the comments. I have already addressed @kiranchandramohan 's comments as much as I could. If you are OK, can you please accept this patch, because Kiran might be busy. Thank you
Mar 15 2022
Mar 15 2022
arnamoy10 committed rG0e9198c3e95a: [MLIR][OpenMP] Add support for basic SIMD construct (authored by arnamoy10).
[MLIR][OpenMP] Add support for basic SIMD construct
Mar 15 2022, 6:41 AM · Restricted Project
Mar 14 2022
Mar 14 2022
arnamoy10 updated the diff for D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Rebase on main and fix line character count
Mar 7 2022
Mar 7 2022
arnamoy10 added inline comments to D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
arnamoy10 updated the diff for D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Addressing reviewers' comments
Mar 1 2022
Mar 1 2022
arnamoy10 added inline comments to D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
arnamoy10 updated the diff for D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Addressing reviewers' comments.
Jan 24 2022
Jan 24 2022
arnamoy10 requested review of D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Jan 19 2022
Jan 19 2022
arnamoy10 committed rG9fbd33ad623d: [OMPIRBuilder] Add support for simd (loop) directive. (authored by arnamoy10).
[OMPIRBuilder] Add support for simd (loop) directive.
Jan 18 2022
Jan 18 2022
arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Making any_of one-liner.
arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..
- Trying to tackle a test failure
- Adding any_of() as per reviewer's suggestion.
Jan 17 2022
Jan 17 2022
arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Updating as per reviewers comments.
Dec 17 2021
Dec 17 2021
arnamoy10 updated the diff for D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.
Addressing reviewers comments:
Dec 13 2021
Dec 13 2021
arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Thanks @Meinersbur for the comments. Addressing reviewers comments:
Dec 6 2021
Dec 6 2021
arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Addressing reviewers comments Major changes are as follows:
- Skipping unsupported clauses and skip the case when there is an ordered directive inside the simd construct
- Traversing all the blocks in the Canonical loop body (not only the first block of the loop body) to look for locations to insert metadata
- Making metadata unique for each Canonical loop
- Update test case to reflect changes.
Dec 1 2021
Dec 1 2021
arnamoy10 added inline comments to D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Nov 22 2021
Nov 22 2021
arnamoy10 updated the summary of D114379: [OMPIRBuilder] Add support for simd (loop) directive..
arnamoy10 requested review of D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Oct 5 2021
Oct 5 2021
Herald added a project to D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive: Restricted Project.
Sep 22 2021
Sep 22 2021
Sep 13 2021
Sep 13 2021
arnamoy10 committed rGb9a8f34d476e: [flang][OpenMP] Add parsing support for nontemporal clause. (authored by arnamoy10).
[flang][OpenMP] Add parsing support for nontemporal clause.
Sep 13 2021, 12:23 PM · Restricted Project
Sep 9 2021
Sep 9 2021
arnamoy10 updated the diff for D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Updated changes as per comments.
Sep 9 2021, 11:03 AM · Restricted Project
Aug 24 2021
Aug 24 2021
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 24 2021, 12:52 PM · Restricted Project
Aug 16 2021
Aug 16 2021
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 16 2021, 6:22 AM · Restricted Project
Aug 13 2021
Aug 13 2021
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 13 2021, 12:51 PM · Restricted Project
arnamoy10 committed rG42f51107016c: [flang][OpenMP] Add semantic check for teams nesting (authored by peixin).
[flang][OpenMP] Add semantic check for teams nesting
Aug 13 2021, 7:42 AM · Restricted Project
arnamoy10 committed rG70894c8dd14d: [flang][OpenMP] Add semantic checks for cancellation nesting (authored by peixin).
[flang][OpenMP] Add semantic checks for cancellation nesting
Aug 13 2021, 7:11 AM · Restricted Project
Aug 4 2021
Aug 4 2021
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 4 2021, 8:36 AM · Restricted Project
Jul 27 2021
Jul 27 2021
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Jul 27 2021, 4:48 PM · Restricted Project
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Jul 27 2021, 1:29 PM · Restricted Project
arnamoy10 added reviewers for D106896: [flang][OpenMP] Add parsing support for nontemporal clause.: kiranchandramohan, bryanpkc, clementval.
Jul 27 2021, 10:50 AM · Restricted Project
arnamoy10 requested review of D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Jul 27 2021, 10:49 AM · Restricted Project
Jul 14 2021
Jul 14 2021
arnamoy10 committed rG67002b5f20c2: [flang][OpenMP] Fix semantic check of test case in taskloop simd construct (authored by peixin).
[flang][OpenMP] Fix semantic check of test case in taskloop simd construct
arnamoy10 closed D105874: [flang][OpenMP] Fix semantic check of test case in taskloop simd construct.
Jul 14 2021, 7:33 AM · Restricted Project
arnamoy10 added a comment to D105874: [flang][OpenMP] Fix semantic check of test case in taskloop simd construct.
I will land this patch for him @kiranchandramohan , thanks for reviewing.
Jul 14 2021, 6:39 AM · Restricted Project
Jun 18 2021
Jun 18 2021
arnamoy10 committed rG8fdd475c8563: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions (authored by arnamoy10).
[flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions
arnamoy10 added inline comments to D104229: [flang][docs] Add documentation for the new Flang driver.
Jun 8 2021
Jun 8 2021
arnamoy10 added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
arnamoy10 updated the diff for D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Using the recently introduced OmpDirectiveSet workShareSet to do the nesting check.
Jun 4 2021
Jun 4 2021
arnamoy10 committed rGf2622a150ade: [flang][OpenMP] Add semantic check to allow only loop iteration variables in a… (authored by arnamoy10).
[flang][OpenMP] Add semantic check to allow only loop iteration variables in a…
May 13 2021
May 13 2021
arnamoy10 committed rGb766576d38d3: [flang][OpenMP] Add semantic check for close nesting of `master` regions (authored by arnamoy10).
[flang][OpenMP] Add semantic check for close nesting of `master` regions
arnamoy10 updated the diff for D100224: [flang][OpenMP] Add semantic check for occurrence of variables other than loop iteration variable in a `linear` clause associated with a `distribute` construct..
Updating the algorithm as per suggestion, to skip collection of loop induction variable if no linear clause is found
May 7 2021
May 7 2021
arnamoy10 added inline comments to D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
arnamoy10 updated the diff for D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
Removing master construct from the error set.
May 6 2021
May 6 2021
arnamoy10 updated the diff for D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
Updating the patch to use the recent merged workShareSet (that included tests for combined constructs for worksharing loops).
arnamoy10 committed rGa40b60995882: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a… (authored by arnamoy10).
[flang][OpenMP] Add semantic check for occurrence of constructs nested inside a…
May 5 2021
May 5 2021
arnamoy10 added inline comments to D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
arnamoy10 updated the diff for D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
Using a variable to identify SIMD nesting as per suggestion to avoid expensive traversals.
Apr 29 2021
Apr 29 2021
arnamoy10 committed rG8f5a2a5836cc: [flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more… (authored by arnamoy10).
[flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more…
arnamoy10 committed rG79f7d3b7b123: [flang][OpenMP] Add semantic checks for strict nesting inside `teams` construct. (authored by arnamoy10).
[flang][OpenMP] Add semantic checks for strict nesting inside `teams` construct.
arnamoy10 updated the diff for D100575: [flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more constructs to cover entire workshare family..
Addressing comments.
Apr 28 2021
Apr 28 2021
arnamoy10 added inline comments to D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
arnamoy10 updated the diff for D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
Small change in function docstring as per reviewers suggestion.
arnamoy10 added inline comments to D100041: [flang][OpenMP] Add semantic checks for strict nesting inside `teams` construct..
arnamoy10 updated the diff for D100041: [flang][OpenMP] Add semantic checks for strict nesting inside `teams` construct..
Addressing reviewers' comments, avoiding additional traversals of the parse tree nodes.
Apr 27 2021
Apr 27 2021
arnamoy10 updated the diff for D100575: [flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more constructs to cover entire workshare family..
Addressing comments.
arnamoy10 added a comment to D101281: [flang] Remove `%f18` from LIT configuration files.
LGTM
arnamoy10 added inline comments to D101281: [flang] Remove `%f18` from LIT configuration files.
Apr 26 2021
Apr 26 2021
arnamoy10 added inline comments to D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
arnamoy10 updated the diff for D100224: [flang][OpenMP] Add semantic check for occurrence of variables other than loop iteration variable in a `linear` clause associated with a `distribute` construct..
Addressing reviewers comments:
Apr 25 2021
Apr 25 2021
arnamoy10 added a comment to D98657: [flang][driver] Add options for -Werror.
Apr 25 2021, 6:59 AM · Restricted Project
Apr 22 2021
Apr 22 2021
arnamoy10 committed rG4299ab6c5daf: [flang][driver][Revert] Reverts f18 to allow options passed to -W (authored by arnamoy10).
[flang][driver][Revert] Reverts f18 to allow options passed to -W