Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People arnamoy10

arnamoy10 (Arnamoy B)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 26 2020, 5:33 AM (148 w, 4 d)

Recent Activity
View All

Aug 10 2022

arnamoy10 added inline comments to D131526: [OMPIRBuilder] Add support for safelen clause.
Aug 10 2022, 6:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

arnamoy10 committed rG79a5ff45cbda: [Flang][Driver] Add support for AsmPrinter -mmlir options (authored by psoni2628).
[Flang][Driver] Add support for AsmPrinter -mmlir options
Jul 27 2022, 1:06 PM · Restricted Project, Restricted Project
arnamoy10 closed D130598: [Flang][Driver] Add support for AsmPrinter -mmlir options.
Jul 27 2022, 1:06 PM · Restricted Project, Restricted Project
arnamoy10 added a comment to D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..

Not sure why, in line 516 you will see a use.

Jul 27 2022, 11:55 AM · Restricted Project, Restricted Project
arnamoy10 accepted D130625: [NFC][flang] Post changes for D127137 and D130027.

LGTM

Jul 27 2022, 5:16 AM · Restricted Project, Restricted Project

Jul 26 2022

arnamoy10 added a comment to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.

LGTM.

Jul 26 2022, 10:19 AM · Restricted Project, Restricted Project, Restricted Project

Jul 25 2022

arnamoy10 committed rG17d9bdf46019: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop. (authored by arnamoy10).
[Flang][OpenMP] Add support for lastprivate clause for worksharing loop.
Jul 25 2022, 5:28 PM · Restricted Project, Restricted Project
arnamoy10 closed D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..
Jul 25 2022, 5:28 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..

fixing clang-format

Jul 25 2022, 4:26 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..

Addressing comments before landing

Jul 25 2022, 2:30 PM · Restricted Project, Restricted Project
arnamoy10 added inline comments to D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..
Jul 25 2022, 2:19 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..

Addressing all reviewers comments and adding TODOs and more test cases as per suggestion.

Jul 25 2022, 8:53 AM · Restricted Project, Restricted Project

Jul 20 2022

arnamoy10 requested changes to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.
  1. Can we have a test case in invalid.mlir
  2. Can we have a testcase where the simdlen is specified through a function argument or a local variable?
Jul 20 2022, 6:45 PM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 updated the diff for D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..

camelBack-ization!

Jul 20 2022, 4:06 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..
  1. Handling the control flow through scf.if
  2. Trying to fix the test case.
Jul 20 2022, 3:46 PM · Restricted Project, Restricted Project
arnamoy10 added a comment to D130195: [Flang][MLIR][OpenMP] Add support for simdlen clause.

Thanks for working on this patch. Can we add a verifier for
simdlen to error when the given value is negative? From the OpenMP standards "The parameter of the simdlen clause must be a constant positive integer expression."

Jul 20 2022, 12:26 PM · Restricted Project, Restricted Project, Restricted Project

Jul 18 2022

arnamoy10 requested review of D130027: [Flang][OpenMP] Add support for lastprivate clause for worksharing loop..
Jul 18 2022, 10:14 AM · Restricted Project, Restricted Project

Jul 11 2022

arnamoy10 committed rGac892c70a456: [OMPIRBuilder] Add support for simdlen clause (authored by psoni2628).
[OMPIRBuilder] Add support for simdlen clause
Jul 11 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
arnamoy10 closed D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 11 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
arnamoy10 committed rGd507e8b70e46: [flang][OpenMP] Fix firstprivate bug (authored by arnamoy10).
[flang][OpenMP] Fix firstprivate bug
Jul 11 2022, 5:57 AM · Restricted Project, Restricted Project
arnamoy10 closed D127137: [flang][OpenMP] Fix firstprivate bug.
Jul 11 2022, 5:57 AM · Restricted Project, Restricted Project

Jul 10 2022

arnamoy10 updated the diff for D127137: [flang][OpenMP] Fix firstprivate bug.

Rebase, update comment and code to reflect reviewer's comments.

Jul 10 2022, 6:20 AM · Restricted Project, Restricted Project

Jul 5 2022

arnamoy10 added inline comments to D129149: [OMPIRBuilder] Add support for simdlen clause.
Jul 5 2022, 12:28 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 4 2022

arnamoy10 added inline comments to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.
Jul 4 2022, 4:55 AM · Restricted Project, Restricted Project, Restricted Project

Jun 30 2022

arnamoy10 added a comment to D128940: [mlir][OpenMP] Add if clause to OpenMP simd construct.

Thanks for working on this patch. I think we need to add a testcase in flang/test/Lower/OpenMP/simd.f90

Jun 30 2022, 7:40 PM · Restricted Project, Restricted Project, Restricted Project

Jun 27 2022

arnamoy10 updated the diff for D127137: [flang][OpenMP] Fix firstprivate bug.

Rebasing. Also did not attempt to move this before loop-bounds creation (will not be a simple fix IMHO), adding a TODO

Jun 27 2022, 11:30 AM · Restricted Project, Restricted Project

Jun 13 2022

arnamoy10 committed rG3f4a63e5f882: [Flang][OpenMP] Implementation of lowering of SIMD construct. (authored by arnamoy10).
[Flang][OpenMP] Implementation of lowering of SIMD construct.
Jun 13 2022, 6:43 AM · Restricted Project, Restricted Project
arnamoy10 closed D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
Jun 13 2022, 6:42 AM · Restricted Project, Restricted Project

Jun 6 2022

arnamoy10 requested review of D127137: [flang][OpenMP] Fix firstprivate bug.
Jun 6 2022, 11:28 AM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Fixing fortran->FIR testcase after rebasing.

Jun 6 2022, 8:48 AM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Rebase before land

Jun 6 2022, 7:21 AM · Restricted Project, Restricted Project

May 30 2022

arnamoy10 committed rG314abe3922c1: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal… (authored by arnamoy10).
[flang][OpenMP] Check for occurrence of multiple list items in nontemporal…
May 30 2022, 7:55 AM · Restricted Project, Restricted Project
arnamoy10 closed D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.
May 30 2022, 7:55 AM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Adding testcase, thanks @kiranchandramohan

May 30 2022, 7:53 AM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.

Rebase before land

May 30 2022, 7:07 AM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Rebasing and fixing minor stuff based on comments.

May 30 2022, 7:05 AM · Restricted Project, Restricted Project

May 16 2022

arnamoy10 added inline comments to D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
May 16 2022, 5:28 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Addressing reviewers comments. No test case for clauses could be added as we currently support simd without any clauses

May 16 2022, 5:28 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Addressing reviewers comments. No test case for clauses could be added as we currently support simd without any clauses

May 16 2022, 5:26 PM · Restricted Project, Restricted Project

May 10 2022

arnamoy10 updated the diff for D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..

Fixing the test case

May 10 2022, 6:22 AM · Restricted Project, Restricted Project

May 9 2022

arnamoy10 requested review of D125282: [Flang][OpenMP] Implementation of lowering of SIMD construct..
May 9 2022, 5:12 PM · Restricted Project, Restricted Project

Apr 11 2022

arnamoy10 accepted D123350: [MLIR][OpenMP] Add support for threadprivate directive.

LGTM

Apr 11 2022, 6:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

arnamoy10 added a comment to D123350: [MLIR][OpenMP] Add support for threadprivate directive.
  1. Do we need a verifier for this?
  2. If yes, then we should add test cases (in invalid.mlir). Also we probably should add a test case to verify the printer in ops.mlir.
Apr 7 2022, 7:26 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Mar 21 2022

arnamoy10 updated the diff for D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.

@shraiysh Thanks for the comments. I have already addressed @kiranchandramohan 's comments as much as I could. If you are OK, can you please accept this patch, because Kiran might be busy. Thank you

Mar 21 2022, 1:36 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

arnamoy10 committed rG0e9198c3e95a: [MLIR][OpenMP] Add support for basic SIMD construct (authored by arnamoy10).
[MLIR][OpenMP] Add support for basic SIMD construct
Mar 15 2022, 6:41 AM · Restricted Project
arnamoy10 closed D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Mar 15 2022, 6:41 AM · Restricted Project, Restricted Project

Mar 14 2022

arnamoy10 updated the diff for D118065: [MLIR][OpenMP] Add support for basic SIMD construct.

Rebase on main and fix line character count

Mar 14 2022, 1:05 PM · Restricted Project, Restricted Project

Mar 7 2022

arnamoy10 added inline comments to D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Mar 7 2022, 9:13 AM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D118065: [MLIR][OpenMP] Add support for basic SIMD construct.

Addressing reviewers' comments

Mar 7 2022, 9:13 AM · Restricted Project, Restricted Project

Mar 1 2022

arnamoy10 added inline comments to D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Mar 1 2022, 7:47 AM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D118065: [MLIR][OpenMP] Add support for basic SIMD construct.

Addressing reviewers' comments.

Mar 1 2022, 7:47 AM · Restricted Project, Restricted Project

Jan 24 2022

arnamoy10 requested review of D118065: [MLIR][OpenMP] Add support for basic SIMD construct.
Jan 24 2022, 12:31 PM · Restricted Project, Restricted Project

Jan 19 2022

arnamoy10 committed rG9fbd33ad623d: [OMPIRBuilder] Add support for simd (loop) directive. (authored by arnamoy10).
[OMPIRBuilder] Add support for simd (loop) directive.
Jan 19 2022, 8:29 AM
arnamoy10 closed D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Jan 19 2022, 8:29 AM · Restricted Project, Restricted Project

Jan 18 2022

arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..

Making any_of one-liner.

Jan 18 2022, 12:48 PM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..
  1. Trying to tackle a test failure
  2. Adding any_of() as per reviewer's suggestion.
Jan 18 2022, 6:43 AM · Restricted Project, Restricted Project

Jan 17 2022

arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..

Updating as per reviewers comments.

Jan 17 2022, 1:33 PM · Restricted Project, Restricted Project

Dec 17 2021

arnamoy10 added inline comments to D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.
Dec 17 2021, 2:56 PM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 updated the diff for D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.

Addressing reviewers comments:

Dec 17 2021, 2:56 PM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2021

arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..

Thanks @Meinersbur for the comments. Addressing reviewers comments:

Dec 13 2021, 1:47 PM · Restricted Project, Restricted Project

Dec 6 2021

arnamoy10 updated the diff for D114379: [OMPIRBuilder] Add support for simd (loop) directive..

Addressing reviewers comments Major changes are as follows:

  1. Skipping unsupported clauses and skip the case when there is an ordered directive inside the simd construct
  2. Traversing all the blocks in the Canonical loop body (not only the first block of the loop body) to look for locations to insert metadata
  3. Making metadata unique for each Canonical loop
  4. Update test case to reflect changes.
Dec 6 2021, 2:38 PM · Restricted Project, Restricted Project

Dec 1 2021

arnamoy10 added inline comments to D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Dec 1 2021, 7:37 AM · Restricted Project, Restricted Project

Nov 22 2021

arnamoy10 updated the summary of D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Nov 22 2021, 9:40 AM · Restricted Project, Restricted Project
arnamoy10 requested review of D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Nov 22 2021, 9:39 AM · Restricted Project, Restricted Project

Oct 5 2021

Herald added a project to D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive: Restricted Project.
Oct 5 2021, 6:27 AM · Restricted Project, Restricted Project, Restricted Project

Sep 22 2021

arnamoy10 requested review of D110270: [flang][OpenMP] Check for occurrence of multiple list items in nontemporal clause for simd directive.
Sep 22 2021, 10:22 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2021

arnamoy10 committed rGb9a8f34d476e: [flang][OpenMP] Add parsing support for nontemporal clause. (authored by arnamoy10).
[flang][OpenMP] Add parsing support for nontemporal clause.
Sep 13 2021, 12:23 PM
arnamoy10 closed D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Sep 13 2021, 12:23 PM · Restricted Project

Sep 9 2021

arnamoy10 updated the diff for D106896: [flang][OpenMP] Add parsing support for nontemporal clause..

Updated changes as per comments.

Sep 9 2021, 11:03 AM · Restricted Project

Aug 24 2021

arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 24 2021, 12:52 PM · Restricted Project

Aug 16 2021

arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 16 2021, 6:22 AM · Restricted Project

Aug 13 2021

arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 13 2021, 12:51 PM · Restricted Project
arnamoy10 committed rG42f51107016c: [flang][OpenMP] Add semantic check for teams nesting (authored by peixin).
[flang][OpenMP] Add semantic check for teams nesting
Aug 13 2021, 7:42 AM
arnamoy10 closed D106335: [flang][OpenMP] Add semantic check for teams nesting.
Aug 13 2021, 7:42 AM · Restricted Project
arnamoy10 committed rG70894c8dd14d: [flang][OpenMP] Add semantic checks for cancellation nesting (authored by peixin).
[flang][OpenMP] Add semantic checks for cancellation nesting
Aug 13 2021, 7:11 AM
arnamoy10 closed D106538: [flang][OpenMP] Add semantic check for cancellation nesting.
Aug 13 2021, 7:11 AM · Restricted Project

Aug 4 2021

arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Aug 4 2021, 8:36 AM · Restricted Project

Jul 27 2021

arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Jul 27 2021, 4:48 PM · Restricted Project
arnamoy10 added inline comments to D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Jul 27 2021, 1:29 PM · Restricted Project
arnamoy10 added reviewers for D106896: [flang][OpenMP] Add parsing support for nontemporal clause.: kiranchandramohan, bryanpkc, clementval.
Jul 27 2021, 10:50 AM · Restricted Project
arnamoy10 requested review of D106896: [flang][OpenMP] Add parsing support for nontemporal clause..
Jul 27 2021, 10:49 AM · Restricted Project

Jul 14 2021

arnamoy10 committed rG67002b5f20c2: [flang][OpenMP] Fix semantic check of test case in taskloop simd construct (authored by peixin).
[flang][OpenMP] Fix semantic check of test case in taskloop simd construct
Jul 14 2021, 7:33 AM
arnamoy10 closed D105874: [flang][OpenMP] Fix semantic check of test case in taskloop simd construct.
Jul 14 2021, 7:33 AM · Restricted Project
arnamoy10 added a comment to D105874: [flang][OpenMP] Fix semantic check of test case in taskloop simd construct.

I will land this patch for him @kiranchandramohan , thanks for reviewing.

Jul 14 2021, 6:39 AM · Restricted Project

Jun 18 2021

arnamoy10 committed rG8fdd475c8563: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions (authored by arnamoy10).
[flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions
Jun 18 2021, 1:23 PM
arnamoy10 closed D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Jun 18 2021, 1:23 PM · Restricted Project, Restricted Project
arnamoy10 added inline comments to D104229: [flang][docs] Add documentation for the new Flang driver.
Jun 18 2021, 5:50 AM · Restricted Project, Restricted Project

Jun 8 2021

arnamoy10 added inline comments to D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.
Jun 8 2021, 5:57 AM · Restricted Project, Restricted Project
arnamoy10 updated the diff for D99888: [flang][OpenMP] Add semantic checks for occurrence of nested Barrier regions.

Using the recently introduced OmpDirectiveSet workShareSet to do the nesting check.

Jun 8 2021, 5:57 AM · Restricted Project, Restricted Project

Jun 4 2021

arnamoy10 committed rGf2622a150ade: [flang][OpenMP] Add semantic check to allow only loop iteration variables in a… (authored by arnamoy10).
[flang][OpenMP] Add semantic check to allow only loop iteration variables in a…
Jun 4 2021, 2:31 PM
arnamoy10 closed D100224: [flang][OpenMP] Add semantic check for occurrence of variables other than loop iteration variable in a `linear` clause associated with a `distribute` construct..
Jun 4 2021, 2:31 PM · Restricted Project, Restricted Project, Restricted Project

May 13 2021

arnamoy10 committed rGb766576d38d3: [flang][OpenMP] Add semantic check for close nesting of `master` regions (authored by arnamoy10).
[flang][OpenMP] Add semantic check for close nesting of `master` regions
May 13 2021, 11:59 AM
arnamoy10 closed D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
May 13 2021, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 added inline comments to D100224: [flang][OpenMP] Add semantic check for occurrence of variables other than loop iteration variable in a `linear` clause associated with a `distribute` construct..
May 13 2021, 11:46 AM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 updated the diff for D100224: [flang][OpenMP] Add semantic check for occurrence of variables other than loop iteration variable in a `linear` clause associated with a `distribute` construct..

Updating the algorithm as per suggestion, to skip collection of loop induction variable if no linear clause is found

May 13 2021, 11:46 AM · Restricted Project, Restricted Project, Restricted Project

May 7 2021

arnamoy10 added inline comments to D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.
May 7 2021, 7:57 AM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 updated the diff for D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.

Removing master construct from the error set.

May 7 2021, 7:57 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2021

arnamoy10 updated the diff for D100228: [flang][OpenMP] Add semantic check for close nesting of `master` regions.

Updating the patch to use the recent merged workShareSet (that included tests for combined constructs for worksharing loops).

May 6 2021, 1:09 PM · Restricted Project, Restricted Project, Restricted Project
arnamoy10 committed rGa40b60995882: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a… (authored by arnamoy10).
[flang][OpenMP] Add semantic check for occurrence of constructs nested inside a…
May 6 2021, 12:08 PM
arnamoy10 closed D99757: [flang][OpenMP] Add semantic check for occurrence of constructs nested inside a SIMD region.
May 6 2021, 12:08 PM · Restricted Project, Restricted Project