Differential D99436

[OPENMP]Fix PR49366: crash on VLAs in task untied regions.
Needs ReviewPublic
Actions

Authored by ABataev on Mar 26 2021, 12:51 PM.

Tags

Subscribers

Details

Reviewers

Summary

We need to capture the local variables into a record in task untied
regions but clang does not support record with VLA data members.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	2,230 ms	x64 debian > libarcher.races::lock-unrelated.c Script: -- : 'RUN: at line 13'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -Wl,-rpath,/mnt/disks/ssd0/agent/llvm-project/build/lib /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/deflake.bash /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp 2>&1 \| tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp.log \| /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c

Event Timeline

ABataev created this revision.Mar 26 2021, 12:51 PM

Herald added subscribers: guansong, yaxunl. · View Herald TranscriptMar 26 2021, 12:51 PM

ABataev requested review of this revision.Mar 26 2021, 12:51 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 12:51 PM

Herald added a subscriber: sstefan1. · View Herald Transcript

Harbormaster completed remote builds in B95920: Diff 333610.Mar 26 2021, 1:27 PM

Rebase

Harbormaster completed remote builds in B99178: Diff 338114.Fri, Apr 16, 9:01 AM

Rebase

Harbormaster completed remote builds in B101203: Diff 340887.Tue, Apr 27, 11:06 AM

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

Basic/

DiagnosticSemaKinds.td

2 lines

Sema/

4 lines

lib/

Sema/

16 lines

3 lines

test/

OpenMP/

task_messages.cpp

8 lines

taskloop_loop_messages.cpp

9 lines

Diff 340887

clang/include/clang/Basic/DiagnosticSemaKinds.td

Loading...

clang/include/clang/Sema/Sema.h

Loading...

clang/lib/Sema/SemaOpenMP.cpp

Loading...

clang/lib/Sema/SemaType.cpp

Loading...

clang/test/OpenMP/task_messages.cpp

Loading...

clang/test/OpenMP/taskloop_loop_messages.cpp

Loading...