Page MenuHomePhabricator
Differential D99436

[OPENMP]Fix PR49366: crash on VLAs in task untied regions.
ClosedPublic
Actions

Authored by ABataev on Mar 26 2021, 12:51 PM.

Details

Reviewers
jdoerfert
mikerice
Commits
rGf9c3310d32c6: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.
Summary

We need to capture the local variables into a record in task untied
regions but clang does not support record with VLA data members.

Diff Detail

Event Timeline

ABataev created this revision.Mar 26 2021, 12:51 PM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptMar 26 2021, 12:51 PM
ABataev requested review of this revision.Mar 26 2021, 12:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2021, 12:51 PM
Herald added a subscriber: sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B95920: Diff 333610.Mar 26 2021, 1:27 PM
ABataev updated this revision to Diff 338114.Apr 16 2021, 7:47 AM

Rebase

Harbormaster completed remote builds in B99178: Diff 338114.Apr 16 2021, 9:01 AM
ABataev updated this revision to Diff 340887.Apr 27 2021, 9:41 AM

Rebase

Harbormaster completed remote builds in B101203: Diff 340887.Apr 27 2021, 11:06 AM
ABataev updated this revision to Diff 345565.May 14 2021, 2:28 PM

Rebase

Harbormaster completed remote builds in B104598: Diff 345565.May 14 2021, 3:40 PM
ABataev updated this revision to Diff 349627.Jun 3 2021, 11:46 AM

Rebase

Harbormaster completed remote builds in B107506: Diff 349627.Jun 3 2021, 12:52 PM
ABataev updated this revision to Diff 350870.Jun 9 2021, 5:54 AM

Ping

Harbormaster completed remote builds in B108397: Diff 350870.Jun 9 2021, 7:02 AM
ABataev updated this revision to Diff 356726.Jul 6 2021, 8:00 AM

Rebase

Harbormaster completed remote builds in B112621: Diff 356726.Jul 6 2021, 8:50 AM
ABataev updated this revision to Diff 357616.Jul 9 2021, 1:21 PM

Rebase

Harbormaster completed remote builds in B113273: Diff 357616.Jul 9 2021, 2:53 PM
ABataev updated this revision to Diff 360553.Jul 21 2021, 12:21 PM

Rebase

Harbormaster completed remote builds in B115386: Diff 360553.Jul 21 2021, 2:07 PM
ABataev added a comment.Jul 22 2021, 4:34 AM

Better to fix this before the next release.

ABataev updated this revision to Diff 368393.Aug 24 2021, 10:39 AM

Rebase

Harbormaster completed remote builds in B120998: Diff 368393.Aug 24 2021, 11:45 AM
ABataev updated this revision to Diff 376914.Oct 4 2021, 8:57 AM

Rebase

Harbormaster completed remote builds in B126837: Diff 376914.Oct 4 2021, 8:57 AM
ABataev updated this revision to Diff 396524.Dec 29 2021, 6:16 AM

Rebase

ABataev added a reviewer: mikerice.Dec 29 2021, 6:16 AM
Harbormaster completed remote builds in B140892: Diff 396524.Dec 29 2021, 6:51 AM
ABataev updated this revision to Diff 405968.Feb 4 2022, 7:40 AM

Rebase

Harbormaster completed remote builds in B147629: Diff 405968.Feb 4 2022, 8:16 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 21 2022, 12:30 PM
This revision was landed with ongoing or failed builds.
Closed by commit rGf9c3310d32c6: [OPENMP]Fix PR49366: crash on VLAs in task untied regions. (authored by ABataev). · Explain Why
This revision was automatically updated to reflect the committed changes.
ABataev added a commit: rGf9c3310d32c6: [OPENMP]Fix PR49366: crash on VLAs in task untied regions..

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Basic/
2 lines
Sema/
4 lines
lib/
Sema/
16 lines
3 lines
test/
OpenMP/
8 lines
9 lines

Diff 410366

View Options

clang/include/clang/Basic/DiagnosticSemaKinds.td

Loading...
View Options

clang/include/clang/Sema/Sema.h

Loading...
View Options

clang/lib/Sema/SemaOpenMP.cpp

Loading...
View Options

clang/lib/Sema/SemaType.cpp

Loading...
View Options

clang/test/OpenMP/task_messages.cpp

Loading...
View Options

clang/test/OpenMP/taskloop_loop_messages.cpp

Loading...