Page MenuHomePhabricator

Change OwningRewritePatternList to carry an MLIRContext with it.
ClosedPublic

Authored by lattner on Mar 20 2021, 4:30 PM.

Details

Summary

This updates the codebase to pass the context when creating an instance of
OwningRewritePatternList, and starts removing extraneous MLIRContext
parameters. There are many many more to be removed.

Diff Detail

Event Timeline

lattner created this revision.Mar 20 2021, 4:30 PM
lattner requested review of this revision.Mar 20 2021, 4:30 PM
lattner updated this revision to Diff 332136.Mar 20 2021, 4:39 PM

Remove some unnecessary #includes

LGTM, unless River has an objection :)

lattner accepted this revision.Mar 21 2021, 10:06 AM

Thanks Mehdi, I think this is a pretty obvious cleanup (and enables many others), so I'm going to land it.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 21 2021, 10:09 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.

Looks like a nice cleanup, I see:

LowerToAffineLoops.cpp:299:28: error: no matching constructor for initialization of 'mlir::OwningRewritePatternList'

OwningRewritePatternList patterns;
                         ^

in buildbot, was this fixed in follow up here? (my rebuild is being slow ...)

Thanks, I see that too, will fix.

I think Jacques already fixed, makes sure to be at HEAD before re-fixing the same one :)