Install clang-format.

Address comments.

Update comment.

Installed clang-format.

Thanks - this solves for the case I was talking to you about from my end.

Thanks!

In D49116#1158298, @starsid wrote:

In D49116#1158292, @dberris wrote:

One concern here would be whether this would even work on Windows, and whether it might make more sense to use a more portable scripting language to do it instead (say, Python). I don't use Windows so I'll let someone else who does (and uses Arcanist as well) to chime in as to whether this is going to be a problem.

I don't have a Windows machine to test, but maybe someone can port the bash script to python, while testing it on Windows. I don't mind if we don't commit this revision now, but someone takes over, and changes it to work on Windows.

Removed command line check.

Removed unit tests and examples.

Removed tests missed in the first commit.

In D77002#1948310, @mehdi_amini wrote:

Do why know why is this object so large? This may be an indication of something underlying to look at anyway.

Are you able to commit, or do you need me to do it?

Nice, thanks. Some small changes requested. Also, I would have expected cmake updates since you added a dep.

The core of this change lgtm modulo one bit on where to put the getChunkSize helper. I need river to weigh in on the ShapedType api update.

Some typos but lgtm. Thanks!

Do you need me to commit this on your behalf?