Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (132 w, 3 d)

Recent Activity

Yesterday

stellaraccident added a comment to D128230: [mlir] Leverage CMake interface libraries for mlir python.

Fixed in https://reviews.llvm.org/rGaa78c5298ea37f2ca8150dc0a1c880be7ec438f4

Mon, Jul 4, 7:08 AM · Restricted Project, Restricted Project
stellaraccident committed rGaa78c5298ea3: Fix MLIR Python CMake bug causing duplicate sources target. (authored by stellaraccident).
Fix MLIR Python CMake bug causing duplicate sources target.
Mon, Jul 4, 7:08 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D128230: [mlir] Leverage CMake interface libraries for mlir python.

FYI - this patch has a minor bug in it when used as part of larger projects. Line 214 creates duplicate target names in some cases. It needs to be scoped (like is done for the target just below it).

Mon, Jul 4, 7:04 AM · Restricted Project, Restricted Project

Tue, Jun 28

stellaraccident added a comment to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

I have some concerns with:

Define a register_dialects(registry: DialectRegistry) function that can extend the DialectRegistry that will be used to bootstrap the Context.
Define a context_init_hook(context: Context) function that will be added to a list of callbacks which will be invoked after dialect registration during Context initialization.

Because contrary to pass registration for example, there isn't a global context or global dialect registry in MLIR: that means that I should be able to create a context inside my python library and not have it "polluted" by something that was registered by another library for its own purpose.

That said this is still quite an big step forward from where we're at right now, even though I fear we may dig ourselves in a place where it'll be hard to get out of.

Tue, Jun 28, 7:10 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

I am not a huge fan of magic method / file names, but this is a common thing to do in Python. My only usability concern is about debugging:

with Context():
  ir.parse("custom.func @foo()",)

will work or break depending on where the Context is imported from: from mlir.ir import Context vs from custom.ir import Context. I suppose we can get used to it.

Tue, Jun 28, 7:09 AM · Restricted Project, Restricted Project

Mon, Jun 27

stellaraccident accepted D126446: [mlir] Allow for attaching external resources to .mlir files.

A few very minor nits, but otherwise lgtm.

Mon, Jun 27, 3:55 PM · Restricted Project, Restricted Project
stellaraccident updated the summary of D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..
Mon, Jun 27, 2:50 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Comments.

Mon, Jun 27, 2:33 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..
Mon, Jun 27, 2:33 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Move closer to end state.

Mon, Jun 27, 2:30 PM · Restricted Project, Restricted Project
stellaraccident planned changes to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Would you mind posting a PSA on the forum copying the change description and the tentative evolution plan?

Mon, Jun 27, 7:56 AM · Restricted Project, Restricted Project

Sun, Jun 26

Herald added a project to D104289: Implement an scf.for range folding optimization pass.: Restricted Project.

I think we need to revisit this patch as it is broken for some very common cases. Left notes here: https://github.com/llvm/llvm-project/issues/56235

Sun, Jun 26, 3:38 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D128616: [mlir] Generalize Affine transforms to work on FunctionOpInterface..

Fix fir test.

Sun, Jun 26, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
stellaraccident added a comment to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Do you believe that there is a place for a HowTo.md that makes downstream users really happy?

As in a "How to Integrate into a Downstream Project?" guide. Yes, we should create that.

Sun, Jun 26, 12:51 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Do you believe that there is a place for a HowTo.md that makes downstream users really happy?

Sun, Jun 26, 12:45 PM · Restricted Project, Restricted Project
stellaraccident added reviewers for D128616: [mlir] Generalize Affine transforms to work on FunctionOpInterface.: jpienaar, mehdi_amini.
Sun, Jun 26, 12:37 PM · Restricted Project, Restricted Project, Restricted Project
stellaraccident requested review of D128616: [mlir] Generalize Affine transforms to work on FunctionOpInterface..
Sun, Jun 26, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
stellaraccident added reviewers for D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities.: mehdi_amini, mikeurbach, ftynse.
Sun, Jun 26, 11:12 AM · Restricted Project, Restricted Project
stellaraccident committed rG54998986c3d9: [mlir] Generalize SCF passes to not have to run on FuncOp. (authored by stellaraccident).
[mlir] Generalize SCF passes to not have to run on FuncOp.
Sun, Jun 26, 11:05 AM · Restricted Project, Restricted Project
stellaraccident closed D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..
Sun, Jun 26, 11:05 AM · Restricted Project, Restricted Project
stellaraccident updated the diff for D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..

Rebase

Sun, Jun 26, 10:56 AM · Restricted Project, Restricted Project
stellaraccident added a reviewer for D128614: [mlir] Generalize SCF passes to not have to run on FuncOp.: jpienaar.
Sun, Jun 26, 10:40 AM · Restricted Project, Restricted Project
stellaraccident requested review of D128614: [mlir] Generalize SCF passes to not have to run on FuncOp..
Sun, Jun 26, 10:40 AM · Restricted Project, Restricted Project

Sat, Jun 25

stellaraccident requested review of D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..
Sat, Jun 25, 4:01 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D128230: [mlir] Leverage CMake interface libraries for mlir python.

Thank you for this. As we discussed on Discord, I didn't know about the inheritable sources on interface libraries, and that simplifies things. A couple of comments for my own education, but otherwise looks good.

Have you happened to have tested this with a downstream yet?

I made sure torch-mlir can build/test/install correctly both with a build and an install tree of mlir. I haven't tested other downstreams.

Sat, Jun 25, 12:23 AM · Restricted Project, Restricted Project

Fri, Jun 24

stellaraccident added inline comments to D128300: [mlir] Example/test code for Python binding of MLIR enum attributes.
Fri, Jun 24, 7:57 AM · Restricted Project, Restricted Project

Thu, Jun 23

stellaraccident accepted D128230: [mlir] Leverage CMake interface libraries for mlir python.

Thank you for this. As we discussed on Discord, I didn't know about the inheritable sources on interface libraries, and that simplifies things. A couple of comments for my own education, but otherwise looks good.

Thu, Jun 23, 5:23 PM · Restricted Project, Restricted Project
stellaraccident accepted D128245: [mlir][quant] output spec verification check for quant.region.
Thu, Jun 23, 5:15 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D128300: [mlir] Example/test code for Python binding of MLIR enum attributes.
Thu, Jun 23, 5:13 PM · Restricted Project, Restricted Project

Tue, Jun 21

stellaraccident added a comment to D128300: [mlir] Example/test code for Python binding of MLIR enum attributes.

(also sorry for some auto correct typos - on mobile)

Tue, Jun 21, 9:32 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D128300: [mlir] Example/test code for Python binding of MLIR enum attributes.

Thanks for this. Just one comment of the variety of "have you considered doing it entirely differently) :) I'm not convinced either way -- open to discuss

Tue, Jun 21, 9:31 PM · Restricted Project, Restricted Project

Sun, Jun 19

stellaraccident added a comment to D123774: Introduce a new Dense Array attribute.

Nice! Are the builtin dialect docs auto-generated somehow, or is there something we should update in this patch? (https://mlir.llvm.org/docs/Dialects/Builtin/#arrayattr)

Sun, Jun 19, 9:33 PM · Restricted Project, Restricted Project

Sat, Jun 18

stellaraccident added inline comments to D123774: Introduce a new Dense Array attribute.
Sat, Jun 18, 10:18 AM · Restricted Project, Restricted Project

Wed, Jun 15

stellaraccident committed rGbccf27d934b3: [mlir][python] Actually set UseLocalScope printing flag (authored by mabrowning).
[mlir][python] Actually set UseLocalScope printing flag
Wed, Jun 15, 10:03 PM · Restricted Project, Restricted Project
stellaraccident closed D127907: [mlir][python] Actually set UseLocalScope printing flag.
Wed, Jun 15, 10:03 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D127907: [mlir][python] Actually set UseLocalScope printing flag.

Thanks for the contribution. I'll land it at my next opportunity, then.

Wed, Jun 15, 2:56 PM · Restricted Project, Restricted Project
stellaraccident accepted D127907: [mlir][python] Actually set UseLocalScope printing flag.

Thanks - good catch. Do you have commit access to land?

Wed, Jun 15, 2:49 PM · Restricted Project, Restricted Project

Tue, Jun 14

stellaraccident accepted D127813: [mlir] Split MLProgram global load and store to Graph variants.

Thanks for doing this!

Tue, Jun 14, 6:24 PM · Restricted Project, Restricted Project

Mon, Jun 6

stellaraccident added a comment to D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build..

Idk - I haven't seen the failures. It passed presubmit Benoit I landed (phab says it didn't because I did a trivial rebase/addressed comments right before).

Mon, Jun 6, 7:45 AM · Restricted Project, Restricted Project

Sun, Jun 5

stellaraccident committed rG768a251587e4: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build. (authored by stellaraccident).
[mlir] Tunnel LLVM_USE_LINKER through to the standalone example build.
Sun, Jun 5, 12:36 PM · Restricted Project, Restricted Project
stellaraccident closed D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build..
Sun, Jun 5, 12:36 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build..

Nice. Would integration go to heavy then or still be separate? (I was even wondering if this test should be considered an integration test, and indeed this one is quite slow while not providing much signal, but we do want to make sure this flow isn't broken)

Sun, Jun 5, 12:33 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build..

comments and rebase

Sun, Jun 5, 12:32 PM · Restricted Project, Restricted Project

Jun 1 2022

stellaraccident committed rG3bb7999339c5: [mlir] Add global_load and global_store ops to ml_program. (authored by stellaraccident).
[mlir] Add global_load and global_store ops to ml_program.
Jun 1 2022, 11:33 AM · Restricted Project, Restricted Project
stellaraccident closed D126230: [mlir] Add global_load and global_store ops to ml_program..
Jun 1 2022, 11:32 AM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Remove braces.

Jun 1 2022, 11:29 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D126230: [mlir] Add global_load and global_store ops to ml_program..

Looks good thanks!

Jun 1 2022, 11:13 AM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Tweak based on comments.

Jun 1 2022, 11:12 AM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Bazel updates.

Jun 1 2022, 10:30 AM · Restricted Project, Restricted Project

May 31 2022

stellaraccident added inline comments to D126230: [mlir] Add global_load and global_store ops to ml_program..
May 31 2022, 7:42 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Comments.

May 31 2022, 7:39 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D126230: [mlir] Add global_load and global_store ops to ml_program..
May 31 2022, 2:25 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Comments

May 31 2022, 2:21 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D126230: [mlir] Add global_load and global_store ops to ml_program..
May 31 2022, 1:29 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D126446: [mlir] Allow for attaching external resources to .mlir files.

What about using directly YAML for this section?

I considered, but ultimately it felt like more complexity than the benefits it brought (especially for this draft). Having something
just for us felt much simpler and more expressive (we could use Attributes/Types for config values if we wanted). I could likely be
convinced otherwise though, using something like YAML would conceptually make supporting more complex config values
easier (nested structs and stuff) if we wanted to go that approach. There are tradeoffs though (e.g. error reporting, attribute/type values,
still need a generic interface to enable seamless bitcode integration, etc.).

May 31 2022, 9:20 AM · Restricted Project, Restricted Project

May 29 2022

stellaraccident added inline comments to D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.
May 29 2022, 8:36 AM · Restricted Project, Restricted Project

May 28 2022

stellaraccident accepted D124685: [mlir][tosa] Moves constant folding operations out of the Canonicalizer.

Generally LGTM, although we may want to further constrain this in a follow-up. In general, I am pro having optimization passes and having them be truly optional. I would be tempted to name this "TensorDataConstantOptimizationPass".

May 28 2022, 5:51 PM · Restricted Project, Restricted Project

May 27 2022

stellaraccident added reviewers for D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build.: bondhugula, mehdi_amini.
May 27 2022, 8:19 PM · Restricted Project, Restricted Project
stellaraccident requested review of D126585: [mlir] Tunnel LLVM_USE_LINKER through to the standalone example build..
May 27 2022, 8:19 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Add chains.

May 27 2022, 7:35 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D126230: [mlir] Add global_load and global_store ops to ml_program..

Comments

May 27 2022, 5:18 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D126230: [mlir] Add global_load and global_store ops to ml_program..
May 27 2022, 5:18 PM · Restricted Project, Restricted Project

May 25 2022

stellaraccident added a reviewer for D126422: [mlir][python][ctypes] fix ctype python binding complication for complex: mehdi_amini.

I think Mehdi wrote some of this originally. I'll review as well but need to study it...

May 25 2022, 8:23 PM · Restricted Project, Restricted Project

May 24 2022

stellaraccident added a comment to D126230: [mlir] Add global_load and global_store ops to ml_program..

*breathes a sigh of relief that no ODS bugs were stepped on*

May 24 2022, 3:59 PM · Restricted Project, Restricted Project

May 23 2022

stellaraccident added a comment to D126230: [mlir] Add global_load and global_store ops to ml_program..

Note: design discussion continuing on discourse: https://discourse.llvm.org/t/rfc-introduce-ml-program-dialect-and-top-level-ops-proposal-v2/60907/51

May 23 2022, 11:48 AM · Restricted Project, Restricted Project
stellaraccident requested review of D126230: [mlir] Add global_load and global_store ops to ml_program..
May 23 2022, 11:42 AM · Restricted Project, Restricted Project
stellaraccident committed rG02d3499a46cc: NFC: Silence two warnings for unused bufferization symbols in release mode. (authored by stellaraccident).
NFC: Silence two warnings for unused bufferization symbols in release mode.
May 23 2022, 9:02 AM · Restricted Project, Restricted Project
stellaraccident closed D126182: NFC: Silence two warnings for unused bufferization symbols in release mode..
May 23 2022, 9:02 AM · Restricted Project, Restricted Project

May 22 2022

stellaraccident added a reviewer for D126182: NFC: Silence two warnings for unused bufferization symbols in release mode.: springerm.
May 22 2022, 9:31 PM · Restricted Project, Restricted Project
stellaraccident requested review of D126182: NFC: Silence two warnings for unused bufferization symbols in release mode..
May 22 2022, 9:30 PM · Restricted Project, Restricted Project
stellaraccident committed rG9b79f50b59c6: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder… (authored by jfurtek).
[mlir][tblgen][ods][python] Use keyword-only arguments for optional builder…
May 22 2022, 9:24 PM · Restricted Project, Restricted Project
stellaraccident closed D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.
May 22 2022, 9:24 PM · Restricted Project, Restricted Project
stellaraccident accepted D126011: [mlir] Use 'native' instead of 'llvm_has_native_target' in the mlir tests.
May 22 2022, 9:14 PM · Restricted Project, Restricted Project

May 19 2022

stellaraccident added a comment to D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.

Yes, I will land it either tomorrow or this weekend. Thank you for the patch!

May 19 2022, 7:42 PM · Restricted Project, Restricted Project

May 18 2022

stellaraccident committed rG8b7e85f4f840: [mlir][python] Add Python bindings for ml_program dialect. (authored by stellaraccident).
[mlir][python] Add Python bindings for ml_program dialect.
May 18 2022, 11:09 PM · Restricted Project, Restricted Project
stellaraccident committed rG2bb252852c72: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program. (authored by stellaraccident).
[mlir] Add GlobalOp, GlobalLoadConstOp to ml_program.
May 18 2022, 11:09 PM · Restricted Project, Restricted Project
stellaraccident closed D125852: [mlir][python] Add Python bindings for ml_program dialect..
May 18 2022, 11:09 PM · Restricted Project, Restricted Project
stellaraccident closed D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..
May 18 2022, 11:09 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D125852: [mlir][python] Add Python bindings for ml_program dialect..

Comments

May 18 2022, 11:02 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..
May 18 2022, 10:59 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Comments

May 18 2022, 10:59 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D125852: [mlir][python] Add Python bindings for ml_program dialect..
May 18 2022, 8:15 AM · Restricted Project, Restricted Project

May 17 2022

stellaraccident updated the diff for D125852: [mlir][python] Add Python bindings for ml_program dialect..

Update bazel files.

May 17 2022, 10:59 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Update bazel files.

May 17 2022, 10:56 PM · Restricted Project, Restricted Project
stellaraccident added a reviewer for D125852: [mlir][python] Add Python bindings for ml_program dialect.: jpienaar.
May 17 2022, 10:43 PM · Restricted Project, Restricted Project
stellaraccident requested review of D125852: [mlir][python] Add Python bindings for ml_program dialect..
May 17 2022, 10:43 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Jacques/Jeff, please take a look if you have a chance. I see there is a patch pending to fix the attribute parser declarations, but that will be a minor adaptation. I think the IR format is good enough as I have it here.

May 17 2022, 10:23 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Rebase and adapt to self-type attribute fix.

May 17 2022, 10:21 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D124318: [mlir] Add GlobalOp, GlobalLoadConstOp to ml_program..

Yeah that's... unfortunate to hear. ODS can be a bag of knives sometimes. I'll take a look at the bugs.

May 17 2022, 10:20 PM · Restricted Project, Restricted Project
stellaraccident accepted D125809: [mlir][ods] Simplify useDefaultType/AttributePrinterParser.

Thanks!

May 17 2022, 10:12 PM · Restricted Project, Restricted Project

May 15 2022

stellaraccident accepted D124717: [mlir][tblgen][ods][python] Use keyword-only arguments for optional builder arguments in generated Python bindings.
May 15 2022, 7:42 PM · Restricted Project, Restricted Project
stellaraccident accepted D125132: [mlir] Remove unused properties from the standalone example's lit configuration.
May 15 2022, 7:39 PM · Restricted Project, Restricted Project

May 10 2022

stellaraccident accepted D123536: [mlir:Pass] Add support for op-agnostic pass managers.

Thank you for the clarifications. lgtm.

May 10 2022, 10:39 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D125182: [mlir] Experimental, simplified CMake auto-config for Python development..

Seems reasonable. If this works it would be nice to just hand it off to the cmake folks...

May 10 2022, 10:00 PM · Restricted Project, Restricted Project

May 9 2022

stellaraccident added a comment to D125284: [mlir] Fix python bindings build on Windows in Debug.

I am glad that an actual Windows dev (versus someone who just occasionally plays one on TV) is looking at this. I've never understood the windows debug/release/runtime version dichotomies when not just working on a stock VS based project that automatically does the right thing.

I'm fine with landing if we special case the header like I suggest. Otherwise, open to discuss more.

To be honest, I don't think anyone understands this. It took me half a day of looking at source, building various bits and then looking at python, cmake and pybind11 sources to figure it out. I only hope I've documented enough of it so that next time we can skip most of it :)

May 9 2022, 7:42 PM · Restricted Project, Restricted Project
stellaraccident accepted D125284: [mlir] Fix python bindings build on Windows in Debug.

I am glad that an actual Windows dev (versus someone who just occasionally plays one on TV) is looking at this. I've never understood the windows debug/release/runtime version dichotomies when not just working on a stock VS based project that automatically does the right thing.

May 9 2022, 6:34 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D125182: [mlir] Experimental, simplified CMake auto-config for Python development..

Does this print how to run the python file in case of CMake failure?

May 9 2022, 8:04 AM · Restricted Project, Restricted Project

May 7 2022

stellaraccident added reviewers for D125182: [mlir] Experimental, simplified CMake auto-config for Python development.: mehdi_amini, stephenneuendorffer, mikeurbach.
May 7 2022, 10:21 PM · Restricted Project, Restricted Project
stellaraccident requested review of D125182: [mlir] Experimental, simplified CMake auto-config for Python development..
May 7 2022, 10:20 PM · Restricted Project, Restricted Project
stellaraccident committed rG6dedbcd5e96f: Make BinaryStreamWriter::padToAlignment write blocks vs bytes. (authored by stellaraccident).
Make BinaryStreamWriter::padToAlignment write blocks vs bytes.
May 7 2022, 5:39 PM · Restricted Project, Restricted Project