Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (23 w, 20 h)

Recent Activity

Apr 24 2020

stellaraccident committed rG485cf19651a5: Define SDBM key methods in its own cpp file. (authored by stellaraccident).
Define SDBM key methods in its own cpp file.
Apr 24 2020, 7:30 PM
stellaraccident closed D78039: Define SDBM key methods in its own cpp file..
Apr 24 2020, 7:30 PM · Restricted Project
stellaraccident committed rG7720d6578cc9: Add constructor to ShapedTypeComponents for unranked with element type. (authored by stellaraccident).
Add constructor to ShapedTypeComponents for unranked with element type.
Apr 24 2020, 10:49 AM
stellaraccident closed D78774: Add constructor to ShapedTypeComponents for unranked with element type..
Apr 24 2020, 10:49 AM · Restricted Project

Apr 23 2020

stellaraccident added a reviewer for D78774: Add constructor to ShapedTypeComponents for unranked with element type.: jpienaar.
Apr 23 2020, 4:53 PM · Restricted Project
stellaraccident created D78774: Add constructor to ShapedTypeComponents for unranked with element type..
Apr 23 2020, 4:52 PM · Restricted Project

Apr 22 2020

stellaraccident accepted D78671: [mlir/Quant] Allows to use 32 bits storage type.
Apr 22 2020, 8:38 PM · Restricted Project

Apr 19 2020

stellaraccident updated the diff for D78039: Define SDBM key methods in its own cpp file..

Install clang-format.

Apr 19 2020, 7:45 PM · Restricted Project
stellaraccident updated the diff for D78039: Define SDBM key methods in its own cpp file..

Address comments.

Apr 19 2020, 7:45 PM · Restricted Project

Apr 13 2020

stellaraccident updated the diff for D78039: Define SDBM key methods in its own cpp file..

Update comment.

Apr 13 2020, 10:44 AM · Restricted Project
stellaraccident updated the diff for D78039: Define SDBM key methods in its own cpp file..

Installed clang-format.

Apr 13 2020, 10:44 AM · Restricted Project
stellaraccident added a reviewer for D78039: Define SDBM key methods in its own cpp file.: rriddle.
Apr 13 2020, 10:44 AM · Restricted Project
stellaraccident created D78039: Define SDBM key methods in its own cpp file..
Apr 13 2020, 10:44 AM · Restricted Project

Apr 9 2020

stellaraccident accepted D77782: [mlir] Add a new RewritePattern::hasBoundedRewriteRecursion hook..

Thanks - this solves for the case I was talking to you about from my end.

Apr 9 2020, 12:30 PM · Restricted Project

Apr 7 2020

stellaraccident committed rGf5deb0878d9a: Remove FxpMathOps dialect and Quantizer tool. (authored by stellaraccident).
Remove FxpMathOps dialect and Quantizer tool.
Apr 7 2020, 1:38 PM
stellaraccident closed D77479: Remove FxpMathOps dialect and Quantizer tool..
Apr 7 2020, 1:38 PM · Restricted Project
stellaraccident accepted D77675: [mlir][Diagnostic] Don't store Operation arguments as a DiagnosticArgument.

Thanks!

Apr 7 2020, 1:03 PM · Restricted Project

Apr 5 2020

stellaraccident added a comment to D49116: Setup clang-format as an Arcanist linter.

One concern here would be whether this would even work on Windows, and whether it might make more sense to use a more portable scripting language to do it instead (say, Python). I don't use Windows so I'll let someone else who does (and uses Arcanist as well) to chime in as to whether this is going to be a problem.

I don't have a Windows machine to test, but maybe someone can port the bash script to python, while testing it on Windows. I don't mind if we don't commit this revision now, but someone takes over, and changes it to work on Windows.

Apr 5 2020, 11:12 AM · Restricted Project

Apr 4 2020

stellaraccident updated the diff for D77479: Remove FxpMathOps dialect and Quantizer tool..

Removed command line check.

Apr 4 2020, 8:14 PM · Restricted Project
stellaraccident updated the diff for D77479: Remove FxpMathOps dialect and Quantizer tool..

Removed unit tests and examples.

Apr 4 2020, 8:14 PM · Restricted Project
stellaraccident updated the diff for D77479: Remove FxpMathOps dialect and Quantizer tool..

Removed tests missed in the first commit.

Apr 4 2020, 7:42 PM · Restricted Project
stellaraccident created D77479: Remove FxpMathOps dialect and Quantizer tool..
Apr 4 2020, 7:42 PM · Restricted Project

Mar 30 2020

stellaraccident committed rG0af6d27e2ee2: Add /bigobj for SPIRV dialect on MSVC. (authored by stellaraccident).
Add /bigobj for SPIRV dialect on MSVC.
Mar 30 2020, 12:31 PM
stellaraccident closed D77002: Add /bigobj for SPIRV dialect on MSVC..
Mar 30 2020, 12:30 PM · Restricted Project

Mar 29 2020

stellaraccident added a comment to D77002: Add /bigobj for SPIRV dialect on MSVC..

Do why know why is this object so large? This may be an indication of something underlying to look at anyway.

Mar 29 2020, 4:36 PM · Restricted Project

Mar 28 2020

stellaraccident created D77002: Add /bigobj for SPIRV dialect on MSVC..
Mar 28 2020, 6:16 PM · Restricted Project

Mar 20 2020

stellaraccident accepted D76442: [mlir/quant] fix a small typo in the quant utility.
Mar 20 2020, 10:17 AM · Restricted Project

Mar 12 2020

stellaraccident requested changes to D75722: [mlir][Linalg] Implement padding for linalg.conv and lowering to loops..
Mar 12 2020, 4:50 PM · Restricted Project
stellaraccident accepted D75972: [QuantOps] Add the quant region definition.

Are you able to commit, or do you need me to do it?

Mar 12 2020, 2:06 PM · Restricted Project

Mar 10 2020

stellaraccident requested changes to D74703: Add test op for quantizer statistics..

Nice, thanks. Some small changes requested. Also, I would have expected cmake updates since you added a dep.

Mar 10 2020, 6:24 AM · Restricted Project
stellaraccident requested changes to D74705: [mlir][quantizer] Support quantizing sparse tensors.

The core of this change lgtm modulo one bit on where to put the getChunkSize helper. I need river to weigh in on the ShapedType api update.

Mar 10 2020, 6:23 AM · Restricted Project

Feb 8 2020

stellaraccident added inline comments to D73944: [mlir][wip] Start Shape dialect.
Feb 8 2020, 3:50 PM · Restricted Project
stellaraccident committed rG327e062a026a: [mlir][quantizer] Add gathering of per-axis statistics in quantizer. (authored by Vooblin).
[mlir][quantizer] Add gathering of per-axis statistics in quantizer.
Feb 8 2020, 3:22 PM
stellaraccident closed D73556: [mlir][quantizer] Add gathering of per-axis statistics in quantizer..
Feb 8 2020, 3:22 PM · Restricted Project
stellaraccident committed rGbff4e752f370: [mlir][quantizer] Add gathering of per-axis statistics in quantizer. (authored by Vooblin).
[mlir][quantizer] Add gathering of per-axis statistics in quantizer.
Feb 8 2020, 3:22 PM

Feb 3 2020

stellaraccident added inline comments to D73944: [mlir][wip] Start Shape dialect.
Feb 3 2020, 11:56 PM · Restricted Project
stellaraccident requested changes to D73944: [mlir][wip] Start Shape dialect.
Feb 3 2020, 11:11 PM · Restricted Project

Feb 1 2020

stellaraccident accepted D73572: [mlir] Expand shape functions in ShapeInference doc.

Some typos but lgtm. Thanks!

Feb 1 2020, 10:00 AM · Restricted Project
stellaraccident accepted D73556: [mlir][quantizer] Add gathering of per-axis statistics in quantizer..

Do you need me to commit this on your behalf?

Feb 1 2020, 9:42 AM · Restricted Project

Jan 28 2020

stellaraccident requested changes to D73556: [mlir][quantizer] Add gathering of per-axis statistics in quantizer..
Jan 28 2020, 7:54 AM · Restricted Project

Jan 3 2020

stellaraccident committed rG7d82d20f37f0: Add missing mlir-headers target and add tablegen'd deps to it. (authored by stellaraccident).
Add missing mlir-headers target and add tablegen'd deps to it.
Jan 3 2020, 4:08 PM
stellaraccident closed D72045: Add missing mlir-headers target and add tablegen'd deps to it..
Jan 3 2020, 4:08 PM · Restricted Project

Dec 31 2019

stellaraccident created D72045: Add missing mlir-headers target and add tablegen'd deps to it..
Dec 31 2019, 4:40 PM · Restricted Project
stellaraccident added a reviewer for D72045: Add missing mlir-headers target and add tablegen'd deps to it.: jpienaar.
Dec 31 2019, 4:40 PM · Restricted Project