Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (49 w, 5 d)

Recent Activity

Yesterday

stellaraccident accepted D92536: Use the generic form when printing from the python bindings and the verifier fails.

Thanks! Been meaning to add the verify hook for a while.

Wed, Dec 2, 11:43 PM · Restricted Project

Mon, Nov 30

stellaraccident added inline comments to D92276: [mlir][Python] Check numpy in Python bindings configuration..
Mon, Nov 30, 10:00 AM · Restricted Project

Sun, Nov 29

stellaraccident committed rG62195b754818: [mlir][CAPI] Convert the rest of the API int -> bool. (authored by stellaraccident).
[mlir][CAPI] Convert the rest of the API int -> bool.
Sun, Nov 29, 8:37 PM
stellaraccident closed D92292: [mlir][CAPI] Convert the rest of the API int -> bool..
Sun, Nov 29, 8:37 PM · Restricted Project
stellaraccident added reviewers for D92292: [mlir][CAPI] Convert the rest of the API int -> bool.: GeorgeLyon, mehdi_amini, ftynse.
Sun, Nov 29, 6:33 PM · Restricted Project
stellaraccident requested review of D92292: [mlir][CAPI] Convert the rest of the API int -> bool..
Sun, Nov 29, 6:32 PM · Restricted Project
stellaraccident committed rGba0fe76b7eb8: [mlir][Python] Add an Operation.result property. (authored by stellaraccident).
[mlir][Python] Add an Operation.result property.
Sun, Nov 29, 6:12 PM
stellaraccident committed rGbd2083c2fa7b: [mlir][Python] Python API cleanups and additions found during code audit. (authored by stellaraccident).
[mlir][Python] Python API cleanups and additions found during code audit.
Sun, Nov 29, 6:12 PM
stellaraccident closed D92287: [mlir][Python] Add an Operation.result property..
Sun, Nov 29, 6:12 PM · Restricted Project
stellaraccident closed D92283: [mlir][Python] Python API cleanups and additions found during code audit..
Sun, Nov 29, 6:12 PM · Restricted Project
stellaraccident updated the diff for D92287: [mlir][Python] Add an Operation.result property..

Address comments.

Sun, Nov 29, 4:49 PM · Restricted Project
stellaraccident added a reviewer for D92287: [mlir][Python] Add an Operation.result property.: ftynse.
Sun, Nov 29, 1:54 PM · Restricted Project
stellaraccident requested review of D92287: [mlir][Python] Add an Operation.result property..
Sun, Nov 29, 1:54 PM · Restricted Project
stellaraccident added reviewers for D92283: [mlir][Python] Python API cleanups and additions found during code audit.: mehdi_amini, ftynse.
Sun, Nov 29, 1:33 PM · Restricted Project
stellaraccident requested review of D92283: [mlir][Python] Python API cleanups and additions found during code audit..
Sun, Nov 29, 1:33 PM · Restricted Project
stellaraccident added inline comments to D92279: Add SCF Dialect C API.
Sun, Nov 29, 11:25 AM · Restricted Project

Wed, Nov 25

stellaraccident committed rG2fb5f4a1cf41: [mlir][Python] Add additional capsule interop types. (authored by stellaraccident).
[mlir][Python] Add additional capsule interop types.
Wed, Nov 25, 7:15 PM
stellaraccident closed D92144: [mlir][Python] Add additional capsule interop types..
Wed, Nov 25, 7:15 PM · Restricted Project
stellaraccident requested review of D92144: [mlir][Python] Add additional capsule interop types..
Wed, Nov 25, 5:47 PM · Restricted Project

Tue, Nov 24

stellaraccident accepted D91959: [mlir] use STATUS instead of CHECK_* in MLIRDetectPythonEnv.cmake.
Tue, Nov 24, 2:21 PM · Restricted Project
stellaraccident committed rG5f0c1e380661: [mlir][Python] Sync Python bindings with C API MlirStringRef modification. (authored by zhanghb97).
[mlir][Python] Sync Python bindings with C API MlirStringRef modification.
Tue, Nov 24, 11:35 AM
stellaraccident closed D92007: [mlir][Python] Sync Python bindings with C API MlirStringRef modification..
Tue, Nov 24, 11:35 AM · Restricted Project
stellaraccident added a comment to D92007: [mlir][Python] Sync Python bindings with C API MlirStringRef modification..

The difference is that all the consumers of the C++ API are C++, so it is pretty straightforward to update when making breaking changes even if the surface is greater.

You're clearly not updating all of the Google internal users ;)

Language bindings will live at least partially in their own ecosystem and requiring folks who work on the C API to understand each individual ecosystem may be too onerous, even if the surface area is smaller.

There are a few aspects here that make me doubtful about it:

  • the C API is more limited (by the virtue of using C: no overloading sets, no inheritance/overrides, no templates, etc.)
  • the C API is intended to be stable at some point and see little churn.
  • I does not seem hard to me to see myself changing the C API like here and adjust any in-tree language bindings in a fairly straightforward way, in most cases it'll be fairly mechanical to look at the API call site and update it. I don't quite get why this would be more complex than all of the C++ uses actually.
Tue, Nov 24, 11:33 AM · Restricted Project
stellaraccident updated the diff for D92007: [mlir][Python] Sync Python bindings with C API MlirStringRef modification..

Commandeer change and resolve comments.

Tue, Nov 24, 10:48 AM · Restricted Project
stellaraccident commandeered D92007: [mlir][Python] Sync Python bindings with C API MlirStringRef modification..
Tue, Nov 24, 10:47 AM · Restricted Project
stellaraccident added a comment to D92007: [mlir][Python] Sync Python bindings with C API MlirStringRef modification..

Small process question: I authored the change to us MlirStringRef instead of const char *, what is the policy about breaking changes in the C API? I think it is likely unreasonable to expect any change in the C API to fix all in-tree language bindings, but since the Python bindings are in-tree, these types of changes can break them. I'm might be the only person working on non-Python bindings here, so I may be biased :)

Tue, Nov 24, 9:58 AM · Restricted Project
stellaraccident committed rG15481bba1ff2: [mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE. (authored by stellaraccident).
[mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE.
Tue, Nov 24, 9:56 AM
stellaraccident closed D92043: [mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE..
Tue, Nov 24, 9:56 AM · Restricted Project
stellaraccident added a reviewer for D92043: [mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE.: mehdi_amini.
Tue, Nov 24, 9:51 AM · Restricted Project
stellaraccident requested review of D92043: [mlir][Python] Fix the last remaining instance of PYTHON_EXECUTABLE..
Tue, Nov 24, 9:50 AM · Restricted Project
stellaraccident committed rGdb9713cd776a: [mlir] Add Tosa dialect const folder for tosa.const. (authored by stellaraccident).
[mlir] Add Tosa dialect const folder for tosa.const.
Tue, Nov 24, 9:34 AM
stellaraccident closed D92040: [mlir] Add Tosa dialect const folder for tosa.const..
Tue, Nov 24, 9:34 AM · Restricted Project
stellaraccident added a comment to D92007: [mlir][Python] Sync Python bindings with C API MlirStringRef modification..

Does anyone mind if I commandeer this change (it is broken at head)?

Tue, Nov 24, 9:20 AM · Restricted Project
stellaraccident added reviewers for D92040: [mlir] Add Tosa dialect const folder for tosa.const.: jpienaar, sjarus.
Tue, Nov 24, 9:02 AM · Restricted Project
stellaraccident requested review of D92040: [mlir] Add Tosa dialect const folder for tosa.const..
Tue, Nov 24, 9:01 AM · Restricted Project

Sun, Nov 22

stellaraccident committed rGf4f8a67aaf13: [mlir][Python] Support finding pybind11 from the python environment. (authored by stellaraccident).
[mlir][Python] Support finding pybind11 from the python environment.
Sun, Nov 22, 12:56 PM
stellaraccident closed D91903: [mlir][Python] Support finding pybind11 from the python environment..
Sun, Nov 22, 12:56 PM · Restricted Project
stellaraccident added a comment to D91903: [mlir][Python] Support finding pybind11 from the python environment..

I'm wondering can we use the MLIRDetectPythonEnv.cmake or names like this (detect all the required Python environments), instead of MLIRDetectPybind11.cmake (only responsible for checking pybind11). In this case, we can define all the detecting functions (like mlir_detect_numpy_install) in one cmake file to avoid fragmentation.

Sun, Nov 22, 12:53 PM · Restricted Project
stellaraccident updated the diff for D91903: [mlir][Python] Support finding pybind11 from the python environment..

Address comments and rebase

Sun, Nov 22, 12:53 PM · Restricted Project

Fri, Nov 20

stellaraccident added reviewers for D91903: [mlir][Python] Support finding pybind11 from the python environment.: silvas, mehdi_amini, zhanghb97, ftynse.
Fri, Nov 20, 6:05 PM · Restricted Project
stellaraccident requested review of D91903: [mlir][Python] Support finding pybind11 from the python environment..
Fri, Nov 20, 6:05 PM · Restricted Project
stellaraccident accepted D91652: [mlir] Make attributes mutable in Python bindings.

Nice!

Fri, Nov 20, 7:49 AM · Restricted Project

Tue, Nov 17

stellaraccident committed rG989b19442905: [mlir][Python] Make DenseElementsAttr loading be int size agnostic. (authored by stellaraccident).
[mlir][Python] Make DenseElementsAttr loading be int size agnostic.
Tue, Nov 17, 9:55 PM
stellaraccident closed D91283: [mlir][Python] Make DenseElementsAttr loading be int size agnostic..
Tue, Nov 17, 9:55 PM · Restricted Project
stellaraccident accepted D91021: [mlir] Get array from the dense elements attribute with buffer protocol..

Thanks - a few nits. Maybe put a message on discord when you land indicating the new version requirement (and tag ftynse since he is working on this)

Tue, Nov 17, 8:54 PM · Restricted Project
stellaraccident accepted D91623: [mlir] Add a _get_default_loc_context utility to Python bindings.
Tue, Nov 17, 7:45 AM · Restricted Project

Mon, Nov 16

stellaraccident added a reviewer for D91283: [mlir][Python] Make DenseElementsAttr loading be int size agnostic.: ftynse.

Gentle ping - fixes the Windows build and working to get the bot up.

Mon, Nov 16, 10:24 PM · Restricted Project
stellaraccident added a comment to D91021: [mlir] Get array from the dense elements attribute with buffer protocol..

Thanks - I prefer this version, but have a material request wrt readonly access.

Mon, Nov 16, 10:20 PM · Restricted Project
stellaraccident accepted D91542: [mlir] Add basic support for attributes in ODS-generated Python bindings.

This is quite slick. A couple of nits.

Mon, Nov 16, 9:59 PM · Restricted Project
stellaraccident accepted D91584: Add CalibratedQuantizedType to quant dialect.

Wow, that has been a minute since that was discussed. I'm not 100% sure these days that I would encode this in the type system if I were doing it, but having the representation to do it is fine with me.

Mon, Nov 16, 9:48 PM · Restricted Project

Thu, Nov 12

stellaraccident committed rG4726a402a32a: [mlir][Python] Fix 'unreferenced local variable' warning on MSVC. (authored by stellaraccident).
[mlir][Python] Fix 'unreferenced local variable' warning on MSVC.
Thu, Nov 12, 1:35 PM
stellaraccident closed D91282: [mlir][Python] Fix 'unreferenced local variable' warning on MSVC..
Thu, Nov 12, 1:35 PM · Restricted Project

Wed, Nov 11

stellaraccident accepted D91190: [mlir] Generate Op builders for Python bindings.
Wed, Nov 11, 5:55 PM · Restricted Project
stellaraccident committed rG5fef6ce0cce0: [mlir][Python] Allow PassManager to interop with the capsule APIs. (authored by stellaraccident).
[mlir][Python] Allow PassManager to interop with the capsule APIs.
Wed, Nov 11, 10:38 AM
stellaraccident closed D91232: [mlir][Python] Allow PassManager to interop with the capsule APIs..
Wed, Nov 11, 10:37 AM · Restricted Project
stellaraccident added a comment to D91232: [mlir][Python] Allow PassManager to interop with the capsule APIs..

Thanks

Wed, Nov 11, 10:36 AM · Restricted Project
stellaraccident updated the diff for D91232: [mlir][Python] Allow PassManager to interop with the capsule APIs..

Rebase and comments

Wed, Nov 11, 10:36 AM · Restricted Project
stellaraccident added a reviewer for D91283: [mlir][Python] Make DenseElementsAttr loading be int size agnostic.: mehdi_amini.
Wed, Nov 11, 10:25 AM · Restricted Project
stellaraccident requested review of D91283: [mlir][Python] Make DenseElementsAttr loading be int size agnostic..
Wed, Nov 11, 10:24 AM · Restricted Project
stellaraccident added a reviewer for D91282: [mlir][Python] Fix 'unreferenced local variable' warning on MSVC.: mehdi_amini.
Wed, Nov 11, 10:05 AM · Restricted Project
stellaraccident updated the diff for D91282: [mlir][Python] Fix 'unreferenced local variable' warning on MSVC..

clang-format

Wed, Nov 11, 10:04 AM · Restricted Project
stellaraccident requested review of D91282: [mlir][Python] Fix 'unreferenced local variable' warning on MSVC..
Wed, Nov 11, 10:02 AM · Restricted Project
stellaraccident committed rG99b1c42fd3ac: [mlir][Python] Add Windows DLL loader to get python extensions working there. (authored by stellaraccident).
[mlir][Python] Add Windows DLL loader to get python extensions working there.
Wed, Nov 11, 9:59 AM
stellaraccident closed D90958: [mlir][Python] Add Windows DLL loader to get python extensions working there..
Wed, Nov 11, 9:59 AM · Restricted Project
stellaraccident updated the diff for D90958: [mlir][Python] Add Windows DLL loader to get python extensions working there..

Rebase and test on Windows.

Wed, Nov 11, 9:59 AM · Restricted Project
stellaraccident accepted D91233: Disable implicit nesting on parsing textual pass pipeline.

Aside from nits that River is discussing, lgtm! Thanks for this!

Wed, Nov 11, 9:43 AM · Restricted Project

Tue, Nov 10

stellaraccident added a reviewer for D91232: [mlir][Python] Allow PassManager to interop with the capsule APIs.: mehdi_amini.
Tue, Nov 10, 9:02 PM · Restricted Project
stellaraccident requested review of D91232: [mlir][Python] Allow PassManager to interop with the capsule APIs..
Tue, Nov 10, 9:02 PM · Restricted Project
stellaraccident accepted D91197: [mlir] Refactor finding python.
Tue, Nov 10, 12:07 PM · Restricted Project
stellaraccident added inline comments to D90819: Add basic Python bindings for the PassManager and bind libTransforms.
Tue, Nov 10, 11:37 AM · Restricted Project

Mon, Nov 9

stellaraccident added inline comments to D90819: Add basic Python bindings for the PassManager and bind libTransforms.
Mon, Nov 9, 9:43 PM · Restricted Project

Sun, Nov 8

stellaraccident updated subscribers of D90966: Add pybind11 to the mlir-nvidia Docker image to be able to enable the MLIR Python bindings.

Yes, we'll update the parameters once the container is ready.

Sun, Nov 8, 10:56 PM
stellaraccident added a reverting change for rGbb9b5d39712e: Revert "[mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so.": rG08c1a0dda4b8: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply)..
Sun, Nov 8, 5:23 PM
stellaraccident committed rG08c1a0dda4b8: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply). (authored by stellaraccident).
[mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply).
Sun, Nov 8, 5:23 PM
stellaraccident closed D91044: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply)..
Sun, Nov 8, 5:23 PM · Restricted Project
stellaraccident added a reviewer for D91044: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply).: mehdi_amini.

Pure re-apply of previously reviewed revision.

Sun, Nov 8, 5:15 PM · Restricted Project
stellaraccident added a reverting change for rGbb9b5d39712e: Revert "[mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so.": D91044: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply)..
Sun, Nov 8, 4:58 PM
stellaraccident requested review of D91044: [mlir][CAPI] Proposal: Always building a libMLIRPublicAPI.so (re-apply)..
Sun, Nov 8, 4:57 PM · Restricted Project
stellaraccident accepted D90354: [mlir] Add pass to convert elementwise ops to linalg..
Sun, Nov 8, 4:47 PM · Restricted Project
stellaraccident accepted D90731: Add ElementwiseMappable trait and apply it to std elementwise ops..

This is very nice, and the corresponding RFC seems to have gotten to a nice conclusion.

Sun, Nov 8, 4:44 PM · Restricted Project

Sat, Nov 7

stellaraccident added inline comments to D91021: [mlir] Get array from the dense elements attribute with buffer protocol..
Sat, Nov 7, 6:57 PM · Restricted Project
stellaraccident committed rG86b011777ea4: Remove TOSA test passes from non test registration. (authored by stellaraccident).
Remove TOSA test passes from non test registration.
Sat, Nov 7, 6:40 PM
stellaraccident closed D91022: Remove TOSA test passes from non test registration..
Sat, Nov 7, 6:40 PM · Restricted Project
stellaraccident added reviewers for D91022: Remove TOSA test passes from non test registration.: mehdi_amini, sjarus.

Mehdi: I just followed the example of how this is done for Affine. Not sure if there is a plan to systematize these test passes long term.

Sat, Nov 7, 6:37 PM · Restricted Project
stellaraccident added a comment to D90411: TOSA MLIR Dialect.

Fixed in https://reviews.llvm.org/D91022 (just waiting on the bots and then
will submit).

Sat, Nov 7, 6:36 PM · Restricted Project
stellaraccident requested review of D91022: Remove TOSA test passes from non test registration..
Sat, Nov 7, 6:34 PM · Restricted Project
stellaraccident added a comment to D90411: TOSA MLIR Dialect.

Found the problem and will send a fix shortly.

Sat, Nov 7, 6:23 PM · Restricted Project
stellaraccident updated subscribers of D90411: TOSA MLIR Dialect.

Thank you for the report: I don't think we have a bit which verifies that,
so it is plausible. I will triage this momentarily.

Sat, Nov 7, 6:10 PM · Restricted Project
stellaraccident added a comment to D90411: TOSA MLIR Dialect.

Will do. The review thread was getting confusing. If you have further comments, I will work with you to land them in a follow-up.

Sat, Nov 7, 12:52 PM · Restricted Project
stellaraccident added a reverting change for rG330398052d04: Revert "NFC: Fix some post-review nits for the Tosa dialect.": rGac3587f272cc: NFC: (re-apply) Fix some post-review nits for the Tosa dialect..
Sat, Nov 7, 10:04 AM
stellaraccident committed rGac3587f272cc: NFC: (re-apply) Fix some post-review nits for the Tosa dialect. (authored by stellaraccident).
NFC: (re-apply) Fix some post-review nits for the Tosa dialect.
Sat, Nov 7, 10:04 AM
stellaraccident closed D91006: NFC: (re-apply) Fix some post-review nits for the Tosa dialect..
Sat, Nov 7, 10:04 AM · Restricted Project
stellaraccident added a reviewer for D91006: NFC: (re-apply) Fix some post-review nits for the Tosa dialect.: sjarus.
Sat, Nov 7, 9:40 AM · Restricted Project
stellaraccident added a reverting change for rG330398052d04: Revert "NFC: Fix some post-review nits for the Tosa dialect.": D91006: NFC: (re-apply) Fix some post-review nits for the Tosa dialect..
Sat, Nov 7, 9:39 AM
stellaraccident requested review of D91006: NFC: (re-apply) Fix some post-review nits for the Tosa dialect..
Sat, Nov 7, 9:39 AM · Restricted Project
stellaraccident added a reverting change for rGb5fcd06105de: NFC: Fix some post-review nits for the Tosa dialect.: rG330398052d04: Revert "NFC: Fix some post-review nits for the Tosa dialect.".
Sat, Nov 7, 9:36 AM
stellaraccident committed rG330398052d04: Revert "NFC: Fix some post-review nits for the Tosa dialect." (authored by stellaraccident).
Revert "NFC: Fix some post-review nits for the Tosa dialect."
Sat, Nov 7, 9:36 AM
stellaraccident accepted D90966: Add pybind11 to the mlir-nvidia Docker image to be able to enable the MLIR Python bindings.

Thanks!

Sat, Nov 7, 9:08 AM
stellaraccident committed rG9bda935289fd: [mlir][Python] Adapt to include property change in pybind11 v2.6. (authored by stellaraccident).
[mlir][Python] Adapt to include property change in pybind11 v2.6.
Sat, Nov 7, 9:07 AM
stellaraccident closed D90955: [mlir][Python] Adapt to include property change in pybind11 v2.6..
Sat, Nov 7, 9:07 AM · Restricted Project