Page MenuHomePhabricator

stellaraccident (Stella Laurenzo)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 20 2019, 9:16 PM (169 w, 5 d)

Recent Activity

Mon, Mar 13

stellaraccident accepted D145956: [mlir] Don't use -z,defs on sanitizer builds.
Mon, Mar 13, 10:58 AM · Restricted Project, Restricted Project

Sun, Mar 5

stellaraccident added reviewers for D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so.: stephenneuendorffer, marbre.
Sun, Mar 5, 9:26 PM · Restricted Project, Restricted Project
stellaraccident requested review of D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so..
Sun, Mar 5, 9:25 PM · Restricted Project, Restricted Project

Sun, Feb 26

stellaraccident accepted D143869: [mlir][python] Capture error diagnostics in exceptions.

Nice, thanks! Fine to land as a stretch improvement but I think we need to further sugar the new exception class to avoid exposing implementation details.

Sun, Feb 26, 10:38 PM · Restricted Project, Restricted Project
stellaraccident accepted D143830: [mlir][python] Remove "Raw" OpView classes.

Thanks. I had started reviewing this but got side tracked with the archaeology. Thanks for simplifying -- this was always not great.

Sun, Feb 26, 10:30 PM · Restricted Project, Restricted Project
stellaraccident accepted D143352: [mlir][python] Add generic operation parse APIs.

Python changes lgtm. The parser changed make sense to but I usually defer those reviews to river.

Sun, Feb 26, 10:26 PM · Restricted Project, Restricted Project
stellaraccident accepted D144805: [mlir][python] Don't emit diagnostics when printing invalid ops.

Thanks!

Sun, Feb 26, 10:46 AM · Restricted Project, Restricted Project

Fri, Feb 24

stellaraccident added a reviewer for D144750: [mlir] Define transform dialect expensive checks regardless of asserts.: ftynse.
Fri, Feb 24, 11:13 AM · Restricted Project, Restricted Project
stellaraccident requested review of D144750: [mlir] Define transform dialect expensive checks regardless of asserts..
Fri, Feb 24, 11:13 AM · Restricted Project, Restricted Project

Wed, Feb 22

stellaraccident accepted D143718: [mlir][standalone] Enable to build as LLVM external project.
Wed, Feb 22, 1:06 PM · Restricted Project, Restricted Project

Feb 10 2023

stellaraccident added a comment to D141804: [mlir][linalg] Omit printing result types for named ops..

In early December we switched back to textual representation (at the cost of storage space) to provide better stability of the IR.

How is this supposed to be more stable? What were you using before?
The bytecode is intended to be more stable than textual IR (even though not resilient to Dialects changes at the moment, pending some versioning work)

I think this may be a case of socialization / familiarity with that part of the system.
I haven't personally looked at how to use the bytecode, I see there is doc, should we have something in the Tutorial ?
Serializing string always seems tantalizingly easy until the castle build on sand starts to crumble..

To start with, I see at minima design consistency with the general dialect design I think I saw upstream so far.

Linalg ops syntax is

%foo = linalg.<some-op> ins(... : <list of input types>) outs(... : <list of output types>) -> <return types>

Ops AFAIK in general are

%foo = <some op> : <inputtypes> -> <result type>

for the most part.... So linalg ops are anyway not consistent. If we want to evolve Linalg ops syntax, then can we do it in one shot to a state that has general consensus. Also in terms of consistency, these are only for named Linalg ops and not linalg.generic, which by itself is not consistent.

Makes sense, let's work towards this! Shall we start a shared doc and go through IR samples, including various dialects, and try to put together a "style guide for dialect syntax"?

@mehdi_amini that would be fantastic!
This needs a serious owner to really lift these ops from their "assembly-level" status and I have not been able to do that part.
One thing I have always been frustrated about is the syntax delta between a linalg.generic and a simple math expression.
@stellaraccident and @gysit provided huge improvements to make it better at the python level but the IR remains very much underserved.

The ability to "see" computations as e.g. %C(i,j) = arith.addf(arith.mulf(%A(i, k), %B(k, j)), %C(i, j) brings a phase shift in cognitive capacity.
See "Fig. 6. TC Benchmarks used in the experiments." in https://dl.acm.org/doi/pdf/10.1145/3355606.
It was e.g. very useful to understand the anti-diagonal reduction pattern on the LHS operands in the kronecker3 example.

Feb 10 2023, 5:47 AM · Restricted Project, Restricted Project

Feb 7 2023

stellaraccident accepted D143523: [mlir] Relax version requirement for PyYAML in mlir.
Feb 7 2023, 1:22 PM · Restricted Project, Restricted Project

Jan 27 2023

stellaraccident accepted D142563: [mlir] Pin for the PyPi requirements for mlir.

Given the security situation, I am fine making this change to tighten things up. It may cause some trouble for folks in the wild if they have concerning versions and pip doesn't offer great solutions. As part of a dev setup, though, I feel that folks should be able to self serve solutions to issues of there is a problem.

Jan 27 2023, 8:36 AM · Restricted Project, Restricted Project

Jan 9 2023

stellaraccident added a comment to D140088: Add LLVM type support for fp8.

Is there an RFC for this change? In https://discourse.llvm.org/t/rfc-add-apfloat-and-mlir-type-support-for-fp8-e5m2/65279 the addition of an LLVM IR type was explicitly out of scope. See also in particular the comment by @efriedma here: https://discourse.llvm.org/t/rfc-add-apfloat-and-mlir-type-support-for-fp8-e5m2/65279/3

I'm personally rather skeptical about adding new ad-hoc floating-point types to IR without at least some restructuring of the existing system. At the IR level, my expectation would be that all the different float types get consolidated into a single type that is parameterized over the floating-point semantics.

Jan 9 2023, 10:04 AM · Restricted Project, Restricted Project

Jan 6 2023

stellaraccident accepted D141155: [mlir][py] Fix python modules build with clang-cl due to requiring exceptions.

Perfect. Thanks for checking. Do you need help landing this patch?

Jan 6 2023, 1:42 PM · Restricted Project, Restricted Project
stellaraccident added inline comments to D141155: [mlir][py] Fix python modules build with clang-cl due to requiring exceptions.
Jan 6 2023, 1:27 PM · Restricted Project, Restricted Project

Dec 28 2022

stellaraccident accepted D140746: [mlir][python] Expose fp8 types with pybind..

Thank you! Do you need help landing this patch or do you have commit access?

Dec 28 2022, 6:14 PM · Restricted Project, Restricted Project

Dec 21 2022

stellaraccident added a comment to D140488: [mlir] Clear running passes in crashreporter.

Thank you Jacques/River -- I found this one in the field when only running release binaries on windows. It was not fun to get the repro that triggered it. Really glad we're continuing to improve reprocucers as they are a life saver.

Dec 21 2022, 12:49 PM · Restricted Project, Restricted Project

Dec 16 2022

stellaraccident added inline comments to D140088: Add LLVM type support for fp8.
Dec 16 2022, 5:37 AM · Restricted Project, Restricted Project

Dec 15 2022

stellaraccident added a comment to D140088: Add LLVM type support for fp8.

Hi Renato - I've reviewed and this lgtm, but I rarely work on/review this part of the codebase. Do you feel like you are a good reviewer for it (the author reached out to me asking for some help coordinating reviewers)?

Dec 15 2022, 11:57 AM · Restricted Project, Restricted Project

Dec 13 2022

stellaraccident accepted D139597: [mlir][Python] Add a simple PyOpOperand iterator for PyValue uses..

Lgtm modulo trivial comments

Dec 13 2022, 5:01 PM · Restricted Project, Restricted Project
stellaraccident accepted D139942: mlir/ods-gen: use bash from env in shell script.

Thanks. Do you have commit access? Or do you need help landing?

Dec 13 2022, 4:38 PM · Restricted Project, Restricted Project

Dec 5 2022

stellaraccident added a comment to D134812: Don't use root logger at import time.

Gentle ping: can this be merged? The same bug got reported again.

Dec 5 2022, 6:02 PM · Restricted Project, Restricted Project
stellaraccident committed rG35d26be21976: Don't use root logger at import time (authored by stellaraccident).
Don't use root logger at import time
Dec 5 2022, 5:56 PM · Restricted Project, Restricted Project
stellaraccident closed D134812: Don't use root logger at import time.
Dec 5 2022, 5:56 PM · Restricted Project, Restricted Project

Nov 27 2022

stellaraccident accepted D138764: Make ScopedDiagnosticHandler destructor virtual (NFC).

(change lgtm and I think we may want to rework this API at some point)

Nov 27 2022, 2:44 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D138764: Make ScopedDiagnosticHandler destructor virtual (NFC).

Thanks for having a look. I left a note on the issue about possibly doing this differently. WDYT? https://github.com/llvm/llvm-project/issues/59212#issuecomment-1328315420

Nov 27 2022, 11:23 AM · Restricted Project, Restricted Project

Nov 19 2022

stellaraccident accepted D138274: Add version to all LLVM cmake package.

As mentioned, the duplication is annoying but I suspect is the least bad way to do it.

Nov 19 2022, 4:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 15 2022

stellaraccident accepted D138075: Add Float8E4M3FN type to MLIR..

Thanks - this is great!

Nov 15 2022, 5:17 PM · Restricted Project, Restricted Project
stellaraccident accepted D137760: Add FP8 E4M3 support to APFloat..

Thanks for this. Patch lgtm. Has a couple of format issues but probably ok as-is (this file is very inconsistently formatted and it looks like you overrode clang-format a bit for consistency with adjacent code).

Nov 15 2022, 11:21 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2022

stellaraccident accepted D137724: [CMake] Warn when the version is older than 3.20.0..
Nov 12 2022, 1:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 26 2022

stellaraccident added a comment to D136404: [mlir][CAPI] Allow specifying pass manager anchor.

I don't have a strong opinion. We don't (yet) offer any sort of API stability guarantees at this level, so just changing it is fine. There will be a compiler error, it's not like changing the type from one pointer to another. On the other hand, having mlirPassManagerCreate to work on builtin.module sounds like a reasonable default and we can have a more verbose mlirPassManagerCreateOnOperation that also needs a more verbose argument.

Oct 26 2022, 7:31 AM · Restricted Project, Restricted Project

Oct 11 2022

stellaraccident added a comment to D134812: Don't use root logger at import time.

Sorry for the delay - I attempted to rebase/land but the patch conflicts. I don't have time to actually update it right now - can you rebase/fix? I'll be back from traveling later in the week and can do the rebase/fix if you don't get to it but am not in a position to be making actual edits right now.

Oct 11 2022, 6:38 AM · Restricted Project, Restricted Project
stellaraccident abandoned D110489: Make windows resource generation more robust to misconfiguration..

Another contributor cloned and submitted this with suggested fixes as a new patch: https://reviews.llvm.org/D135650

Oct 11 2022, 6:32 AM · Restricted Project, Restricted Project
stellaraccident committed rG4d25ba0165aa: Make windows resource generation more robust (authored by powderluv).
Make windows resource generation more robust
Oct 11 2022, 6:31 AM · Restricted Project, Restricted Project
stellaraccident closed D135650: Make windows resource generation more robust.
Oct 11 2022, 6:31 AM · Restricted Project, Restricted Project
stellaraccident accepted D135650: Make windows resource generation more robust.
Oct 11 2022, 6:27 AM · Restricted Project, Restricted Project

Oct 6 2022

stellaraccident abandoned D94387: Add new LLVMComponents CMake module..
Oct 6 2022, 9:14 PM · Restricted Project, Restricted Project

Oct 4 2022

stellaraccident added a comment to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Ran the full clang/llvm/mlir test suite in debug mode just to be safe.

Oct 4 2022, 5:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident committed rGe28b15b572b5: Add APFloat and MLIR type support for fp8 (e5m2). (authored by stellaraccident).
Add APFloat and MLIR type support for fp8 (e5m2).
Oct 4 2022, 5:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident closed D133823: Add APFloat and MLIR type support for fp8 (e5m2)..
Oct 4 2022, 5:40 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident updated the diff for D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Remove break after llvm_unreachable for consistency with other switches in file.

Oct 4 2022, 5:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident updated the diff for D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Switch to explicit case per comment from ctopper.

Oct 4 2022, 5:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident updated the diff for D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Add fix to MicrosoftMangle.cpp that caused buildbot failure.

Oct 4 2022, 5:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 3 2022

stellaraccident accepted D135089: [mlir] Add unsigned version of index_cast.

I'm personally ok with this patch. If we decide to go forward with the index dialect, it will come with a transition plan for index-in-arith, and it doesn't seem like this makes that harder. If anything, it makes it easier to specify what the transition path is for the existing index cast ops.

Oct 3 2022, 10:45 AM · Restricted Project, Restricted Project
stellaraccident added inline comments to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..
Oct 3 2022, 10:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 2 2022

stellaraccident committed rG2dc68b539825: Add APFloat and MLIR type support for fp8 (e5m2). (authored by stellaraccident).
Add APFloat and MLIR type support for fp8 (e5m2).
Oct 2 2022, 5:25 PM · Restricted Project, Restricted Project, Restricted Project
stellaraccident closed D133823: Add APFloat and MLIR type support for fp8 (e5m2)..
Oct 2 2022, 5:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident updated the diff for D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Rebase.

Oct 2 2022, 5:18 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 28 2022

stellaraccident accepted D133450: [mlir][python] stop initialization on ImportError.

Go ahead and land at your convenience. I'll land the other one once you do (busy and not going to get to it today)

Sep 28 2022, 5:36 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D133450: [mlir][python] stop initialization on ImportError.

Do you need help committing? The other one does - so if you both do, I can do final fix-ups as I'm landing both.

Sep 28 2022, 9:47 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D133450: [mlir][python] stop initialization on ImportError.

Also note https://reviews.llvm.org/D134812 in flight. I think that one should go in first

Sep 28 2022, 7:54 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D134812: Don't use root logger at import time.

Also note https://reviews.llvm.org/D133450 in flight. I think yours should go in first

Sep 28 2022, 7:54 AM · Restricted Project, Restricted Project
stellaraccident accepted D134812: Don't use root logger at import time.

Good catch - thanks.

Sep 28 2022, 7:53 AM · Restricted Project, Restricted Project
stellaraccident added inline comments to D133450: [mlir][python] stop initialization on ImportError.
Sep 28 2022, 7:36 AM · Restricted Project, Restricted Project
stellaraccident added a comment to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Bkramer; was your intention to review both the APFloat and MLIR side of the patch? Just making sure that the MLIR side had a proper look before submitting and it wasn't clear to me from the commentary.

Sep 28 2022, 4:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added inline comments to D133450: [mlir][python] stop initialization on ImportError.
Sep 28 2022, 4:35 AM · Restricted Project, Restricted Project

Sep 26 2022

stellaraccident added reviewers for D133823: Add APFloat and MLIR type support for fp8 (e5m2).: jpienaar, mehdi_amini.
Sep 26 2022, 2:00 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added a comment to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Honestly, there isn't much meat here, other than the decision to support and the name bikeshedding, both of which I think are well covered in the RFC.

Sep 26 2022, 10:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added a comment to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Code looks good. Were the concerns about naming resolved?

Sep 26 2022, 5:12 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 23 2022

stellaraccident added a comment to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Formatted and naming suggestions from RFC applied. Ready for review.

Sep 23 2022, 4:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident updated the diff for D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

git-clang-format

Sep 23 2022, 4:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident updated the diff for D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

Format and apply rename suggestions.

Sep 23 2022, 4:07 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 20 2022

stellaraccident accepted D134251: [mlir][standalone] Specify python path when configuring.

Oh, wow - not sure how that was missed. Thanks.

Sep 20 2022, 12:08 PM · Restricted Project, Restricted Project

Sep 14 2022

stellaraccident added a comment to D133823: Add APFloat and MLIR type support for fp8 (e5m2)..

I imagine APFloat changes likely require an RFC (though I'm not sure). Also, did you accidentally reformat all of the APFloat tests (4k lines change o.O)

Sep 14 2022, 1:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added a reviewer for D133823: Add APFloat and MLIR type support for fp8 (e5m2).: bkramer.
Sep 14 2022, 9:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added reviewers for D133823: Add APFloat and MLIR type support for fp8 (e5m2).: jholewinski, gchakrabarti.
Sep 14 2022, 9:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident published D133823: Add APFloat and MLIR type support for fp8 (e5m2). for review.
Sep 14 2022, 9:05 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sep 11 2022

stellaraccident added a comment to D133076: [mlir][arith] Change the syntax of `arith.cmpi/f`.

Further, for these matters of style/taste, I think that barring a rationale (which can be consistency based like you point out) or strong opinions that one form is better, we should bias towards what is. That is how mature projects operate, ime, and the decision making process working something like this is kind what I'm looking for.

We don't have any of this written down, and maybe we should. Thus my comment about a style guide -- the traditional way to codify both specifics and rationale for such things.

My two cents, for what is worth. 100% in favour of some sort of style guide. It already came up a couple of times in the past for me. I find consistency in syntax very valuable, it makes dialects predictable and easier to understand. In an ideal world, whenever I see an op in a dialect I haven't worked with before, I should have a decent idea of what it does. You can see some syntax convergence, but also exceptions. It's annoying. I'm not sure if it's too late to create something sensible at this point, or even if it's possible in something of MLIR's nature, but I think it's worth considering. Naming conventions for ops, types, and attributes, operand order, keywords for different types of operations (like the into and from in data movement operations).

I offer myself as volunteer to start some sort of draft collecting common practices in the core dialects, if it's any help. It doesn't even need to be prescriptive, it might be valuable as a reference for people starting a new dialect 🤷Thoughts?

Sep 11 2022, 6:10 PM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2022

stellaraccident added a comment to D133076: [mlir][arith] Change the syntax of `arith.cmpi/f`.

(sarcastic) So we should stage the removal of the comma by first making it optional, parsed with a warning that "The comma is deprecated and will be removed on Sept 10" to give users time to migrate.

In all seriousness, it was useful gauging the feedback for a relatively minimal change with big user impact. My concern specifically is that if we are in the position of introducing new compare ops (e.g. in new dialects), "keeping it consistent with arith" means adopting a perhaps less-than-optimal syntax. Hence, arith should be updated to a "better" syntax, which other dialects can copy.

Sep 2 2022, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2022

stellaraccident added a comment to D133076: [mlir][arith] Change the syntax of `arith.cmpi/f`.

Personally, I'm +1 on cleaning things up but -1 that this is an actual improvement in consistency and legibility (based on a cursory review of the prevailing style). I'm with ftynse's interpretation, and while I could see the argument for removing the comma, I don't think that is an improvement either.

Sep 1 2022, 3:26 PM · Restricted Project, Restricted Project, Restricted Project
stellaraccident added a comment to D133076: [mlir][arith] Change the syntax of `arith.cmpi/f`.

Personally, I'm +1 on cleaning things up but -1 that this is an actual improvement in consistency and legibility (based on a cursory review of the prevailing style). I'm with ftynse's interpretation, and while I could see the argument for removing the comma, I don't think that is an improvement either.

Sep 1 2022, 3:23 PM · Restricted Project, Restricted Project, Restricted Project

Aug 25 2022

stellaraccident added inline comments to rGf55a6fde1d47: [mlir] Make sure that aggregate shared libraries define all of their symbols..
Aug 25 2022, 5:04 PM · Restricted Project, Restricted Project

Aug 19 2022

stellaraccident added inline comments to D132243: [mlir][MemRef] Introduce a memref.extract_metadata op..
Aug 19 2022, 9:02 AM · Restricted Project, Restricted Project
stellaraccident accepted D132243: [mlir][MemRef] Introduce a memref.extract_metadata op..

This looks good to me but I'd like to see the reviews of the other contributors to the conversation before landing.

Aug 19 2022, 8:49 AM · Restricted Project, Restricted Project

Aug 17 2022

stellaraccident accepted D131151: [mlir][test] Require JIT support in JIT tests.

Thanks and sorry for missing this. Ditto to what Mehdi said about pinging for things that have direct impacts like this.

Aug 17 2022, 5:50 AM · Restricted Project, Restricted Project

Aug 15 2022

stellaraccident accepted D131919: Move googletest to the third-party directory.
Aug 15 2022, 9:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident added inline comments to D131919: Move googletest to the third-party directory.
Aug 15 2022, 1:51 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
stellaraccident committed rGf55a6fde1d47: [mlir] Make sure that aggregate shared libraries define all of their symbols. (authored by stellaraccident).
[mlir] Make sure that aggregate shared libraries define all of their symbols.
Aug 15 2022, 12:02 PM · Restricted Project, Restricted Project
stellaraccident closed D131911: [mlir] Make sure that aggregate shared libraries define all of their symbols..
Aug 15 2022, 12:02 PM · Restricted Project, Restricted Project
stellaraccident added a reviewer for D131911: [mlir] Make sure that aggregate shared libraries define all of their symbols.: stella.stamenova.
Aug 15 2022, 11:22 AM · Restricted Project, Restricted Project
stellaraccident requested review of D131911: [mlir] Make sure that aggregate shared libraries define all of their symbols..
Aug 15 2022, 11:21 AM · Restricted Project, Restricted Project

Aug 8 2022

stellaraccident added a comment to D131237: [mlir][Linalg] Canonicalize decomposed ops by default..

I'm ok/supportive of having the option in the test pass to run with canonicalizations mixed in: it isn't a bad idea to be and to test that they work together. But yeah, I'm not thrilled about coupling that in the actual populate method.

Aug 8 2022, 8:37 PM · Restricted Project, Restricted Project

Aug 7 2022

stellaraccident added inline comments to D131237: [mlir][Linalg] Canonicalize decomposed ops by default..
Aug 7 2022, 11:17 PM · Restricted Project, Restricted Project
stellaraccident added a comment to D131237: [mlir][Linalg] Canonicalize decomposed ops by default..

I did add the canonicalization patterns to a downstream and have observed that they do "help" a lot of real cases I was seeing get to a fully decomposed state.

Aug 7 2022, 11:16 PM · Restricted Project, Restricted Project

Aug 4 2022

stellaraccident added a comment to D131237: [mlir][Linalg] Canonicalize decomposed ops by default..

Makes sense to me in theory. Is there a kind of case we can test for that needs this?

Aug 4 2022, 10:01 PM · Restricted Project, Restricted Project

Aug 1 2022

stellaraccident abandoned D120788: [cmake] Add INTERFACE_INCLUDE_DIRECTORIES to LLVM and MLIR..

FYI - Some intervening changes rendered this patch at least partially invalid and I never parsed back through and redid it. Consider it for inspirational value if anyone wants to pick it up.

Aug 1 2022, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Jul 27 2022

stellaraccident committed rG7356404ace4b: [mlir] Delete most of the ops from the quant dialect. (authored by stellaraccident).
[mlir] Delete most of the ops from the quant dialect.
Jul 27 2022, 5:51 PM · Restricted Project, Restricted Project
stellaraccident closed D120204: [mlir] Delete most of the quant dialect..
Jul 27 2022, 5:51 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D120204: [mlir] Delete most of the quant dialect..

Rebase

Jul 27 2022, 5:17 PM · Restricted Project, Restricted Project
stellaraccident accepted D130527: [mlir][Linalg] Allow decompose to handle ops when value of `outs` operand is used in payload..

Thank you!

Jul 27 2022, 4:50 PM · Restricted Project, Restricted Project

Jul 21 2022

stellaraccident accepted D130271: [mlir][python] Fix issues with block argument slices.

Good catch, and thank you!

Jul 21 2022, 7:33 AM · Restricted Project, Restricted Project

Jul 19 2022

stellaraccident accepted D130143: [mlir] Fix macOS tests.

Do you have commit access?

Jul 19 2022, 9:18 PM · Restricted Project, Restricted Project

Jul 18 2022

stellaraccident added a comment to D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Sorry, yes - I submitted a follow-up and neglected to note on this thread: https://reviews.llvm.org/rGbeebffa9ab81bba3de91b2cee7a62578ebe1ae00

Jul 18 2022, 6:35 AM · Restricted Project, Restricted Project

Jul 16 2022

stellaraccident committed rGbeebffa9ab81: [NFC] Remove obsolete all_passes_registration from integration tests. (authored by stellaraccident).
[NFC] Remove obsolete all_passes_registration from integration tests.
Jul 16 2022, 6:20 PM · Restricted Project, Restricted Project
stellaraccident committed rG5e83a5b4752d: [mlir] Overhaul C/Python registration APIs to properly scope… (authored by stellaraccident).
[mlir] Overhaul C/Python registration APIs to properly scope…
Jul 16 2022, 5:28 PM · Restricted Project, Restricted Project
stellaraccident closed D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..
Jul 16 2022, 5:28 PM · Restricted Project, Restricted Project
stellaraccident updated the diff for D128593: [mlir] Overhaul C/Python registration APIs to properly scope registration/loading activities..

Rebase, fix standalone example, attempt to patch bazel as best I could.

Jul 16 2022, 5:00 PM · Restricted Project, Restricted Project

Jul 15 2022

stellaraccident closed D129604: [mlir] Print the pass argument in parens for print-ir-before/after..

Closed by https://reviews.llvm.org/rG1d6a90418e4bfc294b4174880e93cb43835ebdf5 (messed up the arcanist command and association was lost)

Jul 15 2022, 11:29 PM · Restricted Project, Restricted Project
stellaraccident added a comment to rG1d6a90418e4b: Example:.

Note that this is associated with https://reviews.llvm.org/D129604 (messed up the arcanist command and association was lost)

Jul 15 2022, 11:28 PM · Restricted Project, Restricted Project