User Details
- User Since
- Dec 20 2019, 9:16 PM (132 w, 3 d)
Yesterday
FYI - this patch has a minor bug in it when used as part of larger projects. Line 214 creates duplicate target names in some cases. It needs to be scoped (like is done for the target just below it).
Tue, Jun 28
Mon, Jun 27
A few very minor nits, but otherwise lgtm.
Comments.
Move closer to end state.
Sun, Jun 26
I think we need to revisit this patch as it is broken for some very common cases. Left notes here: https://github.com/llvm/llvm-project/issues/56235
Fix fir test.
Rebase
Sat, Jun 25
Fri, Jun 24
Thu, Jun 23
Thank you for this. As we discussed on Discord, I didn't know about the inheritable sources on interface libraries, and that simplifies things. A couple of comments for my own education, but otherwise looks good.
Tue, Jun 21
(also sorry for some auto correct typos - on mobile)
Thanks for this. Just one comment of the variety of "have you considered doing it entirely differently) :) I'm not convinced either way -- open to discuss
Sun, Jun 19
Nice! Are the builtin dialect docs auto-generated somehow, or is there something we should update in this patch? (https://mlir.llvm.org/docs/Dialects/Builtin/#arrayattr)
Sat, Jun 18
Wed, Jun 15
Thanks for the contribution. I'll land it at my next opportunity, then.
Thanks - good catch. Do you have commit access to land?
Tue, Jun 14
Thanks for doing this!
Mon, Jun 6
Idk - I haven't seen the failures. It passed presubmit Benoit I landed (phab says it didn't because I did a trivial rebase/addressed comments right before).
Sun, Jun 5
comments and rebase
Jun 1 2022
Remove braces.
Tweak based on comments.
Bazel updates.
May 31 2022
Comments.
Comments
May 29 2022
May 28 2022
Generally LGTM, although we may want to further constrain this in a follow-up. In general, I am pro having optimization passes and having them be truly optional. I would be tempted to name this "TensorDataConstantOptimizationPass".
May 27 2022
Add chains.
Comments
May 25 2022
I think Mehdi wrote some of this originally. I'll review as well but need to study it...
May 24 2022
May 23 2022
Note: design discussion continuing on discourse: https://discourse.llvm.org/t/rfc-introduce-ml-program-dialect-and-top-level-ops-proposal-v2/60907/51
May 22 2022
May 19 2022
Yes, I will land it either tomorrow or this weekend. Thank you for the patch!
May 18 2022
Comments
Comments
May 17 2022
Update bazel files.
Update bazel files.
Jacques/Jeff, please take a look if you have a chance. I see there is a patch pending to fix the attribute parser declarations, but that will be a minor adaptation. I think the IR format is good enough as I have it here.
Rebase and adapt to self-type attribute fix.
Thanks!
May 15 2022
May 10 2022
Thank you for the clarifications. lgtm.
May 9 2022
I am glad that an actual Windows dev (versus someone who just occasionally plays one on TV) is looking at this. I've never understood the windows debug/release/runtime version dichotomies when not just working on a stock VS based project that automatically does the right thing.