- User Since
- Dec 20 2019, 9:16 PM (49 w, 5 d)
Thanks! Been meaning to add the verify hook for a while.
Mon, Nov 30
Sun, Nov 29
Wed, Nov 25
Tue, Nov 24
Commandeer change and resolve comments.
Does anyone mind if I commandeer this change (it is broken at head)?
Sun, Nov 22
Address comments and rebase
Fri, Nov 20
Tue, Nov 17
Thanks - a few nits. Maybe put a message on discord when you land indicating the new version requirement (and tag ftynse since he is working on this)
Mon, Nov 16
Gentle ping - fixes the Windows build and working to get the bot up.
Thanks - I prefer this version, but have a material request wrt readonly access.
This is quite slick. A couple of nits.
Wow, that has been a minute since that was discussed. I'm not 100% sure these days that I would encode this in the type system if I were doing it, but having the representation to do it is fine with me.
Thu, Nov 12
Wed, Nov 11
Rebase and comments
Rebase and test on Windows.
Aside from nits that River is discussing, lgtm! Thanks for this!
Tue, Nov 10
Mon, Nov 9
Sun, Nov 8
Yes, we'll update the parameters once the container is ready.
Pure re-apply of previously reviewed revision.
This is very nice, and the corresponding RFC seems to have gotten to a nice conclusion.
Sat, Nov 7
Mehdi: I just followed the example of how this is done for Affine. Not sure if there is a plan to systematize these test passes long term.
Fixed in https://reviews.llvm.org/D91022 (just waiting on the bots and then
Found the problem and will send a fix shortly.
Thank you for the report: I don't think we have a bit which verifies that,
so it is plausible. I will triage this momentarily.
Will do. The review thread was getting confusing. If you have further comments, I will work with you to land them in a follow-up.