Page MenuHomePhabricator
Differential D97471

[SVE] Fix LoopVectorizer test scalalable-call.ll
ClosedPublic
Actions

Authored by sdesmalen on Feb 25 2021, 6:38 AM.

Details

Reviewers
efriedma
dmgreen
paulwalker-arm
kmclaughlin
Commits
rG7108b2dec17d: [SVE] Fix LoopVectorizer test scalalable-call.ll
Summary

This marks FSIN and other operations to EXPAND for scalable
vectors, so that they are not assumed to be legal by the cost-model.

Depends on D97470

Diff Detail

Event Timeline

sdesmalen created this revision.Feb 25 2021, 6:38 AM
Herald added a reviewer: efriedma. · View Herald TranscriptFeb 25 2021, 6:38 AM
Herald added subscribers: psnobl, hiraditya, tschuett. · View Herald Transcript
sdesmalen requested review of this revision.Feb 25 2021, 6:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2021, 6:38 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B90813: Diff 326380.Feb 25 2021, 7:43 AM
sdesmalen added reviewers: dmgreen, paulwalker-arm, kmclaughlin.Feb 25 2021, 7:58 AM
paulwalker-arm accepted this revision.Feb 25 2021, 9:27 AM
This revision is now accepted and ready to land.Feb 25 2021, 9:27 AM
dmgreen added a comment.Feb 28 2021, 10:40 AM

Are codegen test for these impossible? If so can costmodel tests be added, showing invalid costs?

sdesmalen updated this revision to Diff 327100.Mar 1 2021, 6:26 AM

Added tests showing unknown costs.

The only two ISD nodes not covered with cost tests are:

  • SINCOS as this can't be expressed in IR directly.
  • FREM as this requires getArithmeticInstrCost to be migrated to InstructionCost.
Harbormaster completed remote builds in B91328: Diff 327100.Mar 1 2021, 7:53 AM
dmgreen accepted this revision.Mar 1 2021, 7:58 AM

Thanks for the fix. LGTM.

(We might want to consider change it from "Unknown" to "Invalid", if the meaning is now that the cost is essentially infinite.)

This revision was landed with ongoing or failed builds.Wed, Mar 31, 7:02 AM
Closed by commit rG7108b2dec17d: [SVE] Fix LoopVectorizer test scalalable-call.ll (authored by sdesmalen). · Explain Why
This revision was automatically updated to reflect the committed changes.
sdesmalen added a commit: rG7108b2dec17d: [SVE] Fix LoopVectorizer test scalalable-call.ll.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
AArch64/
12 lines
Transforms/
Vectorize/
8 lines
test/
Analysis/
CostModel/
AArch64/
34 lines
Transforms/
LoopVectorize/
AArch64/
3 lines

Diff 334431

View Options

llvm/lib/Target/AArch64/AArch64ISelLowering.cpp

Loading...
View Options

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

Loading...
View Options

llvm/test/Analysis/CostModel/AArch64/sve-intrinsics.ll

Loading...
View Options

llvm/test/Transforms/LoopVectorize/AArch64/scalable-call.ll

Loading...