Page MenuHomePhabricator

[SVE] Fix LoopVectorizer test scalalable-call.ll
ClosedPublic

Authored by sdesmalen on Feb 25 2021, 6:38 AM.

Details

Summary

This marks FSIN and other operations to EXPAND for scalable
vectors, so that they are not assumed to be legal by the cost-model.

Depends on D97470

Diff Detail

Event Timeline

sdesmalen created this revision.Feb 25 2021, 6:38 AM
sdesmalen requested review of this revision.Feb 25 2021, 6:38 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2021, 6:38 AM
paulwalker-arm accepted this revision.Feb 25 2021, 9:27 AM
This revision is now accepted and ready to land.Feb 25 2021, 9:27 AM

Are codegen test for these impossible? If so can costmodel tests be added, showing invalid costs?

sdesmalen updated this revision to Diff 327100.Mar 1 2021, 6:26 AM

Added tests showing unknown costs.

The only two ISD nodes not covered with cost tests are:

  • SINCOS as this can't be expressed in IR directly.
  • FREM as this requires getArithmeticInstrCost to be migrated to InstructionCost.
dmgreen accepted this revision.Mar 1 2021, 7:58 AM

Thanks for the fix. LGTM.

(We might want to consider change it from "Unknown" to "Invalid", if the meaning is now that the cost is essentially infinite.)

This revision was landed with ongoing or failed builds.Wed, Mar 31, 7:02 AM
This revision was automatically updated to reflect the committed changes.