Page MenuHomePhabricator

[UpdateTestChecks] Warn if any function conflicts under the same prefix
Needs ReviewPublic

Authored by qiucf on Feb 19 2021, 7:23 PM.



Currently the update test script will only output warning if all functions have conflict under different run lines with same prefix, and be silent if part of them conflict. This looks counterintuitive and leads to confusion sometimes.

Diff Detail

Event Timeline

qiucf created this revision.Feb 19 2021, 7:23 PM
qiucf requested review of this revision.Feb 19 2021, 7:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 19 2021, 7:23 PM

lgtm code-wise. Added folks who were also interested in this, from a user perspective (I'm not a user of the tool, can't comment on that aspect.)

mtrofin added inline comments.Feb 19 2021, 7:34 PM

Nit: may be worth renaming this function to more accurately reflect its new behavior. For example: _get_prefixes_failing_functions (or better name).

pengfei added inline comments.Feb 19 2021, 7:38 PM

I think the warn only conflicting for all functions is used for the multi prefixes case, e.g. --check-prefixes=A,B;--check-prefixes=A,C when we hope the conflicted functions use B and C respectively. Under which case, warn A conflicted is annoying.