This is an archive of the discontinued LLVM Phabricator instance.

clang-cl: Remove /Zd flag
ClosedPublic

Authored by thakis on Dec 17 2020, 6:25 AM.

Details

Summary

cl.exe doesn't understand Zd (in either MSVC 2017 or 2019), so neiter
should we. It used to do the same as -gline-tables-only which is
exposed as clang-cl flag as well, so if you want this behavior, use
gline-tables-only. That makes it clear that it's a clang-cl-only flag
that won't work with cl.exe.

Motivated by the discussion in D92958.

Diff Detail

Event Timeline

thakis created this revision.Dec 17 2020, 6:25 AM
thakis requested review of this revision.Dec 17 2020, 6:25 AM
aeubanks accepted this revision.Dec 17 2020, 9:19 AM
aeubanks added reviewers: rnk, hans.

lgtm, but perhaps Reid should take a look

clang/docs/ReleaseNotes.rst
127
This revision is now accepted and ready to land.Dec 17 2020, 9:20 AM
rnk accepted this revision.Dec 17 2020, 10:57 AM

lgtm

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 12:40 PM