Paths

Table of Contentst

Differential D93098

[mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation.
ClosedPublic
Actions

Authored by csigg on Dec 11 2020, 2:43 AM.

Details

Reviewers

rriddle
ftynse
nicolasvasilache
mravishankar
antiagainst
herhut
aartbik
mehdi_amini

Commits

rG1ffc1aaa0967: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation.

Summary

This is a preparation step to remove those methods from OpState.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	50 ms	x64 windows > LLVM.CodeGen/XCore::threads.ll Script: -- : 'RUN: at line 1'; c:\ws\w64\llvm-project\premerge-checks\build\bin\llc.exe -march=xcore < C:\ws\w64\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll \| c:\ws\w64\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w64\llvm-project\premerge-checks\llvm\test\CodeGen\XCore\threads.ll

Event Timeline

csigg created this revision.Dec 11 2020, 2:43 AM

Herald added a reviewer: rriddle. · View Herald TranscriptDec 11 2020, 2:43 AM

Herald added a reviewer: ftynse. · View Herald Transcript

Herald added subscribers: mravishankar, teijeong, rdzhabarov and 16 others. · View Herald Transcript

csigg requested review of this revision.Dec 11 2020, 2:43 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptDec 11 2020, 2:43 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B81993: Diff 311150.Dec 11 2020, 3:07 AM

Seems like a related test failure in mlir-tblgen::op-attribute.td ?

Fix op-attribute.td test.

Harbormaster completed remote builds in B82137: Diff 311367.Dec 11 2020, 11:03 PM

More fixes.

Herald added a reviewer: mravishankar. · View Herald TranscriptDec 12 2020, 1:51 AM

Herald added a reviewer: antiagainst. · View Herald Transcript

Herald added a reviewer: herhut. · View Herald Transcript

Herald added a reviewer: aartbik. · View Herald Transcript

Herald added subscribers: ThomasRaoux, AlexeySotkin. · View Herald Transcript

Harbormaster completed remote builds in B82139: Diff 311371.Dec 12 2020, 2:07 AM

mehdi_amini added inline comments.Dec 12 2020, 9:47 AM

mlir/include/mlir/Dialect/Affine/IR/AffineOps.h
110	Nit: `getOperation()` may be more friendly to read than `(*this)`

mehdi_amini accepted this revision.Dec 12 2020, 9:47 AM

This revision is now accepted and ready to land.Dec 12 2020, 9:47 AM

csigg added inline comments.Dec 13 2020, 12:46 AM

mlir/include/mlir/Dialect/Affine/IR/AffineOps.h
110	I also don't really like to read `(this)->` or `(it)->`, but I thought it's a personal quirk and switched from `getOperation()->` when River suggested it here. It probably makes sense to keep it consistent.

This revision was landed with ongoing or failed builds.Dec 13 2020, 12:58 AM

Closed by commit rG1ffc1aaa0967: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. (authored by csigg). · Explain Why

This revision was automatically updated to reflect the committed changes.

csigg added a commit: rG1ffc1aaa0967: [mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation..

Revision Contents
Changeset List

Path

Size

flang/

include/

flang/

Optimizer/

Dialect/

2 lines

mlir/

include/

mlir/

Dialect/

Affine/

IR/

8 lines

16 lines

Linalg/

IR/

LinalgStructuredOpsInterface.td

6 lines

StandardOps/

IR/

2 lines

IR/

FunctionSupport.h

2 lines

1 line

SymbolInterfaces.td

2 lines

lib/

Analysis/

2 lines

Conversion/

GPUCommon/

ConvertKernelFuncToBlob.cpp

2 lines

GPUToSPIRV/

ConvertGPUToSPIRV.cpp

2 lines

GPUToVulkan/

ConvertGPULaunchFuncToVulkanLaunchFunc.cpp

4 lines

LinalgToStandard/

LinalgToStandard.cpp

2 lines

SCFToGPU/

4 lines

SPIRVToLLVM/

ConvertSPIRVToLLVM.cpp

18 lines

StandardToLLVM/

StandardToLLVM.cpp

4 lines

Dialect/

Affine/

IR/

18 lines

Utils/

4 lines

GPU/

IR/

5 lines

Transforms/

KernelOutlining.cpp

8 lines

ParallelLoopMapper.cpp

6 lines

LLVMIR/

IR/

LLVMDialect.cpp

4 lines

Linalg/

Transforms/

Interchange.cpp

8 lines

SPIRV/

SPIRVLowering.cpp

4 lines

Serialization/

Deserializer.cpp

15 lines

14 lines

Transforms/

UpdateVCEPass.cpp

2 lines

Vector/

22 lines

VectorTransforms.cpp

4 lines

test/

lib/

Dialect/

SPIRV/

TestEntryPointAbi.cpp

6 lines

Test/

TestDialect.cpp

2 lines

2 lines

TestPatterns.cpp

2 lines

Transforms/

TestCallGraph.cpp

3 lines

mlir-tblgen/

op-attribute.td

18 lines

tools/

mlir-tblgen/

OpDefinitionsGen.cpp

27 lines

OpFormatGen.cpp

2 lines

SPIRVUtilsGen.cpp

4 lines

Diff 311371

flang/include/flang/Optimizer/Dialect/FIROps.td

Loading...

mlir/include/mlir/Dialect/Affine/IR/AffineOps.h

Loading...

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Loading...

mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td

Loading...

mlir/include/mlir/Dialect/StandardOps/IR/Ops.td

Loading...

mlir/include/mlir/IR/FunctionSupport.h

Loading...

mlir/include/mlir/IR/Operation.h

Loading...

mlir/include/mlir/IR/SymbolInterfaces.td

Loading...

mlir/lib/Analysis/Utils.cpp

Loading...

mlir/lib/Conversion/GPUCommon/ConvertKernelFuncToBlob.cpp

Loading...

mlir/lib/Conversion/GPUToSPIRV/ConvertGPUToSPIRV.cpp

Loading...

mlir/lib/Conversion/GPUToVulkan/ConvertGPULaunchFuncToVulkanLaunchFunc.cpp

Loading...

mlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp

Loading...

mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp

Loading...

mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp

Loading...

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Loading...

mlir/lib/Dialect/Affine/IR/AffineOps.cpp

Loading...

mlir/lib/Dialect/Affine/Utils/Utils.cpp

Loading...

mlir/lib/Dialect/GPU/IR/GPUDialect.cpp

Loading...

mlir/lib/Dialect/GPU/Transforms/KernelOutlining.cpp

Loading...

mlir/lib/Dialect/GPU/Transforms/ParallelLoopMapper.cpp

Loading...

mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp

Loading...

mlir/lib/Dialect/Linalg/Transforms/Interchange.cpp

Loading...

mlir/lib/Dialect/SPIRV/SPIRVLowering.cpp

Loading...

mlir/lib/Dialect/SPIRV/Serialization/Deserializer.cpp

Loading...

mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp

Loading...

mlir/lib/Dialect/SPIRV/Transforms/UpdateVCEPass.cpp

Loading...

mlir/lib/Dialect/Vector/VectorOps.cpp

Loading...

mlir/lib/Dialect/Vector/VectorTransforms.cpp

Loading...

mlir/test/lib/Dialect/SPIRV/TestEntryPointAbi.cpp

Loading...

mlir/test/lib/Dialect/Test/TestDialect.cpp

Loading...

mlir/test/lib/Dialect/Test/TestOps.td

Loading...

mlir/test/lib/Dialect/Test/TestPatterns.cpp

Loading...

mlir/test/lib/Transforms/TestCallGraph.cpp

Loading...

mlir/test/mlir-tblgen/op-attribute.td

Loading...

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Loading...

mlir/tools/mlir-tblgen/OpFormatGen.cpp

Loading...

mlir/tools/mlir-tblgen/SPIRVUtilsGen.cpp

Loading...