Page MenuHomePhabricator
People csigg

csigg (Christian Sigg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 10:10 AM (52 w, 1 d)

Recent Activity
View All

Today

csigg added inline comments to D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..
Tue, Nov 24, 1:09 PM · Restricted Project
csigg updated the diff for D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..

Thanks for the review!

Tue, Nov 24, 1:08 PM · Restricted Project

Wed, Nov 18

csigg requested review of D91698: [mlir] Add gpu.allocate, gpu.deallocate ops with LLVM lowering to runtime function calls..
Wed, Nov 18, 4:26 AM · Restricted Project
csigg committed rG8b97e17d161a: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr(). (authored by csigg).
[mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr().
Wed, Nov 18, 2:52 AM
csigg closed D91599: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr()..
Wed, Nov 18, 2:52 AM · Restricted Project

Tue, Nov 17

csigg updated the diff for D91599: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr()..

Rebase.

Tue, Nov 17, 10:23 AM · Restricted Project
csigg committed rGbedaad44953a: [mlir] Simplify std.alloc lowering to LLVM. (authored by csigg).
[mlir] Simplify std.alloc lowering to LLVM.
Tue, Nov 17, 9:56 AM
csigg closed D91549: [mlir] Simplify std.alloc lowering to LLVM..
Tue, Nov 17, 9:55 AM · Restricted Project
csigg added inline comments to D91549: [mlir] Simplify std.alloc lowering to LLVM..
Tue, Nov 17, 9:02 AM · Restricted Project
csigg updated the diff for D91549: [mlir] Simplify std.alloc lowering to LLVM..

Extend documentation.

Tue, Nov 17, 9:02 AM · Restricted Project
csigg committed rG43ede0e2a7ff: [mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts(). (authored by csigg).
[mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts().
Tue, Nov 17, 8:26 AM
csigg closed D91594: [mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts()..
Tue, Nov 17, 8:25 AM · Restricted Project
csigg requested review of D91599: [mlir] Simplify code generated by ConvertToLLVMPattern::getStridedElementPtr()..
Tue, Nov 17, 1:23 AM · Restricted Project
csigg requested review of D91594: [mlir] Remove unused ConvertToLLVMPattern::linearizeSubscripts()..
Tue, Nov 17, 12:32 AM · Restricted Project

Mon, Nov 16

csigg requested review of D91549: [mlir] Simplify std.alloc lowering to LLVM..
Mon, Nov 16, 8:32 AM · Restricted Project
csigg committed rG04481f26faff: [mlir] Require std.alloc() ops to have canonical layout during LLVM lowering. (authored by csigg).
[mlir] Require std.alloc() ops to have canonical layout during LLVM lowering.
Mon, Nov 16, 8:30 AM
csigg closed D91523: [mlir] Require std.alloc() ops to have canonical layout during LLVM lowering..
Mon, Nov 16, 8:29 AM · Restricted Project
csigg requested review of D91523: [mlir] Require std.alloc() ops to have canonical layout during LLVM lowering..
Mon, Nov 16, 2:42 AM · Restricted Project

Sun, Nov 15

csigg committed rG906220b5e9b3: [mlir] NFC: tiny fix in comment. (authored by csigg).
[mlir] NFC: tiny fix in comment.
Sun, Nov 15, 1:39 AM
csigg closed D91430: [mlir] NFC: tiny fix in comment..
Sun, Nov 15, 1:39 AM · Restricted Project

Fri, Nov 13

csigg updated the diff for D91430: [mlir] NFC: tiny fix in comment..

Add another one.

Fri, Nov 13, 8:23 AM · Restricted Project
csigg requested review of D91430: [mlir] NFC: tiny fix in comment..
Fri, Nov 13, 8:18 AM · Restricted Project

Thu, Nov 12

csigg added a comment to D90589: [mlir] Use assemblyFormat in AllocLikeOp..
In D90589#2391801, @stella.stamenova wrote:

onnx-mlir (https://github.com/onnx/onnx-mlir) is currently using parseDimAndSymbolList. Is the intention for this function to not be available outside of mlir any more? I notice it no longer has any uses inside mlir either.

Thu, Nov 12, 11:29 PM · Restricted Project

Wed, Nov 11

csigg accepted D91183: Added GDB pretty printer for StringMap.

Looks great, thanks!

Wed, Nov 11, 10:11 AM · Restricted Project
csigg committed rG3307a7c046cb: [mlir][gpu] Add missing initialization of gpu runtime wrappers. (authored by csigg).
[mlir][gpu] Add missing initialization of gpu runtime wrappers.
Wed, Nov 11, 1:34 AM
csigg closed D91148: [mlir][gpu] Add missing initialization of gpu runtime wrappers..
Wed, Nov 11, 1:34 AM · Restricted Project
csigg committed rG5bdb21df21c6: [mlir] Use assemblyFormat in AllocLikeOp. (authored by csigg).
[mlir] Use assemblyFormat in AllocLikeOp.
Wed, Nov 11, 1:27 AM
csigg closed D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Wed, Nov 11, 1:27 AM · Restricted Project
csigg updated the summary of D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Wed, Nov 11, 12:47 AM · Restricted Project
csigg updated the diff for D90589: [mlir] Use assemblyFormat in AllocLikeOp..

Don't introduce extra space.

Wed, Nov 11, 12:45 AM · Restricted Project
csigg committed rG5dfe6545d4aa: [mlir] Allow omitting spaces in assemblyFormat with a `` literal. (authored by csigg).
[mlir] Allow omitting spaces in assemblyFormat with a `` literal.
Wed, Nov 11, 12:35 AM
csigg closed D91068: [mlir] Allow omitting spaces in assemblyFormat with a `` literal..
Wed, Nov 11, 12:34 AM · Restricted Project

Tue, Nov 10

csigg updated the diff for D91068: [mlir] Allow omitting spaces in assemblyFormat with a `` literal..

Change to proper accessor.

Tue, Nov 10, 11:25 PM · Restricted Project
csigg added inline comments to D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Tue, Nov 10, 11:56 AM · Restricted Project
csigg added a comment to D91183: Added GDB pretty printer for StringMap.

Would it be possible to the StringMap to the existing test? (Note that the debug-info tests are not run as part of the pre-merge checks, you need to run them manually).

Tue, Nov 10, 11:33 AM · Restricted Project
csigg requested review of D91148: [mlir][gpu] Add missing initialization of gpu runtime wrappers..
Tue, Nov 10, 3:57 AM · Restricted Project
csigg updated the diff for D90589: [mlir] Use assemblyFormat in AllocLikeOp..

Also add space to affine_map and affine.apply etc.

Tue, Nov 10, 12:19 AM · Restricted Project

Mon, Nov 9

csigg added inline comments to D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Mon, Nov 9, 4:13 AM · Restricted Project
csigg added a reviewer for D91068: [mlir] Allow omitting spaces in assemblyFormat with a `` literal.: rriddle.
Mon, Nov 9, 4:06 AM · Restricted Project
csigg requested review of D91068: [mlir] Allow omitting spaces in assemblyFormat with a `` literal..
Mon, Nov 9, 4:06 AM · Restricted Project

Mon, Nov 2

csigg added inline comments to D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Mon, Nov 2, 5:00 AM · Restricted Project
csigg updated the summary of D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Mon, Nov 2, 12:27 AM · Restricted Project
csigg requested review of D90589: [mlir] Use assemblyFormat in AllocLikeOp..
Mon, Nov 2, 12:27 AM · Restricted Project

Thu, Oct 29

csigg updated the diff for D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..

Rebase.

Thu, Oct 29, 2:22 PM · Restricted Project
csigg committed rGdb7129a005c1: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously. (authored by csigg).
[mlir][gpu] Add pass to make GPU ops within a region execute asynchronously.
Thu, Oct 29, 2:18 PM
csigg closed D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..
Thu, Oct 29, 2:18 PM · Restricted Project
csigg committed rGfce99e5f739e: [mlir][gpu] Handle async in gpu.launch_func lowering. (authored by csigg).
[mlir][gpu] Handle async in gpu.launch_func lowering.
Thu, Oct 29, 2:17 PM
csigg closed D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..
Thu, Oct 29, 2:16 PM · Restricted Project
csigg updated the diff for D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..

Rebase.

Thu, Oct 29, 1:53 PM · Restricted Project
csigg updated the diff for D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..

Rebase.

Thu, Oct 29, 1:51 PM · Restricted Project
csigg committed rG355611408384: [mlir][gpu] Allow gpu.launch_func to be async. (authored by csigg).
[mlir][gpu] Allow gpu.launch_func to be async.
Thu, Oct 29, 1:49 PM
csigg closed D90420: [mlir][gpu] Allow gpu.launch_func to be async..
Thu, Oct 29, 1:48 PM · Restricted Project
csigg requested review of D90420: [mlir][gpu] Allow gpu.launch_func to be async..
Thu, Oct 29, 1:25 PM · Restricted Project
csigg committed rGb22f111023ba: [mlir][gpu] NFC: Change gpu.launch_func ops to custom format. (authored by csigg).
[mlir][gpu] NFC: Change gpu.launch_func ops to custom format.
Thu, Oct 29, 1:21 PM
csigg closed D90410: [mlir][gpu] NFC: Change gpu.launch_func ops to custom format..
Thu, Oct 29, 1:21 PM · Restricted Project
csigg requested review of D90410: [mlir][gpu] NFC: Change gpu.launch_func ops to custom format..
Thu, Oct 29, 11:16 AM · Restricted Project
csigg updated the diff for D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..

Rebase.

Thu, Oct 29, 10:14 AM · Restricted Project
csigg updated the diff for D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..

Rebase.

Thu, Oct 29, 10:11 AM · Restricted Project
csigg updated the diff for D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..

Rebase.

Thu, Oct 29, 10:03 AM · Restricted Project
csigg committed rGec7780ebdab4: [mlir][gpu] Allow gpu.launch_func to be async. (authored by csigg).
[mlir][gpu] Allow gpu.launch_func to be async.
Thu, Oct 29, 9:55 AM
csigg closed D89324: [mlir][gpu] Allow gpu.launch_func to be async..
Thu, Oct 29, 9:55 AM · Restricted Project
csigg added a comment to D90370: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to runtime calls..

Thanks Mehdi for the quick review!

Thu, Oct 29, 12:41 AM · Restricted Project
csigg committed rG97b351a82767: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to… (authored by csigg).
[mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to…
Thu, Oct 29, 12:41 AM
csigg closed D90370: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to runtime calls..
Thu, Oct 29, 12:41 AM · Restricted Project
csigg requested review of D90370: [mlir][gpu] Fix leaked stream and module when lowering gpu.launch_func to runtime calls..
Thu, Oct 29, 12:18 AM · Restricted Project

Wed, Oct 28

csigg requested review of D90346: [mlir][gpu] Move gpu.wait ops from async.execute regions to its dependencies..
Wed, Oct 28, 2:59 PM · Restricted Project

Tue, Oct 27

csigg committed rG8c176b602986: [mlir] Catch async.yield operands not matching the number of async.execute… (authored by csigg).
[mlir] Catch async.yield operands not matching the number of async.execute…
Tue, Oct 27, 11:39 AM
csigg closed D90211: [mlir] Catch async.yield operands not matching the number of async.execute results..
Tue, Oct 27, 11:39 AM · Restricted Project
csigg added inline comments to D90211: [mlir] Catch async.yield operands not matching the number of async.execute results..
Tue, Oct 27, 1:46 AM · Restricted Project
csigg updated the diff for D90211: [mlir] Catch async.yield operands not matching the number of async.execute results..

Much cleaner, thanks River!

Tue, Oct 27, 1:46 AM · Restricted Project
csigg updated the diff for D90211: [mlir] Catch async.yield operands not matching the number of async.execute results..

Fix.

Tue, Oct 27, 1:32 AM · Restricted Project
csigg added a reviewer for D90211: [mlir] Catch async.yield operands not matching the number of async.execute results.: ezhulenev.
Tue, Oct 27, 12:01 AM · Restricted Project
csigg requested review of D90211: [mlir] Catch async.yield operands not matching the number of async.execute results..
Tue, Oct 27, 12:01 AM · Restricted Project

Mon, Oct 26

csigg committed rGe851e566d4ae: [mlir] Fix TypeID lookup in GDB pretty printers. (authored by csigg).
[mlir] Fix TypeID lookup in GDB pretty printers.
Mon, Oct 26, 11:12 PM
csigg closed D90191: [mlir] Fix TypeID lookup in GDB pretty printers..
Mon, Oct 26, 11:12 PM · Restricted Project
csigg updated the summary of D90191: [mlir] Fix TypeID lookup in GDB pretty printers..
Mon, Oct 26, 2:17 PM · Restricted Project
csigg requested review of D90191: [mlir] Fix TypeID lookup in GDB pretty printers..
Mon, Oct 26, 2:15 PM · Restricted Project
csigg updated the diff for D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..

Fail when synchronous version has async dependencies.

Mon, Oct 26, 4:29 AM · Restricted Project
csigg updated the diff for D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..

Error out on encountering pre-existing gpu.wait.

Mon, Oct 26, 2:53 AM · Restricted Project

Oct 23 2020

csigg added inline comments to D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..
Oct 23 2020, 12:36 PM · Restricted Project
csigg committed rGff87c4d3e773: [mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first… (authored by csigg).
[mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first…
Oct 23 2020, 2:10 AM
csigg closed D89981: [mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first iteration that didn't change the op..
Oct 23 2020, 2:10 AM · Restricted Project

Oct 22 2020

csigg updated the diff for D89324: [mlir][gpu] Allow gpu.launch_func to be async..

Rebase.

Oct 22 2020, 11:45 PM · Restricted Project
csigg updated the summary of D89981: [mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first iteration that didn't change the op..
Oct 22 2020, 11:37 PM · Restricted Project
csigg updated the diff for D89981: [mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first iteration that didn't change the op..

Keep 'changed' initialized.

Oct 22 2020, 11:29 PM · Restricted Project
csigg updated the diff for D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..

Use raw walk instead of a RewritePattern.

Oct 22 2020, 11:28 PM · Restricted Project
csigg added a reviewer for D89981: [mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first iteration that didn't change the op.: rriddle.
Oct 22 2020, 1:00 PM · Restricted Project
csigg requested review of D89981: [mlir] Fix exiting OpPatternRewriteDriver::simplifyLocally after first iteration that didn't change the op..
Oct 22 2020, 1:00 PM · Restricted Project
csigg added inline comments to D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..
Oct 22 2020, 10:50 AM · Restricted Project
csigg added inline comments to D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..
Oct 22 2020, 10:13 AM · Restricted Project
csigg updated the diff for D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..

Add a comment that token are expected to not be reused.

Oct 22 2020, 10:10 AM · Restricted Project
csigg added a comment to D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..
In D89933#2347104, @herhut wrote:

The lifetime management of streams is not correct, I think. Even with the assumption that "forks" are explicit, we might leak streams. For instance if we have

%t3 = gpu.wait aysnc [%t1, %t2] // last use of %t1 and %t2
...

the streams would never be freed. I wonder whether it would be easier to not deallocate streams at all when lowering and then have a fix-up pass that inserts the stream destruction where needed.

Oct 22 2020, 10:05 AM · Restricted Project
csigg committed rG9ab5362baba6: [mlir][gpu] NFC: switch occurrences of gpu.launch_func to custom format. (authored by csigg).
[mlir][gpu] NFC: switch occurrences of gpu.launch_func to custom format.
Oct 22 2020, 8:27 AM
csigg closed D89929: [mlir][gpu] NFC: switch occurrences of gpu.launch_func to custom format..
Oct 22 2020, 8:27 AM · Restricted Project
csigg requested review of D89937: [mlir][gpu] Add pass to make GPU ops within a region execute asynchronously..
Oct 22 2020, 1:05 AM · Restricted Project

Oct 21 2020

csigg added a reviewer for D89933: [mlir][gpu] Handle async in gpu.launch_func lowering.: ftynse.
Oct 21 2020, 11:42 PM · Restricted Project
csigg requested review of D89933: [mlir][gpu] Handle async in gpu.launch_func lowering..
Oct 21 2020, 11:40 PM · Restricted Project
csigg updated the diff for D89929: [mlir][gpu] NFC: switch occurrences of gpu.launch_func to custom format..

Rebase.

Oct 21 2020, 10:58 PM · Restricted Project
csigg updated the diff for D89324: [mlir][gpu] Allow gpu.launch_func to be async..

Splitting 'switch to custom gpu.launch_func format' into separate change.

Oct 21 2020, 10:52 PM · Restricted Project
csigg requested review of D89929: [mlir][gpu] NFC: switch occurrences of gpu.launch_func to custom format..
Oct 21 2020, 10:44 PM · Restricted Project