Page MenuHomePhabricator

csigg (Christian Sigg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 10:10 AM (13 w, 4 d)

Recent Activity

Sun, Feb 9

csigg added inline comments to D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Sun, Feb 9, 11:38 AM · Restricted Project

Fri, Feb 7

csigg updated the diff for D73609: Change to individual pretty printer classes, remove generic `make_printer`..

Rebase from master.

Fri, Feb 7, 5:18 AM · Restricted Project
csigg committed rG5a21d2bbb982: Rename prettyprinters test to llvm-support. (authored by csigg).
Rename prettyprinters test to llvm-support.
Fri, Feb 7, 5:10 AM
csigg closed D73726: Rename prettyprinters test to llvm-support..
Fri, Feb 7, 5:09 AM · Restricted Project

Tue, Feb 4

csigg added inline comments to D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Tue, Feb 4, 1:09 PM · Restricted Project

Mon, Feb 3

csigg added a comment to D73546: Add a few GDB pretty printers for MLIR..

@nicolasvasilache, it's currently blocked on D73609 and D73726. Then I will add tests and send it to @dblaikie for review.

Mon, Feb 3, 5:13 AM · Restricted Project
csigg retitled D73726: Rename prettyprinters test to llvm-support. from Rename llvm-prettyprinters to visualizer-tests. to Rename prettyprinters test to llvm-support..
Mon, Feb 3, 5:03 AM · Restricted Project
csigg updated the diff for D73726: Rename prettyprinters test to llvm-support..

Revert back to llvm-prettyprinters directory.

Mon, Feb 3, 5:03 AM · Restricted Project

Fri, Jan 31

csigg created D73794: [MLIR] Remove all-reduce lowering from GPU to NVVM. Use in-dialect lowering instead..
Fri, Jan 31, 10:45 AM · Restricted Project

Thu, Jan 30

csigg added a comment to D73726: Rename prettyprinters test to llvm-support..

Maybe I should just leave the directory as is and only rename the files?

Thu, Jan 30, 11:20 PM · Restricted Project
csigg created D73726: Rename prettyprinters test to llvm-support..
Thu, Jan 30, 10:30 AM · Restricted Project

Jan 30 2020

csigg updated the diff for D73609: Change to individual pretty printer classes, remove generic `make_printer`..

Rebase from master.

Jan 30 2020, 12:45 AM · Restricted Project
csigg committed rGa03ec58da60c: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm… (authored by csigg).
Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm…
Jan 30 2020, 12:36 AM
csigg closed D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Jan 30 2020, 12:36 AM · Restricted Project

Jan 29 2020

csigg created D73609: Change to individual pretty printer classes, remove generic `make_printer`..
Jan 29 2020, 1:01 AM · Restricted Project

Jan 28 2020

csigg added a comment to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Thanks for the details! I'd be /OK/ with this, but it doesn't seem ideal to be printing the next/prev when printing the container? Do you think it's worth/there's any nice way to avoid that significant redundancy/verbosity in the printing & just print the payload?

Jan 28 2020, 11:46 PM · Restricted Project
csigg added inline comments to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Jan 28 2020, 1:34 PM · Restricted Project
csigg updated the diff for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Add detailed CHECKs.

Jan 28 2020, 1:22 PM · Restricted Project
csigg updated the diff for D73546: Add a few GDB pretty printers for MLIR..

No change, but I updated the revision summary.

Jan 28 2020, 11:46 AM · Restricted Project
csigg updated the summary of D73546: Add a few GDB pretty printers for MLIR..
Jan 28 2020, 11:34 AM · Restricted Project
csigg added a comment to D73546: Add a few GDB pretty printers for MLIR..

GDB has a python API to customize how values are printed. See here for an introduction. The API documentation is here.

Jan 28 2020, 11:22 AM · Restricted Project
csigg created D73546: Add a few GDB pretty printers for MLIR..
Jan 28 2020, 5:54 AM · Restricted Project
csigg added inline comments to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Jan 28 2020, 12:24 AM · Restricted Project

Jan 27 2020

csigg updated the diff for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Switch from factory method to printer class.

Jan 27 2020, 11:38 PM · Restricted Project
csigg updated the diff for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Switch from factory method to printer class.

Jan 27 2020, 11:38 PM · Restricted Project
csigg added inline comments to D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Jan 27 2020, 12:04 PM · Restricted Project
csigg updated the diff for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Remove capture from lambda.

Jan 27 2020, 12:04 PM · Restricted Project
csigg updated the diff for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..

Reworking things and improving after PointerIntPair printer has landed.

Jan 27 2020, 11:54 AM · Restricted Project
csigg committed rG97431831e569: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion. (authored by csigg).
Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.
Jan 27 2020, 8:26 AM
csigg closed D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Jan 27 2020, 8:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg added inline comments to D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Jan 27 2020, 2:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Getting rid of for loop to handle optional return value.

Jan 27 2020, 2:00 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 20 2020

csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Revert merge accident.

Jan 20 2020, 10:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg added a comment to D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Hi David. Thanks a lot for you review. I did another pass to switch to factory methods that catch exceptions without spewing common errors on the GDB console. Would you mind taking another quick peek? Thanks a lot for your patience!

Jan 20 2020, 10:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Fix base. I'm so terrible at this.

Jan 20 2020, 10:07 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg abandoned D72590: NFC: Change PointerLikeTypeTraits::NumLowBitsAvailable from enum to static member. This allows GDB pretty printer to find the value..
Jan 20 2020, 9:58 AM · Restricted Project
csigg added a comment to D72590: NFC: Change PointerLikeTypeTraits::NumLowBitsAvailable from enum to static member. This allows GDB pretty printer to find the value..

Thanks a lot for your help. Sorry I've not been keeping up.

Jan 20 2020, 9:58 AM · Restricted Project
csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Use factory methods for printeres to catch exceptions.

Jan 20 2020, 8:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg committed rG8b2eb7c494b2: [mlir] Add in-dialect lowering of gpu.all_reduce. (authored by csigg).
[mlir] Add in-dialect lowering of gpu.all_reduce.
Jan 20 2020, 4:45 AM
csigg closed D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..
Jan 20 2020, 4:44 AM · Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

clang-format.

Jan 20 2020, 4:35 AM · Restricted Project

Jan 17 2020

csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Do not wrap temporaries in ValueRange.

Jan 17 2020, 12:09 PM · Restricted Project

Jan 15 2020

csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Remove debug hack.

Jan 15 2020, 8:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg added inline comments to D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Jan 15 2020, 8:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Switch from lookup_symbol of PtrTraits's 'NumBitsAvailable' to lookup_type of Info::MaskAndShiftConstants.
The latter is not (or less) part of the public interface of PointerIntPair, and requires less code changes.

Jan 15 2020, 8:21 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

clang-format

Jan 15 2020, 5:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg added inline comments to D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Jan 15 2020, 5:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 14 2020

csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Applying dblaikie's review comments.

Jan 14 2020, 2:46 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg added a comment to D72590: NFC: Change PointerLikeTypeTraits::NumLowBitsAvailable from enum to static member. This allows GDB pretty printer to find the value..

I was not able to get to NumLowBitsAvailable through Python GDB if it's an enumeration inside an anonymous struct.

Jan 14 2020, 2:45 PM · Restricted Project
csigg added inline comments to D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Jan 14 2020, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Apply clang-format.

Jan 14 2020, 8:40 AM · Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Fix build error after Value* -> Value change.

Jan 14 2020, 8:40 AM · Restricted Project
csigg added a reviewer for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce.: herhut.
Jan 14 2020, 12:46 AM · Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Rebase.

Jan 14 2020, 12:45 AM · Restricted Project
csigg added a reviewer for D72590: NFC: Change PointerLikeTypeTraits::NumLowBitsAvailable from enum to static member. This allows GDB pretty printer to find the value.: dblaikie.
Jan 14 2020, 12:45 AM · Restricted Project
csigg added a reviewer for D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node.: dblaikie.
Jan 14 2020, 12:45 AM · Restricted Project
csigg added a reviewer for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion.: dblaikie.
Jan 14 2020, 12:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 13 2020

csigg created D72590: NFC: Change PointerLikeTypeTraits::NumLowBitsAvailable from enum to static member. This allows GDB pretty printer to find the value..
Jan 13 2020, 12:34 AM · Restricted Project
csigg updated the diff for D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..

Fix formatting.

Jan 13 2020, 12:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg created D72589: Add GDB pretty printers for llvm::ilist, llvm::simple_ilist, and llvm::ilist_node..
Jan 13 2020, 12:25 AM · Restricted Project

Jan 11 2020

csigg created D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Jan 11 2020, 9:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
csigg committed rG60346bdbd73d: Add test for GDB pretty printers. (authored by csigg).
Add test for GDB pretty printers.
Jan 11 2020, 12:24 AM
csigg closed D72321: Add test for GDB pretty printers..
Jan 11 2020, 12:24 AM · Restricted Project
csigg added a comment to D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

What is the status re EDSC discussion?
Were the pointers I sent offline enough to give a good picture / do you see how to followup on this to use (and maybe extend) EDSCs?

Jan 11 2020, 12:24 AM · Restricted Project

Jan 10 2020

csigg updated the diff for D72321: Add test for GDB pretty printers..

Revert test_debuginfo.pl.

Jan 10 2020, 7:05 AM · Restricted Project
csigg updated the diff for D72321: Add test for GDB pretty printers..

Move to different directory, split file.

Jan 10 2020, 6:58 AM · Restricted Project
csigg added a comment to D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

The approach you took for building code is very similar to our motivation for declarative builders (aka EDSC), maybe it's time to reconsider those again.

Jan 10 2020, 5:36 AM · Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Address ftynse's review comments.

Jan 10 2020, 5:36 AM · Restricted Project

Jan 9 2020

csigg committed rG0f5f28d000f7: Add gdb pretty printer for MutableArrayRef, remove ConstArrayRef. (authored by csigg).
Add gdb pretty printer for MutableArrayRef, remove ConstArrayRef.
Jan 9 2020, 1:51 PM
csigg closed D72136: Add gdb pretty printer for MutableArrayRef, remove ConstArrayRef..
Jan 9 2020, 1:51 PM · Restricted Project

Jan 8 2020

csigg added a comment to D72321: Add test for GDB pretty printers..
  1. What do you think about putting this into an llvm subdirectory, to make clear that this is a test of llvm/utils rather than generic debug info as all the other tests?

Do you mean something like debuginfo-tests/llvm-prettyprinters/? Or 'llvm/tests/prettyprinter'?

Jan 8 2020, 11:48 PM · Restricted Project
csigg updated the diff for D72321: Add test for GDB pretty printers..

O0 > optnone

Jan 8 2020, 8:09 AM · Restricted Project

Jan 7 2020

csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Updating again, hopefully with all changes this time.

Jan 7 2020, 11:29 PM · Restricted Project
csigg added inline comments to D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..
Jan 7 2020, 5:13 AM · Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Addressing rriddle's review comments.

Jan 7 2020, 5:04 AM · Restricted Project
csigg updated the diff for D72321: Add test for GDB pretty printers..

Fix variable name casing.

Jan 7 2020, 2:27 AM · Restricted Project
csigg added inline comments to D72321: Add test for GDB pretty printers..
Jan 7 2020, 2:18 AM · Restricted Project
csigg created D72321: Add test for GDB pretty printers..
Jan 7 2020, 1:59 AM · Restricted Project

Jan 6 2020

csigg added a comment to D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Thanks a lot for the review, Alex!

Jan 6 2020, 11:45 AM · Restricted Project
csigg updated the diff for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..

Update reflecting review comments from ftynse.

Jan 6 2020, 11:45 AM · Restricted Project

Jan 3 2020

csigg added a reviewer for D72136: Add gdb pretty printer for MutableArrayRef, remove ConstArrayRef.: dblaikie.
Jan 3 2020, 3:18 AM · Restricted Project
csigg created D72136: Add gdb pretty printer for MutableArrayRef, remove ConstArrayRef..
Jan 3 2020, 3:14 AM · Restricted Project
csigg added a reviewer for D72129: [mlir] Add in-dialect lowering of gpu.all_reduce.: ftynse.
Jan 3 2020, 1:03 AM · Restricted Project
csigg created D72129: [mlir] Add in-dialect lowering of gpu.all_reduce..
Jan 3 2020, 12:54 AM · Restricted Project

Dec 31 2019

csigg created D72030: Add in-dialect lowering of gpu.all_reduce..
Dec 31 2019, 12:16 AM · Restricted Project
csigg abandoned D72030: Add in-dialect lowering of gpu.all_reduce..
Dec 31 2019, 12:16 AM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG42d46b4efa9d: Add gpu.shuffle op. (authored by csigg).
Add gpu.shuffle op.
Dec 23 2019, 9:27 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG8846557672d6: Fix maskAndClamp in gpu.all_reduce. (authored by csigg).
Fix maskAndClamp in gpu.all_reduce.
Dec 23 2019, 9:23 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG9b855826824d: Automated rollback of commit f68ac464d818629e0fe10c23b44ac782d64a12d2 (authored by csigg).
Automated rollback of commit f68ac464d818629e0fe10c23b44ac782d64a12d2
Dec 23 2019, 9:23 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf68ac464d818: Switch from shfl.bfly to shfl.down. (authored by csigg).
Switch from shfl.bfly to shfl.down.
Dec 23 2019, 9:23 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGc5fb4c130383: NFC: Fix naming inconsistency: FuncOpLowering -> GPUFuncOpLowering. (authored by csigg).
NFC: Fix naming inconsistency: FuncOpLowering -> GPUFuncOpLowering.
Dec 23 2019, 9:22 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGd60133f89bb0: Changing directory shortcut for CPU/GPU runner utils. (authored by csigg).
Changing directory shortcut for CPU/GPU runner utils.
Dec 23 2019, 9:17 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGd7c17195a439: Change CUDA tests to use print_memref. (authored by csigg).
Change CUDA tests to use print_memref.
Dec 23 2019, 9:16 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGf868adafee91: Make type and rank explicit in mcuMemHostRegister function. (authored by csigg).
Make type and rank explicit in mcuMemHostRegister function.
Dec 23 2019, 9:15 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGe38fe4a7af03: Print reason why dynamic library could not be loaded during execution. (authored by csigg).
Print reason why dynamic library could not be loaded during execution.
Dec 23 2019, 9:11 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGb74af4aa5c31: Unify GPU op definition names with other dialects. (authored by csigg).
Unify GPU op definition names with other dialects.
Dec 23 2019, 9:10 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGc3e56cd12cf6: Get active source lane predicate from shuffle instruction. (authored by csigg).
Get active source lane predicate from shuffle instruction.
Dec 23 2019, 9:10 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGfe0ee32da537: Add gpu.barrier op to synchronize invocations of a local workgroup. (authored by csigg).
Add gpu.barrier op to synchronize invocations of a local workgroup.
Dec 23 2019, 9:09 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rGd2f0f847af31: Support custom accumulator provided as region to gpu.all_reduce. (authored by csigg).
Support custom accumulator provided as region to gpu.all_reduce.
Dec 23 2019, 9:09 PM
A. Unique TensorFlower <gardener@tensorflow.org> committed rG82dc6c449211: Mark GPU dialect as illegal when lowering to NVVM. (authored by csigg).
Mark GPU dialect as illegal when lowering to NVVM.
Dec 23 2019, 9:07 PM