Page MenuHomePhabricator

csigg (Christian Sigg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 10:10 AM (173 w, 4 h)

Recent Activity

Today

csigg accepted D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC..

Ok, but it would be good to add a comment that this might not work on Windows.

Mon, Mar 20, 2:02 AM · Restricted Project, Restricted Project
csigg added a comment to D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC..

It seems this would result in duplicate definitions of mlir::registerGpuSerializeToCubinPass() on Windows.

Mon, Mar 20, 1:46 AM · Restricted Project, Restricted Project

Fri, Mar 17

csigg accepted D146330: Separate SerializeToCubin from GPUTransforms..

Thanks Artem!

Fri, Mar 17, 2:00 PM · Restricted Project, Restricted Project

Feb 3 2023

csigg committed rGa7bf6831f955: [MLIR] NFC: fully scope use FastMathFlag. (authored by csigg).
[MLIR] NFC: fully scope use FastMathFlag.
Feb 3 2023, 2:48 AM · Restricted Project, Restricted Project

Feb 2 2023

csigg committed rG146f5d940dfe: [MLIR] NFC: fully scope use FastMathFlag. (authored by csigg).
[MLIR] NFC: fully scope use FastMathFlag.
Feb 2 2023, 9:27 AM · Restricted Project, Restricted Project

Jan 11 2023

Herald added a reviewer for D128867: [mlir] Delete ForwardDataFlowAnalysis: nicolasvasilache.

Could we fix the documentation to no longer refer to ForwardDataFlowAnalysis?

Jan 11 2023, 4:21 AM · Restricted Project, Restricted Project

Jan 5 2023

csigg committed rG2c3f82b77596: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite. (authored by bchetioui).
[NVPTX] Fix NVPTX lowering of frem when denominator is infinite.
Jan 5 2023, 12:28 AM · Restricted Project, Restricted Project
csigg closed D140846: [NVPTX] Fix NVPTX lowering of frem when denominator is infinite..
Jan 5 2023, 12:28 AM · Restricted Project, Restricted Project

Dec 29 2022

csigg committed rG947d529e4194: [mlir] NFC: work around gcc-aarch64 v8.3 compilation issue in… (authored by csigg).
[mlir] NFC: work around gcc-aarch64 v8.3 compilation issue in…
Dec 29 2022, 3:04 AM · Restricted Project, Restricted Project

Dec 28 2022

csigg committed rG25671db3d343: [mlir] NFC: work around gcc-aarch64 v8.3 compilation issue in… (authored by csigg).
[mlir] NFC: work around gcc-aarch64 v8.3 compilation issue in…
Dec 28 2022, 3:24 AM · Restricted Project, Restricted Project

Nov 30 2022

csigg committed rGbe065c41d83a: [mlir] Change scf::LoopNest to store 'results'. (authored by csigg).
[mlir] Change scf::LoopNest to store 'results'.
Nov 30 2022, 9:52 PM · Restricted Project, Restricted Project
csigg closed D136926: [mlir] Change scf::LoopNest to store 'results'..
Nov 30 2022, 9:51 PM · Restricted Project, Restricted Project

Nov 28 2022

csigg added a comment to D136926: [mlir] Change scf::LoopNest to store 'results'..

Thanks for reviewing and sorry for the delay. Just to be clear, although I think it's a minor improvement, I'm not attached to this change. If you prefer to keep things as is, I will just abandon it.

Nov 28 2022, 7:48 AM · Restricted Project, Restricted Project

Nov 21 2022

csigg committed rG7f37a779e9f8: [MLIR] Hide FailureOr::hasValue() (authored by csigg).
[MLIR] Hide FailureOr::hasValue()
Nov 21 2022, 9:36 AM · Restricted Project, Restricted Project
csigg closed D138400: [MLIR] Hide FailureOr::hasValue().
Nov 21 2022, 9:35 AM · Restricted Project, Restricted Project

Nov 20 2022

csigg requested review of D138400: [MLIR] Hide FailureOr::hasValue().
Nov 20 2022, 10:45 PM · Restricted Project, Restricted Project

Nov 15 2022

csigg added a comment to D136926: [mlir] Change scf::LoopNest to store 'results'..

This API is doing too much and splitting 3. out would be the much cleaner solution IMO.

Nov 15 2022, 5:24 AM · Restricted Project, Restricted Project
csigg updated the diff for D136926: [mlir] Change scf::LoopNest to store 'results'..

Clean up test TODO.

Nov 15 2022, 5:20 AM · Restricted Project, Restricted Project

Nov 14 2022

csigg committed rGe28cc9382e6a: [mlir][bazel] NFC: change MLIR_GPU_TO_CUBIN_PASS_ENABLE from `defines` to… (authored by csigg).
[mlir][bazel] NFC: change MLIR_GPU_TO_CUBIN_PASS_ENABLE from `defines` to…
Nov 14 2022, 3:24 AM · Restricted Project

Nov 10 2022

csigg added inline comments to D136926: [mlir] Change scf::LoopNest to store 'results'..
Nov 10 2022, 6:59 AM · Restricted Project, Restricted Project

Nov 7 2022

csigg added inline comments to D137424: [mlir][transform] Introduce `gpu.map_foreach`.
Nov 7 2022, 1:52 AM · Restricted Project, Restricted Project

Nov 4 2022

csigg added a comment to D136926: [mlir] Change scf::LoopNest to store 'results'..

Nicolas, could you take another look please?

Nov 4 2022, 2:57 AM · Restricted Project, Restricted Project

Oct 29 2022

csigg added a comment to D136496: [bazel] Make labels to third-party dependencies explicit.

Have you tried to simply use e.g. "//:WORKSPACE" (without Label, without @llvm-raw)?
I think this might work because those rules are provided by @llvm-raw (or whatever the repo is called).

Oct 29 2022, 1:31 AM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

csigg accepted D136496: [bazel] Make labels to third-party dependencies explicit.

This looks good to me.

Oct 28 2022, 12:34 PM · Restricted Project, Restricted Project, Restricted Project
csigg added inline comments to D136926: [mlir] Change scf::LoopNest to store 'results'..
Oct 28 2022, 5:05 AM · Restricted Project, Restricted Project
csigg retitled D136926: [mlir] Change scf::LoopNest to store 'results'. from [mlir] Fix empty scf::LoopNest. to [mlir] Change scf::LoopNest to store 'results'..
Oct 28 2022, 5:04 AM · Restricted Project, Restricted Project
csigg updated the diff for D136926: [mlir] Change scf::LoopNest to store 'results'..

Add 'results' member to LoopNest.

Oct 28 2022, 5:03 AM · Restricted Project, Restricted Project
csigg added inline comments to D136926: [mlir] Change scf::LoopNest to store 'results'..
Oct 28 2022, 2:15 AM · Restricted Project, Restricted Project
csigg committed rGb251b608b5fc: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls (authored by csigg).
[mlir][gpu] Unroll ops on vectors which map to intrinsic calls
Oct 28 2022, 1:34 AM · Restricted Project, Restricted Project
csigg closed D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.
Oct 28 2022, 1:33 AM · Restricted Project, Restricted Project
csigg updated the diff for D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.

Fix comment.

Oct 28 2022, 1:32 AM · Restricted Project, Restricted Project
csigg requested review of D136926: [mlir] Change scf::LoopNest to store 'results'..
Oct 28 2022, 1:31 AM · Restricted Project, Restricted Project

Oct 27 2022

csigg updated the diff for D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.

Switch from lambda to template function: uglier formatting, but no uncommon c++ pattern.

Oct 27 2022, 1:11 AM · Restricted Project, Restricted Project

Oct 21 2022

csigg added a comment to D136496: [bazel] Make labels to third-party dependencies explicit.

I think you can remove the surrounding Label() if the repo is explicitly stated in the target string.

Oct 21 2022, 2:26 PM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.

Rename to scalarizeVectorOp.

Oct 21 2022, 12:47 AM · Restricted Project, Restricted Project
csigg added a comment to D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.

Thanks Diego.

Oct 21 2022, 12:41 AM · Restricted Project, Restricted Project

Oct 20 2022

csigg updated the diff for D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.

Nothing.

Oct 20 2022, 6:05 AM · Restricted Project, Restricted Project
csigg requested review of D136345: [mlir][gpu] Unroll ops on vectors which map to intrinsic calls.
Oct 20 2022, 5:57 AM · Restricted Project, Restricted Project

Oct 4 2022

csigg added a comment to D132354: [MLIR][GPU] Detect bounds with `arith.minsi ` in loops-to-gpu.

@csigg, the code you've added here yields a warning:

Oct 4 2022, 11:59 AM · Restricted Project, Restricted Project
csigg committed rG63022c48101b: [mlir][gpu] Fix GCC -Wparenthesis warning (authored by csigg).
[mlir][gpu] Fix GCC -Wparenthesis warning
Oct 4 2022, 11:58 AM · Restricted Project, Restricted Project
csigg updated the diff for D135067: [lit] RUN commands without stdin..

Fix clang tests that relied on empty input or accidentally did not provide the input in the RUN directive.

Oct 4 2022, 11:28 AM · Restricted Project, Restricted Project, Restricted Project
csigg added a comment to D135067: [lit] RUN commands without stdin..

So what would such a tool see? Would it get an error trying to open stdin, or something else?

A tool reading from stdin would get stdin, not an error and not an empty string (which it did before this change).

Oct 4 2022, 2:39 AM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D135067: [lit] RUN commands without stdin..

Fix bazel config to actually test lit tests.

Oct 4 2022, 2:38 AM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D135067: [lit] RUN commands without stdin..

Add test, fix external shell mode.

Oct 4 2022, 1:19 AM · Restricted Project, Restricted Project, Restricted Project

Oct 3 2022

csigg added a comment to D131810: [mlir][shape] add outline-shape-computation pass.

FYI, I pushed 5faebb5 fix for Windows for the test added in this change.

Oct 3 2022, 6:50 AM · Restricted Project, Restricted Project
csigg committed rG5faebb562401: [mlir][shape] fix test added in 9f77909. (authored by csigg).
[mlir][shape] fix test added in 9f77909.
Oct 3 2022, 6:49 AM · Restricted Project, Restricted Project
csigg updated the summary of D135067: [lit] RUN commands without stdin..
Oct 3 2022, 2:24 AM · Restricted Project, Restricted Project, Restricted Project
csigg requested review of D135067: [lit] RUN commands without stdin..
Oct 3 2022, 2:12 AM · Restricted Project, Restricted Project, Restricted Project
csigg committed rG2ddbe56b34ab: [Bazel] fixes for 9f77909. (authored by csigg).
[Bazel] fixes for 9f77909.
Oct 3 2022, 12:12 AM · Restricted Project

Sep 28 2022

csigg committed rG720dd814ba87: [MLIR] Fix after 4b27825. (authored by csigg).
[MLIR] Fix after 4b27825.
Sep 28 2022, 1:17 AM · Restricted Project, Restricted Project
csigg added inline comments to D134762: [mlir][arith] Change dialect name from Arithmetic to Arith.
Sep 28 2022, 12:36 AM · Restricted Project, Restricted Project

Sep 27 2022

csigg committed rG0a14f7312617: [Bazel] NFC: Move ParseUtilities.h from 'hdrs' to 'srcs'. (authored by csigg).
[Bazel] NFC: Move ParseUtilities.h from 'hdrs' to 'srcs'.
Sep 27 2022, 11:30 PM · Restricted Project
csigg committed rG39bf517e01e2: [Bazel] Fix after 4b27825ba36d55779561c0a2c3c2f89f52d81303. (authored by csigg).
[Bazel] Fix after 4b27825ba36d55779561c0a2c3c2f89f52d81303.
Sep 27 2022, 11:19 PM · Restricted Project

Sep 26 2022

csigg committed rG7876469c77a6: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead. (authored by csigg).
[Bazel] Remove template_rule and use @bazel_skylib's expand_template instead.
Sep 26 2022, 6:30 AM · Restricted Project
csigg closed D134347: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead..
Sep 26 2022, 6:30 AM · Restricted Project, Restricted Project
csigg updated the diff for D134347: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead..

Rebase.

Sep 26 2022, 5:08 AM · Restricted Project, Restricted Project

Sep 21 2022

csigg added a comment to D134347: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead..

Note: pre-merge failures are unrelated, I expect this change can be landed as-is (but I will definitely rerun the pre-merge check once it's fixed).

Sep 21 2022, 8:10 AM · Restricted Project, Restricted Project
csigg added a reviewer for D134347: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead.: GMNGeoffrey.
Sep 21 2022, 8:09 AM · Restricted Project, Restricted Project
csigg updated the diff for D134347: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead..

Update clang/BUILD.bazel as well.

Sep 21 2022, 6:23 AM · Restricted Project, Restricted Project
csigg added inline comments to D134190: [mlir] Add map_nested_foreach_thread_to_gpu_blocks op to transform dialect.
Sep 21 2022, 6:16 AM · Restricted Project, Restricted Project
csigg requested review of D134347: [Bazel] Remove template_rule and use @bazel_skylib's expand_template instead..
Sep 21 2022, 3:24 AM · Restricted Project, Restricted Project

Sep 18 2022

csigg committed rG8c3ea28f1816: [MLIR] NFC: improve comment about MLIR_CMAKE_DIR. (authored by csigg).
[MLIR] NFC: improve comment about MLIR_CMAKE_DIR.
Sep 18 2022, 10:47 PM · Restricted Project, Restricted Project

Sep 17 2022

csigg committed rGa6e91040eaad: [Bazel] Allow lit_test() macro to be used from other repos. (authored by csigg).
[Bazel] Allow lit_test() macro to be used from other repos.
Sep 17 2022, 2:06 AM · Restricted Project

Sep 14 2022

csigg committed rG70ac46667613: [Bazel] Add lit tests to bazel builds. (authored by csigg).
[Bazel] Add lit tests to bazel builds.
Sep 14 2022, 10:50 PM · Restricted Project
csigg closed D133455: [Bazel] Add lit tests to bazel builds..
Sep 14 2022, 10:49 PM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D133455: [Bazel] Add lit tests to bazel builds..

Rebase.

Sep 14 2022, 10:42 PM · Restricted Project, Restricted Project, Restricted Project
csigg committed rG5cff32b9f0bc: [MLIR] Fix toy lit substitutions (authored by csigg).
[MLIR] Fix toy lit substitutions
Sep 14 2022, 6:59 AM · Restricted Project, Restricted Project
csigg closed D133842: [MLIR] Fix toy lit substitutions.
Sep 14 2022, 6:59 AM · Restricted Project, Restricted Project
csigg updated the summary of D133842: [MLIR] Fix toy lit substitutions.
Sep 14 2022, 6:58 AM · Restricted Project, Restricted Project
csigg updated the summary of D133842: [MLIR] Fix toy lit substitutions.
Sep 14 2022, 6:58 AM · Restricted Project, Restricted Project
csigg added a comment to D133842: [MLIR] Fix toy lit substitutions.

How are things working right now without this? Does it mean that these may not be useful actually?

Sep 14 2022, 6:54 AM · Restricted Project, Restricted Project
csigg updated the diff for D133842: [MLIR] Fix toy lit substitutions.

Add missing toyc-ch6/7.

Sep 14 2022, 3:58 AM · Restricted Project, Restricted Project
csigg retitled D133842: [MLIR] Fix toy lit substitutions from [MLIR] Remove unused lit substitutions to [MLIR] Fix toy lit substitutions.
Sep 14 2022, 3:56 AM · Restricted Project, Restricted Project
csigg updated the diff for D133842: [MLIR] Fix toy lit substitutions.

Changing this revision to only fix the toy substitutions.

Sep 14 2022, 3:55 AM · Restricted Project, Restricted Project
csigg requested review of D133842: [MLIR] Fix toy lit substitutions.
Sep 14 2022, 12:41 AM · Restricted Project, Restricted Project

Sep 13 2022

csigg updated the diff for D133455: [Bazel] Add lit tests to bazel builds..

Rebase.

Sep 13 2022, 11:51 AM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D118126: Correct instcombine of fcmp+select..

Restore diff.

Sep 13 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project
csigg committed rGd3081133549c: [Bazel] Bump bazel version to 5.0. (authored by csigg).
[Bazel] Bump bazel version to 5.0.
Sep 13 2022, 11:09 AM · Restricted Project
csigg closed D133750: [Bazel] Bump bazel version to 5.0..
Sep 13 2022, 11:09 AM · Restricted Project, Restricted Project
csigg added a comment to D133750: [Bazel] Bump bazel version to 5.0..

LG but I think it'd be better to rebase to get a passing pre-merge build.

Sep 13 2022, 10:30 AM · Restricted Project, Restricted Project
csigg updated the diff for D133750: [Bazel] Bump bazel version to 5.0..

Rebase.

Sep 13 2022, 10:28 AM · Restricted Project, Restricted Project
csigg committed rGc5197517305a: [MLIR] Remove unused lit test replacements. (authored by csigg).
[MLIR] Remove unused lit test replacements.
Sep 13 2022, 10:28 AM · Restricted Project, Restricted Project
csigg closed D133409: [MLIR] Remove unused lit test replacements..
Sep 13 2022, 10:27 AM · Restricted Project, Restricted Project
csigg added a comment to D118126: Correct instcombine of fcmp+select..

Something has gone wrong with the diff.

Sep 13 2022, 10:26 AM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D118126: Correct instcombine of fcmp+select..

Rebase.

Sep 13 2022, 8:20 AM · Restricted Project, Restricted Project, Restricted Project
csigg committed rG5c6d8a74e1b0: [MLIR] Only substitute `mlir-spirv-cpu-runner` tool if enabled (authored by csigg).
[MLIR] Only substitute `mlir-spirv-cpu-runner` tool if enabled
Sep 13 2022, 6:42 AM · Restricted Project, Restricted Project
csigg closed D133752: [MLIR] Only substitute `mlir-spirv-cpu-runner` tool if enabled.
Sep 13 2022, 6:42 AM · Restricted Project, Restricted Project
csigg added inline comments to D133752: [MLIR] Only substitute `mlir-spirv-cpu-runner` tool if enabled.
Sep 13 2022, 6:40 AM · Restricted Project, Restricted Project
csigg added inline comments to D133533: [mlir][gpu] Introduce `shared` flag to `gpu.alloc`.
Sep 13 2022, 1:43 AM · Restricted Project, Restricted Project
csigg added inline comments to D133533: [mlir][gpu] Introduce `shared` flag to `gpu.alloc`.
Sep 13 2022, 12:47 AM · Restricted Project, Restricted Project
csigg requested review of D133752: [MLIR] Only substitute `mlir-spirv-cpu-runner` tool if enabled.
Sep 13 2022, 12:33 AM · Restricted Project, Restricted Project
csigg requested review of D133750: [Bazel] Bump bazel version to 5.0..
Sep 13 2022, 12:04 AM · Restricted Project, Restricted Project

Sep 12 2022

csigg added a reviewer for D133409: [MLIR] Remove unused lit test replacements.: herhut.
Sep 12 2022, 11:50 PM · Restricted Project, Restricted Project
csigg updated the diff for D133409: [MLIR] Remove unused lit test replacements..

Rebase.

Sep 12 2022, 11:49 PM · Restricted Project, Restricted Project

Sep 10 2022

csigg updated the diff for D133455: [Bazel] Add lit tests to bazel builds..

Bump bazel version to 5.0.

Sep 10 2022, 11:56 PM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2022

csigg updated the diff for D133455: [Bazel] Add lit tests to bazel builds..

Rebase

Sep 8 2022, 6:08 AM · Restricted Project, Restricted Project, Restricted Project
csigg committed rG1dbcb79498d0: [lit] Test changes to make it work with bazel (authored by csigg).
[lit] Test changes to make it work with bazel
Sep 8 2022, 5:52 AM · Restricted Project, Restricted Project, Restricted Project
csigg closed D133416: [lit] Test changes to make it work with bazel.
Sep 8 2022, 5:52 AM · Restricted Project, Restricted Project, Restricted Project
csigg updated the diff for D133416: [lit] Test changes to make it work with bazel.

Rebase.

Sep 8 2022, 4:51 AM · Restricted Project, Restricted Project, Restricted Project
csigg added a reviewer for D133416: [lit] Test changes to make it work with bazel: bkramer.
Sep 8 2022, 2:35 AM · Restricted Project, Restricted Project, Restricted Project