Page MenuHomePhabricator

csigg (Christian Sigg)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2019, 10:10 AM (72 w, 16 h)

Recent Activity

Tue, Apr 6

csigg committed rGfcc57558783b: [mlir] Remove no-op array assignment in dictionaryAttrSort(). (authored by csigg).
[mlir] Remove no-op array assignment in dictionaryAttrSort().
Tue, Apr 6, 12:31 PM
csigg closed D99954: [mlir] Remove no-op array assignment in dictionaryAttrSort()..
Tue, Apr 6, 12:30 PM · Restricted Project
csigg requested review of D99954: [mlir] Remove no-op array assignment in dictionaryAttrSort()..
Tue, Apr 6, 6:46 AM · Restricted Project

Sat, Apr 3

csigg committed rG3bcb6a389ff4: Silence `-Wunused-private-field` warning on isIsolatedFromAbove. (authored by csigg).
Silence `-Wunused-private-field` warning on isIsolatedFromAbove.
Sat, Apr 3, 6:45 AM
csigg closed D99721: Silence `-Wunused-private-field` warning on isIsolatedFromAbove..
Sat, Apr 3, 6:45 AM · Restricted Project

Thu, Apr 1

csigg requested review of D99721: Silence `-Wunused-private-field` warning on isIsolatedFromAbove..
Thu, Apr 1, 5:56 AM · Restricted Project

Fri, Mar 26

csigg added inline comments to D90352: Introduce a Bazel build configuration.
Fri, Mar 26, 5:29 AM · Restricted Project

Tue, Mar 23

csigg committed rGddae61dfef48: [mlir] Remove deprecated methods from mlir::OpState (authored by csigg).
[mlir] Remove deprecated methods from mlir::OpState
Tue, Mar 23, 3:08 AM
csigg closed D99150: [mlir] Remove deprecated methods from mlir::OpState.
Tue, Mar 23, 3:08 AM · Restricted Project
csigg requested review of D99150: [mlir] Remove deprecated methods from mlir::OpState.
Tue, Mar 23, 12:33 AM · Restricted Project

Fri, Mar 19

csigg committed rGa5f9cda17333: [mlir] Rename gpu-to-llvm pass implementation file (authored by csigg).
[mlir] Rename gpu-to-llvm pass implementation file
Fri, Mar 19, 5:58 AM
csigg closed D98930: [mlir] Rename gpu-to-llvm pass implementation file.
Fri, Mar 19, 5:58 AM · Restricted Project
csigg requested review of D98930: [mlir] Rename gpu-to-llvm pass implementation file.
Fri, Mar 19, 2:16 AM · Restricted Project
csigg committed rG74ffe8dc590c: [mlir] Remove ConvertKernelFuncToBlob (authored by csigg).
[mlir] Remove ConvertKernelFuncToBlob
Fri, Mar 19, 1:34 AM
csigg closed D98928: [mlir] Remove ConvertKernelFuncToBlob.
Fri, Mar 19, 1:34 AM · Restricted Project
csigg requested review of D98928: [mlir] Remove ConvertKernelFuncToBlob.
Fri, Mar 19, 1:29 AM · Restricted Project
csigg committed rGa825fb2c0733: [mlir] Remove mlir-rocm-runner (authored by csigg).
[mlir] Remove mlir-rocm-runner
Fri, Mar 19, 12:24 AM
csigg closed D98447: [mlir] Remove mlir-rocm-runner.
Fri, Mar 19, 12:24 AM · Restricted Project

Wed, Mar 17

csigg added inline comments to D98447: [mlir] Remove mlir-rocm-runner.
Wed, Mar 17, 3:25 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Update error messages.

Wed, Mar 17, 3:18 AM · Restricted Project

Tue, Mar 16

csigg added a comment to D98447: [mlir] Remove mlir-rocm-runner.

Also, in our downstream work, we did a rebase recently and we found we have to disable multi-threading when we run MLIR passes.
To emit HSACO for AMD GPU platform, lld is used, and it seems lld itself doesn't seem to be thread-safe.

Tue, Mar 16, 3:10 AM · Restricted Project

Mar 13 2021

csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Another fix.

Mar 13 2021, 12:13 PM · Restricted Project
csigg added a comment to D98447: [mlir] Remove mlir-rocm-runner.

@csigg May I understand how you configure the build?

With this cmake command:

cmake -G Ninja ../llvm \
    -DLLVM_ENABLE_PROJECTS="mlir;lld" \
    -DLLVM_BUILD_EXAMPLES=ON \
    -DLLVM_TARGETS_TO_BUILD="X86;AMDGPU" \
    -DCMAKE_BUILD_TYPE=Release \
    -DLLVM_ENABLE_ASSERTIONS=ON \
    -DBUILD_SHARED_LIBS=ON \
    -DLLVM_BUILD_LLVM_DYLIB=ON \
    -DMLIR_ROCM_RUNNER_ENABLED=1
Mar 13 2021, 11:30 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Fix dependencies for libMLIR.so, fix tests.

Mar 13 2021, 11:24 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Simplify dependencies.

Mar 13 2021, 1:26 AM · Restricted Project

Mar 12 2021

csigg added a comment to D98447: [mlir] Remove mlir-rocm-runner.

@csigg May I understand the goal for this changeset is to merge everything under mlir-cpu-runner?

Mar 12 2021, 7:08 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Another fix.

Mar 12 2021, 7:02 AM · Restricted Project
csigg committed rG1ef544d4a94e: [mlir] Remove mlir-cuda-runner (authored by csigg).
[mlir] Remove mlir-cuda-runner
Mar 12 2021, 5:07 AM
csigg closed D98396: [mlir] Remove mlir-cuda-runner.
Mar 12 2021, 5:07 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Various fixes.

Mar 12 2021, 5:03 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Rebase.

Mar 12 2021, 12:17 AM · Restricted Project
csigg updated the summary of D98447: [mlir] Remove mlir-rocm-runner.
Mar 12 2021, 12:11 AM · Restricted Project
csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Do not depend on D98396.

Mar 12 2021, 12:10 AM · Restricted Project

Mar 11 2021

csigg updated the diff for D98447: [mlir] Remove mlir-rocm-runner.

Polish.

Mar 11 2021, 12:57 PM · Restricted Project
csigg added a reviewer for D98447: [mlir] Remove mlir-rocm-runner: whchung.
Mar 11 2021, 12:39 PM · Restricted Project
csigg requested review of D98447: [mlir] Remove mlir-rocm-runner.
Mar 11 2021, 12:36 PM · Restricted Project
csigg committed rGbafe418d12e9: [mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass (authored by csigg).
[mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass
Mar 11 2021, 1:42 AM
csigg closed D98360: [mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass.
Mar 11 2021, 1:42 AM · Restricted Project
csigg updated the diff for D98360: [mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass.

Rebase.

Mar 11 2021, 1:40 AM · Restricted Project
csigg committed rG2224221fb3fa: [mlir] Add NVVM to CUBIN conversion to mlir-opt (authored by csigg).
[mlir] Add NVVM to CUBIN conversion to mlir-opt
Mar 11 2021, 1:07 AM
csigg closed D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.
Mar 11 2021, 1:07 AM · Restricted Project
csigg updated the summary of D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.
Mar 11 2021, 1:06 AM · Restricted Project
csigg updated the diff for D98396: [mlir] Remove mlir-cuda-runner.

Rebase.

Mar 11 2021, 1:05 AM · Restricted Project
csigg updated the diff for D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.

Fix nit.

Mar 11 2021, 12:57 AM · Restricted Project

Mar 10 2021

csigg requested review of D98396: [mlir] Remove mlir-cuda-runner.
Mar 10 2021, 11:35 PM · Restricted Project
csigg retitled D98360: [mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass from [mlir] Change test-gpu-to-cubin to derive from SerializeToCubinPass to [mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass.
Mar 10 2021, 11:01 PM · Restricted Project
csigg committed rG6a291ed0f069: [mlir] Remove unnecessary copying of pass options (authored by csigg).
[mlir] Remove unnecessary copying of pass options
Mar 10 2021, 12:55 PM
csigg closed D98366: [mlir] Remove unnecessary copying of pass options.
Mar 10 2021, 12:55 PM · Restricted Project
csigg added a comment to D98366: [mlir] Remove unnecessary copying of pass options.

I'm wondering though, wouldn't it be cleaner to implement the copy c'tor for Pass::Option so that passes (like SerializeToBlobPass here) can use the default copy c'tor?

Mar 10 2021, 12:40 PM · Restricted Project
csigg requested review of D98366: [mlir] Remove unnecessary copying of pass options.
Mar 10 2021, 12:38 PM · Restricted Project
csigg added inline comments to D98279: [mlir] Add base class for GpuKernelToBlobPass.
Mar 10 2021, 12:25 PM · Restricted Project
csigg requested review of D98360: [mlir] Change test-gpu-to-cubin to derive from SerializeToBlobPass.
Mar 10 2021, 9:44 AM · Restricted Project
csigg added a comment to D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.

This change should be ready for review again.

Mar 10 2021, 6:43 AM · Restricted Project
csigg updated the diff for D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.

Rebase, cmake fixes.

Mar 10 2021, 6:37 AM · Restricted Project
csigg committed rG4d295cf5b54e: [mlir] Add base class for GpuKernelToBlobPass (authored by csigg).
[mlir] Add base class for GpuKernelToBlobPass
Mar 10 2021, 3:15 AM
csigg closed D98279: [mlir] Add base class for GpuKernelToBlobPass.
Mar 10 2021, 3:14 AM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Fix.

Mar 10 2021, 3:13 AM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Move LLVM dependencies.

Mar 10 2021, 1:35 AM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Reduce public #includes.

Mar 10 2021, 1:23 AM · Restricted Project
csigg updated the summary of D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.
Mar 10 2021, 1:03 AM · Restricted Project
csigg updated the diff for D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.

Use base class added in D98279.

Mar 10 2021, 1:01 AM · Restricted Project
csigg added inline comments to D98279: [mlir] Add base class for GpuKernelToBlobPass.
Mar 10 2021, 12:54 AM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Change isa string to reference.

Mar 10 2021, 12:52 AM · Restricted Project
csigg added inline comments to D98279: [mlir] Add base class for GpuKernelToBlobPass.
Mar 10 2021, 12:36 AM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Fix file comment.

Mar 10 2021, 12:36 AM · Restricted Project

Mar 9 2021

csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Remove accidental mlir-cuda-runner change.

Mar 9 2021, 11:02 PM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Add options for triple, chip, features.

Mar 9 2021, 10:58 PM · Restricted Project
csigg updated the diff for D98279: [mlir] Add base class for GpuKernelToBlobPass.

Rebase

Mar 9 2021, 12:11 PM · Restricted Project
csigg committed rG840ff84d33c7: [mlir] Default for gpu-binary-annotation option. (authored by csigg).
[mlir] Default for gpu-binary-annotation option.
Mar 9 2021, 12:02 PM
csigg closed D98168: [mlir] Default for gpu-binary-annotation option..
Mar 9 2021, 12:01 PM · Restricted Project
csigg requested review of D98279: [mlir] Add base class for GpuKernelToBlobPass.
Mar 9 2021, 11:47 AM · Restricted Project
csigg planned changes to D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.
Mar 9 2021, 11:40 AM · Restricted Project
csigg added a comment to D98168: [mlir] Default for gpu-binary-annotation option..

Remove triple, target and feature options.

Could you include this in the commit summary please?

Mar 9 2021, 11:22 AM · Restricted Project
csigg updated the diff for D98168: [mlir] Default for gpu-binary-annotation option..

Address reviewer comments.

Mar 9 2021, 11:19 AM · Restricted Project
csigg retitled D98168: [mlir] Default for gpu-binary-annotation option. from [mlir] Add options to GPUKernelToBlobPass. to [mlir] Default for gpu-binary-annotation option..
Mar 9 2021, 11:14 AM · Restricted Project
csigg updated the diff for D98168: [mlir] Default for gpu-binary-annotation option..

Fix.

Mar 9 2021, 7:06 AM · Restricted Project
csigg updated the diff for D98168: [mlir] Default for gpu-binary-annotation option..

Remove triple, target and feature options.

Mar 9 2021, 7:01 AM · Restricted Project

Mar 8 2021

csigg added inline comments to D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.
Mar 8 2021, 11:55 AM · Restricted Project
csigg requested review of D98203: [mlir] Add NVVM to CUBIN conversion to mlir-opt.
Mar 8 2021, 11:26 AM · Restricted Project
csigg committed rG7cdcb4a3b980: [mlir] NFC: Add #endif comment. (authored by csigg).
[mlir] NFC: Add #endif comment.
Mar 8 2021, 10:25 AM
csigg updated the diff for D98168: [mlir] Default for gpu-binary-annotation option..

Move option to GpuToLLVMConversionPass (from Base) to remove the duplicate forward declaration of getDefaultGpuBinaryAnnotation().

Mar 8 2021, 4:44 AM · Restricted Project
csigg requested review of D98168: [mlir] Default for gpu-binary-annotation option..
Mar 8 2021, 4:19 AM · Restricted Project

Mar 5 2021

csigg committed rG5fedf3074838: [mlir] Make cuInit() call thread-safe. (authored by csigg).
[mlir] Make cuInit() call thread-safe.
Mar 5 2021, 7:06 AM
csigg closed D98024: [mlir] Make cuInit() call thread-safe..
Mar 5 2021, 7:06 AM · Restricted Project
csigg updated the summary of D98024: [mlir] Make cuInit() call thread-safe..
Mar 5 2021, 2:30 AM · Restricted Project
csigg requested review of D98024: [mlir] Make cuInit() call thread-safe..
Mar 5 2021, 2:29 AM · Restricted Project

Mar 4 2021

csigg committed rGf69d5a7fc7e4: [mlir] Initialize CUDA context lazily. (authored by csigg).
[mlir] Initialize CUDA context lazily.
Mar 4 2021, 4:08 AM
csigg closed D97864: [mlir] Initialize CUDA context lazily..
Mar 4 2021, 4:08 AM · Restricted Project
csigg updated the diff for D97864: [mlir] Initialize CUDA context lazily..

Switch to context push/pop.

Mar 4 2021, 12:27 AM · Restricted Project
csigg added inline comments to D97864: [mlir] Initialize CUDA context lazily..
Mar 4 2021, 12:20 AM · Restricted Project
csigg updated the diff for D97864: [mlir] Initialize CUDA context lazily..

Simplify.

Mar 4 2021, 12:20 AM · Restricted Project

Mar 3 2021

csigg requested review of D97864: [mlir] Initialize CUDA context lazily..
Mar 3 2021, 8:35 AM · Restricted Project
csigg committed rGb6ac26fce597: [mlir] Silence -Wglobal-constructors error in CudaRuntimeWrapper.cpp (authored by csigg).
[mlir] Silence -Wglobal-constructors error in CudaRuntimeWrapper.cpp
Mar 3 2021, 4:49 AM
csigg committed rG9d7be77bf91e: [mlir] Move cuda tests (authored by csigg).
[mlir] Move cuda tests
Mar 3 2021, 4:17 AM
csigg closed D97463: [mlir] Move cuda tests.
Mar 3 2021, 4:17 AM · Restricted Project
csigg updated the diff for D97463: [mlir] Move cuda tests.

Needs C++14, not C++11.

Mar 3 2021, 2:25 AM · Restricted Project
csigg updated the diff for D97463: [mlir] Move cuda tests.

Fix clang-tidy, hopefully.

Mar 3 2021, 1:41 AM · Restricted Project
csigg updated the diff for D97463: [mlir] Move cuda tests.

Rebase.

Mar 3 2021, 12:43 AM · Restricted Project

Mar 2 2021

csigg closed D97492: Enable mlir integration tests on the mlir-nvidia bot..
Mar 2 2021, 2:54 PM
csigg committed rZORGd1c8a51b6392: Enable mlir integration tests on the mlir-nvidia bot. (authored by csigg).
Enable mlir integration tests on the mlir-nvidia bot.
Mar 2 2021, 2:54 PM