Page MenuHomePhabricator

rdzhabarov (Roman Dzhabarov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 2 2020, 10:29 AM (86 w, 1 d)

Recent Activity

Tue, May 3

rdzhabarov accepted D124883: [mlir][sparse] fix build issue with unused local under opt builds.
Tue, May 3, 2:52 PM · Restricted Project, Restricted Project

Apr 15 2022

rdzhabarov committed rG3ef4099a6110: [mlir] Fix BUILD issues and dependencies. (authored by rdzhabarov).
[mlir] Fix BUILD issues and dependencies.
Apr 15 2022, 12:07 PM · Restricted Project, Restricted Project
rdzhabarov closed D123868: [mlir] Fix BUILD issues and dependencies for EnumAttr..
Apr 15 2022, 12:07 PM · Restricted Project, Restricted Project
rdzhabarov updated the diff for D123868: [mlir] Fix BUILD issues and dependencies for EnumAttr..

Sort

Apr 15 2022, 12:02 PM · Restricted Project, Restricted Project
rdzhabarov requested review of D123868: [mlir] Fix BUILD issues and dependencies for EnumAttr..
Apr 15 2022, 11:57 AM · Restricted Project, Restricted Project

Apr 11 2022

rdzhabarov committed rG64d3e163d8e3: Fix BUILD dependency for ExecutionEngineUtils (authored by rdzhabarov).
Fix BUILD dependency for ExecutionEngineUtils
Apr 11 2022, 9:50 PM · Restricted Project
rdzhabarov closed D123570: Fix BUILD dependency for ExecutionEngineUtils.
Apr 11 2022, 9:50 PM · Restricted Project, Restricted Project
rdzhabarov requested review of D123570: Fix BUILD dependency for ExecutionEngineUtils.
Apr 11 2022, 9:48 PM · Restricted Project, Restricted Project
rdzhabarov committed rGe4c4d0d29899: Fixing BUILD dependency on the DialectBase. (authored by rdzhabarov).
Fixing BUILD dependency on the DialectBase.
Apr 11 2022, 6:24 PM · Restricted Project
rdzhabarov closed D123558: Fixing BUILD dependency on the DialectBase..
Apr 11 2022, 6:23 PM · Restricted Project, Restricted Project
rdzhabarov requested review of D123558: Fixing BUILD dependency on the DialectBase..
Apr 11 2022, 5:29 PM · Restricted Project, Restricted Project

Mar 8 2022

rdzhabarov accepted D121178: [mlir] Check nullity of MixedContainerType and TypedArrayAttrBase.
Mar 8 2022, 9:44 AM · Restricted Project, Restricted Project

Mar 1 2022

rdzhabarov committed rG2e32525d95bd: [mlir] Fix unused var warning in the IR/MemRefOps.cpp (authored by rdzhabarov).
[mlir] Fix unused var warning in the IR/MemRefOps.cpp
Mar 1 2022, 11:54 AM
rdzhabarov closed D120759: [mlir] Fix unused var warning in the IR/MemRefOps.cpp.
Mar 1 2022, 11:54 AM · Restricted Project, Restricted Project
rdzhabarov requested review of D120759: [mlir] Fix unused var warning in the IR/MemRefOps.cpp.
Mar 1 2022, 11:46 AM · Restricted Project, Restricted Project

Feb 24 2022

rdzhabarov added inline comments to D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..
Feb 24 2022, 3:44 PM · Restricted Project
rdzhabarov accepted D120514: [mlir-tblgen] Fix non-deterministic generating static verifier in DRR..
Feb 24 2022, 3:41 PM · Restricted Project

Jan 13 2022

rdzhabarov added inline comments to D117029: [mlir] Add ODS support for enum attributes with grouped bit cases.
Jan 13 2022, 3:29 PM · Restricted Project

Jan 12 2022

rdzhabarov accepted D117127: [mlir] Update BUILD rule for MathDialect..
Jan 12 2022, 10:09 AM · Restricted Project

Nov 19 2021

rdzhabarov committed rGd729f4c38fca: [mlir] Bug fix. Stream must outlive the pass manager. (authored by rdzhabarov).
[mlir] Bug fix. Stream must outlive the pass manager.
Nov 19 2021, 1:46 PM
rdzhabarov closed D114277: [mlir] Bug fix. Stream must outlive the pass manager..
Nov 19 2021, 1:46 PM · Restricted Project
rdzhabarov added reviewers for D114277: [mlir] Bug fix. Stream must outlive the pass manager.: Chia-hungDuan, mehdi_amini, jpienaar.
Nov 19 2021, 1:15 PM · Restricted Project
rdzhabarov requested review of D114277: [mlir] Bug fix. Stream must outlive the pass manager..
Nov 19 2021, 1:13 PM · Restricted Project

Nov 2 2021

rdzhabarov accepted D113052: [mlir][sparse] bazel correction after filename change.
Nov 2 2021, 2:07 PM · Restricted Project

Oct 25 2021

rdzhabarov added a comment to D112468: When generating C++ code, use C++ string escaping..

I also see similar method used here and there across the codebase. Might be good to expose this as a utility method and reuse.

Oct 25 2021, 10:32 AM · Restricted Project

Oct 6 2021

rdzhabarov committed rGfb3d83acaf1c: [mlir] Fix redundant return in the void method. (authored by rdzhabarov).
[mlir] Fix redundant return in the void method.
Oct 6 2021, 11:46 AM
rdzhabarov closed D111251: [mlir] Fix redundant return in the void method..
Oct 6 2021, 11:45 AM · Restricted Project
rdzhabarov requested review of D111251: [mlir] Fix redundant return in the void method..
Oct 6 2021, 11:27 AM · Restricted Project

Aug 4 2021

rdzhabarov added a comment to D107287: [MLIR][NFC] Get DiagnosticEngine as a reference in doc.

release 13 I mean (since this is just a doc update), and it is "Alfsonso Gregory <gfunni234@gmail.com>" @rdzhabarov

Aug 4 2021, 12:03 PM · Restricted Project
rdzhabarov committed rGfb27e8c76e04: [MLIR][NFC] Get DiagnosticEngine as a reference in doc (authored by gAlfonso-bit).
[MLIR][NFC] Get DiagnosticEngine as a reference in doc
Aug 4 2021, 12:02 PM
rdzhabarov closed D107287: [MLIR][NFC] Get DiagnosticEngine as a reference in doc.
Aug 4 2021, 12:01 PM · Restricted Project
rdzhabarov added a comment to D107287: [MLIR][NFC] Get DiagnosticEngine as a reference in doc.

Any updates? @rdzhabarov

Aug 4 2021, 11:38 AM · Restricted Project

Aug 2 2021

rdzhabarov accepted D107287: [MLIR][NFC] Get DiagnosticEngine as a reference in doc.

Nit:

[MLIR] get DiagnosticEngine as a reference

Aug 2 2021, 10:10 AM · Restricted Project
rdzhabarov accepted D107288: [mlir] std.call reference function return types in failure.
Aug 2 2021, 10:03 AM · Restricted Project

Jul 21 2021

rdzhabarov committed rG1dd37975b56e: [mlir] Fix various issues in TimerImpl. (authored by rdzhabarov).
[mlir] Fix various issues in TimerImpl.
Jul 21 2021, 8:45 PM
rdzhabarov closed D106513: [mlir] Fix various issues in TimerImpl..
Jul 21 2021, 8:45 PM · Restricted Project
rdzhabarov updated the summary of D106513: [mlir] Fix various issues in TimerImpl..
Jul 21 2021, 5:21 PM · Restricted Project
rdzhabarov added reviewers for D106513: [mlir] Fix various issues in TimerImpl.: jpienaar, mehdi_amini.
Jul 21 2021, 5:21 PM · Restricted Project
rdzhabarov requested review of D106513: [mlir] Fix various issues in TimerImpl..
Jul 21 2021, 5:19 PM · Restricted Project

Jul 19 2021

rdzhabarov added inline comments to D105677: [mlir-tblgen] Fix failed matching when binds same operand of an op in different depth.
Jul 19 2021, 12:03 PM · Restricted Project

Jul 14 2021

rdzhabarov added inline comments to D105677: [mlir-tblgen] Fix failed matching when binds same operand of an op in different depth.
Jul 14 2021, 10:12 AM · Restricted Project

Jan 21 2021

rdzhabarov added a comment to D94868: [mlir] Enable passing crash reproducer stream factory method.

nice!

Jan 21 2021, 2:40 PM · Restricted Project, Restricted Project

Jan 20 2021

rdzhabarov added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Jan 20 2021, 9:24 AM · Restricted Project, Restricted Project

Jan 19 2021

rdzhabarov added inline comments to D94868: [mlir] Enable passing crash reproducer stream factory method.
Jan 19 2021, 12:07 PM · Restricted Project, Restricted Project

Nov 2 2020

rdzhabarov added inline comments to D90573: [mlir] Set random starting index.
Nov 2 2020, 10:44 AM · Restricted Project
rdzhabarov added inline comments to D90573: [mlir] Set random starting index.
Nov 2 2020, 9:34 AM · Restricted Project

Oct 27 2020

rdzhabarov added inline comments to D90266: [mlir] Optimize the parsing of ElementsAttr hex strings.
Oct 27 2020, 3:54 PM · Restricted Project
rdzhabarov accepted D90266: [mlir] Optimize the parsing of ElementsAttr hex strings.

Pretty cool improvement!

Oct 27 2020, 3:42 PM · Restricted Project

Oct 21 2020

rdzhabarov committed rG281e0f3636a3: [mlir] Simplify DDR matching patterns with equal operands for operators where… (authored by rdzhabarov).
[mlir] Simplify DDR matching patterns with equal operands for operators where…
Oct 21 2020, 2:32 PM
rdzhabarov closed D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..
Oct 21 2020, 2:32 PM · Restricted Project

Oct 19 2020

rdzhabarov updated the diff for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

comments.

Oct 19 2020, 9:51 PM · Restricted Project

Oct 16 2020

rdzhabarov updated the diff for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

fix wording.

Oct 16 2020, 5:12 PM · Restricted Project
rdzhabarov added a comment to D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

fixed.

Oct 16 2020, 5:02 PM · Restricted Project
rdzhabarov updated the diff for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

comments.

Oct 16 2020, 5:01 PM · Restricted Project
rdzhabarov added a comment to D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..

commented.

Oct 16 2020, 4:43 PM · Restricted Project
rdzhabarov added a reviewer for D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable.: jpienaar.
Oct 16 2020, 3:11 PM · Restricted Project
rdzhabarov requested review of D89598: [mlir] Simplify DDR matching patterns with equal operands for operators where it's applicable..
Oct 16 2020, 3:10 PM · Restricted Project

Oct 13 2020

rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

updating to latest.

Oct 13 2020, 10:01 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

fixing gcc5 issues.

Oct 13 2020, 9:46 PM · Restricted Project
rdzhabarov reopened D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

gcc5 was not happy with StringRef in the emplace call to a map<std::string, ...> , will be fixing it.

Oct 13 2020, 9:45 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

@mehdi_amini is there any way to run those tests prior merging?

Oct 13 2020, 9:08 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

to fix merge conflict.

Oct 13 2020, 3:56 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

added TODO.

Oct 13 2020, 3:32 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Thanks for quick review @jpienaar!

Oct 13 2020, 3:24 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

@jpienaar comments addressed

Oct 13 2020, 11:50 AM · Restricted Project

Oct 12 2020

rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

update.

Oct 12 2020, 6:01 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

comments

Oct 12 2020, 5:57 PM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Addressed comments.

Oct 12 2020, 5:57 PM · Restricted Project
rdzhabarov added a comment to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

Will update this Cl in a bit.

Oct 12 2020, 3:37 PM · Restricted Project
rdzhabarov added reviewers for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name.: jpienaar, rriddle.
Oct 12 2020, 11:28 AM · Restricted Project
rdzhabarov added inline comments to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 12 2020, 11:06 AM · Restricted Project
rdzhabarov updated the diff for D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..

fixing clang-tidy, revert leftovers from merge conflict.

Oct 12 2020, 11:01 AM · Restricted Project
rdzhabarov added inline comments to D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 12 2020, 10:51 AM · Restricted Project
rdzhabarov requested review of D89254: [DDR] Introduce implicit equality check for the source pattern operands with the same name..
Oct 12 2020, 10:36 AM · Restricted Project