Page MenuHomePhabricator

[mlir] Use mlir::OpState::operator->() to get to methods of mlir::Operation. This is a preparation step to remove the corresponding methods from OpState.
ClosedPublic

Authored by csigg on Dec 8 2020, 12:43 PM.

Diff Detail

Event Timeline

csigg created this revision.Dec 8 2020, 12:43 PM
csigg requested review of this revision.Dec 8 2020, 12:43 PM
silvas accepted this revision.Dec 8 2020, 12:45 PM
This revision is now accepted and ready to land.Dec 8 2020, 12:45 PM
rriddle accepted this revision.Dec 8 2020, 12:51 PM
rriddle added inline comments.
flang/include/flang/Optimizer/Dialect/FIROps.td
273

Why not (*this)-> instead for these?

csigg marked an inline comment as done.Dec 9 2020, 12:41 AM
csigg updated this revision to Diff 310443.Dec 9 2020, 12:42 AM

Change getOperation()-> to (*this)->.

csigg updated this revision to Diff 310444.Dec 9 2020, 12:43 AM

Rebase.

csigg updated this revision to Diff 310445.Dec 9 2020, 12:47 AM

Replace getOperation()-> with (*this)-> across FIROps.td.

Harbormaster completed remote builds in B81585: Diff 310444.
csigg updated this revision to Diff 310457.Dec 9 2020, 1:39 AM

Update op-attribute.td test.

csigg updated this revision to Diff 310474.Dec 9 2020, 2:50 AM

Fix clang-tidy error.

This revision was landed with ongoing or failed builds.Dec 9 2020, 3:11 AM
This revision was automatically updated to reflect the committed changes.