Page MenuHomePhabricator

[PowerPC] Remove QPX/A2Q BGQ/BGP CNK support
ClosedPublic

Authored by jsji on Wed, Jul 15, 3:16 PM.

Details

Summary

Per RFC http://lists.llvm.org/pipermail/llvm-dev/2020-April/141295.html
no one is making use of QPX/A2Q/BGQ/BGP CNK anymore.

This patch remove the support of QPX/A2Q in llvm, BGQ/BGP in clang,
CNK support in openmp/polly.

Diff Detail

Event Timeline

jsji created this revision.Wed, Jul 15, 3:16 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
jsji updated this revision to Diff 278363.Wed, Jul 15, 7:58 PM

Add triples to tests.

sstefan1 resigned from this revision.Thu, Jul 16, 12:01 AM

Should we indicate planned removal in the Release Notes for version 11 and actual removal in those for version 12?

jsji added a comment.Thu, Jul 16, 10:38 AM

Should we indicate planned removal in the Release Notes for version 11 and actual removal in those for version 12?

Good suggestion. https://reviews.llvm.org/D83968 for adding the section in master, will add conent in v11 branch if approved.

jsji removed a reviewer: sstefan1.
jsji added a comment.Fri, Jul 17, 9:02 AM

Should we indicate planned removal in the Release Notes for version 11 and actual removal in those for version 12?

Good suggestion. https://reviews.llvm.org/D83968 for adding the section in master, will add conent in v11 branch if approved.

Notes added to ReleaseNotes in release/11.x in https://reviews.llvm.org/rG297be788a797c0ab98d9677f50e3dc57faab363b

jdoerfert resigned from this revision.Fri, Jul 17, 9:11 AM
sstefan1 resigned from this revision.Sun, Jul 19, 1:10 PM
jsji added a comment.Thu, Jul 23, 6:51 AM

Ping ... Any other comments? Thanks.

Thanks for working on this. Please, however, take another pass of the test cases (especially those that are not in the PowerPC directory). Many of those should not be deleted, please change triple instead. They're testing general functionality.

llvm/test/Transforms/DeadStoreElimination/combined-partial-overwrites.ll
1

This test should not be deleted. Change the triple.

llvm/test/Transforms/EntryExitInstrumenter/mcount.ll
1

This test should not be deleted. It's testing general functionality. The triple should be changed.

openmp/runtime/src/kmp_platform.h
71

Was this not used anywhere? Or is there more to delete?

jsji updated this revision to Diff 280223.Thu, Jul 23, 12:29 PM

Thanks @hfinkel!

Updated testcases, and also remove CNK support from openmp/polly.

jsji updated this revision to Diff 280228.Thu, Jul 23, 12:44 PM

Add a few missing files.

jsji retitled this revision from [PowerPC] Remove QPX/A2Q BGQ/BGP support to [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.Thu, Jul 23, 12:47 PM
jsji edited the summary of this revision. (Show Details)
hfinkel accepted this revision as: hfinkel.Mon, Jul 27, 10:08 AM

LGTM. Thank you.

This revision is now accepted and ready to land.Mon, Jul 27, 10:08 AM
This revision was automatically updated to reflect the committed changes.