User Details
- User Since
- Feb 10 2015, 8:35 AM (380 w, 3 d)
Thu, May 19
Wed, May 18
LGTM
Thu, May 5
LGTM
LGTM
LGTM
Apr 13 2022
LGTM
Apr 12 2022
There are no existing documentation for these. Thanks for creating this!
Mar 31 2022
Mar 7 2022
LGTM
Mar 2 2022
LGTM
Few comments below, and just for clarification, is it correct that priority==0 means "use the regular per-thread deques" and are assumed to be lowest (and default) priority?
Feb 24 2022
Feb 14 2022
Forgot the Differential Revision: link in the commit message. This is closed by commit: https://github.com/llvm/llvm-project/commit/1234011b80f835a297482467ca6ca2099677c39c
Update to address Andrey's comments.
Feb 10 2022
Ah ok that works for me!
According to the pre-merge results: https://buildkite.com/llvm-project/premerge-checks/builds/76212#f61fe509-f800-4780-9571-cfe70624ba18, the test still depends on libomptarget even though it is run on the host. I think the test may have to go into the libomptarget/test directory. @jdoerfert could you advise on integrating the test?
Feb 9 2022
@hans , I've pushed commit 6be7c21b57e4a45b012209974ab9038b679134f5 to fix this.
Jan 31 2022
Jan 4 2022
LGTM
Dec 20 2021
Dec 15 2021
Dec 13 2021
Dec 10 2021
Dec 9 2021
LGTM
Dec 1 2021
Nov 30 2021
Nov 19 2021
Fix a few typos
Nov 17 2021
Nov 11 2021
Nov 9 2021
LGTM
I only have one other suggestion. I think its fine to use uppercase_CMAKE_BUILD_TYPE since its defined everywhere. The DEBUG_BUILD (and friends) are useful as booleans for append_if() type macro/functions in CMake.
Nov 8 2021
Nov 1 2021
Oct 25 2021
https://reviews.llvm.org/D112458 addresses this instead.
LGTM
Oct 22 2021
Oct 21 2021
LGTM
Oct 19 2021
LGTM
Oct 18 2021
Oct 14 2021
Oct 13 2021
LGTM
Oct 12 2021
@jdoerfert , does it look OK now?
Oct 8 2021
Addressed patch comments
Oct 1 2021
Sep 27 2021
Sep 24 2021
Sep 20 2021
This patch is no longer relevant.