User Details
- User Since
- Feb 10 2015, 8:35 AM (424 w, 2 d)
Feb 17 2023
Feb 13 2023
LGTM
Feb 8 2023
LGTM
Can you comment on the removal of kmp_import.cpp? Is it not needed anymore because Microsoft is moving away from the vcomp interface? If it is indeed unnecessary, then shouldn't we just remove the file entirely?
Feb 7 2023
Feb 6 2023
Apologies for the breakage!
Feb 3 2023
Feb 2 2023
Some linkers error out with a wildcard in both the global and local section under a version symbol. Removed the local part.
Patch from D142152 was pushed.
LGTM
Jan 20 2023
LGTM
Jan 19 2023
openmp/runtime/src/kmp_affinity.cpp:1611 has to be guarded by version check as well.
Ok I've made https://reviews.llvm.org/D142152 which combines @ggouaillardet 's patch with the other needed guard around line 1611 as you noted.
Sorry! I just realized there's another patch that solves this problem by inserting the proper HWLOC version checks in the code mentioned here: https://reviews.llvm.org/D112270. I'd rather go with that approach since it allows older HWLOC versions.
Jan 18 2023
Jan 16 2023
LGTM
Jan 10 2023
LGTM
Dec 13 2022
LGTM
Dec 12 2022
LGTM
Dec 6 2022
Nov 28 2022
LGTM
Sounds good to me.
Nov 22 2022
Nov 17 2022
Thanks for the fixes! LGTM.
Nov 16 2022
A few suggestions
LGTM
Nov 15 2022
Nov 2 2022
Nov 1 2022
@mgorny , This patch should fix the issues you were seeing after https://reviews.llvm.org/D135113. Can you confirm?
Oct 28 2022
Oct 25 2022
ping. This is the third patch set in a series of three to introduce hidden helper affinity.
Oct 19 2022
LGTM
Oct 17 2022
Oct 13 2022
Just a few comments.
Oct 3 2022
Sep 8 2022
Aug 11 2022
My mistake here. Uploading diff with full context for the record.
Aug 10 2022
ping
Aug 3 2022
Addressing comments
Aug 2 2022
I've created https://reviews.llvm.org/D131000 to address you issue specifically. It's just the same patch as before. I will leave this one open for review.
@mgorny , I thought the fundamental issue, as noted by @Meinersbur, was the newly built (but not installed) clang's inability to find an accessible omp.h. You then use the newly built clang to standalone build OpenMP.
Aug 1 2022
Updated patch to copy headers to clang build directory so it can find omp.h and omp-tools.h before install phase.
LGTM