User Details
User Details
- User Since
- Feb 10 2015, 8:35 AM (166 w, 4 d)
Wed, Apr 18
Wed, Apr 18
[OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter
jlpeyton committed rOMP330282: Introduce GOMP_taskloop API.
Introduce GOMP_taskloop API
[OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter
Wed, Apr 18, 12:29 PM · Restricted Project
jlpeyton committed rL330282: Introduce GOMP_taskloop API.
Introduce GOMP_taskloop API
Wed, Apr 18, 12:27 PM · Restricted Project
Wed, Apr 11
Wed, Apr 11
Wed, Apr 11, 10:14 AM · Restricted Project
Thu, Apr 5
Thu, Apr 5
Thu, Apr 5, 10:11 AM · Restricted Project
Fri, Mar 30
Fri, Mar 30
Minor cleanup in __kmp_atfork_child()
Minor cleanup in __kmp_atfork_child()
Fri, Mar 30, 12:58 PM · Restricted Project
Mon, Mar 26
Mon, Mar 26
Move blocktime_str variable right before its first use
Move blocktime_str variable right before its first use
Add summarizeStats.py to tools directory
Add summarizeStats.py to tools directory
Mon, Mar 26, 11:49 AM · Restricted Project
Mar 20 2018
Mar 20 2018
Read OMP_TARGET_OFFLOAD and provide API to access ICV
Read OMP_TARGET_OFFLOAD and provide API to access ICV
Feb 1 2018
Feb 1 2018
jlpeyton added a comment to D42795: make libomp work on amd64 x32 ABI.
I guess first and foremost, we need to make sure that we want KMP_ARCH_X86, KMP_ARCH_X86_64, and KMP_ARCH_X86_X32 to be mutually exclusive macros i.e., different architectures as far as CMake is concerned. If we want them to be mutually exclusive, then there is more work to be done including but not limited to:
Feb 1 2018, 1:23 PM · Restricted Project
Jan 10 2018
Jan 10 2018
Force HWLOC topology method for NUMA-specific topology
Force HWLOC topology method for NUMA-specific topology
jlpeyton accepted D40905: Force HWLOC topology method in case user requested NUMA-specific topology via granularity or KMP_HW_SUBSET.
LGTM
jlpeyton committed rL322204: Simplify __kmp_expand_threads.
Simplify __kmp_expand_threads
Simplify __kmp_expand_threads
Improve stability of the runtime in parent/child processes
Improve stability of the runtime in parent/child processes
Jan 10 2018, 10:23 AM · Restricted Project
Jan 8 2018
Jan 8 2018
Jan 8 2018, 2:16 PM · Restricted Project
Jan 4 2018
Jan 4 2018
Fix some comments and formatting in kmp_dispatch.cpp
Fix some comments and formatting in kmp_dispatch.cpp
Fix trademarks found by scanner
Fix trademarks found by scanner
Dec 6 2017
Dec 6 2017
[OpenMP] Add entry for Intel Compiler 18
[OpenMP] Add entry for Intel Compiler 18
Eliminate double printing of verbose affinity settings
Eliminate double printing of verbose affinity settings
jlpeyton closed D40624: Eliminate double printing of verbose affinity settings by committing rL319960: Eliminate double printing of verbose affinity settings.
Dec 6 2017, 1:08 PM · Restricted Project
Nov 29 2017
Nov 29 2017
Nov 29 2017, 2:56 PM · Restricted Project
Make kmp_r_sched_t into a union
Make kmp_r_sched_t into a union
jlpeyton closed D40374: Make kmp_r_sched_t into a union by committing rOMP319379: Make kmp_r_sched_t into a union.
jlpeyton closed D40374: Make kmp_r_sched_t into a union by committing rL319379: Make kmp_r_sched_t into a union.
Fix aligned memory allocation in the stub library
Fix aligned memory allocation in the stub library
Warning is emitted when tiles are requested but cannot be used
Warning is emitted when tiles are requested but cannot be used
Fix types of Fortran array elements
Fix types of Fortran array elements
jlpeyton closed D40356: Fix types of Fortran array elements by committing rL319372: Fix types of Fortran array elements.
Fix minor thing, then LGTM
Nov 28 2017
Nov 28 2017
Ok sounds good. LGTM.
jlpeyton added a comment to D40081: [CMake] Refactor common settings and flags.
I'm going to make one last plea for doing it correctly. Here is actual CMake code from LLVM's main CMakeLists.txt. It is reasonable to error-check what the user requests no matter how odd you may find it! The user may not know that something is only available on a certain platform until they request it. They do not wrap the option in operating system guards. Although some other options they do wrap in OS guards. Please just add the three line OS error check and the three line flag check.
option(LLVM_USE_INTEL_JITEVENTS "Use Intel JIT API to inform Intel(R) VTune(TM) Amplifier XE 2011 about JIT code" OFF)
jlpeyton added inline comments to D40081: [CMake] Refactor common settings and flags.
jlpeyton added inline comments to D40081: [CMake] Refactor common settings and flags.
jlpeyton added inline comments to D40080: [CMake] Disallow direct configuration.
jlpeyton added inline comments to D40080: [CMake] Disallow direct configuration.
Nov 15 2017
Nov 15 2017
LGTM
Nov 13 2017
Nov 13 2017
[OpenMP] Remove the unused testsuite/ directory
jlpeyton closed D39767: [OpenMP] Removing unused testsuite/ directory by committing rL318056: [OpenMP] Remove the unused testsuite/ directory.
Nov 13 2017, 9:45 AM · Restricted Project
Nov 7 2017
Nov 7 2017
Nov 7 2017, 3:39 PM · Restricted Project
Cleanup version symbol macros and attributes/declspecs
jlpeyton closed D39516: Cleanup version symbol macros and attributes/declspecs by committing rL317636: Cleanup version symbol macros and attributes/declspecs.
Nov 7 2017, 3:32 PM · Restricted Project
Nov 3 2017
Nov 3 2017
LGTM
Nov 1 2017
Nov 1 2017
Nov 1 2017, 3:40 PM · Restricted Project
[OpenMP] Fix race condition in omp_init_lock
jlpeyton closed D39439: [OpenMP]Fix race condition in omp_init_lock by committing rL317115: [OpenMP] Fix race condition in omp_init_lock.
Nov 1 2017, 12:45 PM · Restricted Project
Oct 25 2017
Oct 25 2017
Fix fatal error message displaying
jlpeyton closed D39248: Fix fatal error message displaying by committing rL316623: Fix fatal error message displaying.
Oct 25 2017, 3:05 PM · Restricted Project
jlpeyton added a comment to D38880: Detect whether the current system is a Linux system.
Also, if you take the features completely out, D38185 will need updating taking out the features in the REQUIRES: lines in the tests.
Oct 24 2017
Oct 24 2017
Oct 24 2017, 11:04 AM · Restricted Project
Disable threadprivate data cleanup if runtime is terminating
Oct 20 2017
Oct 20 2017
Restrict OMPT to OpenMP version 5.0 and remove old header files
Add license envirable for testing Intel compilers
jlpeyton committed rL316230: Add C++ support for testcases.
Add C++ support for testcases
jlpeyton closed D38878: Add C++ support for testcases by committing rL316230: Add C++ support for testcases.
jlpeyton closed D38837: Add explicit values to .clang-format by committing rL316227: Apply formatting changes.
Oct 17 2017
Oct 17 2017
jlpeyton added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
jlpeyton added a comment to D38837: Add explicit values to .clang-format.
The main question remaining is, to what files should we apply clang-format. You already pointed out that we should not format tests.
We also need to include kmp_itt.inl. So *.cpp *.h *.inl should do the trick.
jlpeyton added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
A few more comments