jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 8:35 AM (140 w, 1 d)

Recent Activity

Yesterday

jlpeyton added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Tue, Oct 17, 1:13 PM
jlpeyton added a comment to D38837: Add explicit values to .clang-format.

The main question remaining is, to what files should we apply clang-format. You already pointed out that we should not format tests.

We also need to include kmp_itt.inl. So *.cpp *.h *.inl should do the trick.

Tue, Oct 17, 10:17 AM
jlpeyton added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

A few more comments

Tue, Oct 17, 9:56 AM

Mon, Oct 16

jlpeyton added a comment to D38837: Add explicit values to .clang-format.

Ok, I've done some more research on this and here is what I've found and suggest as the solution:

Mon, Oct 16, 3:59 PM

Thu, Oct 12

jlpeyton added a comment to D38837: Add explicit values to .clang-format.

Ah ok, I see now. When we first created .clang-format some specific attributes were changed from the defaults and not properly added. So we just need to remove the DisableFormat line, change the DisableFormat line in the comments to false (as Joachim noted), and the rest can stay. The OMPT patch still needs to be run through clang-format in some manner since the DisableFormat line probably prevented any real formatting to occur. After those changes this one looks good to me.

Thu, Oct 12, 2:55 PM
jlpeyton added a comment to D38837: Add explicit values to .clang-format.

That is peculiar that the DisableFormat attribute is true for our defaults in comments. I don't know why that is.

Thu, Oct 12, 1:52 PM
jlpeyton added inline comments to D38837: Add explicit values to .clang-format.
Thu, Oct 12, 9:19 AM

Fri, Oct 6

jlpeyton committed rL315091: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.
KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix
Fri, Oct 6, 12:25 PM
jlpeyton closed D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix by committing rL315091: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.
Fri, Oct 6, 12:25 PM

Thu, Oct 5

jlpeyton updated the diff for D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.

Updated with Andrey's suggestion

Thu, Oct 5, 2:08 PM

Wed, Sep 27

jlpeyton committed rL314340: Remove unnecessary semicolons.
Remove unnecessary semicolons
Wed, Sep 27, 1:38 PM
jlpeyton added a reviewer for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1: hbae.

Initial scanning review, I'm adding Hansang as a reviewer since he has been looking at this code.

Wed, Sep 27, 11:07 AM

Tue, Sep 26

jlpeyton abandoned D22144: [lit] add support for unsetting environment variable.

D36403 committed this functionality (a74a4df4d5 or svn r311180) . This revision is not needed.

Tue, Sep 26, 4:20 PM
jlpeyton committed rL314243: Allow printing of KMP_TOPOLOGY_METHOD when KMP_SETTINGS=true.
Allow printing of KMP_TOPOLOGY_METHOD when KMP_SETTINGS=true
Tue, Sep 26, 3:35 PM
jlpeyton committed rL314242: Remove unused t_single_lock.
Remove unused t_single_lock
Tue, Sep 26, 3:35 PM
jlpeyton created D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.
Tue, Sep 26, 3:30 PM

Sep 5 2017

jlpeyton committed rL312539: Read blocktime value set by kmp_set_blocktime() before reading from….
Read blocktime value set by kmp_set_blocktime() before reading from…
Sep 5 2017, 8:49 AM
jlpeyton closed D37403: Read blocktime value set by kmp_set_blocktime() before reading from KMP_BLOCKTIME by committing rL312539: Read blocktime value set by kmp_set_blocktime() before reading from….
Sep 5 2017, 8:49 AM
jlpeyton accepted D37403: Read blocktime value set by kmp_set_blocktime() before reading from KMP_BLOCKTIME.

LGTM

Sep 5 2017, 8:45 AM
jlpeyton committed rL312538: Minor code cleanup of Klocwork issues.
Minor code cleanup of Klocwork issues
Sep 5 2017, 8:45 AM
jlpeyton closed D37275: Minor code cleanup of Klocwork issues by committing rL312538: Minor code cleanup of Klocwork issues.
Sep 5 2017, 8:45 AM
jlpeyton accepted D37275: Minor code cleanup of Klocwork issues.

LGTM

Sep 5 2017, 8:43 AM

Aug 19 2017

jlpeyton committed rL311269: Use va_copy instead of __va_copy to fix building libomp against musl libc.
Use va_copy instead of __va_copy to fix building libomp against musl libc
Aug 19 2017, 4:54 PM
jlpeyton closed D36343: Use va_copy instead of __va_copy to fix building libomp against musl libc by committing rL311269: Use va_copy instead of __va_copy to fix building libomp against musl libc.
Aug 19 2017, 4:54 PM

Aug 17 2017

jlpeyton committed rL311114: Remove BUILD_TV.
Remove BUILD_TV
Aug 17 2017, 12:12 PM
jlpeyton closed D36011: Remove BUILD_TV by committing rL311114: Remove BUILD_TV.
Aug 17 2017, 12:12 PM

Aug 11 2017

jlpeyton accepted D36403: [lit] add support for unsetting environment variables (again!).

LGTM

Aug 11 2017, 12:16 PM

Aug 10 2017

jlpeyton accepted D36510: OMP_PROC_BIND: better spread.

Looks good to me.

Aug 10 2017, 1:33 PM · Restricted Project

Aug 9 2017

jlpeyton added a comment to D36510: OMP_PROC_BIND: better spread.

Can you give a small example of how this would differ from the previous code?

Aug 9 2017, 10:25 AM · Restricted Project

Aug 7 2017

jlpeyton accepted D36343: Use va_copy instead of __va_copy to fix building libomp against musl libc.

All our sources are compiled as C++11 files and va_copy() is part of the C++11 standard. So this looks good to me.

Aug 7 2017, 2:26 PM

Aug 2 2017

jlpeyton committed rL309877: Exclude version symbols for static libomp.
Exclude version symbols for static libomp
Aug 2 2017, 1:10 PM
jlpeyton closed D36225: Exclude version symbols for static libomp by committing rL309877: Exclude version symbols for static libomp.
Aug 2 2017, 1:10 PM
jlpeyton accepted D36225: Exclude version symbols for static libomp.

LGTM

Aug 2 2017, 1:09 PM
jlpeyton committed rL309875: Move lock acquire/release functions in task deque cleanup code.
Move lock acquire/release functions in task deque cleanup code
Aug 2 2017, 1:07 PM
jlpeyton closed D36017: Move lock acquire/release functions to safer locations in task deque cleanup code by committing rL309875: Move lock acquire/release functions in task deque cleanup code.
Aug 2 2017, 1:07 PM
jlpeyton committed rL309874: Add new envirable KMP_TEAMS_THREAD_LIMIT.
Add new envirable KMP_TEAMS_THREAD_LIMIT
Aug 2 2017, 1:05 PM
jlpeyton closed D36009: Add new envirable KMP_TEAMS_THREAD_LIMIT by committing rL309874: Add new envirable KMP_TEAMS_THREAD_LIMIT.
Aug 2 2017, 1:05 PM

Jul 28 2017

jlpeyton committed rL309418: Fix comments and build messages concerning TSX.
Fix comments and build messages concerning TSX
Jul 28 2017, 12:06 PM

Jul 27 2017

jlpeyton committed rL309319: Fix implementation of OMP_THREAD_LIMIT.
Fix implementation of OMP_THREAD_LIMIT
Jul 27 2017, 1:59 PM
jlpeyton closed D35912: Fix implementation of OMP_THREAD_LIMIT by committing rL309319: Fix implementation of OMP_THREAD_LIMIT.
Jul 27 2017, 1:59 PM
jlpeyton accepted D35912: Fix implementation of OMP_THREAD_LIMIT.

LGTM

Jul 27 2017, 1:58 PM

Jul 26 2017

jlpeyton committed rL309168: Introduce KMP_DEVICE_THREAD_LIMIT.
Introduce KMP_DEVICE_THREAD_LIMIT
Jul 26 2017, 1:08 PM
jlpeyton closed D35860: Introduce KMP_DEVICE_THREAD_LIMIT by committing rL309168: Introduce KMP_DEVICE_THREAD_LIMIT.
Jul 26 2017, 1:08 PM

Jul 25 2017

jlpeyton committed rL309000: Cleanup: __kmp_env_* variables.
Cleanup: __kmp_env_* variables
Jul 25 2017, 11:21 AM
jlpeyton closed D35808: Cleanup: __kmp_env_* variables by committing rL309000: Cleanup: __kmp_env_* variables.
Jul 25 2017, 11:20 AM
jlpeyton accepted D35808: Cleanup: __kmp_env_* variables.

LGTM

Jul 25 2017, 11:20 AM

Jul 18 2017

jlpeyton committed rL308351: Fix failing taskloop tests by omitting gcc.
Fix failing taskloop tests by omitting gcc
Jul 18 2017, 1:17 PM
jlpeyton committed rL308338: Add recursive task scheduling strategy to taskloop implementation.
Add recursive task scheduling strategy to taskloop implementation
Jul 18 2017, 11:51 AM
jlpeyton closed D35273: Add recursive task scheduling strategy to taskloop implementation by committing rL308338: Add recursive task scheduling strategy to taskloop implementation.
Jul 18 2017, 11:50 AM

Jul 17 2017

jlpeyton accepted D35497: Cleanup: nullify pointer after memory freeing.

LGTM

Jul 17 2017, 11:57 AM · Restricted Project
jlpeyton committed rL308189: Removed "duplicates" from verbose affinity output.
Removed "duplicates" from verbose affinity output
Jul 17 2017, 10:07 AM
jlpeyton closed D35269: Removed "duplicates" from verbose affinity output by committing rL308189: Removed "duplicates" from verbose affinity output.
Jul 17 2017, 10:07 AM

Jul 14 2017

jlpeyton accepted D35417: Second part of -Wcast-qual option enabling for OpenMP RTL code.

LGTM

Jul 14 2017, 12:42 PM · Restricted Project

Jul 11 2017

jlpeyton created D35273: Add recursive task scheduling strategy to taskloop implementation.
Jul 11 2017, 1:38 PM
jlpeyton created D35269: Removed "duplicates" from verbose affinity output.
Jul 11 2017, 10:42 AM

Jul 5 2017

jlpeyton committed rL307206: Fix wrong website in messages.
Fix wrong website in messages
Jul 5 2017, 3:01 PM
jlpeyton closed D35018: Address wrong website bug by committing rL307206: Fix wrong website in messages.
Jul 5 2017, 3:01 PM
jlpeyton created D35018: Address wrong website bug.
Jul 5 2017, 10:01 AM

Jun 26 2017

jlpeyton added a comment to D34632: Check for libdl, and only use it when available.

CMake has a variable CMAKE_DL_LIBS which I believe contains the information you want. It essentially gets defined to "-ldl" on unices that need it and "" on platforms which don't need it.

Jun 26 2017, 10:48 AM

Jun 15 2017

jlpeyton committed rL305513: Set affinity to none/false in child processes.
Set affinity to none/false in child processes
Jun 15 2017, 2:51 PM
jlpeyton closed D34154: Set affinity to none/false in child processes by committing rL305513: Set affinity to none/false in child processes.
Jun 15 2017, 2:51 PM

Jun 13 2017

jlpeyton created D34154: Set affinity to none/false in child processes.
Jun 13 2017, 10:24 AM
jlpeyton committed rL305307: Replace platform macro with KMP_MIC_SUPPORTED.
Replace platform macro with KMP_MIC_SUPPORTED
Jun 13 2017, 10:18 AM
jlpeyton closed D34119: Replace platform macro with KMP_MIC_SUPPORTED by committing rL305307: Replace platform macro with KMP_MIC_SUPPORTED.
Jun 13 2017, 10:18 AM
jlpeyton committed rL305306: Reset initial affinity in children processes.
Reset initial affinity in children processes
Jun 13 2017, 10:16 AM
jlpeyton closed D34118: Reset initial affinity in children processes by committing rL305306: Reset initial affinity in children processes.
Jun 13 2017, 10:16 AM

Jun 12 2017

jlpeyton created D34119: Replace platform macro with KMP_MIC_SUPPORTED.
Jun 12 2017, 1:18 PM
jlpeyton created D34118: Reset initial affinity in children processes.
Jun 12 2017, 1:09 PM

Jun 6 2017

jlpeyton committed rL304828: Fix static initializers for locks..
Fix static initializers for locks.
Jun 6 2017, 1:25 PM
jlpeyton closed D33794: Fix static initializers for locks. by committing rL304828: Fix static initializers for locks..
Jun 6 2017, 1:25 PM

Jun 1 2017

jlpeyton accepted D31602: Added support for OpenMP 4.5 simd modifier of the schedule clause of the OpenMP loop construct.

LGTM

Jun 1 2017, 1:52 PM · Restricted Project
jlpeyton committed rL304438: Fix minor formatting issues.
Fix minor formatting issues
Jun 1 2017, 10:11 AM
jlpeyton closed D33744: Minor fixes: moved some code under debug, format improvements by committing rL304438: Fix minor formatting issues.
Jun 1 2017, 10:11 AM
jlpeyton accepted D33744: Minor fixes: moved some code under debug, format improvements .

LGTM

Jun 1 2017, 9:51 AM
jlpeyton updated subscribers of D33744: Minor fixes: moved some code under debug, format improvements .

Adding openmp-commits

Jun 1 2017, 9:40 AM

May 31 2017

jlpeyton committed rL304344: Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc.
Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc
May 31 2017, 1:35 PM
jlpeyton closed D33208: Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc by committing rL304344: Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc.
May 31 2017, 1:35 PM
jlpeyton committed rL304343: Address default pinning OpenMP process with multiple processor groups.
Address default pinning OpenMP process with multiple processor groups
May 31 2017, 1:34 PM
jlpeyton closed D33210: Address default pinning OpenMP process with multiple processor groups by committing rL304343: Address default pinning OpenMP process with multiple processor groups.
May 31 2017, 1:34 PM
jlpeyton added a comment to D33208: Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc.

Ping

May 31 2017, 12:25 PM
jlpeyton added a comment to D33210: Address default pinning OpenMP process with multiple processor groups.

Ping

May 31 2017, 12:25 PM

May 22 2017

jlpeyton accepted D31421: Re-enable assertion after the problem that caused it to be hit had been fixed..
May 22 2017, 11:32 AM

May 15 2017

jlpeyton created D33210: Address default pinning OpenMP process with multiple processor groups.
May 15 2017, 1:13 PM
jlpeyton committed rL303101: Fix for KMP_AFFINITY=respect with multiple processor groups.
Fix for KMP_AFFINITY=respect with multiple processor groups
May 15 2017, 12:19 PM
jlpeyton created D33208: Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc.
May 15 2017, 12:05 PM
jlpeyton accepted D32033: Make test/parallel/omp_nested.c not use so many threads.

LGTM

May 15 2017, 11:47 AM
jlpeyton abandoned D9534: Adding openmp project as a runtime project to projects/CMakeLists.txt.
May 15 2017, 11:47 AM
jlpeyton committed rL303086: Remove some outdated comments.
Remove some outdated comments
May 15 2017, 10:52 AM
jlpeyton committed rL303079: Add the .clang-format file which the formatting was based on.
Add the .clang-format file which the formatting was based on
May 15 2017, 9:53 AM

May 12 2017

jlpeyton committed rL302929: Clang-format and whitespace cleanup of source code.
Clang-format and whitespace cleanup of source code
May 12 2017, 11:15 AM
jlpeyton closed D32659: Clang-format and whitespace cleanup of source code by committing rL302929: Clang-format and whitespace cleanup of source code.
May 12 2017, 11:15 AM
jlpeyton accepted D32659: Clang-format and whitespace cleanup of source code.

LGTM. I think we can fix any further formatting problems as we go.

May 12 2017, 11:12 AM

Apr 25 2017

jlpeyton committed rL301349: Fix Hwloc API Incompatibility.
Fix Hwloc API Incompatibility
Apr 25 2017, 12:17 PM
jlpeyton closed D32496: Fix Hwloc API Incompatibility by committing rL301349: Fix Hwloc API Incompatibility.
Apr 25 2017, 12:17 PM
jlpeyton updated the diff for D32496: Fix Hwloc API Incompatibility.

Updated the diff. I had gotten errors when I tried that first, but now I realize that the SOCKET name is used in address2os map creation. I've changed all of them to HWLOC_OBJ_PACKAGE now and added the #ifndef method.

Apr 25 2017, 11:18 AM
jlpeyton created D32496: Fix Hwloc API Incompatibility.
Apr 25 2017, 10:24 AM

Apr 5 2017

jlpeyton accepted D31600: KMP_HW_SUBSET extended with NUMA support when HWLOC enabled.

LGTM

Apr 5 2017, 2:37 PM · Restricted Project
jlpeyton added inline comments to D31602: Added support for OpenMP 4.5 simd modifier of the schedule clause of the OpenMP loop construct.
Apr 5 2017, 2:28 PM · Restricted Project

Mar 31 2017

jlpeyton accepted D31466: [OpenMP] Fix for http://bugs.llvm.org/show_bug.cgi?id=32456.

LGTM

Mar 31 2017, 9:19 AM

Mar 30 2017

jlpeyton added inline comments to D31466: [OpenMP] Fix for http://bugs.llvm.org/show_bug.cgi?id=32456.
Mar 30 2017, 12:17 PM