Page MenuHomePhabricator
People jlpeyton

jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 8:35 AM (379 w, 4 d)

Recent Activity
View All

Thu, May 19

jlpeyton committed rGf613e6d19d29: [OpenMP][libomp] Fix accidental removal of else for core attributes (authored by jlpeyton).
[OpenMP][libomp] Fix accidental removal of else for core attributes
Thu, May 19, 12:00 PM · Restricted Project, Restricted Project
jlpeyton requested review of D126001: [OpenMP][libomp] Fix fallthrough attribute detection for Intel compilers.
Thu, May 19, 11:48 AM · Restricted Project, Restricted Project
jlpeyton requested review of D125996: [OpenMP][libomp] Fix /dev/shm pollution after forked child process terminates.
Thu, May 19, 11:31 AM · Restricted Project, Restricted Project
jlpeyton requested review of D125993: [OpenMP][libomp] Allow reset affinity mask after parallel.
Thu, May 19, 11:22 AM · Restricted Project, Restricted Project
jlpeyton requested review of D125991: [OpenMP][libomp] Fix affinity warnings and unify under one macro.
Thu, May 19, 11:18 AM · Restricted Project, Restricted Project

Wed, May 18

jlpeyton committed rGc44ba01de7f0: [OpenMP] libomp: honor passive wait policy requested with tasking (authored by AndreyChurbanov).
[OpenMP] libomp: honor passive wait policy requested with tasking
Wed, May 18, 8:08 AM · Restricted Project, Restricted Project
jlpeyton closed D123044: [OpenMP] libomp: honor passive wait policy requested in the presence of tasking.
Wed, May 18, 8:08 AM · Restricted Project, Restricted Project
jlpeyton accepted D123044: [OpenMP] libomp: honor passive wait policy requested in the presence of tasking.

LGTM

Wed, May 18, 8:06 AM · Restricted Project, Restricted Project

Thu, May 5

jlpeyton committed rG52d0ef3c00fc: [OpenMP] libomp: Add itt notifications to sync dependent tasks. (authored by AndreyChurbanov).
[OpenMP] libomp: Add itt notifications to sync dependent tasks.
Thu, May 5, 9:31 AM · Restricted Project, Restricted Project
jlpeyton closed D123042: [OpenMP] libomp: Add itt notifications to sync dependent tasks..
Thu, May 5, 9:31 AM · Restricted Project, Restricted Project
jlpeyton added a comment to D123042: [OpenMP] libomp: Add itt notifications to sync dependent tasks..

LGTM

Thu, May 5, 9:27 AM · Restricted Project, Restricted Project
jlpeyton committed rG4a64bed2160c: [OpenMP] libomp: cleanup - remove duplicate check (authored by AndreyChurbanov).
[OpenMP] libomp: cleanup - remove duplicate check
Thu, May 5, 9:02 AM · Restricted Project, Restricted Project
jlpeyton closed D123046: [OpenMP] libomp: cleanup - remove duplicate check.
Thu, May 5, 9:01 AM · Restricted Project, Restricted Project
jlpeyton accepted D123046: [OpenMP] libomp: cleanup - remove duplicate check.

LGTM

Thu, May 5, 8:59 AM · Restricted Project, Restricted Project
jlpeyton committed rGeed0d8515295: [OpenMP] libomp: cleanup dead code (authored by AndreyChurbanov).
[OpenMP] libomp: cleanup dead code
Thu, May 5, 8:58 AM · Restricted Project, Restricted Project
jlpeyton closed D123047: [OpenMP] libomp: cleanup dead code.
Thu, May 5, 8:57 AM · Restricted Project, Restricted Project
jlpeyton accepted D123047: [OpenMP] libomp: cleanup dead code.

LGTM

Thu, May 5, 8:57 AM · Restricted Project, Restricted Project
jlpeyton requested review of D125013: [OpenMP][libomp] Hold old __kmp_threads arrays until library shutdown.
Thu, May 5, 7:23 AM · Restricted Project, Restricted Project

Apr 13 2022

jlpeyton accepted D123564: [OpenMP][doc] Add documents for barrier related environment variables.

LGTM

Apr 13 2022, 10:50 AM · Restricted Project, Restricted Project

Apr 12 2022

jlpeyton committed rGd49ce7c35606: [OpenMP][libomp] Replace global variable references with local object (authored by jlpeyton).
[OpenMP][libomp] Replace global variable references with local object
Apr 12 2022, 10:51 AM · Restricted Project, Restricted Project
jlpeyton committed rG747a49061283: [OpenMP][libomp] Fix some Doxygen issues (authored by jlpeyton).
[OpenMP][libomp] Fix some Doxygen issues
Apr 12 2022, 9:09 AM · Restricted Project, Restricted Project
jlpeyton added a comment to D123564: [OpenMP][doc] Add documents for barrier related environment variables.

There are no existing documentation for these. Thanks for creating this!

Apr 12 2022, 8:54 AM · Restricted Project, Restricted Project

Mar 31 2022

jlpeyton committed rGd345fe7c221f: [OpenMP][libomp] NFC: Move omp_* functions out of kmp_* section (authored by jlpeyton).
[OpenMP][libomp] NFC: Move omp_* functions out of kmp_* section
Mar 31 2022, 11:41 AM · Restricted Project, Restricted Project

Mar 7 2022

jlpeyton committed rG6564a70415df: [OpenMP][libomp] Fix register constraint for tpause and umwait (authored by jlpeyton).
[OpenMP][libomp] Fix register constraint for tpause and umwait
Mar 7 2022, 12:56 PM · Restricted Project, Restricted Project
jlpeyton closed D120519: [OpenMP][libomp] Fix register constraint for tpause and umwait.
Mar 7 2022, 12:56 PM · Restricted Project, Restricted Project
jlpeyton accepted D119676: [OpenMP] libomp: implemented task priorities..

LGTM

Mar 7 2022, 8:21 AM · Restricted Project, Restricted Project

Mar 2 2022

jlpeyton accepted D120671: [OpenMP][libomp] omp_in_explicit_task() implementation..

LGTM

Mar 2 2022, 2:55 PM · Restricted Project, Restricted Project
jlpeyton added a comment to D119676: [OpenMP] libomp: implemented task priorities..

Few comments below, and just for clarification, is it correct that priority==0 means "use the regular per-thread deques" and are assumed to be lowest (and default) priority?

Mar 2 2022, 2:49 PM · Restricted Project, Restricted Project

Feb 24 2022

jlpeyton requested review of D120519: [OpenMP][libomp] Fix register constraint for tpause and umwait.
Feb 24 2022, 2:16 PM · Restricted Project, Restricted Project

Feb 14 2022

jlpeyton closed D118662: [OpenMP][libomp] Introduce oneAPI compiler support.

Forgot the Differential Revision: link in the commit message. This is closed by commit: https://github.com/llvm/llvm-project/commit/1234011b80f835a297482467ca6ca2099677c39c

Feb 14 2022, 12:14 PM · Restricted Project
jlpeyton committed rG1234011b80f8: [OpenMP][libomp] Introduce oneAPI compiler support (authored by jlpeyton).
[OpenMP][libomp] Introduce oneAPI compiler support
Feb 14 2022, 12:11 PM
jlpeyton updated the diff for D118662: [OpenMP][libomp] Introduce oneAPI compiler support.

Update to address Andrey's comments.

Feb 14 2022, 10:06 AM · Restricted Project

Feb 10 2022

jlpeyton accepted D118393: [OpenMP] host rtl: fixed bug in implementation of distribute construct..

Ah ok that works for me!

Feb 10 2022, 1:58 PM · Restricted Project
jlpeyton added a comment to D118393: [OpenMP] host rtl: fixed bug in implementation of distribute construct..

According to the pre-merge results: https://buildkite.com/llvm-project/premerge-checks/builds/76212#f61fe509-f800-4780-9571-cfe70624ba18, the test still depends on libomptarget even though it is run on the host. I think the test may have to go into the libomptarget/test directory. @jdoerfert could you advise on integrating the test?

Feb 10 2022, 11:23 AM · Restricted Project

Feb 9 2022

jlpeyton added a comment to D114901: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET.

@hans , I've pushed commit 6be7c21b57e4a45b012209974ab9038b679134f5 to fix this.

Feb 9 2022, 6:20 AM · Restricted Project
jlpeyton committed rG6be7c21b57e4: [OpenMP][libomp] Replace accidental VLA with KMP_ALLOCA (authored by jlpeyton).
[OpenMP][libomp] Replace accidental VLA with KMP_ALLOCA
Feb 9 2022, 6:10 AM

Jan 31 2022

jlpeyton requested review of D118662: [OpenMP][libomp] Introduce oneAPI compiler support.
Jan 31 2022, 3:26 PM · Restricted Project

Jan 4 2022

jlpeyton accepted D115758: [OpenMP][CPU runtime] Add use of TPAUSE to the runtime.

LGTM

Jan 4 2022, 7:20 AM · Restricted Project

Dec 20 2021

jlpeyton committed rG6a556ecaf4c3: [OpenMP][libomp] Add use-all syntax to KMP_HW_SUBSET (authored by jlpeyton).
[OpenMP][libomp] Add use-all syntax to KMP_HW_SUBSET
Dec 20 2021, 11:46 AM
jlpeyton closed D115826: [OpenMP][libomp] Add use-all syntax to KMP_HW_SUBSET.
Dec 20 2021, 11:46 AM · Restricted Project

Dec 15 2021

jlpeyton requested review of D115826: [OpenMP][libomp] Add use-all syntax to KMP_HW_SUBSET.
Dec 15 2021, 1:02 PM · Restricted Project

Dec 13 2021

jlpeyton added a comment to D114901: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET.
In D114901#3189707, @kaz7 wrote:

In addition, these lines also cause compiler errors.

Dec 13 2021, 12:20 PM · Restricted Project
jlpeyton requested review of D115664: [OpenMP][libomp] Fix compile errors with new KMP_HW_SUBSET changes.
Dec 13 2021, 12:19 PM · Restricted Project

Dec 10 2021

jlpeyton committed rGdf2059959707: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET (authored by jlpeyton).
[OpenMP][libomp] Add core attributes to KMP_HW_SUBSET
Dec 10 2021, 12:35 PM
jlpeyton closed D114901: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET.
Dec 10 2021, 12:35 PM · Restricted Project

Dec 9 2021

jlpeyton accepted D114537: [OpenMP] libomp: fix Fortran header: lines exceeded 72-char length.

LGTM

Dec 9 2021, 2:33 PM · Restricted Project

Dec 1 2021

jlpeyton requested review of D114901: [OpenMP][libomp] Add core attributes to KMP_HW_SUBSET.
Dec 1 2021, 12:28 PM · Restricted Project

Nov 30 2021

jlpeyton committed rG618f8dc5e5b5: [OpenMP][libomp][doc] Add environment variables documentation (authored by jlpeyton).
[OpenMP][libomp][doc] Add environment variables documentation
Nov 30 2021, 2:30 PM
jlpeyton closed D114269: [OpenMP][libomp][doc] Add environment variables documentation.
Nov 30 2021, 2:30 PM · Restricted Project

Nov 19 2021

jlpeyton updated the diff for D114269: [OpenMP][libomp][doc] Add environment variables documentation.

Fix a few typos

Nov 19 2021, 2:27 PM · Restricted Project
jlpeyton requested review of D114269: [OpenMP][libomp][doc] Add environment variables documentation.
Nov 19 2021, 11:42 AM · Restricted Project

Nov 17 2021

jlpeyton committed rGa733b18bdbe2: [OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds (authored by jlpeyton).
[OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds
Nov 17 2021, 2:30 PM
jlpeyton closed D112270: [OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds.
Nov 17 2021, 2:30 PM · Restricted Project
jlpeyton committed rG286094af9bc0: [OpenMP][libomp] Improve Windows Processor Group handling within topology (authored by jlpeyton).
[OpenMP][libomp] Improve Windows Processor Group handling within topology
Nov 17 2021, 2:30 PM
jlpeyton closed D112273: [OpenMP][libomp] Improve Windows Processor Group handling within topology.
Nov 17 2021, 2:29 PM · Restricted Project
jlpeyton committed rG1dd797168e9f: [OpenMP][libomp] Add support for offline CPUs in Linux (authored by jlpeyton).
[OpenMP][libomp] Add support for offline CPUs in Linux
Nov 17 2021, 2:28 PM
jlpeyton closed D112274: [OpenMP][libomp] Add support for offline CPUs in Linux.
Nov 17 2021, 2:28 PM · Restricted Project
jlpeyton committed rGa0afb9d0fc2b: [OpenMP][libomp] Allow users to specify KMP_HW_SUBSET in any order (authored by jlpeyton).
[OpenMP][libomp] Allow users to specify KMP_HW_SUBSET in any order
Nov 17 2021, 1:28 PM
jlpeyton closed D112027: [OpenMP][libomp] Allow users to specify KMP_HW_SUBSET in any order.
Nov 17 2021, 1:28 PM · Restricted Project
jlpeyton committed rGc46becf500df: [OpenMP][libomp][NFC] Remove non-ASCII apostrophe in comment (authored by jlpeyton).
[OpenMP][libomp][NFC] Remove non-ASCII apostrophe in comment
Nov 17 2021, 12:47 PM

Nov 11 2021

jlpeyton committed rG9f15cacc2ecd: [OpenMP] Allow building libomp using Microsoft Visual C++ naming scheme (authored by branh).
[OpenMP] Allow building libomp using Microsoft Visual C++ naming scheme
Nov 11 2021, 11:12 AM
jlpeyton closed D110354: Add option to build libomp library using Microsoft Visual C++ naming scheme..
Nov 11 2021, 11:12 AM · Restricted Project

Nov 9 2021

jlpeyton accepted D110354: Add option to build libomp library using Microsoft Visual C++ naming scheme..

LGTM

Nov 9 2021, 1:19 PM · Restricted Project
jlpeyton added a comment to D110354: Add option to build libomp library using Microsoft Visual C++ naming scheme..

I only have one other suggestion. I think its fine to use uppercase_CMAKE_BUILD_TYPE since its defined everywhere. The DEBUG_BUILD (and friends) are useful as booleans for append_if() type macro/functions in CMake.

Nov 9 2021, 9:18 AM · Restricted Project
jlpeyton committed rG48b67dca2ccc: [OpenMP][libomp][CMake] use uppercase_CMAKE_BUILD_TYPE (authored by jlpeyton).
[OpenMP][libomp][CMake] use uppercase_CMAKE_BUILD_TYPE
Nov 9 2021, 9:04 AM
jlpeyton closed D112951: [OpenMP][libomp][CMake] set and use uppercase_CMAKE_BUILD_TYPE.
Nov 9 2021, 9:04 AM · Restricted Project

Nov 8 2021

jlpeyton added a comment to D112027: [OpenMP][libomp] Allow users to specify KMP_HW_SUBSET in any order.
In D112027#3071416, @ye-luo wrote:

Can we have user documentation for KMP_XX environment variables on https://openmp.llvm.org//design/Runtimes.html#openmp-runtimes?

Nov 8 2021, 7:54 AM · Restricted Project

Nov 1 2021

jlpeyton added inline comments to D110354: Add option to build libomp library using Microsoft Visual C++ naming scheme..
Nov 1 2021, 12:33 PM · Restricted Project
jlpeyton requested review of D112951: [OpenMP][libomp][CMake] set and use uppercase_CMAKE_BUILD_TYPE.
Nov 1 2021, 12:28 PM · Restricted Project

Oct 25 2021

jlpeyton added a comment to rGd7fdd236d59f: [OpenMP][Tests][NFC] Replace atomic increment by reduction.
In rGd7fdd236d59f5850a1205929dae5a9e26a6b8c0b#1034077, @protze.joachim wrote:

@jlpeyton can you check with your compiler team, what is wrong with icc 2021? icx works fine.

After changing a/b to long long, I get this output:

a = 4294967295 (should be 83), b = 4294967295 (should be 83)

I was wondering about the -1, but that actually seems to be the result.

The execution time for 4294967295 atomic updates was just too long.

Oct 25 2021, 11:04 AM
jlpeyton abandoned D112456: [OpenMP][libomp] Fix omp_get_wtime.c test.

https://reviews.llvm.org/D112458 addresses this instead.

Oct 25 2021, 8:59 AM · Restricted Project
jlpeyton accepted D112458: [OpenMP] [test] Test omp_get_wtime for invariants.

LGTM

Oct 25 2021, 8:58 AM · Restricted Project
jlpeyton requested review of D112456: [OpenMP][libomp] Fix omp_get_wtime.c test.
Oct 25 2021, 7:46 AM · Restricted Project

Oct 22 2021

jlpeyton committed rGba02586fbe18: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS (authored by vladaindjic).
[OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS
Oct 22 2021, 9:02 AM
jlpeyton closed D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.
Oct 22 2021, 9:02 AM · Restricted Project

Oct 21 2021

jlpeyton requested review of D112274: [OpenMP][libomp] Add support for offline CPUs in Linux.
Oct 21 2021, 2:59 PM · Restricted Project
jlpeyton requested review of D112273: [OpenMP][libomp] Improve Windows Processor Group handling within topology.
Oct 21 2021, 2:33 PM · Restricted Project
jlpeyton requested review of D112270: [OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds.
Oct 21 2021, 2:06 PM · Restricted Project
jlpeyton accepted D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.

LGTM

Oct 21 2021, 12:19 PM · Restricted Project
jlpeyton added inline comments to D112205: [OpenMP][OMPT][GOMP] task frame support in KMP_API_NAME_GOMP_PARALLEL_SECTIONS.
Oct 21 2021, 6:50 AM · Restricted Project

Oct 19 2021

jlpeyton accepted D111673: [OpenMP] Add GOMP allocator functions.

LGTM

Oct 19 2021, 6:47 AM · Restricted Project

Oct 18 2021

jlpeyton requested review of D112027: [OpenMP][libomp] Allow users to specify KMP_HW_SUBSET in any order.
Oct 18 2021, 12:29 PM · Restricted Project

Oct 14 2021

jlpeyton committed rGb840d3ab0d8a: [OpenMP][host runtime] small fixup of RTM CPUID bit check (authored by jlpeyton).
[OpenMP][host runtime] small fixup of RTM CPUID bit check
Oct 14 2021, 2:50 PM
jlpeyton committed rGacb3b187c4c8: [OpenMP][host runtime] Add initial hybrid CPU support (authored by jlpeyton).
[OpenMP][host runtime] Add initial hybrid CPU support
Oct 14 2021, 2:50 PM
jlpeyton closed D110435: [OpenMP][host runtime] Add initial hybrid CPU support.
Oct 14 2021, 2:50 PM · Restricted Project
jlpeyton committed rG50b68a3d0305: [OpenMP][host runtime] Add support for teams affinity (authored by jlpeyton).
[OpenMP][host runtime] Add support for teams affinity
Oct 14 2021, 2:32 PM
jlpeyton closed D109921: [OpenMP][host runtime] Add support for teams affinity.
Oct 14 2021, 2:32 PM · Restricted Project
jlpeyton added inline comments to D109921: [OpenMP][host runtime] Add support for teams affinity.
Oct 14 2021, 8:50 AM · Restricted Project

Oct 13 2021

jlpeyton accepted D111562: [OpenMP] libomp: fix warning on comparison of integer expressions of different signedness.

LGTM

Oct 13 2021, 9:19 AM · Restricted Project

Oct 12 2021

jlpeyton added a comment to D110435: [OpenMP][host runtime] Add initial hybrid CPU support.

@jdoerfert , does it look OK now?

Oct 12 2021, 8:35 AM · Restricted Project

Oct 8 2021

jlpeyton updated the diff for D110435: [OpenMP][host runtime] Add initial hybrid CPU support.

Addressed patch comments

Oct 8 2021, 8:23 AM · Restricted Project

Oct 1 2021

jlpeyton committed rG343b9e8590db: [OpenMP][host runtime] Introduce kmp_cpuinfo_flags_t to replace integer flags (authored by jlpeyton).
[OpenMP][host runtime] Introduce kmp_cpuinfo_flags_t to replace integer flags
Oct 1 2021, 9:09 AM
jlpeyton closed D110091: [OpenMP][host runtime] Introduce kmp_cpuinfo_flags_t to replace integer flags.
Oct 1 2021, 9:09 AM · Restricted Project
jlpeyton committed rG957b4c57501b: [OpenMP][testing] increase threshold for omp_get_wtime test (authored by jlpeyton).
[OpenMP][testing] increase threshold for omp_get_wtime test
Oct 1 2021, 9:08 AM

Sep 27 2021

jlpeyton added inline comments to D110354: Add option to build libomp library using Microsoft Visual C++ naming scheme..
Sep 27 2021, 8:16 AM · Restricted Project

Sep 24 2021

jlpeyton requested review of D110435: [OpenMP][host runtime] Add initial hybrid CPU support.
Sep 24 2021, 11:08 AM · Restricted Project

Sep 20 2021

jlpeyton abandoned D104788: [OpenMP] Fix builds for non-x86 after distributed barrier patch.

This patch is no longer relevant.

Sep 20 2021, 2:08 PM · Restricted Project
jlpeyton requested review of D110091: [OpenMP][host runtime] Introduce kmp_cpuinfo_flags_t to replace integer flags.
Sep 20 2021, 11:38 AM · Restricted Project
jlpeyton committed rG1e45cd75dfb1: [OpenMP][host runtime] Fix indirect lock table race condition (authored by jlpeyton).
[OpenMP][host runtime] Fix indirect lock table race condition
Sep 20 2021, 11:02 AM
jlpeyton closed D109725: [OpenMP][host runtime] Fix indirect lock table race condition.
Sep 20 2021, 11:02 AM · Restricted Project