Page MenuHomePhabricator

jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 8:35 AM (321 w, 4 d)

Recent Activity

Mon, Apr 5

jlpeyton committed rG2aebb7cb3c88: [OpenMP] Fix incorrect KMP_STRLEN() macro (authored by jlpeyton).
[OpenMP] Fix incorrect KMP_STRLEN() macro
Mon, Apr 5, 7:04 AM
jlpeyton closed D98209: [OpenMP] Fix incorrect KMP_STRLEN() macro on Windows.
Mon, Apr 5, 7:03 AM · Restricted Project

Tue, Mar 23

jlpeyton requested review of D99218: [OpenMP] Allow affinity to re-detect for child processes.
Tue, Mar 23, 3:03 PM · Restricted Project
jlpeyton accepted D98584: [OpenMP] Misc. changes that add or remove pointer/bound checks.

These look fine to me.

Tue, Mar 23, 1:34 PM · Restricted Project

Wed, Mar 17

jlpeyton requested review of D98806: [OpenMP] Implement GOMP task reductions.
Wed, Mar 17, 12:44 PM · Restricted Project

Mon, Mar 15

jlpeyton committed rG7085f0457395: [OpenMP] Remove unused cpu_stackoffset member (authored by jlpeyton).
[OpenMP] Remove unused cpu_stackoffset member
Mon, Mar 15, 2:52 PM

Mar 8 2021

jlpeyton requested review of D98209: [OpenMP] Fix incorrect KMP_STRLEN() macro on Windows.
Mar 8 2021, 12:01 PM · Restricted Project
jlpeyton accepted D97079: [OpenMP] libomp: eliminate pause from atomic CAS loops.

LGTM

Mar 8 2021, 11:54 AM · Restricted Project
jlpeyton added a comment to D97079: [OpenMP] libomp: eliminate pause from atomic CAS loops.

I think this is architecture specific.

If a CAS failed spuriously, then immediately retry is good. If it failed because another core wrote to the cache line, then we have established that said cache line is somewhat contended, in which case pause() may let the other threads progress faster.

If one thread succeeded then ALL other threads competing on the cache line would fail. So they will not progress faster executing pause instruction. Only gain can be for succeeding thread, that means it executes nothing but atomic in a loop, and that is not a real code example...

Actually the atomic functions are never called by clang, so it is kind of cleanup change in any case.

Experiments calling an internal atomic function directly in a loop show either no difference on some processors (where pause instruction is fast enough), or significant speedup (where pause instruction is slow).

One clear gain of this patch is reduced size of the runtime - I see 4096 bytes smaller size of the binary if the patch applied.

If you still think the patch is not good, I am fine to abandon it. But to me it is pretty harmless, and as I mentioned, it reduces the size of the runtime.

Mar 8 2021, 8:35 AM · Restricted Project
jlpeyton committed rGe2738b3758a9: [OpenMP] Fix potential integer overflow in dynamic schedule code (authored by jlpeyton).
[OpenMP] Fix potential integer overflow in dynamic schedule code
Mar 8 2021, 7:44 AM
jlpeyton closed D96747: [OpenMP] Fix potential integer overflow in dynamic schedule code.
Mar 8 2021, 7:43 AM · Restricted Project

Mar 5 2021

jlpeyton added a comment to D97019: [OpenMP] libomp: Add masked construct, change proc-bind keyword, deprecate master construct.

@tlwilmar , you can just close this revision manually, but if you look at the git log for the llvm-project you'll see the "Differential Revision: <hyperlink>" line in many of the commits.

Mar 5 2021, 8:28 AM · Restricted Project
jlpeyton added a comment to D97019: [OpenMP] libomp: Add masked construct, change proc-bind keyword, deprecate master construct.

Hi Johnny,
When I just commit via the instructions on our wiki, I just see this separate e-mail labeled "[Diffusion]" which looks like a separate review in Phabricator. When others push their changes, it appears attached to the original phabricator review, and seems to close it automagically. What am I missing there?

Thanks!

Mar 5 2021, 8:25 AM · Restricted Project

Mar 2 2021

jlpeyton committed rGe83380fccc2c: [OpenMP] Fix clang-cl build error regarding TSX intrinsics (authored by jlpeyton).
[OpenMP] Fix clang-cl build error regarding TSX intrinsics
Mar 2 2021, 5:48 AM
jlpeyton closed D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.
Mar 2 2021, 5:48 AM · Restricted Project

Mar 1 2021

jlpeyton updated the diff for D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.

Ok, this actually restores using OLD_CMAKE_REQUIRED_FLAGS

Mar 1 2021, 2:25 PM · Restricted Project
jlpeyton updated the diff for D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.

Ok, I see what you're saying. I've copied the exact idiom used in the LLVM CMake where CMAKE_REQUIRED_FLAGS is temporarily stored in OLD_CMAKE_REQUIRED_FLAGS and then restored after the check.

Mar 1 2021, 2:22 PM · Restricted Project
jlpeyton accepted D97019: [OpenMP] libomp: Add masked construct, change proc-bind keyword, deprecate master construct.

LGTM

Mar 1 2021, 10:16 AM · Restricted Project

Feb 25 2021

jlpeyton added inline comments to D97019: [OpenMP] libomp: Add masked construct, change proc-bind keyword, deprecate master construct.
Feb 25 2021, 12:15 PM · Restricted Project
jlpeyton committed rGd12ae7db9973: [OpenMP] Fix accidental addition of use omp_lib_kinds (authored by jlpeyton).
[OpenMP] Fix accidental addition of use omp_lib_kinds
Feb 25 2021, 10:54 AM
jlpeyton added a comment to D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.

Oh, and I just realized: just because my machine supports RTM doesn't necessarily mean we want to use it, since these builds will then be used on all kinds of machines. This might be a bigger problem with the runtime's build config though.

Feb 25 2021, 9:37 AM · Restricted Project
jlpeyton updated the diff for D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.

Since CMake's documentation states that the CMAKE_REQURIED_FLAGS variable is a string rather than a list, use simple set() to assign it.

Feb 25 2021, 9:22 AM · Restricted Project

Feb 24 2021

jlpeyton requested review of D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.
Feb 24 2021, 1:37 PM · Restricted Project

Feb 22 2021

jlpeyton committed rG56223b1e91ed: [OpenMP] Help static loop code avoid over/underflow (authored by jlpeyton).
[OpenMP] Help static loop code avoid over/underflow
Feb 22 2021, 11:22 AM
jlpeyton closed D96426: [OpenMP] Help static loop code avoid over/underflow.
Feb 22 2021, 11:22 AM · Restricted Project
jlpeyton committed rG1b968467c057: [OpenMP] Remove shutdown attempt on Windows process detach (authored by jlpeyton).
[OpenMP] Remove shutdown attempt on Windows process detach
Feb 22 2021, 11:16 AM
jlpeyton closed D96750: [OpenMP] Remove shutdown attempt on Windows process detach.
Feb 22 2021, 11:16 AM · Restricted Project
jlpeyton committed rG8c73be9d8675: [OpenMP] Limit number of dispatch buffers (authored by jlpeyton).
[OpenMP] Limit number of dispatch buffers
Feb 22 2021, 11:15 AM
jlpeyton closed D96749: [OpenMP] Limit number of dispatch buffers.
Feb 22 2021, 11:15 AM · Restricted Project
jlpeyton committed rG55dff8b2e4f0: [OpenMP] Update HWLOC code for die level detection (authored by jlpeyton).
[OpenMP] Update HWLOC code for die level detection
Feb 22 2021, 11:06 AM
jlpeyton closed D96748: [OpenMP] Update HWLOC topology detection for die level.
Feb 22 2021, 11:06 AM · Restricted Project

Feb 15 2021

jlpeyton requested review of D96750: [OpenMP] Remove shutdown attempt on Windows process detach.
Feb 15 2021, 9:54 PM · Restricted Project
jlpeyton requested review of D96749: [OpenMP] Limit number of dispatch buffers.
Feb 15 2021, 9:50 PM · Restricted Project
jlpeyton requested review of D96748: [OpenMP] Update HWLOC topology detection for die level.
Feb 15 2021, 9:47 PM · Restricted Project
jlpeyton requested review of D96747: [OpenMP] Fix potential integer overflow in dynamic schedule code.
Feb 15 2021, 9:45 PM · Restricted Project

Feb 10 2021

jlpeyton requested review of D96426: [OpenMP] Help static loop code avoid over/underflow.
Feb 10 2021, 8:44 AM · Restricted Project

Feb 2 2021

jlpeyton committed rGffca74b8b82f: [OpenMP] Fix sign comparison warnings from GCC (authored by jlpeyton).
[OpenMP] Fix sign comparison warnings from GCC
Feb 2 2021, 8:53 AM
jlpeyton closed D95818: [OpenMP] Fix sign comparison warnings from GCC.
Feb 2 2021, 8:53 AM · Restricted Project

Feb 1 2021

jlpeyton requested review of D95818: [OpenMP] Fix sign comparison warnings from GCC.
Feb 1 2021, 1:55 PM · Restricted Project

Jan 27 2021

jlpeyton committed rG8e6713436462: [OpenMP] Fix misleading warning for OMP_PLACES (authored by jlpeyton).
[OpenMP] Fix misleading warning for OMP_PLACES
Jan 27 2021, 12:28 PM
jlpeyton closed D95170: [OpenMP] Fix misleading warning for OMP_PLACES.
Jan 27 2021, 12:28 PM · Restricted Project
jlpeyton committed rG598c590b3c96: [OpenMP] Add cpuid leaf 1f topology discovery (authored by jlpeyton).
[OpenMP] Add cpuid leaf 1f topology discovery
Jan 27 2021, 12:28 PM
jlpeyton closed D95157: [OpenMP] Add CPUID leaf 1f topology discovery.
Jan 27 2021, 12:28 PM · Restricted Project
jlpeyton committed rG9f87c6b47df9: [OpenMP] Fix HWLOC topology detection for 2.0.x (authored by jlpeyton).
[OpenMP] Fix HWLOC topology detection for 2.0.x
Jan 27 2021, 12:28 PM
jlpeyton closed D95156: [OpenMP] Update HWLOC topology detection for 2.0.x.
Jan 27 2021, 12:28 PM · Restricted Project

Jan 22 2021

jlpeyton updated the diff for D95170: [OpenMP] Fix misleading warning for OMP_PLACES.

Fixed so that cores is displayed in the warning message.

Jan 22 2021, 11:38 AM · Restricted Project
jlpeyton added a comment to D95170: [OpenMP] Fix misleading warning for OMP_PLACES.

In my quick test, env KMP_SETTINGS=1 OMP_PROC_BIND=spread ./a.out reports OMP_PLACES='cores'. I could not find the code path that sets places to cores in this case, but I think it would be more consistent to have consistent setting in the unset and the invalid case.

Is there a reason to choose threads?

Jan 22 2021, 8:28 AM · Restricted Project

Jan 21 2021

jlpeyton requested review of D95170: [OpenMP] Fix misleading warning for OMP_PLACES.
Jan 21 2021, 1:49 PM · Restricted Project
jlpeyton requested review of D95157: [OpenMP] Add CPUID leaf 1f topology discovery.
Jan 21 2021, 11:33 AM · Restricted Project
jlpeyton requested review of D95156: [OpenMP] Update HWLOC topology detection for 2.0.x.
Jan 21 2021, 11:22 AM · Restricted Project

Dec 15 2020

jlpeyton committed rG5aafdd7b88f5: [OpenMP] Introduce new file wrapper class for runtime (authored by jlpeyton).
[OpenMP] Introduce new file wrapper class for runtime
Dec 15 2020, 12:48 PM
jlpeyton closed D92604: [OpenMP] Introduce new file wrapper class for runtime.
Dec 15 2020, 12:48 PM · Restricted Project

Dec 9 2020

jlpeyton updated the diff for D92604: [OpenMP] Introduce new file wrapper class for runtime.

Updated with documentation. Class is now kmp_safe_raii_file_t

Dec 9 2020, 1:43 PM · Restricted Project
jlpeyton committed rGfe3b244ef7c2: [OpenMP] Fix norespect affinity bug for Windows (authored by jlpeyton).
[OpenMP] Fix norespect affinity bug for Windows
Dec 9 2020, 12:34 PM
jlpeyton closed D92587: [OpenMP] Fix norespect affinity bug for Windows.
Dec 9 2020, 12:34 PM · Restricted Project
jlpeyton committed rG9b7d6a6bffce: [OpenMP] Fix too long name for shm segment on macOS (authored by jlpeyton).
[OpenMP] Fix too long name for shm segment on macOS
Dec 9 2020, 12:32 PM
jlpeyton closed D92660: [OpenMP] Fix too long name for shm segment on macOS.
Dec 9 2020, 12:32 PM · Restricted Project

Dec 4 2020

jlpeyton requested review of D92660: [OpenMP] Fix too long name for shm segment on macOS.
Dec 4 2020, 8:34 AM · Restricted Project

Dec 3 2020

jlpeyton requested review of D92604: [OpenMP] Introduce new file wrapper class for runtime.
Dec 3 2020, 1:44 PM · Restricted Project
jlpeyton requested review of D92587: [OpenMP] Fix norespect affinity bug for Windows.
Dec 3 2020, 10:21 AM · Restricted Project

Dec 1 2020

jlpeyton committed rGe0665a905084: [OpenMP] Add support for Intel's umonitor/umwait (authored by tlwilmar).
[OpenMP] Add support for Intel's umonitor/umwait
Dec 1 2020, 12:08 PM
jlpeyton closed D91189: Add support for Intel's umonitor/umwait.
Dec 1 2020, 12:08 PM · Restricted Project
jlpeyton accepted D91189: Add support for Intel's umonitor/umwait.

LGTM now.

Dec 1 2020, 10:12 AM · Restricted Project
jlpeyton added a comment to D91189: Add support for Intel's umonitor/umwait.

Sorry, I missed one thing.

Dec 1 2020, 9:15 AM · Restricted Project

Nov 20 2020

jlpeyton added a comment to D91189: Add support for Intel's umonitor/umwait.

This broke compilation for me:

Nov 20 2020, 11:47 AM · Restricted Project

Nov 17 2020

jlpeyton committed rG8647c669a4a3: [OpenMP] NFC: remove tabs in message catalog file (authored by jlpeyton).
[OpenMP] NFC: remove tabs in message catalog file
Nov 17 2020, 8:16 AM
jlpeyton committed rG0454154efd54: [OpenMP][stats] reset serial state when re-entering serial region (authored by jlpeyton).
[OpenMP][stats] reset serial state when re-entering serial region
Nov 17 2020, 8:11 AM
jlpeyton closed D90867: [OpenMP][stats] reset serial state when re-entering serial region.
Nov 17 2020, 8:10 AM · Restricted Project

Nov 11 2020

jlpeyton committed rGdd8723d348c9: [OpenMP] Fix shutdown hang/race bug (authored by jlpeyton).
[OpenMP] Fix shutdown hang/race bug
Nov 11 2020, 11:48 AM
jlpeyton closed D90647: [OpenMP] Fix shutdown hang bug.
Nov 11 2020, 11:48 AM · Restricted Project

Nov 5 2020

jlpeyton requested review of D90867: [OpenMP][stats] reset serial state when re-entering serial region.
Nov 5 2020, 10:41 AM · Restricted Project
jlpeyton committed rG5e34877480df: [OpenMP] Add ident_t flags for compiler OpenMP version (authored by jlpeyton).
[OpenMP] Add ident_t flags for compiler OpenMP version
Nov 5 2020, 9:15 AM
jlpeyton closed D90632: [OpenMP] Add ident_t flags for compiler OpenMP version.
Nov 5 2020, 9:15 AM · Restricted Project

Nov 3 2020

jlpeyton accepted D90077: [OpenMP] Remove obsolete Fortran module file.

LGTM

Nov 3 2020, 8:57 AM · Restricted Project
jlpeyton added a comment to D90412: Fix hierarchical barrier deadlock for infinite blocktime.

one comment.

Nov 3 2020, 8:43 AM · Restricted Project

Nov 2 2020

jlpeyton requested review of D90647: [OpenMP] Fix shutdown hang bug.
Nov 2 2020, 2:03 PM · Restricted Project
jlpeyton requested review of D90632: [OpenMP] Add ident_t flags for compiler OpenMP version.
Nov 2 2020, 10:34 AM · Restricted Project

Oct 29 2020

jlpeyton committed rG771f0fb92dc2: [OpenMP] Add NULL check in dispatcher debug output (authored by jlpeyton).
[OpenMP] Add NULL check in dispatcher debug output
Oct 29 2020, 12:08 PM
jlpeyton closed D90403: [OpenMP] Add NULL check in dispatcher debug output.
Oct 29 2020, 12:08 PM · Restricted Project
jlpeyton accepted D90403: [OpenMP] Add NULL check in dispatcher debug output.

LGTM as well

Oct 29 2020, 12:02 PM · Restricted Project

Sep 24 2020

jlpeyton accepted D87680: [OpenMP][OMPT] Update OMPT tests for newly added GOMP interface patches.

LGTM as well.

Sep 24 2020, 8:04 AM · Restricted Project
jlpeyton committed rGee1c04a92690: [OpenMP] Fix if0 task with dependencies in the runtime (authored by jlpeyton).
[OpenMP] Fix if0 task with dependencies in the runtime
Sep 24 2020, 7:50 AM
jlpeyton committed rG9089b4a5c5b4: [OpenMP] Introduce GOMP taskwait depend in the runtime (authored by jlpeyton).
[OpenMP] Introduce GOMP taskwait depend in the runtime
Sep 24 2020, 7:50 AM
jlpeyton committed rG72ada5ae6c5b: [OpenMP] Introduce GOMP mutexinoutset in the runtime (authored by jlpeyton).
[OpenMP] Introduce GOMP mutexinoutset in the runtime
Sep 24 2020, 7:50 AM
jlpeyton closed D87271: [OpenMP] Fix if0 task with dependencies.
Sep 24 2020, 7:50 AM · Restricted Project
jlpeyton committed rGea34d95e0ad6: [OpenMP] Introduce GOMP teams support in runtime (authored by jlpeyton).
[OpenMP] Introduce GOMP teams support in runtime
Sep 24 2020, 7:50 AM
jlpeyton closed D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.
Sep 24 2020, 7:50 AM · Restricted Project
jlpeyton closed D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.
Sep 24 2020, 7:50 AM · Restricted Project
jlpeyton closed D87167: [OpenMP] Introduce GOMP teams support in runtime.
Sep 24 2020, 7:50 AM · Restricted Project

Sep 23 2020

jlpeyton added a comment to D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.

ping

Sep 23 2020, 9:10 AM · Restricted Project

Sep 17 2020

jlpeyton updated the diff for D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.

Fixed the GOMP dependency type assignment. Checked with the follow-up OMPT changes in D87680.

Sep 17 2020, 10:53 AM · Restricted Project
jlpeyton updated the diff for D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.

Change to XFAIL for clang and icc and add comment in test file.

Sep 17 2020, 10:31 AM · Restricted Project

Sep 14 2020

jlpeyton updated the diff for D87271: [OpenMP] Fix if0 task with dependencies.

Add #pragma omp task if(0) depend() version of taskwait depend test.

Sep 14 2020, 3:11 PM · Restricted Project
jlpeyton updated the diff for D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.

Use my_sleep() from omp_my_sleep.h

Sep 14 2020, 3:07 PM · Restricted Project
jlpeyton updated the diff for D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.

Test was poorly constructed. Second attempt.

Sep 14 2020, 2:52 PM · Restricted Project

Sep 10 2020

jlpeyton updated the diff for D87271: [OpenMP] Fix if0 task with dependencies.

Added enum for GOMP task flags.

Sep 10 2020, 2:15 PM · Restricted Project

Sep 7 2020

jlpeyton requested review of D87271: [OpenMP] Fix if0 task with dependencies.
Sep 7 2020, 10:25 PM · Restricted Project
jlpeyton requested review of D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.
Sep 7 2020, 10:12 PM · Restricted Project
jlpeyton requested review of D87267: [OpenMP] Introduce GOMP mutexinoutset in the runtime.
Sep 7 2020, 10:04 PM · Restricted Project

Sep 4 2020

jlpeyton updated the summary of D87167: [OpenMP] Introduce GOMP teams support in runtime.
Sep 4 2020, 2:43 PM · Restricted Project