jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 8:35 AM (148 w, 22 h)

Recent Activity

Wed, Dec 6

jlpeyton committed rL319961: [OpenMP] Add entry for Intel Compiler 18.
[OpenMP] Add entry for Intel Compiler 18
Wed, Dec 6, 1:16 PM
jlpeyton committed rOMP319961: [OpenMP] Add entry for Intel Compiler 18.
[OpenMP] Add entry for Intel Compiler 18
Wed, Dec 6, 1:16 PM
jlpeyton closed D40386: [OpenMP] Add entry for Intel Compiler 18 by committing rOMP319961: [OpenMP] Add entry for Intel Compiler 18.
Wed, Dec 6, 1:15 PM
jlpeyton committed rOMP319960: Eliminate double printing of verbose affinity settings.
Eliminate double printing of verbose affinity settings
Wed, Dec 6, 1:08 PM
jlpeyton committed rL319960: Eliminate double printing of verbose affinity settings.
Eliminate double printing of verbose affinity settings
Wed, Dec 6, 1:08 PM
jlpeyton closed D40624: Eliminate double printing of verbose affinity settings by committing rL319960: Eliminate double printing of verbose affinity settings.
Wed, Dec 6, 1:08 PM · Restricted Project
jlpeyton committed rOMP319957: Trivial enum fix.
Trivial enum fix
Wed, Dec 6, 1:03 PM
jlpeyton committed rL319957: Trivial enum fix.
Trivial enum fix
Wed, Dec 6, 1:03 PM
jlpeyton closed D40804: Trivial enum fix by committing rL319957: Trivial enum fix.
Wed, Dec 6, 1:02 PM

Wed, Nov 29

jlpeyton created D40624: Eliminate double printing of verbose affinity settings.
Wed, Nov 29, 2:56 PM · Restricted Project
jlpeyton committed rOMP319379: Make kmp_r_sched_t into a union.
Make kmp_r_sched_t into a union
Wed, Nov 29, 2:48 PM
jlpeyton committed rL319379: Make kmp_r_sched_t into a union.
Make kmp_r_sched_t into a union
Wed, Nov 29, 2:48 PM
jlpeyton closed D40374: Make kmp_r_sched_t into a union by committing rOMP319379: Make kmp_r_sched_t into a union.
Wed, Nov 29, 2:48 PM
jlpeyton closed D40374: Make kmp_r_sched_t into a union by committing rL319379: Make kmp_r_sched_t into a union.
Wed, Nov 29, 2:48 PM
jlpeyton accepted D40374: Make kmp_r_sched_t into a union.

LGTM

Wed, Nov 29, 2:46 PM
jlpeyton committed rL319375: Fix aligned memory allocation in the stub library.
Fix aligned memory allocation in the stub library
Wed, Nov 29, 2:30 PM
jlpeyton committed rOMP319375: Fix aligned memory allocation in the stub library.
Fix aligned memory allocation in the stub library
Wed, Nov 29, 2:30 PM
jlpeyton closed D40296: Fix aligned memory allocation in the stub library by committing rOMP319375: Fix aligned memory allocation in the stub library.
Wed, Nov 29, 2:30 PM
jlpeyton committed rL319374: Warning is emitted when tiles are requested but cannot be used.
Warning is emitted when tiles are requested but cannot be used
Wed, Nov 29, 2:27 PM
jlpeyton committed rOMP319374: Warning is emitted when tiles are requested but cannot be used.
Warning is emitted when tiles are requested but cannot be used
Wed, Nov 29, 2:27 PM
jlpeyton closed D40340: Warning is emitted when tiles are requested but cannot be used by committing rL319374: Warning is emitted when tiles are requested but cannot be used.
Wed, Nov 29, 2:27 PM
jlpeyton closed D40340: Warning is emitted when tiles are requested but cannot be used by committing rOMP319374: Warning is emitted when tiles are requested but cannot be used.
Wed, Nov 29, 2:27 PM
jlpeyton committed rOMP319372: Fix types of Fortran array elements.
Fix types of Fortran array elements
Wed, Nov 29, 2:24 PM
jlpeyton committed rL319372: Fix types of Fortran array elements.
Fix types of Fortran array elements
Wed, Nov 29, 2:24 PM
jlpeyton closed D40356: Fix types of Fortran array elements by committing rL319372: Fix types of Fortran array elements.
Wed, Nov 29, 2:24 PM
jlpeyton accepted D40083: [CMake] Detect information about test compiler.

LGTM.

Wed, Nov 29, 12:26 PM
jlpeyton accepted D40082: [CMake] Refactor testing infrastructure.

Fix minor thing, then LGTM

Wed, Nov 29, 10:20 AM
jlpeyton accepted D40081: [CMake] Refactor common settings and flags.

LGTM

Wed, Nov 29, 9:24 AM

Tue, Nov 28

jlpeyton accepted D40080: [CMake] Disallow direct configuration.

Ok sounds good. LGTM.

Tue, Nov 28, 2:42 PM
jlpeyton added a comment to D40081: [CMake] Refactor common settings and flags.

I'm going to make one last plea for doing it correctly. Here is actual CMake code from LLVM's main CMakeLists.txt. It is reasonable to error-check what the user requests no matter how odd you may find it! The user may not know that something is only available on a certain platform until they request it. They do not wrap the option in operating system guards. Although some other options they do wrap in OS guards. Please just add the three line OS error check and the three line flag check.

option(LLVM_USE_INTEL_JITEVENTS
  "Use Intel JIT API to inform Intel(R) VTune(TM) Amplifier XE 2011 about JIT code"
  OFF)
Tue, Nov 28, 2:33 PM
jlpeyton added inline comments to D40081: [CMake] Refactor common settings and flags.
Tue, Nov 28, 1:04 PM
jlpeyton added inline comments to D40081: [CMake] Refactor common settings and flags.
Tue, Nov 28, 10:44 AM
jlpeyton added inline comments to D40080: [CMake] Disallow direct configuration.
Tue, Nov 28, 10:10 AM
jlpeyton added inline comments to D40080: [CMake] Disallow direct configuration.
Tue, Nov 28, 10:05 AM

Wed, Nov 15

jlpeyton accepted D39613: Exclude untied tasks from checking of task scheduling constraint (TSC).

LGTM

Wed, Nov 15, 10:24 AM

Mon, Nov 13

jlpeyton committed rL318056: [OpenMP] Remove the unused testsuite/ directory.
[OpenMP] Remove the unused testsuite/ directory
Mon, Nov 13, 9:46 AM
jlpeyton closed D39767: [OpenMP] Removing unused testsuite/ directory by committing rL318056: [OpenMP] Remove the unused testsuite/ directory.
Mon, Nov 13, 9:45 AM · Restricted Project

Nov 7 2017

jlpeyton created D39767: [OpenMP] Removing unused testsuite/ directory.
Nov 7 2017, 3:39 PM · Restricted Project
jlpeyton committed rL317636: Cleanup version symbol macros and attributes/declspecs.
Cleanup version symbol macros and attributes/declspecs
Nov 7 2017, 3:32 PM
jlpeyton closed D39516: Cleanup version symbol macros and attributes/declspecs by committing rL317636: Cleanup version symbol macros and attributes/declspecs.
Nov 7 2017, 3:32 PM · Restricted Project

Nov 3 2017

jlpeyton accepted D39326: Rename field of ompt_frame_t.

LGTM

Nov 3 2017, 9:48 AM
jlpeyton accepted D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.

LGTM

Nov 3 2017, 9:46 AM

Nov 1 2017

jlpeyton created D39516: Cleanup version symbol macros and attributes/declspecs.
Nov 1 2017, 3:40 PM · Restricted Project
jlpeyton committed rL317115: [OpenMP] Fix race condition in omp_init_lock.
[OpenMP] Fix race condition in omp_init_lock
Nov 1 2017, 12:45 PM
jlpeyton closed D39439: [OpenMP]Fix race condition in omp_init_lock by committing rL317115: [OpenMP] Fix race condition in omp_init_lock.
Nov 1 2017, 12:45 PM · Restricted Project

Oct 25 2017

jlpeyton committed rL316623: Fix fatal error message displaying.
Fix fatal error message displaying
Oct 25 2017, 3:05 PM
jlpeyton closed D39248: Fix fatal error message displaying by committing rL316623: Fix fatal error message displaying.
Oct 25 2017, 3:05 PM · Restricted Project
jlpeyton added a comment to D38880: Detect whether the current system is a Linux system.

Also, if you take the features completely out, D38185 will need updating taking out the features in the REQUIRES: lines in the tests.

Oct 25 2017, 12:15 PM

Oct 24 2017

jlpeyton created D39248: Fix fatal error message displaying.
Oct 24 2017, 11:04 AM · Restricted Project
jlpeyton committed rL316452: Disable threadprivate data cleanup if runtime is terminating.
Disable threadprivate data cleanup if runtime is terminating
Oct 24 2017, 9:10 AM

Oct 20 2017

jlpeyton committed rL316234: Restrict OMPT to OpenMP version 5.0 and remove old header files.
Restrict OMPT to OpenMP version 5.0 and remove old header files
Oct 20 2017, 1:15 PM
jlpeyton closed D38876: Restrict OMPT to OpenMP version 5.0 and remove old header files by committing rL316234: Restrict OMPT to OpenMP version 5.0 and remove old header files.
Oct 20 2017, 1:15 PM
jlpeyton committed rL316232: Add license envirable for testing Intel compilers.
Add license envirable for testing Intel compilers
Oct 20 2017, 12:46 PM
jlpeyton closed D38881: Load Intel License environment variable in tests if available by committing rL316232: Add license envirable for testing Intel compilers.
Oct 20 2017, 12:45 PM
jlpeyton committed rL316230: Add C++ support for testcases.
Add C++ support for testcases
Oct 20 2017, 12:43 PM
jlpeyton closed D38878: Add C++ support for testcases by committing rL316230: Add C++ support for testcases.
Oct 20 2017, 12:43 PM
jlpeyton committed rL316227: Apply formatting changes.
Apply formatting changes
Oct 20 2017, 12:31 PM
jlpeyton closed D38837: Add explicit values to .clang-format by committing rL316227: Apply formatting changes.
Oct 20 2017, 12:31 PM

Oct 17 2017

jlpeyton added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 17 2017, 1:13 PM
jlpeyton added a comment to D38837: Add explicit values to .clang-format.

The main question remaining is, to what files should we apply clang-format. You already pointed out that we should not format tests.

We also need to include kmp_itt.inl. So *.cpp *.h *.inl should do the trick.

Oct 17 2017, 10:17 AM
jlpeyton added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

A few more comments

Oct 17 2017, 9:56 AM

Oct 16 2017

jlpeyton added a comment to D38837: Add explicit values to .clang-format.

Ok, I've done some more research on this and here is what I've found and suggest as the solution:

Oct 16 2017, 3:59 PM

Oct 12 2017

jlpeyton added a comment to D38837: Add explicit values to .clang-format.

Ah ok, I see now. When we first created .clang-format some specific attributes were changed from the defaults and not properly added. So we just need to remove the DisableFormat line, change the DisableFormat line in the comments to false (as Joachim noted), and the rest can stay. The OMPT patch still needs to be run through clang-format in some manner since the DisableFormat line probably prevented any real formatting to occur. After those changes this one looks good to me.

Oct 12 2017, 2:55 PM
jlpeyton added a comment to D38837: Add explicit values to .clang-format.

That is peculiar that the DisableFormat attribute is true for our defaults in comments. I don't know why that is.

Oct 12 2017, 1:52 PM
jlpeyton added inline comments to D38837: Add explicit values to .clang-format.
Oct 12 2017, 9:19 AM

Oct 6 2017

jlpeyton committed rL315091: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.
KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix
Oct 6 2017, 12:25 PM
jlpeyton closed D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix by committing rL315091: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.
Oct 6 2017, 12:25 PM

Oct 5 2017

jlpeyton updated the diff for D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.

Updated with Andrey's suggestion

Oct 5 2017, 2:08 PM

Sep 27 2017

jlpeyton committed rL314340: Remove unnecessary semicolons.
Remove unnecessary semicolons
Sep 27 2017, 1:38 PM
jlpeyton added a reviewer for D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1: hbae.

Initial scanning review, I'm adding Hansang as a reviewer since he has been looking at this code.

Sep 27 2017, 11:07 AM

Sep 26 2017

jlpeyton abandoned D22144: [lit] add support for unsetting environment variable.

D36403 committed this functionality (a74a4df4d5 or svn r311180) . This revision is not needed.

Sep 26 2017, 4:20 PM
jlpeyton committed rL314243: Allow printing of KMP_TOPOLOGY_METHOD when KMP_SETTINGS=true.
Allow printing of KMP_TOPOLOGY_METHOD when KMP_SETTINGS=true
Sep 26 2017, 3:35 PM
jlpeyton committed rL314242: Remove unused t_single_lock.
Remove unused t_single_lock
Sep 26 2017, 3:35 PM
jlpeyton created D38292: KMP_HW_SUBSET vs KMP_PLACE_THREADS rival envirables fix.
Sep 26 2017, 3:30 PM

Sep 5 2017

jlpeyton committed rL312539: Read blocktime value set by kmp_set_blocktime() before reading from….
Read blocktime value set by kmp_set_blocktime() before reading from…
Sep 5 2017, 8:49 AM
jlpeyton closed D37403: Read blocktime value set by kmp_set_blocktime() before reading from KMP_BLOCKTIME by committing rL312539: Read blocktime value set by kmp_set_blocktime() before reading from….
Sep 5 2017, 8:49 AM
jlpeyton accepted D37403: Read blocktime value set by kmp_set_blocktime() before reading from KMP_BLOCKTIME.

LGTM

Sep 5 2017, 8:45 AM
jlpeyton committed rL312538: Minor code cleanup of Klocwork issues.
Minor code cleanup of Klocwork issues
Sep 5 2017, 8:45 AM
jlpeyton closed D37275: Minor code cleanup of Klocwork issues by committing rL312538: Minor code cleanup of Klocwork issues.
Sep 5 2017, 8:45 AM
jlpeyton accepted D37275: Minor code cleanup of Klocwork issues.

LGTM

Sep 5 2017, 8:43 AM

Aug 19 2017

jlpeyton committed rL311269: Use va_copy instead of __va_copy to fix building libomp against musl libc.
Use va_copy instead of __va_copy to fix building libomp against musl libc
Aug 19 2017, 4:54 PM
jlpeyton closed D36343: Use va_copy instead of __va_copy to fix building libomp against musl libc by committing rL311269: Use va_copy instead of __va_copy to fix building libomp against musl libc.
Aug 19 2017, 4:54 PM

Aug 17 2017

jlpeyton committed rL311114: Remove BUILD_TV.
Remove BUILD_TV
Aug 17 2017, 12:12 PM
jlpeyton closed D36011: Remove BUILD_TV by committing rL311114: Remove BUILD_TV.
Aug 17 2017, 12:12 PM

Aug 11 2017

jlpeyton accepted D36403: [lit] add support for unsetting environment variables (again!).

LGTM

Aug 11 2017, 12:16 PM

Aug 10 2017

jlpeyton accepted D36510: OMP_PROC_BIND: better spread.

Looks good to me.

Aug 10 2017, 1:33 PM · Restricted Project

Aug 9 2017

jlpeyton added a comment to D36510: OMP_PROC_BIND: better spread.

Can you give a small example of how this would differ from the previous code?

Aug 9 2017, 10:25 AM · Restricted Project

Aug 7 2017

jlpeyton accepted D36343: Use va_copy instead of __va_copy to fix building libomp against musl libc.

All our sources are compiled as C++11 files and va_copy() is part of the C++11 standard. So this looks good to me.

Aug 7 2017, 2:26 PM

Aug 2 2017

jlpeyton committed rL309877: Exclude version symbols for static libomp.
Exclude version symbols for static libomp
Aug 2 2017, 1:10 PM
jlpeyton closed D36225: Exclude version symbols for static libomp by committing rL309877: Exclude version symbols for static libomp.
Aug 2 2017, 1:10 PM
jlpeyton accepted D36225: Exclude version symbols for static libomp.

LGTM

Aug 2 2017, 1:09 PM
jlpeyton committed rL309875: Move lock acquire/release functions in task deque cleanup code.
Move lock acquire/release functions in task deque cleanup code
Aug 2 2017, 1:07 PM
jlpeyton closed D36017: Move lock acquire/release functions to safer locations in task deque cleanup code by committing rL309875: Move lock acquire/release functions in task deque cleanup code.
Aug 2 2017, 1:07 PM
jlpeyton committed rL309874: Add new envirable KMP_TEAMS_THREAD_LIMIT.
Add new envirable KMP_TEAMS_THREAD_LIMIT
Aug 2 2017, 1:05 PM
jlpeyton closed D36009: Add new envirable KMP_TEAMS_THREAD_LIMIT by committing rL309874: Add new envirable KMP_TEAMS_THREAD_LIMIT.
Aug 2 2017, 1:05 PM

Jul 28 2017

jlpeyton committed rL309418: Fix comments and build messages concerning TSX.
Fix comments and build messages concerning TSX
Jul 28 2017, 12:06 PM

Jul 27 2017

jlpeyton committed rL309319: Fix implementation of OMP_THREAD_LIMIT.
Fix implementation of OMP_THREAD_LIMIT
Jul 27 2017, 1:59 PM
jlpeyton closed D35912: Fix implementation of OMP_THREAD_LIMIT by committing rL309319: Fix implementation of OMP_THREAD_LIMIT.
Jul 27 2017, 1:59 PM
jlpeyton accepted D35912: Fix implementation of OMP_THREAD_LIMIT.

LGTM

Jul 27 2017, 1:58 PM

Jul 26 2017

jlpeyton committed rL309168: Introduce KMP_DEVICE_THREAD_LIMIT.
Introduce KMP_DEVICE_THREAD_LIMIT
Jul 26 2017, 1:08 PM