jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 8:35 AM (166 w, 4 d)

Recent Activity

Wed, Apr 18

jlpeyton accepted D45786: [OpenMP] Compilation error fix on const char*.

LGTM

Wed, Apr 18, 2:59 PM
jlpeyton committed rOMP330283: [OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter.
[OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter
Wed, Apr 18, 12:33 PM
jlpeyton committed rOMP330282: Introduce GOMP_taskloop API.
Introduce GOMP_taskloop API
Wed, Apr 18, 12:33 PM
jlpeyton committed rL330283: [OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter.
[OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter
Wed, Apr 18, 12:29 PM
jlpeyton closed D45527: [OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter.
Wed, Apr 18, 12:29 PM · Restricted Project
jlpeyton committed rL330282: Introduce GOMP_taskloop API.
Introduce GOMP_taskloop API
Wed, Apr 18, 12:27 PM
jlpeyton closed D45327: Introduce GOMP_taskloop API.
Wed, Apr 18, 12:27 PM · Restricted Project

Wed, Apr 11

jlpeyton created D45527: [OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter.
Wed, Apr 11, 10:14 AM · Restricted Project

Thu, Apr 5

jlpeyton created D45327: Introduce GOMP_taskloop API.
Thu, Apr 5, 10:11 AM · Restricted Project

Fri, Mar 30

jlpeyton committed rOMP328900: Minor cleanup in __kmp_atfork_child().
Minor cleanup in __kmp_atfork_child()
Fri, Mar 30, 1:11 PM
jlpeyton committed rL328900: Minor cleanup in __kmp_atfork_child().
Minor cleanup in __kmp_atfork_child()
Fri, Mar 30, 12:58 PM
jlpeyton closed D44949: Minor cleanup in __kmp_atfork_child().
Fri, Mar 30, 12:58 PM · Restricted Project

Mon, Mar 26

jlpeyton committed rOMP328575: Move blocktime_str variable right before its first use.
Move blocktime_str variable right before its first use
Mon, Mar 26, 12:23 PM
jlpeyton committed rL328575: Move blocktime_str variable right before its first use.
Move blocktime_str variable right before its first use
Mon, Mar 26, 12:23 PM
jlpeyton committed rOMP328568: Add summarizeStats.py to tools directory.
Add summarizeStats.py to tools directory
Mon, Mar 26, 11:49 AM
jlpeyton committed rL328568: Add summarizeStats.py to tools directory.
Add summarizeStats.py to tools directory
Mon, Mar 26, 11:49 AM
jlpeyton closed D41838: Add summarizeStats.py to tools directory.
Mon, Mar 26, 11:49 AM · Restricted Project

Mar 20 2018

jlpeyton committed rOMP328046: Read OMP_TARGET_OFFLOAD and provide API to access ICV.
Read OMP_TARGET_OFFLOAD and provide API to access ICV
Mar 20 2018, 2:22 PM
jlpeyton committed rL328046: Read OMP_TARGET_OFFLOAD and provide API to access ICV.
Read OMP_TARGET_OFFLOAD and provide API to access ICV
Mar 20 2018, 2:22 PM
jlpeyton closed D44577: Read OMP_TARGET_OFFLOAD and provide API to access ICV.
Mar 20 2018, 2:22 PM

Feb 1 2018

jlpeyton added a comment to D42795: make libomp work on amd64 x32 ABI.

I guess first and foremost, we need to make sure that we want KMP_ARCH_X86, KMP_ARCH_X86_64, and KMP_ARCH_X86_X32 to be mutually exclusive macros i.e., different architectures as far as CMake is concerned. If we want them to be mutually exclusive, then there is more work to be done including but not limited to:

Feb 1 2018, 1:23 PM · Restricted Project

Jan 10 2018

jlpeyton committed rOMP322205: Force HWLOC topology method for NUMA-specific topology.
Force HWLOC topology method for NUMA-specific topology
Jan 10 2018, 10:33 AM
jlpeyton committed rL322205: Force HWLOC topology method for NUMA-specific topology.
Force HWLOC topology method for NUMA-specific topology
Jan 10 2018, 10:33 AM
jlpeyton closed D40905: Force HWLOC topology method in case user requested NUMA-specific topology via granularity or KMP_HW_SUBSET.
Jan 10 2018, 10:33 AM
jlpeyton accepted D40905: Force HWLOC topology method in case user requested NUMA-specific topology via granularity or KMP_HW_SUBSET.

LGTM

Jan 10 2018, 10:30 AM
jlpeyton committed rL322204: Simplify __kmp_expand_threads.
Simplify __kmp_expand_threads
Jan 10 2018, 10:28 AM
jlpeyton committed rOMP322204: Simplify __kmp_expand_threads.
Simplify __kmp_expand_threads
Jan 10 2018, 10:28 AM
jlpeyton closed D41836: Simplify __kmp_expand_threads.
Jan 10 2018, 10:28 AM
jlpeyton committed rOMP322203: Minor code cleanup.
Minor code cleanup
Jan 10 2018, 10:25 AM
jlpeyton committed rL322203: Minor code cleanup.
Minor code cleanup
Jan 10 2018, 10:25 AM
jlpeyton closed D41831: Minor code cleanup.
Jan 10 2018, 10:25 AM
jlpeyton committed rOMP322202: Improve stability of the runtime in parent/child processes.
Improve stability of the runtime in parent/child processes
Jan 10 2018, 10:23 AM
jlpeyton committed rL322202: Improve stability of the runtime in parent/child processes.
Improve stability of the runtime in parent/child processes
Jan 10 2018, 10:23 AM
jlpeyton closed D41462: Improve stability of the runtime in parent/child processes.
Jan 10 2018, 10:23 AM · Restricted Project

Jan 8 2018

jlpeyton created D41838: Add summarizeStats.py to tools directory.
Jan 8 2018, 2:16 PM · Restricted Project

Jan 4 2018

jlpeyton committed rL321831: Fix some comments and formatting in kmp_dispatch.cpp.
Fix some comments and formatting in kmp_dispatch.cpp
Jan 4 2018, 3:06 PM
jlpeyton committed rOMP321831: Fix some comments and formatting in kmp_dispatch.cpp.
Fix some comments and formatting in kmp_dispatch.cpp
Jan 4 2018, 3:06 PM
jlpeyton committed rOMP321827: Fix trademarks found by scanner.
Fix trademarks found by scanner
Jan 4 2018, 3:02 PM
jlpeyton committed rL321827: Fix trademarks found by scanner.
Fix trademarks found by scanner
Jan 4 2018, 2:58 PM

Dec 6 2017

jlpeyton committed rL319961: [OpenMP] Add entry for Intel Compiler 18.
[OpenMP] Add entry for Intel Compiler 18
Dec 6 2017, 1:16 PM
jlpeyton committed rOMP319961: [OpenMP] Add entry for Intel Compiler 18.
[OpenMP] Add entry for Intel Compiler 18
Dec 6 2017, 1:16 PM
jlpeyton closed D40386: [OpenMP] Add entry for Intel Compiler 18 by committing rOMP319961: [OpenMP] Add entry for Intel Compiler 18.
Dec 6 2017, 1:15 PM
jlpeyton committed rOMP319960: Eliminate double printing of verbose affinity settings.
Eliminate double printing of verbose affinity settings
Dec 6 2017, 1:08 PM
jlpeyton committed rL319960: Eliminate double printing of verbose affinity settings.
Eliminate double printing of verbose affinity settings
Dec 6 2017, 1:08 PM
jlpeyton closed D40624: Eliminate double printing of verbose affinity settings by committing rL319960: Eliminate double printing of verbose affinity settings.
Dec 6 2017, 1:08 PM · Restricted Project
jlpeyton committed rOMP319957: Trivial enum fix.
Trivial enum fix
Dec 6 2017, 1:03 PM
jlpeyton committed rL319957: Trivial enum fix.
Trivial enum fix
Dec 6 2017, 1:03 PM
jlpeyton closed D40804: Trivial enum fix by committing rL319957: Trivial enum fix.
Dec 6 2017, 1:02 PM

Nov 29 2017

jlpeyton created D40624: Eliminate double printing of verbose affinity settings.
Nov 29 2017, 2:56 PM · Restricted Project
jlpeyton committed rOMP319379: Make kmp_r_sched_t into a union.
Make kmp_r_sched_t into a union
Nov 29 2017, 2:48 PM
jlpeyton committed rL319379: Make kmp_r_sched_t into a union.
Make kmp_r_sched_t into a union
Nov 29 2017, 2:48 PM
jlpeyton closed D40374: Make kmp_r_sched_t into a union by committing rOMP319379: Make kmp_r_sched_t into a union.
Nov 29 2017, 2:48 PM
jlpeyton closed D40374: Make kmp_r_sched_t into a union by committing rL319379: Make kmp_r_sched_t into a union.
Nov 29 2017, 2:48 PM
jlpeyton accepted D40374: Make kmp_r_sched_t into a union.

LGTM

Nov 29 2017, 2:46 PM
jlpeyton committed rL319375: Fix aligned memory allocation in the stub library.
Fix aligned memory allocation in the stub library
Nov 29 2017, 2:30 PM
jlpeyton committed rOMP319375: Fix aligned memory allocation in the stub library.
Fix aligned memory allocation in the stub library
Nov 29 2017, 2:30 PM
jlpeyton closed D40296: Fix aligned memory allocation in the stub library by committing rOMP319375: Fix aligned memory allocation in the stub library.
Nov 29 2017, 2:30 PM
jlpeyton committed rL319374: Warning is emitted when tiles are requested but cannot be used.
Warning is emitted when tiles are requested but cannot be used
Nov 29 2017, 2:27 PM
jlpeyton committed rOMP319374: Warning is emitted when tiles are requested but cannot be used.
Warning is emitted when tiles are requested but cannot be used
Nov 29 2017, 2:27 PM
jlpeyton closed D40340: Warning is emitted when tiles are requested but cannot be used by committing rL319374: Warning is emitted when tiles are requested but cannot be used.
Nov 29 2017, 2:27 PM
jlpeyton closed D40340: Warning is emitted when tiles are requested but cannot be used by committing rOMP319374: Warning is emitted when tiles are requested but cannot be used.
Nov 29 2017, 2:27 PM
jlpeyton committed rOMP319372: Fix types of Fortran array elements.
Fix types of Fortran array elements
Nov 29 2017, 2:24 PM
jlpeyton committed rL319372: Fix types of Fortran array elements.
Fix types of Fortran array elements
Nov 29 2017, 2:24 PM
jlpeyton closed D40356: Fix types of Fortran array elements by committing rL319372: Fix types of Fortran array elements.
Nov 29 2017, 2:24 PM
jlpeyton accepted D40083: [CMake] Detect information about test compiler.

LGTM.

Nov 29 2017, 12:26 PM
jlpeyton accepted D40082: [CMake] Refactor testing infrastructure.

Fix minor thing, then LGTM

Nov 29 2017, 10:20 AM
jlpeyton accepted D40081: [CMake] Refactor common settings and flags.

LGTM

Nov 29 2017, 9:24 AM

Nov 28 2017

jlpeyton accepted D40080: [CMake] Disallow direct configuration.

Ok sounds good. LGTM.

Nov 28 2017, 2:42 PM
jlpeyton added a comment to D40081: [CMake] Refactor common settings and flags.

I'm going to make one last plea for doing it correctly. Here is actual CMake code from LLVM's main CMakeLists.txt. It is reasonable to error-check what the user requests no matter how odd you may find it! The user may not know that something is only available on a certain platform until they request it. They do not wrap the option in operating system guards. Although some other options they do wrap in OS guards. Please just add the three line OS error check and the three line flag check.

option(LLVM_USE_INTEL_JITEVENTS
  "Use Intel JIT API to inform Intel(R) VTune(TM) Amplifier XE 2011 about JIT code"
  OFF)
Nov 28 2017, 2:33 PM
jlpeyton added inline comments to D40081: [CMake] Refactor common settings and flags.
Nov 28 2017, 1:04 PM
jlpeyton added inline comments to D40081: [CMake] Refactor common settings and flags.
Nov 28 2017, 10:44 AM
jlpeyton added inline comments to D40080: [CMake] Disallow direct configuration.
Nov 28 2017, 10:10 AM
jlpeyton added inline comments to D40080: [CMake] Disallow direct configuration.
Nov 28 2017, 10:05 AM

Nov 15 2017

jlpeyton accepted D39613: Exclude untied tasks from checking of task scheduling constraint (TSC).

LGTM

Nov 15 2017, 10:24 AM

Nov 13 2017

jlpeyton committed rL318056: [OpenMP] Remove the unused testsuite/ directory.
[OpenMP] Remove the unused testsuite/ directory
Nov 13 2017, 9:46 AM
jlpeyton closed D39767: [OpenMP] Removing unused testsuite/ directory by committing rL318056: [OpenMP] Remove the unused testsuite/ directory.
Nov 13 2017, 9:45 AM · Restricted Project

Nov 7 2017

jlpeyton created D39767: [OpenMP] Removing unused testsuite/ directory.
Nov 7 2017, 3:39 PM · Restricted Project
jlpeyton committed rL317636: Cleanup version symbol macros and attributes/declspecs.
Cleanup version symbol macros and attributes/declspecs
Nov 7 2017, 3:32 PM
jlpeyton closed D39516: Cleanup version symbol macros and attributes/declspecs by committing rL317636: Cleanup version symbol macros and attributes/declspecs.
Nov 7 2017, 3:32 PM · Restricted Project

Nov 3 2017

jlpeyton accepted D39326: Rename field of ompt_frame_t.

LGTM

Nov 3 2017, 9:48 AM
jlpeyton accepted D39182: Implementation of OMPT as specified in OpenMP 5.0 Preview 2.

LGTM

Nov 3 2017, 9:46 AM

Nov 1 2017

jlpeyton created D39516: Cleanup version symbol macros and attributes/declspecs.
Nov 1 2017, 3:40 PM · Restricted Project
jlpeyton committed rL317115: [OpenMP] Fix race condition in omp_init_lock.
[OpenMP] Fix race condition in omp_init_lock
Nov 1 2017, 12:45 PM
jlpeyton closed D39439: [OpenMP]Fix race condition in omp_init_lock by committing rL317115: [OpenMP] Fix race condition in omp_init_lock.
Nov 1 2017, 12:45 PM · Restricted Project

Oct 25 2017

jlpeyton committed rL316623: Fix fatal error message displaying.
Fix fatal error message displaying
Oct 25 2017, 3:05 PM
jlpeyton closed D39248: Fix fatal error message displaying by committing rL316623: Fix fatal error message displaying.
Oct 25 2017, 3:05 PM · Restricted Project
jlpeyton added a comment to D38880: Detect whether the current system is a Linux system.

Also, if you take the features completely out, D38185 will need updating taking out the features in the REQUIRES: lines in the tests.

Oct 25 2017, 12:15 PM

Oct 24 2017

jlpeyton created D39248: Fix fatal error message displaying.
Oct 24 2017, 11:04 AM · Restricted Project
jlpeyton committed rL316452: Disable threadprivate data cleanup if runtime is terminating.
Disable threadprivate data cleanup if runtime is terminating
Oct 24 2017, 9:10 AM

Oct 20 2017

jlpeyton committed rL316234: Restrict OMPT to OpenMP version 5.0 and remove old header files.
Restrict OMPT to OpenMP version 5.0 and remove old header files
Oct 20 2017, 1:15 PM
jlpeyton closed D38876: Restrict OMPT to OpenMP version 5.0 and remove old header files by committing rL316234: Restrict OMPT to OpenMP version 5.0 and remove old header files.
Oct 20 2017, 1:15 PM
jlpeyton committed rL316232: Add license envirable for testing Intel compilers.
Add license envirable for testing Intel compilers
Oct 20 2017, 12:46 PM
jlpeyton closed D38881: Load Intel License environment variable in tests if available by committing rL316232: Add license envirable for testing Intel compilers.
Oct 20 2017, 12:45 PM
jlpeyton committed rL316230: Add C++ support for testcases.
Add C++ support for testcases
Oct 20 2017, 12:43 PM
jlpeyton closed D38878: Add C++ support for testcases by committing rL316230: Add C++ support for testcases.
Oct 20 2017, 12:43 PM
jlpeyton committed rL316227: Apply formatting changes.
Apply formatting changes
Oct 20 2017, 12:31 PM
jlpeyton closed D38837: Add explicit values to .clang-format by committing rL316227: Apply formatting changes.
Oct 20 2017, 12:31 PM

Oct 17 2017

jlpeyton added inline comments to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.
Oct 17 2017, 1:13 PM
jlpeyton added a comment to D38837: Add explicit values to .clang-format.

The main question remaining is, to what files should we apply clang-format. You already pointed out that we should not format tests.

We also need to include kmp_itt.inl. So *.cpp *.h *.inl should do the trick.

Oct 17 2017, 10:17 AM
jlpeyton added a comment to D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1.

A few more comments

Oct 17 2017, 9:56 AM