jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.
User Since
Feb 10 2015, 8:35 AM (111 w, 14 h)

Recent Activity

Mon, Mar 20

jlpeyton committed rL298314: Minor improvement of KMP_YIELD_NOW() macro..
Minor improvement of KMP_YIELD_NOW() macro.
Mon, Mar 20, 3:23 PM
jlpeyton closed D31008: Minor improvement of KMP_YIELD_NOW() macro. by committing rL298314: Minor improvement of KMP_YIELD_NOW() macro..
Mon, Mar 20, 3:23 PM
jlpeyton accepted D31008: Minor improvement of KMP_YIELD_NOW() macro..

LGTM

Mon, Mar 20, 3:22 PM
jlpeyton committed rL298313: Fix incorrect initial value of __kmp_affinity_type..
Fix incorrect initial value of __kmp_affinity_type.
Mon, Mar 20, 3:16 PM
jlpeyton closed D31012: Fix incorrect initial value of __kmp_affinity_type. by committing rL298313: Fix incorrect initial value of __kmp_affinity_type..
Mon, Mar 20, 3:16 PM
jlpeyton accepted D31012: Fix incorrect initial value of __kmp_affinity_type..

LGTM

Mon, Mar 20, 3:15 PM

Fri, Mar 10

jlpeyton committed rL297480: Fix assertion failure when 'proclist' is used without 'explicit' in KMP_AFFINITY.
Fix assertion failure when 'proclist' is used without 'explicit' in KMP_AFFINITY
Fri, Mar 10, 9:34 AM
jlpeyton closed D30404: Assertion failure when 'proclist' is used without 'explicit' in KMP_AFFINITY by committing rL297480: Fix assertion failure when 'proclist' is used without 'explicit' in KMP_AFFINITY.
Fri, Mar 10, 9:34 AM

Thu, Mar 9

jlpeyton accepted D30784: Create a git ignore file for openmp runtime.

Fix, then commit

Thu, Mar 9, 4:00 PM

Tue, Mar 7

jlpeyton added a comment to D30470: [cmake] Include openmp with add_llvm_external_project.

Yes, OpenMP would be under the runtimes/ directory.

Tue, Mar 7, 1:05 PM
jlpeyton accepted D30056: Fix GNU strerror_r check for Android..

LGTM

Tue, Mar 7, 10:12 AM

Mon, Mar 6

jlpeyton committed rL297083: OpenMP version 5.0 added.
OpenMP version 5.0 added
Mon, Mar 6, 2:19 PM
jlpeyton closed D30450: OpenMP version 5.0 added by committing rL297083: OpenMP version 5.0 added.
Mon, Mar 6, 2:19 PM
jlpeyton accepted D30470: [cmake] Include openmp with add_llvm_external_project.

LGTM, but I don't know if somebody else needs to OK.

Mon, Mar 6, 1:59 PM
jlpeyton committed rL297082: Mixed type atomic routines added to Windows DLL.
Mixed type atomic routines added to Windows DLL
Mon, Mar 6, 1:58 PM
jlpeyton closed D30408: Mixed type atomic routines are missed from DLL (Windows) by committing rL297082: Mixed type atomic routines added to Windows DLL.
Mon, Mar 6, 1:58 PM

Tue, Feb 28

jlpeyton committed rL296525: Removing couple unnecessary architecture guards..
Removing couple unnecessary architecture guards.
Tue, Feb 28, 1:55 PM

Feb 24 2017

jlpeyton accepted D30083: [openmp] [test] Try to link -latomic to provide atomics when available.

LGTM

Feb 24 2017, 1:30 PM

Feb 22 2017

jlpeyton accepted D30271: [OpenMP] Missing virtual destructor in KMPAffinity.

LGTM

Feb 22 2017, 2:51 PM

Feb 17 2017

jlpeyton committed rL295461: [stats] add stats-gathering for static_steal scheduling method.
[stats] add stats-gathering for static_steal scheduling method
Feb 17 2017, 9:18 AM

Feb 15 2017

jlpeyton committed rL295203: Enable yield cycle on Linux.
Enable yield cycle on Linux
Feb 15 2017, 9:31 AM
jlpeyton closed D29227: Enable yield cycle on Linux by committing rL295203: Enable yield cycle on Linux.
Feb 15 2017, 9:31 AM
jlpeyton accepted D29600: OpenMP 5.0 task reduction implementation.

LGTM

Feb 15 2017, 9:27 AM
jlpeyton accepted D29665: Add an option to bind initial thread at the start of application.

LGTM

Feb 15 2017, 9:20 AM

Jan 27 2017

jlpeyton committed rL293316: Cleanup: put i_maxmin members and ___kmp_size_type into traits_t.
Cleanup: put i_maxmin members and ___kmp_size_type into traits_t
Jan 27 2017, 10:20 AM
jlpeyton closed D28847: Cleanup: put i_maxmin members and ___kmp_size_type into traits_t by committing rL293316: Cleanup: put i_maxmin members and ___kmp_size_type into traits_t.
Jan 27 2017, 10:20 AM
jlpeyton committed rL293315: Printing OS thread id, when KMP_AFFINITY is set..
Printing OS thread id, when KMP_AFFINITY is set.
Jan 27 2017, 10:16 AM
jlpeyton closed D28873: Printing os thread id, when KMP_AFFINITY is set. by committing rL293315: Printing OS thread id, when KMP_AFFINITY is set..
Jan 27 2017, 10:15 AM
jlpeyton accepted D28873: Printing os thread id, when KMP_AFFINITY is set..

LGTM.

Jan 27 2017, 10:13 AM
jlpeyton committed rL293312: Fix performance issue incurred by removing monitor thread..
Fix performance issue incurred by removing monitor thread.
Jan 27 2017, 10:05 AM
jlpeyton closed D28906: Fix performance issue incurred by removing monitor thread. by committing rL293312: Fix performance issue incurred by removing monitor thread..
Jan 27 2017, 10:05 AM
jlpeyton accepted D28906: Fix performance issue incurred by removing monitor thread..

LGTM.

Jan 27 2017, 10:03 AM

Jan 20 2017

jlpeyton committed rL292678: Merging r292349:.
Merging r292349:
Jan 20 2017, 3:44 PM
jlpeyton committed rL292677: Merging r292348:.
Merging r292348:
Jan 20 2017, 3:42 PM

Jan 18 2017

jlpeyton committed rL292350: Use C++11 static_assert() for build asserts..
Use C++11 static_assert() for build asserts.
Jan 18 2017, 12:00 AM

Jan 17 2017

jlpeyton created D28847: Cleanup: put i_maxmin members and ___kmp_size_type into traits_t.
Jan 17 2017, 11:45 PM
jlpeyton committed rL292349: Fix memory error in case of reinit using kmp_set_defaults() for lock code..
Fix memory error in case of reinit using kmp_set_defaults() for lock code.
Jan 17 2017, 11:13 PM
jlpeyton committed rL292348: Fix small memory leak regarding __kmp_nested_proc_bind.
Fix small memory leak regarding __kmp_nested_proc_bind
Jan 17 2017, 10:51 PM

Jan 4 2017

jlpeyton accepted D28280: [CMake] Make openmp build under runtimes/.

LGTM

Jan 4 2017, 9:40 AM

Dec 14 2016

jlpeyton committed rL289739: Follow up to r289732: Update comments in source files to reference .cpp files.
Follow up to r289732: Update comments in source files to reference .cpp files
Dec 14 2016, 3:12 PM
jlpeyton committed rL289732: Change source files from .c to .cpp.
Change source files from .c to .cpp
Dec 14 2016, 2:50 PM
jlpeyton closed D26688: Change source file extension from .c to .cpp. by committing rL289732: Change source files from .c to .cpp.
Dec 14 2016, 2:49 PM

Dec 8 2016

jlpeyton accepted D26576: Support of mips & mips64 for openmprtl.

LGTM

Dec 8 2016, 12:27 AM

Nov 30 2016

jlpeyton added a comment to D26576: Support of mips & mips64 for openmprtl.

Could you add an entry in runtime/README.txt, www/README.txt, and www/index.html for MIPS in their corresponding sections on the topic?

Nov 30 2016, 11:50 AM

Nov 28 2016

jlpeyton committed rL288056: Fixed typo in kmp_process_deps trace output.
Fixed typo in kmp_process_deps trace output
Nov 28 2016, 12:20 PM
jlpeyton closed D27172: Fixed typo in kmp_process_deps trace output by committing rL288056: Fixed typo in kmp_process_deps trace output.
Nov 28 2016, 12:20 PM
jlpeyton accepted D27172: Fixed typo in kmp_process_deps trace output.

LGTM.

Nov 28 2016, 12:15 PM

Nov 21 2016

jlpeyton committed rL287561: Merging r285703:.
Merging r285703:
Nov 21 2016, 10:59 AM
jlpeyton committed rL287560: Merging r287551:.
Merging r287551:
Nov 21 2016, 10:57 AM
jlpeyton committed rL287559: Merging r285283:.
Merging r285283:
Nov 21 2016, 10:55 AM
jlpeyton committed rL287558: Merging r280138:.
Merging r280138:
Nov 21 2016, 10:53 AM
jlpeyton committed rL287557: Merging r278332:.
Merging r278332:
Nov 21 2016, 10:52 AM
jlpeyton added a comment to D26860: Fix for D25504 - segfault because of double free()-ing in task deps shutdown code..

Committed setting task->td_dephash = NULL without review: r287552

Nov 21 2016, 8:35 AM
jlpeyton committed rL287552: Set task->td_dephash to NULL after free.
Set task->td_dephash to NULL after free
Nov 21 2016, 8:35 AM
jlpeyton committed rL287551: Fix for D25504 - segfault because of double free()-ing in shutdown code..
Fix for D25504 - segfault because of double free()-ing in shutdown code.
Nov 21 2016, 8:29 AM
jlpeyton closed D26860: Fix for D25504 - segfault because of double free()-ing in task deps shutdown code. by committing rL287551: Fix for D25504 - segfault because of double free()-ing in shutdown code..
Nov 21 2016, 8:28 AM

Nov 18 2016

jlpeyton retitled D26860: Fix for D25504 - segfault because of double free()-ing in task deps shutdown code. from to Fix for D25504 - segfault because of double free()-ing in task deps shutdown code..
Nov 18 2016, 9:05 AM

Nov 14 2016

jlpeyton committed rL286892: Update stats-gathering code.
Update stats-gathering code
Nov 14 2016, 1:23 PM
jlpeyton closed D26361: Update stats-gathering code by committing rL286892: Update stats-gathering code.
Nov 14 2016, 1:23 PM
jlpeyton committed rL286890: Introduce dynamic affinity dispatch capabilities.
Introduce dynamic affinity dispatch capabilities
Nov 14 2016, 1:18 PM
jlpeyton closed D26356: Dynamic affinity dispatch capabilities. by committing rL286890: Introduce dynamic affinity dispatch capabilities.
Nov 14 2016, 1:18 PM
jlpeyton added inline comments to D26576: Support of mips & mips64 for openmprtl.
Nov 14 2016, 9:11 AM

Nov 7 2016

jlpeyton retitled D26361: Update stats-gathering code from to Update stats-gathering code.
Nov 7 2016, 12:09 PM
jlpeyton retitled D26356: Dynamic affinity dispatch capabilities. from to Dynamic affinity dispatch capabilities..
Nov 7 2016, 10:44 AM

Nov 1 2016

jlpeyton accepted D21196: Excluded untied tasks from task stealing constraint.
Nov 1 2016, 9:45 AM
jlpeyton added a comment to D21196: Excluded untied tasks from task stealing constraint.

Paul, can you accept the changes in here so we can close this revision?

Nov 1 2016, 9:41 AM
jlpeyton accepted D26182: Fixed problem introduced by part of https://reviews.llvm.org/D21196..

LGTM

Nov 1 2016, 9:19 AM

Oct 26 2016

jlpeyton committed rL285244: Fixing typos in __kmp_release_deps trace outputs.
Fixing typos in __kmp_release_deps trace outputs
Oct 26 2016, 2:56 PM
jlpeyton closed D25972: Fixing typos in __kmp_release_deps trace outputs by committing rL285244: Fixing typos in __kmp_release_deps trace outputs.
Oct 26 2016, 2:56 PM
jlpeyton committed rL285243: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.
Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true
Oct 26 2016, 2:52 PM
jlpeyton closed D26001: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true by committing rL285243: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.
Oct 26 2016, 2:52 PM
jlpeyton accepted D26001: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.

LGTM and thanks for the patch! Do I need to commit on your behalf?

Oct 26 2016, 12:19 PM
jlpeyton added a comment to D26001: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.

Inside kmp_os.h (around the PAGE_SIZE code), could you have:

#if KMP_OS_LINUX
# define KMP_GET_PAGE_SIZE() getpagesize()
#else
# define KMP_GET_PAGE_SIZE() PAGE_SIZE
#endif

And then const int page_size = KMP_GET_PAGE_SIZE() inside kmp_alloc.c and kmp_runtime.c

Oct 26 2016, 11:48 AM
jlpeyton added inline comments to D21196: Excluded untied tasks from task stealing constraint.
Oct 26 2016, 11:36 AM
jlpeyton accepted D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.

LGTM

Oct 26 2016, 10:29 AM

Oct 19 2016

jlpeyton added inline comments to D13072: [OpenMP] Enable ThreadSanitizer to check OpenMP programs.
Oct 19 2016, 3:11 PM

Oct 18 2016

jlpeyton closed D25505: Cleanup: fixed OpenMP 4.0 library build by committing rL284499: Fix OpenMP 4.0 library build.
Oct 18 2016, 10:48 AM
jlpeyton committed rL284499: Fix OpenMP 4.0 library build.
Fix OpenMP 4.0 library build
Oct 18 2016, 10:48 AM
jlpeyton accepted D25505: Cleanup: fixed OpenMP 4.0 library build.

LGTM

Oct 18 2016, 10:48 AM
jlpeyton accepted D25071: [openmp] fix a compile error on musl-libc.

LGTM too.

Oct 18 2016, 9:31 AM
jlpeyton committed rL284489: Mixed type atomic routines added for capture and update/capture reverse..
Mixed type atomic routines added for capture and update/capture reverse.
Oct 18 2016, 9:30 AM
jlpeyton closed D25275: Mixed type atomic routines added for capture and update/capture reverse. by committing rL284489: Mixed type atomic routines added for capture and update/capture reverse..
Oct 18 2016, 9:30 AM
jlpeyton accepted D25275: Mixed type atomic routines added for capture and update/capture reverse..

LGTM now.

Oct 18 2016, 9:27 AM

Oct 7 2016

jlpeyton added a comment to D25275: Mixed type atomic routines added for capture and update/capture reverse..

Olga, I think this patch accidently includes content from the previous atomic patch (r282509). Can you get rid of that and repost the patch?

Oct 7 2016, 11:31 AM
jlpeyton committed rL283577: Code cleanup for the runtime without monitor thread.
Code cleanup for the runtime without monitor thread
Oct 7 2016, 11:21 AM
jlpeyton closed D25102: Code cleanup for the runtime without monitor thread by committing rL283577: Code cleanup for the runtime without monitor thread.
Oct 7 2016, 11:21 AM
jlpeyton committed rL283576: Enable omp_get_schedule() to return static steal type..
Enable omp_get_schedule() to return static steal type.
Oct 7 2016, 11:10 AM
jlpeyton added a comment to D25071: [openmp] fix a compile error on musl-libc.

_GNU_SOURCE has to be defined for the char* version to be used (which we do by sending in -D_GNU_SOURCE during compilation). So have the #if be

#if defined(__GLIBC__) && defined(_GNU_SOURCE)
Oct 7 2016, 9:19 AM

Oct 5 2016

jlpeyton added a comment to D22144: [lit] add support for unsetting environment variable.

ping

Oct 5 2016, 2:04 PM

Sep 30 2016

jlpeyton committed rL282947: Insert missing checks for KMP_AFFINITY_CAPABLE() in affinity API..
Insert missing checks for KMP_AFFINITY_CAPABLE() in affinity API.
Sep 30 2016, 2:05 PM
jlpeyton accepted D25072: [test] Support 'lit' executable name.

LGTM

Sep 30 2016, 9:04 AM
jlpeyton committed rL282868: Fix incorrect OpenMP version in Fortran module..
Fix incorrect OpenMP version in Fortran module.
Sep 30 2016, 8:59 AM
jlpeyton closed D24761: Fixed incorrect OpenMP version in Fortran module. by committing rL282868: Fix incorrect OpenMP version in Fortran module..
Sep 30 2016, 8:59 AM
jlpeyton accepted D24959: [cmake] Fix for a bug https://llvm.org/bugs/show_bug.cgi?id=30489 "Cannot build with -DLIBOMP_FORTRAN_MODULES=True".

This is fine for now. I may come back to it though.

Sep 30 2016, 8:52 AM

Sep 27 2016

jlpeyton added a comment to D24959: [cmake] Fix for a bug https://llvm.org/bugs/show_bug.cgi?id=30489 "Cannot build with -DLIBOMP_FORTRAN_MODULES=True".

From what I found this code was never meant to run in parallel

I should clarify that by parallel I mean running make in parallel (make -j).

Sep 27 2016, 1:04 PM
jlpeyton committed rL282509: Mixed type atomic routines for unsigned integers..
Mixed type atomic routines for unsigned integers.
Sep 27 2016, 10:47 AM
jlpeyton closed D24756: Mixed type atomic routines for unsigned integers. by committing rL282509: Mixed type atomic routines for unsigned integers..
Sep 27 2016, 10:47 AM
jlpeyton committed rL282507: Disable monitor thread creation by default..
Disable monitor thread creation by default.
Sep 27 2016, 10:20 AM
jlpeyton closed D24739: Disable monitor thread creation by default. by committing rL282507: Disable monitor thread creation by default..
Sep 27 2016, 10:20 AM
jlpeyton accepted D24739: Disable monitor thread creation by default..

LGTM

Sep 27 2016, 10:14 AM