Page MenuHomePhabricator
People jlpeyton

jlpeyton (Jonathan Peyton)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 10 2015, 8:35 AM (424 w, 2 d)

Recent Activity
View All

Feb 17 2023

jlpeyton added inline comments to D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.
Feb 17 2023, 9:17 AM · Restricted Project, Restricted Project

Feb 13 2023

jlpeyton accepted D142582: [OpenMP] Add check for target allocator regardless of the availability of libmemkind.

LGTM

Feb 13 2023, 8:15 AM · Restricted Project, Restricted Project

Feb 8 2023

jlpeyton accepted D142247: Fix initialization of th_task_state on each thread on expanding hot teams..

LGTM

Feb 8 2023, 1:53 PM · Restricted Project, Restricted Project
jlpeyton added a comment to D143431: Switch the Windows OpenMP import library to import by name rather than ordinal..

Can you comment on the removal of kmp_import.cpp? Is it not needed anymore because Microsoft is moving away from the vcomp interface? If it is indeed unnecessary, then shouldn't we just remove the file entirely?

Feb 8 2023, 9:57 AM · Restricted Project, Restricted Project

Feb 7 2023

jlpeyton committed rG4ce32d2f12ec: [OpenMP][libomp] Remove false positive for memory sanitizer (authored by jlpeyton).
[OpenMP][libomp] Remove false positive for memory sanitizer
Feb 7 2023, 8:01 AM · Restricted Project, Restricted Project
jlpeyton closed D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.
Feb 7 2023, 8:00 AM · Restricted Project, Restricted Project

Feb 6 2023

jlpeyton reopened D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.
Feb 6 2023, 11:49 AM · Restricted Project, Restricted Project
jlpeyton updated the diff for D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.

Apologies for the breakage!

Feb 6 2023, 11:38 AM · Restricted Project, Restricted Project
jlpeyton committed rG402981ee25fe: [OpenMP][libomp] Remove false positive for memory sanitizer (authored by jlpeyton).
[OpenMP][libomp] Remove false positive for memory sanitizer
Feb 6 2023, 7:31 AM · Restricted Project, Restricted Project
jlpeyton closed D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.
Feb 6 2023, 7:30 AM · Restricted Project, Restricted Project
jlpeyton requested review of D143401: [OpenMP][libomp] Remove false positive for memory sanitizer.
Feb 6 2023, 7:19 AM · Restricted Project, Restricted Project

Feb 3 2023

jlpeyton committed rGc32022ad260a: [OpenMP][libomp] Fix CMake version symbol testing (authored by jlpeyton).
[OpenMP][libomp] Fix CMake version symbol testing
Feb 3 2023, 8:53 AM · Restricted Project, Restricted Project
jlpeyton closed D143200: [OpenMP][libomp] Fix CMake version symbol testing.
Feb 3 2023, 8:52 AM · Restricted Project, Restricted Project
jlpeyton updated the summary of D143200: [OpenMP][libomp] Fix CMake version symbol testing.
Feb 3 2023, 8:52 AM · Restricted Project, Restricted Project

Feb 2 2023

jlpeyton updated the diff for D143200: [OpenMP][libomp] Fix CMake version symbol testing.

Some linkers error out with a wildcard in both the global and local section under a version symbol. Removed the local part.

Feb 2 2023, 2:25 PM · Restricted Project, Restricted Project
jlpeyton closed D112270: [OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds.

Patch from D142152 was pushed.

Feb 2 2023, 12:27 PM · Restricted Project, Restricted Project
jlpeyton requested review of D143200: [OpenMP][libomp] Fix CMake version symbol testing.
Feb 2 2023, 9:40 AM · Restricted Project, Restricted Project
jlpeyton accepted D143004: [OpenMP] Guard the code if ITT is not used.

LGTM

Feb 2 2023, 9:22 AM · Restricted Project, Restricted Project

Jan 20 2023

jlpeyton accepted D142172: [OpenMP] Only test kmp_atomic_float10_max_min.c on X86.

LGTM

Jan 20 2023, 7:44 AM · Restricted Project, Restricted Project

Jan 19 2023

jlpeyton committed rG3a362a9f38b9: [OpenMP][libomp] Insert correct HWLOC version guards (authored by ggouaillardet).
[OpenMP][libomp] Insert correct HWLOC version guards
Jan 19 2023, 12:32 PM · Restricted Project, Restricted Project
jlpeyton closed D142152: [OpenMP][libomp] Insert correct HWLOC version guards.
Jan 19 2023, 12:32 PM · Restricted Project, Restricted Project
jlpeyton added a comment to D112270: [OpenMP][libomp] Enable HWLOC topology detection of multiple CPU kinds.

openmp/runtime/src/kmp_affinity.cpp:1611 has to be guarded by version check as well.

Jan 19 2023, 12:07 PM · Restricted Project, Restricted Project
jlpeyton updated subscribers of D142036: [OpenMP] Add HWLOC compatibility check.

Ok I've made https://reviews.llvm.org/D142152 which combines @ggouaillardet 's patch with the other needed guard around line 1611 as you noted.

Jan 19 2023, 12:06 PM · Restricted Project, Restricted Project
jlpeyton requested review of D142152: [OpenMP][libomp] Insert correct HWLOC version guards.
Jan 19 2023, 12:03 PM · Restricted Project, Restricted Project
jlpeyton added a comment to D142036: [OpenMP] Add HWLOC compatibility check.

Sorry! I just realized there's another patch that solves this problem by inserting the proper HWLOC version checks in the code mentioned here: https://reviews.llvm.org/D112270. I'd rather go with that approach since it allows older HWLOC versions.

Jan 19 2023, 9:38 AM · Restricted Project, Restricted Project

Jan 18 2023

jlpeyton added inline comments to D142036: [OpenMP] Add HWLOC compatibility check.
Jan 18 2023, 12:16 PM · Restricted Project, Restricted Project
jlpeyton committed rG2aea0a9de093: [OpenMP][libomp] Switch Intel topology type values: module, tile (authored by jlpeyton).
[OpenMP][libomp] Switch Intel topology type values: module, tile
Jan 18 2023, 10:12 AM · Restricted Project, Restricted Project
jlpeyton committed rGf31192253541: [OpenMP][libomp] Fix stats-gathering for new MSVC sections API (authored by jlpeyton).
[OpenMP][libomp] Fix stats-gathering for new MSVC sections API
Jan 18 2023, 10:02 AM · Restricted Project, Restricted Project
jlpeyton closed D139867: [OpenMP][libomp] Fix stats-gathering for new MSVC sections API.
Jan 18 2023, 10:02 AM · Restricted Project, Restricted Project

Jan 16 2023

jlpeyton committed rGf4cce0f47b3e: [OpenMP][libomp] Add topology information to thread structure (authored by jlpeyton).
[OpenMP][libomp] Add topology information to thread structure
Jan 16 2023, 9:05 PM · Restricted Project, Restricted Project
jlpeyton closed D139854: [OpenMP][libomp] Add topology information to thread structure.
Jan 16 2023, 9:04 PM · Restricted Project, Restricted Project
jlpeyton accepted D141889: [OpenMP] Fix the wrong format string used in `__kmpc_error`.

LGTM

Jan 16 2023, 8:50 PM · Restricted Project, Restricted Project
jlpeyton committed rG0aa5aebd0ace: [OpenMP][libomp] Fix macOS 12 library destruction (authored by jlpeyton).
[OpenMP][libomp] Fix macOS 12 library destruction
Jan 16 2023, 8:43 PM · Restricted Project, Restricted Project
jlpeyton closed D139857: [OpenMP][libomp] Fix macOS 12 library destruction.
Jan 16 2023, 8:43 PM · Restricted Project, Restricted Project

Jan 10 2023

jlpeyton accepted D139960: [OpenMP] Fix for smaller team sizes inside teams construct.

LGTM

Jan 10 2023, 7:58 AM · Restricted Project, Restricted Project

Dec 13 2022

jlpeyton accepted D138933: [OpenMP] Add API for pinned memory.

LGTM

Dec 13 2022, 1:10 PM · Restricted Project, Restricted Project
jlpeyton added inline comments to D138933: [OpenMP] Add API for pinned memory.
Dec 13 2022, 11:51 AM · Restricted Project, Restricted Project

Dec 12 2022

jlpeyton accepted D139116: [OpenMP] Refactoring: Move teams forking and serial region forking to separate functions..

LGTM

Dec 12 2022, 2:11 PM · Restricted Project, Restricted Project
jlpeyton requested review of D139867: [OpenMP][libomp] Fix stats-gathering for new MSVC sections API.
Dec 12 2022, 11:28 AM · Restricted Project, Restricted Project
jlpeyton requested review of D139857: [OpenMP][libomp] Fix macOS 12 library destruction.
Dec 12 2022, 9:37 AM · Restricted Project, Restricted Project
jlpeyton requested review of D139854: [OpenMP][libomp] Add topology information to thread structure.
Dec 12 2022, 9:26 AM · Restricted Project, Restricted Project
jlpeyton added inline comments to D138933: [OpenMP] Add API for pinned memory.
Dec 12 2022, 8:35 AM · Restricted Project, Restricted Project
jlpeyton added inline comments to D139116: [OpenMP] Refactoring: Move teams forking and serial region forking to separate functions..
Dec 12 2022, 6:48 AM · Restricted Project, Restricted Project

Dec 6 2022

jlpeyton committed rGfef73b81e9a7: [OpenMP][libomp] Cleanup version script and exported symbols (authored by jlpeyton).
[OpenMP][libomp] Cleanup version script and exported symbols
Dec 6 2022, 6:34 AM · Restricted Project, Restricted Project
jlpeyton closed D138049: [OpenMP][libomp] Cleanup version script and exported symbols.
Dec 6 2022, 6:34 AM · Restricted Project, Restricted Project

Nov 28 2022

jlpeyton accepted D137772: [openmp] [test] Set __COMPAT_LAYER=RunAsInvoker when running tests on Windows.

LGTM

Nov 28 2022, 8:24 AM · Restricted Project, Restricted Project
jlpeyton accepted D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info.

Sounds good to me.

Nov 28 2022, 6:35 AM · Restricted Project, Restricted Project
jlpeyton added inline comments to D137748: [openmp] [test] Fix data structure mismatches for tests that define kmp_depend_info.
Nov 28 2022, 6:27 AM · Restricted Project, Restricted Project

Nov 22 2022

jlpeyton added a comment to D138049: [OpenMP][libomp] Cleanup version script and exported symbols.
In D138049#3939286, @MaskRay wrote:

Very appreciate your and jhuber6's efforts to fix the symbol versioning issues for OpenMP!

Nov 22 2022, 12:13 PM · Restricted Project, Restricted Project

Nov 17 2022

jlpeyton accepted D137749: [openmp] [test] Unbreak tests that rely on hidden_helper_task on Windows.

Thanks for the fixes! LGTM.

Nov 17 2022, 9:26 AM · Restricted Project, Restricted Project

Nov 16 2022

jlpeyton added a comment to D137749: [openmp] [test] Unbreak tests that rely on hidden_helper_task on Windows.

A few suggestions

Nov 16 2022, 2:13 PM · Restricted Project, Restricted Project
jlpeyton accepted D138113: [openmp] [cmake] Fix detecting aarch64 in standalone MSVC builds.

LGTM

Nov 16 2022, 8:48 AM · Restricted Project, Restricted Project

Nov 15 2022

jlpeyton requested review of D138049: [OpenMP][libomp] Cleanup version script and exported symbols.
Nov 15 2022, 11:16 AM · Restricted Project, Restricted Project

Nov 2 2022

jlpeyton committed rG96696b882bdb: [OpenMP][libomp] Fix disabled affinity (authored by jlpeyton).
[OpenMP][libomp] Fix disabled affinity
Nov 2 2022, 1:38 PM · Restricted Project, Restricted Project
jlpeyton closed D137176: [OpenMP][libomp] Fix disabled affinity.
Nov 2 2022, 1:38 PM · Restricted Project, Restricted Project

Nov 1 2022

jlpeyton added a comment to D137176: [OpenMP][libomp] Fix disabled affinity.

@mgorny , This patch should fix the issues you were seeing after https://reviews.llvm.org/D135113. Can you confirm?

Nov 1 2022, 10:37 AM · Restricted Project, Restricted Project
jlpeyton requested review of D137176: [OpenMP][libomp] Fix disabled affinity.
Nov 1 2022, 10:35 AM · Restricted Project, Restricted Project

Oct 28 2022

jlpeyton committed rG7a9643fd2a07: [OpenMP][libomp] Add hidden helper affinity (authored by jlpeyton).
[OpenMP][libomp] Add hidden helper affinity
Oct 28 2022, 1:22 PM · Restricted Project, Restricted Project
jlpeyton committed rGb03d67f7f58b: [OpenMP][libomp] Make affinity warnings parameterized (authored by jlpeyton).
[OpenMP][libomp] Make affinity warnings parameterized
Oct 28 2022, 1:22 PM · Restricted Project, Restricted Project
jlpeyton committed rG174502fc14d0: [OpenMP][libomp] Parameterize affinity functions (authored by jlpeyton).
[OpenMP][libomp] Parameterize affinity functions
Oct 28 2022, 1:22 PM · Restricted Project, Restricted Project
jlpeyton closed D135113: [OpenMP][libomp] Add hidden helper affinity.
Oct 28 2022, 1:21 PM · Restricted Project, Restricted Project
jlpeyton closed D135112: [OpenMP][libomp] Make affinity warnings parameterized.
Oct 28 2022, 1:21 PM · Restricted Project, Restricted Project
jlpeyton closed D135109: [OpenMP][libomp] Parameterize affinity initialization.
Oct 28 2022, 1:21 PM · Restricted Project, Restricted Project

Oct 25 2022

jlpeyton added a comment to D135113: [OpenMP][libomp] Add hidden helper affinity.

ping. This is the third patch set in a series of three to introduce hidden helper affinity.

Oct 25 2022, 10:35 AM · Restricted Project, Restricted Project

Oct 19 2022

jlpeyton accepted D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..

LGTM

Oct 19 2022, 7:31 AM · Restricted Project, Restricted Project

Oct 17 2022

jlpeyton added inline comments to D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..
Oct 17 2022, 9:12 AM · Restricted Project, Restricted Project

Oct 13 2022

jlpeyton added a comment to D135795: Avoid exporting 80-bit fp functions for architectures other than Intel..

Just a few comments.

Oct 13 2022, 9:17 AM · Restricted Project, Restricted Project

Oct 3 2022

jlpeyton requested review of D135113: [OpenMP][libomp] Add hidden helper affinity.
Oct 3 2022, 3:07 PM · Restricted Project, Restricted Project
jlpeyton requested review of D135112: [OpenMP][libomp] Make affinity warnings parameterized.
Oct 3 2022, 3:04 PM · Restricted Project, Restricted Project
jlpeyton requested review of D135109: [OpenMP][libomp] Parameterize affinity initialization.
Oct 3 2022, 3:02 PM · Restricted Project, Restricted Project
jlpeyton committed rGf8d081c1a51c: [OpenMP][libomp] Allow unused-but-set warnings (authored by jlpeyton).
[OpenMP][libomp] Allow unused-but-set warnings
Oct 3 2022, 8:26 AM · Restricted Project, Restricted Project
jlpeyton closed D133528: [OpenMP][libomp] Allow unused-but-set warnings.
Oct 3 2022, 8:26 AM · Restricted Project, Restricted Project

Sep 8 2022

jlpeyton committed rGe5ac98fa0150: [OpenMP][libomp] Cleanup __kmpc_flush() code (authored by jlpeyton).
[OpenMP][libomp] Cleanup __kmpc_flush() code
Sep 8 2022, 2:17 PM · Restricted Project, Restricted Project
jlpeyton closed D130928: [OpenMP][libomp] Cleanup __kmpc_flush() code.
Sep 8 2022, 2:17 PM · Restricted Project, Restricted Project
jlpeyton requested review of D133528: [OpenMP][libomp] Allow unused-but-set warnings.
Sep 8 2022, 2:12 PM · Restricted Project, Restricted Project

Aug 11 2022

jlpeyton committed rG56f36f85e029: [OpenMP][OMPT] Fix memory leak when using GCC compatibility code (authored by jlpeyton).
[OpenMP][OMPT] Fix memory leak when using GCC compatibility code
Aug 11 2022, 1:27 PM · Restricted Project, Restricted Project
jlpeyton closed D131690: [OpenMP][OMPT] Fix memory leak when using serialized GCC compatibility code.
Aug 11 2022, 1:26 PM · Restricted Project, Restricted Project
jlpeyton updated the diff for D131690: [OpenMP][OMPT] Fix memory leak when using serialized GCC compatibility code.

My mistake here. Uploading diff with full context for the record.

Aug 11 2022, 1:25 PM · Restricted Project, Restricted Project
jlpeyton requested review of D131690: [OpenMP][OMPT] Fix memory leak when using serialized GCC compatibility code.
Aug 11 2022, 9:19 AM · Restricted Project, Restricted Project

Aug 10 2022

jlpeyton added a comment to D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.

ping

Aug 10 2022, 2:36 PM · Restricted Project, Restricted Project

Aug 3 2022

jlpeyton added inline comments to D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.
Aug 3 2022, 12:35 PM · Restricted Project, Restricted Project
jlpeyton updated the diff for D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.

Addressing comments

Aug 3 2022, 12:32 PM · Restricted Project, Restricted Project

Aug 2 2022

jlpeyton committed rG9cf6511bff97: [OpenMP][libomp] Detect if test compiler has omp.h (authored by jlpeyton).
[OpenMP][libomp] Detect if test compiler has omp.h
Aug 2 2022, 3:08 PM · Restricted Project, Restricted Project
jlpeyton closed D131000: [OpenMP][libomp] Detect if test compiler has omp.h.
Aug 2 2022, 3:08 PM · Restricted Project, Restricted Project
jlpeyton updated the summary of D131000: [OpenMP][libomp] Detect if test compiler has omp.h.
Aug 2 2022, 3:07 PM · Restricted Project, Restricted Project
jlpeyton added a comment to D131000: [OpenMP][libomp] Detect if test compiler has omp.h.
In D131000#3694188, @Meinersbur wrote:

Rather than disabling the test, did you consider adding an -I${CMAKE_CURRENT_BINARY_DIR}/runtime/src (where omp.h resides) to the clang test flags? Even if there is an omp.h already on the system, libomp's header should be used instead since it may contain new symbols not yet present in the system's omp.h. It might even be -isystem to treat it like a system header.

Aug 2 2022, 11:53 AM · Restricted Project, Restricted Project
jlpeyton added a comment to D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.

I've created https://reviews.llvm.org/D131000 to address you issue specifically. It's just the same patch as before. I will leave this one open for review.

Aug 2 2022, 10:46 AM · Restricted Project, Restricted Project
jlpeyton requested review of D131000: [OpenMP][libomp] Detect if test compiler has omp.h.
Aug 2 2022, 10:45 AM · Restricted Project, Restricted Project
jlpeyton updated the summary of D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.
Aug 2 2022, 10:44 AM · Restricted Project, Restricted Project
jlpeyton added a comment to D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.

@mgorny , I thought the fundamental issue, as noted by @Meinersbur, was the newly built (but not installed) clang's inability to find an accessible omp.h. You then use the newly built clang to standalone build OpenMP.

Aug 2 2022, 9:27 AM · Restricted Project, Restricted Project

Aug 1 2022

jlpeyton updated the diff for D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.

Updated patch to copy headers to clang build directory so it can find omp.h and omp-tools.h before install phase.

Aug 1 2022, 7:20 PM · Restricted Project, Restricted Project
jlpeyton requested review of D130928: [OpenMP][libomp] Cleanup __kmpc_flush() code.
Aug 1 2022, 12:21 PM · Restricted Project, Restricted Project
jlpeyton requested review of D130926: [OpenMP][libomp] Copy OpenMP headers to clang build directory.
Aug 1 2022, 11:56 AM · Restricted Project, Restricted Project
jlpeyton accepted D130825: [openmp] [test] Fix prepending config.library_dir to LD_LIBRARY_PATH.

LGTM

Aug 1 2022, 9:35 AM · Restricted Project, Restricted Project

Jul 19 2022

jlpeyton committed rG40ce65b5b225: [OpenMP][libomp] Fix affinity warnings and unify under one macro (authored by jlpeyton).
[OpenMP][libomp] Fix affinity warnings and unify under one macro
Jul 19 2022, 11:11 AM · Restricted Project, Restricted Project
jlpeyton closed D125991: [OpenMP][libomp] Fix affinity warnings and unify under one macro.
Jul 19 2022, 11:11 AM · Restricted Project, Restricted Project
jlpeyton committed rG17dcde5f1bfe: [OpenMP][libomp] Allow reset affinity mask after parallel (authored by AndreyChurbanov).
[OpenMP][libomp] Allow reset affinity mask after parallel
Jul 19 2022, 11:10 AM · Restricted Project, Restricted Project
jlpeyton closed D125993: [OpenMP][libomp] Allow reset affinity mask after parallel.
Jul 19 2022, 11:10 AM · Restricted Project, Restricted Project
jlpeyton committed rG28c8da29654d: [OpenMP][libomp] Fix fallthrough attribute detection for Intel compilers (authored by jlpeyton).
[OpenMP][libomp] Fix fallthrough attribute detection for Intel compilers
Jul 19 2022, 11:05 AM · Restricted Project, Restricted Project
jlpeyton closed D126001: [OpenMP][libomp] Fix fallthrough attribute detection for Intel compilers.
Jul 19 2022, 11:04 AM · Restricted Project, Restricted Project