Page MenuHomePhabricator

AndreyChurbanov (Andrey Churbanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 16 2015, 7:54 AM (248 w, 1 d)

Recent Activity

Wed, Jan 15

AndreyChurbanov added a comment to D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support.

Having a copy function per type allows us to reuse it, otherwise we have one copy function per static task location (at worst). Either works for me I think.

I also would be OK with either option.
But note that using per-type functions will require more additions to the interface, like:

(..., num_objects, array_of_copy_wrappers, array_of_desctuctor_wrappers, array_of_obj_offsets).

Then the library can iterate over objects to copy-construct them, then iterate to destroy them after the task is complete. Without any possibility of inlining of any wrappers.

Wed, Jan 15, 10:22 AM · Restricted Project, Restricted Project

Tue, Jan 14

AndreyChurbanov added a comment to D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support.

the task create and task issue step are
conceptually not separated anymore as it is

I don't think this can work reliably. Because not all C++ objects can be mem-copied.
E.g. an object can keep its own address or reference, and mem-copy will make it broken.
This could be fixed by generating (optional) thunk routine which would create all needed objects
in the library-allocated space, and similar routine which would destroy all the created objects.

Tue, Jan 14, 4:00 AM · Restricted Project, Restricted Project

Nov 27 2019

AndreyChurbanov committed rGbd2fb41c2dd5: [openmp] Fixed nonmonotonic schedule when #threads > #chunks in a loop. (authored by AndreyChurbanov).
[openmp] Fixed nonmonotonic schedule when #threads > #chunks in a loop.
Nov 27 2019, 4:29 AM
AndreyChurbanov closed D70713: Fixed nonmonotonic dynamic schedule for case when #threads > #chunks in a loop..
Nov 27 2019, 4:29 AM · Restricted Project

Nov 26 2019

AndreyChurbanov updated the summary of D70713: Fixed nonmonotonic dynamic schedule for case when #threads > #chunks in a loop..
Nov 26 2019, 5:19 AM · Restricted Project
AndreyChurbanov created D70713: Fixed nonmonotonic dynamic schedule for case when #threads > #chunks in a loop..
Nov 26 2019, 5:19 AM · Restricted Project
AndreyChurbanov committed rG5f8b8d282048: [openmp] Recognise ARMv7ve machine arch. (authored by AndreyChurbanov).
[openmp] Recognise ARMv7ve machine arch.
Nov 26 2019, 3:39 AM
AndreyChurbanov closed D68543: openmp: Recognise ARMv7ve machine arch.
Nov 26 2019, 3:39 AM · Restricted Project

Nov 25 2019

AndreyChurbanov accepted D68543: openmp: Recognise ARMv7ve machine arch.

I am not an ARM expert, but don't see any problems with checking extra define here.

Nov 25 2019, 9:58 AM · Restricted Project

Nov 19 2019

AndreyChurbanov committed rG3a76b8a538c0: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD. (authored by AndreyChurbanov).
Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.
Nov 19 2019, 8:52 AM
AndreyChurbanov closed D67190: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.
Nov 19 2019, 8:52 AM · Restricted Project

Nov 18 2019

AndreyChurbanov accepted D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

LGTM

Nov 18 2019, 8:27 AM · Restricted Project

Nov 13 2019

AndreyChurbanov added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

I will try removing __kmp_internal_end_fini with a test that __kmp_internal_end_atexit is still called.

Nov 13 2019, 11:00 AM · Restricted Project
AndreyChurbanov added a comment to D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

I will contact ittnotify owners just in case. So that we might have lesser burden with possible future updates of this third-party code.

Thanks. Is that open-source or internal to Intel?

It is open-sourced many years ago, now under BSD license; IINM, it can be found at https://github.com/intel/IntelSEAPI/tree/master/ittnotify (though we don't update it regularly without real need);
and it is also part of Intel Tools products (e.g. Amplifier, etc.).

They already agreed to upstream the last change (removal of const). Not sure it will be possible to upstream .c --> .cpp, because they depend on many other customers. But I think this is minor issue for us.

One mode detail - the link I provided is not an "official" location of ittnotify, but just one more usage of it by SEAPI project. The updates of the ittnotify itself were published sporadically. And it will get its own stable location on githab soon (the publishing is in process).

Nov 13 2019, 7:12 AM · Restricted Project, Restricted Project

Nov 7 2019

AndreyChurbanov added a comment to D69927: [OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini.

Looks acceptable to me. As well as removing the kmp_internal_end_fini symbol at all, as it duplicates the functionality of kmp_internal_end_dtor which has attribute "destructor". I am OK with either solution, would be good to hear others opinion.

Nov 7 2019, 7:04 AM · Restricted Project

Oct 30 2019

AndreyChurbanov committed rG27f6eedc57f9: Enable OpenBSD support. (authored by AndreyChurbanov).
Enable OpenBSD support.
Oct 30 2019, 2:40 AM

Oct 25 2019

AndreyChurbanov committed rGbe29d9285487: OpenMP Tasks dependencies hash re-sizing fixed. (authored by AndreyChurbanov).
OpenMP Tasks dependencies hash re-sizing fixed.
Oct 25 2019, 6:08 AM
AndreyChurbanov closed D68036: Tasks dependencies hash re-sizing fixed.
Oct 25 2019, 6:08 AM · Restricted Project

Oct 8 2019

AndreyChurbanov added a comment to D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

Jan,
you may want to ask for D68045 landing there directly, as compiler-rt is a different project which I don't work on.

Oct 8 2019, 5:56 AM · Restricted Project
AndreyChurbanov committed rGca2973bb2024: Don't assume Type from `readelf -d` has parentheses (authored by AndreyChurbanov).
Don't assume Type from `readelf -d` has parentheses
Oct 8 2019, 5:47 AM
AndreyChurbanov closed D68053: [OpenMP] Don't assume Type from `readelf -d` has parentheses.
Oct 8 2019, 5:46 AM · Restricted Project
AndreyChurbanov committed rGf34271d88690: Don't link libm with -Wl,--as-needed on FreeBSD (authored by AndreyChurbanov).
Don't link libm with -Wl,--as-needed on FreeBSD
Oct 8 2019, 5:29 AM
AndreyChurbanov closed D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.
Oct 8 2019, 5:28 AM · Restricted Project

Sep 27 2019

AndreyChurbanov accepted D67190: Fix openmp on PowerPC64-BE-ELFv2 ABI on FreeBSD.

LGTM

Sep 27 2019, 7:13 AM · Restricted Project
AndreyChurbanov accepted D68053: [OpenMP] Don't assume Type from `readelf -d` has parentheses.

LGTM

Sep 27 2019, 6:59 AM · Restricted Project
AndreyChurbanov accepted D68051: [OpenMP] Don't link libm with -Wl,--as-needed on FreeBSD.

LGTM

Sep 27 2019, 6:07 AM · Restricted Project

Sep 25 2019

AndreyChurbanov created D68036: Tasks dependencies hash re-sizing fixed.
Sep 25 2019, 10:10 AM · Restricted Project
AndreyChurbanov committed rGde44f434e828: fixed test: eliminated race condition which might cause deadlock (authored by AndreyChurbanov).
fixed test: eliminated race condition which might cause deadlock
Sep 25 2019, 8:28 AM
AndreyChurbanov committed rGa1639b9bba7c: Enable tasks dependencies hashmaps resizing. (authored by AndreyChurbanov).
Enable tasks dependencies hashmaps resizing.
Sep 25 2019, 7:40 AM

Sep 16 2019

AndreyChurbanov accepted D67447: Enable tasks dependencies hashmaps resizing.
Sep 16 2019, 9:11 AM · Restricted Project, Restricted Project

Sep 4 2019

AndreyChurbanov accepted D66292: [OpenMP] Change initialization of __kmp_global.

LGTM

Sep 4 2019, 6:42 AM · Restricted Project, Restricted Project

Sep 3 2019

AndreyChurbanov added a comment to D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

BTW, there is also workaround without runtime patching, - set KMP_TEAMS_THREAD_LIMIT to the same value as OMP_THREAD_LIMIT. This avoids runtime segfault with old library.

Sep 3 2019, 4:26 AM · Restricted Project, Restricted Project

Sep 2 2019

AndreyChurbanov added a comment to D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..

Will this fix make it to the 9.0 release? Thank you!

Sep 2 2019, 8:24 AM · Restricted Project, Restricted Project

Aug 16 2019

AndreyChurbanov created D66351: Force runtime to honor nthreads-var and thread-limit-var inside the teams construct on host..
Aug 16 2019, 7:44 AM · Restricted Project, Restricted Project

Aug 12 2019

AndreyChurbanov committed rG5eec1a9d324f: Cleanup unused variable. (authored by AndreyChurbanov).
Cleanup unused variable.
Aug 12 2019, 5:39 AM

Aug 7 2019

AndreyChurbanov created D65885: Cleanup unused variable..
Aug 7 2019, 8:25 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D65870: [OpenMP] Remove 'unnecessary parentheses'.
Aug 7 2019, 7:48 AM · Restricted Project, Restricted Project

Aug 6 2019

AndreyChurbanov added a comment to D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

For the correct solution, could you point me to code that uses the dll_path_ptr member? Given that there were no problem with static const char dll_path[PATH_MAX] I guess it never assigns to *dll_path_ptr, but then I don't fully understand why it needs a pointer to a pointer...

Aug 6 2019, 5:46 AM · Restricted Project, Restricted Project

Jul 29 2019

AndreyChurbanov added a comment to D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

I will contact ittnotify owners just in case. So that we might have lesser burden with possible future updates of this third-party code.

Thanks. Is that open-source or internal to Intel?

Jul 29 2019, 7:54 AM · Restricted Project, Restricted Project

Jul 26 2019

AndreyChurbanov accepted D65285: [OpenMP] Rename last file to cpp and remove LIBOMP_CFLAGS.

I will contact ittnotify owners just in case. So that we might have lesser burden with possible future updates of this third-party code.

Jul 26 2019, 5:03 AM · Restricted Project, Restricted Project

Jul 25 2019

AndreyChurbanov accepted D65284: [OpenMP] Fix build of stubs library.

LGTM (I'd treat this as NFC :).

Jul 25 2019, 9:06 AM · Restricted Project, Restricted Project

Jul 16 2019

AndreyChurbanov accepted D64625: [OpenMP] Move header inclusion out of 'extern "C"'.

LGTM

Jul 16 2019, 9:11 AM · Restricted Project

Jul 12 2019

AndreyChurbanov added inline comments to D64534: Remove OMP spec versioning.
Jul 12 2019, 6:56 AM · Restricted Project, Restricted Project

Jul 10 2019

AndreyChurbanov committed rG28f44040cc43: NFC: fixed typo #ifdef --> #if to allow macro set to 0 work correctly (authored by AndreyChurbanov).
NFC: fixed typo #ifdef --> #if to allow macro set to 0 work correctly
Jul 10 2019, 8:12 AM

Jul 2 2019

AndreyChurbanov committed rGa23806e67a2d: Create a runtime option to disable task throttling. (authored by AndreyChurbanov).
Create a runtime option to disable task throttling.
Jul 2 2019, 8:12 AM
AndreyChurbanov accepted D63196: Create a runtime option to disable task throttling.

LGTM

Jul 2 2019, 8:05 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rGe7b2c64a6e4c: Cleanup of unused code (authored by AndreyChurbanov).
Cleanup of unused code
Jul 2 2019, 6:46 AM

Jun 27 2019

AndreyChurbanov requested changes to D63196: Create a runtime option to disable task throttling.

Of cause you are free to choose your own test, or simply extend existing test(s).

Jun 27 2019, 6:01 AM · Restricted Project, Restricted Project

Jun 26 2019

AndreyChurbanov committed rGb7e6c37efead: Fixed memory use-after-free problem. (authored by AndreyChurbanov).
Fixed memory use-after-free problem.
Jun 26 2019, 11:13 AM
AndreyChurbanov added a comment to D63196: Create a runtime option to disable task throttling.

Yes, adding tests would be great. Simplest thing to do is to extend existing tests with throttling on/off, I think.

Jun 26 2019, 7:12 AM · Restricted Project, Restricted Project

Jun 25 2019

AndreyChurbanov accepted D63196: Create a runtime option to disable task throttling.

sorry for the delay.

Jun 25 2019, 5:25 AM · Restricted Project, Restricted Project

Jun 21 2019

AndreyChurbanov updated the diff for D63599: Fixed memory use-after-free problem..

Covered more cases caused memory leak (when target-teams region is followed by parallel with bigger number of threads) and use-after-free problem (when nested hot teams requested via KMP_HOT_TEAMS_MAX_LEVEL=2 and num_teams is bigger than 1). The leak is fixed by freeing CG structure when worker threads inherit master's CG but had earlier non-NULL CG. Use-after-free fixed by making one more freeing of CG conditional (in __kmp_free_team routine).

Jun 21 2019, 6:56 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D63599: Fixed memory use-after-free problem..
Jun 21 2019, 6:44 AM · Restricted Project, Restricted Project

Jun 20 2019

AndreyChurbanov created D63599: Fixed memory use-after-free problem..
Jun 20 2019, 6:25 AM · Restricted Project, Restricted Project

Jun 19 2019

AndreyChurbanov committed rG405037c4e62a: New implementation of OpenMP 5.0 detached tasks. (authored by AndreyChurbanov).
New implementation of OpenMP 5.0 detached tasks.
Jun 19 2019, 6:21 AM
AndreyChurbanov added a comment to D62485: New implementation of OpenMP 5.0 detached tasks..

Are there any plans to add the code for the appropriate OMPT callbacks?

Jun 19 2019, 6:17 AM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D62485: New implementation of OpenMP 5.0 detached tasks..

Addressed Joachim's comments.

Jun 19 2019, 6:06 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D62485: New implementation of OpenMP 5.0 detached tasks..
Jun 19 2019, 6:06 AM · Restricted Project, Restricted Project

Jun 5 2019

AndreyChurbanov committed rGd47f5488cf02: Added propagation of not big initial stack size of master thread to workers. (authored by AndreyChurbanov).
Added propagation of not big initial stack size of master thread to workers.
Jun 5 2019, 9:14 AM
AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Review comments addressed:

  • removed printf("passed") when the test is skipped;
  • changed default size to lower/upper limit for consistency during size adjustment.
Jun 5 2019, 7:51 AM · Restricted Project, Restricted Project

Jun 4 2019

AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Addressed Johannes' comment. At the same time I've reduced the upper bound of the size to be propagated to 64MB (from initial 256MB), because with this change more applications will be affected (those require big stack for master and small stack for workers).

Jun 4 2019, 6:18 AM · Restricted Project, Restricted Project

Jun 3 2019

AndreyChurbanov committed rG3f786dab0eb1: Fixed build warning with -DLIBOMP_USE_HWLOC=1 (authored by AndreyChurbanov).
Fixed build warning with -DLIBOMP_USE_HWLOC=1
Jun 3 2019, 7:20 AM

May 31 2019

AndreyChurbanov added inline comments to D62488: Added propagation of not big initial stack size of master thread to workers..
May 31 2019, 9:02 AM · Restricted Project, Restricted Project
AndreyChurbanov added a comment to D62488: Added propagation of not big initial stack size of master thread to workers..

Regarding test system,

May 31 2019, 8:15 AM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Test fixed: added "return 1" on possible failure of the test.

May 31 2019, 8:12 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D62488: Added propagation of not big initial stack size of master thread to workers..
May 31 2019, 8:08 AM · Restricted Project, Restricted Project
AndreyChurbanov retitled D62488: Added propagation of not big initial stack size of master thread to workers. from Fix for https://bugs.llvm.org/show_bug.cgi?id=26540. to Added propagation of not big initial stack size of master thread to workers..
May 31 2019, 7:43 AM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Moved declaration of rlim under #if to avoid "unused variable" warning.

May 31 2019, 6:41 AM · Restricted Project, Restricted Project

May 29 2019

AndreyChurbanov accepted D62431: Fix OMP_TARGET_OFFLOAD parsing.

LGTM

May 29 2019, 1:11 AM · Restricted Project

May 28 2019

AndreyChurbanov added a comment to D62431: Fix OMP_TARGET_OFFLOAD parsing.

By negative test I meant the wrong value is ignored and the default used instead. I don't think we need to check library warnings.

May 28 2019, 9:33 AM · Restricted Project
AndreyChurbanov requested changes to D62431: Fix OMP_TARGET_OFFLOAD parsing.

Probably test case worth adding. Or even two, - one negative with something like "mandatorynot" value, another positive (we do have internal getter routine for the target-offload-var ICV).

May 28 2019, 9:19 AM · Restricted Project
AndreyChurbanov accepted D62431: Fix OMP_TARGET_OFFLOAD parsing.

LGTM

May 28 2019, 7:40 AM · Restricted Project

May 27 2019

AndreyChurbanov created D62488: Added propagation of not big initial stack size of master thread to workers..
May 27 2019, 9:39 AM · Restricted Project, Restricted Project
AndreyChurbanov created D62485: New implementation of OpenMP 5.0 detached tasks..
May 27 2019, 6:37 AM · Restricted Project, Restricted Project

May 23 2019

AndreyChurbanov created D62332: Fixed build warning with -DLIBOMP_USE_HWLOC=1.
May 23 2019, 11:12 AM · Restricted Project, Restricted Project

May 22 2019

AndreyChurbanov committed rG184ef0a0a6b3: Fixed third issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed third issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 22 2019, 9:49 AM
AndreyChurbanov updated the summary of D62251: Fix for third case reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 22 2019, 6:13 AM · Restricted Project, Restricted Project
AndreyChurbanov created D62251: Fix for third case reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 22 2019, 5:58 AM · Restricted Project, Restricted Project
AndreyChurbanov accepted D62224: Add checks before dereferencing pointers.

LGTM

May 22 2019, 5:25 AM · Restricted Project

May 16 2019

AndreyChurbanov committed rGf8f788b2054e: Fixed second issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed second issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 16 2019, 10:53 AM
AndreyChurbanov accepted D61796: Fix hwloc topology traversal code unable to handle situation where L2 cache is common for the packages.

LGTM

May 16 2019, 4:40 AM · Restricted Project, Restricted Project
AndreyChurbanov created D61995: Fixed second problem reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 16 2019, 2:53 AM · Restricted Project

May 15 2019

AndreyChurbanov committed rG6ebb785bb1fd: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.
May 15 2019, 9:54 AM
AndreyChurbanov added a comment to D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.

I actually was not able to reproduce your first problem. But I hope the patch should fix both.

May 15 2019, 9:50 AM · Restricted Project
AndreyChurbanov created D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.
May 15 2019, 6:56 AM · Restricted Project
AndreyChurbanov committed rG22405f3097c1: Introduce new OpenMP 5.0 depend object type. (authored by AndreyChurbanov).
Introduce new OpenMP 5.0 depend object type.
May 15 2019, 6:44 AM

May 13 2019

AndreyChurbanov added a comment to D61673: Fixed creation of aliases in Windows build.

Sorry for committing the broken patch with missed ")" and "eol". Should now be fixed by r360602.

May 13 2019, 10:09 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rG1aaf2a3c184a: fixed typo made by commit r360595 (authored by AndreyChurbanov).
fixed typo made by commit r360595
May 13 2019, 10:03 AM
AndreyChurbanov created D61860: Introduce new OpenMP 5.0 depend object type..
May 13 2019, 9:46 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rG7f63e8c0a69e: Fixed creation of aliases in Windows build. (authored by AndreyChurbanov).
Fixed creation of aliases in Windows build.
May 13 2019, 9:06 AM

May 8 2019

AndreyChurbanov created D61673: Fixed creation of aliases in Windows build.
May 8 2019, 4:02 AM · Restricted Project, Restricted Project
AndreyChurbanov accepted D61603: [OpenMP] Fix gfortran bugzilla build bug 41755.

LGTM

May 8 2019, 3:54 AM · Restricted Project, Restricted Project

Apr 30 2019

AndreyChurbanov accepted D60979: [OpenMP] Add OpenMP 5.0 nonmonotonic code.

LGTM

Apr 30 2019, 11:26 AM · Restricted Project, Restricted Project

Apr 22 2019

AndreyChurbanov accepted D60938: Use correct way to test for MIPS arch after rOMP355687.

LGTM

Apr 22 2019, 12:28 AM · Restricted Project

Apr 19 2019

AndreyChurbanov added a comment to D60894: openmp: Align kmp_int64 and kmp_uint64 to 64 bits..

Not sure this is a good change, e.g. gcc produces tons of warnings:

Apr 19 2019, 10:49 AM · Restricted Project

Apr 17 2019

AndreyChurbanov committed rGcf5bdb83b02a: Fixed memory leak reported in Bugzilla: https://bugs.llvm.org/show_bug.cgi? (authored by AndreyChurbanov).
Fixed memory leak reported in Bugzilla: https://bugs.llvm.org/show_bug.cgi?
Apr 17 2019, 3:43 AM

Apr 15 2019

AndreyChurbanov updated the diff for D60729: Fixed memory leak reported in https://bugs.llvm.org/show_bug.cgi?id=41494.

formatted

Apr 15 2019, 11:57 AM · Restricted Project, Restricted Project
AndreyChurbanov created D60729: Fixed memory leak reported in https://bugs.llvm.org/show_bug.cgi?id=41494.
Apr 15 2019, 11:51 AM · Restricted Project, Restricted Project

Apr 11 2019

AndreyChurbanov committed rG705384be9741: Fixed possible out of bound array access. (authored by AndreyChurbanov).
Fixed possible out of bound array access.
Apr 11 2019, 8:04 AM
AndreyChurbanov accepted D60423: [OpenMP] Exchange code in asm file for inline assembly.

LGTM

Apr 11 2019, 5:12 AM · Restricted Project, Restricted Project