Page MenuHomePhabricator

AndreyChurbanov (Andrey Churbanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 16 2015, 7:54 AM (221 w, 6 d)

Recent Activity

Tue, Jul 16

AndreyChurbanov accepted D64625: [OpenMP] Move header inclusion out of 'extern "C"'.

LGTM

Tue, Jul 16, 9:11 AM · Restricted Project

Fri, Jul 12

AndreyChurbanov added inline comments to D64534: Remove OMP spec versioning.
Fri, Jul 12, 6:56 AM · Restricted Project, Restricted Project

Wed, Jul 10

AndreyChurbanov committed rG28f44040cc43: NFC: fixed typo #ifdef --> #if to allow macro set to 0 work correctly (authored by AndreyChurbanov).
NFC: fixed typo #ifdef --> #if to allow macro set to 0 work correctly
Wed, Jul 10, 8:12 AM

Tue, Jul 2

AndreyChurbanov committed rGa23806e67a2d: Create a runtime option to disable task throttling. (authored by AndreyChurbanov).
Create a runtime option to disable task throttling.
Tue, Jul 2, 8:12 AM
AndreyChurbanov accepted D63196: Create a runtime option to disable task throttling.

LGTM

Tue, Jul 2, 8:05 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rGe7b2c64a6e4c: Cleanup of unused code (authored by AndreyChurbanov).
Cleanup of unused code
Tue, Jul 2, 6:46 AM

Thu, Jun 27

AndreyChurbanov requested changes to D63196: Create a runtime option to disable task throttling.

Of cause you are free to choose your own test, or simply extend existing test(s).

Thu, Jun 27, 6:01 AM · Restricted Project, Restricted Project

Wed, Jun 26

AndreyChurbanov committed rGb7e6c37efead: Fixed memory use-after-free problem. (authored by AndreyChurbanov).
Fixed memory use-after-free problem.
Wed, Jun 26, 11:13 AM
AndreyChurbanov added a comment to D63196: Create a runtime option to disable task throttling.

Yes, adding tests would be great. Simplest thing to do is to extend existing tests with throttling on/off, I think.

Wed, Jun 26, 7:12 AM · Restricted Project, Restricted Project

Tue, Jun 25

AndreyChurbanov accepted D63196: Create a runtime option to disable task throttling.

sorry for the delay.

Tue, Jun 25, 5:25 AM · Restricted Project, Restricted Project

Fri, Jun 21

AndreyChurbanov updated the diff for D63599: Fixed memory use-after-free problem..

Covered more cases caused memory leak (when target-teams region is followed by parallel with bigger number of threads) and use-after-free problem (when nested hot teams requested via KMP_HOT_TEAMS_MAX_LEVEL=2 and num_teams is bigger than 1). The leak is fixed by freeing CG structure when worker threads inherit master's CG but had earlier non-NULL CG. Use-after-free fixed by making one more freeing of CG conditional (in __kmp_free_team routine).

Fri, Jun 21, 6:56 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D63599: Fixed memory use-after-free problem..
Fri, Jun 21, 6:44 AM · Restricted Project, Restricted Project

Thu, Jun 20

AndreyChurbanov created D63599: Fixed memory use-after-free problem..
Thu, Jun 20, 6:25 AM · Restricted Project, Restricted Project

Wed, Jun 19

AndreyChurbanov committed rG405037c4e62a: New implementation of OpenMP 5.0 detached tasks. (authored by AndreyChurbanov).
New implementation of OpenMP 5.0 detached tasks.
Wed, Jun 19, 6:21 AM
AndreyChurbanov added a comment to D62485: New implementation of OpenMP 5.0 detached tasks..

Are there any plans to add the code for the appropriate OMPT callbacks?

Wed, Jun 19, 6:17 AM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D62485: New implementation of OpenMP 5.0 detached tasks..

Addressed Joachim's comments.

Wed, Jun 19, 6:06 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D62485: New implementation of OpenMP 5.0 detached tasks..
Wed, Jun 19, 6:06 AM · Restricted Project, Restricted Project

Jun 5 2019

AndreyChurbanov committed rGd47f5488cf02: Added propagation of not big initial stack size of master thread to workers. (authored by AndreyChurbanov).
Added propagation of not big initial stack size of master thread to workers.
Jun 5 2019, 9:14 AM
AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Review comments addressed:

  • removed printf("passed") when the test is skipped;
  • changed default size to lower/upper limit for consistency during size adjustment.
Jun 5 2019, 7:51 AM · Restricted Project, Restricted Project

Jun 4 2019

AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Addressed Johannes' comment. At the same time I've reduced the upper bound of the size to be propagated to 64MB (from initial 256MB), because with this change more applications will be affected (those require big stack for master and small stack for workers).

Jun 4 2019, 6:18 AM · Restricted Project, Restricted Project

Jun 3 2019

AndreyChurbanov committed rG3f786dab0eb1: Fixed build warning with -DLIBOMP_USE_HWLOC=1 (authored by AndreyChurbanov).
Fixed build warning with -DLIBOMP_USE_HWLOC=1
Jun 3 2019, 7:20 AM

May 31 2019

AndreyChurbanov added inline comments to D62488: Added propagation of not big initial stack size of master thread to workers..
May 31 2019, 9:02 AM · Restricted Project, Restricted Project
AndreyChurbanov added a comment to D62488: Added propagation of not big initial stack size of master thread to workers..

Regarding test system,

May 31 2019, 8:15 AM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Test fixed: added "return 1" on possible failure of the test.

May 31 2019, 8:12 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D62488: Added propagation of not big initial stack size of master thread to workers..
May 31 2019, 8:08 AM · Restricted Project, Restricted Project
AndreyChurbanov retitled D62488: Added propagation of not big initial stack size of master thread to workers. from Fix for https://bugs.llvm.org/show_bug.cgi?id=26540. to Added propagation of not big initial stack size of master thread to workers..
May 31 2019, 7:43 AM · Restricted Project, Restricted Project
AndreyChurbanov updated the diff for D62488: Added propagation of not big initial stack size of master thread to workers..

Moved declaration of rlim under #if to avoid "unused variable" warning.

May 31 2019, 6:41 AM · Restricted Project, Restricted Project

May 29 2019

AndreyChurbanov accepted D62431: Fix OMP_TARGET_OFFLOAD parsing.

LGTM

May 29 2019, 1:11 AM · Restricted Project

May 28 2019

AndreyChurbanov added a comment to D62431: Fix OMP_TARGET_OFFLOAD parsing.

By negative test I meant the wrong value is ignored and the default used instead. I don't think we need to check library warnings.

May 28 2019, 9:33 AM · Restricted Project
AndreyChurbanov requested changes to D62431: Fix OMP_TARGET_OFFLOAD parsing.

Probably test case worth adding. Or even two, - one negative with something like "mandatorynot" value, another positive (we do have internal getter routine for the target-offload-var ICV).

May 28 2019, 9:19 AM · Restricted Project
AndreyChurbanov accepted D62431: Fix OMP_TARGET_OFFLOAD parsing.

LGTM

May 28 2019, 7:40 AM · Restricted Project

May 27 2019

AndreyChurbanov created D62488: Added propagation of not big initial stack size of master thread to workers..
May 27 2019, 9:39 AM · Restricted Project, Restricted Project
AndreyChurbanov created D62485: New implementation of OpenMP 5.0 detached tasks..
May 27 2019, 6:37 AM · Restricted Project, Restricted Project

May 23 2019

AndreyChurbanov created D62332: Fixed build warning with -DLIBOMP_USE_HWLOC=1.
May 23 2019, 11:12 AM · Restricted Project, Restricted Project

May 22 2019

AndreyChurbanov committed rG184ef0a0a6b3: Fixed third issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed third issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 22 2019, 9:49 AM
AndreyChurbanov updated the summary of D62251: Fix for third case reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 22 2019, 6:13 AM · Restricted Project, Restricted Project
AndreyChurbanov created D62251: Fix for third case reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 22 2019, 5:58 AM · Restricted Project, Restricted Project
AndreyChurbanov accepted D62224: Add checks before dereferencing pointers.

LGTM

May 22 2019, 5:25 AM · Restricted Project

May 16 2019

AndreyChurbanov committed rGf8f788b2054e: Fixed second issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed second issue reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 16 2019, 10:53 AM
AndreyChurbanov accepted D61796: Fix hwloc topology traversal code unable to handle situation where L2 cache is common for the packages.

LGTM

May 16 2019, 4:40 AM · Restricted Project, Restricted Project
AndreyChurbanov created D61995: Fixed second problem reported in https://bugs.llvm.org/show_bug.cgi?id=41584.
May 16 2019, 2:53 AM · Restricted Project

May 15 2019

AndreyChurbanov committed rG6ebb785bb1fd: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584. (authored by AndreyChurbanov).
Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.
May 15 2019, 9:54 AM
AndreyChurbanov added a comment to D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.

I actually was not able to reproduce your first problem. But I hope the patch should fix both.

May 15 2019, 9:50 AM · Restricted Project
AndreyChurbanov created D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.
May 15 2019, 6:56 AM · Restricted Project
AndreyChurbanov committed rG22405f3097c1: Introduce new OpenMP 5.0 depend object type. (authored by AndreyChurbanov).
Introduce new OpenMP 5.0 depend object type.
May 15 2019, 6:44 AM

May 13 2019

AndreyChurbanov added a comment to D61673: Fixed creation of aliases in Windows build.

Sorry for committing the broken patch with missed ")" and "eol". Should now be fixed by r360602.

May 13 2019, 10:09 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rG1aaf2a3c184a: fixed typo made by commit r360595 (authored by AndreyChurbanov).
fixed typo made by commit r360595
May 13 2019, 10:03 AM
AndreyChurbanov created D61860: Introduce new OpenMP 5.0 depend object type..
May 13 2019, 9:46 AM · Restricted Project, Restricted Project
AndreyChurbanov committed rG7f63e8c0a69e: Fixed creation of aliases in Windows build. (authored by AndreyChurbanov).
Fixed creation of aliases in Windows build.
May 13 2019, 9:06 AM

May 8 2019

AndreyChurbanov created D61673: Fixed creation of aliases in Windows build.
May 8 2019, 4:02 AM · Restricted Project, Restricted Project
AndreyChurbanov accepted D61603: [OpenMP] Fix gfortran bugzilla build bug 41755.

LGTM

May 8 2019, 3:54 AM · Restricted Project, Restricted Project

Apr 30 2019

AndreyChurbanov accepted D60979: [OpenMP] Add OpenMP 5.0 nonmonotonic code.

LGTM

Apr 30 2019, 11:26 AM · Restricted Project, Restricted Project

Apr 22 2019

AndreyChurbanov accepted D60938: Use correct way to test for MIPS arch after rOMP355687.

LGTM

Apr 22 2019, 12:28 AM · Restricted Project

Apr 19 2019

AndreyChurbanov added a comment to D60894: openmp: Align kmp_int64 and kmp_uint64 to 64 bits..

Not sure this is a good change, e.g. gcc produces tons of warnings:

Apr 19 2019, 10:49 AM · Restricted Project

Apr 17 2019

AndreyChurbanov committed rGcf5bdb83b02a: Fixed memory leak reported in Bugzilla: https://bugs.llvm.org/show_bug.cgi? (authored by AndreyChurbanov).
Fixed memory leak reported in Bugzilla: https://bugs.llvm.org/show_bug.cgi?
Apr 17 2019, 3:43 AM

Apr 15 2019

AndreyChurbanov updated the diff for D60729: Fixed memory leak reported in https://bugs.llvm.org/show_bug.cgi?id=41494.

formatted

Apr 15 2019, 11:57 AM · Restricted Project, Restricted Project
AndreyChurbanov created D60729: Fixed memory leak reported in https://bugs.llvm.org/show_bug.cgi?id=41494.
Apr 15 2019, 11:51 AM · Restricted Project, Restricted Project

Apr 11 2019

AndreyChurbanov committed rG705384be9741: Fixed possible out of bound array access. (authored by AndreyChurbanov).
Fixed possible out of bound array access.
Apr 11 2019, 8:04 AM
AndreyChurbanov accepted D60423: [OpenMP] Exchange code in asm file for inline assembly.

LGTM

Apr 11 2019, 5:12 AM · Restricted Project, Restricted Project

Apr 9 2019

AndreyChurbanov created D60471: Fixed possible out of bound array access.
Apr 9 2019, 10:19 AM · Restricted Project, Restricted Project

Apr 8 2019

AndreyChurbanov accepted D59508: Clean up load balancing dynamic mode.

LGTM

Apr 8 2019, 10:41 AM · Restricted Project, Restricted Project

Apr 2 2019

AndreyChurbanov added inline comments to D59451: Fix gettid warnings and one test on FreeBSD.
Apr 2 2019, 6:33 AM · Restricted Project, Restricted Project

Mar 26 2019

AndreyChurbanov added inline comments to D59783: [OpenMP] Implement 5.0 memory management.
Mar 26 2019, 3:43 AM · Restricted Project

Mar 7 2019

AndreyChurbanov accepted D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit.

LGTM

Mar 7 2019, 2:22 PM · Restricted Project

Mar 5 2019

AndreyChurbanov requested changes to D45691: [mips] Use libatomic instead of GCC intrinsics for 64bit.
Mar 5 2019, 8:55 AM · Restricted Project

Feb 11 2019

AndreyChurbanov accepted D56804: Fix thread_limits to work properly for teams construct.

LGTM

Feb 11 2019, 10:47 AM · Restricted Project, Restricted Project
AndreyChurbanov requested changes to D56804: Fix thread_limits to work properly for teams construct.

Per-task ICV works for me.

Feb 11 2019, 3:40 AM · Restricted Project, Restricted Project

Feb 7 2019

AndreyChurbanov added inline comments to D56804: Fix thread_limits to work properly for teams construct.
Feb 7 2019, 9:39 AM · Restricted Project, Restricted Project
AndreyChurbanov added inline comments to D56804: Fix thread_limits to work properly for teams construct.
Feb 7 2019, 5:54 AM · Restricted Project, Restricted Project

Jan 21 2019

AndreyChurbanov added inline comments to D55078: Add omp_pause_resource* API.
Jan 21 2019, 8:14 AM · Restricted Project
AndreyChurbanov added inline comments to D55078: Add omp_pause_resource* API.
Jan 21 2019, 8:00 AM · Restricted Project
AndreyChurbanov created D57017: Fixed https://reviews.llvm.org/D55078.
Jan 21 2019, 7:21 AM · Restricted Project

Jan 16 2019

AndreyChurbanov accepted D55078: Add omp_pause_resource* API.

LGTM

Jan 16 2019, 3:31 AM · Restricted Project
AndreyChurbanov accepted D56775: [OpenMP] Remove compiler warning about unused value.

LGTM

Jan 16 2019, 3:12 AM

Jan 11 2019

AndreyChurbanov accepted D56103: Add lock function definitions to fix Bug 40042.

LGTM

Jan 11 2019, 3:04 AM · Restricted Project

Jan 9 2019

AndreyChurbanov accepted D56432: Documentation: providing a more precise description of a parameter of the kmpc_taskloop function.

Sergi, do you have commit rights? I can commit it otherwise. Thanks.

Jan 9 2019, 3:34 AM · Restricted Project

Dec 19 2018

AndreyChurbanov accepted D55788: Fix performance regression in SPEC kdtree test.

LGTM

Dec 19 2018, 2:33 AM · Restricted Project

Dec 18 2018

AndreyChurbanov added inline comments to D55788: Fix performance regression in SPEC kdtree test.
Dec 18 2018, 1:12 AM · Restricted Project
AndreyChurbanov added inline comments to D55788: Fix performance regression in SPEC kdtree test.
Dec 18 2018, 1:05 AM · Restricted Project

Dec 13 2018

AndreyChurbanov accepted D55598: Fix for https://bugs.llvm.org/show_bug.cgi?id=39970.

Tom Stellard confirmed that this patch fixes all the issues reported. So, once this patch does not touch source code, I will commit it without formal review.

Dec 13 2018, 2:02 AM

Dec 12 2018

AndreyChurbanov created D55598: Fix for https://bugs.llvm.org/show_bug.cgi?id=39970.
Dec 12 2018, 5:40 AM

Dec 11 2018

AndreyChurbanov accepted D55496: [OpenMP] RFC: fixes for LIBOMP_OMP_VERSION=4.5/4.

II think it would be best to just remove all the #ifdefs and code that is not needed anymore.

Sure, i could do that instead, if that is the final decision.
I just don't want it to stay in the current sudo-broken state.

Dec 11 2018, 8:48 AM · Restricted Project

Dec 10 2018

AndreyChurbanov accepted D55148: [OpenMP] Implement OpenMP 5.0 Affinity Format Functionality.

LGTM

Dec 10 2018, 9:46 AM · Restricted Project

Dec 5 2018

AndreyChurbanov added inline comments to D55078: Add omp_pause_resource* API.
Dec 5 2018, 9:41 AM · Restricted Project
AndreyChurbanov accepted D55300: Fix transient divide by zero bug in 32-bit code.

LGTM

Dec 5 2018, 9:27 AM · Restricted Project

Nov 27 2018

AndreyChurbanov created D54950: Fixed possible array out of bound access.
Nov 27 2018, 6:41 AM
AndreyChurbanov created D54948: Minor cleanup of debug code.
Nov 27 2018, 5:55 AM

Nov 9 2018

AndreyChurbanov added a reviewer for D53479: [Cmake] Allowed OpenMP testing detect test compiler with same generator: jlpeyton.
Nov 9 2018, 5:53 AM
AndreyChurbanov created D54305: Fix for bugzilla https://bugs.llvm.org/show_bug.cgi?id=39137..
Nov 9 2018, 5:50 AM · Restricted Project

Nov 7 2018

AndreyChurbanov added a comment to D40358: Use hyperbarrier by default on all architectures.

Can you share more info on the problem on x86_64? What kind of failure you see? What is OS and HW? Can you share a reproducer?

Nov 7 2018, 6:17 AM

Nov 6 2018

AndreyChurbanov added a comment to D54079: [OPENMP] Add Hurd support.

Please submit the patch with full sources, so that more code around changes could be easily viewed.

Nov 6 2018, 6:00 AM

Oct 17 2018

AndreyChurbanov created D53380: Implementation of OpenMP 5.0 mutexinoutset task dependency type..
Oct 17 2018, 10:54 AM

Oct 1 2018

AndreyChurbanov created D52712: Fixed workaround made in https://reviews.llvm.org/D51694.
Oct 1 2018, 2:59 AM

Sep 28 2018

AndreyChurbanov accepted D52628: Shutdown library on Windows if possible for better OMPT behavior..

LGTM

Sep 28 2018, 8:40 AM · Restricted Project

Sep 6 2018

AndreyChurbanov updated the diff for D51694: Fix for https://bugs.llvm.org/show_bug.cgi?id=38839.

Changed the style so that all lines have length less than 72 char.
The kind of the longest variable "omp_control_tool_nocallback" changed from "omp_control_tool_result_kind" to be the parent kind "omp_integer_kind", thus the declaration line fits 72 chars (could not come up with a better solution for this variable).

Sep 6 2018, 2:10 AM
AndreyChurbanov added a comment to D51694: Fix for https://bugs.llvm.org/show_bug.cgi?id=38839.

I am a bit puzzled by the requirement for the file to be compilable in free or fixed form and with 72 or 132 line width, because of the line:

integer(kind=omp_control_tool_result_kind)omp_control_tool_nocallback

Not sure if it is possible at all.

Sep 6 2018, 1:40 AM

Sep 5 2018

AndreyChurbanov added inline comments to D51694: Fix for https://bugs.llvm.org/show_bug.cgi?id=38839.
Sep 5 2018, 11:21 AM
AndreyChurbanov created D51694: Fix for https://bugs.llvm.org/show_bug.cgi?id=38839.
Sep 5 2018, 10:44 AM

Aug 29 2018

AndreyChurbanov added a comment to D51331: [OPENMP] Create non-const ident_t structs..

When is ITT Notify used? Does it have some preconditions like debug info, some optimizations level etc.?

Aug 29 2018, 4:00 AM

Aug 27 2018

AndreyChurbanov accepted D51301: [OpenMP][Fix] Ensure comparison between unsigned values..

LGTM

Aug 27 2018, 7:41 AM