Page MenuHomePhabricator

AndreyChurbanov (Andrey Churbanov)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 16 2015, 7:54 AM (301 w, 16 h)

Recent Activity

Today

AndreyChurbanov accepted D95167: [OpenMP] properly initialize buckets in __kmp_dephash_extend.

LGTM

Thu, Jan 21, 1:26 PM · Restricted Project

Tue, Jan 19

AndreyChurbanov requested review of D95003: [OpenMP] libomp: implement OpenMP 5.1 nteams-var and teams-thread-limit-var ICVs.
Tue, Jan 19, 2:21 PM · Restricted Project
AndreyChurbanov accepted D94848: [OpenMP] Fix atomic entries for captured logical operation.

LGTM

Tue, Jan 19, 5:46 AM · Restricted Project
AndreyChurbanov committed rGa60bc55c6936: [OpenMP] libomp: cleanup parsing of OMP_ALLOCATOR env variable. (authored by AndreyChurbanov).
[OpenMP] libomp: cleanup parsing of OMP_ALLOCATOR env variable.
Tue, Jan 19, 5:22 AM
AndreyChurbanov closed D94932: [OpenMP] libomp: cleanup parsing of OMP_ALLOCATOR env variable.
Tue, Jan 19, 5:22 AM · Restricted Project

Mon, Jan 18

AndreyChurbanov requested review of D94932: [OpenMP] libomp: cleanup parsing of OMP_ALLOCATOR env variable.
Mon, Jan 18, 2:04 PM · Restricted Project
AndreyChurbanov committed rGaa3a59e0c69e: [OpenMP][NFC] Fix test (authored by AndreyChurbanov).
[OpenMP][NFC] Fix test
Mon, Jan 18, 1:06 PM

Tue, Jan 12

AndreyChurbanov accepted D94353: [OpenMP] Use persistent memory for omp_large_cap_mem.

LGTM

Tue, Jan 12, 3:17 PM · Restricted Project
AndreyChurbanov accepted D94277: [OpenMP] Update allocator trait key/value definitions.

LGTM

Tue, Jan 12, 3:11 PM · Restricted Project

Wed, Jan 6

AndreyChurbanov accepted D94042: [OpenMP] Use c_int/c_size_t in Fortran target memory routine interface.

LGTM

Wed, Jan 6, 2:09 PM · Restricted Project

Wed, Dec 30

AndreyChurbanov accepted D93505: [OpenMP] Add definition/interface for target memory routines.

LGTM

Wed, Dec 30, 2:40 PM · Restricted Project
AndreyChurbanov committed rG6b316febb438: [OpenMP] libomp: Handle implicit conversion warnings (authored by tlwilmar).
[OpenMP] libomp: Handle implicit conversion warnings
Wed, Dec 30, 1:41 PM
AndreyChurbanov closed D92942: Handle implicit conversion warnings.
Wed, Dec 30, 1:40 PM · Restricted Project
AndreyChurbanov accepted D92942: Handle implicit conversion warnings.

LGTM

Wed, Dec 30, 1:35 PM · Restricted Project

Dec 15 2020

AndreyChurbanov added a comment to D71989: [OpenMP][IRBuilder][WIP] Prototype `omp task` support.

The required changes in addition to the diff have been discussed with @AndreyChurbanov in the comments above.

Dec 15 2020, 1:48 PM · Restricted Project, Restricted Project
AndreyChurbanov accepted D93230: [OpenMP] Initialize runtime in the forked child process.

LGTM

Dec 15 2020, 5:05 AM · Restricted Project

Dec 9 2020

AndreyChurbanov added a comment to D91002: [OpenMP] Fix asm for arm64-darwin.

I tested with make check-openmp and make check-clang on an AArch64 linux machine and both versions (D91002,D88252) pass.
If you were asking for a different kind of testing then please let me know.

Dec 9 2020, 6:54 AM · Restricted Project
AndreyChurbanov accepted D92352: Add strict mode in num_tasks and grainsize.

LGTM

Dec 9 2020, 6:49 AM · Restricted Project
AndreyChurbanov accepted D92660: [OpenMP] Fix too long name for shm segment on macOS.

LGTM

Dec 9 2020, 5:50 AM · Restricted Project
AndreyChurbanov accepted D92615: [OpenMP] Use RTM lock for OMP lock with synchronization hint.

LGTM

Dec 9 2020, 5:49 AM · Restricted Project

Dec 7 2020

AndreyChurbanov committed rGfff1abc406d5: [OpenMP] NFC: comment adjusted (authored by AndreyChurbanov).
[OpenMP] NFC: comment adjusted
Dec 7 2020, 8:51 AM
AndreyChurbanov added a comment to D90962: [OpenMP] Fix possible NULL dereferences.

LGTM, I left a nit inlined but feel free to ignore.

...
Argh, ... OK, so the situation we are in is that the frontends are not in agreement. One thing we should avoid is to mix the comments in the runtime as well, will just cause more confusion. I'd argue we can let the frontends do what they think is right and in the runtime just say "this is a number that is either the line end or column". We always treat it the same, given that we don't interpret it anyway. Tools need to be aware of the frontend to avoid confusion. WDYT? (This would mean an action item to make sure all comments (maybe also variable names) reflect the duality.)

Dec 7 2020, 8:19 AM · Restricted Project
AndreyChurbanov committed rG22558c8501ea: [OpenMP] libomp: Fix possible NULL dereferences (authored by AndreyChurbanov).
[OpenMP] libomp: Fix possible NULL dereferences
Dec 7 2020, 8:09 AM
AndreyChurbanov closed D90962: [OpenMP] Fix possible NULL dereferences.
Dec 7 2020, 8:09 AM · Restricted Project
AndreyChurbanov accepted D92587: [OpenMP] Fix norespect affinity bug for Windows.

LGTM

Dec 7 2020, 6:24 AM · Restricted Project

Dec 1 2020

AndreyChurbanov committed rG6bf84871e938: [OpenMP] libomp: add UNLIKELY hints to rarely executed branches (authored by AndreyChurbanov).
[OpenMP] libomp: add UNLIKELY hints to rarely executed branches
Dec 1 2020, 5:54 AM
AndreyChurbanov closed D92322: [OpenMP] libomp: add UNLIKELY hints to rarely executed branches.
Dec 1 2020, 5:53 AM · Restricted Project

Nov 30 2020

AndreyChurbanov updated the diff for D92322: [OpenMP] libomp: add UNLIKELY hints to rarely executed branches.

Rebased

Nov 30 2020, 2:15 PM · Restricted Project
AndreyChurbanov committed rG9615890db576: [OpenMP] libomp: change shm name to include UID, call unregister_lib on SIGTERM (authored by terdner).
[OpenMP] libomp: change shm name to include UID, call unregister_lib on SIGTERM
Nov 30 2020, 1:42 PM
AndreyChurbanov closed D91869: [OpenMP] change shm name to include UID, call unregister_lib on SIGTERM.
Nov 30 2020, 1:41 PM · Restricted Project
AndreyChurbanov accepted D91869: [OpenMP] change shm name to include UID, call unregister_lib on SIGTERM.

LGTM

Nov 30 2020, 1:25 PM · Restricted Project
AndreyChurbanov committed rGf6f28b44ad48: [OpenMP] libomp: fix mutexinoutset dependence for proxy tasks (authored by AndreyChurbanov).
[OpenMP] libomp: fix mutexinoutset dependence for proxy tasks
Nov 30 2020, 1:14 PM
AndreyChurbanov closed D92326: [OpenMP] libomp: fix mutexinoutset dependence for proxy tasks.
Nov 30 2020, 1:14 PM · Restricted Project
AndreyChurbanov added inline comments to D92326: [OpenMP] libomp: fix mutexinoutset dependence for proxy tasks.
Nov 30 2020, 12:52 PM · Restricted Project
AndreyChurbanov updated the diff for D90962: [OpenMP] Fix possible NULL dereferences.

Updated the style of newly added function.

Nov 30 2020, 12:26 PM · Restricted Project
AndreyChurbanov added a comment to D90962: [OpenMP] Fix possible NULL dereferences.

I like the approach. Minor nits and one question though: Why are we talking about two line numbers and not line + column? This confuses me.

Nov 30 2020, 11:45 AM · Restricted Project
AndreyChurbanov requested review of D92326: [OpenMP] libomp: fix mutexinoutset dependence for proxy tasks.
Nov 30 2020, 8:02 AM · Restricted Project
AndreyChurbanov requested review of D92322: [OpenMP] libomp: add UNLIKELY hints to rarely executed branches.
Nov 30 2020, 6:55 AM · Restricted Project
AndreyChurbanov updated the diff for D90962: [OpenMP] Fix possible NULL dereferences.

Add function for reading numeric only values from location string. Use the function in metadata reporting for loop and single constructs.

Nov 30 2020, 5:19 AM · Restricted Project
AndreyChurbanov commandeered D90962: [OpenMP] Fix possible NULL dereferences.
Nov 30 2020, 5:03 AM · Restricted Project

Nov 25 2020

AndreyChurbanov committed rG9e3e332d273b: [OpenMP] libomp: fix non-X86, non-AARCH64 builds (authored by AndreyChurbanov).
[OpenMP] libomp: fix non-X86, non-AARCH64 builds
Nov 25 2020, 9:41 AM
AndreyChurbanov closed D92027: [OpenMP] libomp: fix non-X86 non-AARCH64 builds.
Nov 25 2020, 9:40 AM · Restricted Project
AndreyChurbanov added a comment to D91189: Add support for Intel's umonitor/umwait.

https://llvm.org/docs/DeveloperPolicy.html#commit-messages Please use git commit --amend --author= for future patches for proper attribution.

Nov 25 2020, 9:29 AM · Restricted Project

Nov 24 2020

AndreyChurbanov added inline comments to D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.
Nov 24 2020, 6:44 AM · Restricted Project, Restricted Project
AndreyChurbanov requested review of D92027: [OpenMP] libomp: fix non-X86 non-AARCH64 builds.
Nov 24 2020, 6:42 AM · Restricted Project
AndreyChurbanov committed rG7b5254223acb: [OpenMP] fix asm code for for arm64 (AARCH64) for Darwin/macOS (authored by AndreyChurbanov).
[OpenMP] fix asm code for for arm64 (AARCH64) for Darwin/macOS
Nov 24 2020, 2:09 AM
AndreyChurbanov closed D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.
Nov 24 2020, 2:09 AM · Restricted Project, Restricted Project
AndreyChurbanov accepted D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.

Patch would still better be updated with correct path and full context (maybe post commit).

Nov 24 2020, 2:06 AM · Restricted Project, Restricted Project

Nov 23 2020

AndreyChurbanov requested changes to D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.

I am sorry, my accept action was not formal enough.

Nov 23 2020, 1:17 PM · Restricted Project, Restricted Project

Nov 20 2020

AndreyChurbanov added a comment to D91189: Add support for Intel's umonitor/umwait.

This broke compilation for me:

../runtime/src/kmp.h:1371:3: error: always_inline function '_umonitor' requires target feature 'waitpkg', but would be inlined into function '__kmp_umonitor' that is compiled without support for 'waitpkg'
  _umonitor(cacheline);
  ^ 
../runtime/src/kmp.h:1390:10: error: always_inline function '_umwait' requires target feature 'waitpkg', but would be inlined into function '__kmp_umwait' that is compiled without support for 'waitpkg'
  return _umwait(hint, counter);
         ^
2 errors generated.
Nov 20 2020, 1:21 AM · Restricted Project
AndreyChurbanov added a reverting change for rG9cfad5f9c5bf: [OpenMP] Add support for Intel's umonitor/umwait: rG5644f734d606: Revert "[OpenMP] Add support for Intel's umonitor/umwait".
Nov 20 2020, 1:17 AM
AndreyChurbanov committed rG5644f734d606: Revert "[OpenMP] Add support for Intel's umonitor/umwait" (authored by AndreyChurbanov).
Revert "[OpenMP] Add support for Intel's umonitor/umwait"
Nov 20 2020, 1:17 AM
AndreyChurbanov added a reverting change for D91189: Add support for Intel's umonitor/umwait: rG5644f734d606: Revert "[OpenMP] Add support for Intel's umonitor/umwait".
Nov 20 2020, 1:17 AM · Restricted Project

Nov 19 2020

AndreyChurbanov committed rG9cfad5f9c5bf: [OpenMP] Add support for Intel's umonitor/umwait (authored by AndreyChurbanov).
[OpenMP] Add support for Intel's umonitor/umwait
Nov 19 2020, 11:05 AM
AndreyChurbanov closed D91189: Add support for Intel's umonitor/umwait.
Nov 19 2020, 11:04 AM · Restricted Project

Nov 18 2020

AndreyChurbanov accepted D91189: Add support for Intel's umonitor/umwait.

LGTM

Nov 18 2020, 1:43 PM · Restricted Project
AndreyChurbanov added a comment to D89898: changing OMP rtl to use shared memory instead of env variable .

Note that I assume that hitting a file we left behind by ourselves is not a problem for the runtime.

You will still need to explicitly ask library to work with files left behind via setting KMP_DUPLICATE_LIB_OK=1.
Otherwise library should abort, as it will think that another copy of the library already works in the same process, that is not supported.

Nov 18 2020, 12:11 PM · Restricted Project
AndreyChurbanov added a comment to D89898: changing OMP rtl to use shared memory instead of env variable .

Hi @jdoerfert

[Drive by] What about appending the process id or a random number to the file name, or both?

yeah, the patch already does this. The space of PIDs it is not too large (most systems still use 16-bit PIDs) so collisions are not that unlikely. It is just a bit confusing that an OpenMP application fails due to this, sporadically, at startup.

Perhaps the scenario of leftover files is not that common: probably only if the process receives a SIGKILL. Most scheduling systems will send SIGTERM first and users often use SIGINT or SIGQUIT.

Kind regards,

Nov 18 2020, 7:20 AM · Restricted Project

Nov 17 2020

AndreyChurbanov accepted D91105: [OpenMP] Use explicit type casting in kmp_atomic.cpp.

LGTM

Nov 17 2020, 12:12 PM · Restricted Project
AndreyChurbanov accepted D90971: [OpenMP] Add OpenMP 5.1 omp_realloc function implementation.

LGTM

Nov 17 2020, 11:15 AM · Restricted Project

Nov 16 2020

AndreyChurbanov added a comment to D90971: [OpenMP] Add OpenMP 5.1 omp_realloc function implementation.

Please also change the openmp/runtime/tools/generate-def.pl file in order to not break Windows build.
See https://reviews.llvm.org/D91478 as an example of the change made for omp_calloc function.

Nov 16 2020, 9:00 AM · Restricted Project

Nov 15 2020

AndreyChurbanov accepted D91478: [OpenMP] Fix building for windows after adding omp_calloc.

LGTM

Nov 15 2020, 10:32 AM · Restricted Project

Nov 13 2020

AndreyChurbanov accepted D90967: [OpenMP] Add OpenMP 5.1 omp_calloc function implementation.

LGTM

Nov 13 2020, 5:52 AM · Restricted Project

Nov 12 2020

AndreyChurbanov accepted D91309: [OpenMP] Fixed a bug when displaying affinity.

LGTM

Nov 12 2020, 10:11 AM · Restricted Project

Nov 10 2020

AndreyChurbanov committed rG33da6bd7f503: [OpenMP] Fixes for shared memory cleanup when aborts occur (authored by AndreyChurbanov).
[OpenMP] Fixes for shared memory cleanup when aborts occur
Nov 10 2020, 1:17 PM
AndreyChurbanov closed D90974: Fixes for shared memory cleanup when aborts occur.
Nov 10 2020, 1:16 PM · Restricted Project
AndreyChurbanov accepted D90974: Fixes for shared memory cleanup when aborts occur.

LGTM

Nov 10 2020, 1:06 PM · Restricted Project
AndreyChurbanov added a comment to D90962: [OpenMP] Fix possible NULL dereferences.

I mean for example __kmp_str_loc_init, which does gracefully handle ill-formed input (as far as I can tell).
If it doesn't, let's fix it as well. Either way, we should probably reuse it.

Nov 10 2020, 12:34 PM · Restricted Project
AndreyChurbanov accepted D90647: [OpenMP] Fix shutdown hang bug.

LGTM

Nov 10 2020, 11:30 AM · Restricted Project

Nov 9 2020

AndreyChurbanov added inline comments to D90967: [OpenMP] Add OpenMP 5.1 omp_calloc function implementation.
Nov 9 2020, 6:54 AM · Restricted Project
AndreyChurbanov added a comment to D90971: [OpenMP] Add OpenMP 5.1 omp_realloc function implementation.

Can we have tests for ptr = NULL, size=0? Probably just replace alloc and free by these cases and check returned address after each call?

Nov 9 2020, 6:45 AM · Restricted Project

Nov 6 2020

AndreyChurbanov added a comment to D90962: [OpenMP] Fix possible NULL dereferences.

So, we had asserts, right? And this code is "copied" a few times all over. What I try to say is, I'm not sure this is a "fix" and it is sufficient.

KMP_DEBUG_ASSERT is no-op in release build. Thus this patch adds missed checks in order to make static code analyzers happy.
In real codes we haven't encountered broken source location string, but in theory this might happen and then NULL pointer could be dereferenced.

I don't think we should generally "make the static code analyzers happy" by swapping out reasonable asserts with some if-then-else logic for a case we don't expect to happen.
It also doesn't help us in any of the other copies of this code.

Nov 6 2020, 1:02 PM · Restricted Project
AndreyChurbanov added a comment to D90962: [OpenMP] Fix possible NULL dereferences.

So, we had asserts, right? And this code is "copied" a few times all over. What I try to say is, I'm not sure this is a "fix" and it is sufficient.

Nov 6 2020, 11:57 AM · Restricted Project

Nov 4 2020

AndreyChurbanov accepted D90756: [OpenMP] avoid warning: equality comparison with extraneous parentheses.

LGTM

Nov 4 2020, 6:22 AM · Restricted Project

Oct 26 2020

AndreyChurbanov committed rGd6a0957467e8: [OpenMP] changing OMP rtl to use shared memory instead of env variable (authored by AndreyChurbanov).
[OpenMP] changing OMP rtl to use shared memory instead of env variable
Oct 26 2020, 9:03 AM
AndreyChurbanov closed D89898: changing OMP rtl to use shared memory instead of env variable .
Oct 26 2020, 9:02 AM · Restricted Project

Oct 23 2020

AndreyChurbanov accepted D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS.

Accepting as there were no objections.
I cannot check the correctness myself as don't have access to these architectures.

Oct 23 2020, 11:58 AM · Restricted Project, Restricted Project
AndreyChurbanov accepted D89898: changing OMP rtl to use shared memory instead of env variable .

LGTM

Oct 23 2020, 9:58 AM · Restricted Project

Sep 15 2020

AndreyChurbanov accepted D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.

LGTM

Sep 15 2020, 4:51 AM · Restricted Project

Sep 14 2020

AndreyChurbanov added inline comments to D87269: [OpenMP] Introduce GOMP taskwait depend in the runtime.
Sep 14 2020, 1:11 AM · Restricted Project

Sep 11 2020

AndreyChurbanov accepted D87167: [OpenMP] Introduce GOMP teams support in runtime.

LGTM

Sep 11 2020, 3:45 PM · Restricted Project
AndreyChurbanov accepted D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Looks good, besides a few formatting nits.

Sep 11 2020, 1:31 PM · Restricted Project

Sep 9 2020

AndreyChurbanov added a comment to D77609: [OpenMP] Added the support for hidden helper task in RTL.

Couple of tests needed to check if the implementation works - one with unshackled task encountered before parallel, and another with unshackled task encountered after / between parallels.

Sep 9 2020, 7:07 AM · Restricted Project

Aug 26 2020

AndreyChurbanov committed rG1596ea80fdf3: [OpenMP] Fix import library installation with MinGW (authored by AndreyChurbanov).
[OpenMP] Fix import library installation with MinGW
Aug 26 2020, 11:56 AM
AndreyChurbanov closed D86552: [OpenMP] Fix import library installation with MinGW.
Aug 26 2020, 11:56 AM · Restricted Project
AndreyChurbanov added a comment to D86419: fix omp post-generation event statement error on windows.

This change causes standalone Windows build to fail:

Aug 26 2020, 11:33 AM · Restricted Project
AndreyChurbanov accepted D86552: [OpenMP] Fix import library installation with MinGW.

LGTM

Aug 26 2020, 10:15 AM · Restricted Project
AndreyChurbanov committed rG09af378f49dc: [OpenMP] Fix build on macOS sdk 10.12 and newer (authored by AndreyChurbanov).
[OpenMP] Fix build on macOS sdk 10.12 and newer
Aug 26 2020, 6:53 AM
AndreyChurbanov closed D76755: Fix build on macOS sdk 10.12 and newer.
Aug 26 2020, 6:53 AM · Restricted Project

Aug 24 2020

AndreyChurbanov accepted D86397: Move special va_list handling to kmp_os.h.

This seems to replace D77333

Aug 24 2020, 1:21 PM · Restricted Project
AndreyChurbanov committed rGd0f4f5a182d7: [OpenMP] Check if _MSC_VER is defined before using it (authored by AndreyChurbanov).
[OpenMP] Check if _MSC_VER is defined before using it
Aug 24 2020, 7:51 AM
AndreyChurbanov closed D86448: [OpenMP] Check if `_MSC_VER` is defined before using it.
Aug 24 2020, 7:51 AM · Restricted Project
AndreyChurbanov accepted D86448: [OpenMP] Check if `_MSC_VER` is defined before using it.

LGTM

Aug 24 2020, 6:33 AM · Restricted Project

Aug 19 2020

AndreyChurbanov added inline comments to D77609: [OpenMP] Added the support for hidden helper task in RTL.
Aug 19 2020, 7:49 AM · Restricted Project
AndreyChurbanov added inline comments to D77609: [OpenMP] Added the support for hidden helper task in RTL.
Aug 19 2020, 7:26 AM · Restricted Project

Aug 17 2020

AndreyChurbanov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

The key difference is:
git diff # gives you short patch
git diff -U999999 # gives you full patch

The full patch should have complete source, as opposed to 3 lines above and below the changes for the short patch.

Ugh, sorry I missed that! Fixed.

Aug 17 2020, 7:46 AM · Restricted Project

Aug 12 2020

AndreyChurbanov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Other than few formatting changes the instructions from the link didn't provide any information about "full diff". Is that related to arcanist somehow? I can try to figure out how to use it if that'll help. :)

I figured if I give you the link to the start of "how to submit a patch" you would follow the links from there. My bad: https://llvm.org/docs/Phabricator.html#phabricator-request-review-web

That's exactly the instructions I followed to submit my patch. If it is lacking some details, I would like to know how to fix it.

Aug 12 2020, 6:14 AM · Restricted Project

Aug 11 2020

AndreyChurbanov added a comment to D84456: [OpenMP] Refactor memory allocation code for easier support for third party memory libraries.

Could you please provide full diff so that more context is available around the changes?

Aug 11 2020, 1:53 PM · Restricted Project

Aug 5 2020

AndreyChurbanov accepted D84472: [OpenMP] Fix releasing of stack memory.

LGTM

Aug 5 2020, 11:44 AM · Restricted Project

Aug 4 2020

AndreyChurbanov committed rG4a04bc899563: [OpenMP] Don't use MSVC workaround with MinGW (authored by AndreyChurbanov).
[OpenMP] Don't use MSVC workaround with MinGW
Aug 4 2020, 8:49 AM