User Details
- User Since
- Apr 20 2015, 1:32 PM (413 w, 3 h)
Thu, Mar 9
Tue, Feb 21
LGTM
Feb 9 2023
@rogfer01 th_task_state is used to refer to one of two task teams that are reused for each hot team. These two task teams exist because of a need to start using a new one while there may still be activity on the old task team, so we flip between the two. Each thread has a th_task_state so it knows which task team is in use for a particular parallel region. When a hot team is expanded in size for a larger parallel region, new threads added to the team need to have their th_task_state initialized to exactly what the other threads in the team are using, so that they are all in sync. So instead, we just initialize from a thread that was in the team before the resize.
Feb 8 2023
Jan 20 2023
ping
Jan 18 2023
LGTM
Jan 17 2023
LGTM
Jan 12 2023
Jan 11 2023
Dec 19 2022
LGTM
LGTM
Dec 13 2022
Dec 12 2022
Thanks Johnny -- made all the fixes you mentioned.
Dec 1 2022
Nov 30 2022
Jul 15 2022
LGTM
LGTM
LGTM
LGTM
Jun 22 2022
LGTM
Jun 21 2022
LGTM
Apr 7 2022
Hi -- can you tell me which specific tests failed reliably? Was it one particular arch? I want to make sure I'm covering those tests and will give your change a try and review soon. Thanks!
Apr 6 2022
Just a side note that dist barrier is an Intel-hardware-specific barrier. It's not likely to work well for non-Intel hardware.
Mar 7 2022
Looks good to me.
Jan 18 2022
Dec 14 2021
Dec 8 2021
LGTM
Nov 3 2021
LGTM
Oct 14 2021
LGTM
Okay, that makes sense. THanks! LGTM
Oct 13 2021
Check potential KMP_AFFINITY_SUPPORTED changes mentioned in comments.
LGTM
LGTM
Sep 24 2021
Jul 23 2021
@kkwli0 Other than some clang-format and clang-tidy issues (ignorable), builds look okay, so I think this is ready to try out.
Jul 21 2021
Johnny added overloaded operator new() and operator delete() functions to the two kmp_flag classes that have virtual destructors. He took out the removal of the -Wl,-z,defs flag from the previous patch as well.
He applied it to LLVM and built all of LLVM using clang-12 (with no warnings now and no undefined references), then ran check-openmp and everything was OK.
Kelvin, please wait for the x86 build bot to give a passing result, before attempting to test. Thanks!
Jul 15 2021
Patch notes from Jonathan Peyton: The -Wl,-z,defs flag sent in from LLVM cause undefined references which cause link-time errors in object files due to the new empty virtual destructors. We eliminate this flag for the host OpenMP runtime which eliminates the undefined reference errors. This prevents the host runtime from requiring linking to the standard C++ runtime library.
Jul 13 2021
Kelvin, please try again with this new patch. As of this moment, at least, it applies on top of main branch.
Jul 12 2021
kmp_barrier.h was missing; added back.
This update contains the original patch plus https://reviews.llvm.org/D104638, https://reviews.llvm.org/D104788, and a few more additions to fix the warnings mentioned in D104788.
Jun 16 2021
Jun 15 2021
Added test lines.
Jun 4 2021
Nawrin -- I added a comment about it. I'm hesitant to document that part of this experimental feature in its current form -- it's needed for experimentation at the moment, but is likely to change in syntax or otherwise. It's for having an app use a limited outer level of parallelism, and then library calls into selected libraries can turn on nesting and avoid oversubscription. So, I've left out that option in the commit message, but added the comment to the code, emphasizing that it is an experimental option on an experimental feature.
May 25 2021
May 21 2021
A few updates that were missed in the original patch were added. Condition fix in the init function, and a topology method check to make use of hwloc if available.
May 12 2021
May 10 2021
May 3 2021
LGTM
Mar 5 2021
Hi Johnny,
When I just commit via the instructions on our wiki, I just see this separate e-mail labeled "[Diffusion]" which looks like a separate review in Phabricator. When others push their changes, it appears attached to the original phabricator review, and seems to close it automagically. What am I missing there?
Feb 26 2021
Added masked to cons_text_c.
Feb 18 2021
Jan 29 2021
Jan 28 2021
Addressed Nawrin's comment fixes.
Jan 27 2021
LGTM
Jan 26 2021
LGTM
LGTM
Jan 22 2021
Jan 7 2021
Dec 17 2020
Dec 9 2020
Dec 1 2020
One missed change added.
Nov 30 2020
Build problems associated with target attribute for waitpkg should be fixed now. Please try the new diff.
Fixed build problems associated with target attribute for waitpkg.
Nov 16 2020
LGTM
Nov 10 2020
Oct 23 2019
LGTM
Aug 5 2019
Jul 22 2019
Jul 12 2019
Jul 10 2019
Jun 27 2019
Jun 18 2019
LGTM
Jun 17 2019
May 15 2019
LGTM!
Apr 23 2019
LGTM
Apr 8 2019
LGTM
*ping*
Apr 2 2019
LGTM