Page MenuHomePhabricator
People tlwilmar

tlwilmar (Terry Wilmarth)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2015, 1:32 PM (226 w, 4 d)

Recent Activity
View All

Mon, Aug 5

tlwilmar added a reviewer for D65714: Add support for libgomp's GOMP_*_nonmonotonic_* functions: jlpeyton.
Mon, Aug 5, 7:51 AM · Restricted Project, Restricted Project

Jul 22 2019

tlwilmar accepted rL366716: Delete empty file.

LGTM

Jul 22 2019, 11:23 AM

Jul 12 2019

tlwilmar added inline comments to D64534: Remove OMP spec versioning.
Jul 12 2019, 1:10 PM · Restricted Project, Restricted Project
tlwilmar added a comment to D64534: Remove OMP spec versioning.
In D64534#1582486, @Hahnfeld wrote:

@tlwilmar D64625 conflicts with moving the headers. Let me know if you want to land this first, but I'd like to get the fix into the next release which is set to branch next week.

Jul 12 2019, 5:29 AM · Restricted Project, Restricted Project

Jul 10 2019

tlwilmar created D64534: Remove OMP spec versioning.
Jul 10 2019, 2:47 PM · Restricted Project, Restricted Project

Jun 27 2019

tlwilmar created D63891: Cleanup of unused code.
Jun 27 2019, 1:05 PM · Restricted Project, Restricted Project

Jun 18 2019

tlwilmar accepted D62485: New implementation of OpenMP 5.0 detached tasks..

LGTM

Jun 18 2019, 1:21 PM · Restricted Project, Restricted Project

Jun 17 2019

tlwilmar added a reviewer for D63009: [OpenMP] Add target task alloc function with device ID: hbae.
Jun 17 2019, 11:48 AM · Restricted Project, Restricted Project, Restricted Project

May 15 2019

tlwilmar accepted D61944: Fixed https://bugs.llvm.org/show_bug.cgi?id=41584.

LGTM!

May 15 2019, 7:21 AM · Restricted Project

Apr 23 2019

tlwilmar accepted D60983: [OpenMP] Eliminate some compiler warnings.

LGTM

Apr 23 2019, 12:18 PM · Restricted Project, Restricted Project

Apr 8 2019

tlwilmar accepted D59783: [OpenMP] Implement 5.0 memory management.

LGTM

Apr 8 2019, 10:35 AM · Restricted Project
tlwilmar added a comment to D59508: Clean up load balancing dynamic mode.

*ping*

Apr 8 2019, 10:24 AM · Restricted Project, Restricted Project

Apr 2 2019

tlwilmar accepted D59801: [OpenMP][Stats] Fix stats gathering for distribute and team clause.

LGTM

Apr 2 2019, 1:01 PM · Restricted Project, Restricted Project

Mar 18 2019

tlwilmar updated the summary of D59508: Clean up load balancing dynamic mode.
Mar 18 2019, 1:24 PM · Restricted Project, Restricted Project
tlwilmar created D59508: Clean up load balancing dynamic mode.
Mar 18 2019, 1:17 PM · Restricted Project, Restricted Project

Mar 15 2019

tlwilmar created D59428: Fix pause check with version info.
Mar 15 2019, 12:38 PM · Restricted Project, Restricted Project
tlwilmar added a comment to D58989: Remove deprecated taskq.

*ping*

Mar 15 2019, 10:58 AM · Restricted Project, Restricted Project

Mar 5 2019

tlwilmar created D58989: Remove deprecated taskq.
Mar 5 2019, 12:12 PM · Restricted Project, Restricted Project

Feb 27 2019

tlwilmar added a comment to D58148: Make use of sched_yield optional in runtime.

*ping*

Feb 27 2019, 2:05 PM · Restricted Project
tlwilmar added a comment to D58408: [5.0] Deprecate nest-var and associated features.

*ping*

Feb 27 2019, 2:05 PM · Restricted Project, Restricted Project

Feb 26 2019

tlwilmar added a reviewer for D58148: Make use of sched_yield optional in runtime: hbae.
Feb 26 2019, 1:23 PM · Restricted Project

Feb 19 2019

tlwilmar created D58408: [5.0] Deprecate nest-var and associated features.
Feb 19 2019, 2:44 PM · Restricted Project, Restricted Project

Feb 13 2019

tlwilmar accepted D57969: [OpenMP] Adding GOMP compatible cancellation.

LGTM

Feb 13 2019, 2:59 PM · Restricted Project, Restricted Project
tlwilmar created D58211: [5.0] Add omp_get_supported_active_levels().
Feb 13 2019, 2:57 PM · Restricted Project, Restricted Project

Feb 12 2019

tlwilmar created D58148: Make use of sched_yield optional in runtime.
Feb 12 2019, 2:12 PM · Restricted Project

Feb 11 2019

tlwilmar updated the diff for D56804: Fix thread_limits to work properly for teams construct.

Fix update for non-CG_root threads in __kmp_free_thread.

Feb 11 2019, 10:44 AM · Restricted Project, Restricted Project

Feb 8 2019

tlwilmar added a comment to D56804: Fix thread_limits to work properly for teams construct.

I was going for the per-data-environment specification for the ICV, though I agree it is only needed per contention group. Is there any consensus on this? Leave as is, or remove per-data-environment ICV?

Feb 8 2019, 9:56 AM · Restricted Project, Restricted Project

Jan 16 2019

tlwilmar created D56804: Fix thread_limits to work properly for teams construct.
Jan 16 2019, 1:12 PM · Restricted Project, Restricted Project
tlwilmar updated the diff for D55078: Add omp_pause_resource* API.

Sorry Andrey -- I missed the Windows fix. Added now.

Jan 16 2019, 11:58 AM · Restricted Project

Jan 15 2019

tlwilmar updated the diff for D55078: Add omp_pause_resource* API.

Renamed parameters to match 5.0 spec. Added test.

Jan 15 2019, 12:51 PM · Restricted Project

Jan 2 2019

tlwilmar added a comment to D55578: Add omp_get_device_num() and update several other device API functions (FIXED).
In D55578#1343476, @protze.joachim wrote:

Is the intention to have this ready for the 8.0 release?

Jan 2 2019, 8:06 AM · Restricted Project

Dec 21 2018

tlwilmar accepted D55795: Fix for CMPLRS-48319 proc_bind affinity bug.

LGTM

Dec 21 2018, 11:54 AM · Restricted Project

Dec 18 2018

tlwilmar updated the diff for D55578: Add omp_get_device_num() and update several other device API functions (FIXED).

Tests added.

Dec 18 2018, 2:25 PM · Restricted Project

Dec 12 2018

tlwilmar added a comment to D55578: Add omp_get_device_num() and update several other device API functions (FIXED).
In D55578#1328082, @jcownie wrote:

Since you're using it twice already, is it worth abstracting the "find the appropriate function using dlsym" logic into a function?
I imagine that there will be other user-interface functions which will also need this, so abstracting it sooner rather than later seems a good thing to do.

Dec 12 2018, 10:38 AM · Restricted Project

Dec 11 2018

tlwilmar created D55578: Add omp_get_device_num() and update several other device API functions (FIXED).
Dec 11 2018, 2:13 PM · Restricted Project

Nov 29 2018

tlwilmar added a comment to D54342: Add omp_get_device_num() and update several other device API functions.
In D54342#1313542, @tlwilmar wrote:
In D54342#1313515, @gtbercea wrote:

After this patch, omp_get_num_devices() seems to wrongly return 0 even when devices are present.

OK, on my internal build these are showing up as weak symbols with nm. But on my LLVM build, not. Will look into the LLVM build to make sure it allows for weak attribute.

Nov 29 2018, 3:24 PM · Restricted Project
tlwilmar added a comment to D54342: Add omp_get_device_num() and update several other device API functions.
In D54342#1313515, @gtbercea wrote:

After this patch, omp_get_num_devices() seems to wrongly return 0 even when devices are present.

Nov 29 2018, 2:39 PM · Restricted Project
tlwilmar created D55078: Add omp_pause_resource* API.
Nov 29 2018, 2:16 PM · Restricted Project
tlwilmar added a comment to D54342: Add omp_get_device_num() and update several other device API functions.
In D54342#1313417, @ABataev wrote:

This commit conflicts with libomptarget. libomptarget have the same functions and the code may be confused during execution which version of the functions should be executed. This conflict should be resolved somehow. Before that, I think, this patch must be reverted.

Nov 29 2018, 1:55 PM · Restricted Project

Nov 28 2018

tlwilmar created D55026: Task Affinity API.
Nov 28 2018, 1:55 PM · Restricted Project

Nov 27 2018

tlwilmar accepted D54948: Minor cleanup of debug code.

LGTM

Nov 27 2018, 11:59 AM
tlwilmar accepted D54950: Fixed possible array out of bound access.

LGTM

Nov 27 2018, 11:58 AM

Nov 9 2018

tlwilmar created D54342: Add omp_get_device_num() and update several other device API functions.
Nov 9 2018, 12:12 PM · Restricted Project

Nov 6 2018

tlwilmar accepted D53380: Implementation of OpenMP 5.0 mutexinoutset task dependency type..

LGTM

Nov 6 2018, 2:15 PM

Oct 23 2018

tlwilmar added a reviewer for D53422: Support clang compiling under windows-gnu and windows-msvc: jlpeyton.
Oct 23 2018, 5:45 AM

Aug 6 2018

tlwilmar accepted D49105: [OpenMP] Cleanup code.

LGTM

Aug 6 2018, 1:41 PM · Restricted Project

Jul 26 2018

tlwilmar accepted D49857: [OpenMP] Implement GOMP doacross compatibility.

LGTM

Jul 26 2018, 11:56 AM · Restricted Project
tlwilmar accepted D49859: [OpenMP] Add GOMP version symbols for OMP_4.5 API.

LGTM

Jul 26 2018, 11:48 AM · Restricted Project
tlwilmar accepted D49823: [OpenMP] Fix build errors when building with KMP_DEBUG_ADAPTIVE_LOCKS=1.

LGTM

Jul 26 2018, 11:45 AM · Restricted Project
tlwilmar accepted D49699: [OpenMP][Stats] Cleanup stats gathering code.

LGTM

Jul 26 2018, 11:41 AM · Restricted Project

Apr 11 2018

tlwilmar accepted D45327: Introduce GOMP_taskloop API.

LGTM

Apr 11 2018, 1:13 PM · Restricted Project
tlwilmar accepted D45527: [OpenMP] Fix affinity API for KMP_AFFINITY=none|compact|scatter.

LGTM

Apr 11 2018, 12:43 PM · Restricted Project

Mar 26 2018

tlwilmar accepted D41838: Add summarizeStats.py to tools directory.

LGTM

Mar 26 2018, 11:41 AM · Restricted Project

Mar 22 2018

tlwilmar accepted D44793: Fixed __kmpc_get_target_offload() to call initialization..

LGTM

Mar 22 2018, 11:45 AM

Mar 19 2018

tlwilmar accepted D44637: Fix for https://bugs.llvm.org/show_bug.cgi?id=36705.

LGTM

Mar 19 2018, 11:02 AM

Mar 16 2018

tlwilmar added inline comments to D44577: Read OMP_TARGET_OFFLOAD and provide API to access ICV.
Mar 16 2018, 12:52 PM
tlwilmar created D44577: Read OMP_TARGET_OFFLOAD and provide API to access ICV.
Mar 16 2018, 12:49 PM
tlwilmar updated subscribers of D44522: [Libomptarget] Full implementation of the target-offload-icv.

We have a patch coming with libomp-side addition of OMP_TARGET_OFFLOAD envirable plus an internal API so that libomptarget can get the value from libomp. Would it help if we get this patch out faster?

Mar 16 2018, 8:20 AM · Restricted Project

Feb 14 2018

tlwilmar updated the diff for D41914: Improve threadprivate implementation.

Updated comment to be more general.

Feb 14 2018, 2:12 PM

Jan 10 2018

tlwilmar created D41914: Improve threadprivate implementation.
Jan 10 2018, 12:53 PM

Jan 9 2018

tlwilmar added inline comments to D41831: Minor code cleanup.
Jan 9 2018, 12:51 PM
tlwilmar added inline comments to D41831: Minor code cleanup.
Jan 9 2018, 12:15 PM

Jan 8 2018

tlwilmar created D41836: Simplify __kmp_expand_threads.
Jan 8 2018, 1:46 PM
tlwilmar created D41831: Minor code cleanup.
Jan 8 2018, 12:20 PM

Dec 4 2017

tlwilmar created D40804: Trivial enum fix.
Dec 4 2017, 1:51 PM

Nov 29 2017

tlwilmar accepted D40624: Eliminate double printing of verbose affinity settings.

LGTM

Nov 29 2017, 3:01 PM · Restricted Project
tlwilmar added reviewers for D40374: Make kmp_r_sched_t into a union: hbae, omalyshe.
Nov 29 2017, 2:28 PM

Nov 27 2017

tlwilmar accepted D40340: Warning is emitted when tiles are requested but cannot be used.

LGTM

Nov 27 2017, 11:38 AM

Nov 22 2017

tlwilmar created D40374: Make kmp_r_sched_t into a union.
Nov 22 2017, 1:27 PM

Aug 29 2017

tlwilmar created D37275: Minor code cleanup of Klocwork issues.
Aug 29 2017, 2:08 PM

Aug 10 2017

tlwilmar added a comment to D36510: OMP_PROC_BIND: better spread.
Aug 10 2017, 8:05 AM · Restricted Project
tlwilmar added a comment to D36510: OMP_PROC_BIND: better spread.

So I think in summary, what you are doing is creating the place partitions with the ceil(P/T)-sized partitions evenly spread amongst the floor(P/T) partitions (where P is num places and T is num_threads). Is that right?

Aug 10 2017, 7:45 AM · Restricted Project

Aug 9 2017

tlwilmar added a comment to D36510: OMP_PROC_BIND: better spread.

Hi Paul,
Can you be more specific about how this "improves the way threads are spread across cores"? The OMP spec is very specific on exactly how the spread algorithm should work.
Thanks!
Terry

Aug 9 2017, 10:50 AM · Restricted Project

Jul 28 2017

tlwilmar accepted D36017: Move lock acquire/release functions to safer locations in task deque cleanup code .

LGTM

Jul 28 2017, 2:13 PM
tlwilmar created D36011: Remove BUILD_TV.
Jul 28 2017, 12:11 PM
tlwilmar created D36009: Add new envirable KMP_TEAMS_THREAD_LIMIT.
Jul 28 2017, 11:28 AM

Jul 27 2017

tlwilmar updated the diff for D35912: Fix implementation of OMP_THREAD_LIMIT.

Added a test for OMP_THREAD_LIMIT env, api, and general functionality. Note that this test, when running correctly, will emit a Warning and a Hint, because the limit squashes the requested number of threads.

Jul 27 2017, 1:40 PM

Jul 26 2017

tlwilmar created D35912: Fix implementation of OMP_THREAD_LIMIT.
Jul 26 2017, 1:43 PM

Jul 25 2017

tlwilmar created D35860: Introduce KMP_DEVICE_THREAD_LIMIT.
Jul 25 2017, 3:18 PM

Jul 24 2017

tlwilmar created D35808: Cleanup: __kmp_env_* variables.
Jul 24 2017, 11:14 AM

Jul 18 2017

tlwilmar accepted D35490: Cleanup: two consecutive PAUSE instructions per spin loop iteration replaced with single one.

LGTM

Jul 18 2017, 12:17 PM · Restricted Project

Jul 17 2017

tlwilmar accepted D35273: Add recursive task scheduling strategy to taskloop implementation.

lgtm

Jul 17 2017, 10:19 AM

Jul 5 2017

tlwilmar accepted D35018: Address wrong website bug.

LGTM

Jul 5 2017, 1:11 PM
tlwilmar added a comment to D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG.
In D33227#792489, @sdmitriev wrote:
In D33227#769266, @tlwilmar wrote:

I don't think the environment variable should be named "OMP_TARGET_DEBUG" as that would suggest it is something coming from the OpenMP specification, which I don't believe it is. I'd suggest just keeping the LIBOMPTARGET_DEBUG name at all levels.

Terry, I have changed the environment variable name as you suggested. Do you have more comments for this patch?

Jul 5 2017, 11:23 AM · Restricted Project

Jun 13 2017

tlwilmar accepted D34154: Set affinity to none/false in child processes.

LGTM

Jun 13 2017, 10:33 AM

Jun 12 2017

tlwilmar accepted D34119: Replace platform macro with KMP_MIC_SUPPORTED.

LGTM

Jun 12 2017, 1:50 PM
tlwilmar accepted D34118: Reset initial affinity in children processes.

LGTM

Jun 12 2017, 1:48 PM

Jun 1 2017

tlwilmar created D33794: Fix static initializers for locks..
Jun 1 2017, 11:52 AM

May 31 2017

tlwilmar created D33744: Minor fixes: moved some code under debug, format improvements .
May 31 2017, 4:07 PM
tlwilmar added a comment to D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG.

Hmmm... that's disturbing.

May 31 2017, 2:37 PM · Restricted Project
tlwilmar added a reviewer for D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG: RaviNarayanaswamy.
May 31 2017, 2:25 PM · Restricted Project
tlwilmar requested changes to D33227: [OpenMP] libomptarget: move debugging dumps under control of environment variable OMP_TARGET_DEBUG.

I don't think the environment variable should be named "OMP_TARGET_DEBUG" as that would suggest it is something coming from the OpenMP specification, which I don't believe it is. I'd suggest just keeping the LIBOMPTARGET_DEBUG name at all levels.

May 31 2017, 2:21 PM · Restricted Project
tlwilmar accepted D33210: Address default pinning OpenMP process with multiple processor groups.

LGTM

May 31 2017, 1:17 PM
tlwilmar accepted D33208: Fix for KMP_AFFINITY=disabled and KMP_TOPOLOGY_METHOD=hwloc.

LGTM

May 31 2017, 1:16 PM

Apr 28 2017

tlwilmar added a reviewer for D32659: Clang-format and whitespace cleanup of source code: hfinkel.
Apr 28 2017, 1:36 PM
tlwilmar created D32659: Clang-format and whitespace cleanup of source code.
Apr 28 2017, 1:33 PM

Mar 3 2017

tlwilmar accepted D30450: OpenMP version 5.0 added.

LGTM

Mar 3 2017, 2:01 PM
tlwilmar accepted D30408: Mixed type atomic routines are missed from DLL (Windows).

LGTM

Mar 3 2017, 2:00 PM

Feb 1 2017

tlwilmar updated the diff for D28377: Fix a race in shutdown when tasking is used.

Jonas -- made the changes you requested (and removed second 'if' checking tasking mode).

Feb 1 2017, 10:56 AM

Jan 31 2017

tlwilmar updated the diff for D28377: Fix a race in shutdown when tasking is used.

Reap state does not need to be reset after each barrier. If thread attempts to execute tasks, it will be set to NOT SAFE to reap. It only matters in the spin at the fork barrier after shutdown is triggered. Master thread now waits for ALL threads to reach SAFE state before proceeding to clean anything up.

Jan 31 2017, 4:06 PM