Page MenuHomePhabricator

baziotis (Stefanos Baziotis)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2019, 1:37 PM (41 w, 7 h)

Recent Activity

Today

baziotis added a comment to D88183: [LoopInfo] Clarify header-loop relationship.

There are different definitions of loops. In the literature, such as a Dragon Book, a loop is identified by a backedge, but LLVM does it with its header. But only natural loops have a header: that is, not all cyclic control flow is represented by LoopInfo. Cyclic control flow that is is not form a natural loop is called irreducible control flow.

Anyway, using SCCs to stand for loops is bad as well since it ignores subloops. It should be a induced subgraph, not component. I think I raised this in the first review, but it was committed anyway. I'd be grateful if this could be cleaned up.

Thu, Sep 24, 1:05 PM · Restricted Project

Yesterday

baziotis requested review of D88183: [LoopInfo] Clarify header-loop relationship.
Wed, Sep 23, 2:22 PM · Restricted Project
baziotis committed rG7aa982a57ce0: [LoopTerminology][NFC] Fix formatting typo (authored by baziotis).
[LoopTerminology][NFC] Fix formatting typo
Wed, Sep 23, 12:54 PM

Tue, Sep 22

baziotis updated subscribers of D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

API changes may cause problems to other backends. It is a good idea to test -DLLVM_TARGETS_TO_BUILD=ALL

Tue, Sep 22, 5:16 PM · Restricted Project
baziotis committed rGa7873e5abc65: Small fixes for "[LoopInfo] empty() -> isInnermost(), add isOutermost()" (authored by baziotis).
Small fixes for "[LoopInfo] empty() -> isInnermost(), add isOutermost()"
Tue, Sep 22, 2:00 PM
baziotis committed rG89c1e35f3c50: [LoopInfo] empty() -> isInnermost(), add isOutermost() (authored by baziotis).
[LoopInfo] empty() -> isInnermost(), add isOutermost()
Tue, Sep 22, 1:29 PM
baziotis closed D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().
Tue, Sep 22, 1:29 PM · Restricted Project
baziotis added inline comments to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().
Tue, Sep 22, 11:23 AM · Restricted Project
baziotis updated the diff for D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

Address comments

Tue, Sep 22, 11:21 AM · Restricted Project

Sat, Sep 19

baziotis updated the diff for D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

@baziotis Are you going to update this diff?

Sat, Sep 19, 8:23 AM · Restricted Project

Fri, Aug 28

baziotis added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Fri, Aug 28, 1:07 PM · Restricted Project
baziotis added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Fri, Aug 28, 9:37 AM · Restricted Project
baziotis added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Fri, Aug 28, 8:48 AM · Restricted Project

Thu, Aug 27

baziotis added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Thu, Aug 27, 6:17 AM · Restricted Project
baziotis added inline comments to D86696: [Attributor][WIP] Introduce Loop AA.
Thu, Aug 27, 5:52 AM · Restricted Project

Jul 30 2020

baziotis added a comment to D84608: [LAA] Avoid adding pointers to the checks if they are not needed..

Thanks for taking a look @baziotis & @anemet !

Instead of accumulating in AccessInfos, couldn't we just reiterate the alias set (if we didn't bail out)?

Yes, I think either approach is fine. The current way avoids a few repeated lookups, but in the grand scheme of things I don't think it makes a big difference.

You mean in Accesses.. Well, since the iteration in an AliasSet is deterministic we could also only save the bools in a BitVector and both save memory and not do lookups. But never mind if you consider it overthinking / nitpicking.

Yeah, this code is very unlikely to be performance critical, so IMO we should try to make the code as straight-forward as possible. I think it would be good to stick with the version in the patch initially and potentially do follow-on improvements as follow-up patches.

Jul 30 2020, 7:40 AM · Restricted Project

Jul 28 2020

baziotis committed rGdb0d636e52c1: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in() (authored by baziotis).
[ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in()
Jul 28 2020, 6:52 PM
baziotis closed D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().
Jul 28 2020, 6:52 PM · Restricted Project
baziotis updated the diff for D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().
  • Added doc.
Jul 28 2020, 6:42 PM · Restricted Project
baziotis added a comment to D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().

LGTM

One proposal by a friend of mine, GeorgeLS, is that we can make a wrapper in which instead of passing a bool, we pass a BitWord.
And then we XOR with this BitWord every BitWord we read from Bits. So, the passed BitWord acts conditionally. If we want the "unset" version, we pass ~0.
If we want the "set" version, we pass 0.

An optimizing compiler might already do this if it thinks it is profitable. That is, InstCombine

if (!Set)
  Copy = ~Copy;

to

Mask = Set ? 0 : -1;
Copy ^= Mask;

and hoist Mask out of the loop.

However, unless you show that there is a relevant performance difference, I don't have a preference for either version.

Jul 28 2020, 6:32 PM · Restricted Project
baziotis added inline comments to D84733: [Attributor] Check nonnull attribute violation in AAUndefinedBehavior.
Jul 28 2020, 7:35 AM · Restricted Project
baziotis added inline comments to D84733: [Attributor] Check nonnull attribute violation in AAUndefinedBehavior.
Jul 28 2020, 6:55 AM · Restricted Project
baziotis added a comment to D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().

Please can you add unit test coverage at llvm/unittest/ADT/BitVectorTest.cpp

Jul 28 2020, 3:36 AM · Restricted Project
baziotis retitled D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in() from [ADT][BitVector] Merge find_first_in() / find_first_unset_in() to [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().
Jul 28 2020, 3:35 AM · Restricted Project
baziotis added a comment to D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().

One proposal by a friend of mine, GeorgeLS, is that we can make a wrapper in which instead of passing a bool, we pass a BitWord.
And then we XOR with this BitWord every BitWord we read from Bits. So, the passed BitWord acts conditionally. If we want the "unset" version, we pass ~0.
If we want the "set" version, we pass 0.

Jul 28 2020, 2:14 AM · Restricted Project
baziotis updated the diff for D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in().

Addressed comments.

Jul 28 2020, 1:50 AM · Restricted Project

Jul 27 2020

Herald added a project to D84717: [ADT][BitVector][NFC] Merge find_first_in() / find_first_unset_in(): Restricted Project.
Jul 27 2020, 5:47 PM · Restricted Project
baziotis added a comment to D84608: [LAA] Avoid adding pointers to the checks if they are not needed..

Apart from that, now that I'm seeing it again, in LAA, we probably want to move a lot of vectors out of loops and just reset() them.

Jul 27 2020, 1:52 PM · Restricted Project
baziotis added a comment to D84608: [LAA] Avoid adding pointers to the checks if they are not needed..

Instead of accumulating in AccessInfos, couldn't we just reiterate the alias set (if we didn't bail out)?

Yes, I think either approach is fine. The current way avoids a few repeated lookups, but in the grand scheme of things I don't think it makes a big difference.

Jul 27 2020, 1:47 PM · Restricted Project

Jul 26 2020

baziotis added a comment to D84608: [LAA] Avoid adding pointers to the checks if they are not needed..

Instead of accumulating in AccessInfos, couldn't we just reiterate the alias set (if we didn't bail out)?

Jul 26 2020, 3:55 PM · Restricted Project

Jul 17 2020

baziotis added inline comments to D83283: [Attributor] AAPotentialValues Interface.
Jul 17 2020, 5:15 AM · Restricted Project

Jul 14 2020

baziotis added a comment to D83283: [Attributor] AAPotentialValues Interface.

The code is quite good and clean. Most comments are on the doc so that we can make it good and clean too and move to the full patch.

Jul 14 2020, 3:09 AM · Restricted Project

Jul 13 2020

baziotis added a comment to D83283: [Attributor] AAPotentialValues Interface.

A nit comment is to please start comments with caps.

Jul 13 2020, 3:32 AM · Restricted Project

Jul 8 2020

baziotis added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

Hm, adding multiple ways to check the same thing may lead to other problems. IMO it will be more confusing if some places use !L->getParentLoop() and other L->isOutermost().

There are often multiple ways for the same goal, for instance LoadInst::getPointerOperand() and LoadInst::getOperand(0). One makes the intention clearer than the other.

Same for isInnerMost()/empty().

Since these are identical, I'd tend to remove one. In these case I'd remove empty() since Loop does not represent a container.

Jul 8 2020, 1:42 AM · Restricted Project

Jul 7 2020

baziotis added a comment to D83283: [Attributor] AAPotentialValues Interface.

Nit comments, I haven't yet digested the whole patch.

Jul 7 2020, 3:39 AM · Restricted Project
baziotis added a comment to D80991: [WIP][Attributor] AAPotentialValues Attribute.

First of all, great patch. Reading the description and the referenced diff, I can't find an explanation about what this patch tries to do, it would be good if you added that. My assumption is:

Jul 7 2020, 3:38 AM · Restricted Project

Jul 3 2020

baziotis added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

I partially agree but also IMHO empty() is confusing enough so that introducing isInnermost/Outermost has benefit that outweighs the cost. A Loop can contain both BBs and loops which is different than DominatorTree AFAIK (which can only contain BBs).
This is a big source of confusion when one comes across it in the code (and as I said, personally I assumed it had to do with the BBs).

Jul 3 2020, 3:44 AM · Restricted Project

Jul 2 2020

baziotis updated the diff for D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

Added isInnermost/Outermost.

Jul 2 2020, 5:17 PM · Restricted Project
baziotis added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

Thanks for the reviews, I'm updating.

Jul 2 2020, 4:46 PM · Restricted Project

Jun 30 2020

baziotis updated the diff for D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

Address comment.

Jun 30 2020, 12:29 PM · Restricted Project
baziotis added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

I created the review instead of just committing to discuss that it may be a good idea to even rename this e.g. to "isInnermost()".
With "empty()", it's not clear if the implementation is:
return getSubLoops().empty() or return !getNumBlocks() (or something else)

I think using empty makes sense in the context of begin() and end()

Jun 30 2020, 11:58 AM · Restricted Project
baziotis added a comment to D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().

I created the review instead of just committing to discuss that it may be a good idea to even rename this e.g. to "isInnermost()".
With "empty()", it's not clear if the implementation is:
return getSubLoops().empty() or return !getNumBlocks() (or something else)

Jun 30 2020, 11:24 AM · Restricted Project
baziotis created D82895: [LoopInfo] empty() -> isInnermost(), add isOutermost().
Jun 30 2020, 11:24 AM · Restricted Project

May 28 2020

baziotis added inline comments to D80552: [PrintSCC] Fix printing a basic-block without a name.
May 28 2020, 1:45 PM · Restricted Project

May 26 2020

baziotis committed rGef94f60ff795: [MSSA][Doc] Fix typo (authored by baziotis).
[MSSA][Doc] Fix typo
May 26 2020, 12:33 PM
baziotis committed rG2c7d63257d8e: [MSSA][Doc] Clobbers, more info on Defs / Def chain (authored by baziotis).
[MSSA][Doc] Clobbers, more info on Defs / Def chain
May 26 2020, 10:53 AM
baziotis closed D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.
May 26 2020, 10:53 AM · Restricted Project
baziotis added a comment to D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.

thanks for this!

if someone stamps with nits and you're confident that you've addressed the nits, feel free to commit :)

May 26 2020, 10:49 AM · Restricted Project

May 25 2020

baziotis added a comment to D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.

Ping :) Should I commit?

May 25 2020, 6:13 PM · Restricted Project

May 15 2020

baziotis updated the diff for D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.

Thanks for the comments!

May 15 2020, 4:19 PM · Restricted Project
baziotis added inline comments to D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.
May 15 2020, 5:53 AM · Restricted Project
baziotis created D80000: [MSSA] Doc: Clobbers, more info on Defs / Def chain.
May 15 2020, 5:53 AM · Restricted Project

Apr 11 2020

baziotis committed rG72ffeb2d38fb: [LoopTerminology] LCSSA: Fix typo in code sample (authored by baziotis).
[LoopTerminology] LCSSA: Fix typo in code sample
Apr 11 2020, 6:41 PM

Apr 4 2020

baziotis accepted D76873: [Attributor][NFC] Split AbstractAttribute subclasses out of Attributor.cpp.

I think we'll benefit from more structure and this is only one step in that direction. If there is no argument against I'd like to land this now as we have little attributor patches in the pipeline.

Apr 4 2020, 6:06 PM · Restricted Project
baziotis added a comment to rGf3dd3a66d3d5: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing….

Differential Review: https://reviews.llvm.org/D71960/

Apr 4 2020, 5:34 PM
baziotis closed D71960: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing instructions..

Closed by: https://reviews.llvm.org/rGf3dd3a66d3d5643a5e6f46bb18dee3be3a5898cd

Apr 4 2020, 5:34 PM · Restricted Project
baziotis committed rGf3dd3a66d3d5: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing… (authored by baziotis).
[Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing…
Apr 4 2020, 5:02 PM
baziotis updated the diff for D71960: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing instructions..
  • Final update
Apr 4 2020, 5:01 PM · Restricted Project
baziotis added a comment to D71960: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing instructions..

Committed but of course I forgot again to add the differential revision. I don't why I continuously do that, sorry. :)
I'll add it to the commit in Phabricator and close this when the commit is ready.

Apr 4 2020, 5:01 PM · Restricted Project

Apr 2 2020

baziotis committed rG8348e9d71b0a: [LoopTerminology] Make term names bold (authored by baziotis).
[LoopTerminology] Make term names bold
Apr 2 2020, 5:24 AM
baziotis closed D77151: [LoopTerminology] Make term names bold.
Apr 2 2020, 5:23 AM · Restricted Project
baziotis added a comment to D77151: [LoopTerminology] Make term names bold.

Ty

Apr 2 2020, 5:23 AM · Restricted Project

Mar 31 2020

baziotis created D77151: [LoopTerminology] Make term names bold.
Mar 31 2020, 9:57 AM · Restricted Project
baziotis committed rG229cda968cb2: [LoopTerminology] LCSSA form (authored by baziotis).
[LoopTerminology] LCSSA form
Mar 31 2020, 6:05 AM
baziotis closed D75233: [LoopTerminology] LCSSA Form.
Mar 31 2020, 6:04 AM · Restricted Project
baziotis added a comment to D75233: [LoopTerminology] LCSSA Form.

LGTM. Thanks for the effort!

No, problem, thanks for the review and the info!

Mar 31 2020, 5:32 AM · Restricted Project

Mar 30 2020

baziotis added a comment to D75405: [LSR] OptimizeShadowIV: Constant can be negative.

Ping.

Mar 30 2020, 4:57 PM · Restricted Project
baziotis updated the diff for D75233: [LoopTerminology] LCSSA Form.
  • Addressed SCEV behavior in loop-variant expressions.
Mar 30 2020, 6:27 AM · Restricted Project
baziotis added inline comments to D75233: [LoopTerminology] LCSSA Form.
Mar 30 2020, 5:55 AM · Restricted Project

Mar 29 2020

baziotis added a comment to D75233: [LoopTerminology] LCSSA Form.

Yes. Could you explain the part about dominator nodes ? I understand how dominators help in the identification
of loops and how dominance frontiers help in the placement of normal PHI nodes (i.e. when 2 or more paths converge). But I don't see how dominators
help with the placement of LCSSA phi nodes.

It is simple if the loop has just a single exit, but much more involved with multiple exits. Example CFG:

Header:
  %val = ...

Header->{Latch1,Latch2,Latch3}->Header

Header->Latch1->Exit1
Header->Latch2->Exit2
Header->Latch3->Exit3

Exit->Successor1

Successor1->SharedSucc
Exit2->SharedSucc

SharedSucc->CommonSucc
Exit3->CommonSucc

CommonSucc:
  use(%val)

Header dominates all other BBs in this example, hence without LCSSA, this is well-formed. However, with LCSSA we have to insert phis into Exit1,Exit2,Exit3 such that the end result has to look like:

Exit1:
  %lcssa1 = phi [%val, %Latch1]

Exit2:
  %lcssa2 = phi [%val, %Latch2]

Exit3:
  %lcssa3 = phi [%val, %Latch3]

SharedSucc:
  %sharedval = phi [%lcssa1 , %Exit1], [%lcssa2, %Exit2]

CommonSucc:
  %commonval = phi [%lcssa3 , %Exit3], [%sharedval , %SharedSucc]
  use(%commonval)

For computing %sharedval and %commonval, DominanceFrontier is needed again, hence LCSSA is not less complicated that SSA itself.

Mar 29 2020, 6:12 PM · Restricted Project
baziotis updated the diff for D75233: [LoopTerminology] LCSSA Form.
  • Various typos.
  • Added def-use chain info as a footnote since its used twice. Also a footnote about LCSSA construction (I consider it interesting but in a footnote because it may be irrelevant in the main text).
  • Added some info about SCEV.
Mar 29 2020, 6:12 PM · Restricted Project
baziotis added a comment to D76873: [Attributor][NFC] Split AbstractAttribute subclasses out of Attributor.cpp.

Personally I don't have problem with big files, sometimes they're more easy to use. But I definitely agree that we should start thinking about structure and splitting into files can help.

Mar 29 2020, 1:56 PM · Restricted Project

Mar 26 2020

baziotis added a comment to D75233: [LoopTerminology] LCSSA Form.

2 questions:

  1. Is it "loop closed PHI node" or "loop closing PHI node"?

Not being an expert of the English language, I;d say "loop-closing PHI node"

  1. Does LCSSA pass have to do this deep analysis? Because to me, it seems it can just use RAUW?

The most complicated thing is finding the dominator nodes to add the PHI nodes in (especially with multiple loop exits).

If possible, could you avoid "deep analysis", but instead refer the kind of analysis needed?

Mar 26 2020, 9:45 AM · Restricted Project

Mar 23 2020

baziotis committed rGa650d555fc21: [Attributor][NFC] Refactorings and typos in doc (authored by baziotis).
[Attributor][NFC] Refactorings and typos in doc
Mar 23 2020, 2:11 PM
baziotis closed D76175: [Attributor][NFC] Refactorings and typos in doc.
Mar 23 2020, 2:11 PM · Restricted Project
baziotis retitled D76175: [Attributor][NFC] Refactorings and typos in doc from [Attributor][NFC] Typos in doc to [Attributor][NFC] Refactorings and typos in doc.
Mar 23 2020, 10:21 AM · Restricted Project
baziotis added a comment to D76175: [Attributor][NFC] Refactorings and typos in doc.

Thanks to both!

Mar 23 2020, 10:21 AM · Restricted Project
baziotis accepted D76589: [Attributor][NFC] Use a BumpPtrAllocator to allocate `AbstractAttribute`s.

Seems reasonable.

Mar 23 2020, 7:36 AM · Restricted Project
baziotis added a comment to D76152: [LoopIdiom] memmove() on aliased pointers.

Ping. :)

Mar 23 2020, 7:36 AM · Restricted Project
baziotis added a comment to D75405: [LSR] OptimizeShadowIV: Constant can be negative.

Should I commit now?

Mar 23 2020, 7:36 AM · Restricted Project
baziotis added a comment to D76175: [Attributor][NFC] Refactorings and typos in doc.

Committing?

Mar 23 2020, 7:36 AM · Restricted Project
baziotis added a comment to D71960: [Attributor] AAUndefinedBehavior: Use AAValueSimplify in memory accessing instructions..

Can I get a look on this?

Mar 23 2020, 7:36 AM · Restricted Project

Mar 21 2020

baziotis added inline comments to D76208: [Attributor] Use AAValueConstantRange to infer dereferencability..
Mar 21 2020, 6:25 AM · Restricted Project

Mar 19 2020

baziotis updated the diff for D75233: [LoopTerminology] LCSSA Form.
  • Added other advantages.
  • Rephrased Chris's wording a little bit as it was not very clear to me. Also, the deep analysis, the more I thought of it and as @Meinersbur mentioned,

does not seem to be needed any way. We could use RAUW() to achieve this effect (although it would still be more expensive).

Mar 19 2020, 6:39 PM · Restricted Project
baziotis added inline comments to D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer.
Mar 19 2020, 6:07 PM · Restricted Project
baziotis added inline comments to D76378: [Attributor] Make use of analysis in the MustBeExecutedExplorer.
Mar 19 2020, 3:54 PM · Restricted Project

Mar 18 2020

baziotis added a comment to D75405: [LSR] OptimizeShadowIV: Constant can be negative.

Thanks, LGTM. Please wait 24 hours to give the others some more time to respond though.

Mar 18 2020, 3:13 AM · Restricted Project

Mar 17 2020

baziotis updated the diff for D75405: [LSR] OptimizeShadowIV: Constant can be negative.

Run update_test_checks.py over 2008-08-14-ShadowIV.ll. Added some CHECK-NOTs over it.

Mar 17 2020, 10:43 AM · Restricted Project

Mar 16 2020

baziotis committed rG3f3bda1c372f: [LoopTerminology] Minor fixes in loop rotation (authored by baziotis).
[LoopTerminology] Minor fixes in loop rotation
Mar 16 2020, 10:00 PM
baziotis added a comment to rG7fa204580dfe: [LoopTerminology] Rotated Loops.

Differential revision: https://reviews.llvm.org/D75013

Mar 16 2020, 4:57 PM
baziotis closed D75013: [LoopTerminology] Rotated Loops.

Closed by commit: https://reviews.llvm.org/rG7fa204580dfeb447f8da4d7da482c187b851914f

Mar 16 2020, 4:57 PM · Restricted Project
baziotis committed rG30dc342f084d: [LoopTerminology] Rotated Loops images (authored by baziotis).
[LoopTerminology] Rotated Loops images
Mar 16 2020, 4:25 PM
baziotis committed rG7fa204580dfe: [LoopTerminology] Rotated Loops (authored by baziotis).
[LoopTerminology] Rotated Loops
Mar 16 2020, 4:25 PM
baziotis added a comment to D75013: [LoopTerminology] Rotated Loops.

Fixed nits. Ready for commit.

Mar 16 2020, 4:24 PM · Restricted Project
baziotis updated the diff for D75013: [LoopTerminology] Rotated Loops.

Fixed nits. Ready for commit.

Mar 16 2020, 4:24 PM · Restricted Project
baziotis added a comment to D75013: [LoopTerminology] Rotated Loops.

My LGTM still stands.

Mar 16 2020, 3:51 PM · Restricted Project

Mar 15 2020

baziotis updated the diff for D76175: [Attributor][NFC] Refactorings and typos in doc.
  • Replacement of getAssociatedFunction() with getAnchorScope() where I think it's almost certain we want the parent function (we can revert that if you don't like it).
  • Other small refactorings.
Mar 15 2020, 6:24 AM · Restricted Project
baziotis added a comment to D76175: [Attributor][NFC] Refactorings and typos in doc.

sizeof(Kind + ArgNo) <= 64

Oh bytes, yes. With the change they will take 16 bytes (as now).

Mar 15 2020, 5:52 AM · Restricted Project

Mar 14 2020

baziotis added a comment to D76175: [Attributor][NFC] Refactorings and typos in doc.

Today I started reading through the whole Attributor, or at least its core parts, because I think otherwise I won't
have a good enough understanding to proceed. This is the start of a series of small patches that will mostly be NFC
improvements to docs with which I hope I'll have the opportunity to ask questions about different decisions in the Attributor.

Great! It's about time we give it a overhaul, a lot of the documentation is still from the very beginning as well. Feel free
to continue issuing design suggestions.

Mar 14 2020, 1:57 PM · Restricted Project
baziotis added a comment to D76175: [Attributor][NFC] Refactorings and typos in doc.

I kind of like how this is working, but if others agree you can change it.

Mar 14 2020, 10:43 AM · Restricted Project