This is a cleanup and normalization patch that also enables reuse with
Flang later on. A follow up will clean up and move the directive ->
clauses mapping.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks for doing this. I looked at all of it, and the changes seem to be you just moved things to llvm/Frontend, and fixed namespaces/includes to work correctly with the new location. Is there here anything else I am missing?
Not really. This moves the macros and the two helper functions (string -> enum, enum -> string) into lib/Frontend and adjusts everything to work again. No functional change was intended and no tests output changed.
Figured as much, just wanted to be sure. Anyways, this one also LGTM
I'll wait a couple of days in case any one has comments, if not I'll approve it
Reverted in 1858f4b50dd35c28b377ba5dbc572fed43a5d38a as some uses need fixing, didn't build clang-tidy locally apparently.
OK, As I said a few days ago, I went over the patch, and I didn't see any functional changes. I am accepting this patch.
Broke clang-tools-extra again: http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/46759/steps/build%20stage%201/logs/stdio
Fixed in 8ea07f62a6f06bdb7da981425227995423867a4d, I might have grabbed the wrong commit locally, apologies.