Page MenuHomePhabricator

LLD: Assign the stderrOS and stdoutOS globals to the new argument values, before using via enableColors.
ClosedPublic

Authored by jyknight on Nov 20 2019, 7:14 AM.

Diff Detail

Event Timeline

jyknight created this revision.Nov 20 2019, 7:14 AM
Herald added a project: Restricted Project. · View Herald Transcript
ruiu accepted this revision.Nov 20 2019, 8:20 PM

LGTM

lld/MinGW/Driver.cpp
167

enableColors is a singe-line function and doesn't seem to provide much value. Can you replace this with stderrOS.enable_colors(stderrOS.has_colors()) and remove enableColors function?

This revision is now accepted and ready to land.Nov 20 2019, 8:20 PM
This revision was automatically updated to reflect the committed changes.