This is an archive of the discontinued LLVM Phabricator instance.

Differential D151817

LoopVectorize: use [[fallthrough]] in one place
AbandonedPublic

Authored by artagnon on May 31 2023, 9:42 AM.

Details

Reviewers
fhahn
reames
Summary

Use [[fallthrough]] in place of the deprecated LLVM_FALLTHROUGH.

Diff Detail

Event Timeline

artagnon created this revision.May 31 2023, 9:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 9:42 AM
Herald added subscribers: shiva0217, StephenFan, hiraditya. · View Herald Transcript
artagnon requested review of this revision.May 31 2023, 9:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 9:42 AM
Herald added subscribers: llvm-commits, • pcwang-thead. · View Herald Transcript
Harbormaster completed remote builds in B235601: Diff 527091.May 31 2023, 9:43 AM
craig.topper added a subscriber: craig.topper.May 31 2023, 10:56 AM

I think I already got this with https://reviews.llvm.org/D150996

artagnon abandoned this revision.Jun 2 2023, 3:25 AM

Revision Contents

PathSize
llvm/
lib/
Transforms/
Vectorize/
2 lines

Diff 527091

llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,481 Lines • ▼ Show 20 Lines if (CM.isPredicatedInst(I)) {
ConstantInt::get(I->getType(), 1u, false)); ConstantInt::get(I->getType(), 1u, false));
auto *SafeRHS = auto *SafeRHS =
new VPInstruction(Instruction::Select, {Mask, Ops[1], One}, new VPInstruction(Instruction::Select, {Mask, Ops[1], One},
I->getDebugLoc()); I->getDebugLoc());
VPBB->appendRecipe(SafeRHS); VPBB->appendRecipe(SafeRHS);
Ops[1] = SafeRHS; Ops[1] = SafeRHS;
return new VPWidenRecipe(*I, make_range(Ops.begin(), Ops.end())); return new VPWidenRecipe(*I, make_range(Ops.begin(), Ops.end()));
} }
LLVM_FALLTHROUGH; [[fallthrough]];
} }
case Instruction::Add: case Instruction::Add:
case Instruction::And: case Instruction::And:
case Instruction::AShr: case Instruction::AShr:
case Instruction::FAdd: case Instruction::FAdd:
case Instruction::FCmp: case Instruction::FCmp:
case Instruction::FDiv: case Instruction::FDiv:
case Instruction::FMul: case Instruction::FMul:
▲ Show 20 Lines • Show All 2,126 Lines • Show Last 20 Lines